[Wikidata-bugs] [Maniphest] T312455: Migrate usage of Database::select to SelectQueryBuilder in PropertySuggester
Umherirrender closed this task as "Resolved". Umherirrender removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T312455 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Lucas_Werkmeister_WMDE, Aklapper, Maintenance_bot, Danny_Benjafield_WMDE, S8321414, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Dringsim, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Izno, Nastoshka, Wikidata-bugs, aude, Dinoguy1000, Sjoerddebruin, Mbch331, Jay8g, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 786, Biggs657, Juan90264, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, Maathavan, Neuronton ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T312455: Migrate usage of Database::select to SelectQueryBuilder in PropertySuggester
Umherirrender claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T312455 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Lucas_Werkmeister_WMDE, Aklapper, Maintenance_bot, Danny_Benjafield_WMDE, S8321414, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Dringsim, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Izno, Nastoshka, Wikidata-bugs, aude, Dinoguy1000, Sjoerddebruin, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T312462: Migrate usage of Database::select to SelectQueryBuilder in ArticlePlaceholder
Umherirrender closed this task as "Resolved". Umherirrender assigned this task to Lucas_Werkmeister_WMDE. Umherirrender added a comment. Done in f3ccb21b2d8b3ec0a8f9c65b68b141c3b34adf26 <https://phabricator.wikimedia.org/rEARPf3ccb21b2d8b3ec0a8f9c65b68b141c3b34adf26> TASK DETAIL https://phabricator.wikimedia.org/T312462 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Umherirrender Cc: Umherirrender, Maintenance_bot, Aklapper, darthmon_wmde, cmadeo, Izno, SBisson, Nastoshka, Wikidata-bugs, Dinoguy1000, jayvdb, Ricordisamoa, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T289046: Use core QueryBuilder for DB queries in Wikibase
Umherirrender closed this task as "Resolved". Umherirrender added a comment. Select queries are handled in other tasks, for example T312510: Migrate usage of Database::select to SelectQueryBuilder in Wikibase <https://phabricator.wikimedia.org/T312510> T312455: Migrate usage of Database::select to SelectQueryBuilder in PropertySuggester <https://phabricator.wikimedia.org/T312455> T312363: Migrate usage of Database::select to SelectQueryBuilder in WikibaseQualityConstraints <https://phabricator.wikimedia.org/T312363> TASK DETAIL https://phabricator.wikimedia.org/T289046 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Umherirrender, Lucas_Werkmeister_WMDE, Aklapper, Ladsgroup, Ullasoff, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, S8321414, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T360560: Make PHP 8.2 voting on development branch of Wikibase
Umherirrender removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T360560 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: karapayneWMDE, Aklapper, Michael, Novem_Linguae, Jdforrester-WMF, Danny_Benjafield_WMDE, S8321414, Astuthiodit_1, malberts, Invadibot, maantietaja, Peteosx1x, ItamarWMDE, Mgagat, Akuckartz, Totolinototo3, Zanziii, Sadisticturd, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, TK-999, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, hashar, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 786, Biggs657, Juan90264, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, Maathavan, Neuronton ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T360560: Make PHP 8.2 voting on development branch of Wikibase
Umherirrender added a comment. Also seen on ImageSuggestions - https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ImageSuggestions/+/1013222 (via CirrusSearch => WikibaseCirrusSearch => Wikibase) And Score - https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Score/+/1013651 (directly Wikibase dependency) TASK DETAIL https://phabricator.wikimedia.org/T360560 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Umherirrender, Aklapper, Michael, Novem_Linguae, Jdforrester-WMF, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, S8321414, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, malberts, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Peteosx1x, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Mgagat, Akuckartz, Totolinototo3, Hook696, Kent7301, Zanziii, Sadisticturd, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, TK-999, QZanden, KimKelting, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331, hashar ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T360560: Make PHP 8.2 voting on development branch of Wikibase
Umherirrender added a comment. GrowthExperiments is affected and tests fails (see T360826 <https://phabricator.wikimedia.org/T360826>) Score is affected and tests fails TASK DETAIL https://phabricator.wikimedia.org/T360560 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Umherirrender, Aklapper, Michael, Novem_Linguae, Jdforrester-WMF, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, malberts, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Peteosx1x, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Mgagat, Akuckartz, Totolinototo3, Hook696, Kent7301, Zanziii, Sadisticturd, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, TK-999, QZanden, KimKelting, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331, hashar ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T360826: Wikibase blocks merges to GrowthExperiments
Umherirrender added subscribers: Jdforrester-WMF, Umherirrender. Umherirrender added a comment. Related: T360560: Make PHP 8.2 voting on development branch of Wikibase <https://phabricator.wikimedia.org/T360560> TASK DETAIL https://phabricator.wikimedia.org/T360826 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Umherirrender, Jdforrester-WMF, Urbanecm_WMF, Aklapper, Danny_Benjafield_WMDE, Astuthiodit_1, Sgs, karapayneWMDE, Invadibot, caldera, maantietaja, NavinRizwi, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Nattes, QZanden, KimKelting, LawExplorer, Iniquity, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Wikidata-bugs, aude, geraki, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T283198: Database deadlock in Wikibase\Lib\Store\Sql\Terms\Util\ReplicaMasterAwareRecordIdsAcquirer::insertNonExistingRecordsIntoMaster query
Umherirrender added a comment. As the data stored in the database are from parsing a page (via SecondaryDataUpdates), the fixes for T355877: [CLIENT] Investigate potential references to wrong ParserOutput in WikibaseClient code <https://phabricator.wikimedia.org/T355877> could be fix this as well. TASK DETAIL https://phabricator.wikimedia.org/T283198 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Umherirrender, Michael, Lucas_Werkmeister_WMDE, Aklapper, thcipriani, Ullasoff, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, darthmon_wmde, Rosalie_WMDE, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Verdy_p, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T358325: Unsuppress Phan issues MediaWikiNoBaseException and MediaWikiNoEmptyIfDefined in Wikibase
Umherirrender closed this task as "Resolved". Umherirrender claimed this task. Umherirrender updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T358325 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Lucas_Werkmeister_WMDE, Aklapper, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Izno, Nastoshka, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T353161: Creation of dynamic property MediaWiki\Title\Title::$wikibasePushedDeleteToRepo is deprecated
Umherirrender added a comment. In T353161#9523476 <https://phabricator.wikimedia.org/T353161#9523476>, @cscott wrote: > This dynamic property is causing spurious failures in phan as well, when phan randomly "gets smart enough" to notice that the Title class doesn't actually have a property named `wikibasePushedDeleteToRepo`. See https://integration.wikimedia.org/ci/job/mwext-php74-phan-docker/96606/console for example. With the remove of the `DeprecationHelper` trait in 7fc8d800b78e4d3d49cdadc686310485607072fe <https://phabricator.wikimedia.org/rMW7fc8d800b78e4d3d49cdadc686310485607072fe> there is no `Title::__set` or `Title::__get` and phan is now strict about the undeclared properties resulting in this report (Before phan could not infer the result of __set/__get to report every undeclared property directly). It should not be randomly, that mostly seen in the context of taint-check, where the order of class loading can impact the result. TASK DETAIL https://phabricator.wikimedia.org/T353161 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Jakob_WMDE, cscott, Lucas_Werkmeister_WMDE, Umherirrender, Aklapper, Danny_Benjafield_WMDE, Astuthiodit_1, malberts, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, TK-999, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T342517: [WD-ORG] Remove unnecessary targets definitions - wikidata
Umherirrender closed this task as "Resolved". Umherirrender assigned this task to Jdforrester-WMF. Umherirrender added a comment. Done via 635c04ecfcf62899039c6687fb4e8d650eff41a3 <https://phabricator.wikimedia.org/rEWOR635c04ecfcf62899039c6687fb4e8d650eff41a3> TASK DETAIL https://phabricator.wikimedia.org/T342517 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdforrester-WMF, Umherirrender Cc: Umherirrender, Aklapper, karapayneWMDE, Danny_Benjafield_WMDE, Astuthiodit_1, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T353184: Creation of dynamic property Wikibase\Lib\Store\EntityRevision::$user is deprecated
Umherirrender closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T353184 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Lucas_Werkmeister_WMDE, Aklapper, Umherirrender, Danny_Benjafield_WMDE, Astuthiodit_1, malberts, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, TK-999, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T353184: Creation of dynamic property Wikibase\Lib\Store\EntityRevision::$user is deprecated
Umherirrender claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T353184 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Lucas_Werkmeister_WMDE, Aklapper, Umherirrender, Danny_Benjafield_WMDE, Astuthiodit_1, malberts, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, TK-999, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T353184: Creation of dynamic property Wikibase\Lib\Store\EntityRevision::$user is deprecated
Umherirrender created this task.
Umherirrender added projects: MediaWiki-extensions-WikibaseRepository, PHP 8.2
support.
Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION
phpunit under php8.2 fails with the following message
https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php82-noselenium-docker/151/console
41) Wikibase\Lib\Tests\MockRepositoryTest::testSaveEntity with data set
"fresh" (Wikibase\DataModel\Entity\Item Object (...), 1, false)
Creation of dynamic property Wikibase\Lib\Store\EntityRevision::$user is
deprecated
/workspace/src/extensions/Wikibase/lib/tests/phpunit/MockRepository.php:263
/workspace/src/extensions/Wikibase/lib/tests/phpunit/MockRepository.php:486
/workspace/src/extensions/Wikibase/lib/tests/phpunit/MockRepositoryTest.php:447
42) Wikibase\Lib\Tests\MockRepositoryTest::testSaveEntity with data set
"update" (Wikibase\DataModel\Entity\Item Object (...), 2, 1011)
Creation of dynamic property Wikibase\Lib\Store\EntityRevision::$user is
deprecated
/workspace/src/extensions/Wikibase/lib/tests/phpunit/MockRepository.php:263
/workspace/src/extensions/Wikibase/lib/tests/phpunit/MockRepository.php:486
/workspace/src/extensions/Wikibase/lib/tests/phpunit/MockRepositoryTest.php:447
43) Wikibase\Lib\Tests\MockRepositoryTest::testUpdateWatchlist
Creation of dynamic property Wikibase\Lib\Store\EntityRevision::$user is
deprecated
/workspace/src/extensions/Wikibase/lib/tests/phpunit/MockRepository.php:263
/workspace/src/extensions/Wikibase/lib/tests/phpunit/MockRepository.php:486
/workspace/src/extensions/Wikibase/lib/tests/phpunit/MockRepositoryTest.php:585
44) Wikibase\Lib\Tests\MockRepositoryTest::testUserWasLastToEdit
Creation of dynamic property Wikibase\Lib\Store\EntityRevision::$user is
deprecated
/workspace/src/extensions/Wikibase/lib/tests/phpunit/MockRepository.php:263
/workspace/src/extensions/Wikibase/lib/tests/phpunit/MockRepository.php:486
/workspace/src/extensions/Wikibase/lib/tests/phpunit/MockRepositoryTest.php:602
The code is:
$revision = new EntityRevision(
$entity->copy(), // note: always clone
$revisionId,
wfTimestamp( TS_MW, $timestamp )
);
if ( $user !== null ) {
if ( $user instanceof UserIdentity ) {
$user = $user->getName();
}
// just glue the user on here...
$revision->user = $user;
}
Not sure why it was added in 58d27b73c6fbaf99ba8e51b98f1c7837046ff723
<https://phabricator.wikimedia.org/rEWBA58d27b73c6fbaf99ba8e51b98f1c7837046ff723>,
it seems the property never exists on the EntityRevision
TASK DETAIL
https://phabricator.wikimedia.org/T353184
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Umherirrender
Cc: Aklapper, Umherirrender, malberts, ItamarWMDE, Akuckartz, lucamauri, Gq86,
TK-999, Wikidata-bugs, Jdforrester-WMF
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T353161: Creation of dynamic property MediaWiki\Title\Title::$wikibasePushedDeleteToRepo is deprecated
Umherirrender created this task. Umherirrender added projects: PHP 8.2 support, MediaWiki-extensions-WikibaseRepository. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Seen on phpunit tests under php8.2 https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php82-noselenium-docker/130/consoleFull > PHP Deprecated: Creation of dynamic property MediaWiki\Title\Title::$wikibasePushedDeleteToRepo is deprecated in /workspace/src/includes/debug/DeprecationHelper.php on line 243 https://codesearch.wmcloud.org/search/?q=wikibasePushedDeleteToRepo=== TASK DETAIL https://phabricator.wikimedia.org/T353161 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Umherirrender, Aklapper, malberts, ItamarWMDE, Akuckartz, lucamauri, Gq86, TK-999, Wikidata-bugs, Jdforrester-WMF ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T326297: Incorrect use of plural with 0 in MediaWiki:Wikibase-statementview-references-counter/sl
Umherirrender removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T326297 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: jhsoby, Lucas_Werkmeister_WMDE, Aklapper, TadejM, Danny_Benjafield_WMDE, Astuthiodit_1, MaryMunyoki, Prufkick, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, srishakatux, LawExplorer, _jensen, rosalieper, Scott_WUaS, Srdjan, MuhammadShuaib, LNDDYL, Psychoslave, Wikidata-bugs, aude, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 786, Biggs657, Juan90264, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, Maathavan, Neuronton ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T348665: Translatable edit summary comments not displaying on Special:NewPages
Umherirrender added a comment. In T348665#9247479 <https://phabricator.wikimedia.org/T348665#9247479>, @Umherirrender wrote: > In case of Wikibase there is no problem with that and I also see no problem for other usages on the hook (The title was added the first time in a44edf4a712ddac24dc4f58f7029febffaee3d3a <https://phabricator.wikimedia.org/rMWa44edf4a712ddac24dc4f58f7029febffaee3d3a>). I have found a (relevant) use case and uploaded a patch set for it. TASK DETAIL https://phabricator.wikimedia.org/T348665 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Umherirrender Cc: Lucas_Werkmeister_WMDE, Umherirrender, tstarling, Aklapper, Mahir256, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, Susie413113, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T348665: Translatable edit summary comments not displaying on Special:NewPages
Umherirrender closed this task as "Resolved". Umherirrender added a comment. Thanks for the fix, the call to `RevisionRecord::getPageAsLinkTarget` is a bit depther in the stack. The title provided to the `RevisionRecord` in the old code was created by `Title::newFromRow`, that function is using columns `page_namespace` and `page_title` from the database result. The fix is using `rc_namespace` and `rc_title`. In the most cases both are identically, only on page moves both could be differ. In case of Wikibase there is no problem with that and I also see no problem for other usages on the hook (The title was added the first time in a44edf4a712ddac24dc4f58f7029febffaee3d3a <https://phabricator.wikimedia.org/rMWa44edf4a712ddac24dc4f58f7029febffaee3d3a>). TASK DETAIL https://phabricator.wikimedia.org/T348665 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Umherirrender Cc: Lucas_Werkmeister_WMDE, Umherirrender, tstarling, Aklapper, Mahir256, Danny_Benjafield_WMDE, Astuthiodit_1, Susie413113, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T346518: Update WikibaseCirrusSearch to use the new HookContainer/HookRunner system
Umherirrender updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T346518 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Umherirrender, Aklapper, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, gonzalez.actor, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Wilmanbeno, Juan90264, Naike, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, apaskulin, Hook696, Kent7301, joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, EBjune, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Agabi10, Neuronton, Scott_WUaS, Wikidata-bugs, aude, jayvdb, Mbch331, jeremyb ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T346519: Update WikibaseQualityConstraints to use the new HookContainer/HookRunner system
Umherirrender added a comment. In T346519#9182060 <https://phabricator.wikimedia.org/T346519#9182060>, @Lucas_Werkmeister_WMDE wrote: >> Use hook handlers for Wikibase hooks (T338452 <https://phabricator.wikimedia.org/T338452>) - (this point is stalled, hook interface are not implement yet) > > That doesn’t block migrating the hook handlers from static methods to classes with ObjectFactory specs – the classes just don’t have an interface to implement yet. > > Also, the task description of T338452 <https://phabricator.wikimedia.org/T338452> sounds like it’s only for migrating the hook handlers Wikibase registers (for hooks from core or other extensions), which IMHO is quite separate from how Wikibase fires its own hooks. Technically the hook interfaces are not needed to use `HookHandlers` as the called method is build up by the hook name and not by the interface name, but the interfaces providing good documentation about types and arguments. Applying this along with the conversion brings better quality by using static analyzers and avoids later work to add them, which could be missed because it already works as is. The tasks about "new HookContainer/HookRunner" (including the #epic <https://phabricator.wikimedia.org/tag/epic/> parent task T263353 <https://phabricator.wikimedia.org/T263353>) are for both things of the new hook system, that includes the hook interfaces with the HookRunner to fire own hooks and to use the hook interfaces in the hook handlers by the called code. TASK DETAIL https://phabricator.wikimedia.org/T346519 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Lucas_Werkmeister_WMDE, Aklapper, Umherirrender, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Naike, ItamarWMDE, Akuckartz, apaskulin, Eihel, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, Esc3300, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, abian, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T338452: Update Wikibase to use the new HookContainer/HookRunner system
Umherirrender added a comment. In T338452#8913695 <https://phabricator.wikimedia.org/T338452#8913695>, @Lucas_Werkmeister_WMDE wrote: > This should probably be a Wikibase ADR <https://doc.wikimedia.org/Wikibase/master/php/docs_adr_index.html>, though I’m not sure which team at WMDE is responsible for it (probably #wikibase_product_platform <https://phabricator.wikimedia.org/tag/wikibase_product_platform_team_wpp/>?). Does this apply to Wikibase only? Or also for other deployed extensions from the eco system? Extensions like: - ArticlePlaceholder (T346514 <https://phabricator.wikimedia.org/T346514>) - WikibaseCirrusSearch (T346518 <https://phabricator.wikimedia.org/T346518>) - WikibaseLexeme (T346516 <https://phabricator.wikimedia.org/T346516>) - WikibaseLexemeCirrusSearch (T346517 <https://phabricator.wikimedia.org/T346517>) - WikibaseMediaInfo (T338456 <https://phabricator.wikimedia.org/T338456>) - WikibaseQualityConstraints (T346519 <https://phabricator.wikimedia.org/T346519>) - WikimediaBadges (T346505 <https://phabricator.wikimedia.org/T346505>) In T338452#9214371 <https://phabricator.wikimedia.org/T338452#9214371>, @Lucas_Werkmeister_WMDE wrote: > I still think this task should have a decision by Wikibase developers. What the task //doesn’t// need is untested and broken patches (T347818 <https://phabricator.wikimedia.org/T347818>) that are uploaded on a Sunday evening and merged less than two hours later, thus ensuring that no WMDE developer can possibly review them in time. (The brokenness of the `MaintenanceShellStart` patch would’ve been quite easily testable by a developer who knew what the hook does – just pop open a maintenance shell.) Wikibase already uses `HookHandlers`, I was not aware that converting already-existing handlers to use this function is also covered by that. TASK DETAIL https://phabricator.wikimedia.org/T338452 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Umherirrender, DannyS712, WMDE-leszek, Lucas_Werkmeister_WMDE, Aklapper, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Naike, ItamarWMDE, Akuckartz, apaskulin, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T338452: Update Wikibase to use the new HookContainer/HookRunner system
Umherirrender updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T338452 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Aklapper, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Naike, ItamarWMDE, Akuckartz, apaskulin, DannyS712, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T346514: Update ArticlePlaceholder to use the new HookContainer/HookRunner system
Umherirrender removed Umherirrender as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T346514 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Aklapper, Umherirrender, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Naike, ItamarWMDE, Akuckartz, apaskulin, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, cmadeo, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Wikidata-bugs, aude, jayvdb, Ricordisamoa, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T346520: Update Wikidata.org to use the new HookContainer/HookRunner system
Umherirrender closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T346520 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Michael, Aklapper, Umherirrender, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Naike, ItamarWMDE, Akuckartz, apaskulin, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T346518: Update WikibaseCirrusSearch to use the new HookContainer/HookRunner system
Umherirrender removed Umherirrender as the assignee of this task. Umherirrender removed a project: Patch-For-Review. Umherirrender updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T346518 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Umherirrender, Aklapper, Danny_Benjafield_WMDE, gonzalez.actor, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Wilmanbeno, Naike, ItamarWMDE, Akuckartz, apaskulin, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Wikidata-bugs, aude, jayvdb, Mbch331, jeremyb, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 786, Biggs657, Juan90264, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, Maathavan, Neuronton ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T346517: Update WikibaseLexemeCirrusSearch to use the new HookContainer/HookRunner system
Umherirrender removed Umherirrender as the assignee of this task. Umherirrender removed a project: Patch-For-Review. Umherirrender updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T346517 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Umherirrender, Aklapper, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Naike, ItamarWMDE, Akuckartz, apaskulin, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 786, Biggs657, Juan90264, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, Maathavan, Neuronton ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T346514: Update ArticlePlaceholder to use the new HookContainer/HookRunner system
Umherirrender updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T346514 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Aklapper, Umherirrender, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Naike, ItamarWMDE, Akuckartz, apaskulin, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, cmadeo, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Wikidata-bugs, aude, jayvdb, Ricordisamoa, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T346519: Update WikibaseQualityConstraints to use the new HookContainer/HookRunner system
Umherirrender removed Umherirrender as the assignee of this task. Umherirrender updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T346519 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Lucas_Werkmeister_WMDE, Aklapper, Umherirrender, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Naike, ItamarWMDE, Akuckartz, apaskulin, Eihel, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, Esc3300, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, abian, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T346516: Update WikibaseLexeme to use the new HookContainer/HookRunner system
Umherirrender removed Umherirrender as the assignee of this task. Umherirrender updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T346516 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Umherirrender, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Naike, ItamarWMDE, Akuckartz, apaskulin, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T346557: Update PropertySuggester to use the new HookContainer/HookRunner system
Umherirrender closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T346557 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Aklapper, Umherirrender, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Naike, ItamarWMDE, Akuckartz, apaskulin, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Wikidata-bugs, aude, Sjoerddebruin, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T346518: Update WikibaseCirrusSearch to use the new HookContainer/HookRunner system
Umherirrender claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T346518 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Umherirrender, Aklapper, Danny_Benjafield_WMDE, gonzalez.actor, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Wilmanbeno, Naike, ItamarWMDE, Akuckartz, apaskulin, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Wikidata-bugs, aude, jayvdb, Mbch331, jeremyb ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T346516: Update WikibaseLexeme to use the new HookContainer/HookRunner system
Umherirrender claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T346516 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Umherirrender, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Naike, ItamarWMDE, Akuckartz, apaskulin, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T346519: Update WikibaseQualityConstraints to use the new HookContainer/HookRunner system
Umherirrender claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T346519 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Lucas_Werkmeister_WMDE, Aklapper, Umherirrender, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Naike, ItamarWMDE, Akuckartz, apaskulin, Eihel, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, Esc3300, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, abian, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T346517: Update WikibaseLexemeCirrusSearch to use the new HookContainer/HookRunner system
Umherirrender claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T346517 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Umherirrender, Aklapper, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Naike, ItamarWMDE, Akuckartz, apaskulin, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T346520: Update Wikidata.org to use the new HookContainer/HookRunner system
Umherirrender claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T346520 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Michael, Aklapper, Umherirrender, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Naike, ItamarWMDE, Akuckartz, apaskulin, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T346514: Update ArticlePlaceholder to use the new HookContainer/HookRunner system
Umherirrender claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T346514 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Aklapper, Umherirrender, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Naike, ItamarWMDE, Akuckartz, apaskulin, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, cmadeo, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Wikidata-bugs, aude, jayvdb, Ricordisamoa, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T346557: Update PropertySuggester to use the new HookContainer/HookRunner system
Umherirrender claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T346557 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Aklapper, Umherirrender, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Naike, ItamarWMDE, Akuckartz, apaskulin, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Wikidata-bugs, aude, Sjoerddebruin, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T346533: Update Cognate to use the new HookContainer/HookRunner system
Umherirrender closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T346533 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Aklapper, Umherirrender, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Naike, ItamarWMDE, Akuckartz, apaskulin, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Thibaut120094, Wikidata-bugs, aude, Lydia_Pintscher, Darkdadaah, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T346533: Update Cognate to use the new HookContainer/HookRunner system
Umherirrender claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T346533 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Aklapper, Umherirrender, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Naike, ItamarWMDE, Akuckartz, apaskulin, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Thibaut120094, Wikidata-bugs, aude, Lydia_Pintscher, Darkdadaah, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T346487: Update EntitySchema to use the new HookContainer/HookRunner system
Umherirrender closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T346487 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Aklapper, Umherirrender, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Naike, ItamarWMDE, Akuckartz, apaskulin, pdehaye, DannyS712, Nandana, Lahi, Gq86, Andrawaag, GoranSMilovanovic, QZanden, YULdigitalpreservation, LawExplorer, Salgo60, _jensen, rosalieper, Agabi10, Scott_WUaS, MisterSynergy, abian, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T346519: Update WikibaseQualityConstraints to use the new HookContainer/HookRunner system
Umherirrender updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T346519 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Aklapper, Umherirrender, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Naike, ItamarWMDE, Akuckartz, apaskulin, Eihel, DannyS712, Nandana, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, Esc3300, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, abian, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T346516: Update WikibaseLexeme to use the new HookContainer/HookRunner system
Umherirrender updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T346516 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Umherirrender, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Naike, ItamarWMDE, Akuckartz, apaskulin, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T346517: Update WikibaseLexemeCirrusSearch to use the new HookContainer/HookRunner system
Umherirrender updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T346517 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Umherirrender, Aklapper, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Naike, ItamarWMDE, Akuckartz, apaskulin, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T346518: Update WikibaseCirrusSearch to use the new HookContainer/HookRunner system
Umherirrender updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T346518 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Umherirrender, Aklapper, Danny_Benjafield_WMDE, gonzalez.actor, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Wilmanbeno, Naike, ItamarWMDE, Akuckartz, apaskulin, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Wikidata-bugs, aude, jayvdb, Mbch331, jeremyb ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T346557: Update PropertySuggester to use the new HookContainer/HookRunner system
Umherirrender added a parent task: T263353: Update all Wikimedia production extensions to use the new HookContainer/HookRunner system. TASK DETAIL https://phabricator.wikimedia.org/T346557 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Aklapper, Umherirrender, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Naike, ItamarWMDE, Akuckartz, apaskulin, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Wikidata-bugs, aude, Sjoerddebruin, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T346557: Update PropertySuggester to use the new HookContainer/HookRunner system
Umherirrender created this task. Umherirrender added projects: MediaWiki-extensions-PropertySuggester, Platform Team Initiatives (New Hook System), Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Implement the Hook system added in MediaWiki 1.35 in the extensions, see Hooks.md <https://phabricator.wikimedia.org/source/mediawiki/browse/master/docs/Hooks.md> for documentation. Use hook handlers for core hooks. TASK DETAIL https://phabricator.wikimedia.org/T346557 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Aklapper, Umherirrender, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Naike, ItamarWMDE, Akuckartz, apaskulin, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Wikidata-bugs, aude, Sjoerddebruin, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T346514: Update ArticlePlaceholder to use the new HookContainer/HookRunner system
Umherirrender added a parent task: T263353: Update all Wikimedia production extensions to use the new HookContainer/HookRunner system. TASK DETAIL https://phabricator.wikimedia.org/T346514 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Aklapper, Umherirrender, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Naike, ItamarWMDE, Akuckartz, apaskulin, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, cmadeo, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Wikidata-bugs, aude, jayvdb, Ricordisamoa, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T346516: Update WikibaseLexeme to use the new HookContainer/HookRunner system
Umherirrender added a parent task: T263353: Update all Wikimedia production extensions to use the new HookContainer/HookRunner system. TASK DETAIL https://phabricator.wikimedia.org/T346516 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Umherirrender, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Naike, ItamarWMDE, Akuckartz, apaskulin, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T346517: Update WikibaseLexemeCirrusSearch to use the new HookContainer/HookRunner system
Umherirrender added a parent task: T263353: Update all Wikimedia production extensions to use the new HookContainer/HookRunner system. TASK DETAIL https://phabricator.wikimedia.org/T346517 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Umherirrender, Aklapper, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Naike, ItamarWMDE, Akuckartz, apaskulin, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T346518: Update WikibaseCirrusSearch to use the new HookContainer/HookRunner system
Umherirrender added a parent task: T263353: Update all Wikimedia production extensions to use the new HookContainer/HookRunner system. TASK DETAIL https://phabricator.wikimedia.org/T346518 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Umherirrender, Aklapper, Danny_Benjafield_WMDE, gonzalez.actor, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Wilmanbeno, Naike, ItamarWMDE, Akuckartz, apaskulin, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Wikidata-bugs, aude, jayvdb, Mbch331, jeremyb ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T346519: Update WikibaseQualityConstraints to use the new HookContainer/HookRunner system
Umherirrender added a parent task: T263353: Update all Wikimedia production extensions to use the new HookContainer/HookRunner system. TASK DETAIL https://phabricator.wikimedia.org/T346519 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Aklapper, Umherirrender, Naike, apaskulin, Eihel, DannyS712, Lucas_Werkmeister_WMDE, Esc3300, Agabi10, abian, Wikidata-bugs ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T346520: Update Wikidata.org to use the new HookContainer/HookRunner system
Umherirrender added a parent task: T263353: Update all Wikimedia production extensions to use the new HookContainer/HookRunner system. TASK DETAIL https://phabricator.wikimedia.org/T346520 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Aklapper, Umherirrender, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Naike, ItamarWMDE, Akuckartz, apaskulin, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T346520: Update Wikidata.org to use the new HookContainer/HookRunner system
Umherirrender created this task. Umherirrender added projects: Wikidata.org, Platform Team Initiatives (New Hook System), Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Implement the Hook system added in MediaWiki 1.35 in the extensions, see Hooks.md <https://phabricator.wikimedia.org/source/mediawiki/browse/master/docs/Hooks.md> for documentation. Use hook handlers for core hooks. TASK DETAIL https://phabricator.wikimedia.org/T346520 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Aklapper, Umherirrender, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Naike, ItamarWMDE, Akuckartz, apaskulin, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T346519: Update WikibaseQualityConstraints to use the new HookContainer/HookRunner system
Umherirrender created this task. Umherirrender added projects: Wikibase-Quality-Constraints, Platform Team Initiatives (New Hook System). Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Implement the Hook system added in MediaWiki 1.35 in the extensions, see Hooks.md <https://phabricator.wikimedia.org/source/mediawiki/browse/master/docs/Hooks.md> for documentation. Use hook handlers for core hooks. TASK DETAIL https://phabricator.wikimedia.org/T346519 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Aklapper, Umherirrender, Naike, apaskulin, Eihel, DannyS712, Lucas_Werkmeister_WMDE, Esc3300, Agabi10, abian, Wikidata-bugs ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T346518: Update WikibaseCirrusSearch to use the new HookContainer/HookRunner system
Umherirrender created this task. Umherirrender added projects: CirrusSearch, Platform Team Initiatives (New Hook System), Wikidata. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Discovery-Search. TASK DESCRIPTION Implement the Hook system added in MediaWiki 1.35 in the extensions, see Hooks.md <https://phabricator.wikimedia.org/source/mediawiki/browse/master/docs/Hooks.md> for documentation. [ ] Use hook handlers for core hooks [ ] Use hook handlers for CirrusSearch hooks TASK DETAIL https://phabricator.wikimedia.org/T346518 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Umherirrender, Aklapper, Danny_Benjafield_WMDE, gonzalez.actor, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Wilmanbeno, Naike, ItamarWMDE, Akuckartz, apaskulin, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Wikidata-bugs, aude, jayvdb, Mbch331, jeremyb ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T346517: Update WikibaseLexemeCirrusSearch to use the new HookContainer/HookRunner system
Umherirrender created this task. Umherirrender added projects: Discovery-Search, Platform Team Initiatives (New Hook System), Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Implement the Hook system added in MediaWiki 1.35 in the extensions, see Hooks.md <https://phabricator.wikimedia.org/source/mediawiki/browse/master/docs/Hooks.md> for documentation. [ ] Use hook handlers for core hooks [ ] Use hook handlers for CirrusSearch hooks TASK DETAIL https://phabricator.wikimedia.org/T346517 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Umherirrender, Aklapper, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Naike, ItamarWMDE, Akuckartz, apaskulin, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T346514: Update ArticlePlaceholder to use the new HookContainer/HookRunner system
Umherirrender created this task. Umherirrender added projects: ArticlePlaceholder, Platform Team Initiatives (New Hook System). Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Implement the Hook system added in MediaWiki 1.35 in the extensions, see Hooks.md <https://phabricator.wikimedia.org/source/mediawiki/browse/master/docs/Hooks.md> for documentation. [ ] Use hook handlers for core hooks [ ] Use hook handlers for Scribunto hooks (T271026 <https://phabricator.wikimedia.org/T271026>) TASK DETAIL https://phabricator.wikimedia.org/T346514 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Aklapper, Umherirrender, Naike, apaskulin, DannyS712, cmadeo, Agabi10, Wikidata-bugs, jayvdb, Ricordisamoa ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T337150: Make PHPUnit dataProvider static in Wikidata.org tests
Umherirrender closed this task as "Resolved". Umherirrender assigned this task to thiemowmde. TASK DETAIL https://phabricator.wikimedia.org/T337150 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde, Umherirrender Cc: Aklapper, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T339346: Clean up retry logic in SqlIdGenerator and UpsertSqlIdGenerator
Umherirrender added a comment. Note: There is a same named class SqlIdGenerator in EntitySchema with the same code. TASK DETAIL https://phabricator.wikimedia.org/T339346 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Umherirrender, Aklapper, Lucas_Werkmeister_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Izno, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T338452: Update Wikibase to use the new HookContainer/HookRunner system
Umherirrender added a project: Platform Team Initiatives (New Hook System). TASK DETAIL https://phabricator.wikimedia.org/T338452 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Aklapper, Umherirrender, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Naike, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, apaskulin, Hook696, Kent7301, joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Agabi10, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T338452: Update Wikibase to use the new HookContainer/HookRunner system
Umherirrender added a parent task: T263353: Update all Wikimedia production extensions to use the new HookContainer/HookRunner system. TASK DETAIL https://phabricator.wikimedia.org/T338452 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Aklapper, Umherirrender, ItamarWMDE, Akuckartz, lucamauri, Gq86, Wikidata-bugs ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T338452: Update Wikibase to use the new HookContainer/HookRunner system
Umherirrender created this task. Umherirrender added projects: MediaWiki-extensions-WikibaseClient, MediaWiki-extensions-WikibaseRepository. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Implement the Hook system added in MediaWiki 1.35 in the extensions, see Hooks.md <https://phabricator.wikimedia.org/source/mediawiki/browse/master/docs/Hooks.md> for documentation. [ ] Create HookRunner class and the hook handler interfaces [ ] Use hook handlers TASK DETAIL https://phabricator.wikimedia.org/T338452 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Aklapper, Umherirrender, ItamarWMDE, Akuckartz, lucamauri, Gq86, Wikidata-bugs ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T337130: Make PHPUnit dataProvider LexemeFieldTest::getTestData static (WikibaseLexemeCirrusSearch extension)
Umherirrender updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T337130 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Umherirrender, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T337148: Make PHPUnit dataProvider static in WikibaseCirrusSearch tests
Umherirrender updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T337148 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Umherirrender, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T337153: Make PHPUnit dataProvider static in WikibaseQualityConstraints tests
[Wikidata-bugs] [Maniphest] T337150: Make PHPUnit dataProvider static in Wikidata.org tests
Umherirrender updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T337150 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Umherirrender, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T337151: Make PHPUnit dataProvider static in WikibaseLexeme tests
Umherirrender updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T337151 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Umherirrender, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T337154: Make PHPUnit dataProvider static in Wikibase tests
Umherirrender updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T337154 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Lucas_Werkmeister_WMDE, Aklapper, Umherirrender, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T337154: Make PHPUnit dataProvider static in Wikibase tests
Umherirrender added a comment. In T337154#8889236 <https://phabricator.wikimedia.org/T337154#8889236>, @Lucas_Werkmeister_WMDE wrote: > It turns out this task has also (like T337153 <https://phabricator.wikimedia.org/T337153>) had some initial work done already: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/921633 > > @Umherirrender, if you’re going to create a bunch of tasks for various extensions to do the same thing, and also upload changes partially doing that thing to those extensions, can you please attach those changes to those tasks, so that others can actually see the connection? My initial work was against T332865 <https://phabricator.wikimedia.org/T332865> and thus all patch sets are marked with that task. After I have finished the work I have looked which data provider are not converted and opened a task for each extension, in the most task I mention the still open data provider I have found, but for Wikibase there are so much tests with so much data provider and it was not possible and seems not useful to mention all of them. I also have assumed when the task gets worked on the developer starts with a up-to-date local clone and would see the already converted data provider in the code and can go with the non-static ones. I am going to update the other tasks to mention the merged patch set. TASK DETAIL https://phabricator.wikimedia.org/T337154 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Lucas_Werkmeister_WMDE, Aklapper, Umherirrender, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T321532: [commons-wmf.6] Console error - 'Error: View mediainfoview does not exist' on File pages
Umherirrender added a project: JavaScript. TASK DETAIL https://phabricator.wikimedia.org/T321532 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Krinkle, Tacsipacsi, mdaniels5757, vadim-kovalenko, matthiasmullie, SimoneThisDot, CBogen, Aklapper, Etonkovidova, Astuthiodit_1, Trngsh15, karapayneWMDE, toberto, Invadibot, Mengs21, GFontenelle_WMF, maantietaja, FRomeo_WMF, EgbeRef, ItamarWMDE, Vaibhav0199, Nintendofan885, Akuckartz, Tinzawoo533, darthmon_wmde, Rosalie_WMDE, Onmir, DannyS712, Nandana, JKSTNK, Mh-3110, Amorymeltzer, Lahi, Gq86, E1presidente, Ramsey-WMF, Cparle, SandraF_WMF, GoranSMilovanovic, QZanden, enigmaeth, rohitt, Tramullas, Acer, LawExplorer, Salgo60, Silverfish, _jensen, rosalieper, Scott_WUaS, Dixtosa, Susannaanas, Verdy_p, Fuzheado, Jane023, Wikidata-bugs, Base, aude, Daniel_Mietchen, Dinoguy1000, Ricordisamoa, Wesalius, Lydia_Pintscher, Raymond, Jdforrester-WMF, Steinsplitter, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T337154: Make PHPUnit dataProvider static in Wikibase tests
Umherirrender added a parent task: T332865: PHPUnit data providers should be simple static functions that return plain data. TASK DETAIL https://phabricator.wikimedia.org/T337154 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Aklapper, Umherirrender, ItamarWMDE, Akuckartz, lucamauri, Gq86, Wikidata-bugs ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T337154: Make PHPUnit dataProvider static in Wikibase tests
Umherirrender created this task. Umherirrender added projects: MediaWiki-extensions-WikibaseClient, MediaWiki-extensions-WikibaseRepository. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION The `@dataProvider` annotation should be a static function, check and make data provider in the extension static and adjust the usages (More infos at T332865 <https://phabricator.wikimedia.org/T332865>). Some abstract provider function are also used in other extensions and need some compatibility code. TASK DETAIL https://phabricator.wikimedia.org/T337154 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Aklapper, Umherirrender, ItamarWMDE, Akuckartz, lucamauri, Gq86, Wikidata-bugs ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T337153: Make PHPUnit dataProvider static in WikibaseQualityConstraints tests
Umherirrender added a parent task: T332865: PHPUnit data providers should be simple static functions that return plain data. TASK DETAIL https://phabricator.wikimedia.org/T337153 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Aklapper, Umherirrender, Eihel, Lucas_Werkmeister_WMDE, Esc3300, Agabi10, abian, Wikidata-bugs ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T337153: Make PHPUnit dataProvider static in WikibaseQualityConstraints tests
Umherirrender created this task. Umherirrender added a project: Wikibase-Quality-Constraints. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION The `@dataProvider` annotation should be a static function, check and make data provider in the extension, at least: - `ContemporaryCheckerTest` with `provideStandardStatements` - `HtmlTableBuilderTest` with `toHtmlDataProvider` - `WikibaseQualityConstraintsHooksTest` with `provideChanges` static and adjust the usages (More infos at T332865 <https://phabricator.wikimedia.org/T332865>). TASK DETAIL https://phabricator.wikimedia.org/T337153 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Aklapper, Umherirrender, Eihel, Lucas_Werkmeister_WMDE, Esc3300, Agabi10, abian, Wikidata-bugs ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T337150: Make PHPUnit dataProvider static in Wikidata.org tests
Umherirrender added a parent task: T332865: PHPUnit data providers should be simple static functions that return plain data. TASK DETAIL https://phabricator.wikimedia.org/T337150 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Umherirrender, Aklapper, Wikidata-bugs ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T337150: Make PHPUnit dataProvider static in Wikidata.org tests
Umherirrender created this task. Umherirrender added a project: Wikidata.org. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION The `@dataProvider` annotation should be a static function, check and make data provider in the extension, at least: - `WikimediaLoadBalancerQueryServicePoolStatusProviderTest` with `getStatusProvider` and `getStatusInvalidJSONProvider` - `WikimediaPrometheusQueryServiceLagProviderTest` with `getLagsProvider` and `getLagsInvalidJSONProvider` static and adjust the usages (More infos at T332865 <https://phabricator.wikimedia.org/T332865>). TASK DETAIL https://phabricator.wikimedia.org/T337150 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Umherirrender, Aklapper, Wikidata-bugs ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T337148: Make PHPUnit dataProvider static in WikibaseCirrusSearch tests
Umherirrender updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T337148 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Umherirrender, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T337148: Make PHPUnit dataProvider static in WikibaseCirrusSearch tests
Umherirrender added a parent task: T332865: PHPUnit data providers should be simple static functions that return plain data. TASK DETAIL https://phabricator.wikimedia.org/T337148 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Umherirrender, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T337148: Make PHPUnit dataProvider static in WikibaseCirrusSearch tests
Umherirrender created this task. Umherirrender added a project: Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION The `@dataProvider` annotation should be a static function, check and amke data provider in the extension, at least: - `AllLabelsFieldTest` with `provideFieldData` - `DescriptionFieldTest` with `getFieldDataProvider` - abstract `WikibaseNumericFieldTestCase` with `getFieldDataProvider` - `LabelsFieldTest` with `getFieldDataProvider` - `StatementQuantityFieldTest` with `statementsProvider` static and adjust the usages (More infos at T332865 <https://phabricator.wikimedia.org/T332865>). TASK DETAIL https://phabricator.wikimedia.org/T337148 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Umherirrender, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T337130: Make PHPUnit dataProvider LexemeFieldTest::getTestData static (WikibaseLexemeCirrusSearch extension)
Umherirrender renamed this task from "Make PHPUnit dataProvider LexemeFieldTest::getTestData static" to "Make PHPUnit dataProvider LexemeFieldTest::getTestData static (WikibaseLexemeCirrusSearch extension)". TASK DETAIL https://phabricator.wikimedia.org/T337130 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Umherirrender, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T337130: Make PHPUnit dataProvider LexemeFieldTest::getTestData static
Umherirrender renamed this task from "Make dataProvider LexemeFieldTest::getTestData static" to "Make PHPUnit dataProvider LexemeFieldTest::getTestData static". Umherirrender updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T337130 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Umherirrender, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T312849: PHPUnit dataProviders access the main DB, not the cloned database
Umherirrender added a comment. The problem seems more that the data provider is not static and doing some expensive things, see T332865 <https://phabricator.wikimedia.org/T332865> for more about non-static data provider. TASK DETAIL https://phabricator.wikimedia.org/T312849 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Umherirrender, Jdforrester-WMF, Krinkle, kostajh, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T336601: Error: View mediainfoview does not exist
Umherirrender added a project: JavaScript. Umherirrender added a comment. Looks similiar to T321532 <https://phabricator.wikimedia.org/T321532>, not sure if the same TASK DETAIL https://phabricator.wikimedia.org/T336601 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Umherirrender, Jdlrobson, Astuthiodit_1, Trngsh15, karapayneWMDE, Invadibot, Mengs21, maantietaja, EgbeRef, ItamarWMDE, Vaibhav0199, Akuckartz, Tinzawoo533, darthmon_wmde, Rosalie_WMDE, Onmir, DannyS712, Nandana, Mh-3110, Amorymeltzer, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, enigmaeth, rohitt, LawExplorer, _jensen, rosalieper, Scott_WUaS, Dixtosa, Verdy_p, Wikidata-bugs, aude, Dinoguy1000, Jdforrester-WMF, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T299077: CI job wmf-quibble-selenium-php72-docker get a deadlock on `change_tag_def` (NameTableStore)
Umherirrender merged a task: T336066: Error 1213 from MediaWiki\Storage\NameTableStore::store, Deadlock found when trying to get lock; try restarting transaction INSERT IGNORE INTO `change_tag_def`. TASK DETAIL https://phabricator.wikimedia.org/T299077 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: ItamarWMDE, Jakob_WMDE, Tarrow, Lucas_Werkmeister_WMDE, Michael, tstarling, Ladsgroup, Nikerabbit, matmarex, kostajh, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, zeljkofilipin, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T243594: Enable disabled phan checks in Wikibase
Umherirrender closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T243594 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Silvan_WMDE, Addshore, Aklapper, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Daimona, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T243594: Enable disabled phan checks in Wikibase
Umherirrender claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T243594 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Silvan_WMDE, Addshore, Aklapper, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Daimona, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T333574: Wikimedia\Rdbms\DBQueryError: Error 1146: Table 'commonswiki.wbt_type' doesn't exist when using Special:NewItem on Commons
Umherirrender added a comment. See also T298452 <https://phabricator.wikimedia.org/T298452> TASK DETAIL https://phabricator.wikimedia.org/T333574 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Umherirrender, Aklapper, Lucas_Werkmeister_WMDE, Astuthiodit_1, Susie413113, karapayneWMDE, Invadibot, GFontenelle_WMF, maantietaja, FRomeo_WMF, CBogen, ItamarWMDE, Nintendofan885, Akuckartz, darthmon_wmde, Rosalie_WMDE, Nandana, JKSTNK, Lahi, Gq86, E1presidente, Ramsey-WMF, Cparle, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Salgo60, Silverfish, _jensen, rosalieper, Scott_WUaS, Susannaanas, Wong128hk, Verdy_p, Fuzheado, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Daniel_Mietchen, Ricordisamoa, Wesalius, Lydia_Pintscher, Raymond, Jdforrester-WMF, Steinsplitter, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T299077: CI job wmf-quibble-selenium-php72-docker get a deadlock on `change_tag_def` (NameTableStore)
Umherirrender added a comment. Have merged a sub task with the same error message/stack trace, so the remove of the transaction is not enough TASK DETAIL https://phabricator.wikimedia.org/T299077 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: ItamarWMDE, Jakob_WMDE, Tarrow, Lucas_Werkmeister_WMDE, Michael, tstarling, Ladsgroup, Nikerabbit, matmarex, kostajh, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, zeljkofilipin, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T299077: CI job wmf-quibble-selenium-php72-docker get a deadlock on `change_tag_def` (NameTableStore)
Umherirrender merged a task: T332540: Error 1213 from MediaWiki\Storage\NameTableStore::store, Deadlock found when trying to get lock; try restarting transaction INSERT IGNORE INTO `change_tag_def` (ctd_name,ctd_user_defined,ctd_count) VALUES (mobile web edit,0,0). TASK DETAIL https://phabricator.wikimedia.org/T299077 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: ItamarWMDE, Jakob_WMDE, Tarrow, Lucas_Werkmeister_WMDE, Michael, tstarling, Ladsgroup, Nikerabbit, matmarex, kostajh, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, zeljkofilipin, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T332540: Error 1213 from MediaWiki\Storage\NameTableStore::store, Deadlock found when trying to get lock; try restarting transaction INSERT IGNORE INTO `change_tag_def` (ct
Umherirrender closed this task as a duplicate of T299077: CI job wmf-quibble-selenium-php72-docker get a deadlock on `change_tag_def` (NameTableStore). TASK DETAIL https://phabricator.wikimedia.org/T332540 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: kostajh, Astuthiodit_1, karapayneWMDE, Invadibot, Devnull, LSobanski, maantietaja, ItamarWMDE, Akuckartz, DannyS712, Nandana, lucamauri, Amorymeltzer, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, TTO, Jdforrester-WMF, Mbch331, hashar ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T328601: TypeError: Argument 2 passed to Parser::parse() must implement interface MediaWiki\Page\PageReference, null given, called in /srv/mediawiki/php-1.40.0-wmf.21/exten
Umherirrender added subscribers: Lucas_Werkmeister_WMDE, thiemowmde, awight, hoo, Umherirrender. Umherirrender added a comment. It is https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/803578 (T309695 <https://phabricator.wikimedia.org/T309695>) The global context (`RequestContext::getMain()->getTitle()`) has no title on the job runners (here by CirrusSearch) TASK DETAIL https://phabricator.wikimedia.org/T328601 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Umherirrender, hoo, awight, thiemowmde, Lucas_Werkmeister_WMDE, DLynch, Jdforrester-WMF, Agusbou2015, dancy, Aklapper, Adamm71, Jersione, Hellket777, mrephabricator, LisafBia6531, 786, Biggs657, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Alilje, Hook696, darthmon_wmde, Nabetaro, Rosalie_WMDE, Kent7301, joker88john, CucyNoiD, MSantos, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Gq86, Af420, Bsandipan, Looniverse, Sturm, Orienteerix, Lewizho99, Ddproxy, Maathavan, JGirault, Neuronton, phabyogi, GAllegre, Susannaanas, ferdbold, lxbarth, Verdy_p, Planemad, Wikidata-bugs, Yurik, TheDJ, Jay8g, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T193180: Clean up archive rows with duplicate revision IDs
Umherirrender merged a task: T24392: Revisions existing in both archive and revision tables. Umherirrender added subscribers: bzimport, RhinosF1, JEumerus, Krenair, drdee, Nemo_bis, Graham87, Peachey88. TASK DETAIL https://phabricator.wikimedia.org/T193180 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie, Umherirrender Cc: Peachey88, Graham87, Nemo_bis, drdee, Krenair, JEumerus, RhinosF1, bzimport, Aklapper, gerritbot, greg, Stashbot, CCicalese_WMF, daniel, Addshore, aude, Jdforrester-WMF, Abit, Astuthiodit_1, karapayneWMDE, Invadibot, GFontenelle_WMF, maantietaja, FRomeo_WMF, CBogen, ItamarWMDE, Nintendofan885, Akuckartz, DannyS712, Nandana, JKSTNK, Lahi, Gq86, E1presidente, Ramsey-WMF, Cparle, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Salgo60, JJMC89, Silverfish, _jensen, rosalieper, Agabi10, Scott_WUaS, Susannaanas, Fuzheado, Fjalapeno, Jane023, Wikidata-bugs, Base, matthiasmullie, Daniel_Mietchen, Ricordisamoa, Wesalius, Lydia_Pintscher, Raymond, Steinsplitter, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T192777: Do not use Content::prepareSave when importing or undeleting (drop hard global constraints)
Umherirrender added a comment. The task needs some rewording since T287159 <https://phabricator.wikimedia.org/T287159> / https://gerrit.wikimedia.org/r/c/mediawiki/core/+/732962 moved/renamed the function and replaced the old usages. TASK DETAIL https://phabricator.wikimedia.org/T192777 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Umherirrender, DannyS712, Legoktm, Aklapper, hoo, Tgr, Lydia_Pintscher, daniel, Servet3131, Astuthiodit_1, karapayneWMDE, Invadibot, Lalamarie69, maantietaja, ItamarWMDE, Akuckartz, holger.knust, Nandana, Amorymeltzer, Lahi, Gq86, Markhalsey, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Pchelolo, Wikidata-bugs, aude, Jackmcbarn, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T326297: Incorrect use of plural with 0 in MediaWiki:Wikibase-statementview-references-counter/sl
Umherirrender added a comment.
It is a issue with use of `{{int:}}` and that means in core and not for this
message or extension.
When the parser function is used, the message is fetched and `Message::plain`
is called. That returns for this message in the user language the wikitext `0
{{PLURAL:0|sklic|sklica|sklici|sklicev}}`. This wikitext is parsed further in
the content language. PLURAL in english language only supports two forms (1 and
not 1), so it pick up the second ("sklica"). The plural needs to be parsed in
the user language as well, so the transform of `{{` must be done in the
message, that's what `Message::text` exists for, that would expand all
templates and parser functions, like grammar, which is good. But it can also
have some other effects, not sure.
It is there since very long (before dfd6988313d7033c8294d4b1ce7d9e92604501dc
<https://phabricator.wikimedia.org/rMWdfd6988313d7033c8294d4b1ce7d9e92604501dc>)
TASK DETAIL
https://phabricator.wikimedia.org/T326297
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Umherirrender
Cc: Umherirrender, Lucas_Werkmeister_WMDE, Aklapper, TadejM, Astuthiodit_1,
Prufkick, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz,
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen,
rosalieper, Scott_WUaS, Srdjan, MuhammadShuaib, LNDDYL, Psychoslave,
Wikidata-bugs, aude, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T326297: Incorrect use of plural with 0 in MediaWiki:Wikibase-statementview-references-counter/sl
Umherirrender added a comment.
`{{PLURAL:}}` supports numbered arguments. The last non-numbered argument is
the "many" parts. It is valid to use "0=" there.
When looking at the "in other languages" page on translatewiki for this
message there are already usage of that -
https://translatewiki.net/w/i.php?title=Special:Translations=MediaWiki%3AWikibase-statementview-references-counter
And it looks like working: https://www.wikidata.org/wiki/Q557141?uselang=sms
TASK DETAIL
https://phabricator.wikimedia.org/T326297
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Umherirrender
Cc: Umherirrender, Lucas_Werkmeister_WMDE, Aklapper, TadejM, Astuthiodit_1,
Prufkick, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz,
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen,
rosalieper, Scott_WUaS, Srdjan, MuhammadShuaib, LNDDYL, Psychoslave,
Wikidata-bugs, aude, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T260340: Stop using deprecated Language static methods in Wikibase extensions
Umherirrender updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T260340 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Addshore, Lucas_Werkmeister_WMDE, Aklapper, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T260340: Stop using deprecated Language static methods in Wikibase extensions
Umherirrender updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T260340 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Addshore, Lucas_Werkmeister_WMDE, Aklapper, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T260340: Stop using deprecated Language static methods in Wikibase extensions
Umherirrender updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T260340 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Addshore, Lucas_Werkmeister_WMDE, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T281122: Wikibase selenium tests timeout, seemingly due to "memory compaction" events on CI VMs
Umherirrender added projects: ci-test-error (WMF-deployed Build Failure), Browser-Tests. Umherirrender added a comment. My core patch https://gerrit.wikimedia.org/r/c/mediawiki/core/+/869838 gets similiar failures https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php74-docker/12766/console 20:19:27 [chrome 90.0.4430.212 linux #0-4] 1) target property label uses the property ID if no label in fallback chain found 20:19:27 [chrome 90.0.4430.212 linux #0-4] Timeout of 6ms exceeded. The execution in the test "target property label uses the property ID if no label in fallback chain found" took too long. Try to reduce the run time or increase your timeout for test specs (https://webdriver.io/docs/timeouts). (/workspace/src/extensions/Wikibase/client/data-bridge/tests/selenium/specs/init.js) 20:19:27 [chrome 90.0.4430.212 linux #0-4] Error: Timeout of 6ms exceeded. The execution in the test "target property label uses the property ID if no label in fallback chain found" took too long. Try to reduce the run time or increase your timeout for test specs (https://webdriver.io/docs/timeouts). (/workspace/src/extensions/Wikibase/client/data-bridge/tests/selenium/specs/init.js) 20:19:27 [chrome 90.0.4430.212 linux #0-4] at createTimeoutError (/workspace/src/extensions/Wikibase/client/data-bridge/node_modules/mocha/lib/errors.js:498:15) 20:19:27 [chrome 90.0.4430.212 linux #0-4] at Test.Runnable._timeoutError (/workspace/src/extensions/Wikibase/client/data-bridge/node_modules/mocha/lib/runnable.js:431:10) 20:19:27 [chrome 90.0.4430.212 linux #0-4] at Timeout. (/workspace/src/extensions/Wikibase/client/data-bridge/node_modules/mocha/lib/runnable.js:246:24) 20:19:27 [chrome 90.0.4430.212 linux #0-4] at listOnTimeout (internal/timers.js:557:17) 20:19:27 [chrome 90.0.4430.212 linux #0-4] at processTimers (internal/timers.js:500:7) 20:19:27 [chrome 90.0.4430.212 linux #0-4] 20:19:27 [chrome 90.0.4430.212 linux #0-4] 2) warning for anonymous edits "before each" hook for init 20:19:27 [chrome 90.0.4430.212 linux #0-4] Timeout of 6ms exceeded. The execution in the test "init "before each" hook for "is not shown when logged in"" took too long. Try to reduce the run time or increase your timeout for test specs (https://webdriver.io/docs/timeouts). (/workspace/src/extensions/Wikibase/client/data-bridge/tests/selenium/specs/init.js) 20:19:27 [chrome 90.0.4430.212 linux #0-4] Error: Timeout of 6ms exceeded. The execution in the test "init "before each" hook for "is not shown when logged in"" took too long. Try to reduce the run time or increase your timeout for test specs (https://webdriver.io/docs/timeouts). (/workspace/src/extensions/Wikibase/client/data-bridge/tests/selenium/specs/init.js) 20:19:27 [chrome 90.0.4430.212 linux #0-4] at createTimeoutError (/workspace/src/extensions/Wikibase/client/data-bridge/node_modules/mocha/lib/errors.js:498:15) 20:19:27 [chrome 90.0.4430.212 linux #0-4] at Hook.Runnable._timeoutError (/workspace/src/extensions/Wikibase/client/data-bridge/node_modules/mocha/lib/runnable.js:431:10) 20:19:27 [chrome 90.0.4430.212 linux #0-4] at Timeout. (/workspace/src/extensions/Wikibase/client/data-bridge/node_modules/mocha/lib/runnable.js:246:24) 20:19:27 [chrome 90.0.4430.212 linux #0-4] at listOnTimeout (internal/timers.js:557:17) 20:19:27 [chrome 90.0.4430.212 linux #0-4] at processTimers (internal/timers.js:500:7) The build has a video from that - https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php74-docker/12766/artifact/log/target-property-label_uses-the-property-ID-if-no-label-in-fallback-chain-found.mp4 Maybe that helps to find a issue or get an idea to harden the code, but that video is only there for some days TASK DETAIL https://phabricator.wikimedia.org/T281122 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender Cc: Umherirrender, thcipriani, Ladsgroup, nskaggs, kostajh, hashar, Tonina_Zhelyazkova_WMDE, Jakob_WMDE, Addshore, WMDE-leszek, Aklapper, santhosh, Astuthiodit_1, karapayneWMDE, Ramtin2021, Invadibot, dcaro, Devnull, Slst2020, GeminiAgaloos, maantietaja, Raymond_Ndibe, ItamarWMDE, Nintendofan885, Akuckartz, Phamhi, Nandana, JKSTNK, Namenlos314, skpuneethumar, Fheredia, sietec, Zylc, 1978Gage2001, Lahi, Operator873, Gq86, Bsandipan, GoranSMilovanovic, Chicocvenancio, Allthingsgo, QZanden, Tbscho, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, Jitrixis, aude, Gryllida, zeljkofilipin, scfc, Jdforrester-WMF, Mbch331, Jay8g, bd808, Krenair ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
