[Wikidata-bugs] [Maniphest] [Commented On] T240884: Standalone service to evaluate user-provided regular expressions

Joe added a comment. In T240884#5813174 , @Daimona wrote: > In T240884#5810160 , @sbassett wrote: > >> In T240884#5810094 , @Ladsg

[Wikidata-bugs] [Maniphest] [Commented On] T240884: Standalone service to evaluate user-provided regular expressions

Ladsgroup added a comment. In T240884#5808716 , @daniel wrote: > So, one key question to answer in this RFC is: Are there other people/projects/teams interested in re2 or gRPC? What are their needs and plans? One complicating factor

[Wikidata-bugs] [Maniphest] [Commented On] T240884: Standalone service to evaluate user-provided regular expressions

daniel added a comment. Condensed outcome of a conversation between @Ladsgroup, @Addshore, @Joe, @krinkle, @tstarling, and myself: - If there are other use cases for re2 in MediaWiki, go for a native php binding for re2. - If there are other use cases for gRPC on our cluster, try to us

[Wikidata-bugs] [Maniphest] [Commented On] T240884: Standalone service to evaluate user-provided regular expressions

tstarling added a comment. There is https://pecl.php.net/package/re2 . It was written for PHP 5 and was never updated after its initial release in 2011, but we have the skills to update it for PHP 7 and review it for security. If we believe in RE2 then we shouldn't be afraid to invest in it.

[Wikidata-bugs] [Maniphest] [Commented On] T240884: Standalone service to evaluate user-provided regular expressions

Bawolff added a comment. In T240884#5796687 , @Joe wrote: > I think the main question to answer is "does it make sense to create a safe regex evaluation service?". > I think in a void the answer is "no". It could make sense to create a

[Wikidata-bugs] [Maniphest] [Commented On] T240884: Standalone service to evaluate user-provided regular expressions

Addshore added a comment. In T240884#5802950 , @Lucas_Werkmeister_WMDE wrote: > If I understand correctly, this is just the time of the individual format constraint check itself. A full constraint check for an item will typically involv

[Wikidata-bugs] [Maniphest] [Commented On] T240884: Standalone service to evaluate user-provided regular expressions

Lucas_Werkmeister_WMDE added a comment. > I believe ever cache miss in that graph will result in 1 call to sparql to check 1 regular expression against 1 string. I think that’s correct, we don’t batch these requests at the moment. > The second panel is the p95 timing for the constrai

[Wikidata-bugs] [Maniphest] [Commented On] T240884: Standalone service to evaluate user-provided regular expressions

Addshore added a comment. I have created a temporary dashboard at https://grafana.wikimedia.org/d/HUGEtYPWz/t240884?orgId=1 with some of these number pulled out. The "Individual regex runs" panel covers what I said in T240884#5802852 a

[Wikidata-bugs] [Maniphest] [Commented On] T240884: Standalone service to evaluate user-provided regular expressions

Joe added a comment. I think the main question to answer is "does it make sense to create a safe regex evaluation service?". I think in a void the answer is "no". It could make sense to create a small C++ program wrapping the main re2 functionality and shell out to it from php. On t

[Wikidata-bugs] [Maniphest] [Commented On] T240884: Standalone service to evaluate user-provided regular expressions

Joe added a comment. In T240884#5789392 , @Ladsgroup wrote: >> Though this is mainly an implementation detail and not significant in terms requirements or pros/cons. > > I disagree for a couple of reasons: gRPC is faster. According t

[Wikidata-bugs] [Maniphest] [Commented On] T240884: Standalone service to evaluate user-provided regular expressions

Ladsgroup added a comment. > Though this is mainly an implementation detail and not significant in terms requirements or pros/cons. I disagree for a couple of reasons: gRPC is faster. According to some measurements in ASP.net

[Wikidata-bugs] [Maniphest] [Commented On] T240884: Standalone service to evaluate user-provided regular expressions

Krinkle added a comment. Based on today's TechCom meeting I've updated the task description to better separate the three proposals, and added a **Requirements** section. I've also fleshed out the re2-based solution description and clarified that gRPC is not itself a critical part of any