[Wikidata-bugs] [Maniphest] T273622: Deprecation warning: Expected RevisionRecord to belong to ...

hashar added a comment. I had dinner, come back and magic the task is closed. Thank you! TASK DETAIL https://phabricator.wikimedia.org/T273622 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, hashar Cc: hashar, WMDE-leszek,

[Wikidata-bugs] [Maniphest] T273622: Deprecation warning: Expected RevisionRecord to belong to ...

daniel added a comment. @Lucas_Werkmeister_WMDE wrote: > so for a RevisionRecord belonging to a non-local wiki, calling getId() without arguments will now trigger a call to wfDeprecatedMsg(). But wfDeprecatedMsg() is apparently enough to make unit tests fail, and also cause warnings to

[Wikidata-bugs] [Maniphest] T273622: Deprecation warning: Expected RevisionRecord to belong to ...

Lucas_Werkmeister_WMDE closed this task as "Resolved". Lucas_Werkmeister_WMDE moved this task from Peer Review to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Lucas_Werkmeister_WMDE claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T273622 WORKBOARD

[Wikidata-bugs] [Maniphest] T273622: Deprecation warning: Expected RevisionRecord to belong to ...

Lucas_Werkmeister_WMDE added a comment. Should be fixed now. TASK DETAIL https://phabricator.wikimedia.org/T273622 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: hashar, WMDE-leszek, RhinosF1, Peter.ovchyn,

[Wikidata-bugs] [Maniphest] T273622: Deprecation warning: Expected RevisionRecord to belong to ...

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.29; 2021-02-02); removed MW-1.36-notes (1.36.0-wmf.30; 2021-02-09). TASK DETAIL https://phabricator.wikimedia.org/T273622 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T273622: Deprecation warning: Expected RevisionRecord to belong to ...

Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2021-02-02T19:58:46Z] Synchronized php-1.36.0-wmf.29/extensions/WikibaseMediaInfo/: Backport: [[gerrit:661092|Pass $databaseName into WikiPageEntityDataLoader (T273622 )]]

[Wikidata-bugs] [Maniphest] T273622: Deprecation warning: Expected RevisionRecord to belong to ...

Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2021-02-02T19:57:14Z] Synchronized php-1.36.0-wmf.29/extensions/Wikibase/: Backport: [[gerrit:661091|Add wiki ID to WikiPageEntityDataLoader (T273622 )]] (duration: 01m 25s)

[Wikidata-bugs] [Maniphest] T273622: Deprecation warning: Expected RevisionRecord to belong to ...

gerritbot added a comment. Change 661092 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseMediaInfo@wmf/1.36.0-wmf.29] Pass $databaseName into WikiPageEntityDataLoader https://gerrit.wikimedia.org/r/661092 TASK DETAIL https://phabricator.wikimedia.org/T273622 EMAIL

[Wikidata-bugs] [Maniphest] T273622: Deprecation warning: Expected RevisionRecord to belong to ...

gerritbot added a comment. Change 661091 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@wmf/1.36.0-wmf.29] Add wiki ID to WikiPageEntityDataLoader https://gerrit.wikimedia.org/r/661091 TASK DETAIL https://phabricator.wikimedia.org/T273622 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T273622: Deprecation warning: Expected RevisionRecord to belong to ...

Lucas_Werkmeister_WMDE added a comment. Yeah, I’ll deploy the backports now (Morning backports window, no other patches as far as I can see). TASK DETAIL https://phabricator.wikimedia.org/T273622 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T273622: Deprecation warning: Expected RevisionRecord to belong to ...

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.30; 2021-02-09). TASK DETAIL https://phabricator.wikimedia.org/T273622 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ReleaseTaggerBot Cc: hashar, WMDE-leszek, RhinosF1, Peter.ovchyn,

[Wikidata-bugs] [Maniphest] T273622: Deprecation warning: Expected RevisionRecord to belong to ...

Addshore added a comment. In T273622#6797282 , @hashar wrote: > I guess we "just" need to backport those two merged changes to 1.36.0-wmf.29 ? If so please cherry pick to `wmf/1.36.0-wmf.29` and either sync them or I can do it. >

[Wikidata-bugs] [Maniphest] T273622: Deprecation warning: Expected RevisionRecord to belong to ...

hashar added a comment. I guess we "just" need to backport those two merged changes to 1.36.0-wmf.29 ? If so please cherry pick to `wmf/1.36.0-wmf.29` and either sync them or I can do it. 1.36.0-wmf.29 is still blocked on other changes though so I am most probably not going to push it

[Wikidata-bugs] [Maniphest] T273622: Deprecation warning: Expected RevisionRecord to belong to ...

gerritbot added a comment. Change 661114 **abandoned** by Addshore: [mediawiki/extensions/Wikibase@master] Update RevisionRecord::getId usage Reason: Replaced by other patches in https://phabricator.wikimedia.org/T273622 https://gerrit.wikimedia.org/r/661114 TASK DETAIL

[Wikidata-bugs] [Maniphest] T273622: Deprecation warning: Expected RevisionRecord to belong to ...

gerritbot added a comment. Change 661092 had a related patch set uploaded (by Addshore; owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseMediaInfo@wmf/1.36.0-wmf.29] Pass $databaseName into WikiPageEntityDataLoader https://gerrit.wikimedia.org/r/661092 TASK DETAIL

[Wikidata-bugs] [Maniphest] T273622: Deprecation warning: Expected RevisionRecord to belong to ...

gerritbot added a comment. Change 661091 had a related patch set uploaded (by Addshore; owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@wmf/1.36.0-wmf.29] Add wiki ID to WikiPageEntityDataLoader https://gerrit.wikimedia.org/r/661091 TASK DETAIL

[Wikidata-bugs] [Maniphest] T273622: Deprecation warning: Expected RevisionRecord to belong to ...

Addshore added a comment. I'll make some cherry picks now so that CI can run on them before they are backported. TASK DETAIL https://phabricator.wikimedia.org/T273622 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: WMDE-leszek,

[Wikidata-bugs] [Maniphest] T273622: Deprecation warning: Expected RevisionRecord to belong to ...

gerritbot added a comment. Change 661137 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseMediaInfo@master] Pass $databaseName into WikiPageEntityDataLoader https://gerrit.wikimedia.org/r/661137 TASK DETAIL https://phabricator.wikimedia.org/T273622 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T273622: Deprecation warning: Expected RevisionRecord to belong to ...

gerritbot added a comment. Change 661136 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Add wiki ID to WikiPageEntityDataLoader https://gerrit.wikimedia.org/r/661136 TASK DETAIL https://phabricator.wikimedia.org/T273622 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T273622: Deprecation warning: Expected RevisionRecord to belong to ...

Addshore added a project: Wikimedia-production-error. TASK DETAIL https://phabricator.wikimedia.org/T273622 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: WMDE-leszek, RhinosF1, Peter.ovchyn, Vlad.shapik, Lucas_Werkmeister_WMDE,

[Wikidata-bugs] [Maniphest] T273622: Deprecation warning: Expected RevisionRecord to belong to ...

Lucas_Werkmeister_WMDE edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite. TASK DETAIL https://phabricator.wikimedia.org/T273622 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE

[Wikidata-bugs] [Maniphest] T273622: Deprecation warning: Expected RevisionRecord to belong to ...

Lucas_Werkmeister_WMDE added a comment. This is also happening in production: Logstash has 11 occurrences of > [{reqId}] {exception_url} ErrorException: Expected RevisionRecord to belong to the local wiki, but it belongs to 'testwikidatawiki' [Called from

[Wikidata-bugs] [Maniphest] T273622: Deprecation warning: Expected RevisionRecord to belong to ...

gerritbot added a comment. Change 661137 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseMediaInfo@master] Pass $databaseName into WikiPageEntityDataLoader https://gerrit.wikimedia.org/r/661137 TASK DETAIL

[Wikidata-bugs] [Maniphest] T273622: Deprecation warning: Expected RevisionRecord to belong to ...

gerritbot added a comment. Change 661136 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Add wiki ID to WikiPageEntityDataLoader https://gerrit.wikimedia.org/r/661136 TASK DETAIL

[Wikidata-bugs] [Maniphest] T273622: Deprecation warning: Expected RevisionRecord to belong to ...

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T273622 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Peter.ovchyn, Vlad.shapik, Lucas_Werkmeister_WMDE, Pchelolo, daniel, Addshore, toan,

[Wikidata-bugs] [Maniphest] T273622: Deprecation warning: Expected RevisionRecord to belong to ...

gerritbot added a comment. Change 661114 had a related patch set uploaded (by Addshore; owner: Tobias Andersson): [mediawiki/extensions/Wikibase@master] Update RevisionRecord::getId usage https://gerrit.wikimedia.org/r/661114 TASK DETAIL https://phabricator.wikimedia.org/T273622

[Wikidata-bugs] [Maniphest] T273622: Deprecation warning: Expected RevisionRecord to belong to ...

Addshore added a comment. In T273622#6796443 , @Lucas_Werkmeister_WMDE wrote: >> I was able to make the tests pass locally by applying a patch like this but I

[Wikidata-bugs] [Maniphest] T273622: Deprecation warning: Expected RevisionRecord to belong to ...

Lucas_Werkmeister_WMDE added a comment. > I was able to make the tests pass locally by applying a patch like this but I suspect there may be many more cases where this could occur as RevisionRecord::getId is called

[Wikidata-bugs] [Maniphest] T273622: Deprecation warning: Expected RevisionRecord to belong to ...

Majavah added a project: Platform Engineering. TASK DETAIL https://phabricator.wikimedia.org/T273622 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Majavah Cc: Peter.ovchyn, Vlad.shapik, Lucas_Werkmeister_WMDE, Pchelolo, daniel, Addshore, toan,

[Wikidata-bugs] [Maniphest] T273622: Deprecation warning: Expected RevisionRecord to belong to ...

DannyS712 raised the priority of this task from "High" to "Unbreak Now!". TASK DETAIL https://phabricator.wikimedia.org/T273622 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: DannyS712 Cc: Peter.ovchyn, Vlad.shapik, Lucas_Werkmeister_WMDE, Pchelolo,

[Wikidata-bugs] [Maniphest] T273622: Deprecation warning: Expected RevisionRecord to belong to ...

Lucas_Werkmeister_WMDE added subscribers: Vlad.shapik, Peter.ovchyn. Lucas_Werkmeister_WMDE added a comment. I’m confused by what happened in RevisionRecord: make RevisionRecord::getId() take a wiki ID . It seems to have added an

[Wikidata-bugs] [Maniphest] T273622: Deprecation warning: Expected RevisionRecord to belong to ...

Lucas_Werkmeister_WMDE added a parent task: T271343: 1.36.0-wmf.29 deployment blockers. TASK DETAIL https://phabricator.wikimedia.org/T273622 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Peter.ovchyn, Vlad.shapik,

[Wikidata-bugs] [Maniphest] T273622: Deprecation warning: Expected RevisionRecord to belong to ...

Addshore added a project: wdwb-tech-focus (backlog). TASK DETAIL https://phabricator.wikimedia.org/T273622 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Lucas_Werkmeister_WMDE, Pchelolo, daniel, Addshore, toan, Aklapper, Akuckartz,

[Wikidata-bugs] [Maniphest] T273622: Deprecation warning: Expected RevisionRecord to belong to ...

Addshore triaged this task as "High" priority. TASK DETAIL https://phabricator.wikimedia.org/T273622 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Lucas_Werkmeister_WMDE, Pchelolo, daniel, Addshore, toan, Aklapper, Akuckartz, Nandana,

[Wikidata-bugs] [Maniphest] T273622: Deprecation warning: Expected RevisionRecord to belong to ...

Addshore added a comment. Given the fact that this seemingly breaks things for us locally this should probably block next weeks train which is when the core patch would be rolled out until we can figure out what is happening and why. T271343: 1.36.0-wmf.29 deployment blockers

[Wikidata-bugs] [Maniphest] T273622: Deprecation warning: Expected RevisionRecord to belong to ...

toan updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T273622 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: toan, Aklapper, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen,

[Wikidata-bugs] [Maniphest] T273622: Deprecation warning: Expected RevisionRecord to belong to ...

toan updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T273622 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: toan, Aklapper, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen,

[Wikidata-bugs] [Maniphest] T273622: Deprecation warning: Expected RevisionRecord to belong to ...

toan updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T273622 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: toan, Aklapper, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen,

[Wikidata-bugs] [Maniphest] T273622: Deprecation warning: Expected RevisionRecord to belong to ...

toan created this task. toan added a project: Wikidata-Campsite. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION In the wikibase release pipeline we've added some tests