Re: [Wikitech-l] Code review thoughts: module reviewers

2011-12-23 Thread Rob Lanphier
On Tue, Dec 20, 2011 at 3:01 PM, Brion Vibber bvib...@wikimedia.org wrote: I'd like us to seriously consider having primary reviewers for various code modules, so things like this get handled asap and don't end up falling through the cracks -- big changes, and small confusing changes ;) --

[MediaWiki-CodeReview] [MediaWiki r100227]: Revision status changed

2011-12-23 Thread MediaWiki Mail
MaxSem changed the status of MediaWiki.r100227 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100227 Old status: new New status: ok Commit summary for MediaWiki.r100227: * Changed ParserOptions to store a Language object instead of only a string, avoids object - string -

[MediaWiki-CodeReview] [MediaWiki r107086]: Revision status changed

2011-12-23 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107086 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107086 Old status: new New status: ok Commit summary for MediaWiki.r107086: * Fix typo in right name * Remove unused and nonexistent message from module definition * Remove

[MediaWiki-CodeReview] [MediaWiki r107087]: Revision status changed

2011-12-23 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107087 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107087 Old status: new New status: ok Commit summary for MediaWiki.r107087: Change error message to past tense ___

[MediaWiki-CodeReview] [MediaWiki r107088]: Revision status changed

2011-12-23 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107088 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107088 Old status: new New status: ok Commit summary for MediaWiki.r107088: set svn:eol-style native for r107035 ___

[MediaWiki-CodeReview] [MediaWiki r107090]: Revision status changed

2011-12-23 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107090 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107090 Old status: new New status: ok Commit summary for MediaWiki.r107090: Remove unused parameters and document prop parameter ___

[MediaWiki-CodeReview] [MediaWiki r107091]: Revision status changed

2011-12-23 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107091 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107091 Old status: new New status: ok Commit summary for MediaWiki.r107091: Forgot static keyword ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r107093]: Revision status changed

2011-12-23 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107093 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107093 Old status: new New status: resolved Commit summary for MediaWiki.r107093: added method to remove item from array by value to solve bug with reloading item, follow

[MediaWiki-CodeReview] [MediaWiki r107095]: New comment added, and revision status changed

2011-12-23 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107095 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107095#c28401 Old Status: new New Status: ok Commit summary for MediaWiki.r107095: Make $item vars local and put .init() call in document ready Nikerabbit's

[MediaWiki-CodeReview] [MediaWiki r107099]: New comment added, and revision status changed

2011-12-23 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107099 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107099#c28402 Old Status: new New Status: ok Commit summary for MediaWiki.r107099: ext.Wikidata.rtl Nikerabbit's comment: The way the rtl module is done, it

[MediaWiki-CodeReview] [MediaWiki r107100]: Revision status changed

2011-12-23 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107100 to deferred URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107100 Old status: new New status: deferred Commit summary for MediaWiki.r107100: corrected bug showing deleted expressions ___

[MediaWiki-CodeReview] [MediaWiki r107105]: Revision status changed

2011-12-23 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107105 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107105 Old status: new New status: ok Commit summary for MediaWiki.r107105: Inclusion guard isn't needed for class-only files ___

[MediaWiki-CodeReview] [MediaWiki r107107]: New comment added, and revision status changed

2011-12-23 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107107 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107107#c28403 Old Status: new New Status: fixme Commit summary for MediaWiki.r107107: finished up some stuff Nikerabbit's comment: pre +

[MediaWiki-CodeReview] [MediaWiki r107109]: Revision status changed

2011-12-23 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107109 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107109 Old status: new New status: ok Commit summary for MediaWiki.r107109: Use local context to get messages ___

[MediaWiki-CodeReview] [MediaWiki r107140]: Revision status changed

2011-12-23 Thread MediaWiki Mail
Santhosh.thottingal changed the status of MediaWiki.r107140 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107140 Old status: new New status: ok Commit summary for MediaWiki.r107140: Stylize ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r107141]: Revision status changed

2011-12-23 Thread MediaWiki Mail
Santhosh.thottingal changed the status of MediaWiki.r107141 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107141 Old status: new New status: ok Commit summary for MediaWiki.r107141: Typos, code conventions ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r107112]: New comment added, and revision status changed

2011-12-23 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107112 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107112#c28404 Old Status: new New Status: fixme Commit summary for MediaWiki.r107112: Protocol-relative URLs on SiteMatrix. URLs with http:// are needed for

[MediaWiki-CodeReview] [MediaWiki r107113]: Revision status changed

2011-12-23 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107113 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107113 Old status: deferred New status: ok Commit summary for MediaWiki.r107113: errant comma causing IE7 errors, may fix bug#33316

[MediaWiki-CodeReview] [MediaWiki r107115]: Revision status changed

2011-12-23 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107115 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107115 Old status: new New status: ok Commit summary for MediaWiki.r107115: small fix for spacing and search button ___

[MediaWiki-CodeReview] [MediaWiki r107116]: Revision status changed

2011-12-23 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107116 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107116 Old status: deferred New status: ok Commit summary for MediaWiki.r107116: * Removed useless call to LinkCache::singleton() * Removed PHP4-ism * Call

[MediaWiki-CodeReview] [MediaWiki r107052]: Revision status changed

2011-12-23 Thread MediaWiki Mail
Santhosh.thottingal changed the status of MediaWiki.r107052 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107052 Old status: new New status: ok Commit summary for MediaWiki.r107052: I18n #319: don't show discouraged groups in Special:LanguageStats

[MediaWiki-CodeReview] [MediaWiki r107053]: Revision status changed

2011-12-23 Thread MediaWiki Mail
Santhosh.thottingal changed the status of MediaWiki.r107053 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107053 Old status: new New status: ok Commit summary for MediaWiki.r107053: Rename sgroup to subgroup for clarity and consistency

[MediaWiki-CodeReview] [MediaWiki r107099]: New comment added

2011-12-23 Thread MediaWiki Mail
Kipmaster posted a comment on MediaWiki.r107099. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107099#c28405 Commit summary for MediaWiki.r107099: ext.Wikidata.rtl Kipmaster's comment: So I just need one css? That would be nice! ___

[MediaWiki-CodeReview] [MediaWiki r107123]: New comment added

2011-12-23 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r107123. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107123#c28406 Commit summary for MediaWiki.r107123: Fixup CA js/css per Roan on r106782 Also removed copypasta message from CR Nikerabbit's comment: My first reaction was wtf is CA

[MediaWiki-CodeReview] [MediaWiki r100933]: New comment added

2011-12-23 Thread MediaWiki Mail
Hashar posted a comment on MediaWiki.r100933. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100933#c28407 Commit summary for MediaWiki.r100933: Quick and ugly fix to stop installs with CACHE_DB from immediately failing with DB errors. Something is wonked with the order of temp table

[MediaWiki-CodeReview] [MediaWiki r105404]: New comment added

2011-12-23 Thread MediaWiki Mail
Petrb posted a comment on MediaWiki.r105404. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105404#c28408 Commit summary for MediaWiki.r105404: commited for brion for review Petrb's comment: resolved ;) ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r107148]: Revision status changed

2011-12-23 Thread MediaWiki Mail
Santhosh.thottingal changed the status of MediaWiki.r107148 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107148 Old status: new New status: ok Commit summary for MediaWiki.r107148: Followup r106942 - I added new tooltips but forgot to use two of them

[MediaWiki-CodeReview] [MediaWiki r107139]: Revision status changed

2011-12-23 Thread MediaWiki Mail
Santhosh.thottingal changed the status of MediaWiki.r107139 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107139 Old status: new New status: ok Commit summary for MediaWiki.r107139: Followup r107102 - consistent whitespace ___

[MediaWiki-CodeReview] [MediaWiki r107138]: Revision status changed

2011-12-23 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107138 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107138 Old status: new New status: ok Commit summary for MediaWiki.r107138: Correct the page link since it is moved in mediawiki.org.

[MediaWiki-CodeReview] [MediaWiki r107143]: Revision status changed

2011-12-23 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107143 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107143 Old status: new New status: ok Commit summary for MediaWiki.r107143: Update punctuation for error messages. ___

[MediaWiki-CodeReview] [MediaWiki r107145]: Revision status changed

2011-12-23 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107145 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107145 Old status: new New status: ok Commit summary for MediaWiki.r107145: Update tags. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r105404]: Revision status changed

2011-12-23 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r105404 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105404 Old status: new New status: resolved Commit summary for MediaWiki.r105404: commited for brion for review ___

[MediaWiki-CodeReview] [MediaWiki r106942]: Revision status changed

2011-12-23 Thread MediaWiki Mail
Santhosh.thottingal changed the status of MediaWiki.r106942 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106942 Old status: new New status: ok Commit summary for MediaWiki.r106942: I18n #321: UI for making translatable pages discouraged/encouraged

[MediaWiki-CodeReview] [MediaWiki r105922]: Revision status changed

2011-12-23 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r105922 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105922 Old status: new New status: ok Commit summary for MediaWiki.r105922: Introduce a Language::getMessagesFileName hook that will allow extensions to define new language

[MediaWiki-CodeReview] [MediaWiki r104966]: Revision status changed

2011-12-23 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r104966 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104966 Old status: deferred New status: ok Commit summary for MediaWiki.r104966: complete message documentation ___

[MediaWiki-CodeReview] [MediaWiki r102160]: New comment added

2011-12-23 Thread MediaWiki Mail
Schnark posted a comment on MediaWiki.r102160. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102160#c28410 Commit summary for MediaWiki.r102160: Merging ReferenceTooltips into Cite step 2: rename/register Schnark's comment: * The backlinks in the tooltip are worthless and shouldn't

[MediaWiki-CodeReview] [MediaWiki r101049]: Revision status changed

2011-12-23 Thread MediaWiki Mail
MaxSem changed the status of MediaWiki.r101049 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101049 Old status: new New status: ok Commit summary for MediaWiki.r101049: FU r100915: split out GlobalWithDBTest (tests which need the DB)

[MediaWiki-CodeReview] [MediaWiki r104314]: Revision status changed

2011-12-23 Thread MediaWiki Mail
MaxSem changed the status of MediaWiki.r104314 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104314 Old status: new New status: resolved Commit summary for MediaWiki.r104314: Added parser test about brackets and for bug 21261

[MediaWiki-CodeReview] [MediaWiki r104551]: Revision status changed

2011-12-23 Thread MediaWiki Mail
MaxSem changed the status of MediaWiki.r104551 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104551 Old status: new New status: ok Commit summary for MediaWiki.r104551: abstract out $data and name it 'sectionData' Makes things easier to handle when calling other methods.

[MediaWiki-CodeReview] [MediaWiki r100570]: Revision status changed

2011-12-23 Thread MediaWiki Mail
MaxSem changed the status of MediaWiki.r100570 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100570 Old status: new New status: ok Commit summary for MediaWiki.r100570: Moved CU table pruning to ArticleEditUpdatesDeleteFromRecentchanges hook for a bit more consistency with

[MediaWiki-CodeReview] [MediaWiki r100602]: Revision status changed

2011-12-23 Thread MediaWiki Mail
MaxSem changed the status of MediaWiki.r100602 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100602 Old status: new New status: ok Commit summary for MediaWiki.r100602: Followup r100509: Increase GADGET_CLASS_VERSION ___

[MediaWiki-CodeReview] [MediaWiki r100743]: Revision status changed

2011-12-23 Thread MediaWiki Mail
MaxSem changed the status of MediaWiki.r100743 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100743 Old status: new New status: ok Commit summary for MediaWiki.r100743: Case differs between filename and php file. Bug report at

[MediaWiki-CodeReview] [MediaWiki r106797]: Revision status changed

2011-12-23 Thread MediaWiki Mail
Santhosh.thottingal changed the status of MediaWiki.r106797 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106797 Old status: new New status: ok Commit summary for MediaWiki.r106797: I18n #320: new section for discouraged pages Also took the time to refactor the code and

[MediaWiki-CodeReview] [MediaWiki r106792]: Revision status changed

2011-12-23 Thread MediaWiki Mail
Santhosh.thottingal changed the status of MediaWiki.r106792 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106792 Old status: new New status: ok Commit summary for MediaWiki.r106792: Refactor and remove some unncessary links ___

[MediaWiki-CodeReview] [MediaWiki r106790]: Revision status changed

2011-12-23 Thread MediaWiki Mail
Santhosh.thottingal changed the status of MediaWiki.r106790 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106790 Old status: new New status: ok Commit summary for MediaWiki.r106790: Move call where it actually has an effect ___

[MediaWiki-CodeReview] [MediaWiki r106791]: New comment added

2011-12-23 Thread MediaWiki Mail
Santhosh.thottingal posted a comment on MediaWiki.r106791. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106791#c28411 Commit summary for MediaWiki.r106791: Show the diff helper labels only once Santhosh.thottingal's comment: Does it make sense to put New Text and Previous Text

[MediaWiki-CodeReview] [MediaWiki r106180]: Revision status changed

2011-12-23 Thread MediaWiki Mail
Santhosh.thottingal changed the status of MediaWiki.r106180 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106180 Old status: new New status: ok Commit summary for MediaWiki.r106180: Some JSHint fixes ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r106789]: Revision status changed

2011-12-23 Thread MediaWiki Mail
Santhosh.thottingal changed the status of MediaWiki.r106789 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106789 Old status: new New status: ok Commit summary for MediaWiki.r106789: Split Special:PageTranslation styles into different module

[MediaWiki-CodeReview] [MediaWiki r107150]: Revision status changed

2011-12-23 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107150 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107150 Old status: new New status: ok Commit summary for MediaWiki.r107150: Add some consistency to grouppage-*. ___

[MediaWiki-CodeReview] [MediaWiki r107151]: Revision status changed

2011-12-23 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107151 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107151 Old status: new New status: resolved Commit summary for MediaWiki.r107151: Fix typo. ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r107152]: New comment added, and revision status changed

2011-12-23 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107152 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107152#c28412 Old Status: new New Status: ok Commit summary for MediaWiki.r107152: Fix typo in typo fix (what!?) Nikerabbit's comment: Come to think about it,

[MediaWiki-CodeReview] [MediaWiki r107153]: New comment added, and revision status changed

2011-12-23 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107153 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107153#c28414 Old Status: new New Status: ok Commit summary for MediaWiki.r107153: More typos. Nikerabbit's comment: You're taking all the fun out of it!

[MediaWiki-CodeReview] [MediaWiki r107154]: New comment added

2011-12-23 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r107154. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107154#c28415 Commit summary for MediaWiki.r107154: Formatting, use plain HTML when no tag attributes or content are involved Nikerabbit's comment: Use at least prehr //pre then.

[MediaWiki-CodeReview] [MediaWiki r107146]: Revision status changed

2011-12-23 Thread MediaWiki Mail
Santhosh.thottingal changed the status of MediaWiki.r107146 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107146 Old status: new New status: ok Commit summary for MediaWiki.r107146: Update README for new paths ___

[MediaWiki-CodeReview] [MediaWiki r107032]: New comment added

2011-12-23 Thread MediaWiki Mail
SPQRobin posted a comment on MediaWiki.r107032. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107032#c28416 Commit summary for MediaWiki.r107032: Add some letters per https://incubator.wikimedia.org/w/index.php?diff=666382oldid=664736 SPQRobin's comment: This language file is not

[MediaWiki-CodeReview] [MediaWiki r106819]: Revision status changed

2011-12-23 Thread MediaWiki Mail
SPQRobin changed the status of MediaWiki.r106819 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106819 Old status: new New status: ok Commit summary for MediaWiki.r106819: Fix XSS vulnerabilities ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r98858]: Revision status changed

2011-12-23 Thread MediaWiki Mail
SPQRobin changed the status of MediaWiki.r98858 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98858 Old status: new New status: ok Commit summary for MediaWiki.r98858: RL2: Fix typo in r98837 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r107154]: Revision status changed

2011-12-23 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107154 to fixme URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107154 Old status: new New status: fixme Commit summary for MediaWiki.r107154: Formatting, use plain HTML when no tag attributes or content are involved

[MediaWiki-CodeReview] [MediaWiki r107149]: Revision status changed

2011-12-23 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107149 to deferred URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107149 Old status: new New status: deferred Commit summary for MediaWiki.r107149: Fix misspelling. Spotted by Amir. ___

[MediaWiki-CodeReview] [MediaWiki r100813]: New comment added, and revision status changed

2011-12-23 Thread MediaWiki Mail
MaxSem changed the status of MediaWiki.r100813 to resolved and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100813#c28418 Old Status: new New Status: resolved Commit summary for MediaWiki.r100813: Bug 31609 - Option to change reCAPTCHA theme Patch by Nx.devnull

[MediaWiki-CodeReview] [MediaWiki r107134]: Revision status changed

2011-12-23 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107134 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107134 Old status: new New status: ok Commit summary for MediaWiki.r107134: You know, if I'm going to release a version of OpenStackManager, I should probably up the version...

[MediaWiki-CodeReview] [MediaWiki r107133]: Revision status changed

2011-12-23 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107133 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107133 Old status: new New status: ok Commit summary for MediaWiki.r107133: Adding forgotten class variable definition. ___

[MediaWiki-CodeReview] [MediaWiki r107132]: New comment added, and revision status changed

2011-12-23 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107132 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107132#c28419 Old Status: new New Status: ok Commit summary for MediaWiki.r107132: Refactor LDAP connections, for performance and less code duplication.

[MediaWiki-CodeReview] [MediaWiki r107124]: Revision status changed

2011-12-23 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107124 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107124 Old status: new New status: ok Commit summary for MediaWiki.r107124: caching disabling necessary for all functions for better working

[MediaWiki-CodeReview] [MediaWiki r107124]: New comment added

2011-12-23 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r107124. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107124#c28420 Commit summary for MediaWiki.r107124: caching disabling necessary for all functions for better working Nikerabbit's comment: It's the cost you have to pay.

[MediaWiki-CodeReview] [MediaWiki r107122]: New comment added, and revision status changed

2011-12-23 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107122 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107122#c28421 Old Status: new New Status: ok Commit summary for MediaWiki.r107122: Documentation fixes Nikerabbit's comment: Some duplication here?

[MediaWiki-CodeReview] [MediaWiki r107117]: Revision status changed

2011-12-23 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107117 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107117 Old status: new New status: ok Commit summary for MediaWiki.r107117: stderr redirection is portable after all, however, single quotes in shell commands are not

[MediaWiki-CodeReview] [MediaWiki r107108]: New comment added

2011-12-23 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r107108. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107108#c28422 Commit summary for MediaWiki.r107108: Make the external URLs to portals like www.wikipedia.org protocol-relative Nikerabbit's comment: Does this need to be deployed? If you

[MediaWiki-CodeReview] [MediaWiki r107094]: Revision status changed

2011-12-23 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107094 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107094 Old status: new New status: ok Commit summary for MediaWiki.r107094: Change isset() to array_key_exists(). Calling the former with the latter's parameter list doesn't

[MediaWiki-CodeReview] [MediaWiki r107156]: Revision status changed

2011-12-23 Thread MediaWiki Mail
Santhosh.thottingal changed the status of MediaWiki.r107156 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107156 Old status: new New status: ok Commit summary for MediaWiki.r107156: Noe more place to hide discouraged groups ___

[MediaWiki-CodeReview] [MediaWiki r106651]: Revision status changed

2011-12-23 Thread MediaWiki Mail
Santhosh.thottingal changed the status of MediaWiki.r106651 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106651 Old status: new New status: ok Commit summary for MediaWiki.r106651: I18n #315: Have Special:Translate not show outdated pages as translatable

[MediaWiki-CodeReview] [MediaWiki r107084]: New comment added

2011-12-23 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r107084. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107084#c28423 Commit summary for MediaWiki.r107084: added filtering of item ids to prevent potential mass queries to server on one item Nikerabbit's comment: Typo preveny

[MediaWiki-CodeReview] [MediaWiki r107093]: New comment added

2011-12-23 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r107093. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107093#c28424 Commit summary for MediaWiki.r107093: added method to remove item from array by value to solve bug with reloading item, follow up r107081 Nikerabbit's comment: Did you

[MediaWiki-CodeReview] [MediaWiki r101108]: Revision status changed

2011-12-23 Thread MediaWiki Mail
MaxSem changed the status of MediaWiki.r101108 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101108 Old status: new New status: ok Commit summary for MediaWiki.r101108: Removed useless usage of $wgUseNormalUser in WikimediaMaintenance. Maintenance doesn't even check this

[MediaWiki-CodeReview] [MediaWiki r107081]: New comment added, and revision status changed

2011-12-23 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107081 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107081#c28425 Old Status: new New Status: fixme Commit summary for MediaWiki.r107081: added gender support for x thinks this helpful. follow up r106743

[MediaWiki-CodeReview] [MediaWiki r107078]: Revision status changed

2011-12-23 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107078 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107078 Old status: new New status: ok Commit summary for MediaWiki.r107078: follow up to -r106985 - Use assignment style for NULL value in where clause

[MediaWiki-CodeReview] [MediaWiki r107108]: New comment added

2011-12-23 Thread MediaWiki Mail
SPQRobin posted a comment on MediaWiki.r107108. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107108#c28426 Commit summary for MediaWiki.r107108: Make the external URLs to portals like www.wikipedia.org protocol-relative SPQRobin's comment: Deployment would be nice, yes (but not

[MediaWiki-CodeReview] [MediaWiki r101149]: Revision status changed

2011-12-23 Thread MediaWiki Mail
MaxSem changed the status of MediaWiki.r101149 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101149 Old status: new New status: ok Commit summary for MediaWiki.r101149: fixed bug 31613 (API UsageException when saving a collection to a page)

[MediaWiki-CodeReview] [MediaWiki r102950]: Revision status changed

2011-12-23 Thread MediaWiki Mail
MaxSem changed the status of MediaWiki.r102950 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102950 Old status: new New status: ok Commit summary for MediaWiki.r102950: 1.18wmf1: MFT r101149 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r107073]: Revision status changed

2011-12-23 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107073 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107073 Old status: new New status: ok Commit summary for MediaWiki.r107073: (bug 12262) Follow-up r102026: update ul margin in shared.css

[MediaWiki-CodeReview] [MediaWiki r107069]: Revision status changed

2011-12-23 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107069 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107069 Old status: new New status: ok Commit summary for MediaWiki.r107069: wrap linecomment js initializer in a ready() block follow up r95435

[MediaWiki-CodeReview] [MediaWiki r107062]: Revision status changed

2011-12-23 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107062 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107062 Old status: new New status: ok Commit summary for MediaWiki.r107062: Update comments a bit. ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r107054]: New comment added

2011-12-23 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r107054. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107054#c28427 Commit summary for MediaWiki.r107054: do not evaluate '?php' line This happen when you are sending to eval.php a php file. The first line is the string '?php' which is

[MediaWiki-CodeReview] [MediaWiki r101257]: Revision status changed

2011-12-23 Thread MediaWiki Mail
MaxSem changed the status of MediaWiki.r101257 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101257 Old status: new New status: ok Commit summary for MediaWiki.r101257: Looks like my simple Ajax buttons cause two different bugs in two different browsers * Firefox marks same

[MediaWiki-CodeReview] [MediaWiki r107034]: New comment added, and revision status changed

2011-12-23 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107034 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107034#c28428 Old Status: new New Status: fixme Commit summary for MediaWiki.r107034: clean up Nikerabbit's comment: $searchValue should be html escaped.

[MediaWiki-CodeReview] [MediaWiki r107033]: Revision status changed

2011-12-23 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107033 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107033 Old status: new New status: ok Commit summary for MediaWiki.r107033: Upgrade aws-sdk libs to 1.4.8.1. ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r107017]: Revision status changed

2011-12-23 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107017 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107017 Old status: new New status: ok Commit summary for MediaWiki.r107017: added missing UploadStash exceptions to AutoLoader ___

[MediaWiki-CodeReview] [MediaWiki r107034]: New comment added, and revision status changed

2011-12-23 Thread MediaWiki Mail
MaxSem changed the status of MediaWiki.r107034 to resolved and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107034#c28429 Old Status: fixme New Status: resolved Commit summary for MediaWiki.r107034: clean up MaxSem's comment: Resolved in a later revision.

Re: [Wikitech-l] Making the Lua/Javascript decision (Re: Performance roadmap update)

2011-12-23 Thread Jay Ashworth
- Original Message - From: Victor Vasiliev vasi...@gmail.com Lua is great, however, it's a bit strange to use two interpreters (PHP+Lua) together. That limits hosting possibilities and it's something like using two similar screwdrivers for the same screw. Not really. Lua was

[MediaWiki-CodeReview] [MediaWiki r102890]: New comment added

2011-12-23 Thread MediaWiki Mail
MaxSem posted a comment on MediaWiki.r102890. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102890#c28430 Commit summary for MediaWiki.r102890: Removed transaction in saveOptions(). No reason was given for it and it could break any callers that have transactions. MaxSem's comment:

[MediaWiki-CodeReview] [MediaWiki r107112]: Revision status changed

2011-12-23 Thread MediaWiki Mail
SPQRobin changed the status of MediaWiki.r107112 to new URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107112 Old status: fixme New status: new Commit summary for MediaWiki.r107112: Protocol-relative URLs on SiteMatrix. URLs with http:// are needed for the API, so make it as an

[MediaWiki-CodeReview] [MediaWiki r103523]: Revision status changed

2011-12-23 Thread MediaWiki Mail
MaxSem changed the status of MediaWiki.r103523 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103523 Old status: new New status: resolved Commit summary for MediaWiki.r103523: Category autocomplete now only suggests categories that have corresponding description pages.

Re: [Wikitech-l] Making the Lua/Javascript decision (Re: Performance roadmap update)

2011-12-23 Thread Gabriel Wicke
I do have some spare time over the holiday and I can take a shot at hacking together a node.js equivalent of the Lua extension. Is that really the highest priority though? I'm willing to do it, but it seems like there are also a lot of other questions to be answered besides just the

[MediaWiki-CodeReview] [MediaWiki r103882]: Revision status changed

2011-12-23 Thread MediaWiki Mail
MaxSem changed the status of MediaWiki.r103882 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103882 Old status: new New status: ok Commit summary for MediaWiki.r103882: whitespace fixes ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r103893]: Revision status changed

2011-12-23 Thread MediaWiki Mail
MaxSem changed the status of MediaWiki.r103893 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103893 Old status: new New status: ok Commit summary for MediaWiki.r103893: Implement a number of namespace related equals functions: * MWNamespace::equals to test equivalence of two

[MediaWiki-CodeReview] [MediaWiki r100274]: New comment added, and revision status changed

2011-12-23 Thread MediaWiki Mail
Siebrand changed the status of MediaWiki.r100274 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100274#c28431 Old Status: ok New Status: fixme Commit summary for MediaWiki.r100274: created basic reminder email functionality Siebrand's comment: +

[MediaWiki-CodeReview] [MediaWiki r99522]: New comment added, and revision status changed

2011-12-23 Thread MediaWiki Mail
Siebrand changed the status of MediaWiki.r99522 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99522#c28432 Old Status: deferred New Status: fixme Commit summary for MediaWiki.r99522: Adding new extension LastModified. Siebrand's comment: This needs

Re: [Wikitech-l] Making the Lua/Javascript decision (Re: Performance roadmap update)

2011-12-23 Thread Dmitriy Sintsov
On 23.12.2011 18:30, Jay Ashworth wrote: This is a really critical point: if you're going to provide an interpreted language to end-users from within a program that is, itself, written in an interpreted language, *you cannot use the underlying interpreter* to run the end-users' programs,

[MediaWiki-CodeReview] [MediaWiki r104525]: Revision status changed

2011-12-23 Thread MediaWiki Mail
MaxSem changed the status of MediaWiki.r104525 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104525 Old status: new New status: ok Commit summary for MediaWiki.r104525: spelling and comment fixes ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r104613]: Revision status changed

2011-12-23 Thread MediaWiki Mail
MaxSem changed the status of MediaWiki.r104613 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104613 Old status: new New status: ok Commit summary for MediaWiki.r104613: [UserDailyContribs] Add friendly reminder. ___

  1   2   >