[MediaWiki-CodeReview] [MediaWiki r110103]: New comment added

2012-01-27 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r110103. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110103#c30089 Commit summary for MediaWiki.r110103: phpunit testcases on the plural rules for am, ar, be, be_tarask, bh, bs and hi languages Nikerabbit's comment: We usually spell

[MediaWiki-CodeReview] [MediaWiki r110103]: New comment added

2012-01-27 Thread MediaWiki Mail
Santhosh.thottingal posted a comment on MediaWiki.r110103. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110103#c30090 Commit summary for MediaWiki.r110103: phpunit testcases on the plural rules for am, ar, be, be_tarask, bh, bs and hi languages Santhosh.thottingal's comment: I

[MediaWiki-CodeReview] [MediaWiki r110099]: Revision status changed

2012-01-27 Thread MediaWiki Mail
Siebrand changed the status of MediaWiki.r110099 to deferred URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110099 Old status: new New status: deferred Commit summary for MediaWiki.r110099: updated path to test date ___

[MediaWiki-CodeReview] [MediaWiki r110105]: Revision status changed

2012-01-27 Thread MediaWiki Mail
Siebrand changed the status of MediaWiki.r110105 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110105 Old status: new New status: ok Commit summary for MediaWiki.r110105: * (bug 33762) QueryPage-based special pages no longer misses *-summary message

[Wikitech-l] One-time run of maintenance scripts to fix years-old utter brokeness

2012-01-27 Thread Federico Leva (Nemo)
There are several maintenance scripts waiting to be run on many wikis since years ago: https://bugzilla.wikimedia.org/showdependencytree.cgi?id=29782hide_resolved=1 The biggest offenders are: * https://bugzilla.wikimedia.org/show_bug.cgi?id=16112 which breaks tons of special pages; *

Re: [Wikitech-l] One-time run of maintenance scripts to fix years-old utter brokeness

2012-01-27 Thread Petr Bena
If the script is optimized per Brion recommendations, I think we could execute it immediately... I don't really know why ops didn't do that, I was in though that it's cronned to run certain jobs On Fri, Jan 27, 2012 at 11:45 AM, Federico Leva (Nemo) nemow...@gmail.comwrote: There are several

[MediaWiki-CodeReview] [MediaWiki r2969]: New comment added

2012-01-27 Thread MediaWiki Mail
Dantman posted a comment on MediaWiki.r2969. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/2969#c30091 Commit summary for MediaWiki.r2969: Added code to implement Dublin Core and Creative Commons RDF metadata. If these features are turned on (with global flags), a metadata link tag

[MediaWiki-CodeReview] [MediaWiki r110101]: Revision status changed

2012-01-27 Thread MediaWiki Mail
Reedy changed the status of MediaWiki.r110101 to deferred URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110101 Old status: new New status: deferred Commit summary for MediaWiki.r110101: New extension that implements some preview related functions -

[MediaWiki-CodeReview] [MediaWiki r110094]: Revision status changed

2012-01-27 Thread MediaWiki Mail
Reedy changed the status of MediaWiki.r110094 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110094 Old status: new New status: ok Commit summary for MediaWiki.r110094: 1.18wmf1: Updating MoodBar to trunk state ___

[MediaWiki-CodeReview] [MediaWiki r110112]: New comment added

2012-01-27 Thread MediaWiki Mail
Siebrand posted a comment on MediaWiki.r110112. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110112#c30092 Commit summary for MediaWiki.r110112: Add PHPUnit tests for plural rules. For languages cs, cu, cy, dsb, fr, ga, gd, gv, hr, hsb, hy, ksh, ln Siebrand's comment: Shouldn't

[MediaWiki-CodeReview] [MediaWiki r110114]: Revision status changed

2012-01-27 Thread MediaWiki Mail
Reedy changed the status of MediaWiki.r110114 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110114 Old status: new New status: ok Commit summary for MediaWiki.r110114: Fix from Dzrraf2 to avoid issues if directory does not open.

[MediaWiki-CodeReview] [MediaWiki r109106]: Revision status changed

2012-01-27 Thread MediaWiki Mail
Reedy changed the status of MediaWiki.r109106 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109106 Old status: new New status: ok Commit summary for MediaWiki.r109106: * Fixed type check in StreamFile::prepareForStream() for 404s * Code comment tweaks and fixes

[MediaWiki-CodeReview] [MediaWiki r110112]: New comment added

2012-01-27 Thread MediaWiki Mail
Santhosh.thottingal posted a comment on MediaWiki.r110112. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110112#c30093 Commit summary for MediaWiki.r110112: Add PHPUnit tests for plural rules. For languages cs, cu, cy, dsb, fr, ga, gd, gv, hr, hsb, hy, ksh, ln Santhosh.thottingal's

[MediaWiki-CodeReview] [MediaWiki r109698]: Revision status changed

2012-01-27 Thread MediaWiki Mail
^demon changed the status of MediaWiki.r109698 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109698 Old status: fixme New status: resolved Commit summary for MediaWiki.r109698: [Unit testing] Add unit tests for Xml::namespaceSelector * Making Language::namespaceNames

[MediaWiki-CodeReview] [MediaWiki r109993]: Revision status changed

2012-01-27 Thread MediaWiki Mail
^demon changed the status of MediaWiki.r109993 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109993 Old status: new New status: resolved Commit summary for MediaWiki.r109993: [Html] Unit test + bugfix Html::namespaceSelector * Previously it was passing

[MediaWiki-CodeReview] [MediaWiki r109994]: Revision status changed

2012-01-27 Thread MediaWiki Mail
^demon changed the status of MediaWiki.r109994 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109994 Old status: new New status: resolved Commit summary for MediaWiki.r109994: Fix broken unit test * r109993 broke the test by overwriting namespaces it tried to preserve *

[MediaWiki-CodeReview] [MediaWiki r109990]: Revision status changed

2012-01-27 Thread MediaWiki Mail
^demon changed the status of MediaWiki.r109990 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109990 Old status: new New status: ok Commit summary for MediaWiki.r109990: [Xml/Html] new method Html::namespaceSelector * Using params and option arrays instead of 4 random

[MediaWiki-CodeReview] [MediaWiki r110118]: Revision status changed

2012-01-27 Thread MediaWiki Mail
Reedy changed the status of MediaWiki.r110118 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110118 Old status: new New status: ok Commit summary for MediaWiki.r110118: Fixup r109698, add setter for $namespaceNames and use proper accessors in the tests. Since we're here:

[MediaWiki-CodeReview] [MediaWiki r110111]: Revision status changed

2012-01-27 Thread MediaWiki Mail
^demon changed the status of MediaWiki.r110111 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110111 Old status: new New status: ok Commit summary for MediaWiki.r110111: Compressed a few images ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r109901]: Revision status changed

2012-01-27 Thread MediaWiki Mail
Reedy changed the status of MediaWiki.r109901 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109901 Old status: new New status: ok Commit summary for MediaWiki.r109901: * Moved FSFile classes from file/ to backend/ * Improved $this-lockCount check in LockServerDaemon

[MediaWiki-CodeReview] [MediaWiki r109992]: Revision status changed

2012-01-27 Thread MediaWiki Mail
^demon changed the status of MediaWiki.r109992 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109992 Old status: new New status: ok Commit summary for MediaWiki.r109992: fix bug 33513, localized alternative upload forms ___

[MediaWiki-CodeReview] [MediaWiki r109603]: Revision status changed

2012-01-27 Thread MediaWiki Mail
^demon changed the status of MediaWiki.r109603 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109603 Old status: new New status: ok Commit summary for MediaWiki.r109603: This Wikipedia mirror has already disappeared. ___

[MediaWiki-CodeReview] [MediaWiki r110106]: Revision status changed

2012-01-27 Thread MediaWiki Mail
^demon changed the status of MediaWiki.r110106 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110106 Old status: new New status: ok Commit summary for MediaWiki.r110106: Use Language::userTimeAndDate() and related to get the time with user preferences instead of

[MediaWiki-CodeReview] [MediaWiki r109161]: New comment added, and revision status changed

2012-01-27 Thread MediaWiki Mail
^demon changed the status of MediaWiki.r109161 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109161#c30094 Old Status: new New Status: ok Commit summary for MediaWiki.r109161: deprecated $query2 in Title.php $query2 was used to pass a variant. Make that

[MediaWiki-CodeReview] [MediaWiki r109974]: Revision status changed

2012-01-27 Thread MediaWiki Mail
^demon changed the status of MediaWiki.r109974 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109974 Old status: new New status: ok Commit summary for MediaWiki.r109974: [Unit testing] Re-order attribs to a-z to make testing more reliable * This is in preparation for

[MediaWiki-CodeReview] [MediaWiki r109898]: New comment added, and revision status changed

2012-01-27 Thread MediaWiki Mail
Reedy changed the status of MediaWiki.r109898 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109898#c30095 Old Status: new New Status: ok Commit summary for MediaWiki.r109898: Timeline extension: * Updated code to use FileBackend * Don't stat the temp dir

[MediaWiki-CodeReview] [MediaWiki r110095]: Revision status changed

2012-01-27 Thread MediaWiki Mail
^demon changed the status of MediaWiki.r110095 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110095 Old status: new New status: ok Commit summary for MediaWiki.r110095: HtmlForm doesn't have contexty stuff in 1.18wmf1 ___

[MediaWiki-CodeReview] [MediaWiki r109809]: Revision status changed

2012-01-27 Thread MediaWiki Mail
^demon changed the status of MediaWiki.r109809 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109809 Old status: new New status: ok Commit summary for MediaWiki.r109809: * Added some wfProfileIn() calls to file backend code. * Made FileBackend::getFileProps() final. * Added

[MediaWiki-CodeReview] [MediaWiki r103151]: Revision status changed

2012-01-27 Thread MediaWiki Mail
^demon changed the status of MediaWiki.r103151 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103151 Old status: deferred New status: ok Commit summary for MediaWiki.r103151: Fix mixed eol-style Fix svn props Followup r103133 ___

[MediaWiki-CodeReview] [MediaWiki r103763]: New comment added

2012-01-27 Thread MediaWiki Mail
^demon posted a comment on MediaWiki.r103763. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103763#c30096 Commit summary for MediaWiki.r103763: (bug 31982) Handle fallback languages in LocalisationUpdate. Modified patch by Umherirrender ^demon's comment: Status on this?

[MediaWiki-CodeReview] [MediaWiki r98081]: New comment added

2012-01-27 Thread MediaWiki Mail
^demon posted a comment on MediaWiki.r98081. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98081#c30097 Commit summary for MediaWiki.r98081: New extension that adds a checkbox to Special:UserLogin/signup and requires users to check it in order for their account to be created (ping

[MediaWiki-CodeReview] [MediaWiki r107980]: New comment added, and revision status changed

2012-01-27 Thread MediaWiki Mail
Reedy changed the status of MediaWiki.r107980 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107980#c30098 Old Status: ok New Status: fixme Commit summary for MediaWiki.r107980: * Added supported for container sharding via existing FileRepo-style hash

[MediaWiki-CodeReview] [MediaWiki r103763]: New comment added

2012-01-27 Thread MediaWiki Mail
Liangent posted a comment on MediaWiki.r103763. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103763#c30099 Commit summary for MediaWiki.r103763: (bug 31982) Handle fallback languages in LocalisationUpdate. Modified patch by Umherirrender Liangent's comment: Seems partly fixed and

[MediaWiki-CodeReview] [MediaWiki r107980]: New comment added

2012-01-27 Thread MediaWiki Mail
Reedy posted a comment on MediaWiki.r107980. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107980#c30100 Commit summary for MediaWiki.r107980: * Added supported for container sharding via existing FileRepo-style hash paths. For sharded containers, all paths used to store files must

[MediaWiki-CodeReview] [MediaWiki r103763]: New comment added

2012-01-27 Thread MediaWiki Mail
Liangent posted a comment on MediaWiki.r103763. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103763#c30101 Commit summary for MediaWiki.r103763: (bug 31982) Handle fallback languages in LocalisationUpdate. Modified patch by Umherirrender Liangent's comment: Can we cache English

[MediaWiki-CodeReview] [MediaWiki r110124]: New comment added

2012-01-27 Thread MediaWiki Mail
Dantman posted a comment on MediaWiki.r110124. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110124#c30102 Commit summary for MediaWiki.r110124: Copy FilesystemIterator constants so we can still pretend to support 5.2 Dantman's comment: The constants aren't the only things that are

[MediaWiki-CodeReview] [MediaWiki r110120]: Revision status changed

2012-01-27 Thread MediaWiki Mail
MarkAHershberger changed the status of MediaWiki.r110120 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110120 Old status: new New status: ok Commit summary for MediaWiki.r110120: Minor tweak to r109161, remove trailing this ___

[MediaWiki-CodeReview] [MediaWiki r108194]: New comment added, and revision status changed

2012-01-27 Thread MediaWiki Mail
^demon changed the status of MediaWiki.r108194 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108194#c30103 Old Status: ok New Status: fixme Commit summary for MediaWiki.r108194: r108192: Explicitly set flags for RecursiveDirectoryIterator constructor

[MediaWiki-CodeReview] [MediaWiki r110122]: New comment added

2012-01-27 Thread MediaWiki Mail
MarkAHershberger posted a comment on MediaWiki.r110122. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110122#c30104 Commit summary for MediaWiki.r110122: Fix undefined $dirRoot MarkAHershberger's comment: Are you sure this shouldn't be $dir?

[MediaWiki-CodeReview] [MediaWiki r110125]: Revision status changed

2012-01-27 Thread MediaWiki Mail
^demon changed the status of MediaWiki.r110125 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110125 Old status: new New status: ok Commit summary for MediaWiki.r110125: Add documentation Fix whitespace ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r110126]: Revision status changed

2012-01-27 Thread MediaWiki Mail
Reedy changed the status of MediaWiki.r110126 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110126 Old status: new New status: ok Commit summary for MediaWiki.r110126: Self-revert r110124, needs more than that to support 5.2 since $flags don't exist in 5.2. Either this

[MediaWiki-CodeReview] [MediaWiki r110123]: Revision status changed

2012-01-27 Thread MediaWiki Mail
^demon changed the status of MediaWiki.r110123 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110123 Old status: new New status: ok Commit summary for MediaWiki.r110123: $this-substPaths takes 2 parameters protected function substPaths( $paths, FileBackend $backend ) { Pass

[MediaWiki-CodeReview] [MediaWiki r110122]: New comment added

2012-01-27 Thread MediaWiki Mail
Reedy posted a comment on MediaWiki.r110122. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110122#c30105 Commit summary for MediaWiki.r110122: Fix undefined $dirRoot Reedy's comment: Somewhat pre if ( !empty( $params['noAccess'] ) ) { if (

[MediaWiki-CodeReview] [MediaWiki r109878]: Revision status changed

2012-01-27 Thread MediaWiki Mail
Reedy changed the status of MediaWiki.r109878 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109878 Old status: new New status: ok Commit summary for MediaWiki.r109878: [InterfaceConcurrency] whitespace + missing dependency * whitespace * missing dependency (follows-up

[MediaWiki-CodeReview] [MediaWiki r110046]: New comment added, and revision status changed

2012-01-27 Thread MediaWiki Mail
Reedy changed the status of MediaWiki.r110046 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110046#c30106 Old Status: new New Status: ok Commit summary for MediaWiki.r110046: Stylize, and whitespace-tab fixes Reedy's comment: Not the fault of this commit

[MediaWiki-CodeReview] [MediaWiki r110127]: Revision status changed

2012-01-27 Thread MediaWiki Mail
^demon changed the status of MediaWiki.r110127 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110127 Old status: new New status: ok Commit summary for MediaWiki.r110127: Fix spurious character from r110122 ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r109597]: Revision status changed

2012-01-27 Thread MediaWiki Mail
Reedy changed the status of MediaWiki.r109597 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109597 Old status: new New status: ok Commit summary for MediaWiki.r109597: wrapped lines to 100 columns, re-enabled some tests that were disabled followup to r109594

[MediaWiki-CodeReview] [MediaWiki r110086]: New comment added

2012-01-27 Thread MediaWiki Mail
Gregchiasson posted a comment on MediaWiki.r110086. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110086#c30107 Commit summary for MediaWiki.r110086: AFT5 - SQL statements to rebuild the rollup tables using only bucket 1, and a fix to prevent loading errors if a record with no

[MediaWiki-CodeReview] [MediaWiki r109706]: Revision status changed

2012-01-27 Thread MediaWiki Mail
Reedy changed the status of MediaWiki.r109706 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109706 Old status: new New status: ok Commit summary for MediaWiki.r109706: * Another fix for SwiftFileBackend file listings * Fixed bogus array key reference in SwiftFileBackend

[MediaWiki-CodeReview] [MediaWiki r74159]: Revision status changed

2012-01-27 Thread MediaWiki Mail
^demon changed the status of MediaWiki.r74159 to old URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/74159 Old status: fixme New status: old Commit summary for MediaWiki.r74159: Do not use ForContent messages for the Special page messages. Note however that messages which end up in

[MediaWiki-CodeReview] [MediaWiki r98563]: New comment added

2012-01-27 Thread MediaWiki Mail
Reedy posted a comment on MediaWiki.r98563. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98563#c30108 Commit summary for MediaWiki.r98563: Followup r98500, conversion of the Javascript to use jQuery fully. It also makes the Javascript work outside of debug=1 (oops) There's a

[MediaWiki-CodeReview] [MediaWiki r108194]: New comment added

2012-01-27 Thread MediaWiki Mail
Dantman posted a comment on MediaWiki.r108194. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108194#c30109 Commit summary for MediaWiki.r108194: r108192: Explicitly set flags for RecursiveDirectoryIterator constructor Dantman's comment: nowiki;)/nowiki of course 5.2 was EOLed some

[MediaWiki-CodeReview] [MediaWiki r110122]: New comment added

2012-01-27 Thread MediaWiki Mail
Reedy posted a comment on MediaWiki.r110122. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110122#c30110 Commit summary for MediaWiki.r110122: Fix undefined $dirRoot Reedy's comment: Might just be easiest to get aaron to OK this one as he wrote the original code

[MediaWiki-CodeReview] [MediaWiki r110122]: New comment added

2012-01-27 Thread MediaWiki Mail
MarkAHershberger posted a comment on MediaWiki.r110122. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110122#c30111 Commit summary for MediaWiki.r110122: Fix undefined $dirRoot MarkAHershberger's comment: Right, but my question was based on how $dir is set up: $dir = ( $dirRel

[MediaWiki-CodeReview] [MediaWiki r110117]: Revision status changed

2012-01-27 Thread MediaWiki Mail
Reedy changed the status of MediaWiki.r110117 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110117 Old status: new New status: ok Commit summary for MediaWiki.r110117: dont run pass 2 if pass 1 failed ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r110130]: Revision status changed

2012-01-27 Thread MediaWiki Mail
Reedy changed the status of MediaWiki.r110130 to deferred URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110130 Old status: ok New status: deferred Commit summary for MediaWiki.r110130: svn:eol-style native ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r108194]: New comment added

2012-01-27 Thread MediaWiki Mail
Arseny1992 posted a comment on MediaWiki.r108194. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108194#c30112 Commit summary for MediaWiki.r108194: r108192: Explicitly set flags for RecursiveDirectoryIterator constructor Arseny1992's comment: Yes. I still running 5.2.10. When I

[MediaWiki-CodeReview] [MediaWiki r110130]: Revision status changed

2012-01-27 Thread MediaWiki Mail
MarkAHershberger changed the status of MediaWiki.r110130 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110130 Old status: deferred New status: ok Commit summary for MediaWiki.r110130: svn:eol-style native ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r108194]: New comment added

2012-01-27 Thread MediaWiki Mail
^demon posted a comment on MediaWiki.r108194. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108194#c30113 Commit summary for MediaWiki.r108194: r108192: Explicitly set flags for RecursiveDirectoryIterator constructor ^demon's comment: also, if 5.2 support broken, why the installer

[MediaWiki-CodeReview] [MediaWiki r110132]: New comment added

2012-01-27 Thread MediaWiki Mail
Reedy posted a comment on MediaWiki.r110132. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110132#c30114 Commit summary for MediaWiki.r110132: Fixes issues raised in commits from last night: - r110069 - Use rawParams (didn't know that existed) for the span, which allows escaping of

[MediaWiki-CodeReview] [MediaWiki r110134]: New comment added

2012-01-27 Thread MediaWiki Mail
Reedy posted a comment on MediaWiki.r110134. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110134#c30115 Commit summary for MediaWiki.r110134: creating a configuration file Reedy's comment: Please setup your [[Subversion/auto-props]] ___

[MediaWiki-CodeReview] [MediaWiki r110134]: Revision status changed

2012-01-27 Thread MediaWiki Mail
Reedy changed the status of MediaWiki.r110134 to deferred URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110134 Old status: new New status: deferred Commit summary for MediaWiki.r110134: creating a configuration file ___

[MediaWiki-CodeReview] [MediaWiki r110135]: Revision status changed

2012-01-27 Thread MediaWiki Mail
Reedy changed the status of MediaWiki.r110135 to deferred URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110135 Old status: new New status: deferred Commit summary for MediaWiki.r110135: Followup r110134 at least svn:eol-style native

[MediaWiki-CodeReview] [MediaWiki r110137]: Revision status changed

2012-01-27 Thread MediaWiki Mail
^demon changed the status of MediaWiki.r110137 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110137 Old status: new New status: ok Commit summary for MediaWiki.r110137: typo ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r110104]: New comment added, and revision status changed

2012-01-27 Thread MediaWiki Mail
^demon changed the status of MediaWiki.r110104 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110104#c30116 Old Status: new New Status: fixme Commit summary for MediaWiki.r110104: - pass wiki option to job threads in maintenance script - cleanup temporary

[MediaWiki-CodeReview] [MediaWiki r105675]: Revision status changed

2012-01-27 Thread MediaWiki Mail
^demon changed the status of MediaWiki.r105675 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105675 Old status: new New status: ok Commit summary for MediaWiki.r105675: Re-committing Asirra module after cleanup. Ping r91976 ___

[MediaWiki-CodeReview] [MediaWiki r104027]: Revision status changed

2012-01-27 Thread MediaWiki Mail
^demon changed the status of MediaWiki.r104027 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104027 Old status: new New status: resolved Commit summary for MediaWiki.r104027: Add direction mark for bug 32600, and put number of pages in message as parameter 2.

[MediaWiki-CodeReview] [MediaWiki r109594]: Revision status changed

2012-01-27 Thread MediaWiki Mail
Reedy changed the status of MediaWiki.r109594 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109594 Old status: new New status: ok Commit summary for MediaWiki.r109594: Added listCheckouts() and fixed some stuff per Tim's review: mediawiki doesn't use autocommit. don't

[MediaWiki-CodeReview] [MediaWiki r109290]: Revision status changed

2012-01-27 Thread MediaWiki Mail
Reedy changed the status of MediaWiki.r109290 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109290 Old status: new New status: ok Commit summary for MediaWiki.r109290: Followup r100509: Don't validate skin names written in the definition page.

[MediaWiki-CodeReview] [MediaWiki r109666]: New comment added

2012-01-27 Thread MediaWiki Mail
^demon posted a comment on MediaWiki.r109666. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109666#c30117 Commit summary for MediaWiki.r109666: added checkoutResult() for generating more informative user-facing errors ^demon's comment: Per the coding conventions, you shouldn't use

[MediaWiki-CodeReview] [MediaWiki r110138]: Revision status changed

2012-01-27 Thread MediaWiki Mail
^demon changed the status of MediaWiki.r110138 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110138 Old status: new New status: ok Commit summary for MediaWiki.r110138: Kill .cvsignore Already set for svn ignores ___

[MediaWiki-CodeReview] [MediaWiki r110140]: Revision status changed

2012-01-27 Thread MediaWiki Mail
MarkAHershberger changed the status of MediaWiki.r110140 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110140 Old status: new New status: ok Commit summary for MediaWiki.r110140: We don't support nor use php4 now ___

[MediaWiki-CodeReview] [MediaWiki r103313]: Revision status changed

2012-01-27 Thread MediaWiki Mail
Reedy changed the status of MediaWiki.r103313 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103313 Old status: new New status: ok Commit summary for MediaWiki.r103313: Bug 22194 - Respect page rotation that will be reported by poppler 0.20

[MediaWiki-CodeReview] [MediaWiki r110113]: Revision status changed

2012-01-27 Thread MediaWiki Mail
Reedy changed the status of MediaWiki.r110113 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110113 Old status: new New status: ok Commit summary for MediaWiki.r110113: also remove temp file if its 0 bytes ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r110142]: Revision status changed

2012-01-27 Thread MediaWiki Mail
^demon changed the status of MediaWiki.r110142 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110142 Old status: new New status: ok Commit summary for MediaWiki.r110142: Kill empty directory left after MobileFrontend rename ___

[MediaWiki-CodeReview] [MediaWiki r110141]: Revision status changed

2012-01-27 Thread MediaWiki Mail
^demon changed the status of MediaWiki.r110141 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110141 Old status: new New status: ok Commit summary for MediaWiki.r110141: Kill more old php4 stuff ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r110143]: New comment added

2012-01-27 Thread MediaWiki Mail
Reedy posted a comment on MediaWiki.r110143. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110143#c30118 Commit summary for MediaWiki.r110143: the location for antlr3 grammars Reedy's comment: Can you please set svn:eol-style native on any text based file you commit? Thanks!

[MediaWiki-CodeReview] [MediaWiki r110144]: Revision status changed

2012-01-27 Thread MediaWiki Mail
Reedy changed the status of MediaWiki.r110144 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110144 Old status: new New status: ok Commit summary for MediaWiki.r110144: should be antlr3 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r110147]: Revision status changed

2012-01-27 Thread MediaWiki Mail
^demon changed the status of MediaWiki.r110147 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110147 Old status: deferred New status: ok Commit summary for MediaWiki.r110147: removed duplicate header definition ___

[MediaWiki-CodeReview] [MediaWiki r110070]: Revision status changed

2012-01-27 Thread MediaWiki Mail
^demon changed the status of MediaWiki.r110070 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110070 Old status: fixme New status: resolved Commit summary for MediaWiki.r110070: ATF5 - fix issues from r109258 (not calling text() on messages) - one of the messages is

[MediaWiki-CodeReview] [MediaWiki r110136]: New comment added, and revision status changed

2012-01-27 Thread MediaWiki Mail
Reedy changed the status of MediaWiki.r110136 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110136#c30119 Old Status: new New Status: fixme Commit summary for MediaWiki.r110136: Added temporary config variable wgArticleFeedbackv5SelectedCTA so that Roan

[MediaWiki-CodeReview] [MediaWiki r110068]: Revision status changed

2012-01-27 Thread MediaWiki Mail
^demon changed the status of MediaWiki.r110068 to new URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110068 Old status: fixme New status: new Commit summary for MediaWiki.r110068: AFT5: - Fix some translation issues: remove a few unused messages (take them out of hooks.php as

[MediaWiki-CodeReview] [MediaWiki r110069]: Revision status changed

2012-01-27 Thread MediaWiki Mail
^demon changed the status of MediaWiki.r110069 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110069 Old status: fixme New status: resolved Commit summary for MediaWiki.r110069: AFT5 - explicitly declare this as plain, per comments on r109390

[MediaWiki-CodeReview] [MediaWiki r110086]: Revision status changed

2012-01-27 Thread MediaWiki Mail
^demon changed the status of MediaWiki.r110086 to new URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110086 Old status: fixme New status: new Commit summary for MediaWiki.r110086: AFT5 - SQL statements to rebuild the rollup tables using only bucket 1, and a fix to prevent loading

[MediaWiki-CodeReview] [MediaWiki r110132]: New comment added

2012-01-27 Thread MediaWiki Mail
^demon posted a comment on MediaWiki.r110132. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110132#c30120 Commit summary for MediaWiki.r110132: Fixes issues raised in commits from last night: - r110069 - Use rawParams (didn't know that existed) for the span, which allows escaping of

[MediaWiki-CodeReview] [MediaWiki r108141]: New comment added

2012-01-27 Thread MediaWiki Mail
Reedy posted a comment on MediaWiki.r108141. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108141#c30121 Commit summary for MediaWiki.r108141: rewrite getXCFMetaData() to get ride of im identify By reading the file header and unpacking the data, we can avoid shelling out to

[MediaWiki-CodeReview] [MediaWiki r110073]: New comment added

2012-01-27 Thread MediaWiki Mail
Reedy posted a comment on MediaWiki.r110073. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110073#c30122 Commit summary for MediaWiki.r110073: Further reduced RTTs in SwiftFileBackend by making file already exists checks use the stat cache, typically already set in

[MediaWiki-CodeReview] [MediaWiki r103738]: Revision status changed

2012-01-27 Thread MediaWiki Mail
Reedy changed the status of MediaWiki.r103738 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103738 Old status: new New status: resolved Commit summary for MediaWiki.r103738: image_auth.php cleanups: * Factored main code into wfImageAuthMain() * Made preg_match() for

[MediaWiki-CodeReview] [Wikimedia r1227]: New comment added, and revision status changed

2012-01-27 Thread MediaWiki Mail
Awjrichards changed the status of Wikimedia.r1227 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1227#c30123 Old Status: new New Status: fixme Commit summary for Wikimedia.r1227: Adding unit test code for drush civicrm-recurring-globalcollect [crg].

[MediaWiki-CodeReview] [Wikimedia r1158]: Revision status changed

2012-01-27 Thread MediaWiki Mail
Awjrichards changed the status of Wikimedia.r1158 to ok URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1158 Old status: new New status: ok Commit summary for Wikimedia.r1158: Adding Global Collect standalone adapter. ___

[MediaWiki-CodeReview] [MediaWiki r110150]: Revision status changed

2012-01-27 Thread MediaWiki Mail
MarkAHershberger changed the status of MediaWiki.r110150 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110150 Old status: new New status: ok Commit summary for MediaWiki.r110150: no longer needed - this dependency is now managed by maven

[MediaWiki-CodeReview] [Wikimedia r1187]: Revision status changed

2012-01-27 Thread MediaWiki Mail
Awjrichards changed the status of Wikimedia.r1187 to deferred URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1187 Old status: new New status: deferred Commit summary for Wikimedia.r1187: Adding Doxygen configuration file. ___

[MediaWiki-CodeReview] [MediaWiki r110151]: Revision status changed

2012-01-27 Thread MediaWiki Mail
MarkAHershberger changed the status of MediaWiki.r110151 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110151 Old status: new New status: ok Commit summary for MediaWiki.r110151: use wfEscapeShellArg, followup 110104 ___

[MediaWiki-CodeReview] [Wikimedia r1188]: Revision status changed

2012-01-27 Thread MediaWiki Mail
Awjrichards changed the status of Wikimedia.r1188 to deferred URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1188 Old status: new New status: deferred Commit summary for Wikimedia.r1188: Adding do payment request for standalone adapter.

[MediaWiki-CodeReview] [Wikimedia r1189]: Revision status changed

2012-01-27 Thread MediaWiki Mail
Awjrichards changed the status of Wikimedia.r1189 to deferred URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1189 Old status: new New status: deferred Commit summary for Wikimedia.r1189: Adding do payment response for standalone adapter testing.

[MediaWiki-CodeReview] [Wikimedia r1186]: Revision status changed

2012-01-27 Thread MediaWiki Mail
Awjrichards changed the status of Wikimedia.r1186 to ok URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1186 Old status: new New status: ok Commit summary for Wikimedia.r1186: Removing @todo statements. ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [Wikimedia r1173]: Revision status changed

2012-01-27 Thread MediaWiki Mail
Awjrichards changed the status of Wikimedia.r1173 to ok URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1173 Old status: new New status: ok Commit summary for Wikimedia.r1173: Removed irrelevant watchdog statement ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r107980]: Revision status changed

2012-01-27 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r107980 to new URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107980 Old status: fixme New status: new Commit summary for MediaWiki.r107980: * Added supported for container sharding via existing FileRepo-style hash paths. For sharded

[MediaWiki-CodeReview] [MediaWiki r110153]: New comment added

2012-01-27 Thread MediaWiki Mail
Aaron Schulz posted a comment on MediaWiki.r110153. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110153#c30124 Commit summary for MediaWiki.r110153: r107980: added missing dir param to FileBackendShardListIterator Aaron Schulz's comment: Summary should be 'r110084: normalize paths

[MediaWiki-CodeReview] [Wikimedia r1212]: Revision status changed

2012-01-27 Thread MediaWiki Mail
Awjrichards changed the status of Wikimedia.r1212 to fixme URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1212 Old status: new New status: fixme Commit summary for Wikimedia.r1212: Adding module for Global Collect recurring payments. ___

  1   2   3   >