[Wikitech-l] Diff colors - a disaster waiting to happen

2011-12-22 Thread Erwin Dokter
I'd like to ask for more eyes and participation in an issue that is in an apparent stalemate. It all started with revision 105280 (https://www.mediawiki.org/wiki/Special:Code/MediaWiki/105280), where Hashdar commited a new color scheme for diffs based on the French scheme. When this generated

Re: [Wikitech-l] Diff colors - a disaster waiting to happen

2011-12-22 Thread Brandon Harris
It's the exact same yellow as before, guys. The *exact* shade. This is the exact definition of a bikeshed argument. Feel free to move along. On 12/22/11 10:33 AM, Erwin Dokter wrote: I'd like to ask for more eyes and participation in an issue that is in an apparent

Re: [Wikitech-l] Diff colors - a disaster waiting to happen

2011-12-22 Thread Erwin Dokter
Brandon Harris wrote: It's the exact same yellow as before, guys. The *exact* shade. This is the exact definition of a bikeshed argument. Feel free to move along. But that is exactly the problem; you left in the *old* yellow against a much mellower blue. If that blue was

Re: [Wikitech-l] Diff colors - a disaster waiting to happen

2011-12-22 Thread Chad
On Thu, Dec 22, 2011 at 1:33 PM, Erwin Dokter er...@darcoury.nl wrote: It all started with revision 105280 (https://www.mediawiki.org/wiki/Special:Code/MediaWiki/105280), where Hashdar commited a new color scheme for diffs based on the French scheme. When this generated some flack for making

Re: [Wikitech-l] Diff colors - a disaster waiting to happen

2011-12-22 Thread Ryan Lane
But that is exactly the problem; you left in the *old* yellow against a much mellower blue. If that blue was as bright as the old green, it would be much less of a problem. I don't know how expert you are in CSS and web colors, but there should really have been more attention to matching all

Re: [Wikitech-l] Diff colors - a disaster waiting to happen

2011-12-22 Thread Roan Kattouw
On Thu, Dec 22, 2011 at 8:11 PM, Ryan Lane rlan...@gmail.com wrote: What was the purpose of changing colors? Aesthetics? If yes, this is bikeshedding. If there isn't a really good reason to change the colors, don't. If you are changing the colors so that they are more accessible for color

Re: [Wikitech-l] Diff colors - a disaster waiting to happen

2011-12-22 Thread Jay Ashworth
- Original Message - From: Brandon Harris bhar...@wikimedia.org It's the exact same yellow as before, guys. The *exact* shade. This is the exact definition of a bikeshed argument. Feel free to move along. I don't see, Brandon, that Erwin suggested that it is not. But no,

Re: [Wikitech-l] Diff colors - a disaster waiting to happen

2011-12-22 Thread Jay Ashworth
- Original Message - From: Chad innocentkil...@gmail.com As they say on enwiki, [citation needed]. Well, we probably say {{citation-needed}}, but... :-) Cheers, -- jra -- Jay R. Ashworth Baylink j...@baylink.com Designer The

Re: [Wikitech-l] Diff colors - a disaster waiting to happen

2011-12-22 Thread Brandon Harris
On 12/22/11 12:31 PM, Jay Ashworth wrote: - Original Message - From: Brandon Harrisbhar...@wikimedia.org It's the exact same yellow as before, guys. The *exact* shade. This is the exact definition of a bikeshed argument. Feel free to move along. I don't see, Brandon, that Erwin

Re: [Wikitech-l] Diff colors - a disaster waiting to happen

2011-12-22 Thread Jay Ashworth
- Original Message - From: Brandon Harris bhar...@wikimedia.org The yellow is *unchanged* Is this not what Erwin's on about? So. What was *supposed* to be a 15 minute task has now turned into a drama - over something I don't really care that much about anyways. Well, that's a sort

Re: [Wikitech-l] Diff colors - a disaster waiting to happen

2011-12-22 Thread Erwin Dokter
Let me address my concerns step by step, as you obviously still don't grasp what the major issue is. Brandon wrote: Here's what happened: * I was asked to look at the bug as part of my 20% code review. * I applied Erwin's patch (manually) and then played with changing colors around to

Re: [Wikitech-l] Diff colors - a disaster waiting to happen

2011-12-22 Thread Ryan Lane
Why didn't you test the original blue/green? What were your findings on that? You should have applied the colors as present in the patch, as these were the colors agreen upon in the original commit, which were blue for deleted content, and green for added content. Those had been tested by

Re: [Wikitech-l] Diff colors - a disaster waiting to happen

2011-12-22 Thread Roan Kattouw
On Thu, Dec 22, 2011 at 10:37 PM, Ryan Lane rlan...@gmail.com wrote: Green has a meaning of Go or of this is ok in many cultures. Making either side green gives a bias to the diff. Similarly with red. Red means Stop or this is not ok. Many people associate red with blood, and green with

Re: [Wikitech-l] Diff colors - a disaster waiting to happen

2011-12-22 Thread Erwin Dokter
Ryan wrote: Green has a meaning of Go or of this is ok in many cultures. Making either side green gives a bias to the diff. Similarly with red. Red means Stop or this is not ok. Many people associate red with blood, and green with nature. When the French created the new color scheme, they

Re: [Wikitech-l] Diff colors - a disaster waiting to happen

2011-12-22 Thread Russell Nelson
May I remind y'all that you are continuing to bikeshed. It's not that it doesn't matter, it's that a very small number of people care very very much. Speaking of a disaster that's already happening, if y'all don't move this conversation to wikicolors-yellow-blue-green-re...@lists.wikimedia.org,

Re: [Wikitech-l] Diff colors - a disaster waiting to happen

2011-12-22 Thread Aaron Schulz
I've stated in CR that I don't think light light green has any real cultural issue. It shouldn't be ruled out on those grounds. Red, on the other hand, has stronger connotations. Part of it comes from the fact that GUIs vry often have certain color standards, e.g.: Blue: notice, fyi, please

Re: [Wikitech-l] Diff colors - a disaster waiting to happen

2011-12-22 Thread Brion Vibber
So just a reminder to y'all: * the primary indicator is physical ordering (left = before; right = after) * the secondary indicator is + and - symbols indicating additional and removal * the colors are totally arbitrary to help set sections apart from each other visibly * the only important thing

Re: [Wikitech-l] Diff colors - a disaster waiting to happen

2011-12-22 Thread Steven Walling
On Thu, Dec 22, 2011 at 1:58 PM, Brion Vibber br...@pobox.com wrote: * the only important thing about the colors is that the text is legible We could save this debate by just making them the same color. ;-) /trolling Steven ___ Wikitech-l mailing

Re: [Wikitech-l] Diff colors - a disaster waiting to happen

2011-12-22 Thread OQ
On Thu, Dec 22, 2011 at 3:56 PM, Russell Nelson russnel...@gmail.com wrote: Speaking of usability, why is this mailing list called Wiki Tech List Lists Wiki Media org? Surely there's some extra duplicate redundancy there there? It isn't, that's just what your $mail_client decided to call it,

Re: [Wikitech-l] Diff colors - a disaster waiting to happen

2011-12-22 Thread Antoine Musso
Hello Erwin, Thanks for bringing this on the wikitech-l list! Erwin Dokter wrote: It all started with revision 105280 (https://www.mediawiki.org/wiki/Special:Code/MediaWiki/105280), where Hashdar commited a new color scheme for diffs based on the French scheme. When this generated some flack

Re: [Wikitech-l] Diff colors - a disaster waiting to happen

2011-12-22 Thread Antoine Musso
Steven Walling wrote: We could save this debate by just making them the same color. troll I purpose white for both sides since it hits all eye cone cells :-D /troll -- Antoine hashar Musso ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org

Re: [Wikitech-l] Diff colors - a disaster waiting to happen

2011-12-22 Thread Roan Kattouw
On Thu, Dec 22, 2011 at 10:56 PM, Russell Nelson russnel...@gmail.com wrote: Speaking of usability, why is this mailing list called Wiki Tech List Lists Wiki Media org? Surely there's some extra duplicate redundancy there there? Do you mean the -l suffix is redundant with the list. prefix? Yes,

Re: [Wikitech-l] Diff colors - a disaster waiting to happen

2011-12-22 Thread Erwin Dokter
Thanks for your reply, Antoine. Antoine Musso wrote: I have looked at your patch this afternoon. Your colors are not that much different from Brandon one. It is clearly not worth it to spend hours and hours in discussion just to add 1% of red in a yellow color or 0.5% of green in the blue

Re: [Wikitech-l] Diff colors - a disaster waiting to happen

2011-12-22 Thread Platonides
On 22/12/11 22:37, Ryan Lane wrote: Green has a meaning of Go or of this is ok in many cultures. Making either side green gives a bias to the diff. Similarly with red. Red means Stop or this is not ok. Many people associate red with blood, and green with nature. - Ryan I don't see why that

Re: [Wikitech-l] Diff colors - a disaster waiting to happen

2011-12-22 Thread Platonides
On 22/12/11 23:59, Erwin Dokter wrote: Note: revisions are not definitives. We can always amend them later on. Until 1.19 is suddenly branched off... game over. Is there an expected timeframe or announcement for when this might happen? Even then it could be backported. That revisions are

Re: [Wikitech-l] Diff colors - a disaster waiting to happen

2011-12-22 Thread Jay Ashworth
- Original Message - From: Ryan Lane rlan...@gmail.com Green has a meaning of Go or of this is ok in many cultures. Making either side green gives a bias to the diff. Similarly with red. Red means Stop or this is not ok. Many people associate red with blood, and green with nature.

Re: [Wikitech-l] Diff colors - a disaster waiting to happen

2011-12-22 Thread Jay Ashworth
- Original Message - From: Steven Walling steven.wall...@gmail.com On Thu, Dec 22, 2011 at 1:58 PM, Brion Vibber br...@pobox.com wrote: * the only important thing about the colors is that the text is legible We could save this debate by just making them the same color. ;-)