[MediaWiki-CodeReview] [MediaWiki r104311]: New comment added

2011-11-29 Thread MediaWiki Mail
User Bryan posted a comment on MediaWiki.r104311.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104311#c26684
Commit summary:

Qqq for r99224

Comment:

I hope to live that day! I'll buy you a drink when the day comes, promised.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104498]: New comment added

2011-11-29 Thread MediaWiki Mail
User Raymond posted a comment on MediaWiki.r104498.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104498#c26685
Commit summary:

Disable the partial HTML and MathML rendering options for Math extension.

MathML mode was so incomplete most people thought it simply didn't work (bug 
25646).
HTML modes often rendered poorly (eg req bug 24207 to set default to PNG on 
some sites)

This may cause regressions in that simple equations of just variables that 
came out as HTML
will now render as PNGs that don't get aligned properly with the text baseline. 
Fixing this is
covered by bug 32694: https://bugzilla.wikimedia.org/show_bug.cgi?id=32694 to 
retrieve the
baseline info from dvipng and position images to fit.

Note that because of the way user options are pulled in to the oarser cache 
key, some folks
may see cached pages with their old settings until they get redone or they save 
their prefs
again and have it normalized.

Comment:

Are the messages
pre
'mw_math_simple' = 'HTML if very simple or else PNG',
'mw_math_html' = 'HTML if possible or else PNG',
'mw_math_modern' = 'Recommended for modern browsers',
'mw_math_mathml' = 'MathML if possible (experimental)',
/pre
still needed or can they be removed from Math.i18n.php?


___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104545]: Revision status changed

2011-11-29 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r104545.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104545
Commit summary:

r104479: Adding extension to translatewiki.net

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104373]: New comment added, and revision status changed

2011-11-29 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r104373.

Old Status: deferred
New Status: fixme

User Nikerabbit also posted a comment on MediaWiki.r104373.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104373#c26686
Commit summary:

== SWB - 2011-11-27 ==
* Incoming links work now
* beautifications
* language
* ...

Comment:

Mixed tabs/spaced indentation. Why is that global statement needed anyway?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


Re: [Wikitech-l] MathJax integration to stock MediaWiki Math extension? (was RFC: math options)

2011-11-29 Thread Roan Kattouw
On Tue, Nov 29, 2011 at 1:42 AM, Brion Vibber br...@pobox.com wrote:
 Most compatible thing is probably to let it include the images/text form
 as-is, then make sure MathJax goes over and replaces them in-place. It
 might need tweaks to understand the images (source in alt text).

You may want to do a quick check for MathJax support in a script in
the head (which executes before the browser renders the page) which
then adds some CSS that ensures the images aren't loaded but the space
is still reserved (something like visibility: hidden; on the image).

Roan

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


[MediaWiki-CodeReview] [MediaWiki r104375]: New comment added, and revision status changed

2011-11-29 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r104375.

Old Status: deferred
New Status: fixme

User Nikerabbit also posted a comment on MediaWiki.r104375.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104375#c26687
Commit summary:

== SWB - 2011-11-27 ==
* Incoming links work now
* beautifications
* language
* ...

Comment:

# Encoding issues in new files.
# Message documentation should be under qqq.
# Typo: dafault

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104375]: New comment added

2011-11-29 Thread MediaWiki Mail
User Raymond posted a comment on MediaWiki.r104375.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104375#c26688
Commit summary:

== SWB - 2011-11-27 ==
* Incoming links work now
* beautifications
* language
* ...

Comment:

Working on it already. Commit will follow soon.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104383]: New comment added, and revision status changed

2011-11-29 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r104383.

Old Status: new
New Status: fixme

User Nikerabbit also posted a comment on MediaWiki.r104383.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104383#c26692
Commit summary:

Followup r104353, updating Special:ProtectedTitles
Adds HTML form fields for namespaces and restriction levels
Adds getVal() to HTMLForm

Comment:

Autoloader entries. Are you sure the escaping is correct in both classes?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104388]: New comment added

2011-11-29 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r104388.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104388#c26693
Commit summary:

improvement in use of arrays per feedback to r104384 - ty Johnduhart

Comment:

And instead of $wgAddThisHServ[$n] inside the loop you can use $a['service'] 
and give $n and $a better names.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104392]: New comment added, and revision status changed

2011-11-29 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r104392.

Old Status: new
New Status: ok

User Nikerabbit also posted a comment on MediaWiki.r104392.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104392#c26694
Commit summary:

Correct the pointer behavior on the menu items.

Comment:

The same fix should be done to Narayam and Kieli too.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104394]: New comment added

2011-11-29 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r104394.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104394#c26695
Commit summary:

fix for possible PHP notices caused by r104388

Comment:

if ( true === isset() ) is redundant, if ( isset() ) does the same.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104397]: New comment added

2011-11-29 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r104397.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104397#c26696
Commit summary:

Cleanup the AddThis extension to conform to MediaWiki standards

Comment:

There must be a better way to check if Title is main page.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104401]: Revision status changed

2011-11-29 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r104401.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104401
Commit summary:

Remove Vaigai font, since it is a title font and not a regular font for reading 
purpose.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r102083]: New comment added

2011-11-29 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r102083.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102083#c26697
Commit summary:

Made use of Pager::doBatchLookups() and Pager::getUser() in special page Pagers

Comment:

Both methods are exactly the same in StablePages_body.php 
ReviewedPages_body.php etc .. Those classes could be refactored to extend a 
common class that would host the getStartBody() / doBatchLookups() methods.

But I am not sure it is worth the time to do it, hence why I marked the change 
ok.

Is it clearer?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r100932]: Revision status changed

2011-11-29 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r100932.

Old Status: new
New Status: resolved

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100932
Commit summary:

Disabled bad image tests which made totally broken assumptions about how/when 
the bad_image_list message is loaded. This caused failures with r100883. More 
direct tests were added in r100915.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104543]: Revision status changed

2011-11-29 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r104543.

Old Status: new
New Status: resolved

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104543
Commit summary:

Remove ks since it is not just devanagari script.
Change the default font for kn to Lohit as per community feedback.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104493]: Revision status changed

2011-11-29 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r104493.

Old Status: new
New Status: deferred

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104493
Commit summary:

Localisation updates for ToolserverI18N from translatewiki.net

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104491]: Revision status changed

2011-11-29 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r104491.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104491
Commit summary:

Add forgotten /*_*/

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104480]: Revision status changed

2011-11-29 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r104480.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104480
Commit summary:

* (bug 32688) Paraminfo for parameter generator of the query module shows too 
many types

Pass prop and list through the generator filtering in the constructor

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104470]: Revision status changed

2011-11-29 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r104470.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104470
Commit summary:

Followup r104441

Fix capitalisation mismatch

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104558]: Revision status changed

2011-11-29 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r104558.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104558
Commit summary:

use {} even when if statement is oneliner

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


Re: [Wikitech-l] MathJax integration to stock MediaWiki Math extension? (was RFC: math options)

2011-11-29 Thread Carl (CBM)
On Mon, Nov 28, 2011 at 7:42 PM, Brion Vibber br...@pobox.com wrote:
 I've done a quick experimental mode commit:
 https://www.mediawiki.org/wiki/Special:Code/MediaWiki/104521

This sounds great. MathJax is used on some other math-intensive sites,
e.g. MathOverflow.net, and in general it does a very nice rendering
job.

When the Mediawiki support for MathJax gets to the right stage, it
would be helpful to have it enabled on the labs wiki, so people can
test it out.

- Carl

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


[MediaWiki-CodeReview] [pywikipedia r9777]: Revision status changed

2011-11-29 Thread MediaWiki Mail
User Xqt changed the status of pywikipedia.r9777.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9777
Commit summary:

Huh, where did that ' go?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [pywikipedia r9778]: Revision status changed

2011-11-29 Thread MediaWiki Mail
User Xqt changed the status of pywikipedia.r9778.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9778
Commit summary:

First chop up description than do the cleanup.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [pywikipedia r9781]: Revision status changed

2011-11-29 Thread MediaWiki Mail
User Xqt changed the status of pywikipedia.r9781.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9781
Commit summary:

-excepttitle documentation update: use multiple times for multiple pages

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [pywikipedia r9782]: Revision status changed

2011-11-29 Thread MediaWiki Mail
User Xqt changed the status of pywikipedia.r9782.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9782
Commit summary:

Update list of allowed (non-warned) extensions.
As we have ogg, also add .ogv and .oga
Plus .tif, .tiff, and that updates it to the
current list at WMF sites.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [pywikipedia r9037]: Revision status changed

2011-11-29 Thread MediaWiki Mail
User Xqt changed the status of pywikipedia.r9037.

Old Status: new
New Status: resolved

Full URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9037
Commit summary:

Handle Special:Mypage/skin.css and js files properly

* Allow the page owner to put custom styles and scripts
* Check editusercss or edituserjs permissions introduced in 1.16
  in addition to the obsolete editusercssjs

  https://bugzilla.wikimedia.org/show_bug.cgi?id=12110

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104036]: New comment added, and revision status changed

2011-11-29 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r104036.

Old Status: ok
New Status: new

User Hashar also posted a comment on MediaWiki.r104036.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104036#c26700
Commit summary:

FlaggedPageTest - FlaggablePageTest

Follow up r99295

Comment:

Resetting to new, I forgot to change the filename in the hook registration file 
(fix is r104562).

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104563]: New comment added

2011-11-29 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r104563.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104563#c26701
Commit summary:

Fix fatal error when running newParserTest

The delayed parser test feature was expecting a ParserTest object which is
almost never the case when using the NewParserTest for PHPUnit. The class
name is forged after the file name! They at least all extends NewParserTest

no polymorphism? no multiple hinting. Be creative the PHP way by writing
your own code :-(

Comment:

Follow up r104561

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104561]: New comment added

2011-11-29 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r104561.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104561#c26702
Commit summary:

parserTest: delay hooks execution to the point we really need them

disabled and filtered out tests were still triggering hooks run. This patch
let us delay hooks running run a little bit until we know we will really need
their execution (i.e. when test is not filtered out and not disabled).

Saving all that unneeded code execution makes running a subset of parser tests
a bit faster when one has many extension enabled.

NOTE: '!!article' sections are still parsed regardless of their usage.
 We would need to add an article/test dependency system to really filter them

Comment:

did not work with NewParserTest because of type hinting. Fixed that with 
r104563.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104564]: New comment added

2011-11-29 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r104564.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104564#c26703
Commit summary:

Committing version 1.1.0 (2008-02-09) of this extension by Edward Z. Yang. See 
http://www.mediawiki.org/wiki/Extension:SpecialUploadLocal.

Comment:

There looks to be quite a lot of things wrong with this extension

You're still using old PHP4 style constructors

Messages shouldn't be loaded in manually like that

All of those random requires shouldn't be needed if you Autoload the classes 
properly

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104565]: Revision status changed

2011-11-29 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r104565.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104565
Commit summary:

Whitespace.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104564]: New comment added

2011-11-29 Thread MediaWiki Mail
User Cneubauer posted a comment on MediaWiki.r104564.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104564#c26704
Commit summary:

Committing version 1.1.0 (2008-02-09) of this extension by Edward Z. Yang. See 
http://www.mediawiki.org/wiki/Extension:SpecialUploadLocal.

Comment:

Yeah I just loaded the original extension as it existed in the wild.  I tried 
to modernize it in r104568.  Thanks for the comments.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104564]: New comment added

2011-11-29 Thread MediaWiki Mail
User Raymond posted a comment on MediaWiki.r104564.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104564#c26705
Commit summary:

Committing version 1.1.0 (2008-02-09) of this extension by Edward Z. Yang. See 
http://www.mediawiki.org/wiki/Extension:SpecialUploadLocal.

Comment:

I suggest to rename the extension to UploadLocal to be more consistent 
(reminder: Use svn move... to keep the history)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104568]: New comment added, and revision status changed

2011-11-29 Thread MediaWiki Mail
User Siebrand changed the status of MediaWiki.r104568.

Old Status: new
New Status: fixme

User Siebrand also posted a comment on MediaWiki.r104568.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104568#c26706
Commit summary:

Update for 1.17.  This probably breaks compatibility with = 1.15 and possibly 
also 1.16.

Comment:

trunk/extensions/SpecialUploadLocal/UploadLocalForm.php contains a lot of 
un-i18n-ed text. See [[i18n]] for more information. Also, error messages should 
have correct punctuation.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104498]: New comment added

2011-11-29 Thread MediaWiki Mail
User Brion VIBBER posted a comment on MediaWiki.r104498.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104498#c26708
Commit summary:

Disable the partial HTML and MathML rendering options for Math extension.

MathML mode was so incomplete most people thought it simply didn't work (bug 
25646).
HTML modes often rendered poorly (eg req bug 24207 to set default to PNG on 
some sites)

This may cause regressions in that simple equations of just variables that 
came out as HTML
will now render as PNGs that don't get aligned properly with the text baseline. 
Fixing this is
covered by bug 32694: https://bugzilla.wikimedia.org/show_bug.cgi?id=32694 to 
retrieve the
baseline info from dvipng and position images to fit.

Note that because of the way user options are pulled in to the oarser cache 
key, some folks
may see cached pages with their old settings until they get redone or they save 
their prefs
again and have it normalized.

Comment:

Indeed, they can go.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104548]: Revision status changed

2011-11-29 Thread MediaWiki Mail
User Platonides changed the status of MediaWiki.r104548.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104548
Commit summary:

nice debug msg for Title::getRestrictionTypes

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104521]: New comment added

2011-11-29 Thread MediaWiki Mail
User Brion VIBBER posted a comment on MediaWiki.r104521.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104521#c26709
Commit summary:

Experimental option $wgMathUseMathJax to have Extension:Math load things via 
MathJax.

If enabled, by default loads MathJax from a CDN and forces all equations 
through MathJax when JavaScript is available -- the image or source form gets 
used only as noscript fallback.

This has a couple of problems for us:
* if scripts are missing -- such as when viewed via MobileFrontend -- you end 
up with no math at all, as the script type=math/tex bits get ignored but 
the noscript still hides the images.
* while MathJax is loading things, blank spots on the page may appear and stuff 
jumps around
* if loading new text in via ajax, it doesn't trigger there

Also using some fairly default config, no idea how appropriate it is. Hoping to 
get some insight from Nageh who's done some of the MathJax work on Wikipedia so 
far - 
https://en.wikipedia.org/wiki/User_talk:Nageh#MathJax_integration_into_stock_MediaWiki

Comment:

We'll certainly use our own copy for Wikimedia. Probably will end up bundling 
MathJax into the ext for convenience as the support matures. Feel free to 
commit it if you're in a hurry. :D

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104498]: New comment added

2011-11-29 Thread MediaWiki Mail
User Brion VIBBER posted a comment on MediaWiki.r104498.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104498#c26710
Commit summary:

Disable the partial HTML and MathML rendering options for Math extension.

MathML mode was so incomplete most people thought it simply didn't work (bug 
25646).
HTML modes often rendered poorly (eg req bug 24207 to set default to PNG on 
some sites)

This may cause regressions in that simple equations of just variables that 
came out as HTML
will now render as PNGs that don't get aligned properly with the text baseline. 
Fixing this is
covered by bug 32694: https://bugzilla.wikimedia.org/show_bug.cgi?id=32694 to 
retrieve the
baseline info from dvipng and position images to fit.

Note that because of the way user options are pulled in to the oarser cache 
key, some folks
may see cached pages with their old settings until they get redone or they save 
their prefs
again and have it normalized.

Comment:

Done in r104575.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104553]: Revision status changed

2011-11-29 Thread MediaWiki Mail
User Platonides changed the status of MediaWiki.r104553.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104553
Commit summary:

Move terminal colorers classes in their own file

They were originally written for parserTests output and were in
tests/testHelpers.inc since them.  Those classes can be used by most
our maintenance scripts anyway, so here is their new home.

Also make tests/testHelpers.inc a bit shorter which is always welcome.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104547]: Revision status changed

2011-11-29 Thread MediaWiki Mail
User Platonides changed the status of MediaWiki.r104547.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104547
Commit summary:

restore parser tests names

r100932 disabled two 'Bad images' tests but did so by also erasing the
test name. Hence we could no more tests them even with --run-disabled.


Test plan:
==

$ php parserTests.php --run-disabled --filter 'Bad images'
-- output two tests failing as expected

$ php parserTests.php --filter 'Bad images'
-- output no tests found

$ php parserTests.php --quiet
-- ALL PASSED :-)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104550]: Revision status changed

2011-11-29 Thread MediaWiki Mail
User Platonides changed the status of MediaWiki.r104550.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104550
Commit summary:

nicely align array key / values

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104563]: New comment added

2011-11-29 Thread MediaWiki Mail
User Platonides posted a comment on MediaWiki.r104563.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104563#c26711
Commit summary:

Fix fatal error when running newParserTest

The delayed parser test feature was expecting a ParserTest object which is
almost never the case when using the NewParserTest for PHPUnit. The class
name is forged after the file name! They at least all extends NewParserTest

no polymorphism? no multiple hinting. Be creative the PHP way by writing
your own code :-(

Comment:

Forging it from the name was easy and much more convenient than eg. 
md5(mt_rand()) :)

In an ideal world, ParserTest and NewParserTest wouldn't duplicate code.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104561]: New comment added

2011-11-29 Thread MediaWiki Mail
User Platonides posted a comment on MediaWiki.r104561.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104561#c26712
Commit summary:

parserTest: delay hooks execution to the point we really need them

disabled and filtered out tests were still triggering hooks run. This patch
let us delay hooks running run a little bit until we know we will really need
their execution (i.e. when test is not filtered out and not disabled).

Saving all that unneeded code execution makes running a subset of parser tests
a bit faster when one has many extension enabled.

NOTE: '!!article' sections are still parsed regardless of their usage.
 We would need to add an article/test dependency system to really filter them

Comment:

It used to avoid reading the rest of the file if it required an unavailable 
hook. Now it's always parsing the whole file.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[Wikitech-l] Code review hours

2011-11-29 Thread Brion Vibber
Due to a schedule conflict I won't be available for review until noonish
pacific (around 20:00 UTC)

-- brion
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


[MediaWiki-CodeReview] [MediaWiki r102137]: Revision status changed

2011-11-29 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r102137.

Old Status: fixme
New Status: resolved

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102137
Commit summary:

Make the CliInstaller use --server to set wgServer instead of always setting it 
to http://localhost;

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104563]: Revision status changed

2011-11-29 Thread MediaWiki Mail
User Platonides changed the status of MediaWiki.r104563.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104563
Commit summary:

Fix fatal error when running newParserTest

The delayed parser test feature was expecting a ParserTest object which is
almost never the case when using the NewParserTest for PHPUnit. The class
name is forged after the file name! They at least all extends NewParserTest

no polymorphism? no multiple hinting. Be creative the PHP way by writing
your own code :-(

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


Re: [Wikitech-l] Dropping the 'LATER' resolution in Bugzilla

2011-11-29 Thread Diederik van Liere
But then the bug should be NEW, nobody is checking for a bug that is marked
LATER. I mentioned WORKSFORME because i suspect that some of the LATER bugs
have been resolved by now.
Diederik


On Tue, Nov 29, 2011 at 1:59 PM, Chad innocentkil...@gmail.com wrote:

 On Tue, Nov 29, 2011 at 1:45 PM, Diederik van Liere dvanli...@gmail.com
 wrote:
  Hi folks,
 
  Currently, we have a 'LATER' resolution in Bugzilla, it contains 339 bug
  reports over all the products, see:
 
 
 https://bugzilla.wikimedia.org/buglist.cgi?query_format=advancedlist_id=57731resolution=LATERproduct=CiviCRMproduct=Cortadoproduct=dbzip2product=Kate%27s%20Toolsproduct=Logwoodproduct=MediaWikiproduct=MediaWiki%20extensionsproduct=mwdumperproduct=mwEmbedproduct=Wikimediaproduct=Wikimedia%20Mobileproduct=Wikimedia%20Toolsproduct=Wiktionary%20toolsproduct=XML%20Snapshots
 
  The question is, when is LATER? Technically, these bugs are not open and
 so
  nobody will ever see them again and that's how they will be forgotten.
 
  To me, it seems that bugs that are labeled LATER should either be
 labeled:
  1) WONTFIX, which I guess is the majority of these bugs
  2) WORKSFORME, I am sure some things have been fixed
  3) NEW, it is a real bug / feature request.
 

 LATER means we can't or won't do it (right now) but that is
 likely to change in the future. WONTFIX implies no and this
 is not likely to change

 WORKSFORME is unrelated.

 -Chad

 ___
 Wikitech-l mailing list
 Wikitech-l@lists.wikimedia.org
 https://lists.wikimedia.org/mailman/listinfo/wikitech-l




-- 
a href=http://about.me/diederik;Check out my about.me profile!/a
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


Re: [Wikitech-l] Dropping the 'LATER' resolution in Bugzilla

2011-11-29 Thread Sumana Harihareswara
If you suspect that a bug has been fixed or is now invalid, then ask
that question in the bug.

But I agree that later really ought not to be a resolution (because
really a bug marked LATER has not been resolved), but rather a status or
prioritization.  When I do searches across all the open bugs, I do not
habitually say and also ones that are Resolved but only if they've been
marked Resolved--Later.  And probably most people are making the same
omission.

Mark H., what do you think?  Also, is there a way to make Bugzilla's
default search include resolved bugs with the Later resolution?

-- 
Sumana Harihareswara
Volunteer Development Coordinator
Wikimedia Foundation


On 11/29/2011 02:02 PM, Diederik van Liere wrote:
 But then the bug should be NEW, nobody is checking for a bug that is marked
 LATER. I mentioned WORKSFORME because i suspect that some of the LATER bugs
 have been resolved by now.
 Diederik
 
 
 On Tue, Nov 29, 2011 at 1:59 PM, Chad innocentkil...@gmail.com wrote:
 
 On Tue, Nov 29, 2011 at 1:45 PM, Diederik van Liere dvanli...@gmail.com
 wrote:
 Hi folks,

 Currently, we have a 'LATER' resolution in Bugzilla, it contains 339 bug
 reports over all the products, see:


 https://bugzilla.wikimedia.org/buglist.cgi?query_format=advancedlist_id=57731resolution=LATERproduct=CiviCRMproduct=Cortadoproduct=dbzip2product=Kate%27s%20Toolsproduct=Logwoodproduct=MediaWikiproduct=MediaWiki%20extensionsproduct=mwdumperproduct=mwEmbedproduct=Wikimediaproduct=Wikimedia%20Mobileproduct=Wikimedia%20Toolsproduct=Wiktionary%20toolsproduct=XML%20Snapshots

 The question is, when is LATER? Technically, these bugs are not open and
 so
 nobody will ever see them again and that's how they will be forgotten.

 To me, it seems that bugs that are labeled LATER should either be
 labeled:
 1) WONTFIX, which I guess is the majority of these bugs
 2) WORKSFORME, I am sure some things have been fixed
 3) NEW, it is a real bug / feature request.


 LATER means we can't or won't do it (right now) but that is
 likely to change in the future. WONTFIX implies no and this
 is not likely to change

 WORKSFORME is unrelated.

 -Chad

 ___
 Wikitech-l mailing list
 Wikitech-l@lists.wikimedia.org
 https://lists.wikimedia.org/mailman/listinfo/wikitech-l

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


Re: [Wikitech-l] Dropping the 'LATER' resolution in Bugzilla

2011-11-29 Thread Chad
On Tue, Nov 29, 2011 at 2:17 PM, Sumana Harihareswara
suma...@wikimedia.org wrote:
 If you suspect that a bug has been fixed or is now invalid, then ask
 that question in the bug.

 But I agree that later really ought not to be a resolution (because
 really a bug marked LATER has not been resolved), but rather a status or
 prioritization.  When I do searches across all the open bugs, I do not
 habitually say and also ones that are Resolved but only if they've been
 marked Resolved--Later.  And probably most people are making the same
 omission.

 Mark H., what do you think?  Also, is there a way to make Bugzilla's
 default search include resolved bugs with the Later resolution?


Yes. Went ahead and did this now to include dupes too.

-Chad

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[Wikitech-l] Who actually reads @wikimediatech ?

2011-11-29 Thread Guillaume Paumier
Hi all,

We've had @wikimediatech accounts on twitter  identica for some time now:
* http://identi.ca/wikimediatech
* https://twitter.com/#!/wikimediatech
that basically broadcast every single action that is logged to the
server admin log:
* http://wikitech.wikimedia.org/view/Server_admin_log

The account has 78 followers on identica and 430 on twitter (probably
counting the spammers).

I'm wondering if there are actually people reading all the stuff
that's pushed through these channels.

My gut feeling is that the few people reading these feeds are also
those that would know to check the SLA if they encountered an issue,
or know how to use the RSS feed of the SLA page if they really wanted
the information in real time.

Meanwhile, we don't really have social media channels dedicated to
Wikimedia tech stuff, i.e. channels where we can actually post stuff,
links, blog posts, outage info, etc and engage with a larger community
of people interested in our tech operations. I feel that the accounts
would be much more useful if we reduced the amount of semi-random
information we post there.

So, I'm basically proposing to repurpose the @wikimediatech accounts for this.

Thoughts? Good idea? Bad idea? You don't care?

-- 
Guillaume Paumier
Technical Communications Manager — Wikimedia Foundation
http://donate.wikimedia.org

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Who actually reads @wikimediatech ?

2011-11-29 Thread Brandon Harris

I read it, and I'm not in the channels.

I use it to have an up-to-moment idea of status.


On 11/29/11 11:25 AM, Guillaume Paumier wrote:
 Hi all,

 We've had @wikimediatech accounts on twitter  identica for some time now:
 * http://identi.ca/wikimediatech
 * https://twitter.com/#!/wikimediatech
 that basically broadcast every single action that is logged to the
 server admin log:
 * http://wikitech.wikimedia.org/view/Server_admin_log

 The account has 78 followers on identica and 430 on twitter (probably
 counting the spammers).

 I'm wondering if there are actually people reading all the stuff
 that's pushed through these channels.

 My gut feeling is that the few people reading these feeds are also
 those that would know to check the SLA if they encountered an issue,
 or know how to use the RSS feed of the SLA page if they really wanted
 the information in real time.

 Meanwhile, we don't really have social media channels dedicated to
 Wikimedia tech stuff, i.e. channels where we can actually post stuff,
 links, blog posts, outage info, etc and engage with a larger community
 of people interested in our tech operations. I feel that the accounts
 would be much more useful if we reduced the amount of semi-random
 information we post there.

 So, I'm basically proposing to repurpose the @wikimediatech accounts for this.

 Thoughts? Good idea? Bad idea? You don't care?


-- 
Brandon Harris, Senior Designer, Wikimedia Foundation

Support Free Knowledge: http://wikimediafoundation.org/wiki/Donate

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


Re: [Wikitech-l] Who actually reads @wikimediatech ?

2011-11-29 Thread Tomasz Finc
As someone who uses social media frequently i'd love to see us use our
resources more effectively. I've found it really helpful to use twitter for
our mobile site (http://twitter.com/#!/WikimediaMobile) and i've been
growing that community steadily through outreach, hackathons, etc.

+1

--tomasz


On Tue, Nov 29, 2011 at 11:25 AM, Guillaume Paumier
gpaum...@wikimedia.orgwrote:

 Hi all,

 We've had @wikimediatech accounts on twitter  identica for some time now:
 * http://identi.ca/wikimediatech
 * https://twitter.com/#!/wikimediatech
 that basically broadcast every single action that is logged to the
 server admin log:
 * http://wikitech.wikimedia.org/view/Server_admin_log

 The account has 78 followers on identica and 430 on twitter (probably
 counting the spammers).

 I'm wondering if there are actually people reading all the stuff
 that's pushed through these channels.

 My gut feeling is that the few people reading these feeds are also
 those that would know to check the SLA if they encountered an issue,
 or know how to use the RSS feed of the SLA page if they really wanted
 the information in real time.

 Meanwhile, we don't really have social media channels dedicated to
 Wikimedia tech stuff, i.e. channels where we can actually post stuff,
 links, blog posts, outage info, etc and engage with a larger community
 of people interested in our tech operations. I feel that the accounts
 would be much more useful if we reduced the amount of semi-random
 information we post there.

 So, I'm basically proposing to repurpose the @wikimediatech accounts for
 this.

 Thoughts? Good idea? Bad idea? You don't care?

 --
 Guillaume Paumier
 Technical Communications Manager — Wikimedia Foundation
 http://donate.wikimedia.org

 ___
 Wikitech-l mailing list
 Wikitech-l@lists.wikimedia.org
 https://lists.wikimedia.org/mailman/listinfo/wikitech-l
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Who actually reads @wikimediatech ?

2011-11-29 Thread Brion Vibber
I think I either set those up or encouraged them to be set up a couple
years ago.

Most likely we would be better off with human updates in there, but we may
need some designated tweeters to make sure it happens reliably when there
are issues to report, new features to mention, or upcoming stuff we want
feedback on.

-- brion
On Nov 29, 2011 11:25 AM, Guillaume Paumier gpaum...@wikimedia.org
wrote:

 Hi all,

 We've had @wikimediatech accounts on twitter  identica for some time now:
 * http://identi.ca/wikimediatech
 * https://twitter.com/#!/wikimediatech
 that basically broadcast every single action that is logged to the
 server admin log:
 * http://wikitech.wikimedia.org/view/Server_admin_log

 The account has 78 followers on identica and 430 on twitter (probably
 counting the spammers).

 I'm wondering if there are actually people reading all the stuff
 that's pushed through these channels.

 My gut feeling is that the few people reading these feeds are also
 those that would know to check the SLA if they encountered an issue,
 or know how to use the RSS feed of the SLA page if they really wanted
 the information in real time.

 Meanwhile, we don't really have social media channels dedicated to
 Wikimedia tech stuff, i.e. channels where we can actually post stuff,
 links, blog posts, outage info, etc and engage with a larger community
 of people interested in our tech operations. I feel that the accounts
 would be much more useful if we reduced the amount of semi-random
 information we post there.

 So, I'm basically proposing to repurpose the @wikimediatech accounts for
 this.

 Thoughts? Good idea? Bad idea? You don't care?

 --
 Guillaume Paumier
 Technical Communications Manager — Wikimedia Foundation
 http://donate.wikimedia.org

 ___
 Wikitech-l mailing list
 Wikitech-l@lists.wikimedia.org
 https://lists.wikimedia.org/mailman/listinfo/wikitech-l
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Who actually reads @wikimediatech ?

2011-11-29 Thread Strainu
2011/11/29 Guillaume Paumier gpaum...@wikimedia.org:
 Hi all,

 We've had @wikimediatech accounts on twitter  identica for some time now:
 * http://identi.ca/wikimediatech
 * https://twitter.com/#!/wikimediatech
 that basically broadcast every single action that is logged to the
 server admin log:
 * http://wikitech.wikimedia.org/view/Server_admin_log

I don't use microblogging platforms, so the answer to your question
would be I don't care. However, when I do need to check something in
the Server admin log, I can almost never remember it's address (the
domain, to be more precise) and I have to go digging in the favorites.
Perhaps a short URL would help?

Thanks,
   Strainu

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


Re: [Wikitech-l] Who actually reads @wikimediatech ?

2011-11-29 Thread Roan Kattouw
On Tue, Nov 29, 2011 at 8:25 PM, Guillaume Paumier
gpaum...@wikimedia.org wrote:
 I'm wondering if there are actually people reading all the stuff
 that's pushed through these channels.

 My gut feeling is that the few people reading these feeds are also
 those that would know to check the SLA if they encountered an issue,
 or know how to use the RSS feed of the SLA page if they really wanted
 the information in real time.

Yeah, I use it, but really just because it's the laziest way to read
the SAL. To be quite honest, my identica noise would be a lot lower
without @wikimediatech .

 Meanwhile, we don't really have social media channels dedicated to
 Wikimedia tech stuff, i.e. channels where we can actually post stuff,
 links, blog posts, outage info, etc and engage with a larger community
 of people interested in our tech operations. I feel that the accounts
 would be much more useful if we reduced the amount of semi-random
 information we post there.

 So, I'm basically proposing to repurpose the @wikimediatech accounts for this.

 Thoughts? Good idea? Bad idea? You don't care?

+1, let's do it.

Roan

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


Re: [Wikitech-l] Who actually reads @wikimediatech ?

2011-11-29 Thread Arthur Richards
I read it, I like it, and I find it useful - particularly when I'm in
transit.

I agree it would be neat to be able to use twitter/identica for actual
humans to post stuff, but I don't think these need to be mutually exclusive
goals. Would it be silly to have separate accounts? One specifically for
bot logging and one specifically for actual human communication?

On Tue, Nov 29, 2011 at 11:32 AM, Roan Kattouw roan.katt...@gmail.comwrote:

 On Tue, Nov 29, 2011 at 8:25 PM, Guillaume Paumier
 gpaum...@wikimedia.org wrote:
  I'm wondering if there are actually people reading all the stuff
  that's pushed through these channels.
 
  My gut feeling is that the few people reading these feeds are also
  those that would know to check the SLA if they encountered an issue,
  or know how to use the RSS feed of the SLA page if they really wanted
  the information in real time.
 
 Yeah, I use it, but really just because it's the laziest way to read
 the SAL. To be quite honest, my identica noise would be a lot lower
 without @wikimediatech .

  Meanwhile, we don't really have social media channels dedicated to
  Wikimedia tech stuff, i.e. channels where we can actually post stuff,
  links, blog posts, outage info, etc and engage with a larger community
  of people interested in our tech operations. I feel that the accounts
  would be much more useful if we reduced the amount of semi-random
  information we post there.
 
  So, I'm basically proposing to repurpose the @wikimediatech accounts for
 this.
 
  Thoughts? Good idea? Bad idea? You don't care?
 
 +1, let's do it.

 Roan

 ___
 Wikitech-l mailing list
 Wikitech-l@lists.wikimedia.org
 https://lists.wikimedia.org/mailman/listinfo/wikitech-l




-- 
Arthur Richards
Software Engineer
Fundraising/Features/Offline/Mobile
[[User:Awjrichards]]
IRC: awjr
+1-415-839-6885 x6687
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


Re: [Wikitech-l] Dropping the 'LATER' resolution in Bugzilla

2011-11-29 Thread Daniel Friesen
On Tue, 29 Nov 2011 10:45:23 -0800, Diederik van Liere  
dvanli...@gmail.com wrote:

 Hi folks,

 Currently, we have a 'LATER' resolution in Bugzilla, it contains 339 bug
 reports over all the products, see:

 https://bugzilla.wikimedia.org/buglist.cgi?query_format=advancedlist_id=57731resolution=LATERproduct=CiviCRMproduct=Cortadoproduct=dbzip2product=Kate%27s%20Toolsproduct=Logwoodproduct=MediaWikiproduct=MediaWiki%20extensionsproduct=mwdumperproduct=mwEmbedproduct=Wikimediaproduct=Wikimedia%20Mobileproduct=Wikimedia%20Toolsproduct=Wiktionary%20toolsproduct=XML%20Snapshots

 The question is, when is LATER? Technically, these bugs are not open and  
 so
 nobody will ever see them again and that's how they will be forgotten.

 To me, it seems that bugs that are labeled LATER should either be  
 labeled:
 1) WONTFIX, which I guess is the majority of these bugs
 2) WORKSFORME, I am sure some things have been fixed
 3) NEW, it is a real bug / feature request.

 So why not do a mass change from LATER to NEW, and give them a fresh pair
 of eyes? and remove the LATER option from Bugzilla.


 Best,

 Diederik

This - https://bugzilla.wikimedia.org/show_bug.cgi?id=18082
Is not really WONTFIX, nor FIXED, nor WORKSFORME... and do you really want  
it marked as an open bug when it won't be implemented at all for ages  
until browsers actually have feature support that would make it possible  
to implement?

Sounds like a bad way to make our list of open bugs grow in a needless way  
and cloud up real bug reports we can and want to fix, with bug reports  
that won't be fixable for quite awhile due to external sources.


-- 
~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://daniel.friesen.name]

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


Re: [Wikitech-l] Who actually reads @wikimediatech ?

2011-11-29 Thread Sebastian Sooth
Hi,

I use it (since two days - after I found this account), because it's the 
fastest way to the SAL updates for me.

But I would also use an account like @wikimediatechSAL - so I think it would be 
fine if you would use @wikimediatech for communications - as long as you set up 
a new twitter account for SAL-Updates. :)

Regards,

Sebastian Sooth

Projektmanager / IT Management
-
Wikimedia Deutschland e.V.
Eisenacher Straße 2
10777 Berlin

Telefon 030 - 219 158 26-0
www.wikimedia.de

Stellen Sie sich eine Welt vor, in der jeder Mensch an der Menge allen Wissens 
frei teilhaben kann. Helfen Sie uns dabei!
http://spenden.wikimedia.de/

 Helfen Sie mit, dass WIKIPEDIA von der UNESCO als erstes digitales 
Weltkulturerbe anerkannt wird. 
Unterzeichnen Sie die Online-Petition! http://wikipedia.de 

Wikimedia Deutschland - Gesellschaft zur Förderung Freien Wissens e. V.
Eingetragen im Vereinsregister des Amtsgerichts Berlin-Charlottenburg unter der 
Nummer 23855 Nz. Als gemeinnützig anerkannt durch das Finanzamt für 
Körperschaften I Berlin, Steuernummer 27/681/51985.

On 29.11.2011, at 20:25, Guillaume Paumier wrote:

 Hi all,
 
 We've had @wikimediatech accounts on twitter  identica for some time now:
 * http://identi.ca/wikimediatech
 * https://twitter.com/#!/wikimediatech
 that basically broadcast every single action that is logged to the
 server admin log:
 * http://wikitech.wikimedia.org/view/Server_admin_log
 
 The account has 78 followers on identica and 430 on twitter (probably
 counting the spammers).
 
 I'm wondering if there are actually people reading all the stuff
 that's pushed through these channels.
 
 My gut feeling is that the few people reading these feeds are also
 those that would know to check the SLA if they encountered an issue,
 or know how to use the RSS feed of the SLA page if they really wanted
 the information in real time.
 
 Meanwhile, we don't really have social media channels dedicated to
 Wikimedia tech stuff, i.e. channels where we can actually post stuff,
 links, blog posts, outage info, etc and engage with a larger community
 of people interested in our tech operations. I feel that the accounts
 would be much more useful if we reduced the amount of semi-random
 information we post there.
 
 So, I'm basically proposing to repurpose the @wikimediatech accounts for this.
 
 Thoughts? Good idea? Bad idea? You don't care?
 
 -- 
 Guillaume Paumier
 Technical Communications Manager — Wikimedia Foundation
 http://donate.wikimedia.org
 
 ___
 Wikitech-l mailing list
 Wikitech-l@lists.wikimedia.org
 https://lists.wikimedia.org/mailman/listinfo/wikitech-l


___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


Re: [Wikitech-l] Who actually reads @wikimediatech ?

2011-11-29 Thread Guillaume Paumier
On Tue, Nov 29, 2011 at 8:38 PM, Arthur Richards
aricha...@wikimedia.org wrote:
 I read it, I like it, and I find it useful - particularly when I'm in
 transit.

 I agree it would be neat to be able to use twitter/identica for actual
 humans to post stuff, but I don't think these need to be mutually exclusive
 goals. Would it be silly to have separate accounts? One specifically for
 bot logging and one specifically for actual human communication?

Not silly at all. As a matter of fact, while you were writing that, I
was registering @wikitechlog on both services, which I think is a
better alternative for automated notifications.

So, unless there are serious concerns, we'll be switching the
automated notifications to @wikitechlog, and we'll repurpose
@wikimediatech for the human stuff.

-- 
Guillaume Paumier
Technical Communications Manager — Wikimedia Foundation
http://donate.wikimedia.org

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r104580]: New comment added, and revision status changed

2011-11-29 Thread MediaWiki Mail
User Raymond changed the status of MediaWiki.r104580.

Old Status: deferred
New Status: fixme

User Raymond also posted a comment on MediaWiki.r104580.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104580#c26713
Commit summary:

some initial work on bug 32698

Comment:

https://translatewiki.net/wiki/User:Boniface

pre
Invalid coordinate data passed to the SMWDIGeoCoord constructor

Backtrace:

#0 /www/w/extensions/SemanticMaps/includes/SM_GeoCoordsValue.php(105): 
SMWDIGeoCoord-__construct(Array)
#1 /www/w/extensions/SemanticMaps/includes/SM_GeoCoordsValue.php(51): 
SMGeoCoordsValue-parseUserValueOrQuery('{{{1}}}')
#2 
/www/w/extensions/SemanticMediaWiki/includes/datavalues/SMW_DataValue.php(169): 
SMGeoCoordsValue-parseUserValue('{{{1}}}')
#3 /www/w/extensions/SemanticMediaWiki/includes/SMW_DataValueFactory.php(113): 
SMWDataValue-setUserValue('{{{1}}}', false)
#4 /www/w/extensions/SemanticMediaWiki/includes/SMW_DataValueFactory.php(177): 
SMWDataValueFactory::newTypeIdValue('_geo', '{{{1}}}', false, 
Object(SMWDIProperty), Object(SMWDIWikiPage))
#5 /www/w/extensions/SemanticMediaWiki/includes/SMW_ParseData.php(113): 
SMWDataValueFactory::newPropertyObjectValue(Object(SMWDIProperty), '{{{1}}}', 
false, Object(SMWDIWikiPage))
#6 /www/w/extensions/SemanticMediaWiki/includes/SMW_ParserExtensions.php(165): 
SMWParseData::addProperty('Coordinates', '{{{1}}}', false, Object(Parser), true)
#7 /www/w/extensions/SemanticMediaWiki/includes/SMW_ParserExtensions.php(112): 
SMWParserExtensions::parsePropertiesCallback(Array)
#8 [internal function]: 
SMWParserExtensions::simpleParsePropertiesCallback(Array)
#9 /www/w/extensions/SemanticMediaWiki/includes/SMW_ParserExtensions.php(71): 
preg_replace_callback('/\[\[ ...', Array, 'span style=di...')
#10 [internal function]: 
SMWParserExtensions::onInternalParseBeforeLinks(Object(Parser), 'span 
style=di...', Object(StripState))
#11 /www/w/includes/Hooks.php(216): call_user_func_array('SMWParserExtens...', 
Array)
#12 /www/w/includes/GlobalFunctions.php(3730): Hooks::run('InternalParseBe...', 
Array)
#13 /www/w/includes/parser/Parser.php(1073): wfRunHooks('InternalParseBe...', 
Array)
#14 /www/w/includes/parser/Parser.php(345): 
Parser-internalParse('{{Location}}?{{...')
#15 /www/w/includes/WikiPage.php(2827): Parser-parse('{{Location}}?{{...', 
Object(Title), Object(ParserOptions), true, true, 3133281)
#16 /www/w/includes/PoolCounter.php(187): PoolWorkArticleView-doWork()
#17 /www/w/includes/Article.php(556): PoolCounterWork-execute()
#18 /www/w/includes/Wiki.php(495): Article-view()
#19 /www/w/includes/Wiki.php(266): MediaWiki-performAction(Object(Article))
#20 /www/w/includes/Wiki.php(619): MediaWiki-performRequest()
#21 /www/w/includes/Wiki.php(538): MediaWiki-main()
#22 /www/w/index.php(58): MediaWiki-run()
#23 {main}
/pre

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


Re: [Wikitech-l] Who actually reads @wikimediatech ?

2011-11-29 Thread Brandon Harris


Do we *have* to rename the feeds?

We rename *everything*. I'm unsure why we can't just create a different 
account for people, rather than subvert the existing one. 
WikimediaTechNews, maybe. I don't know.

On 11/29/11 11:44 AM, Guillaume Paumier wrote:

 Not silly at all. As a matter of fact, while you were writing that, I
 was registering @wikitechlog on both services, which I think is a
 better alternative for automated notifications.

 So, unless there are serious concerns, we'll be switching the
 automated notifications to @wikitechlog, and we'll repurpose
 @wikimediatech for the human stuff.


-- 
Brandon Harris, Senior Designer, Wikimedia Foundation

Support Free Knowledge: http://wikimediafoundation.org/wiki/Donate

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


Re: [Wikitech-l] Who actually reads @wikimediatech ?

2011-11-29 Thread Guillaume Paumier
On Tue, Nov 29, 2011 at 8:48 PM, Brandon Harris bhar...@wikimedia.org wrote:

        Do we *have* to rename the feeds?

        We rename *everything*. I'm unsure why we can't just create a different
 account for people, rather than subvert the existing one.
 WikimediaTechNews, maybe. I don't know.

wikimediatech is shorter (which facilitates manual retweets) and
frankly it's the name I would consider canonical for an account about
wikimedia tech stuff (@wikitech is someone else).

Plus, we get to leverage the existing readership, while at the same
time offering the possibility to subscribe to the automated log
notifications for people who still want to read them.

-- 
Guillaume Paumier
Technical Communications Manager — Wikimedia Foundation

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Dropping the 'LATER' resolution in Bugzilla

2011-11-29 Thread Merlijn van Deen
On 29 November 2011 19:45, Diederik van Liere dvanli...@gmail.com wrote:

 The question is, when is LATER? Technically, these bugs are not open and so
 nobody will ever see them again and that's how they will be forgotten.


I would interpret 'LATER' as 'this bug should be re-evaluated after a
certain period of time'.

Following this train of thought, a LATER bug should have a re-evaluation
date planned, after which it is changed back to NEW. This probably is not
possible, but I think it makes sense to change LATER bugs to NEW after,
say, a year or so.

Merlijn
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


Re: [Wikitech-l] Dropping the 'LATER' resolution in Bugzilla

2011-11-29 Thread Thomas Dalton
On 29 November 2011 19:43, Daniel Friesen li...@nadir-seen-fire.com wrote:
 This - https://bugzilla.wikimedia.org/show_bug.cgi?id=18082
 Is not really WONTFIX, nor FIXED, nor WORKSFORME... and do you really want
 it marked as an open bug when it won't be implemented at all for ages
 until browsers actually have feature support that would make it possible
 to implement?

 Sounds like a bad way to make our list of open bugs grow in a needless way
 and cloud up real bug reports we can and want to fix, with bug reports
 that won't be fixable for quite awhile due to external sources.

The reason WONTFIX, FIXED and WORKSFORME don't make sense is because
that isn't a bug, it's an enhancement request. Perhaps the solution is
to not include enhancements in the list of bugs by default. It's
natural that enhancement requests will sometimes sit around for ages
before they get implemented, that doesn't mean we should mark them as
resolved when they aren't.

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


Re: [Wikitech-l] Who actually reads @wikimediatech ?

2011-11-29 Thread Brandon Harris

There's only 78 followers. Most of them are staff.  That's not a lot of 
people to leverage, so I'm not sure that's a valid point.

Why not wmftech ?



On 11/29/11 11:53 AM, Guillaume Paumier wrote:
 On Tue, Nov 29, 2011 at 8:48 PM, Brandon Harrisbhar...@wikimedia.org  wrote:

 Do we *have* to rename the feeds?

 We rename *everything*. I'm unsure why we can't just create a 
 different
 account for people, rather than subvert the existing one.
 WikimediaTechNews, maybe. I don't know.

 wikimediatech is shorter (which facilitates manual retweets) and
 frankly it's the name I would consider canonical for an account about
 wikimedia tech stuff (@wikitech is someone else).

 Plus, we get to leverage the existing readership, while at the same
 time offering the possibility to subscribe to the automated log
 notifications for people who still want to read them.


-- 
Brandon Harris, Senior Designer, Wikimedia Foundation

Support Free Knowledge: http://wikimediafoundation.org/wiki/Donate

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


Re: [Wikitech-l] Dropping the 'LATER' resolution in Bugzilla

2011-11-29 Thread Chad
On Tue, Nov 29, 2011 at 2:53 PM, Merlijn van Deen valhall...@arctus.nl wrote:
 On 29 November 2011 19:45, Diederik van Liere dvanli...@gmail.com wrote:

 The question is, when is LATER? Technically, these bugs are not open and so
 nobody will ever see them again and that's how they will be forgotten.


 I would interpret 'LATER' as 'this bug should be re-evaluated after a
 certain period of time'.

 Following this train of thought, a LATER bug should have a re-evaluation
 date planned, after which it is changed back to NEW. This probably is not
 possible, but I think it makes sense to change LATER bugs to NEW after,
 say, a year or so.


Reviewed perhaps, but not necessarily marked back to NEW unless we
actually plan to take action on it.

-Chad

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


Re: [Wikitech-l] Who actually reads @wikimediatech ?

2011-11-29 Thread Guillaume Paumier
On Tue, Nov 29, 2011 at 8:57 PM, Brandon Harris bhar...@wikimedia.org wrote:

        There's only 78 followers. Most of them are staff.  That's not a lot of
 people to leverage, so I'm not sure that's a valid point.

78 on identica, 430 on twitter

        Why not wmftech ?

Because initialisms are plain Evil, and Wikimedia != WMF.

If there is any other reason that you think should prevent us from
doing the switch (besides personal comfort), I'm happy to hear them
(on or off-list).

-- 
Guillaume Paumier
Technical Communications Manager — Wikimedia Foundation
http://donate.wikimedia.org

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] Dropping the 'LATER' resolution in Bugzilla

2011-11-29 Thread Diederik van Liere
I agree, currently the LATER acts as a blackhole and there is no structured
process to re-evaluate these kind of bugs.

I have done a lot of reading of these bugs and many were filed 3 to 5 years
ago, I think it's better to say WONTFIX then to suggest that this is
something that is going to be fixed.
It is about expectation management :)

On Tue, Nov 29, 2011 at 2:53 PM, Merlijn van Deen valhall...@arctus.nlwrote:

 On 29 November 2011 19:45, Diederik van Liere dvanli...@gmail.com wrote:

  The question is, when is LATER? Technically, these bugs are not open and
 so
  nobody will ever see them again and that's how they will be forgotten.
 

 I would interpret 'LATER' as 'this bug should be re-evaluated after a
 certain period of time'.

 Following this train of thought, a LATER bug should have a re-evaluation
 date planned, after which it is changed back to NEW. This probably is not
 possible, but I think it makes sense to change LATER bugs to NEW after,
 say, a year or so.

 Merlijn
 ___
 Wikitech-l mailing list
 Wikitech-l@lists.wikimedia.org
 https://lists.wikimedia.org/mailman/listinfo/wikitech-l




-- 
a href=http://about.me/diederik;Check out my about.me profile!/a
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


[MediaWiki-CodeReview] [MediaWiki r104248]: Revision status changed

2011-11-29 Thread MediaWiki Mail
User Kaldari changed the status of MediaWiki.r104248.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104248
Commit summary:

Don't list these SpecialPages, it's raw output (ew)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104247]: Revision status changed

2011-11-29 Thread MediaWiki Mail
User Kaldari changed the status of MediaWiki.r104247.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104247
Commit summary:

msg function was overriding the new msg() function in SpecialPage, and is 
causing a fatal error in 1.19

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104370]: Revision status changed

2011-11-29 Thread MediaWiki Mail
User Kaldari changed the status of MediaWiki.r104370.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104370
Commit summary:

Comments

A fixme on a wrong function call

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104372]: Revision status changed

2011-11-29 Thread MediaWiki Mail
User Kaldari changed the status of MediaWiki.r104372.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104372
Commit summary:

6 possible queries from one method? Now that's just hard to trace

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104424]: Revision status changed

2011-11-29 Thread MediaWiki Mail
User Kaldari changed the status of MediaWiki.r104424.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104424
Commit summary:

Spaces to tabs

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104428]: Revision status changed

2011-11-29 Thread MediaWiki Mail
User Kaldari changed the status of MediaWiki.r104428.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104428
Commit summary:

Followup r104425, missed removing a line in FundraiserStatistics_body.php

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104425]: Revision status changed

2011-11-29 Thread MediaWiki Mail
User Kaldari changed the status of MediaWiki.r104425.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104425
Commit summary:

* (bug 32682) Remove hard coded CSS from ContributionHistory_body 
(Contributions Reporting)
* (bug 32681) Resource Loader-ify ContributionsReporting

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104481]: Revision status changed

2011-11-29 Thread MediaWiki Mail
User Awjrichards changed the status of MediaWiki.r104481.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104481
Commit summary:

small optimization to DailyTotal

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


Re: [Wikitech-l] Who actually reads @wikimediatech ?

2011-11-29 Thread Chad
On Tue, Nov 29, 2011 at 2:25 PM, Guillaume Paumier
gpaum...@wikimedia.org wrote:
 The account has 78 followers on identica and 430 on twitter (probably
 counting the spammers).


Make that 77 and 429. Just unsubscribed from both because I
haven't read them in forever...actually, I never really read them.

I get info straight from the SAL.

-Chad

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


Re: [Wikitech-l] Dropping the 'LATER' resolution in Bugzilla

2011-11-29 Thread Daniel Friesen
On Tue, 29 Nov 2011 11:56:53 -0800, Thomas Dalton  
thomas.dal...@gmail.com wrote:

 On 29 November 2011 19:43, Daniel Friesen li...@nadir-seen-fire.com  
 wrote:
 This - https://bugzilla.wikimedia.org/show_bug.cgi?id=18082
 Is not really WONTFIX, nor FIXED, nor WORKSFORME... and do you really  
 want
 it marked as an open bug when it won't be implemented at all for ages
 until browsers actually have feature support that would make it possible
 to implement?

 Sounds like a bad way to make our list of open bugs grow in a needless  
 way
 and cloud up real bug reports we can and want to fix, with bug reports
 that won't be fixable for quite awhile due to external sources.

 The reason WONTFIX, FIXED and WORKSFORME don't make sense is because
 that isn't a bug, it's an enhancement request. Perhaps the solution is
 to not include enhancements in the list of bugs by default. It's
 natural that enhancement requests will sometimes sit around for ages
 before they get implemented, that doesn't mean we should mark them as
 resolved when they aren't.

No. We have plenty of enhancement requests that don't fit into WONTFIX,  
FIXED, WORKSFORME, or LATER. And we don't want to make those disappear,  
those are valid bugs to keep open.

The reason why WONTFIX, FIXED, and WORKSFORME doesn't fit that bug is  
because it's dependent on external systems implementing functionality in  
order for us to be able to implement the feature. Hence, LATER when they  
are implemented.

-- 
~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://daniel.friesen.name]

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


Re: [Wikitech-l] Who actually reads @wikimediatech ?

2011-11-29 Thread aude
On Nov 29, 2011, at 3:04 PM, Guillaume Paumier  
gpaum...@wikimedia.org wrote:

 On Tue, Nov 29, 2011 at 8:57 PM, Brandon Harris  
 bhar...@wikimedia.org wrote:

There's only 78 followers. Most of them are staff.  That's  
 not a lot of
 people to leverage, so I'm not sure that's a valid point.

 78 on identica, 430 on twitter

Why not wmftech ?

 Because initialisms are plain Evil, and Wikimedia != WMF.

 If there is any other reason that you think should prevent us from
 doing the switch (besides personal comfort), I'm happy to hear them
 (on or off-list).

Why can't we do both the switch on @wikimediatech and for those of us  
who find the server log tweets interesting, how about have  
@wikimediaops?

Cheers,
Katie



 -- 
 Guillaume Paumier
 Technical Communications Manager — Wikimedia Foundation
 http://donate.wikimedia.org

 ___
 Wikitech-l mailing list
 Wikitech-l@lists.wikimedia.org
 https://lists.wikimedia.org/mailman/listinfo/wikitech-l

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r104580]: New comment added

2011-11-29 Thread MediaWiki Mail
User Jeroen De Dauw posted a comment on MediaWiki.r104580.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104580#c26714
Commit summary:

some initial work on bug 32698

Comment:

wtf... I don't see anything wrong w/ the code.

Very useful stack trace, fails to list on which line the exception is thrown _

Can you run update.php and see if it goes away? There was some schema change, 
so not running it might be the reason for this error.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104580]: New comment added

2011-11-29 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r104580.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104580#c26715
Commit summary:

some initial work on bug 32698

Comment:

 Very useful stack trace, fails to list on which line the exception is thrown 
_

#0 /www/w/extensions/SemanticMaps/includes/SM_GeoCoordsValue.php(105): 
SMWDIGeoCoord-__construct(Array)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104580]: New comment added

2011-11-29 Thread MediaWiki Mail
User Raymond posted a comment on MediaWiki.r104580.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104580#c26716
Commit summary:

some initial work on bug 32698

Comment:

Sorry about missing the line. From #mediawiki-i18n channel: mediawiki-bw_: 
/wiki/User:Boniface Exception from line 63 of 
/www/w/extensions/SemanticMediaWiki/includes/dataitems/SMW_DI_GeoCoord.php: 
Invalid coordinate data passed to the SMWDIGeoCoord constructor

Schema change? In which revision? 

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


Re: [Wikitech-l] Dropping the 'LATER' resolution in Bugzilla

2011-11-29 Thread Jay Ashworth
- Original Message -
 From: Diederik van Liere dvanli...@gmail.com

 The question is, when is LATER? Technically, these bugs are not open and so
 nobody will ever see them again and that's how they will be forgotten.

I would assume that LATER is, in a release after this one... and that 
the proper solution is to do as you suggest (stripe them back to NEW)
*after the next release is cut*.

Anyone think that's a bad idea?

Do we have a Target release in our BZ?

Cheers,
-- jra
-- 
Jay R. Ashworth  Baylink   j...@baylink.com
Designer The Things I Think   RFC 2100
Ashworth  Associates http://baylink.pitas.com 2000 Land Rover DII
St Petersburg FL USA  http://photo.imageinc.us +1 727 647 1274

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


Re: [Wikitech-l] Who actually reads @wikimediatech ?

2011-11-29 Thread Jay Ashworth
- Original Message -
 From: Guillaume Paumier gpaum...@wikimedia.org

 I'm wondering if there are actually people reading all the stuff
 that's pushed through these channels.

Now that I know it's there, I'll certainly be reading it; thanks for the
headsup.  ;-)

Cheers,
-- jra
-- 
Jay R. Ashworth  Baylink   j...@baylink.com
Designer The Things I Think   RFC 2100
Ashworth  Associates http://baylink.pitas.com 2000 Land Rover DII
St Petersburg FL USA  http://photo.imageinc.us +1 727 647 1274

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


Re: [Wikitech-l] Who actually reads @wikimediatech ?

2011-11-29 Thread Jay Ashworth
- Original Message -
 From: Guillaume Paumier gpaum...@wikimedia.org

 Meanwhile, we don't really have social media channels dedicated to
 Wikimedia tech stuff, i.e. channels where we can actually post stuff,
 links, blog posts, outage info, etc and engage with a larger community
 of people interested in our tech operations. I feel that the accounts
 would be much more useful if we reduced the amount of semi-random
 information we post there.
 
 So, I'm basically proposing to repurpose the @wikimediatech accounts
 for this.

I think I concur with whomever suggested stripping logmsgbot's postings
out of that to a separate feed, as well, now that I've looked at it.

Cheers,
-- jra
-- 
Jay R. Ashworth  Baylink   j...@baylink.com
Designer The Things I Think   RFC 2100
Ashworth  Associates http://baylink.pitas.com 2000 Land Rover DII
St Petersburg FL USA  http://photo.imageinc.us +1 727 647 1274

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


Re: [Wikitech-l] Who actually reads @wikimediatech ?

2011-11-29 Thread Jay Ashworth
- Original Message -
 From: Guillaume Paumier gpaum...@wikimedia.org

 Not silly at all. As a matter of fact, while you were writing that, I
 was registering @wikitechlog on both services, which I think is a
 better alternative for automated notifications.

What you said.  :-)

Cheers,
-- jra
-- 
Jay R. Ashworth  Baylink   j...@baylink.com
Designer The Things I Think   RFC 2100
Ashworth  Associates http://baylink.pitas.com 2000 Land Rover DII
St Petersburg FL USA  http://photo.imageinc.us +1 727 647 1274

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


[MediaWiki-CodeReview] [MediaWiki r102083]: New comment added

2011-11-29 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r102083.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102083#c26717
Commit summary:

Made use of Pager::doBatchLookups() and Pager::getUser() in special page Pagers

Comment:

Oh, I thought you were talking about the core function.

I'm not sure if it's worth a common method. Different Pagers will want 
different batch lookups. Though a page_namespace,page_title one is probably 
common enough to deserve a function maybe. I don't want nominal OOP just for 
code reuse though.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104580]: New comment added

2011-11-29 Thread MediaWiki Mail
User Jeroen De Dauw posted a comment on MediaWiki.r104580.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104580#c26718
Commit summary:

some initial work on bug 32698

Comment:

Which is not the line where the exception is thrown.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104580]: New comment added

2011-11-29 Thread MediaWiki Mail
User Jeroen De Dauw posted a comment on MediaWiki.r104580.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104580#c26719
Commit summary:

some initial work on bug 32698

Comment:

The schema change was in this revision, see the changes to SMW_SQLStore2. I 
think I fixed the issue in the follow up rev though.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104580]: Revision status changed

2011-11-29 Thread MediaWiki Mail
User Jeroen De Dauw changed the status of MediaWiki.r104580.

Old Status: fixme
New Status: new

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104580
Commit summary:

some initial work on bug 32698

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r103997]: Revision status changed

2011-11-29 Thread MediaWiki Mail
User Trevor Parscal changed the status of MediaWiki.r103997.

Old Status: fixme
New Status: resolved

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103997
Commit summary:

Initial separation of toolbar code into ToolbarView

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104592]: Revision status changed

2011-11-29 Thread MediaWiki Mail
User Raymond changed the status of MediaWiki.r104592.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104592
Commit summary:

Change number separator from dot to a space, per User:Nemo_bis (it is the 
convention in Italian to use spaces)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


Re: [Wikitech-l] Dropping the 'LATER' resolution in Bugzilla

2011-11-29 Thread Dan Collins
I'm noticing that a lot of the RESO LATE bugs are requests for
extensions or site requests which either:
1) We aren't currently installing that extension (Ok for these to be RESO LATE)
2) The original requester needs to provide further information

Do we want that second category to be resolved later? If so, we're
going to be waiting a long time for people to come back with more
details. Should bugs that are resolved later because the original
requester or someone else needs to provide more info instead be closed
invalid, or something else?

--
Dan Collins

On Tue, Nov 29, 2011 at 4:00 PM, Jay Ashworth j...@baylink.com wrote:
 - Original Message -
 From: Diederik van Liere dvanli...@gmail.com

 The question is, when is LATER? Technically, these bugs are not open and so
 nobody will ever see them again and that's how they will be forgotten.

 I would assume that LATER is, in a release after this one... and that
 the proper solution is to do as you suggest (stripe them back to NEW)
 *after the next release is cut*.

 Anyone think that's a bad idea?

 Do we have a Target release in our BZ?

 Cheers,
 -- jra
 --
 Jay R. Ashworth                  Baylink                       
 j...@baylink.com
 Designer                     The Things I Think                       RFC 2100
 Ashworth  Associates     http://baylink.pitas.com         2000 Land Rover DII
 St Petersburg FL USA      http://photo.imageinc.us             +1 727 647 1274

 ___
 Wikitech-l mailing list
 Wikitech-l@lists.wikimedia.org
 https://lists.wikimedia.org/mailman/listinfo/wikitech-l


___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r104587]: Revision status changed

2011-11-29 Thread MediaWiki Mail
User SPQRobin changed the status of MediaWiki.r104587.

Old Status: new
New Status: deferred

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104587
Commit summary:

Localisation updates for core and extension messages from translatewiki.net

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r104582]: Revision status changed

2011-11-29 Thread MediaWiki Mail
User SPQRobin changed the status of MediaWiki.r104582.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104582
Commit summary:

Fix PHP error from r104575
PHP Parse error: syntax error, unexpected T_STRING, expecting ')' in 
/home/betawiki/projects/mediawiki-ext/Math/Math.i18n.php on line 2235
Full export will readd missing messages.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


Re: [Wikitech-l] Who actually reads @wikimediatech ?

2011-11-29 Thread MZMcBride
 On Nov 29, 2011 11:25 AM, Guillaume Paumier gpaum...@wikimedia.org
 wrote:
 My gut feeling is that the few people reading these feeds are also
 those that would know to check the SLA if they encountered an issue,
 or know how to use the RSS feed of the SLA page if they really wanted
 the information in real time.

I think server admin log is usually abbreviated as SAL, not SLA. ;-)

 Meanwhile, we don't really have social media channels dedicated to
 Wikimedia tech stuff, i.e. channels where we can actually post stuff,
 links, blog posts, outage info, etc and engage with a larger community
 of people interested in our tech operations. I feel that the accounts
 would be much more useful if we reduced the amount of semi-random
 information we post there.

 So, I'm basically proposing to repurpose the @wikimediatech accounts for
 this.

Brion Vibber wrote:
 Most likely we would be better off with human updates in there, but we may
 need some designated tweeters to make sure it happens reliably when there
 are issues to report, new features to mention, or upcoming stuff we want
 feedback on.

I agree with Brion. Human updates would be nice. The truncated and often
context-less messages in the current feed are rather useless.

MZMcBride



___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


Re: [Wikitech-l] Who actually reads @wikimediatech ?

2011-11-29 Thread Roan Kattouw
On Tue, Nov 29, 2011 at 11:14 PM, MZMcBride z...@mzmcbride.com wrote:
 I agree with Brion. Human updates would be nice. The truncated and often
 context-less messages in the current feed are rather useless.

We would have to do it in some sort of convenient way that doesn't
involve logging out of one's own account and logging into the
wikimediatech account using the password you had to look up on a
server somewhere. I was thinking we could have a script on fenari that
does it, that way it's convenient but still restricted to people with
command-line access (as opposed to !log which is unrestricted).

Roan

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


[MediaWiki-CodeReview] [MediaWiki r104580]: New comment added

2011-11-29 Thread MediaWiki Mail
User Raymond posted a comment on MediaWiki.r104580.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104580#c26720
Commit summary:

some initial work on bug 32698

Comment:

Thanks, works again.

BTW: It would be helpful to announce a schema change in the commit message. 
Thanks.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


[MediaWiki-CodeReview] [MediaWiki r103658]: Revision status changed

2011-11-29 Thread MediaWiki Mail
User Tim Starling changed the status of MediaWiki.r103658.

Old Status: new
New Status: resolved

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103658
Commit summary:

add click handler to switch instantly between pics

Follow up request by Bryan on r103309

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview


  1   2   >