[MediaWiki-CodeReview] [MediaWiki r101639]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r101639. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101639 Commit summary: Use isRedirect() accessor ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r101674]: New comment added

2011-11-03 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r101674. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101674#c25379 Commit summary: Follow-up to r101580 - added decodeCharReferences() call from patch Comment: Don't you need to do the same for $inLinkStr? I guess this is meant

[MediaWiki-CodeReview] [MediaWiki r101680]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r101680. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101680 Commit summary: Make use of Title::isSpecialPage() in various places ___

[MediaWiki-CodeReview] [MediaWiki r100366]: New comment added

2011-11-03 Thread MediaWiki Mail
User Peachey88 posted a comment on MediaWiki.r100366. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100366#c25380 Commit summary: Also bundle ConfirmEdit, Gadgets, Nuke, RenameUser and WikiEditor Comment: Also, Have these extensions where appropriate been checked for their DB

[MediaWiki-CodeReview] [MediaWiki r101755]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r101755. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101755 Commit summary: Fixed undefined '$wgMaxImageAre' var ___ MediaWiki-CodeReview mailing list

Re: [Wikitech-l] Wikipedia CAPTCHA repair

2011-11-03 Thread Niklas Laxström
On 3 November 2011 04:59, Neil Harris n...@tonal.clara.co.uk wrote: Accordingly, I've reworked the 2005-era CAPTCHA-image-generating Python script in the CAPTCHA engine in a way that I hope should be a drop-in replacement for the existing script. Would anyone be interested in taking a look at

[MediaWiki-CodeReview] [MediaWiki r101793]: New comment added

2011-11-03 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r101793. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101793#c25381 Commit summary: * Use WikiPage instead of Article and call doDeleteArticle() with a custom error message instead of calling doDelete() * Call

[MediaWiki-CodeReview] [MediaWiki r101793]: New comment added

2011-11-03 Thread MediaWiki Mail
User IAlex posted a comment on MediaWiki.r101793. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101793#c25382 Commit summary: * Use WikiPage instead of Article and call doDeleteArticle() with a custom error message instead of calling doDelete() * Call

[MediaWiki-CodeReview] [pywikipedia r9724]: New comment added

2011-11-03 Thread MediaWiki Mail
User Valhallasw posted a comment on pywikipedia.r9724. Full URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9724#c25383 Commit summary: bugfix: bot incorrectly noted edit conflicts on semiprotected pages Comment: Hi Andre, How does this work? Is there a bug in the MW API where one

[MediaWiki-CodeReview] [MediaWiki r96517]: New comment added

2011-11-03 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r96517. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96517#c25384 Commit summary: Merge r90266 to trunk Fixes fixme on r75341, r75343 Comment: So, what is the expected behavior? ___

[MediaWiki-CodeReview] [pywikipedia r9724]: New comment added

2011-11-03 Thread MediaWiki Mail
User Andre Engels posted a comment on pywikipedia.r9724. Full URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9724#c25385 Commit summary: bugfix: bot incorrectly noted edit conflicts on semiprotected pages Comment: I had not checked yet, I just found that they were different

[MediaWiki-CodeReview] [MediaWiki r101784]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User MaxSem changed the status of MediaWiki.r101784. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101784 Commit summary: Typofix in comment ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r100413]: New comment added

2011-11-03 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r100413. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100413#c25386 Commit summary: Added a forgotten file Followup r100345 and Internationalization/#129 Comment: It does, thank you.

[MediaWiki-CodeReview] [MediaWiki r101477]: New comment added

2011-11-03 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r101477. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101477#c25387 Commit summary: Table for message group states Internationalization/#173 Comment: That seems to be the case yes: 83 not null 1 Not null 3222 NOT

[MediaWiki-CodeReview] [MediaWiki r100974]: New comment added

2011-11-03 Thread MediaWiki Mail
User Santhosh.thottingal posted a comment on MediaWiki.r100974. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100974#c25388 Commit summary: Committing my proof of concept extension for feedback Depends on setlang parameter provided by language selector Comment: if ( count++ =

Re: [Wikitech-l] New permission for moodbar

2011-11-03 Thread Petr Bena
Sorry, I meant I *could not *find it (typo), Question is, if it's really needed? If it's for statistical purpose, I believe that there is already some tracking mechanism on wmf cluster which may know what pages are being viewed most etc. where this could be (but I really don't know this). And if

Re: [Wikitech-l] New permission for moodbar

2011-11-03 Thread Roan Kattouw
On Thu, Nov 3, 2011 at 6:03 AM, Risker risker...@gmail.com wrote: Petr, I mean the number of times [[Special:FeedbackDashboard]] is viewed; thanks for asking me to clarify. Best I can find is http://stats.grok.se/en/201110/Special%3AFeedbackDashboard Roan

[MediaWiki-CodeReview] [MediaWiki r100974]: New comment added

2011-11-03 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r100974. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100974#c25389 Commit summary: Committing my proof of concept extension for feedback Depends on setlang parameter provided by language selector Comment: Duplicated values: yes,

[Wikitech-l] Wikimedia engineering report for October 2011

2011-11-03 Thread Guillaume Paumier
Hi, The report covering Wikimedia engineering activities in October 2011 is now available. Wiki version: https://www.mediawiki.org/wiki/Wikimedia_engineering_report/2011/October Blog version: http://blog.wikimedia.org/2011/11/03/wikimedia-engineering-october-2011-report/ -- Guillaume Paumier

[MediaWiki-CodeReview] [MediaWiki r100366]: New comment added

2011-11-03 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r100366. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100366#c25391 Commit summary: Also bundle ConfirmEdit, Gadgets, Nuke, RenameUser and WikiEditor Comment: No, none of them add any new database tables

[MediaWiki-CodeReview] [MediaWiki r101551]: New comment added

2011-11-03 Thread MediaWiki Mail
User Reedy posted a comment on MediaWiki.r101551. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101551#c25392 Commit summary: arrray - array Whitespace Other documentation improvements Comment out some unused code (which has a fixme left with it already) Comment:

[MediaWiki-CodeReview] [MediaWiki r101808]: New comment added, and revision status changed

2011-11-03 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r101808. Old Status: new New Status: fixme User Hashar also posted a comment on MediaWiki.r101808. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101808#c25393 Commit summary: use isValidURI for redirect check Comment: Since

[MediaWiki-CodeReview] [MediaWiki r100055]: New comment added, and revision status changed

2011-11-03 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r100055. Old Status: new New Status: deferred User Hashar also posted a comment on MediaWiki.r100055. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100055#c25394 Commit summary: Start on a a test special phase, untested. Comment: I

[MediaWiki-CodeReview] [MediaWiki r100061]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r100061. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100061 Commit summary: More work on vips test special page ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r101375]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r101375. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101375 Commit summary: Partial revert of r99912: remove $wgEnableAutoRotation setting ___

[MediaWiki-CodeReview] [MediaWiki r99912]: New comment added, and revision status changed

2011-11-03 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r99912. Old Status: fixme New Status: new User Hashar also posted a comment on MediaWiki.r99912. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99912#c25395 Commit summary: Per bug 28135: * Set JPEG comment * Add comment about the

[MediaWiki-CodeReview] [MediaWiki r101666]: New comment added

2011-11-03 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r101666. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101666#c25396 Commit summary: * (bug 32126) Fix 1.18 regression in watchlist editor when items already removed from watchlist Overriding validation in HTMLForm bits so the extras

[MediaWiki-CodeReview] [MediaWiki r101802]: New comment added

2011-11-03 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r101802. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101802#c25397 Commit summary: (bug 31944). As a work around for bug 31944, don't extract tiff:YCbCrSubSampling from XMP. Several files have wrong type for that property, XMPReader

[MediaWiki-CodeReview] [MediaWiki r97150]: New comment added

2011-11-03 Thread MediaWiki Mail
User Fomafix posted a comment on MediaWiki.r97150. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97150#c25398 Commit summary: Update jquery.tablesorter for r97145: emulate thead if there is no thead in the HTML, by walking down the table starting at the first row and moving

[MediaWiki-CodeReview] [MediaWiki r101417]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r101417. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101417 Commit summary: jquery.tablesorter: Selector fixes * Various fixes to limit the selector to the current table and avoid selecting similar

[MediaWiki-CodeReview] [MediaWiki r101420]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r101420. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101420 Commit summary: jquery.tablesorter: More selector fixes * Limit to rowSpans (td or th) within tableRows that are a direct child of this

[MediaWiki-CodeReview] [MediaWiki r101794]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Santhosh.thottingal changed the status of MediaWiki.r101794. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101794 Commit summary: Embed WebFonts icon to reduce number of http requests ___

[MediaWiki-CodeReview] [MediaWiki r101795]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Santhosh.thottingal changed the status of MediaWiki.r101795. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101795 Commit summary: Small whitespace changes ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r101808]: New comment added

2011-11-03 Thread MediaWiki Mail
User MarkAHershberger posted a comment on MediaWiki.r101808. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101808#c25399 Commit summary: use isValidURI for redirect check Comment: That url would have passed before this change. ___

[MediaWiki-CodeReview] [MediaWiki r101804]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r101804. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101804 Commit summary: followup r101490, remove extra tabs after talking to Nikerabbit. ___

[MediaWiki-CodeReview] [MediaWiki r101490]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r101490. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101490 Commit summary: Style fixups ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r101805]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r101805. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101805 Commit summary: api examples++ ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r101806]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r101806. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101806 Commit summary: eol w/s ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r101808]: New comment added

2011-11-03 Thread MediaWiki Mail
User MarkAHershberger posted a comment on MediaWiki.r101808. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101808#c25400 Commit summary: use isValidURI for redirect check Comment: To be clear, before this change, https://Iam.very.secure.com/ would not have worked.

[MediaWiki-CodeReview] [MediaWiki r101807]: New comment added

2011-11-03 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r101807. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101807#c25401 Commit summary: man page help pages generation Tweaked mwdocgen.php to let us generates man pages. They will be saved to ./docs/man so make sure to update your

[MediaWiki-CodeReview] [MediaWiki r101807]: New comment added

2011-11-03 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r101807. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101807#c25402 Commit summary: man page help pages generation Tweaked mwdocgen.php to let us generates man pages. They will be saved to ./docs/man so make sure to update your MANPATH

[MediaWiki-CodeReview] [MediaWiki r101770]: New comment added

2011-11-03 Thread MediaWiki Mail
User SMcCandlish posted a comment on MediaWiki.r101770. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101770#c25403 Commit summary: Add Cite4Wiki straight from the unzipped xpi that I downloaded from https://addons.mozilla.org/en-US/firefox/addon/cite4wiki/ Doing this after

[MediaWiki-CodeReview] [MediaWiki r67684]: New comment added

2011-11-03 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r67684. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/67684#c25404 Commit summary: Fixes for r61911: * Do not follow redirects by default. This breaks on safe_mode, and may potentially open security vulnerabilities in callers which

[MediaWiki-CodeReview] [MediaWiki r101808]: New comment added, and revision status changed

2011-11-03 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r101808. Old Status: fixme New Status: ok User Hashar also posted a comment on MediaWiki.r101808. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101808#c25405 Commit summary: use isValidURI for redirect check Comment: Marking OK per

[MediaWiki-CodeReview] [MediaWiki r101817]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Platonides changed the status of MediaWiki.r101817. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101817 Commit summary: comment that isValidURI must reject file:// URI ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r101808]: New comment added

2011-11-03 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r101808. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101808#c25406 Commit summary: use isValidURI for redirect check Comment: The canonical name of this class is Http if I am not mistaken.

[MediaWiki-CodeReview] [MediaWiki r101809]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r101809. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101809 Commit summary: add special pages aliases and autoloading ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r101810]: New comment added

2011-11-03 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r101810. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101810#c25407 Commit summary: SpecialPage permission is now vipsscaler-test By default, everyone is allowed to use Special:VipsTest Comment: Rights should have right-rightname

[MediaWiki-CodeReview] [MediaWiki r101811]: New comment added

2011-11-03 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r101811. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101811#c25408 Commit summary: prefix i18n msg with vipsscaler- also added some missing translations and the qqq messages. Comment: pre -Invalid file: could not process

[MediaWiki-CodeReview] [MediaWiki r101812]: New comment added, and revision status changed

2011-11-03 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r101812. Old Status: new New Status: fixme User Nikerabbit also posted a comment on MediaWiki.r101812. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101812#c25409 Commit summary: implements Special:VipTest form Comment:

[MediaWiki-CodeReview] [MediaWiki r101813]: New comment added

2011-11-03 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r101813. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101813#c25410 Commit summary: add a nice title to the special page Comment: Does it test VIPS scaling or scaler? Would it be clearer to add word ''image'' in that?

[MediaWiki-CodeReview] [MediaWiki r101814]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r101814. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101814 Commit summary: output rendered thumbnail once form is submitted We probably want to force thumbnail rendering unconditionally. For some

[MediaWiki-CodeReview] [MediaWiki r101820]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r101820. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101820 Commit summary: typo ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r101807]: New comment added

2011-11-03 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r101807. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101807#c25411 Commit summary: man page help pages generation Tweaked mwdocgen.php to let us generates man pages. They will be saved to ./docs/man so make sure to update your

[MediaWiki-CodeReview] [MediaWiki r101812]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r101812. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101812 Commit summary: implements Special:VipTest form ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r101823]: New comment added

2011-11-03 Thread MediaWiki Mail
User Jpostlethwaite posted a comment on MediaWiki.r101823. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101823#c25412 Commit summary: Added helper methods: getTransactionDataFormAction() and getTransactionDataLanguage(). Comment: These have been added so we can stop handling

[MediaWiki-CodeReview] [MediaWiki r101824]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r101824. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101824 Commit summary: remove trailing whitespace in i18n messages follow up r101812 ___

[MediaWiki-CodeReview] [MediaWiki r101810]: New comment added

2011-11-03 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r101810. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101810#c25413 Commit summary: SpecialPage permission is now vipsscaler-test By default, everyone is allowed to use Special:VipsTest Comment: Described in follow up r101825.

[MediaWiki-CodeReview] [MediaWiki r100497]: New comment added

2011-11-03 Thread MediaWiki Mail
User Liangent posted a comment on MediaWiki.r100497. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100497#c25415 Commit summary: Move styles in gadgets to the top of pages to avoid flash of unstyled content. Those styles should be loaded after site and user styles to keep B/C.

[MediaWiki-CodeReview] [MediaWiki r100497]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Liangent changed the status of MediaWiki.r100497. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100497 Commit summary: Move styles in gadgets to the top of pages to avoid flash of unstyled content. Those styles should be loaded after site

[Wikitech-l] Bug 31469

2011-11-03 Thread John
I submitted https://bugzilla.wikimedia.org/show_bug.cgi?id=31469 when 1.18 was rolled out. Is there any way that we can get this issue fixed for the 1.18 tarball? ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org

[MediaWiki-CodeReview] [MediaWiki r96616]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Platonides changed the status of MediaWiki.r96616. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96616 Commit summary: uniform comment style, fix a few space issues, address couple issues from comments on r95272

[MediaWiki-CodeReview] [MediaWiki r101778]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Awjrichards changed the status of MediaWiki.r101778. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101778 Commit summary: Had to revert this, because it both breaks GC non-ajax-based CC forms, and will throw up a Thank You page whenever

[MediaWiki-CodeReview] [MediaWiki r101781]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Awjrichards changed the status of MediaWiki.r101781. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101781 Commit summary: follow-up to r101764 and r101576, fixing bogus call to $data ___

[MediaWiki-CodeReview] [MediaWiki r97178]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Platonides changed the status of MediaWiki.r97178. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97178 Commit summary: throw exception if rename of output file fails ___ MediaWiki-CodeReview

Re: [Wikitech-l] Bug 31469

2011-11-03 Thread Brion Vibber
On Thu, Nov 3, 2011 at 9:20 AM, John phoenixoverr...@gmail.com wrote: I submitted https://bugzilla.wikimedia.org/show_bug.cgi?id=31469 when 1.18 was rolled out. Is there any way that we can get this issue fixed for the 1.18 tarball? TL;DR summary: messages expanded during

[MediaWiki-CodeReview] [MediaWiki r101802]: New comment added

2011-11-03 Thread MediaWiki Mail
User Bawolff posted a comment on MediaWiki.r101802. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101802#c25416 Commit summary: (bug 31944). As a work around for bug 31944, don't extract tiff:YCbCrSubSampling from XMP. Several files have wrong type for that property, XMPReader

[MediaWiki-CodeReview] [MediaWiki r99477]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Platonides changed the status of MediaWiki.r99477. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99477 Commit summary: (bug 31588, sort of) Jpeg metadata code wasn't handling padding bytes properly. Per the spec, segments can have arbitrary

[MediaWiki-CodeReview] [MediaWiki r101767]: New comment added, and revision status changed

2011-11-03 Thread MediaWiki Mail
User Platonides changed the status of MediaWiki.r101767. Old Status: new New Status: ok User Platonides also posted a comment on MediaWiki.r101767. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101767#c25417 Commit summary: Address fixme on r101606, should also call from $this

[MediaWiki-CodeReview] [MediaWiki r101606]: New comment added

2011-11-03 Thread MediaWiki Mail
User Platonides posted a comment on MediaWiki.r101606. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101606#c25418 Commit summary: corrections for fixme in r96486 Comment: They were separate issues. First, the wrong call. Second, I proposed making setup7zCommand() as static

[MediaWiki-CodeReview] [MediaWiki r101786]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Awjrichards changed the status of MediaWiki.r101786. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101786 Commit summary: Cleans up all the cache functions that were all supposed to accomplish the same thing (finding out if we're caching),

[MediaWiki-CodeReview] [MediaWiki r101767]: New comment added

2011-11-03 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r101767. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101767#c25419 Commit summary: Address fixme on r101606, should also call from $this Comment: It's not used outside of this class, so I'm not sure why it needs to be static?

[MediaWiki-CodeReview] [MediaWiki r101830]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r101830. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101830 Commit summary: Adding my USERINFO file. ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r101832]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User ^demon changed the status of MediaWiki.r101832. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101832 Commit summary: w/s fixup ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r101787]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Awjrichards changed the status of MediaWiki.r101787. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101787 Commit summary: way smarter way to handle the failure messages from GlobalCollect ___

[MediaWiki-CodeReview] [MediaWiki r101788]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Awjrichards changed the status of MediaWiki.r101788. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101788 Commit summary: Adding all known missing interface messages ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r101789]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Awjrichards changed the status of MediaWiki.r101789. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101789 Commit summary: Adding qqq messages to the newly added messages ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r101791]: New comment added, and revision status changed

2011-11-03 Thread MediaWiki Mail
User Awjrichards changed the status of MediaWiki.r101791. Old Status: new New Status: fixme User Awjrichards also posted a comment on MediaWiki.r101791. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101791#c25420 Commit summary: essage=Adding two more messages, from the hub on

[MediaWiki-CodeReview] [MediaWiki r101798]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Awjrichards changed the status of MediaWiki.r101798. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101798 Commit summary: fix syntax errors ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r101807]: New comment added

2011-11-03 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r101807. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101807#c25421 Commit summary: man page help pages generation Tweaked mwdocgen.php to let us generates man pages. They will be saved to ./docs/man so make sure to update your MANPATH

[MediaWiki-CodeReview] [MediaWiki r101814]: New comment added

2011-11-03 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r101814. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101814#c25422 Commit summary: output rendered thumbnail once form is submitted We probably want to force thumbnail rendering unconditionally. For some reason the File::RENDER_NOW

[MediaWiki-CodeReview] [MediaWiki r101745]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r101745. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101745 Commit summary: [JSTesting] fix require_once path for testswarm-mw-fetcher.php * When executing in shell from a different directory, path is

[MediaWiki-CodeReview] [MediaWiki r101838]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Awjrichards changed the status of MediaWiki.r101838. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101838 Commit summary: Fix image svn:mime-type ___ MediaWiki-CodeReview mailing list

Re: [Wikitech-l] Bug 31469

2011-11-03 Thread Niklas Laxström
On 3 November 2011 18:29, Brion Vibber br...@pobox.com wrote: On Thu, Nov 3, 2011 at 9:20 AM, John phoenixoverr...@gmail.com wrote: I submitted https://bugzilla.wikimedia.org/show_bug.cgi?id=31469 when 1.18 was rolled out. Is there any way that we can get this issue fixed for the 1.18

Re: [Wikitech-l] Wikipedia CAPTCHA repair

2011-11-03 Thread Platonides
Neil Harris wrote: Would anyone be interested in taking a look at the code and some sample output? -- Neil Sure. Explaining so much but providing no sample isn't too useful, as you're left in the theorical world. PS: if people will start making new captcha generators, note that -other

[MediaWiki-CodeReview] [MediaWiki r101744]: New comment added

2011-11-03 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r101744. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101744#c25423 Commit summary: [JSTesting] partial rewrite of TestSwarmMWFetcher * Before rewrite (should've been a separate commit) -- Removing savedPath/chdir code (unused). We

[MediaWiki-CodeReview] [MediaWiki r101846]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Awjrichards changed the status of MediaWiki.r101846. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101846 Commit summary: enabling canada form, updating for new stuff ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r101744]: New comment added, and revision status changed

2011-11-03 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r101744. Old Status: new New Status: deferred User Hashar also posted a comment on MediaWiki.r101744. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101744#c25424 Commit summary: [JSTesting] partial rewrite of TestSwarmMWFetcher *

[MediaWiki-CodeReview] [MediaWiki r101750]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r101750. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101750 Commit summary: [JSTesting] fix function documentation * Follows-up r101744 ___

[MediaWiki-CodeReview] [MediaWiki r101754]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r101754. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101754 Commit summary: [JSTesting] TestSwarmMWFetcher * rm debug test in TestSwarmMWFetcher::getNextFollowingRevId * implement stub

[MediaWiki-CodeReview] [MediaWiki r97115]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Kaldari changed the status of MediaWiki.r97115. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97115 Commit summary: Removing GC's ability to send credit card info ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r101478]: New comment added

2011-11-03 Thread MediaWiki Mail
User Duplicatebug posted a comment on MediaWiki.r101478. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101478#c25425 Commit summary: bug 32086 Special:Permanentlink require a parameter When Special:Permanentlink was not given any parameter it assumed oldid=0 and redirected to

[Wikitech-l] Removed user agent-sniffing client-* classes from html

2011-11-03 Thread Brion Vibber
Per https://bugzilla.wikimedia.org/show_bug.cgi?id=32183 ... In r101860 I've removed most of the client-* classes from the html that were added based on user-agent sniffing. Sniffing UA strings is a fragile practice which should be strongly discouraged in favor of checking for the actual features

[MediaWiki-CodeReview] [MediaWiki r89405]: New comment added, and revision status changed

2011-11-03 Thread MediaWiki Mail
User IAlex changed the status of MediaWiki.r89405. Old Status: fixme New Status: new User IAlex also posted a comment on MediaWiki.r89405. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89405#c25426 Commit summary: Deprecated wfGetAgent(), use $wgRequest-getHeader( 'User-Agent'

[MediaWiki-CodeReview] [MediaWiki r89405]: New comment added

2011-11-03 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r89405. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89405#c25427 Commit summary: Deprecated wfGetAgent(), use $wgRequest-getHeader( 'User-Agent' ) instead Comment: Yeah, I forgot the extends relationship there.

[MediaWiki-CodeReview] [MediaWiki r101859]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r101859. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101859 Commit summary: Follow-up r101858: forgot to commit AutoLoader.php ___

[MediaWiki-CodeReview] [Wikimedia r697]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Pgehres (WMF) changed the status of Wikimedia.r697. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/697 Commit summary: Modify Live LPs view to include Campaign ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r101861]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r101861. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101861 Commit summary: Fix for r101858: forgot the override those methods ___

[MediaWiki-CodeReview] [MediaWiki r101858]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r101858. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101858 Commit summary: Per Aaron, fix for r89405: introduced DerivativeRequest to allow to override the request parameters, but not

[MediaWiki-CodeReview] [Wikimedia r699]: Revision status changed

2011-11-03 Thread MediaWiki Mail
User Pgehres (WMF) changed the status of Wikimedia.r699. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/699 Commit summary: order campaigns greatest to least by earliest donation ___ MediaWiki-CodeReview

  1   2   3   >