Re: [Wikitech-l] Min php version
On Tue, Jul 21, 2015 at 1:22 PM, Gergo Tisza gti...@wikimedia.org wrote: On Tue, Jul 21, 2015 at 11:27 AM, Tyler Romeo tylerro...@gmail.com wrote: One thing I forgot to mention: while you're considering Debian and Ubuntu support, make sure to also take into account MediaWiki support. Even if we upgrade our minimum PHP version now, older versions of MediaWiki with the 5.3 requirement will still be supported and receive security updates. So the only difference will be that people running Debian oldstable will be locked into our older version and not be able to upgrade to bleeding edge MediaWiki, which they probably won't do anyway considering they haven't even upgraded their Debian. :P Specifically, 1.23, which is the current LTS (long-term support) release, is supported until May 2017 (so that covers Debian/Ubuntu and almost covers RedHat, but that one provides PHP 5.5 anyway). The next LTS is due spring 2016 and will be supported until spring 2019 and I don't think we want to get stuck on PHP 5.3 with that one. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l I don't have a whole lot to add to this argument, but the above statement rings very true to me. I think it would be a big misstep to continue supporting 5.3 until 2019. Erik B. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] Changes require Verified+2 to be merged by CI
Hello, I have upgraded Zuul this morning which has a slight regression. To be considered for merging, Zuul require the change to have a Verified +2. In most case that is not a problem since the tests ran and voted V+2 already. But there is a few other cases where Verified is 0 or -1. The workaround is thus to manually vote Verified +2 in addition to Code-Review +2. You might have to remove the prior CR+2 to have the change properly recognized. The task is: https://phabricator.wikimedia.org/T106531 Will give it a shot tomorrow. -- Antoine hashar Musso ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Geolocation and WikiVoyage
Hi, On Wed, Jul 22, 2015 at 5:10 PM, Sylvain Arnouts sylvain.arno...@wanadoo.fr wrote: Actually, it's the same for other languages, but the API has a very specific way to manage languages in request. To have the datas in different languages, we have to call the langlinks props in the url, and then do llprop=url to have the url of the page for each languages. This is the final request I send to the API : $wikivoyageRequest = https://en.wikivoyage.org/w/api.php?action=queryformat=json; //Base .prop=coordinates|info|langlinks//Props list .inprop=url //Properties dedicated to url .llprop=url//Properties dedicated to langlinks .generator=geosearchggscoord=$user_latitude|$user_longitudeggsradius=1ggslimit=50; //Properties dedicated to geosearch The answer contains every link for every language, so I guess it solves my problem. Well, that depends on what exactly is your problem. The query you have shown here is find all articles within the radius on the English Wikivoyage, and give me the versions of those English articles in other languages, if they exist. However, if you try e.g. https://en.wikivoyage.org/w/api.php?action=queryprop=coordinates|infoinprop=urlgenerator=geosearchggscoord=46.016667|-1.175ggsradius=1ggslimit=50ggsradius=1ggslimit=50, you'll find nothing, even though there is an article about Île d'Aix (lying on those coordinates) on the French and German Wikivoyages, which you _will_ find using https://de.wikivoyage.org/w/api.php?action=queryprop=coordinates|infoinprop=urlgenerator=geosearchggscoord=46.016667|-1.175ggsradius=1ggslimit=50ggsradius=1ggslimit=50 (and you would find it also on French Wikivoyage, if it had the {{#coordinates}} I wrote about in the previous message). In other words, you are searching _only_ within English Wikivoyage articles with the query you posted above. Whether that is enough for you, I cannot decide. HTH, -- [[cs:User:Mormegil | Petr Kadlec]] ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Geolocation and WikiVoyage
Thanks for your help ! Actually, it's the same for other languages, but the API has a very specific way to manage languages in request. To have the datas in different languages, we have to call the langlinks props in the url, and then do llprop=url to have the url of the page for each languages. This is the final request I send to the API : $wikivoyageRequest = https://en.wikivoyage.org/w/api.php?action=queryformat=json; //Base .prop=coordinates|info|langlinks//Props list .inprop=url //Properties dedicated to url .llprop=url//Properties dedicated to langlinks .generator=geosearchggscoord=$user_latitude|$user_longitudeggsradius=1ggslimit=50; //Properties dedicated to geosearch The answer contains every link for every language, so I guess it solves my problem. Thanks a lot for helping me, I'll show you my project when it's over ! :) Le 22/07/2015 15:44, Petr Kadlec a écrit : On Wed, Jul 22, 2015 at 9:09 AM, Sylvain Arnouts sylvain.arno...@wanadoo.fr wrote: But I still have some issues. I'm trying to use it in different languages. It works in english, but I'd like to have results from the french version of Wikivoyage. I don't know why, it doesn't work by calling https://fr.wikivoyage.org/w/api.php? ... same request. I've no answer, even if the page actually exists. For this feature to work, the page obviously needs to know its coordinates. The English page does https://en.wikivoyage.org/w/api.php?action=queryprop=coordinatestitles=Lille while the French page does not https://fr.wikivoyage.org/w/api.php?action=queryprop=coordinatestitles=Lille. The coordinates are stored into the page properties using the {{#coordinates:}} special function, see https://www.mediawiki.org/wiki/Extension:GeoData#Usage. On English Wiktionary, this function is called using the {{Geo}} template (see https://en.wikivoyage.org/w/index.php?title=Template:Geoaction=edit). On the French Wiktionary, the function should probably be called in {{Info Ville}} or {{Geo}}, I guess. HTH, -- [[cs:User:Mormegil | Petr Kadlec]] ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] Phabricator board: reading-admin
Hi all - you've probably seen the reading-web, android, and ios related boards in Phabricator, but I wanted to share another with you: https://phabricator.wikimedia.org/tag/reading-admin/ This is a place the Reading management team adds and tracks more manager oriented tasks. As tasks get moved to Done, we will in the future probably actually want to check into whether they should be moved farther left in the board to be repeated / re-reviewed or figure out some appropriate lightweight workflow for such things. -Adam ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Adding extensions under packagist's mediawiki vendor
On Wed, Jul 22, 2015 at 7:13 AM Federico Leva (Nemo) nemow...@gmail.com wrote: Gerrit is too unpredictable for users: https://phabricator.wikimedia.org/T86476#1462980 . It's probably easier and more functional to create some mediawiki-users vendor on packagist and let any MediaWiki sysadmin (not developer) join to add the packages they need for whatever reason. Forcing people to use Gerrit is quite possibly a violation of the Geneva Convention. -Chad ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Changes require Verified+2 to be merged by CI
On 22 Jul 2015, at 09:28, Antoine Musso hashar+...@free.fr wrote: Hello, I have upgraded Zuul this morning which has a slight regression. To be considered for merging, Zuul require the change to have a Verified +2. In most case that is not a problem since the tests ran and voted V+2 already. But there is a few other cases where Verified is 0 or -1. This primarily affects cases where: * Someone CR+2's a change that is so new it doesn't have the V-vote from jenkins-bot yet. * Someone CR+2's a change that was previously failing but is now fixed and jenkins is still running the build. So this breaks cases where someone does a provisional CR+2 with the concurrent dependency that Jenkins will pass. The workaround is thus to manually vote Verified +2 in addition to Code-Review +2. You might have to remove the prior CR+2 to have the change properly recognized. Please don't (and in many repos, people can't). This bypasses Jenkins and causes other inconsistencies. Instead wait until Jenkins is done and then CR+2 it. -- Krinkle ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] MW support for Composer equivalent for JavaScript packages
Hey, I just wanted to check in about the status of enabling JavaScript package management usage in MediaWiki. I am basically talking about an equivalent for JS to what we have with Composer for PHP. Real-world example: The data-values/value-view package[0] is defining jquery.event.special.eachchange.js: ValueView/lib/jquery.event/jquery.event.special.eachchange.js Now, recently I needed the same functionality in one of my extensions, so I just copied it over. [1] I know that this is the worst way one could do this, but as far as I can see we don't have that much of a choice right now. Here are the alternative options I can see: Moving jquery.event.special.eachchange.js out of the data-values/value-view package into its own WMDE/jquery-eachchange package... 1. ... and using it in my extension via composer. + pro: two or more extensions or other packages requiring this package will still result in having only one MW-wide installation.. - con: requires MW specific code which is actually not related to the MW-independent package to feed the resource loader. - con: using Composer to manage pure JavaScript packages! Uuuh, ugly! 2. ... and having a build step in other packages using the package, pulling the WMDE/jquery-eachchange somewhere into the file structure of the packages/extensions using it. + pro: don't need to abuse composer, we can use npm, Bower or any other arbitrary JS package manager here. - con: got to tell resource loader somehow... (didn't think so much about that yet) - con: if more than one extensions or other packages require this package we still end up with the same code twice or more often in one MW installation. 3. Combining 1 and 2: Start with 2, using a JS package manager. Then going to 1, creating a composer package and pulling the WMDE/jquery-eachchange package in via some build script. + pro: The two pros from 1 + 2 + pro: ^^ - con: still got to tell resource loader somehow... - con: Overhead; We now create two packages where the Composer one is just a bridge to the MW-world, still polluting packagist.org. Still kind of ugly and more effort for publishing a package and therefore potentially scaring programmers away from doing so since they've got better things to do than doing work that could be automated. I have not seen Approach 2 and 3 yet. Though I could imagine that the VisualEditor team has used something like that. Approach 1 is the way the data-values/value-view package itself is being handled. And that package should actually be a MW independent pure JS package but right now it contains MW specific code and uses composer for distribution! There is still another option but that had to be properly implemented: 4. Choose one native JS package manager for now and go with it (add support for others later perhaps). Integrate it properly with MW (resource loader to begin with), document how to use it and finally distribute JS code coming from the MW world but useful for other projects in a way where it can actually be used in a non-MW context. This has already been bugging me when working on Wikidata. Now I'd like to reuse some of the code I have written there without spending hours and hours with option 3 because there should be support for option 4 rather sooner or later. So I am wondering; Does anyone have any thoughts, any alternatives perhaps or is there any roadmap on anything like the option 4 that I have shown? Cheers, Daniel [0]: https://packagist.org/packages/data-values/value-view [1]: https://github.com/DanweDE/mediawiki-ext-UserBitcoinAddresses/blob/master/resources/vendor/jquery.event.special.eachchange.js ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Wikipedia iOS app moving to GH
I have no problem with that, as long as everyone with +2 keeps his access This should already be the case for the main iOS engineers, but I've made a ticket https://phabricator.wikimedia.org/T106547 to make sure people don't slip through the cracks. Oh, and when it syncs with phabricator tickets Phabricator ticket sync is something we're sad to lose, but it's part of the trade-off we're making. That said, it was only slightly beneficial as we relied more on cards being in a Code Review column (w/ a WIP limit) than looking at the gerrit updates on the cards themselves (which aren't visible from the board view). Not that GH will make this any easier, but we're not losing too much here, IMHO. On Wed, Jul 22, 2015 at 8:01 AM, Derk-Jan Hartman d.j.hartman+wmf...@gmail.com wrote: I have no problem with that, as long as everyone with +2 keeps his access and someone manages developer account additions and removals. Oh, and when it syncs with phabricator tickets DJ On Wed, Jul 22, 2015 at 1:39 PM, Petr Bena benap...@gmail.com wrote: Good job, you aren't the only one. Huggle team is using it for quite some time. To be honest I still feel that github is far superior to our gerrit installation and don't really understand why we don't use it for other projects too. The GitHub's pull requests are more compliant with original git philosophy of Linus, see this video: https://www.youtube.com/watch?v=4XpnKHJAok8 and would be sufficient replacement to our current git-review mechanism, which is very complex and unfriendly to new developers who probably find it very difficult to use. On Wed, Jul 22, 2015 at 12:40 PM, Brian Gerstle bgers...@wikimedia.org wrote: Hey everyone, I'm writing with plans for the Wikimedia iOS engineering team to move its workflow to GitHub with Travis CI, much like RESTbase. The Wikimedia iOS engineers have been maintaining their own CI and build server and using Gerrit for code review. The more time efficient and commonplace approach for open source iOS software development leans heavily on GitHub with Travis CI instead (e.g., WordPress[0][1] and Firefox[2][3]). By using GitHub with Travis CI, the team believes it will work faster, improve testing, grow developer confidence in making code changes, and, most importantly, deploy fewer bugs to production. For builds requiring sensitive information (e.g., prod certs), will continue to run on WMF's Mac Mini. As is done for Android, when betas are pushed, the team will notify mobile-l. Feel free to reply or email me directly with any questions or comments. Regards, Brian 0: https://github.com/wordpress-mobile/WordPress-iOS 1: https://travis-ci.org/wordpress-mobile/WordPress-iOS 2: https://github.com/mozilla/firefox-ios 3: https://travis-ci.org/mozilla/firefox-ios -- EN Wikipedia user page: https://en.wikipedia.org/wiki/User:Brian.gerstle IRC: bgerstle ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l -- EN Wikipedia user page: https://en.wikipedia.org/wiki/User:Brian.gerstle IRC: bgerstle ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] FYI: HTMLForm is now available in OOUI format
Great work! I have noticed that the ooui HTMLForm format is also not supporting a form field's hide-if expressions yet. Cheers, Daniel On 22 July 2015 at 16:06, Florian Schmidt florian.schmidt.wel...@t-online.de wrote: Yay :D Sent from my HTC - Reply message - From: Bartosz Dziewoński matma@gmail.com To: Wikimedia developers wikitech-l@lists.wikimedia.org Subject: [Wikitech-l] FYI: HTMLForm is now available in OOUI format Date: Wed, Jul 22, 2015 15:45 It took a while, but most of the issues are ironed out now. OOUI still doesn't support subsections, as that would require some refactoring of gnarly old code. Everything else should work well enough. -- Bartosz Dziewoński ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Wikipedia iOS app moving to GH
* CR fragmentation * CI fragmentation * more reliance on proprietary software Il 22/07/2015 12:40, Brian Gerstle ha scritto: Hey everyone, I'm writing with plans for the Wikimedia iOS engineering team to move its workflow to GitHub with Travis CI, much like RESTbase. The Wikimedia iOS engineers have been maintaining their own CI and build server and using Gerrit for code review. The more time efficient and commonplace approach for open source iOS software development leans heavily on GitHub with Travis CI instead (e.g., WordPress[0][1] and Firefox[2][3]). By using GitHub with Travis CI, the team believes it will work faster, improve testing, grow developer confidence in making code changes, and, most importantly, deploy fewer bugs to production. For builds requiring sensitive information (e.g., prod certs), will continue to run on WMF's Mac Mini. As is done for Android, when betas are pushed, the team will notify mobile-l. Feel free to reply or email me directly with any questions or comments. Regards, Brian 0: https://github.com/wordpress-mobile/WordPress-iOS 1: https://travis-ci.org/wordpress-mobile/WordPress-iOS 2: https://github.com/mozilla/firefox-ios 3: https://travis-ci.org/mozilla/firefox-ios ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] Fwd: Wikipedia iOS app moving to GH
sorry, didn't hit reply-all. (these lists aren't a subset of each other, are they?) Also, we're losing IRC notifications, but that should be easy enough to add back via fastlane. -- Forwarded message -- From: Brian Gerstle bgers...@wikimedia.org Date: Wed, Jul 22, 2015 at 12:59 PM Subject: Re: [Wikitech-l] Wikipedia iOS app moving to GH To: Wikimedia developers wikitech-l@lists.wikimedia.org I have no problem with that, as long as everyone with +2 keeps his access This should already be the case for the main iOS engineers, but I've made a ticket https://phabricator.wikimedia.org/T106547 to make sure people don't slip through the cracks. Oh, and when it syncs with phabricator tickets Phabricator ticket sync is something we're sad to lose, but it's part of the trade-off we're making. That said, it was only slightly beneficial as we relied more on cards being in a Code Review column (w/ a WIP limit) than looking at the gerrit updates on the cards themselves (which aren't visible from the board view). Not that GH will make this any easier, but we're not losing too much here, IMHO. On Wed, Jul 22, 2015 at 8:01 AM, Derk-Jan Hartman d.j.hartman+wmf...@gmail.com wrote: I have no problem with that, as long as everyone with +2 keeps his access and someone manages developer account additions and removals. Oh, and when it syncs with phabricator tickets DJ On Wed, Jul 22, 2015 at 1:39 PM, Petr Bena benap...@gmail.com wrote: Good job, you aren't the only one. Huggle team is using it for quite some time. To be honest I still feel that github is far superior to our gerrit installation and don't really understand why we don't use it for other projects too. The GitHub's pull requests are more compliant with original git philosophy of Linus, see this video: https://www.youtube.com/watch?v=4XpnKHJAok8 and would be sufficient replacement to our current git-review mechanism, which is very complex and unfriendly to new developers who probably find it very difficult to use. On Wed, Jul 22, 2015 at 12:40 PM, Brian Gerstle bgers...@wikimedia.org wrote: Hey everyone, I'm writing with plans for the Wikimedia iOS engineering team to move its workflow to GitHub with Travis CI, much like RESTbase. The Wikimedia iOS engineers have been maintaining their own CI and build server and using Gerrit for code review. The more time efficient and commonplace approach for open source iOS software development leans heavily on GitHub with Travis CI instead (e.g., WordPress[0][1] and Firefox[2][3]). By using GitHub with Travis CI, the team believes it will work faster, improve testing, grow developer confidence in making code changes, and, most importantly, deploy fewer bugs to production. For builds requiring sensitive information (e.g., prod certs), will continue to run on WMF's Mac Mini. As is done for Android, when betas are pushed, the team will notify mobile-l. Feel free to reply or email me directly with any questions or comments. Regards, Brian 0: https://github.com/wordpress-mobile/WordPress-iOS 1: https://travis-ci.org/wordpress-mobile/WordPress-iOS 2: https://github.com/mozilla/firefox-ios 3: https://travis-ci.org/mozilla/firefox-ios -- EN Wikipedia user page: https://en.wikipedia.org/wiki/User:Brian.gerstle IRC: bgerstle ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l -- EN Wikipedia user page: https://en.wikipedia.org/wiki/User:Brian.gerstle IRC: bgerstle -- EN Wikipedia user page: https://en.wikipedia.org/wiki/User:Brian.gerstle IRC: bgerstle ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Geolocation and WikiVoyage
Hi. You're right, I didn't think about it. So to have all result, I have to call all API on each Wikivoyage version ? Thank you. Le 22/07/2015 17:51, Petr Kadlec a écrit : Hi, On Wed, Jul 22, 2015 at 5:10 PM, Sylvain Arnouts sylvain.arno...@wanadoo.fr wrote: Actually, it's the same for other languages, but the API has a very specific way to manage languages in request. To have the datas in different languages, we have to call the langlinks props in the url, and then do llprop=url to have the url of the page for each languages. This is the final request I send to the API : $wikivoyageRequest = https://en.wikivoyage.org/w/api.php?action=queryformat=json; //Base .prop=coordinates|info|langlinks//Props list .inprop=url //Properties dedicated to url .llprop=url//Properties dedicated to langlinks .generator=geosearchggscoord=$user_latitude|$user_longitudeggsradius=1ggslimit=50; //Properties dedicated to geosearch The answer contains every link for every language, so I guess it solves my problem. Well, that depends on what exactly is your problem. The query you have shown here is find all articles within the radius on the English Wikivoyage, and give me the versions of those English articles in other languages, if they exist. However, if you try e.g. https://en.wikivoyage.org/w/api.php?action=queryprop=coordinates|infoinprop=urlgenerator=geosearchggscoord=46.016667|-1.175ggsradius=1ggslimit=50ggsradius=1ggslimit=50, you'll find nothing, even though there is an article about Île d'Aix (lying on those coordinates) on the French and German Wikivoyages, which you _will_ find using https://de.wikivoyage.org/w/api.php?action=queryprop=coordinates|infoinprop=urlgenerator=geosearchggscoord=46.016667|-1.175ggsradius=1ggslimit=50ggsradius=1ggslimit=50 (and you would find it also on French Wikivoyage, if it had the {{#coordinates}} I wrote about in the previous message). In other words, you are searching _only_ within English Wikivoyage articles with the query you posted above. Whether that is enough for you, I cannot decide. HTH, -- [[cs:User:Mormegil | Petr Kadlec]] ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Min php version
On 20 Jul 2015, at 22:42, Legoktm legoktm.wikipe...@gmail.com wrote: OTOH, if we never bump our version requirements, there's less incentive for hosting providers to upgrade their PHP. [1] has some interesting arguments regarding this. [1] http://blog.ircmaxell.com/2014/12/on-php-version-requirements.html Indeed. Providers that don't already provide newer PHP options, will certainly start doing so when major software requires it. On 21 Jul 2015, at 07:12, bawolff bawolff...@gmail.com wrote: https://wikiapiary.com/w/index.php?title=Special:SearchByPropertylimit=500offset=0property=Has+PHP+Versionvalue=5.3.3 is also something to keep in mind Yes, but also keep in mind that many of those wikis likely run in hosting environments that already support newer PHP versions. But customers won't change their settings until they have to. And providers can't change customers proactively without risking site breakage or damaging customer relations. I had the same with my third-party wikis. Until recently they ran on PHP 5.3. Then at some point I realised my provider had a simple Select PHP Version page in the control panel. I switched them all to PHP 5.6 that day and also enabled opcache. Site performance improved greatly. On 19 Jul 2015, at 07:15, Bryan Davis bd...@wikimedia.org wrote: Some WMF production hosts are still on PHP 5.3.10 so as Tim pointed out last spring [0] we shouldn't drop 5.3 support until after the entirety of the WMF server fleet are all switched over to HHVM or at least a newer version of PHP5. [..] [0]: http://www.gossamer-threads.com/lists/wiki/wikitech/436441#436441 Yeah, in case of Wikimedia master is near-immediate production so let's post-pone this until right after Wikimedia's migration is complete. Third parties can stick to using the LTS or the current stable version as needed for upto several years more without issue. -- Krinkle ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Min php version
side note: How come php 5.3.3 support broken accidentally? Isn't Jenkins script validates compatibility with the min php? :) On Wed, Jul 22, 2015 at 9:36 PM, Krinkle krinklem...@gmail.com wrote: On 20 Jul 2015, at 22:42, Legoktm legoktm.wikipe...@gmail.com wrote: OTOH, if we never bump our version requirements, there's less incentive for hosting providers to upgrade their PHP. [1] has some interesting arguments regarding this. [1] http://blog.ircmaxell.com/2014/12/on-php-version-requirements.html Indeed. Providers that don't already provide newer PHP options, will certainly start doing so when major software requires it. On 21 Jul 2015, at 07:12, bawolff bawolff...@gmail.com wrote: https://wikiapiary.com/w/index.php?title=Special:SearchByPropertylimit=500offset=0property=Has+PHP+Versionvalue=5.3.3 is also something to keep in mind Yes, but also keep in mind that many of those wikis likely run in hosting environments that already support newer PHP versions. But customers won't change their settings until they have to. And providers can't change customers proactively without risking site breakage or damaging customer relations. I had the same with my third-party wikis. Until recently they ran on PHP 5.3. Then at some point I realised my provider had a simple Select PHP Version page in the control panel. I switched them all to PHP 5.6 that day and also enabled opcache. Site performance improved greatly. On 19 Jul 2015, at 07:15, Bryan Davis bd...@wikimedia.org wrote: Some WMF production hosts are still on PHP 5.3.10 so as Tim pointed out last spring [0] we shouldn't drop 5.3 support until after the entirety of the WMF server fleet are all switched over to HHVM or at least a newer version of PHP5. [..] [0]: http://www.gossamer-threads.com/lists/wiki/wikitech/436441#436441 Yeah, in case of Wikimedia master is near-immediate production so let's post-pone this until right after Wikimedia's migration is complete. Third parties can stick to using the LTS or the current stable version as needed for upto several years more without issue. -- Krinkle ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Removal of mobile.wikipedia.org and wap.wikipedia.org in support of browser HSTS preload
Is this good to go? On Thu, Jul 16, 2015 at 3:03 PM, Adam Baso ab...@wikimedia.org wrote: I posted the query results at https://phabricator.wikimedia.org/T104942#1458981. I _believe_ there wasn't significant skew on particular days that would taint the initially reported number, although there were small variations as expected. On Thu, Jul 16, 2015 at 9:33 AM, Adam Baso ab...@wikimedia.org wrote: No problem, I'll run some extra queries. On Thu, Jul 16, 2015 at 9:04 AM, John phoenixoverr...@gmail.com wrote: 1 day isnt much to base a decision on, especially on a global level. Normally I would use a sample set of at least a week, to a month of values. Sorry if I seem like im being a pain, I have just seen a lot of bad choices made based off limited data sets. With a wider data set we might find that Tuesdays are the slowest day for traffic, or some other factor that skews the data. Ensuring data validation is important when making these types of calls based off the working dataset. On Thu, Jul 16, 2015 at 11:05 AM, Toby Negrin tneg...@wikimedia.org wrote: Hi John -- What do you think would be a better sample? My feeling is that a 24 hour period captures global usage and we're currently at about .01% of page views come to these domains is a pretty good indicator. Keep in mind we're doing this for a legitimate technical reason and not arbitrarily. Looking at the UAs is a good idea and we will do that. thanks, -Toby On Thu, Jul 16, 2015 at 6:55 AM, John phoenixoverr...@gmail.com wrote: Can we look at a wider sample? using a single day as judgement factor is a bad idea. However if the data supports your position I dont see any serious problems. You might want to take a look at either the UA's or refering sources to see if there is a primary source for the traffic and mitigate that. On Thu, Jul 16, 2015 at 9:03 AM, Adam Baso ab...@wikimedia.org wrote: Looks like the user pageviews for wap.wikipedia.org and mobile.wikipedia.org subdomains are approximately 0.02% of the size of pageviews for m.wikipedia.org subdomains based on a recent one day check. hive select count(*) from wmf.webrequest where year = 2015 and month = 7 and day = 14 and access_method = 'mobile web' and (uri_host like '%.wap.wikipedia.org' OR uri_host like '%. mobile.wikipedia.org') and is_pageview = true and agent_type = 'user'; 35,543 hive select count(*) from wmf.webrequest where year = 2015 and month = 7 and day = 14 and access_method = 'mobile web' and uri_host like '%.m.wikipedia.org' and is_pageview = true and agent_type = 'user'; 202,024,891 On Thu, Jul 16, 2015 at 5:41 AM, John phoenixoverr...@gmail.com wrote: ... Have we done any analysis on usage of those subdomains? On Thu, Jul 16, 2015 at 8:34 AM, Adam Baso ab...@wikimedia.org wrote: There's a ticket for removing mobile.wikipedia.org and wap.wikipedia.org domains/subdomains, which are legacy domain names superceded by m.wikipedia.org and its subdomains. https://phabricator.wikimedia.org/T104942 The rationale for the removal of these legacy domain names is to help support HSTS preloading in browsers with the existing TLS SAN cert. After review of the ticket, can anyone think of a compelling reason to keep those old domain names? I'm going to open a separate thread on mobile-l about this given this is more mobile-targeted, yet some people only operate on one of wikitech-l or mobile-l. -Adam ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Fwd: Wikipedia iOS app moving to GH
They're two separate lists. I believe most Reading engineers are on both mobile-l and wikitech-l. Couldn't say so much for other people. On Wed, Jul 22, 2015 at 10:16 AM, Brian Gerstle bgers...@wikimedia.org wrote: sorry, didn't hit reply-all. (these lists aren't a subset of each other, are they?) Also, we're losing IRC notifications, but that should be easy enough to add back via fastlane. -- Forwarded message -- From: Brian Gerstle bgers...@wikimedia.org Date: Wed, Jul 22, 2015 at 12:59 PM Subject: Re: [Wikitech-l] Wikipedia iOS app moving to GH To: Wikimedia developers wikitech-l@lists.wikimedia.org I have no problem with that, as long as everyone with +2 keeps his access This should already be the case for the main iOS engineers, but I've made a ticket https://phabricator.wikimedia.org/T106547 to make sure people don't slip through the cracks. Oh, and when it syncs with phabricator tickets Phabricator ticket sync is something we're sad to lose, but it's part of the trade-off we're making. That said, it was only slightly beneficial as we relied more on cards being in a Code Review column (w/ a WIP limit) than looking at the gerrit updates on the cards themselves (which aren't visible from the board view). Not that GH will make this any easier, but we're not losing too much here, IMHO. On Wed, Jul 22, 2015 at 8:01 AM, Derk-Jan Hartman d.j.hartman+wmf...@gmail.com wrote: I have no problem with that, as long as everyone with +2 keeps his access and someone manages developer account additions and removals. Oh, and when it syncs with phabricator tickets DJ On Wed, Jul 22, 2015 at 1:39 PM, Petr Bena benap...@gmail.com wrote: Good job, you aren't the only one. Huggle team is using it for quite some time. To be honest I still feel that github is far superior to our gerrit installation and don't really understand why we don't use it for other projects too. The GitHub's pull requests are more compliant with original git philosophy of Linus, see this video: https://www.youtube.com/watch?v=4XpnKHJAok8 and would be sufficient replacement to our current git-review mechanism, which is very complex and unfriendly to new developers who probably find it very difficult to use. On Wed, Jul 22, 2015 at 12:40 PM, Brian Gerstle bgers...@wikimedia.org wrote: Hey everyone, I'm writing with plans for the Wikimedia iOS engineering team to move its workflow to GitHub with Travis CI, much like RESTbase. The Wikimedia iOS engineers have been maintaining their own CI and build server and using Gerrit for code review. The more time efficient and commonplace approach for open source iOS software development leans heavily on GitHub with Travis CI instead (e.g., WordPress[0][1] and Firefox[2][3]). By using GitHub with Travis CI, the team believes it will work faster, improve testing, grow developer confidence in making code changes, and, most importantly, deploy fewer bugs to production. For builds requiring sensitive information (e.g., prod certs), will continue to run on WMF's Mac Mini. As is done for Android, when betas are pushed, the team will notify mobile-l. Feel free to reply or email me directly with any questions or comments. Regards, Brian 0: https://github.com/wordpress-mobile/WordPress-iOS 1: https://travis-ci.org/wordpress-mobile/WordPress-iOS 2: https://github.com/mozilla/firefox-ios 3: https://travis-ci.org/mozilla/firefox-ios -- EN Wikipedia user page: https://en.wikipedia.org/wiki/User:Brian.gerstle IRC: bgerstle ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l -- EN Wikipedia user page: https://en.wikipedia.org/wiki/User:Brian.gerstle IRC: bgerstle -- EN Wikipedia user page: https://en.wikipedia.org/wiki/User:Brian.gerstle IRC: bgerstle ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] 2015-07-22 Scrum of Scrums notes
https://www.mediawiki.org/wiki/Scrum_of_scrums/2015-07-22 ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Min php version
Maybe another php bump to something like 5.3.6. I think one php 5.3 usage goes down then we should switch to something like php 5.5 or 5.6 or even php 7 if php 7 get enough popularity. On Wednesday, 22 July 2015, 21:19, Eran Rosenthal eranro...@gmail.com wrote: side note: How come php 5.3.3 support broken accidentally? Isn't Jenkins script validates compatibility with the min php? :) On Wed, Jul 22, 2015 at 9:36 PM, Krinkle krinklem...@gmail.com wrote: On 20 Jul 2015, at 22:42, Legoktm legoktm.wikipe...@gmail.com wrote: OTOH, if we never bump our version requirements, there's less incentive for hosting providers to upgrade their PHP. [1] has some interesting arguments regarding this. [1] http://blog.ircmaxell.com/2014/12/on-php-version-requirements.html Indeed. Providers that don't already provide newer PHP options, will certainly start doing so when major software requires it. On 21 Jul 2015, at 07:12, bawolff bawolff...@gmail.com wrote: https://wikiapiary.com/w/index.php?title=Special:SearchByPropertylimit=500offset=0property=Has+PHP+Versionvalue=5.3.3 is also something to keep in mind Yes, but also keep in mind that many of those wikis likely run in hosting environments that already support newer PHP versions. But customers won't change their settings until they have to. And providers can't change customers proactively without risking site breakage or damaging customer relations. I had the same with my third-party wikis. Until recently they ran on PHP 5.3. Then at some point I realised my provider had a simple Select PHP Version page in the control panel. I switched them all to PHP 5.6 that day and also enabled opcache. Site performance improved greatly. On 19 Jul 2015, at 07:15, Bryan Davis bd...@wikimedia.org wrote: Some WMF production hosts are still on PHP 5.3.10 so as Tim pointed out last spring [0] we shouldn't drop 5.3 support until after the entirety of the WMF server fleet are all switched over to HHVM or at least a newer version of PHP5. [..] [0]: http://www.gossamer-threads.com/lists/wiki/wikitech/436441#436441 Yeah, in case of Wikimedia master is near-immediate production so let's post-pone this until right after Wikimedia's migration is complete. Third parties can stick to using the LTS or the current stable version as needed for upto several years more without issue. -- Krinkle ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Adding extensions under packagist's mediawiki vendor
Thank you folks! I guess I wasn't logged in when I first tried. It works fine now [0]. Anyhow, I am with Gergo and Jeroen on the issue of code hosting and I chose to use GitHub. I also have lots of extensions on WM's facilities and won't change that in the near future but I am switching to GitHub as I am maintain more and more also non-MW related packages there and I feel like it is less troublesome even though I have also worked on Gerrit for 19 months on a daily basis when working as part of the Wikidata team. Also, some of the biggest MW extensions such as Semantic MediaWiki and Maps seem to be hosted on GitHub already and I can not see how they would lack any support from our community in terms of contributions. Cheers, Daniel [0]: https://packagist.org/packages/mediawiki/user-bitcoin-addresses On 22 July 2015 at 00:57, Bryan Davis bd...@wikimedia.org wrote: On Tue, Jul 21, 2015 at 5:42 PM, Jeroen De Dauw jeroended...@gmail.com wrote: Hey Bryan, What exactly justifies such an authoritarian need to go though some permission process setup? Exactly what problems are we currently seeing? I'm very sceptical about such an approach. Sure you can say things such as that I'd be nice for other people to have access. The reality is that most people don't care about most extensions and that a lot of them end up being unmaintained and very low quality to begin with. Telling volunteers they should go follow a process they do not want to follow and that they should use a code hosting service they do not want to use has its down sides. This was also not done in the past. You did not need approval to create a certified MediaWiki extension or something like that. As of https://github.com/composer/packagist/issues/163#issuecomment-99673878 Packagist itself has created this restriction of vendor namespaces actually indicating some level of ownership. A vendor is a supplier of a good or service. Publishing something as mediawiki/* is explicitly claiming affiliation with the MediaWiki open source project. As such it seems not unreasonable to ensue that projects claiming to be supplied by the MediaWiki community actually are indeed serviceable by that community. Note that there is no form of restriction for publishing a package that provides a MediaWiki extension or other related functionality under another namespace. I would certainly welcome an RfC discussion of the current policy and a potential replacement. From my point of view, use of the MediaWiki brand implies endorsement by the MediaWiki community and thus should only be easily available to projects that are able to be contributed to and managed by that community. If for example a serious security flaw was found in a mediawiki/foo package on Packagist the community should be empowered to fix it. Bryan -- Bryan Davis Wikimedia Foundationbd...@wikimedia.org [[m:User:BDavis_(WMF)]] Sr Software EngineerBoise, ID USA irc: bd808v:415.839.6885 x6855 ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Wikipedia iOS app moving to GH
Good job, you aren't the only one. Huggle team is using it for quite some time. To be honest I still feel that github is far superior to our gerrit installation and don't really understand why we don't use it for other projects too. The GitHub's pull requests are more compliant with original git philosophy of Linus, see this video: https://www.youtube.com/watch?v=4XpnKHJAok8 and would be sufficient replacement to our current git-review mechanism, which is very complex and unfriendly to new developers who probably find it very difficult to use. On Wed, Jul 22, 2015 at 12:40 PM, Brian Gerstle bgers...@wikimedia.org wrote: Hey everyone, I'm writing with plans for the Wikimedia iOS engineering team to move its workflow to GitHub with Travis CI, much like RESTbase. The Wikimedia iOS engineers have been maintaining their own CI and build server and using Gerrit for code review. The more time efficient and commonplace approach for open source iOS software development leans heavily on GitHub with Travis CI instead (e.g., WordPress[0][1] and Firefox[2][3]). By using GitHub with Travis CI, the team believes it will work faster, improve testing, grow developer confidence in making code changes, and, most importantly, deploy fewer bugs to production. For builds requiring sensitive information (e.g., prod certs), will continue to run on WMF's Mac Mini. As is done for Android, when betas are pushed, the team will notify mobile-l. Feel free to reply or email me directly with any questions or comments. Regards, Brian 0: https://github.com/wordpress-mobile/WordPress-iOS 1: https://travis-ci.org/wordpress-mobile/WordPress-iOS 2: https://github.com/mozilla/firefox-ios 3: https://travis-ci.org/mozilla/firefox-ios -- EN Wikipedia user page: https://en.wikipedia.org/wiki/User:Brian.gerstle IRC: bgerstle ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] Wikipedia iOS app moving to GH
Hey everyone, I'm writing with plans for the Wikimedia iOS engineering team to move its workflow to GitHub with Travis CI, much like RESTbase. The Wikimedia iOS engineers have been maintaining their own CI and build server and using Gerrit for code review. The more time efficient and commonplace approach for open source iOS software development leans heavily on GitHub with Travis CI instead (e.g., WordPress[0][1] and Firefox[2][3]). By using GitHub with Travis CI, the team believes it will work faster, improve testing, grow developer confidence in making code changes, and, most importantly, deploy fewer bugs to production. For builds requiring sensitive information (e.g., prod certs), will continue to run on WMF's Mac Mini. As is done for Android, when betas are pushed, the team will notify mobile-l. Feel free to reply or email me directly with any questions or comments. Regards, Brian 0: https://github.com/wordpress-mobile/WordPress-iOS 1: https://travis-ci.org/wordpress-mobile/WordPress-iOS 2: https://github.com/mozilla/firefox-ios 3: https://travis-ci.org/mozilla/firefox-ios -- EN Wikipedia user page: https://en.wikipedia.org/wiki/User:Brian.gerstle IRC: bgerstle ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Geolocation and WikiVoyage
On Wed, Jul 22, 2015 at 9:09 AM, Sylvain Arnouts sylvain.arno...@wanadoo.fr wrote: But I still have some issues. I'm trying to use it in different languages. It works in english, but I'd like to have results from the french version of Wikivoyage. I don't know why, it doesn't work by calling https://fr.wikivoyage.org/w/api.php? ... same request. I've no answer, even if the page actually exists. For this feature to work, the page obviously needs to know its coordinates. The English page does https://en.wikivoyage.org/w/api.php?action=queryprop=coordinatestitles=Lille while the French page does not https://fr.wikivoyage.org/w/api.php?action=queryprop=coordinatestitles=Lille. The coordinates are stored into the page properties using the {{#coordinates:}} special function, see https://www.mediawiki.org/wiki/Extension:GeoData#Usage. On English Wiktionary, this function is called using the {{Geo}} template (see https://en.wikivoyage.org/w/index.php?title=Template:Geoaction=edit). On the French Wiktionary, the function should probably be called in {{Info Ville}} or {{Geo}}, I guess. HTH, -- [[cs:User:Mormegil | Petr Kadlec]] ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] FYI: HTMLForm is now available in OOUI format
It took a while, but most of the issues are ironed out now. OOUI still doesn't support subsections, as that would require some refactoring of gnarly old code. Everything else should work well enough. -- Bartosz Dziewoński ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Geolocation and WikiVoyage
Hey ! Thanks for your answer. Now with the documentation you gave me, I'm able to catch the URL of the pages concerned, like this : https://en.wikivoyage.org/w/api.php?action=queryprop=coordinates|infoinprop=urlgenerator=geosearchggscoord=50.6|3.02ggsradius=1ggslimit=50ggsradius=1ggslimit=50 But I still have some issues. I'm trying to use it in different languages. It works in english, but I'd like to have results from the french version of Wikivoyage. I don't know why, it doesn't work by calling https://fr.wikivoyage.org/w/api.php? ... same request. I've no answer, even if the page actually exists. Maybe you got an idea ? Thanks a lot for your help. Le 22/07/2015 03:25, S Page a écrit : There's an article about getting pages nearby with action=geosearch, http://devhub.wmflabs.org/wiki/API:Showing_nearby_wiki_information [1], I welcome feedback. On Jul 21, 2015 10:40, Sylvain Arnouts sylvain.arno...@wanadoo.fr wrote: I know it's possible with Wikidata API to enter a position (longitude and latitude), a range, and have all Wikipedia pages around. How? I don't see such a feature in the wikidata modules for the MediaWiki API at https://www.wikidata.org/w/api.php , and I wasn't aware of a Wikidata query service for querying within a range of coordinate location. [1] The same content is also at https://www.mediawiki.org/wiki/API:Showing_nearby_wiki_information ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Wikipedia iOS app moving to GH
I have no problem with that, as long as everyone with +2 keeps his access and someone manages developer account additions and removals. Oh, and when it syncs with phabricator tickets DJ On Wed, Jul 22, 2015 at 1:39 PM, Petr Bena benap...@gmail.com wrote: Good job, you aren't the only one. Huggle team is using it for quite some time. To be honest I still feel that github is far superior to our gerrit installation and don't really understand why we don't use it for other projects too. The GitHub's pull requests are more compliant with original git philosophy of Linus, see this video: https://www.youtube.com/watch?v=4XpnKHJAok8 and would be sufficient replacement to our current git-review mechanism, which is very complex and unfriendly to new developers who probably find it very difficult to use. On Wed, Jul 22, 2015 at 12:40 PM, Brian Gerstle bgers...@wikimedia.org wrote: Hey everyone, I'm writing with plans for the Wikimedia iOS engineering team to move its workflow to GitHub with Travis CI, much like RESTbase. The Wikimedia iOS engineers have been maintaining their own CI and build server and using Gerrit for code review. The more time efficient and commonplace approach for open source iOS software development leans heavily on GitHub with Travis CI instead (e.g., WordPress[0][1] and Firefox[2][3]). By using GitHub with Travis CI, the team believes it will work faster, improve testing, grow developer confidence in making code changes, and, most importantly, deploy fewer bugs to production. For builds requiring sensitive information (e.g., prod certs), will continue to run on WMF's Mac Mini. As is done for Android, when betas are pushed, the team will notify mobile-l. Feel free to reply or email me directly with any questions or comments. Regards, Brian 0: https://github.com/wordpress-mobile/WordPress-iOS 1: https://travis-ci.org/wordpress-mobile/WordPress-iOS 2: https://github.com/mozilla/firefox-ios 3: https://travis-ci.org/mozilla/firefox-ios -- EN Wikipedia user page: https://en.wikipedia.org/wiki/User:Brian.gerstle IRC: bgerstle ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] [WikimediaMobile] Wikipedia iOS app moving to GH
Il 22/07/2015 23:43, Brian Gerstle ha scritto: This isn't really about Gerrit vs. GitHub. To be clear, we're mainly doing this for CI (i.e. Travis). That said, we (the iOS team) plan for our workflow to play to GitHub's strengths—which also happen to be our personal preferences. In short, this means amending patches becomes pushing another commit onto a branch. We've run into issues w/ rebasing amending patches destroying our diff in Gerrit, and problems with multiple people collaborating on the same patch. With GitHub it is not possible to amend other people's patches, is it? We think GitHub will not only provide integrations for free CI, but, as an added bonus, also resolve some of the workflow deficiencies that we've personally encountered with Gerrit. On Wed, Jul 22, 2015 at 5:14 PM, Gergo Tisza gti...@wikimedia.org wrote: On Wed, Jul 22, 2015 at 4:39 AM, Petr Bena benap...@gmail.com wrote: Good job, you aren't the only one. Huggle team is using it for quite some time. To be honest I still feel that github is far superior to our gerrit installation and don't really understand why we don't use it for other projects too. GitHub is focused on small projects; for a project with lots of patches and committers it is problematic in many ways: * poor repository management (fun fact: GitHub does not even log force pushes, much less provides any ability to undo them) * noisy commit histories due to poor support of amend-based workflows, and also because poor message generation of the editing interface (Linus wrote a famous rant https://github.com/torvalds/linux/pull/17#issuecomment-5654674 on that) * no way to mark patches which depend on each other * diff view works poorly for large patches * CR interface works poorly for large patches (no way to write draft comments so you need to do two passes; discussions can be marked as obsolete by unrelated code changes in their vicinity) * hard to keep track of cherry-picks ___ Mobile-l mailing list mobil...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Wikipedia iOS app moving to GH
On Wed, Jul 22, 2015 at 4:39 AM, Petr Bena benap...@gmail.com wrote: Good job, you aren't the only one. Huggle team is using it for quite some time. To be honest I still feel that github is far superior to our gerrit installation and don't really understand why we don't use it for other projects too. GitHub is focused on small projects; for a project with lots of patches and committers it is problematic in many ways: * poor repository management (fun fact: GitHub does not even log force pushes, much less provides any ability to undo them) * noisy commit histories due to poor support of amend-based workflows, and also because poor message generation of the editing interface (Linus wrote a famous rant https://github.com/torvalds/linux/pull/17#issuecomment-5654674 on that) * no way to mark patches which depend on each other * diff view works poorly for large patches * CR interface works poorly for large patches (no way to write draft comments so you need to do two passes; discussions can be marked as obsolete by unrelated code changes in their vicinity) * hard to keep track of cherry-picks ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Wikipedia iOS app moving to GH
On Wed, Jul 22, 2015 at 2:14 PM, Gergo Tisza gti...@wikimedia.org wrote: GitHub is focused on small projects; for a project with lots of patches and committers it is problematic in many ways: Some of the largest open source projects around are on github: https://github.com/saltstack/salt/pulse/monthly https://github.com/docker/docker/pulse/monthly * poor repository management (fun fact: GitHub does not even log force pushes, much less provides any ability to undo them) You can have force push to master disabled. Also their fork model (which I dislike for other reasons) means you can limit access to the main fork to a small set of people and require all pull requests to come from branches of forks. It's the default model for basically every public github project. * noisy commit histories due to poor support of amend-based workflows, and also because poor message generation of the editing interface (Linus wrote a famous rant https://github.com/torvalds/linux/pull/17#issuecomment-5654674 on that) You can manage that yourself through rebasing of PRs. That's completely based on your workflow and what you require of contributors (or how you do your merges). * no way to mark patches which depend on each other Sure you can. Alll PRs are also issues and can be referenced by issue number. If you mention the issue in a comment it adds a reference for you. * diff view works poorly for large patches It's way better than gerrit. May not be better than phabricator, though. * CR interface works poorly for large patches (no way to write draft comments so you need to do two passes; discussions can be marked as obsolete by unrelated code changes in their vicinity) You can delete and edit your comments. Draft comments in gerrit are an anti-pattern IMO. The biggest reasons to avoid github are the possibility of future lock-in of the community, them possibly doing evil things (like source forge), and the fact that it's a third party that's collecting information on our community. For all intents and purposes github is superior to gerrit and phabricator in almost every way. It was avoided at Wikimedia in the past because of privacy and security concerns. - Ryan ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Wikipedia iOS app moving to GH
quote name=Ryan Lane date=2015-07-22 time=14:48:07 -0700 For all intents and purposes github is superior to gerrit and phabricator in almost every way. It was avoided at Wikimedia in the past because of privacy and security concerns. Which have not disappeared nor been addressed. Greg -- | Greg GrossmeierGPG: B2FA 27B1 F7EB D327 6B8E | | identi.ca: @gregA18D 1138 8E47 FAC8 1C7D | ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Geolocation and WikiVoyage
Hi, On Wed, Jul 22, 2015 at 7:13 PM, Sylvain Arnouts sylvain.arno...@wanadoo.fr wrote: You're right, I didn't think about it. So to have all result, I have to call all API on each Wikivoyage version ? Well, either that, or you might want to utilize Wikidata, which should basically contain everything. For instance, using https://wdq.wmflabs.org/api?q=around[625,46.016667,-1.175,10] you’ll get the list of all Wikidata items in 10km radius around Île d'Aix. You might want to limit the query to Wikidata items with a link to a Wikivoyage article in English, German or French with https://wdq.wmflabs.org/api?q=around[625,46.016667,-1.175,10]%20AND%20link[enwikivoyage,dewikivoyage,frwikivoyage] (add more languages to the list if so desired). I don’t know if mapping those entity IDs to links could be done in a single step (@Magnus?), or you need to take the result and in another step call something https://www.wikidata.org/w/api.php?action=wbgetentitiesids=Q214568|Q292111props=sitelinks/urlssitefilter=enwikivoyage|dewikivoyage|frwikivoyage . HTH, -- [[cs:User:Mormegil | Petr Kadlec]] ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Min php version
On Wed, 22 Jul 2015 22:18:57 +0200, Eran Rosenthal eranro...@gmail.com wrote: side note: How come php 5.3.3 support broken accidentally? Isn't Jenkins script validates compatibility with the min php? :) We run unit tests, but on PHP 5.3.10, according to the console output. (For example https://integration.wikimedia.org/ci/job/mediawiki-phpunit-zend/6594/consoleFull) (Also, that only catches incompatibilities in code that has unit tests. ;) I've ran into 5.3 compat breakages in the past when I added new features with tests, that used some existing code without tests.) -- Bartosz Dziewoński ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] [WikimediaMobile] Wikipedia iOS app moving to GH
This isn't really about Gerrit vs. GitHub. To be clear, we're mainly doing this for CI (i.e. Travis). That said, we (the iOS team) plan for our workflow to play to GitHub's strengths—which also happen to be our personal preferences. In short, this means amending patches becomes pushing another commit onto a branch. We've run into issues w/ rebasing amending patches destroying our diff in Gerrit, and problems with multiple people collaborating on the same patch. We think GitHub will not only provide integrations for free CI, but, as an added bonus, also resolve some of the workflow deficiencies that we've personally encountered with Gerrit. On Wed, Jul 22, 2015 at 5:14 PM, Gergo Tisza gti...@wikimedia.org wrote: On Wed, Jul 22, 2015 at 4:39 AM, Petr Bena benap...@gmail.com wrote: Good job, you aren't the only one. Huggle team is using it for quite some time. To be honest I still feel that github is far superior to our gerrit installation and don't really understand why we don't use it for other projects too. GitHub is focused on small projects; for a project with lots of patches and committers it is problematic in many ways: * poor repository management (fun fact: GitHub does not even log force pushes, much less provides any ability to undo them) * noisy commit histories due to poor support of amend-based workflows, and also because poor message generation of the editing interface (Linus wrote a famous rant https://github.com/torvalds/linux/pull/17#issuecomment-5654674 on that) * no way to mark patches which depend on each other * diff view works poorly for large patches * CR interface works poorly for large patches (no way to write draft comments so you need to do two passes; discussions can be marked as obsolete by unrelated code changes in their vicinity) * hard to keep track of cherry-picks ___ Mobile-l mailing list mobil...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l -- EN Wikipedia user page: https://en.wikipedia.org/wiki/User:Brian.gerstle IRC: bgerstle ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] MW support for Composer equivalent for JavaScript packages
On Wed, Jul 22, 2015 at 12:24 PM, Daniel Werner daniel.a.r.wer...@gmail.com wrote: Hey, I just wanted to check in about the status of enabling JavaScript package management usage in MediaWiki. I am basically talking about an equivalent for JS to what we have with Composer for PHP. Real-world example: The data-values/value-view package[0] is defining jquery.event.special.eachchange.js: ValueView/lib/jquery.event/jquery.event.special.eachchange.js Now, recently I needed the same functionality in one of my extensions, so I just copied it over. [1] I know that this is the worst way one could do this, but as far as I can see we don't have that much of a choice right now. Here are the alternative options I can see: Moving jquery.event.special.eachchange.js out of the data-values/value-view package into its own WMDE/jquery-eachchange package... 1. ... and using it in my extension via composer. + pro: two or more extensions or other packages requiring this package will still result in having only one MW-wide installation.. - con: requires MW specific code which is actually not related to the MW-independent package to feed the resource loader. - con: using Composer to manage pure JavaScript packages! Uuuh, ugly! 2. ... and having a build step in other packages using the package, pulling the WMDE/jquery-eachchange somewhere into the file structure of the packages/extensions using it. + pro: don't need to abuse composer, we can use npm, Bower or any other arbitrary JS package manager here. - con: got to tell resource loader somehow... (didn't think so much about that yet) - con: if more than one extensions or other packages require this package we still end up with the same code twice or more often in one MW installation. 3. Combining 1 and 2: Start with 2, using a JS package manager. Then going to 1, creating a composer package and pulling the WMDE/jquery-eachchange package in via some build script. + pro: The two pros from 1 + 2 + pro: ^^ - con: still got to tell resource loader somehow... - con: Overhead; We now create two packages where the Composer one is just a bridge to the MW-world, still polluting packagist.org. Still kind of ugly and more effort for publishing a package and therefore potentially scaring programmers away from doing so since they've got better things to do than doing work that could be automated. I have not seen Approach 2 and 3 yet. Though I could imagine that the VisualEditor team has used something like that. Approach 1 is the way the data-values/value-view package itself is being handled. And that package should actually be a MW independent pure JS package but right now it contains MW specific code and uses composer for distribution! There is still another option but that had to be properly implemented: 4. Choose one native JS package manager for now and go with it (add support for others later perhaps). Integrate it properly with MW (resource loader to begin with), document how to use it and finally distribute JS code coming from the MW world but useful for other projects in a way where it can actually be used in a non-MW context. This has already been bugging me when working on Wikidata. Now I'd like to reuse some of the code I have written there without spending hours and hours with option 3 because there should be support for option 4 rather sooner or later. So I am wondering; Does anyone have any thoughts, any alternatives perhaps or is there any roadmap on anything like the option 4 that I have shown? Cheers, Daniel [0]: https://packagist.org/packages/data-values/value-view [1]: https://github.com/DanweDE/mediawiki-ext-UserBitcoinAddresses/blob/master/resources/vendor/jquery.event.special.eachchange.js Option 4 was discussed last October as part of the Librarization project [0]. At the time the front end standards group wasn't ready to pick a winner in the javascript packaging landscape. They did want to revisit that in 3-6 months however so maybe it is time to find someone to look into the various options and their pros and cons again? [0]: https://phabricator.wikimedia.org/T807 -- Bryan Davis Wikimedia Foundationbd...@wikimedia.org [[m:User:BDavis_(WMF)]] Sr Software EngineerBoise, ID USA irc: bd808v:415.839.6885 x6855 ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Wikipedia iOS app moving to GH
On Wed, Jul 22, 2015 at 2:48 PM, Ryan Lane rlan...@gmail.com wrote: Some of the largest open source projects around are on github: https://github.com/saltstack/salt/pulse/monthly https://github.com/docker/docker/pulse/monthly Which does not necessarily mean it does not suck for them. Some large projects are still on Sourceforge. Some large projects still use SVN. etc. Change is hard. * poor repository management (fun fact: GitHub does not even log force pushes, much less provides any ability to undo them) You can have force push to master disabled. Also their fork model (which I dislike for other reasons) means you can limit access to the main fork to a small set of people and require all pull requests to come from branches of forks. It's the default model for basically every public github project. So force pushes can only obliterate feature branches, version branches and whatnot. (GitHub actually developed sane management of force pushes but only included into their enterprise version. I guess that does not quite qualify as doing evil things but still is unpleasant.) * noisy commit histories due to poor support of amend-based workflows, and also because poor message generation of the editing interface (Linus wrote a famous rant https://github.com/torvalds/linux/pull/17#issuecomment-5654674 on that) You can manage that yourself through rebasing of PRs. That's completely based on your workflow and what you require of contributors (or how you do your merges). GitHub's PR interface sucks with a rebase-heavy workflow. There is no indication that a commit is a rebased version of a former commit; former commits disappear without trace; inline comments to former commits become unintelligible. And you need force push to do it which has potentially disastrous effects on GitHub. * no way to mark patches which depend on each other Sure you can. All PRs are also issues and can be referenced by issue number. If you mention the issue in a comment it adds a reference for you. Which will not stop the CI infrastructure from testing your patch without pulling in its dependencies, not will it stop a careless reviewer from merging it without the dependencies. * diff view works poorly for large patches It's way better than gerrit. May not be better than phabricator, though. Here is a patch I made a few days ago: https://gerrit.wikimedia.org/r/#/c/225827/ Here is the same patch in GitHub: https://github.com/wikimedia/operations-software-sentry/commit/ae8bc0fe9adad6f09f3da72a70e888798ff5a22e (Warning: might crash your browser.) * CR interface works poorly for large patches (no way to write draft comments so you need to do two passes; discussions can be marked as obsolete by unrelated code changes in their vicinity) You can delete and edit your comments. Draft comments in gerrit are an anti-pattern IMO. Deleting or reworking comments after email notifications have already been sent out with them is much more of an antipattern. Anyway, I did not intend to start a GitHub-vs-Gerrit deathmatch, nor to criticize the iOS team's decision (at their team size GitHub makes perfect sense IMO), just answer Petr's question about why don't we all just move to GitHub. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] FYI: HTMLForm is now available in OOUI format
Yay :D Sent from my HTC - Reply message - From: Bartosz Dziewoński matma@gmail.com To: Wikimedia developers wikitech-l@lists.wikimedia.org Subject: [Wikitech-l] FYI: HTMLForm is now available in OOUI format Date: Wed, Jul 22, 2015 15:45 It took a while, but most of the issues are ironed out now. OOUI still doesn't support subsections, as that would require some refactoring of gnarly old code. Everything else should work well enough. -- Bartosz Dziewoński ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Adding extensions under packagist's mediawiki vendor
Gerrit is too unpredictable for users: https://phabricator.wikimedia.org/T86476#1462980 . It's probably easier and more functional to create some mediawiki-users vendor on packagist and let any MediaWiki sysadmin (not developer) join to add the packages they need for whatever reason. Nemo ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Min php version
On Tue, 21 Jul 2015 22:22:41 +0200, Gergo Tisza gti...@wikimedia.org wrote: On Tue, Jul 21, 2015 at 11:27 AM, Tyler Romeo tylerro...@gmail.com wrote: Even if we upgrade our minimum PHP version now, older versions of MediaWiki with the 5.3 requirement will still be supported and receive security updates. So the only difference will be that people running Debian oldstable will be locked into our older version and not be able to upgrade to bleeding edge MediaWiki, which they probably won't do anyway considering they haven't even upgraded their Debian. :P Specifically, 1.23, which is the current LTS (long-term support) release, is supported until May 2017 (so that covers Debian/Ubuntu and almost covers RedHat, but that one provides PHP 5.5 anyway). The next LTS is due spring 2016 and will be supported until spring 2019 and I don't think we want to get stuck on PHP 5.3 with that one. Indeed, I think this is a very good argument. Do we want to do this now? Or do we want to fix the accidentally broken 5.3.3 compatibility for now, and then intentionally break it in a few months? Should the upcoming MediaWiki 1.26 release be compatibly with 5.3.3? -- Bartosz Dziewoński ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l