[Wikitech-l] MediaWiki-CodeSniffer 14.1.0 released

Hello! MediaWiki-CodeSniffer 14.1.0 is now available for use in your MediaWiki extensions and other projects. This release features improves to the documentation-related sniffs and new upstream releases. 14.0.0 was tagged, but 14.1.0 should be used as it includes a newer upstream version. Here's

Re: [Wikitech-l] TechCom Radar, 2017-11-08

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 11/12/2017 01:17 PM, Daniel Kinzler wrote: > As always, the discussion will take place in the IRC channel > #wikimedia-office on Wednesday - however, this time, it will be two > hours earlier! Please join us at 12 noon PST / 21:00 CET /

[Wikitech-l] Restricting binaries that MediaWiki shells out to

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, For a while now, Wikimedia has been restricting the different binaries that we shell out to (mostly image handling things) with firejail[1]. This was a manual process by writing wrapper scripts that invoked firejail, and pointing MediaWiki to

[Wikitech-l] RfC: PlatformSettings.php

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, I've written an RfC to introduce a standardized and recommended way for re-distributors and packagers of MediaWiki to be able to tune DefaultSettings.php as appropriate. You can read more details on-wiki[1], and discuss it on Phabricator[2].

[Wikitech-l] Using a PSR-4 autoloader in MediaWiki

Hi, You can now use a PSR-4 autoloader[1] in MediaWiki core and via extension.json. If you're not familiar with PSR-4, it's a standard which tells autoloaders that if a class is named Foo\Bar\Baz, it can be found at $basePath/Bar/Baz.php. This means that we don't need to keep a mapping of

Re: [Wikitech-l] +2 nomination for WMDE-Fisch in mediawiki/*

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 I just closed the request as successful - congratulations Fisch! - -- Legoktm -BEGIN PGP SIGNATURE- iQJLBAEBCgA1FiEE+h6fmkHn9DUCyl1jUvyOe+23/KIFAloxgjoXHGxlZ29rdG1A bWVtYmVyLmZzZi5vcmcACgkQUvyOe+23/KI4hRAAl71AhawYYxoyVoh1p0NTcZ3P

[Wikitech-l] Try out the commit message validator

Hi! tl;dr Commit messages are pretty important - they make it easy to figure out what a change does without reading the entire diff. And because of that, we have some guidelines[1] on how to format your commit message in the standard way.

[Wikitech-l] Migrating away from nose (was 2017-11-01 Scrum of Scrums meeting notes)

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 11/01/2017 10:53 AM, Grace Gellerman wrote: > === Scoring Platform === ** Converted our tests from nosetests to > pytest (Anyone else making the transition?) *** nosetests is > under-maintained *** python community is moving towards pytest

[Wikitech-l] MediaWiki npm jenkins jobs moved over to new docker system

Hi, I just moved the npm jobs in the MediaWiki queue over to the new, faster, docker based CI system. Instead of requiring building a fresh VM for each 20-30 second job, it uses a docker container. I'm expecting this to make a noticeable improvement in CI response times. For the most part

Re: [Wikitech-l] PHPUnit 6+ on older versions of MW

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 05/12/2018 11:37 PM, Jeroen De Dauw wrote: > I updated one of my extensions to use PHPUnit 6+ and am having > troubles getting the tests to run with older versions of MediaWiki. > In particular, I'd like my tests to run with MW 1.27. I

[Wikitech-l] MediaWiki core master now requires PHP 7.0 or HHVM

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, MediaWiki core's master branch now requires a minimum of PHP 7.0 or HHVM[1], as decided upon in the RfC. CI has been updated no longer run PHP 5.5 tests. There are already quite a few patches[2] to remove code that isn't necessary now, or

[Wikitech-l] MediaWiki-CodeSniffer 19.0.0 and 20.0.0 released

for traits with phpunit annotations (Umherirrender ) * Don't allow 'iterable' type hint (Kunal Mehta) * Prevent usage of nullable and void type hints (Kunal Mehta) * Prohibit PHP's vanilla execution (Max Semenik) * Reorganize PHP 7.0 compatibility sniffs into a category (Kunal Mehta) And for 20.0.0

Re: [Wikitech-l] PHPUnit 6+ on older versions of MW

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 05/15/2018 11:25 PM, Jeroen De Dauw wrote: > Failing tests: > https://travis-ci.org/JeroenDeDauw/Maps/builds/375344161 > > Code: https://github.com/JeroenDeDauw/Maps OK, so you need to use the PHPUnit4And6Compat trait as explained in[1].

[Wikitech-l] Provide input on the future direction of MediaWiki's extension management system

Hi everyone, As part of the MediaWiki Platform Team's goal to develop a roadmap for MediaWiki, we want to solicit input on the future direction of MediaWiki's extension management system. One of MediaWiki's greatest strengths is the diverse extension ecosystem. But navigating that ecosystem and

Re: [Wikitech-l] Gerrit as a shared community space

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, CoC.md business aside, I agree with the main thing you've said. Specifically: On 06/09/2018 08:58 AM, Brion Vibber wrote: > I think we should though clarify that code repositories on gerrit > and diffusion are not owned by any one person, but

Re: [Wikitech-l] Thank you week-end thread

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, Thank you for starting this thread :) On 06/08/2018 12:03 PM, Antoine Musso wrote: > Marco Aurelio, who has been dramatically helping to archive a few > outdated/no more working extensions. The workflow is nice, makes > sure nothing get

[Wikitech-l] +2 nomination for MarcoAurelio in mediawiki/*

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, I've filed , nominating MarcoAurelio for +2 access in mediawiki/. - -- Legoktm -BEGIN PGP SIGNATURE- iQIzBAEBCgAdFiEE+h6fmkHn9DUCyl1jUvyOe+23/KIFAlsg1OEACgkQUvyOe+23

Re: [Wikitech-l] Extension registration dependencies towards skins

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 06/15/2018 04:42 PM, Alex Winkler wrote: > I've been wondering if it is just the documentation being wrong or > the key being typo'd ever since 1.29, considering the extensions > dependency key is inplural I'd tend to think the key is typo'd

Re: [Wikitech-l] +2 nomination for Jakob in mediawiki/*

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, I've closed the request as successful. Congrats Jakob! - -- Legoktm On 05/20/2018 10:47 AM, Addshore wrote: > Hi, > > I've filed <*https://phabricator.wikimedia.org/T195220 > *>, nominating Jakob

Re: [Wikitech-l] 2018-05-02 Scrum of Scrums meeting notes

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 05/02/2018 11:02 AM, Grace Gellerman wrote: > * Services: If someone maintains/knows JobQueue Job code that posts > jobs cross-wiki, please tell us. MassMessage and GlobalUserPage both post jobs across wikis and rely on that functionality.

[Wikitech-l] MediaWikiTestCase now validates @cover tags

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, MediaWikiTestCase will now verify[1] that @covers tags are sane when running normal PHPUnit tests. Previously PHPUnit would only verify that when it ran the twice daily coverage job, and fail if even a single one was wrong. This also affects

[Wikitech-l] MediaWiki-CodeSniffer 15.0.0 released

notes[1]. The full MediaWiki-CodeSniffer changelog since 14.1.0: * Add sniff for using is_int over is_integer (Kunal Mehta) * Allow _ in unit test method names (Gergő Tisza) * Check function definitions for the same variable name (Kunal Mehta) * Fix handling of alternative

[Wikitech-l] Thank you 2017 code reviewers

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, Nemo generated a list of the top +2'ers for MediaWiki core and MediaWiki extensions in 2017: Thank you very much for all of the code review that you do :-) Special shout out to Timo with 365

[Wikitech-l] Test coverage reports for patchsets

Hi, I've been working on a tool, phpunit-patch-coverage[0], that tries to provide test coverage reports for patches before they are merged[1]. Since it takes 2-3 hours to do a full coverage report for MediaWiki core, the tool figures out what files were modified, and runs those tests. For now

Re: [Wikitech-l] +2 nomination for WMDE-leszek in mediawiki/*

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 I've closed the request as successful. Congrats Leszek! - -- Legoktm On 01/23/2018 10:36 AM, Addshore wrote: > Hi, > > I've filed , nominating > WMDE-leszek for +2 in mediawiki/ repos. > > -- Addshore

[Wikitech-l] MediaWiki codesearch updates, co-maintainers wanted

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, A few updates on codesearch.wmflabs.org: * The OOUI git repository is now indexed * The operations/dns and operations/mediawiki-config git repositories are now indexed * Should properly restart automatically after rebooting the instance *

[Wikitech-l] MediaWiki-CodeSniffer 16.0.0 released

(Kunal Mehta) * Add sniff to use namespaced PHPUnit\Framework\TestCase (Kunal Mehta) * Avoid assignment in return statements (Umherirrender) * Be aware of extension MediaWiki compatibility (Kunal Mehta) * Detect variadic arguments in function comments (Umherirrender) * Disallow PHP 7.2+ `object` type

Re: [Wikitech-l] MediaWiki-CodeSniffer 16.0.0 released

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi everyone, I just released 16.0.1 to fix a bug[1] that was causing PHPCS to error out in specific cases. Thank you to Umherirrender for both reporting and fixing the issue :-) A few other minor refactoring changes are included: * Fix

[Wikitech-l] Announcing MediaWiki code search

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, MediaWiki code search is a fully free software tool that lets you easily search through all of MediaWiki core, extensions, and skins that are hosted on Gerrit. You can limit your search to specific repositories, or types of repositories too.

Re: [Wikitech-l] +2 nomination for MarcoAurelio in mediawiki/*

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 I've closed the request as successful. Congrats to MarcoAurelio for being the first new volunteer +2'er since 2016! - -- Legoktm On 06/13/2018 10:25 AM, Kunal Mehta wrote: > Hi, > > I've filed <https://phabricator.wikimedia

[Wikitech-l] New PHPUnit structure test validating existence of right-* i18n messages

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, For proper display on pages like Special:ListGroupRights, all userrights are supposed to have a corresponding right-{name} i18n message. MediaWiki core has had a PHPUnit test enforcing this for quite a while now, so I converted[1] it into a

Re: [Wikitech-l] Proposal for removal without deprecation of MagicWord::clearCache

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, I don't have a strong opinion about the specific function in this case, but I did want to discuss a few things about the policy itself. On 07/30/2018 06:28 AM, Stephan Gambke via Wikitech-l wrote: > I know it is annoying as heck to keep

[Wikitech-l] Postgres and SQLite tests are now voting on mediawiki/core patches

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, MediaWiki core patches will now need to pass tests on postgres and sqlite (in addition to mysql of course) to be merged. For speed, CI won't run postgres/sqlite tests until after the patch has been +2'd (gate-and-submit queue). If you want to

Re: [Wikitech-l] +2 nominations for mediawiki/*

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, I just closed all of the nominations as unanimously successful - congratulations to everyone :) - -- Legoktm On 07/18/2018 12:51 AM, Kunal Mehta wrote: > Hi, > > Following comments from last time that we need some more volunteer

Re: [Wikitech-l] ForkableMaintenance: thoughts and help with tests/code coverage

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 08/11/2018 06:48 PM, Brion Vibber wrote: > Second, probably related to that I'm seeing a failure in the code > coverage calculations -- it's seeing some increased coverage on the > parent process at least but seems to think it's returning a

Re: [Wikitech-l] My Phabricator account has been disabled

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 08/08/2018 03:08 AM, Amir Ladsgroup wrote: > I disabled the account and now I disabled it again. It's part of a > CoC ban. We sent the user an email using the "Email to user" > functionality from mediawiki.org the moment I enforced the ban.

Re: [Wikitech-l] My Phabricator account has been disabled

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 08/09/2018 04:55 AM, Aryeh Gregor wrote: > The main problem here that needs to be solved is communicating > what the problem was in a manner that is clear to the parties whom > the CoC committee seeks to deter. A one-week ban is not going to >

[Wikitech-l] +2 nominations for mediawiki/*

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, Following comments from last time that we need some more volunteer +2'ers, I've filed multiple nominations for +2 rights in mediawiki/*: * Eranroz: https://phabricator.wikimedia.org/T199866 * Huji: https://phabricator.wikimedia.org/T199867 *

Re: [Wikitech-l] [Engineering] Additional European-appropriate MediaWiki train window starting week of July 9th (also SWAT change)

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 07/11/2018 12:05 AM, Marko Obrovac wrote: > It seems to me that it will be confusing only to non-US people, > honestly, which are the ones benefiting from this change. When DST > changes are applied, and because they are not applied at the

[Wikitech-l] eslint compromised, reset your npm tokens

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, If you ran eslint (JavaScript codestyle linter) recently (it was only compromised for an hour), your npm token might have been compromised (~/.npmrc). To identify if you were compromised, run: $ locate eslint-scope | grep -i

[Wikitech-l] Generating PHP test coverage reports for extensions

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, CI now supports generating PHP test coverage reports for extensions after a commit is merged. It's already running for some extensions: Hopefully these reports will encourage people to increase

Re: [Wikitech-l] Upcoming CI changes for PHP 7

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 03/05/2018 10:54 PM, Kunal Mehta wrote: > We're planning to enable tests against PHP 7.0 as a voting job for > MediaWiki core, and all MediaWiki extensions and skins that > currently have one for PHP 5.5 and HHVM. This has hap

[Wikitech-l] Review and update your extensions for PHPUnit 6

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, tl;dr: Read the "So what do you need to do?" section We're currently in the process of upgrading the MediaWiki PHPUnit version to 6. To avoid an immediate breaking change, we will be doing this transition in two steps. First, we will start

Re: [Wikitech-l] Review and update your extensions for PHPUnit 6

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 04/07/2018 09:03 PM, Kunal Mehta wrote: > I'd like to start running voting tests against PHPUnit 4 and 6 > next week on Thursday (April 12). This should give us just enough > time to fix any resulting issues before the 1.31 branch

Re: [Wikitech-l] Proposal to remove $wgValidateAllHtml and MWTidy::checkErrors() without deprecation

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 04/10/2018 05:44 PM, Kunal Mehta wrote: > As part of the goal to have MediaWiki 1.31 default to using > RemexHtml and replacing tidy, we want to remove > MWTidy::checkErrors() and $wgValidateAllHtml as part of MediaWiki > 1

[Wikitech-l] Proposal to remove $wgValidateAllHtml and MWTidy::checkErrors() without deprecation

Hi, As part of the goal to have MediaWiki 1.31 default to using RemexHtml and replacing tidy, we want to remove MWTidy::checkErrors() and $wgValidateAllHtml as part of MediaWiki 1.31, without a deprecation period. MWTidy::checkErrors() basically ran the provided input through tidy, and checked

[Wikitech-l] MediaWiki-CodeSniffer 17.0.0 released

irst and shorten out earlier (Thiemo Kreu z) * Check for use statement with non-compound name (Umherirrender) * Don't require @covers from abstract tests (Max Semenik) * Forbid usage of assert() (Kunal Mehta) * Improve ClassMatchesFilenameSniff::isMaintenanceScript (Umherirrender) *

Re: [Wikitech-l] Example .spec file for packaging Mediawiki with RPM

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 03/28/2018 01:46 PM, Hogan, Michael C wrote: > Kunal, thank you for the reference to the Fedora .spec files. > Anyone know if there's a technical / policy reason for the Fedora > EPEL package to be stuck at mediawiki123? >

Re: [Wikitech-l] Example .spec file for packaging Mediawiki with RPM?

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 03/26/2018 03:02 PM, Hogan, Michael C wrote: > Anyone know of a Mediawiki RPM .spec file posted online? I've only > been able to find pre-packaged RPMs. Thank you! The .spec files that Fedora uses are available at

[Wikitech-l] codesearch might have returned incorrect results in the past 2ish days

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, For about the past two days codesearch.wmflabs.org ran out of disk space[1] and has been not searching some repositories[2]. This has been fixed now, thanks to bd808 and others in #wikimedia-cloud for their help :) People who were looking for

[Wikitech-l] Upcoming CI changes for PHP 7

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, We're planning to enable tests against PHP 7.0 as a voting job for MediaWiki core, and all MediaWiki extensions and skins that currently have one for PHP 5.5 and HHVM. Tests have run in non-voting mode against nearly all extensions, most of

Re: [Wikitech-l] "PHP test coverage decreased" - really?

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 04/26/2018 12:02 PM, Daniel Kinzler wrote: > Hi all! > > While I think it's great that CI is making sure that test coverage > improves, I'm struggeling with making this work for me. It seems > to me the stats that are used to detect test

[Wikitech-l] Extension test failures on PHP 7.1

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, In preparation for Wikimedia production switching to PHP 7.2, we need to get CI running using 7.2 (and for the rest of the MediaWiki world too!). But before we can do that, we'll need 7.1 to be passing first. The following extensions are

[Wikitech-l] Extension test failures on PHP 7.2

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 10/8/18 7:43 AM, Aryeh Gregor wrote: > On Mon, Oct 8, 2018 at 9:04 AM Kunal Mehta > wrote: >> In preparation for Wikimedia production switching to PHP 7.2, we >> need to get CI running using 7.2 (and for the rest of the

Re: [Wikitech-l] Extension test failures on PHP 7.2

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 10/14/18 11:39 PM, Kunal Mehta wrote: > I'd like to also make 7.2 voting by the end of the week, but I > realize that might be a little too ambitious with multiple > conferences this week s/week/month/ it seems. As of a few hours

[Wikitech-l] MediaWiki-CodeSniffer 23.0.0 released

in @param (Umherirrender) * Update message to talk about "top level" instead of "file comment" (Thiemo Kreuz) * Upgrade squizlabs/php_codesniffer to 3.3.2 (Kunal Mehta) Thanks, - -- Legoktm -BEGIN PGP SIGNATURE- iQIzBAEBCgAdFiEE+h6fmkHn9DUCyl1jUvyOe+23/KIFAlvr0ekACgkQUvyOe

Re: [Wikitech-l] Changes to User Blocking

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 11/2/18 12:58 PM, Alex Ezell wrote: > *tl:dr;* On a wiki with the new Partial Blocks enabled (currently > only testwiki), if the code is checking User::isBlocked() to > determine edit rights, it should instead check User::isBlockedFrom( >

[Wikitech-l] Debian & Ubuntu packages of MediaWiki 1.31 now available

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, Debian and Ubuntu packages of MediaWiki 1.31 (LTS) are now available. See for more information on how to get them, and basic instructions for installing (hint: it's as simple as `sudo apt

[Wikitech-l] MediaWiki-CodeSniffer 22.0.0 released

nesting of inline ternary statements without parentheses (Kevin Israel) * Disable 'Generic.PHP.DeprecatedFunctions' sniff (Kunal Mehta) * Enable PSR2.Classes.ClassDeclaration (Umherirrender) * Enable Squiz.Functions.FunctionDeclarationArgumentSpacing (Umherirrender) * Enable

Re: [Wikitech-l] Gerrit now automatically adds reviewers

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 1/18/19 1:11 AM, Jaime Crespo wrote: > One member of my team sadly left. Now he is pinged every time I > upload a change, passively aggressive reminding him he used to work > on this. > > Don't get me wrong, I think this is great to get

Re: [Wikitech-l] [Engineering] Gerrit now automatically adds reviewers

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 1/18/19 6:11 AM, Tyler Cipriani wrote: > In the interim, project-owners are able to opt-in to using the > reviewers-by-blame plugin on a per-project basis on their project > admin page in Gerrit. I'm happy to volunteer any of the projects

Re: [Wikitech-l] UserMerge extension on Wikimedia sites

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 1/22/19 12:24 AM, Amir E. Aharoni wrote: > Yes, it's installed, but it doesn't seem to be actually used. The > English Wikivoyage has a bunch of log entries of its usage, the > last in 2015. Other Wikimedia sites have very few entries, or

[Wikitech-l] Thank you Tuesday

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, It's still Tuesday in my timezone, so here's this week's thread. Noticed something neat or cool that someone did? Or is someone just being awesome in general? Say thanks! * Thanks to Krinkle and Krenair for cleaning up user JavaScript across

[Wikitech-l] Thank you Tuesday

Hi everyone, Following up on Andre's statistics[1] about the people writing/editing the code, I wanted to share some about the people reviewing the code (gathered by Nemo, thanks!). The top +2'ers in MediaWiki core: 582 Timo Tijhof 475 James D. Forrester 406 Kunal Mehta 189 Aaron Schulz 174

[Wikitech-l] Feedback requested on proposal for extensions to "reserve" blocks of namespaces

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, I'm forwarding along a request for feedback on a proposal started by Dinoguy1000 related to the "Extension default namespaces"[1] page. They've proposed codifying the general practice of having extensions reserve blocks of ten namespace

[Wikitech-l] Changes to CI for Python jobs

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, There are a few changes to the Python `tox` jobs that CI is running: 1. Most importantly, Python 3.5 is now the default version when invoked with `tox`. This can be overridden by using basepython[1]. 2. Multiple Python 3 versions are available:

[Wikitech-l] Thank you Thursday

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, Sorry for missing Tuesday, here's this week's thank you thread :) * Thanks to Faidon for packaging different Python 3 versions for Stretch so Wikimedia CI can test against multiple Python versions seamlessly. * Thanks to Jforrester and Paladox

Re: [Wikitech-l] Thank you Tuesday

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 12/4/18 7:55 AM, MA wrote: > It's Tuesday (my timezone at least) and this week I'd like to thank > the following people for their work and assistance: Sorry for being a day late, here's my thanks: * BPirkle and Reedy for moving forwards

[Wikitech-l] Thank you Tuesday

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, It's been a while since we had a thank you thread, so since it's Tuesday, I'm starting one for the alliteration. If you haven't participated in one of these before, it's simple - just reply to the list thanking someone for what they've done

[Wikitech-l] MediaWiki-CodeSniffer 25.0.0 released

PHPDoc comment parsing in UnusedUseStatement sniff (Thiemo Kreuz) * Upgrade PHP_CodeSniffer to 3.4.1 (Kunal Mehta) * Whitelist more phan annotations (Kunal Mehta) [1] https://phabricator.wikimedia.org/T218750 - -- Legoktm -BEGIN PGP SIGNATURE

[Wikitech-l] Upgrading phan

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, It's time to work on upgrading phan, the PHP static analysis tool we use! The version of phan we were using was released over two years ago (0.8.0) - we're moving to 1.2.4 that was released less than a week ago. And the CI infrastructure is now

[Wikitech-l] Thank you Thursday

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, It's Thursday :) I wanted to say thank you this week to Zoranzoki21 and Matěj Suchánek for jumping on the phan migration and helping with upgrading extensions to take advantage of newer static analysis tools. - -- Legoktm -BEGIN PGP

[Wikitech-l] MediaWiki-CodeSniffer 24.0.0 released

, 19.2.0, which just disabled the problematic Generic.PHP.DeprecatedFunctions sniff. Here's the changelog for 24.0.0: * Whitelist @after and @before phpunit annotations (Umherirrender) * Update PHP_CodeSniffer to 3.4.0 (Kunal Mehta) * Enable new Generic.VersionControl.GitMergeConflict sniff (Kunal

Re: [Wikitech-l] [Train] 1.33.0-wmf.18 status update

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 2/19/19 6:36 AM, Tyler Cipriani wrote: > I have not yet started the 1.33.0-wmf.18 train; however, at the end > of last week, I noticed some errors that (AFAICT) are regressions > in 1.33.0-wmf.17. In addition to those, I'm not sure whether

Re: [Wikitech-l] IE 6/7 MIME type sniffing checks on uploads - is it time to retire them?

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 1/28/19 3:58 PM, Brion Vibber wrote: > Years ago, we added security checks for IE 5/6/7 to work around > IE's mime type sniffing: if you went to view a .png file directly > in IE (as opposed to in an ) the browser would check the first > few

Re: [Wikitech-l] The mw.ext construct in lua modules

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 1/24/19 11:33 PM, Thiemo Kreuz wrote: > Is there a question assigned with this long email? Is this a call > for feedback? I think this is probably related to/coming from . - -- Legoktm

Re: [Wikitech-l] Switching to elections for the Code of Conduct Committee?

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 6/18/19 3:24 PM, Yaron Koren wrote: > That's what I'm writing about: I now think that the committee > should be decided via open elections, instead of having the > committee appoint itself. At the moment, this group has a complete > lack of

Re: [Wikitech-l] New errors with composer update

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 6/26/19 10:53 PM, James Montalvo wrote: > I'm getting a new error today that was not happening with the > identical config yesterday. Tgr tracked down the root cause and filed to figure out how

[Wikitech-l] Dealing with composer dependencies in early MediaWiki initialization

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, I (with Reedy's help) recently started work on librarizing MediaWiki's IP class into a separate composer package (wikimedia/ip-utils[1]). The main motivation was so that the Parsoid PHP port could use it[2]. However, I ran into an unexpected

Re: [Wikitech-l] Help merge patch (Interwiki)

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 7/8/19 10:04 AM, Isarra Yos wrote: > Basically, uh, can anyone else help us with this? Any of this? > Given the nature of the patch we really do kind of need it merged > so it can get translations. I went ahead and +2'd it. As I was

Re: [Wikitech-l] Dealing with composer dependencies in early MediaWiki initialization

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, On 6/26/19 11:25 PM, Tim Starling wrote: > Interesting that I wrote there: "How about this: let's set > $wgServer in the installer in 1.18, and remove $wgServer > autodetection from DefaultSettings.php a bit later, say in 1.20." > > It was

[Wikitech-l] +2 nomination for Daimona in mediawiki/*

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, I've nominated Daimona for +2 in mediawiki/* repositories. Please see . Thanks! - -- Legoktm -BEGIN PGP SIGNATURE- iQIzBAEBCgAdFiEE2MtZ8F27ngU4xIGd8QX4EBsFJpsFAl0u2zMACgkQ8QX4EBsF

Re: [Wikitech-l] +2 nomination for Daimona in mediawiki/*

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 > I've nominated Daimona for +2 in mediawiki/* repositories. Please > see . I've closed this as successful. Congrats Daimona! - -- Legoktm -BEGIN PGP SIGNATURE-

[Wikitech-l] Thank you Thursday

Hi, This week I'd like to thank: * Daimona, bawolff, and sbassett for their work on v2.0 of the phan-taint-check-plugin, which has been instrumental in catching real security issues. * James_F for picking up a lot of CI maintenance * MatmaRex for seeing through a patch to allow skins to have

Re: [Wikitech-l] TechCom Radar 2020-01-22

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi, On 2020-01-28 05:29, Kate Chapman wrote: > * New RFC under discussion: Allow extensions to register handlers > with factories without the use of global variables. > Just to be clear, this is not

[Wikitech-l] CodeReview to be removed from mediawiki.org, dumps available

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi everyone, We're planning to review the CodeReview extension, which was used during the SVN era, from mediawiki.org soon. A static HTML dump of the code review comments is available at and SQL dumps are

Re: [Wikitech-l] List related to repositories which haven't mediawiki/mediawiki-codesniffer

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi, On 2020-03-05 22:46, Zoran Dori wrote: > Hello, can someone to update list > https://phabricator.wikimedia.org/P10500 which contains > repositories which haven't mediawiki/mediawiki-codesniffer. I added this functionality to the PHPCS tool:

Re: [Wikitech-l] CodeReview to be removed from mediawiki.org, dumps available

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi, On 2020-05-18 14:46, Zoran Dori wrote: > Hello, >> We're planning to review the CodeReview extension, which was >> used during the SVN era, from mediawiki.org soon. > > You mean to "remove extension" from mediawiki.org, right? :) Yep, my bad.

Re: [Wikitech-l] +2 for DannyS712 for mediawiki/*

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 I just closed the request as successful. Congrats Danny! - -- Legoktm On 2020-05-14 14:28, Danny S wrote: > Dear all, > > Per policy[1], I'd like to inform you that I have been nominated[2] > for +2 rights for mediawiki/*. > > Stay safe,

Re: [Wikitech-l] Making breaking changes without deprecation?

Hi, On 2020-08-28 02:18, Daniel Kinzler wrote: > tl;dr: the key question is: > > Can we shorten or even entirely skip the deprecation process, > if we have removed all usages of the obsolete code from public > extensions? I think going down this road would be a mistake, mostly

Re: [Wikitech-l] CI build of empty patch fails in Vector repo in 'mediawiki/phan-taint-check-plugin'

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 2020-06-01 07:21, Aron Demian wrote: > This has been happening since Saturday. Looking for resolution. See . It's currently being fixed by rolling out a new version of the phan-taint-check plugin. - --

Re: [Wikitech-l] [MediaWiki-l] MediaWiki 1.35.0-rc.0 is ready for testing

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi, On 2020-07-31 07:05, Sam Reed wrote: > I'm pleased to announce the immediate availability of MediaWiki > 1.35.0-rc.0, the first release candidate for 1.35.x, the next LTS > version to replace 1.31 which is due to go end of life in June > 2021.

[Wikitech-l] Proposed breaking change to Command::restrict()

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi, I'm proposing a breaking change to MediaWiki\Shell\Command::restrict(). I made a mistake in my original implementation of this function that I believe we're better off fixing. For background on what shell restrictions are, see

Re: [Wikitech-l] Hard deprecation of the Revision class

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi, On 2020-07-06 13:18, Petr Pchelko wrote: > TLDR: your extension CI might break due to hard deprecation of > Revision class. Unfortunately, this is happening to a significant amount of extensions. The latest libup security run shows failures

Re: [Wikitech-l] Gerrit upgrade on Saturday, 27th of June

Hi, On 2020-06-20 14:58, Christian Aistleitner via Wikitech-l wrote: > It holds a copy of our Gerrit data as of 15th of June, and it runs > the new Gerrit v3.2.2. We'll keep tuning things there during this > week, so it might get an occasional restart. But look around and > test the new UI, the

[Wikitech-l] Help test the new MediaWiki codesearch UI

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi, tl;dr: Help would be appreciated testing a new MediaWiki codesearch UI: . Sticking "-beta" in existing URLs should just work. The current codesearch interface is a pretty bad hack based on upstream's UI.

[Wikitech-l] npm and security (was: Re: TechCom Radar 2020-07-01)

Hi, On 2020-07-02 02:41, Aron Manning wrote: > Recently, I haven't seen the security question of npm being discussed on > https://phabricator.wikimedia.org/T199004 > and thought that question was not on topic. If that's not the case: is > there another discussion I'm not aware of? There's been

Re: [Wikitech-l] Technical Decision Making Process Update and Change

Hi, On 1/25/21 6:19 PM, Kate Chapman wrote: If you currently have an RFC in process with TechCom that is not on Last Call, it may need to be moved into this process. If you have filed an RFC that is no longer relevant please close it. The group setting up the process will be inquiring about the

[Wikitech-l] Performance regression expected with Debian Buster upgrade

Hi, We're currently in the process of upgrading the MediaWiki servers to Debian Buster and expect a performance regression to come with it. The cause appears to be better Spectre[1] mitigations in the Buster 4.19 kernel, which we can't disable. Most of the effect is seen in code that ends

[Wikitech-l] Re: Mailman 3 - is there an API available?

Hi, On 6/19/21 5:32 AM, Martin Urbanec wrote: does Mailman 3 (as-installed by Wikimedia) have an API I could use? Yes it has an API, but it's not available for public access. Everything in Mailman3 is driven by a REST API, however that API has a single user/password and has access to do

  1   2   >