Re: [Wikitech-l] Github/Gerrit mirroring
On Sat, 09 Mar 2013 13:06:06 -0800, Tyler Romeo tylerro...@gmail.com wrote: - Developers don't understand rebasing - This is not a Gerrit thing. Rebasing in Git is an essential feature that anybody who uses Git should know how to use, even if on Github. Why? Because git-rebase is the only way to submit a change in a way that it can be merged without conflicts. If you submit a pull request on Github without rebasing first, you're just putting work onto the maintainer to resolve your merge conflicts, possibly resulting in a breakage on master. False. git rebase is not the standard or only way of resolving conflicts in a feature branch for review before submission. As long as you're not using something that properly supports multiple commits being part of a small feature branch (which is basically everything besides Gerrit; GitHub's pull request does support this) the best way to handle conflicts (both during development with other people and before review) is to do a git merge from the branch your code is based on into your feature branch (ie: in most cases a simple `git merge master`). This leaves you with a tip with all conflicts handled that can be easily merged into master. -- ~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://danielfriesen.name/] ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Github/Gerrit mirroring
On Thu, 14 Mar 2013 19:19:34 -0700, Tyler Romeo tylerro...@gmail.com wrote: Can we please be real here? The reason more contributors come in through GitHub than through Gerrit is because they *already have a GitHub account*. My browser is always logged into GitHub, and it's at the point where I can casually just fork a project and begin working on it, whereas with Gerrit you need to request an account. You don't need to 'request' an account. Labs/Gerrit was opened up awhile ago. Anyone can get an account to use in Gerrit just by signing up on the labs wiki. Which is now sitting at: https://wikitech.wikimedia.org/w/index.php?title=Special:UserLoginreturnto=Main+Pagetype=signup -- ~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://danielfriesen.name/] ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Github/Gerrit mirroring
On Thu, Mar 14, 2013 at 10:02 PM, Quim Gil q...@wikimedia.org wrote: This thread has probably reached that limit of fresh arguments. Can we continue with proper documentation, reporting and patches? We care about GitHub and we believe it is an important source of potential contributors. This is why we are mirroring our repos there, and this is why we are working on Bug 35497 - Implement a way to bring GitHub pull requests into Gerrit https://bugzilla.wikimedia.**org/show_bug.cgi?id=35497https://bugzilla.wikimedia.org/show_bug.cgi?id=35497 If you want to improve the path from GitHub to Gerrit please contribute to that bug report or e.g. in a landing page (at mediawiki.org or github.com) to help GitHub users interested in our projects. About the Gerrit UI, if you have specific complaints or enhancement requests please file them. We have been upstreaming reports and also patches. We are surely not the only Gerrit users thinking that GitHub does some things better so there is hope. But saying it's ugly doesn't help. On 03/09/2013 01:06 PM, Tyler Romeo wrote: - Registration - The only thing that is probably a problem. We need to make Gerrit registration easier. What are the bottlenecks nowadays? If there are still any please file bugs. Yes, please do. Notice that I'm tracking account creation improvement here, as well: http://www.mediawiki.org/wiki/Wikimedia_Labs/Account_creation_improvement_project - Ryan ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Github/Gerrit mirroring
On 03/14/2013 08:36 PM, Erik Moeller wrote: And I wouldn't be too quick to celebrate the increased vendor lock-in of a large percentage of the open source community into an ecosystem of partially proprietary tools and services (the GitHub engine itself, the official GitHub applications, etc.). Gerrit and other open source git repo management and code review tools are one of the best hopes for the development of a viable alternative. Unlike GitHub, Gerrit can be improved by its users over time, and the issues that frustrate and annoy us about it _can_ be fixed (and indeed, many have been). Yes to better pull request management from GitHub. But let's stop complaining about Gerrit, and instead get both functionality and UX issues into their bug tracker, and help get them fixed. Erik That's a good argument. Someone mentioned GitLab though. If I have more time I'll go again through the list of our requirements and what it offers. -- Juliusz ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Github/Gerrit mirroring
On 03/09/2013 01:06 PM, Tyler Romeo wrote: I strongly disagree that Gerrit is harder to learn than Github. The only difficult thing to understand is the web UI, which takes only a few minutes to really get used to. Let's look at the biggest complaints: Let's not forget about this one: ...forces a *one commit at a time* workflow on developers and forces the use of |git commit --amend| as the only way to update patches. [1] For me this breaks the purpose of branches. [1] http://www.mediawiki.org/wiki/Git/Gerrit_evaluation#The_case_against_Gerrit -- Juliusz ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Github/Gerrit mirroring
On 03/08/2013 10:20 AM, Bartosz Dziewoński wrote: On Fri, 08 Mar 2013 17:07:18 +0100, Antoine Musso hashar+...@free.fr wrote: I guess the whole idea of using GitHub is for public relation and to attract new people. Then, if a developer is not willing to learn Gerrit, its code is probably not worth the effort of us integrating github/gerrit. That will just add some more poor quality code to your review queues. This a hundred times. I manage a few (small) open-source projects at GitHub, and most of the patches I get are not even up to my standards (and those are significantly lower than WMF's ones). Submitting a patch to gerrit and even fixing it after code review is not that hard. (Of course any more complicated operations like rebasing do suck, but you hopefully won't be doing that with your first patch.) I strongly disagree with this. I also get some poor quality pull requests to my projects on GitHub, but once in a while I get something good. To be honest, if I hadn't worked at WMF I'd have never thought about learning something as obscure as gerrit just to submit a small patch. And I wouldn't assume that without knowing the project well anyone would want to contribute something big. My reasoning: people get involved in open source projects by starting with a small contribution and if we don't make it easy for them, they just won't try. -- Juliusz ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Github/Gerrit mirroring
On 03/08/2013 08:55 AM, Andrew Otto wrote: I've been hosting my puppet-cdh4 (Hadoop) repository on Github for a while now. I am planning on moving this into Gerrit. I've been getting pretty high quality pull requests for the last month or so from a couple of different users. (Including CentOS support, supporting MapReduce v1 as well as YARN, etc.) https://github.com/wikimedia/puppet-cdh4/issues?page=1state=closed I'm happy to host this in Gerrit, but I suspect that contribution to this project will drop once I do. :/ Why do you want to move it to gerrit then? -- Juliusz ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Github/Gerrit mirroring
I've been hosting my puppet-cdh4 (Hadoop) repository on Github for a while now. I am planning on moving this into Gerrit. Why do you want to move it to gerrit then? Security reasons. All puppet repos have to be hosted by WMF and reviewed by ops before we can use it in production. On Mar 14, 2013, at 4:11 PM, Juliusz Gonera jgon...@wikimedia.org wrote: On 03/08/2013 08:55 AM, Andrew Otto wrote: I've been hosting my puppet-cdh4 (Hadoop) repository on Github for a while now. I am planning on moving this into Gerrit. I've been getting pretty high quality pull requests for the last month or so from a couple of different users. (Including CentOS support, supporting MapReduce v1 as well as YARN, etc.) https://github.com/wikimedia/puppet-cdh4/issues?page=1state=closed I'm happy to host this in Gerrit, but I suspect that contribution to this project will drop once I do. :/ Why do you want to move it to gerrit then? -- Juliusz ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Github/Gerrit mirroring
Can we please be real here? The reason more contributors come in through GitHub than through Gerrit is because they *already have a GitHub account*. My browser is always logged into GitHub, and it's at the point where I can casually just fork a project and begin working on it, whereas with Gerrit you need to request an account. Like I said before, if you know how to use Git, you know how to use Gerrit (and the contra-positive is true as well). The primary thing holding people back is that it's confusing and not user friendly enough to make an account and get working. Imagine if people could sign into Gerrit using their Google accounts like Phabricator allows. I can guarantee participation would skyrocket. *--* *Tyler Romeo* Stevens Institute of Technology, Class of 2015 Major in Computer Science www.whizkidztech.com | tylerro...@gmail.com ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Github/Gerrit mirroring
On 03/14/2013 07:19 PM, Tyler Romeo wrote: Like I said before, if you know how to use Git, you know how to use Gerrit (and the contra-positive is true as well). The primary thing holding people back is that it's confusing and not user friendly enough to make an account and get working. Imagine if people could sign into Gerrit using their Google accounts like Phabricator allows. I can guarantee participation would skyrocket. I wouldn't be that optimistic, maybe it would slightly increase. Having an account is one of the factors but I wouldn't underestimate user friendliness. The first time I tried to find the URL to clone a repo in gerrit it took me probably around a minute. On GitHub it probably took me 5 seconds. -- Juliusz ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Github/Gerrit mirroring
On 2013-03-14 11:20 PM, Tyler Romeo tylerro...@gmail.com wrote: Can we please be real here? The reason more contributors come in through GitHub than through Gerrit is because they *already have a GitHub account*. My browser is always logged into GitHub, and it's at the point where I can casually just fork a project and begin working on it, whereas with Gerrit you need to request an account. Like I said before, if you know how to use Git, you know how to use Gerrit (and the contra-positive is true as well). The primary thing holding people back is that it's confusing and not user friendly enough to make an account and get working. Imagine if people could sign into Gerrit using their Google accounts like Phabricator allows. I can guarantee participation would skyrocket. *--* *Tyler Romeo* Stevens Institute of Technology, Class of 2015 Major in Computer Science www.whizkidztech.com | tylerro...@gmail.com ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l I can state from personal experiance that creating an account was not the hard part (particularly because I had my account created for me ;) and there definitly was a hard part learning gerrit. I have no idea how easy/hard it is to do things on github as I don't have an account there but at the very least they probably have more usability engineers than gerrit has. Svn had a much harder account creation procedure, but I personally felt the learning curve was much lower (or maybe I wss just more familar with the ideas involved.) Anyhow, point of this ramble: gerrit is difficult for newbies (or at least when I was. Many others have said similar things). Well we certainly want to keep gerrit, its important to recognize this and mitigate the difficulties where it is reasonable to do so. -bawolff ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Github/Gerrit mirroring
On Fri, Mar 15, 2013 at 12:19 PM, Tyler Romeo tylerro...@gmail.com wrote: Can we please be real here? The reason more contributors come in through GitHub than through Gerrit is because they *already have a GitHub account*. My browser is always logged into GitHub, ?!? Unless you magically had a account created for you at GitHub that logic fails. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Github/Gerrit mirroring
On Thu, Mar 14, 2013 at 7:46 PM, Juliusz Gonera jgon...@wikimedia.org wrote: I wouldn't be that optimistic, maybe it would slightly increase. Having an account is one of the factors but I wouldn't underestimate user friendliness. The first time I tried to find the URL to clone a repo in gerrit it took me probably around a minute. On GitHub it probably took me 5 seconds. And I wouldn't be too quick to celebrate the increased vendor lock-in of a large percentage of the open source community into an ecosystem of partially proprietary tools and services (the GitHub engine itself, the official GitHub applications, etc.). Gerrit and other open source git repo management and code review tools are one of the best hopes for the development of a viable alternative. Unlike GitHub, Gerrit can be improved by its users over time, and the issues that frustrate and annoy us about it _can_ be fixed (and indeed, many have been). Yes to better pull request management from GitHub. But let's stop complaining about Gerrit, and instead get both functionality and UX issues into their bug tracker, and help get them fixed. Erik -- Erik Möller VP of Engineering and Product Development, Wikimedia Foundation Support Free Knowledge: https://wikimediafoundation.org/wiki/Donate ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Github/Gerrit mirroring
This thread has probably reached that limit of fresh arguments. Can we continue with proper documentation, reporting and patches? We care about GitHub and we believe it is an important source of potential contributors. This is why we are mirroring our repos there, and this is why we are working on Bug 35497 - Implement a way to bring GitHub pull requests into Gerrit https://bugzilla.wikimedia.org/show_bug.cgi?id=35497 If you want to improve the path from GitHub to Gerrit please contribute to that bug report or e.g. in a landing page (at mediawiki.org or github.com) to help GitHub users interested in our projects. About the Gerrit UI, if you have specific complaints or enhancement requests please file them. We have been upstreaming reports and also patches. We are surely not the only Gerrit users thinking that GitHub does some things better so there is hope. But saying it's ugly doesn't help. On 03/09/2013 01:06 PM, Tyler Romeo wrote: - Registration - The only thing that is probably a problem. We need to make Gerrit registration easier. What are the bottlenecks nowadays? If there are still any please file bugs. -- Quim Gil Technical Contributor Coordinator @ Wikimedia Foundation http://www.mediawiki.org/wiki/User:Qgil ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Github/Gerrit mirroring
Dan Andreescu dandree...@wikimedia.org wrote: [...] The point I'm trying to make is that the problems with Gerrit are not problems with Gerrit, but actually problems with Git itself. If you can't handle the basics of Gerrit, it's because you don't know how to use Git. And at that point I don't see how GitHub is going to make things that much easier anyway. ACK. Also I think, if you have mastered the MediaWiki code- base to a degree where you can submit a patch, its actual submission will be the least problem you've encountered :-). I disagree and I have a very simple counter-point. Gerrit makes it basically impossible to work in a git-flow style ( http://nvie.com/posts/a-successful-git-branching-model/). From what I understand, rebasing and good branching strategies like git-flow simply don't get along. [...] You're changing topics here. Tyler addressed the question whether a contributor knows how to use Git, you whether he is content with MediaWiki's development workflow. A con- tributor couldn't even participate in the latter's discus- sion if he isn't a (rather experienced) Git user. I seri- ously doubt that developers can't submit their patches just because MediaWiki uses master for development and not next or pu or develop or ... Tim ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Github/Gerrit mirroring
On Sat, Mar 9, 2013 at 8:39 PM, Ryan Lane rlan...@gmail.com wrote: On Sat, Mar 9, 2013 at 12:15 PM, Yuri Astrakhan yuriastrak...@gmail.com wrote: Should we re-start the lets migrate to github discussion? No. To be fair, though I understand the arguments against using github (though accepting pull requests from it is a must!), I always had the impression that other options weren't given enough attention during that discussion. Particularly GitLab looked very usable, could be used for self-hosting, etc., and never even got much content in the case against section (only two items, both currently marked as no longer true). I am not entirely sure why it was discarded so promptly in favor of the admittedly powerful, but clearly problematic/controversial Gerrit. Are there strong reasons do dismiss it that weren't stated in that page? --Waldir ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Github/Gerrit mirroring
On Sun, Mar 10, 2013 at 8:55 AM, Waldir Pimenta wal...@email.com wrote: Are there strong reasons do dismiss it that weren't stated in that page? Sorry, forgot the link: http://www.mediawiki.org/wiki/Git/Gerrit_evaluation#GitLab ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Github/Gerrit mirroring
On Sun, Mar 10, 2013 at 12:06 AM, Dan Andreescu dandree...@wikimedia.orgwrote: I disagree and I have a very simple counter-point. Gerrit makes it basically impossible to work in a git-flow style ( http://nvie.com/posts/a-successful-git-branching-model/ ). From what I understand, rebasing and good branching strategies like git-flow simply don't get along. This is not true. The purpose of git-rebase is very clear and outlined. It's something you use *before* you implement branching strategies. In other words, you're supposed to work on a feature in a branch, and right before you push your branch to a remote, you fetch origin and rebase on master so that all conflicts are resolved. Only then does branching and anything else matter. Also, in a project like MediaWiki, where numerous individual contributors are submitting patches rather than a small set of trusted employees, a model where the maintainer is responsible for resolving conflicts in merges is simply not feasible. To be fair, though I understand the arguments against using github (though accepting pull requests from it is a must!), I always had the impression that other options weren't given enough attention during that discussion. Particularly GitLab looked very usable, could be used for self-hosting, etc., and never even got much content in the case against section (only two items, both currently marked as no longer true). I am not entirely sure why it was discarded so promptly in favor of the admittedly powerful, but clearly problematic/controversial Gerrit. Are there strong reasons do dismiss it that weren't stated in that page? What's the difference between GitHub's and GitLab's merge request workflow? *--* *Tyler Romeo* Stevens Institute of Technology, Class of 2015 Major in Computer Science www.whizkidztech.com | tylerro...@gmail.com ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Github/Gerrit mirroring
On Sun, Mar 10, 2013 at 12:55 AM, Waldir Pimenta wal...@email.com wrote: On Sat, Mar 9, 2013 at 8:39 PM, Ryan Lane rlan...@gmail.com wrote: On Sat, Mar 9, 2013 at 12:15 PM, Yuri Astrakhan yuriastrak...@gmail.com wrote: Should we re-start the lets migrate to github discussion? No. To be fair, though I understand the arguments against using github (though accepting pull requests from it is a must!), I always had the impression that other options weren't given enough attention during that discussion. Particularly GitLab looked very usable, could be used for self-hosting, etc., and never even got much content in the case against section (only two items, both currently marked as no longer true). I am not entirely sure why it was discarded so promptly in favor of the admittedly powerful, but clearly problematic/controversial Gerrit. Are there strong reasons do dismiss it that weren't stated in that page? Let's please not start the giant flamewar of solutions again. We went through a fairly long and fairly difficult process just to continue using Gerrit. If you feel strongly about this, I'll create a project in Labs, and you can prove that it's worth switching to. Remember to use the evaluation process we already went through http://www.mediawiki.org/wiki/Git/Gerrit_evaluation#Criteria_by_which_to_judge_a_code_review_tool and also consider there's probably a giant list of things that we've added into Gerrit since then. Remember that if something uses about 100 ruby gems that ops will want to skin you alive, even if it's a superior solution. - Ryan ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Github/Gerrit mirroring
Hi, all! Then, if a developer is not willing to learn Gerrit, its code is probably not worth the effort of integrating github/gerrit. That will just add some more poor quality code to you review queues. Submitting a patch to gerrit and even fixing it after code review is not that hard. (Of course any more complicated operations like rebasing do suck, but you hopefully won't be doing that with your first patch.) If I may, I'd like to respectfully disagree with these statements. For context, I'm a new Mediawiki developer who got a labs/Gerrit/LDAP account late last Fall. Since that time, I've submitted exactly five patches. Of those five, two were abandoned, once because Gerrit screwed up big time and once because someone merged another patch that superseded mine. Two have been merged, both were minor English translation changes. One is still sitting, waiting for me to re-base (It was my third patch… I'm scared to re-base because I don't want to screw something up). I did have to re-base on my first patch, thankfully; someone walked me through the process on IRC. I double-checked my code for consistency in all major browsers; in OSX, Ubuntu linux, and Windows; read and re-read the style guidelines. I can confidently say it was not poor quality. So, why am I not trying to learn Gerrit or try to submit patches? Because it's not worth my time. The interface is so far outside of what I'm used to, and it's just so touchy. By comparison, GitHub has a solid, no frills, Mac app that handles all of the important stuff. And, even when I committed to GitHub by command line, there was no way I could Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/mediawiki/core by miss-typing a re-base https://gerrit.wikimedia.org/r/#/c/37684/. So, having GitHub is almost essential for folks who don't want to - or can't - understand or work with Gerrit. And closing off GitHub (or viewing their patches as poor quality) will close of developers - like be - who are having trouble with Gerrit. Just my two cents. Thanks for reading. Matthew Bowker http://en.wikipedia.org/wiki/User:Matthewrbowker On Mar 8, 2013, at 11:20 AM, Bartosz Dziewoński matma@gmail.com wrote: On Fri, 08 Mar 2013 17:07:18 +0100, Antoine Musso hashar+...@free.fr wrote: I guess the whole idea of using GitHub is for public relation and to attract new people. Then, if a developer is not willing to learn Gerrit, its code is probably not worth the effort of us integrating github/gerrit. That will just add some more poor quality code to your review queues. This a hundred times. I manage a few (small) open-source projects at GitHub, and most of the patches I get are not even up to my standards (and those are significantly lower than WMF's ones). Submitting a patch to gerrit and even fixing it after code review is not that hard. (Of course any more complicated operations like rebasing do suck, but you hopefully won't be doing that with your first patch.) -- Matma Rex ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Github/Gerrit mirroring
Should we re-start the lets migrate to github discussion? P.S. no, this is not a troll attempt, I am trying to understand if the costs of not getting quality volunteers is worth the benefits of gerrit, or if the two-system solution would solve all perceived complexities. Moreover, I do not know github well enough to even suggest one over the other. On Sat, Mar 9, 2013 at 3:04 PM, Matthew Bowker matthewrbowker.w...@me.comwrote: Hi, all! Then, if a developer is not willing to learn Gerrit, its code is probably not worth the effort of integrating github/gerrit. That will just add some more poor quality code to you review queues. Submitting a patch to gerrit and even fixing it after code review is not that hard. (Of course any more complicated operations like rebasing do suck, but you hopefully won't be doing that with your first patch.) If I may, I'd like to respectfully disagree with these statements. For context, I'm a new Mediawiki developer who got a labs/Gerrit/LDAP account late last Fall. Since that time, I've submitted exactly five patches. Of those five, two were abandoned, once because Gerrit screwed up big time and once because someone merged another patch that superseded mine. Two have been merged, both were minor English translation changes. One is still sitting, waiting for me to re-base (It was my third patch… I'm scared to re-base because I don't want to screw something up). I did have to re-base on my first patch, thankfully; someone walked me through the process on IRC. I double-checked my code for consistency in all major browsers; in OSX, Ubuntu linux, and Windows; read and re-read the style guidelines. I can confidently say it was not poor quality. So, why am I not trying to learn Gerrit or try to submit patches? Because it's not worth my time. The interface is so far outside of what I'm used to, and it's just so touchy. By comparison, GitHub has a solid, no frills, Mac app that handles all of the important stuff. And, even when I committed to GitHub by command line, there was no way I could Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/mediawiki/core by miss-typing a re-base https://gerrit.wikimedia.org/r/#/c/37684/. So, having GitHub is almost essential for folks who don't want to - or can't - understand or work with Gerrit. And closing off GitHub (or viewing their patches as poor quality) will close of developers - like be - who are having trouble with Gerrit. Just my two cents. Thanks for reading. Matthew Bowker http://en.wikipedia.org/wiki/User:Matthewrbowker On Mar 8, 2013, at 11:20 AM, Bartosz Dziewoński matma@gmail.com wrote: On Fri, 08 Mar 2013 17:07:18 +0100, Antoine Musso hashar+...@free.fr wrote: I guess the whole idea of using GitHub is for public relation and to attract new people. Then, if a developer is not willing to learn Gerrit, its code is probably not worth the effort of us integrating github/gerrit. That will just add some more poor quality code to your review queues. This a hundred times. I manage a few (small) open-source projects at GitHub, and most of the patches I get are not even up to my standards (and those are significantly lower than WMF's ones). Submitting a patch to gerrit and even fixing it after code review is not that hard. (Of course any more complicated operations like rebasing do suck, but you hopefully won't be doing that with your first patch.) -- Matma Rex ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Github/Gerrit mirroring
On Sat, Mar 9, 2013 at 12:15 PM, Yuri Astrakhan yuriastrak...@gmail.comwrote: Should we re-start the lets migrate to github discussion? No. - Ryan ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Github/Gerrit mirroring
On 2013-03-08 2:20 PM, Bartosz Dziewoński matma@gmail.com wrote: On Fri, 08 Mar 2013 17:07:18 +0100, Antoine Musso hashar+...@free.fr wrote: I guess the whole idea of using GitHub is for public relation and to attract new people. Then, if a developer is not willing to learn Gerrit, its code is probably not worth the effort of us integrating github/gerrit. That will just add some more poor quality code to your review queues. This a hundred times. I manage a few (small) open-source projects at GitHub, and most of the patches I get are not even up to my standards (and those are significantly lower than WMF's ones). Submitting a patch to gerrit and even fixing it after code review is not that hard. (Of course any more complicated operations like rebasing do suck, but you hopefully won't be doing that with your first patch.) -- Matma Rex ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l Making it easier to contribute is always going to cause more lower quality content to be submitted, since the unmotivated arent weeded out. But there are plenty of good people that also would get weeded out. I think this debate has a lot in common with the perenial debates on wikipedia to futher restrict anons and non autoconfirmed users. -bawolff ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Github/Gerrit mirroring
Yes, lots of bad content might be submitted, but usually it is easy and quick to spot, and could become good content over time. What I think we should follow is the model that most other big open source projects follow, which does seem to have lower barrier of entry. On Sat, Mar 9, 2013 at 3:51 PM, Brian Wolff bawo...@gmail.com wrote: On 2013-03-08 2:20 PM, Bartosz Dziewoński matma@gmail.com wrote: On Fri, 08 Mar 2013 17:07:18 +0100, Antoine Musso hashar+...@free.fr wrote: I guess the whole idea of using GitHub is for public relation and to attract new people. Then, if a developer is not willing to learn Gerrit, its code is probably not worth the effort of us integrating github/gerrit. That will just add some more poor quality code to your review queues. This a hundred times. I manage a few (small) open-source projects at GitHub, and most of the patches I get are not even up to my standards (and those are significantly lower than WMF's ones). Submitting a patch to gerrit and even fixing it after code review is not that hard. (Of course any more complicated operations like rebasing do suck, but you hopefully won't be doing that with your first patch.) -- Matma Rex ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l Making it easier to contribute is always going to cause more lower quality content to be submitted, since the unmotivated arent weeded out. But there are plenty of good people that also would get weeded out. I think this debate has a lot in common with the perenial debates on wikipedia to futher restrict anons and non autoconfirmed users. -bawolff ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Github/Gerrit mirroring
So, why am I not trying to learn Gerrit or try to submit patches? Because it's not worth my time. The interface is so far outside of what I'm used to, and it's just so touchy. By comparison, GitHub has a solid, no frills, Mac app that handles all of the important stuff. And, even when I committed to GitHub by command line, there was no way I could Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/mediawiki/core by miss-typing a re-base https://gerrit.wikimedia.org/r/#/c/37684/. Thank you for sharing this view. This was my fear and it is useful to get this view. To me I would be happy having more contributions regardless of quality. A contribution in itself is wonderful as it shows an interest in the work that is being done and a will to help with that work. We should be striving to mentor any developer who contributes poor quality code not see this as a negative thing. To me this is what is so beautiful about open source development - we get the opportunity to create awesome things and create awesome developers. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Github/Gerrit mirroring
I strongly disagree that Gerrit is harder to learn than Github. The only difficult thing to understand is the web UI, which takes only a few minutes to really get used to. Let's look at the biggest complaints: - Submitting patchsets is hard - Install git-review and then just replace the git push command with git review. If anything, this is significantly easier than Github, which requires forking, cloning, pushing, and pull requesting. - Developers don't understand rebasing - This is not a Gerrit thing. Rebasing in Git is an essential feature that anybody who uses Git should know how to use, even if on Github. Why? Because git-rebase is the only way to submit a change in a way that it can be merged without conflicts. If you submit a pull request on Github without rebasing first, you're just putting work onto the maintainer to resolve your merge conflicts, possibly resulting in a breakage on master. - Registration - The only thing that is probably a problem. We need to make Gerrit registration easier. The point I'm trying to make is that the problems with Gerrit are not problems with Gerrit, but actually problems with Git itself. If you can't handle the basics of Gerrit, it's because you don't know how to use Git. And at that point I don't see how GitHub is going to make things that much easier anyway. *--* *Tyler Romeo* Stevens Institute of Technology, Class of 2015 Major in Computer Science www.whizkidztech.com | tylerro...@gmail.com ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Github/Gerrit mirroring
On Mar 9, 2013 12:39 PM, Ryan Lane rlan...@gmail.com wrote: On Sat, Mar 9, 2013 at 12:15 PM, Yuri Astrakhan yuriastrak...@gmail.com wrote: Should we re-start the lets migrate to github discussion? No. - Ryan I agree with what everyone has been saying about the barrier to entry with Gerrit being bad, but let's not talk migration. That's a rat hole. Let's talk about how to make submitting patches more attractive to people not already using Gerrit. Accepting GitHub pull requests is one. Any others? ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Github/Gerrit mirroring
On 2013-03-09 5:04 PM, Jon Robson jdlrob...@gmail.com wrote: So, why am I not trying to learn Gerrit or try to submit patches? Because it's not worth my time. The interface is so far outside of what I'm used to, and it's just so touchy. By comparison, GitHub has a solid, no frills, Mac app that handles all of the important stuff. And, even when I committed to GitHub by command line, there was no way I could Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/mediawiki/core by miss-typing a re-base https://gerrit.wikimedia.org/r/#/c/37684/. Thank you for sharing this view. This was my fear and it is useful to get this view. To me I would be happy having more contributions regardless of quality. A contribution in itself is wonderful as it shows an interest in the work that is being done and a will to help with that work. We should be striving to mentor any developer who contributes poor quality code not see this as a negative thing. To me this is what is so beautiful about open source development - we get the opportunity to create awesome things and create awesome developers. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l In theory you are right - more folks = more awesomeness. In practice this involves a lot of effort, effort that people often are not willing to put in. Just look at our rather poor history with bugzilla patches (although things have improved) Notwithstanding that, I still think we should reduce as many barriers as possible. Even if the ideal world mentoring is not there, at least more openness makes it more likely someone will figure stuff out themselves. -bawolff ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Github/Gerrit mirroring
In theory you are right - more folks = more awesomeness. In practice this involves a lot of effort, effort that people often are not willing to put in. Just look at our rather poor history with bugzilla patches (although things have improved) I see this as a good problem to have. On the short term yes more effort. On the long term if we do things right more people invested in the project, more people to deal with patches, more people with +2 etc etc... ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Github/Gerrit mirroring
Tyler Romeo tylerro...@gmail.com wrote: [...] The point I'm trying to make is that the problems with Gerrit are not problems with Gerrit, but actually problems with Git itself. If you can't handle the basics of Gerrit, it's because you don't know how to use Git. And at that point I don't see how GitHub is going to make things that much easier anyway. ACK. Also I think, if you have mastered the MediaWiki code- base to a degree where you can submit a patch, its actual submission will be the least problem you've encountered :-). Tim ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Github/Gerrit mirroring
[...] The point I'm trying to make is that the problems with Gerrit are not problems with Gerrit, but actually problems with Git itself. If you can't handle the basics of Gerrit, it's because you don't know how to use Git. And at that point I don't see how GitHub is going to make things that much easier anyway. ACK. Also I think, if you have mastered the MediaWiki code- base to a degree where you can submit a patch, its actual submission will be the least problem you've encountered :-). I disagree and I have a very simple counter-point. Gerrit makes it basically impossible to work in a git-flow style ( http://nvie.com/posts/a-successful-git-branching-model/). From what I understand, rebasing and good branching strategies like git-flow simply don't get along. I agree with Steven and Ryan about leaving the migrate to GitHub discussion closed. Gerrit is open source and it meets all of our needs. But it does create barriers of entry as shown above, in Jon's point, and in Matthew Bowker's experience (which I'm sure is not atypical). So I think we should be open to valid criticism and find out how we can lower the bar of entry. As for the argument that this will lower code quality, I think the burden of proof is on those making that assumption. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Github/Gerrit mirroring
On Sun, 10 Mar 2013 06:06:47 +0100, Dan Andreescu dandree...@wikimedia.org wrote: As for the argument that this will lower code quality, I think the burden of proof is on those making that assumption. You want me to link to patches created by contributors who have been carefully walked through the process of submitting something to gerrit? Because I can do that, but it would be a little demeaning. (I can even link some patches that were merged – and it took 30 patchsets, 5 reviewers and a month to do that – for a ten-line change...) -- Matma Rex ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Github/Gerrit mirroring
On Sun, Mar 10, 2013 at 1:08 AM, Bartosz Dziewoński matma@gmail.comwrote: You want me to link to patches created by contributors who have been carefully walked through the process of submitting something to gerrit? Because I can do that, but it would be a little demeaning. (I can even link some patches that were merged – and it took 30 patchsets, 5 reviewers and a month to do that – for a ten-line change...) I think I have seen that with experienced devs as well :) And the fact that the person stayed around for 30 patchsets is a testament that they will a) learn all our requirements, and b) are driven enough to be beneficial to MediaWiki in the long run and will see their projects to completion. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Github/Gerrit mirroring
Le 05/03/13 11:27, Krinkle a écrit : If all we do is immediately copy the PR, submit it to Gerrit and close the PR saying Please create a WMFLabs account, learn all of fucking Gerrit, and then continue on Gerrit to finalise the patch, then we should just kill PR now. That always has been my point. The code ultimately require to land in Gerrit so, to me, there is no point in using GitHub pull requests. I guess the whole idea of using GitHub is for public relation and to attract new people. Then, if a developer is not willing to learn Gerrit, its code is probably not worth the effort of us integrating github/gerrit. That will just add some more poor quality code to your review queues. -- Antoine hashar Musso ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Github/Gerrit mirroring
... Then, if a developer is not willing to learn Gerrit, its code is probably not worth the effort of us integrating github/gerrit. That will just add some more poor quality code to your review queues. That seems like a pretty big assumption, and likely to be wrong. The simpler the code review process, the happier people will be to submit patches. Quality seems independent from that, and more likely linked to the ease of validating patches (linting, unit test requirements, good style guides, etc). But that's just a guess. If deemed interesting, I would be glad to help quantify patch quality and analyze what helps to improve it. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Github/Gerrit mirroring
On 03/08/2013 08:31 AM, Dan Andreescu wrote: ... Then, if a developer is not willing to learn Gerrit, its code is probably not worth the effort of us integrating github/gerrit. That will just add some more poor quality code to your review queues. imho GitHub has the potential to get us a first patch from many contributors that won't arrive through gerrit.wikimedia.org first. It's just a lot simpler for GitHub users. Some of those patches will be good, some not so much, but that is probably also the case for first time contributors in Gerrit. When a developer submits a second and a third pull request via GitHub then we can politely invite her to check http://www.mediawiki.org/wiki/Gerrit and join our actual development process. -- Quim Gil Technical Contributor Coordinator @ Wikimedia Foundation http://www.mediawiki.org/wiki/User:Qgil ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Github/Gerrit mirroring
I've been hosting my puppet-cdh4 (Hadoop) repository on Github for a while now. I am planning on moving this into Gerrit. I've been getting pretty high quality pull requests for the last month or so from a couple of different users. (Including CentOS support, supporting MapReduce v1 as well as YARN, etc.) https://github.com/wikimedia/puppet-cdh4/issues?page=1state=closed I'm happy to host this in Gerrit, but I suspect that contribution to this project will drop once I do. :/ On Mar 8, 2013, at 11:47 AM, Quim Gil q...@wikimedia.org wrote: On 03/08/2013 08:31 AM, Dan Andreescu wrote: ... Then, if a developer is not willing to learn Gerrit, its code is probably not worth the effort of us integrating github/gerrit. That will just add some more poor quality code to your review queues. imho GitHub has the potential to get us a first patch from many contributors that won't arrive through gerrit.wikimedia.org first. It's just a lot simpler for GitHub users. Some of those patches will be good, some not so much, but that is probably also the case for first time contributors in Gerrit. When a developer submits a second and a third pull request via GitHub then we can politely invite her to check http://www.mediawiki.org/wiki/Gerrit and join our actual development process. -- Quim Gil Technical Contributor Coordinator @ Wikimedia Foundation http://www.mediawiki.org/wiki/User:Qgil ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Github/Gerrit mirroring
On 8 Mar 2013 10:47, Quim Gil q...@wikimedia.org wrote: On 03/08/2013 08:31 AM, Dan Andreescu wrote: ... Then, if a developer is not willing to learn Gerrit, its code is probably not worth the effort of us integrating github/gerrit. That will just add some more poor quality code to your review queues. imho GitHub has the potential to get us a first patch from many contributors that won't arrive through gerrit.wikimedia.org first. It's just a lot simpler for GitHub users. Some of those patches will be good, some not so much, but that is probably also the case for first time contributors in Gerrit. +1 to me the need to create a gerrit account is a huge barrier for entry. I think we are missing out on attracting small but useful patches from developers who are not heavily invested in the project and have no wish to become regular core contributors... When a developer submits a second and a third pull request via GitHub then we can politely invite her to check http://www.mediawiki.org/wiki/Gerrit and join our actual development process. -- Quim Gil Technical Contributor Coordinator @ Wikimedia Foundation http://www.mediawiki.org/wiki/User:Qgil ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Github/Gerrit mirroring
On Fri, 08 Mar 2013 17:07:18 +0100, Antoine Musso hashar+...@free.fr wrote: I guess the whole idea of using GitHub is for public relation and to attract new people. Then, if a developer is not willing to learn Gerrit, its code is probably not worth the effort of us integrating github/gerrit. That will just add some more poor quality code to your review queues. This a hundred times. I manage a few (small) open-source projects at GitHub, and most of the patches I get are not even up to my standards (and those are significantly lower than WMF's ones). Submitting a patch to gerrit and even fixing it after code review is not that hard. (Of course any more complicated operations like rebasing do suck, but you hopefully won't be doing that with your first patch.) -- Matma Rex ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Github/Gerrit mirroring
Le 08/03/13 09:21, Jon Robson a écrit : +1 to me the need to create a gerrit account is a huge barrier for entry. I think we are missing out on attracting small but useful patches from developers who are not heavily invested in the project and have no wish to become regular core contributors... Maybe Gerrit can be made to let one authenticate with its github account? -- Antoine hashar Musso ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Github/Gerrit mirroring
On Fri, Mar 8, 2013 at 11:50 AM, Antoine Musso hashar+...@free.fr wrote: Le 08/03/13 09:21, Jon Robson a écrit : +1 to me the need to create a gerrit account is a huge barrier for entry. I think we are missing out on attracting small but useful patches from developers who are not heavily invested in the project and have no wish to become regular core contributors... Maybe Gerrit can be made to let one authenticate with its github account? Nope. We use LDAP for auth with Gerrit, and it does not support having multiple authentication methods at the same time (nor do I really see it as worth the effort). Getting Github PR into the Gerrit ecosystem is on the Gerrit roadmap, but we don't have a firm date just yet. I plan to announce this much more widely when we're close to that. -Chad ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] Github/Gerrit mirroring
I was wondering what the latest on this was (I can't seem to find any recent updates in my mailing list). The MobileFrontend project was reassured to see a github user commenting on our commits in github. It's made me more excited about a universe where pull requests made in github show up in gerrit and can be merged. How close to this dream are we? ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Github/Gerrit mirroring
On Mar 5, 2013, at 6:39 PM, Jon Robson jdlrob...@gmail.com wrote: I was wondering what the latest on this was (I can't seem to find any recent updates in my mailing list). The MobileFrontend project was reassured to see a github user commenting on our commits in github. It's made me more excited about a universe where pull requests made in github show up in gerrit and can be merged. How close to this dream are we? I'm not sure to what extend we should make it show up in Gerrit. But there is https://bugzilla.wikimedia.org/show_bug.cgi?id=35497 Where it is explained that it is trivial to take a PR and submit it to Gerrit. Though one could write a tool to simplify it, there isn't much to simplify. Someone with access to Gerrit (anyone with a labs account) only has to: * Check it out locally. * Squash it[1] and amend with no modifications (just `git commit --amend -C HEAD`; which will trigger your git-review hook to add a Change-Id). * Push to Gerrit. If it is submitted as a pull request on GitHub, the communication with the author and revisions of the patch should be on GitHub. We only submit it to Gerrit once it is pretty much finalised. Otherwise the user is going to be unable to answer and act on the feedback. I assume the reason we are not disabling Pull requests, which is possible, is because we want this. If all we do is immediately copy the PR, submit it to Gerrit and close the PR saying Please create a WMFLabs account, learn all of fucking Gerrit, and then continue on Gerrit to finalise the patch, then we should just kill PR now. Instead we are going to have to have some people that participate in review on GitHub. Which, fortunately, is very open and much like on Gerrit. Anyone with a GitHub account can participate in review, anyone can take it and submit it to Gerrit. The only minor detail is closing the PR. When that happens and who that does. The who is clear, someone with write access to the Wikimedia GitHub account. The when, could be when it is taken to Gerrit, could be when it lands in master. -- Krinkle [1] Squash because on GitHub it is common to add commits and squash later (some projects don't even squash, it depends on whether they handle a policy where every commit in the master history should be good - either way, we do, so when a PR gets a commit added to it that fixes a syntax error, we should squash it in the process of preparing for Gerrit). ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Github/Gerrit mirroring
There's some upstream developers working on a github plugin. I was going to mention it once there was something worth showing (which there isn't yet). -Chad On Mar 5, 2013 9:39 AM, Jon Robson jdlrob...@gmail.com wrote: I was wondering what the latest on this was (I can't seem to find any recent updates in my mailing list). The MobileFrontend project was reassured to see a github user commenting on our commits in github. It's made me more excited about a universe where pull requests made in github show up in gerrit and can be merged. How close to this dream are we? ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
