[Wireshark-commits] master-3.0 643e3b0: Build 3.0.13.

2020-08-12 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=643e3b0f718685b3fa7008a0c5c4707daf63ca99 Submitter: "Gerald Combs " Changed: branch: master-3.0 Repository: wireshark Commits: 643e3b0 by Gerald Combs (ger...@wireshark.org): Build 3.0.13. Change-Id:

[Wireshark-commits] [wireshark] annotated tag wireshark-3.2.6 created (now 197ed3d)

2020-08-12 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=197ed3d7a19c4fab7a47198d64812d09f17b7747 Submitter: "Gerald Combs " Changed: annotated tag: wireshark-3.2.6 Repository: wireshark Commits: [ log message not found ] Actions performed: at 197ed3d (tag) tagging

[Wireshark-commits] [wireshark] annotated tag v3.2.6 created (now b182b2f)

2020-08-12 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b182b2f43850e8a0b388ecdf0aef0ffac7d0f9da Submitter: "Gerald Combs " Changed: annotated tag: v3.2.6 Repository: wireshark Commits: [ log message not found ] Actions performed: at b182b2f (tag) tagging

[Wireshark-commits] master-3.2 4f9257f: Build 3.2.6.

2020-08-12 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4f9257fb8ccce92b519d87c4cc905107ae09b5e9 Submitter: "Gerald Combs " Changed: branch: master-3.2 Repository: wireshark Commits: 4f9257f by Gerald Combs (ger...@wireshark.org): Build 3.2.6. Change-Id:

[Wireshark-commits] master 395ac51: Fix some cases where item mask was wider than item type.

2020-08-12 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=395ac51703b235b4344d396dd01ce8345dde294f Submitter: "Martin Mathieson " Changed: branch: master Repository: wireshark Commits: 395ac51 by Martin Mathieson (martin.mathie...@keysight.com): Fix some cases where item

[Wireshark-commits] master 2d74b5c: EPL: modified timestamp format of errorcodelist

2020-08-12 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2d74b5c9b0838e3a098ad912608cfe959a77f389 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 2d74b5c by Christian Krump (christian.kr...@br-automation.com): EPL: modified timestamp

[Wireshark-commits] master ebf3d6d: Try to fix -Wpointer-sign warnings.

2020-08-12 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ebf3d6dbf1b3684fcd8f40c0de87498a9810bc74 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: ebf3d6d by Anders Broman (anders.bro...@ericsson.com): Try to fix -Wpointer-sign warnings.

[Wireshark-commits] master 057d50b: NR LTE: add dissection of capabilityRequestFilter for EUTRA and EUTRA-NR RATs

2020-08-12 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=057d50bfdf7cf100db40eb50a1912345ab39ca4f Submitter: "Pascal Quantin " Changed: branch: master Repository: wireshark Commits: 057d50b by Pascal Quantin (pas...@wireshark.org): NR LTE: add dissection of

[Wireshark-commits] master 7c7f576: For a zero time stamp preserve the base time but put "(0)" in front.

2020-08-12 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7c7f5765d3276d2722fc175e47c6f2fb9e942fa3 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 7c7f576 by Anders Broman (anders.bro...@ericsson.com): For a zero time stamp preserve the

[Wireshark-commits] master efd7cb3: doc: explain when to use FT_STRINGZ, and document FT_STRINGZPAD.

2020-08-12 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=efd7cb38e67cbfda8c2fd4bc47aaec4ba83c Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: efd7cb3 by Guy Harris (ghar...@sonic.net): doc: explain when to use FT_STRINGZ, and document

[Wireshark-commits] master 9eddbda: Don't give a zero-length FT_STRINGZ a special value.

2020-08-12 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9eddbdafa975f9c3bafec9e1d2f5f52469a10a28 Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: 9eddbda by Guy Harris (ghar...@sonic.net): Don't give a zero-length FT_STRINGZ a special value.

[Wireshark-commits] master 3e9bf7d: MQ: use FT_STRING, not FT_STRINGZ, for strings.

2020-08-12 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3e9bf7d7cb568281e480a5ac40ba075321b7e585 Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: 3e9bf7d by Guy Harris (ghar...@sonic.net): MQ: use FT_STRING, not FT_STRINGZ, for strings.

[Wireshark-commits] master 9c1a55a: RPC: partially dissect GSS NFS truncated packets

2020-08-12 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9c1a55a5ae1db446934ce8a4ab33bfdfb45f320c Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 9c1a55a by Jorge Mora (jmora1...@gmail.com): RPC: partially dissect GSS NFS truncated packets

[Wireshark-commits] master bf91124: packet-stun.c: Add decoding of PASSWORD_ALGORITHM(S)

2020-08-12 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bf9112445885951c0be121edbf9ed90b7bf3d037 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: bf91124 by Joerg Mayer (jma...@loplof.de): packet-stun.c: Add decoding of

[Wireshark-commits] master 2ce378f: packet_xml: detect and handle UTF-16 BOM

2020-08-12 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2ce378f8ab92e6c8d87b9472033a641ea98d3e80 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 2ce378f by David Perry (boolean...@protonmail.com): packet_xml: detect and handle UTF-16 BOM

[Wireshark-commits] master dae7f76: tacacs: various fixes and cleanups.

2020-08-11 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=dae7f769e8b6f3afc46a28bac5ab6c3449b870e5 Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: dae7f76 by Guy Harris (ghar...@sonic.net): tacacs: various fixes and cleanups. Update

[Wireshark-commits] master-3.2 d4a2705: Prep for 3.2.6.

2020-08-11 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d4a2705fc04c6546758df22539d4aaa829ddbb0e Submitter: "Gerald Combs " Changed: branch: master-3.2 Repository: wireshark Commits: d4a2705 by Gerald Combs (ger...@wireshark.org): Prep for 3.2.6. Change-Id:

[Wireshark-commits] master-3.0 a0a1c84: Prep for 3.0.13.

2020-08-11 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a0a1c8424c7300d3e6ac5d4637b6bb68fd22477b Submitter: "Gerald Combs " Changed: branch: master-3.0 Repository: wireshark Commits: a0a1c84 by Gerald Combs (ger...@wireshark.org): Prep for 3.0.13. Change-Id:

[Wireshark-commits] master-2.6 1caf550: Prep for 2.6.19.

2020-08-11 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1caf5502a24ed47000e97d0dbbcf7238f38923c7 Submitter: "Gerald Combs " Changed: branch: master-2.6 Repository: wireshark Commits: 1caf550 by Gerald Combs (ger...@wireshark.org): Prep for 2.6.19. Change-Id:

[Wireshark-commits] master-3.2 ced45c9: kafka: zstd: free the composite tvb only once

2020-08-11 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ced45c939878f91b47527a0ca5c281fa4e46741a Submitter: "Gerald Combs " Changed: branch: master-3.2 Repository: wireshark Commits: ced45c9 by Martin Kaiser (wiresh...@kaiser.cx): kafka: zstd: free the composite tvb only

[Wireshark-commits] master-3.2 fa44fec: kafka: snappy: free the composite tvb only once

2020-08-11 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fa44fec9d31f556fe7d5848c82da45f0b8f9ee48 Submitter: "Gerald Combs " Changed: branch: master-3.2 Repository: wireshark Commits: fa44fec by Martin Kaiser (wiresh...@kaiser.cx): kafka: snappy: free the composite tvb only

[Wireshark-commits] master-2.6 464dd60: Revert "dicom: when exporting objects, don't assume we have the AE titles."

2020-08-11 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=464dd60506d251217b92811fa41356721d0b1a02 Submitter: "Guy Harris " Changed: branch: master-2.6 Repository: wireshark Commits: 464dd60 by Guy Harris (ghar...@sonic.net): Revert "dicom: when exporting objects, don't

[Wireshark-commits] master-3.0 9aaf08c: Revert "dicom: when exporting objects, don't assume we have the AE titles."

2020-08-11 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9aaf08c42621dbbb52dd026d4ecc5cc55545af84 Submitter: "Guy Harris " Changed: branch: master-3.0 Repository: wireshark Commits: 9aaf08c by Guy Harris (ghar...@sonic.net): Revert "dicom: when exporting objects, don't

[Wireshark-commits] master b1753ce: Qt: Add debugging ifdefs for the packet diagram.

2020-08-11 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b1753ce51161007f1b0f4c210d7ed273291824a9 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: b1753ce by Gerald Combs (ger...@wireshark.org): Qt: Add debugging ifdefs for the packet

[Wireshark-commits] master a72e415: For a zero time stamp don't print the EPOCH, print NULL.

2020-08-11 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a72e4154510a2a535945e83766fab2550539dbfd Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: a72e415 by Anders Broman (anders.bro...@ericsson.com): For a zero time stamp don't print the

[Wireshark-commits] master a582672: lithionics: use ws_strtou32() and ws_hexstrtou32() to convert strings.

2020-08-11 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a582672d6f9bf5706849ccbb7da49f02066552af Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: a582672 by Guy Harris (ghar...@sonic.net): lithionics: use ws_strtou32() and ws_hexstrtou32() to

[Wireshark-commits] master 2db3708: Add Lithionics battery management dissector.

2020-08-10 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2db3708dfd649bd71ea2c9c759eefdf28325f7ab Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 2db3708 by Michael Mann (michael.m...@jbtc.com): Add Lithionics battery management dissector.

[Wireshark-commits] master c207518: epan: Fixup proto_item_set_bits_offset_len.

2020-08-10 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c2075185de7e253e00f2722c841a3ac14cc4063c Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: c207518 by Gerald Combs (ger...@wireshark.org): epan: Fixup proto_item_set_bits_offset_len.

[Wireshark-commits] master fed91de: ssh: make fields for string types FT_STRING rather than FT_STRINGZ.

2020-08-10 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fed91de7a158a9fac68873eef4d02968eb2f326b Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: fed91de by Guy Harris (ghar...@sonic.net): ssh: make fields for string types FT_STRING rather

[Wireshark-commits] master d5fe2d4: wsutil: define HAVE_LIBGCRYPT_AEAD in wsutil/wsgcrypt.h.

2020-08-10 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d5fe2d494c6475263b954a36812b888b11e1a50b Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: d5fe2d4 by Guy Harris (ghar...@sonic.net): wsutil: define HAVE_LIBGCRYPT_AEAD in

[Wireshark-commits] master 151ee60: http3: fix build without support for AEAD cipher suites.

2020-08-10 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=151ee605559ac0d61eb8618a75985772c57dbfa8 Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: 151ee60 by Guy Harris (ghar...@sonic.net): http3: fix build without support for AEAD cipher

[Wireshark-commits] master c462f72: IEEE802.11: WAN Metrics Length Check Update

2020-08-10 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c462f72273addac3821d40f9c236b8bb593b890f Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: c462f72 by Matthew Weant (mswe...@gmail.com): IEEE802.11: WAN Metrics Length Check Update

[Wireshark-commits] master 48a6ea0: ssh: don't crash when computing hash.

2020-08-10 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=48a6ea0e05a7637da1dfb6e6acefd64ae0349de5 Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: 48a6ea0 by Guy Harris (ghar...@sonic.net): ssh: don't crash when computing hash.

[Wireshark-commits] master 9b07412: Qt: Add a packet diagram view.

2020-08-10 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9b07412277b4436b30410bd07e9cb8ee0b88ddb2 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 9b07412 by Gerald Combs (ger...@wireshark.org): Qt: Add a packet diagram view. Add a

[Wireshark-commits] master e846d23: QUIC: fix compile without LIBGCRYPT_AEAD

2020-08-10 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e846d238d7194188e211de7d7cacc531f388a183 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: e846d23 by Joakim Karlsson (oak...@gmail.com): QUIC: fix compile without LIBGCRYPT_AEAD

[Wireshark-commits] master 0cce968: GTPv2: validate length of PDN Address Allocation (PAA) IE

2020-08-10 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0cce968634b30145ab9670f4855dd718128578e4 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 0cce968 by Andreas Schultz (andreas.schu...@travelping.com): GTPv2: validate length of PDN

[Wireshark-commits] master 2364968: Bluetooth: simple HCI ISO Data packet dissector

2020-08-10 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2364968cd652b5d45785f6c69bd24e8b6c3d56db Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 2364968 by Jakub Pawlowski (jpawlow...@google.com): Bluetooth: simple HCI ISO Data packet

[Wireshark-commits] master d7f7b62: OBEX: Fix mismatching API/item-type for some subtree items.

2020-08-10 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d7f7b62ef3d226e2efcef140fefe52536090b7b6 Submitter: "Martin Mathieson " Changed: branch: master Repository: wireshark Commits: d7f7b62 by Martin Mathieson (martin.mathie...@keysight.com): OBEX: Fix mismatching

[Wireshark-commits] master e43e6e6: ieee80211: add radiotap TX flags

2020-08-10 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e43e6e689793620ae1b4ab08830f903aed54d586 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: e43e6e6 by Mathy Vanhoef (mathy.vanh...@nyu.edu): ieee80211: add radiotap TX flags

[Wireshark-commits] master 79e43ef: EAP: Update to EAP Identity Dissection

2020-08-09 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=79e43ef98d59ecfdab5667a6a55b078dab825fdd Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 79e43ef by Matthew Weant (mswe...@gmail.com): EAP: Update to EAP Identity Dissection

[Wireshark-commits] master bb5d031: Fix merge cruft from release-notes.adoc

2020-08-09 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bb5d0317d6617b196e3ee48fa6ed29551adecba3 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: bb5d031 by Michael Mann (mman...@netscape.net): Fix merge cruft from release-notes.adoc

[Wireshark-commits] master 414255f: DHCPv6: fix for bogus errors. Detailed error msgs

2020-08-09 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=414255f1de551206ac2033ee8df07acd33fc8dee Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 414255f by Cal Turney (cturney...@gmail.com): DHCPv6: fix for bogus errors. Detailed error

[Wireshark-commits] master c3dbba3: LTE RRC: upgrade dissector to v16.1.1

2020-08-09 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c3dbba350c6594aa1fb0f34c76e256a515d44045 Submitter: "Pascal Quantin " Changed: branch: master Repository: wireshark Commits: c3dbba3 by Pascal Quantin (pas...@wireshark.org): LTE RRC: upgrade dissector to v16.1.1

[Wireshark-commits] master 744c57b: UI: Follow Stream "Show and save data as" -> "Show data as"

2020-08-09 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=744c57b42c5bc0c36b97fc120124fd57e8e4235b Submitter: "Michael Mann " Changed: branch: master Repository: wireshark Commits: 744c57b by John Thacker (johnthac...@gmail.com): UI: Follow Stream "Show and save data as" ->

[Wireshark-commits] master 74e917f: wiretap: have wtap_dump_flush(), and its callers, check for errors.

2020-08-09 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=74e917fc6ce8f2577dd15637b29ced31a0d1ebbf Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: 74e917f by Guy Harris (ghar...@sonic.net): wiretap: have wtap_dump_flush(), and its callers,

[Wireshark-commits] master fcd7492: proto.c: increase PROTO_PRE_ALLOC_HF_FIELDS_MEM

2020-08-09 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fcd7492566f8cdb1bdce6c6bdc9f65a889e2de97 Submitter: "Pascal Quantin " Changed: branch: master Repository: wireshark Commits: fcd7492 by Pascal Quantin (pas...@wireshark.org): proto.c: increase

[Wireshark-commits] master 37666b6: NSH: Fix an item's bitmask.

2020-08-09 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=37666b6decc3005a7b8e4ce4f92bca057b4afc90 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 37666b6 by Martin Mathieson (martin.mathie...@keysight.com): NSH: Fix an item's bitmask.

[Wireshark-commits] master 9a7b30a: Fix tfs strings that have leading or trailing space characters.

2020-08-09 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9a7b30aea8cba8227346be25db3feeb1bb2cadfc Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 9a7b30a by Martin Mathieson (martin.mathie...@keysight.com): Fix tfs strings that have

[Wireshark-commits] master e9f6958: Windows: upgrade Npcap to 0.9996

2020-08-09 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e9f6958c46c99536bd9bb9a09e824d0789681d0a Submitter: "Pascal Quantin " Changed: branch: master Repository: wireshark Commits: e9f6958 by Pascal Quantin (pas...@wireshark.org): Windows: upgrade Npcap to 0.9996

[Wireshark-commits] master-2.6 1f2076c: [Automatic update for 2020-08-09]

2020-08-09 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1f2076ca06b0651502e712c19052aec756e484db Submitter: "Gerald Combs " Changed: branch: master-2.6 Repository: wireshark Commits: 1f2076c by Gerald Combs (ger...@wireshark.org): [Automatic update for 2020-08-09]

[Wireshark-commits] master-3.0 ac42eae: [Automatic update for 2020-08-09]

2020-08-09 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ac42eae09ab1829dc849caddc8030f3556d2bf31 Submitter: "Gerald Combs " Changed: branch: master-3.0 Repository: wireshark Commits: ac42eae by Gerald Combs (ger...@wireshark.org): [Automatic update for 2020-08-09]

[Wireshark-commits] master-3.2 5fdc375: [Automatic update for 2020-08-09]

2020-08-09 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5fdc375aa333b3fcf164d96fb679d6cd6feb4ddd Submitter: "Gerald Combs " Changed: branch: master-3.2 Repository: wireshark Commits: 5fdc375 by Gerald Combs (ger...@wireshark.org): [Automatic update for 2020-08-09]

[Wireshark-commits] master 5ca2327: [Automatic update for 2020-08-09]

2020-08-09 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5ca2327cc09f445f2d9dfed4ff90f8610692c242 Submitter: "Gerald Combs " Changed: branch: master Repository: wireshark Commits: 5ca2327 by Gerald Combs (ger...@wireshark.org): [Automatic update for 2020-08-09]

[Wireshark-commits] master 2261b59: Replace more DISSECTOR_ASSERT_NOT_REACHED() with more specific messages.

2020-08-09 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2261b59eaef4f4792b49584ddcb94e1eb3485a95 Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: 2261b59 by Guy Harris (ghar...@sonic.net): Replace more DISSECTOR_ASSERT_NOT_REACHED() with more

[Wireshark-commits] master c772824: http3: add very basic support for HTTP/3 framing

2020-08-08 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c7728244bb501770c2657e334d719d6c02d1d910 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: c772824 by Peter Wu (pe...@lekensteyn.nl): http3: add very basic support for HTTP/3 framing

[Wireshark-commits] master 2a832c8: ssh decryption: load logged keys and compute symmetric keys

2020-08-08 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2a832c8a8c44c2a54936176e69172f8b14d3d828 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 2a832c8 by Rasmus Jonsson (was...@zom.bi): ssh decryption: load logged keys and compute

[Wireshark-commits] master c931f0d: Fix most remaining detected cases where item with wrong type is used.

2020-08-08 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c931f0d341d334973604a59ad8e426e4f0a183c6 Submitter: "Martin Mathieson " Changed: branch: master Repository: wireshark Commits: c931f0d by Martin Mathieson (martin.mathie...@keysight.com): Fix most remaining detected

[Wireshark-commits] master f5a8c08: Add FSSO (Fortinet Single Sign-On) Dissector

2020-08-08 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f5a8c08b1206bf4ddbbc07c3dc2e19ca6607dd15 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: f5a8c08 by Alexis La Goutte (alexis.lagou...@gmail.com): Add FSSO (Fortinet Single Sign-On)

[Wireshark-commits] master fd03c85: check_typed_item_calls.py: Look for items with the wrong type passed to APIs

2020-08-08 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fd03c85d0f5c1e17337c2c1380e6018679f2e9c6 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: fd03c85 by Martin Mathieson (martin.mathie...@keysight.com): check_typed_item_calls.py: Look

[Wireshark-commits] master 191e1f6: Kerberos: make tfs change in template rather than directly.

2020-08-08 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=191e1f62d5b27123dae3f4488a5c2e2e799af0a0 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 191e1f6 by Martin Mathieson (martin.mathie...@keysight.com): Kerberos: make tfs change in

[Wireshark-commits] master 3b47a55: Replace instances of wmem_alloc with wmem_new

2020-08-08 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3b47a55b0daeddb4edee6390387b0dfca1135be3 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 3b47a55 by Moshe Kaplan (m...@moshekaplan.com): Replace instances of wmem_alloc with wmem_new

[Wireshark-commits] master e4379f0: Dumpcap: print closed ring-buffer file names

2020-08-08 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e4379f0ea1ae75045cd7969b18bd40c9f3fefa6c Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: e4379f0 by David Perry (boolean...@protonmail.com): Dumpcap: print closed ring-buffer file

[Wireshark-commits] master ac814cf: ieee1905: Eliminate a shadowed variable index.

2020-08-08 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ac814cf6b9b455a5245a69469fb28fc838a8ad63 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: ac814cf by Richard Sharpe (realrichardsha...@gmail.com): ieee1905: Eliminate a shadowed

[Wireshark-commits] master a9f39a2: QUIC: add STREAM data reassembly support

2020-08-08 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a9f39a29fe57fd7b1531f243fa278fd8c0fdab3e Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: a9f39a2 by Peter Wu (pe...@lekensteyn.nl): QUIC: add STREAM data reassembly support

[Wireshark-commits] master 1dd8bb2: Find and fix dissectors that should be using a default tfs.

2020-08-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1dd8bb2811d0e3e676b61f3d7e5ac311aa8ab4fc Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 1dd8bb2 by Martin Mathieson (martin.mathie...@keysight.com): Find and fix dissectors that

[Wireshark-commits] master b711b30: netmon: handle non-monitor-mode 802.11 packets differently.

2020-08-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b711b300cc9da138ff4d1a5aeeae538710c9daa5 Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: b711b30 by Guy Harris (ghar...@sonic.net): netmon: handle non-monitor-mode 802.11 packets

[Wireshark-commits] master 0670230: editcap: use constant for maximum nanosecs in 1sec

2020-08-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=06702303da1ad853cb4bc00f7fa86f5814aa9c6a Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 0670230 by David Perry (boolean...@protonmail.com): editcap: use constant for maximum

[Wireshark-commits] master d24c9df: editcap: add capture-file comments to output file

2020-08-07 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d24c9df38467a2628c126998b3ab1aca54ee6155 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: d24c9df by David Perry (boolean...@protonmail.com): editcap: add capture-file comments to

[Wireshark-commits] master-2.6 5e201ec: dicom: when exporting objects, don't assume we have the AE titles.

2020-08-06 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5e201ecca62d801ef96086e9b24bb83d28bc4f15 Submitter: "Guy Harris " Changed: branch: master-2.6 Repository: wireshark Commits: 5e201ec by Guy Harris (ghar...@sonic.net): dicom: when exporting objects, don't assume we

[Wireshark-commits] master 9015824: dicom: when exporting objects, don't assume we have the AE titles.

2020-08-06 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9015824c0ea3ee9ff265ae0db488bd3472d1875c Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: 9015824 by Guy Harris (ghar...@sonic.net): dicom: when exporting objects, don't assume we have

[Wireshark-commits] master-3.2 d3a0d05: dicom: when exporting objects, don't assume we have the AE titles.

2020-08-06 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d3a0d059d1aabb2f366c932ef42e3c364b96a919 Submitter: "Guy Harris " Changed: branch: master-3.2 Repository: wireshark Commits: d3a0d05 by Guy Harris (ghar...@sonic.net): dicom: when exporting objects, don't assume we

[Wireshark-commits] master-3.0 d24bc59: dicom: when exporting objects, don't assume we have the AE titles.

2020-08-06 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d24bc59565ddc40da0b963cec9e03402893af738 Submitter: "Guy Harris " Changed: branch: master-3.0 Repository: wireshark Commits: d24bc59 by Guy Harris (ghar...@sonic.net): dicom: when exporting objects, don't assume we

[Wireshark-commits] master-3.0 dbe0e6a: ieee80211-netmon: fix a typo.

2020-08-06 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=dbe0e6a7c55eec74a9c3b1ccc834cb67a8249459 Submitter: "Guy Harris " Changed: branch: master-3.0 Repository: wireshark Commits: dbe0e6a by Guy Harris (ghar...@sonic.net): ieee80211-netmon: fix a typo. The

[Wireshark-commits] master-2.6 a7698ff: ieee80211-netmon: fix a typo.

2020-08-06 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a7698ff9b99b2b18f50f531ee603ba11288b67c1 Submitter: "Guy Harris " Changed: branch: master-2.6 Repository: wireshark Commits: a7698ff by Guy Harris (ghar...@sonic.net): ieee80211-netmon: fix a typo. The

[Wireshark-commits] master-3.2 11f78aa: ieee80211-netmon: fix a typo.

2020-08-06 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=11f78aa064f858c9d123ea89a7060c1fd1f14775 Submitter: "Guy Harris " Changed: branch: master-3.2 Repository: wireshark Commits: 11f78aa by Guy Harris (ghar...@sonic.net): ieee80211-netmon: fix a typo. The

[Wireshark-commits] master 245b638: ieee80211-netmon: fix a typo.

2020-08-06 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=245b6387f0724ba95d12856c54799b78836f1169 Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: 245b638 by Guy Harris (ghar...@sonic.net): ieee80211-netmon: fix a typo. The "monitor

[Wireshark-commits] master 818bb96: editcap: clean up an error message.

2020-08-06 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=818bb96e5f903ccc9eb2dbb0fa0179ed34b67e82 Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: 818bb96 by Guy Harris (ghar...@sonic.net): editcap: clean up an error message. "XXX

[Wireshark-commits] master 61e8381: editcap: allow the UNIX/POSIX Epoch to be a start or stop time.

2020-08-06 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=61e8381ab28eca4c64b3369b28c36adc16836517 Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: 61e8381 by Guy Harris (ghar...@sonic.net): editcap: allow the UNIX/POSIX Epoch to be a start or

[Wireshark-commits] master 47e9852: editcap: fix check of start and stop times.

2020-08-06 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=47e9852213e196fdc2fca608ff341a3594bb1963 Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: 47e9852 by Guy Harris (ghar...@sonic.net): editcap: fix check of start and stop times.

[Wireshark-commits] master 613c1bd: editcap: clean up the parsing of fractional time in -A and -B.

2020-08-06 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=613c1bd93147576df74a660e04449fd02a3e46de Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: 613c1bd by Guy Harris (ghar...@sonic.net): editcap: clean up the parsing of fractional time in

[Wireshark-commits] master 75884bd: packet-bthci-cmd: For LE Supported Features, fix loop to exit after 8 items.

2020-08-06 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=75884bd0110558d4d08f802075b7086b371fd61f Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 75884bd by Martin Mathieson (martin.mathie...@keysight.com): packet-bthci-cmd: For LE

[Wireshark-commits] master 30413ed: PFCP: Add GUID field with correct API and length.

2020-08-06 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=30413ed0b30a7092ea34f44964e9253a25b4d304 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 30413ed by Martin Mathieson (martin.mathie...@keysight.com): PFCP: Add GUID field with

[Wireshark-commits] master-3.2 231f103: Qt: Always pop empty filter syntax

2020-08-05 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=231f103e661822c9ab7240a0a922d970ee93b97b Submitter: "Stig Bjørlykke " Changed: branch: master-3.2 Repository: wireshark Commits: 231f103 by Stig Bjørlykke (s...@bjorlykke.org): Qt: Always pop empty filter syntax

[Wireshark-commits] master-3.2 12f50e7: Qt: Pop filter syntax in search frame

2020-08-05 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=12f50e78ce2ebb8d988e892d453fa253047fe450 Submitter: "Stig Bjørlykke " Changed: branch: master-3.2 Repository: wireshark Commits: 12f50e7 by Stig Bjørlykke (s...@bjorlykke.org): Qt: Pop filter syntax in search frame

[Wireshark-commits] master e189bd2: Qt: Always pop empty filter syntax

2020-08-05 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e189bd29965552547df46b300c49a3527d92d31f Submitter: "Stig Bjørlykke " Changed: branch: master Repository: wireshark Commits: e189bd2 by Stig Bjørlykke (s...@bjorlykke.org): Qt: Always pop empty filter syntax

[Wireshark-commits] master 5087b4f: smb2: add some missing flags for TreeConnect

2020-08-05 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5087b4f41825cf33dacae23a7663448bcf45355e Submitter: "ronnie sahlberg " Changed: branch: master Repository: wireshark Commits: 5087b4f by Ronnie Sahlberg (ronniesahlb...@gmail.com): smb2: add some missing flags for

[Wireshark-commits] master 555b894: editcap: support fractional seconds in -A/-B opts

2020-08-05 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=555b89492a99f41b5347c0b2f6b4b9ecbd5fe22f Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 555b894 by David Perry (boolean...@protonmail.com): editcap: support fractional seconds in

[Wireshark-commits] master e22da97: SLSK: Change several items to be signed.

2020-08-05 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e22da97fd159965069fccb4b62feb5c33e906075 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: e22da97 by Martin Mathieson (martin.mathie...@keysight.com): SLSK: Change several items to be

[Wireshark-commits] master 4ac54e2: Qt: Fix status message issues in find packet search

2020-08-05 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4ac54e27b0c3f6d75d3e33714e0e3440b583aab7 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 4ac54e2 by Stig Bjørlykke (s...@bjorlykke.org): Qt: Fix status message issues in find packet

[Wireshark-commits] master 12242e1: STUN: fix heuristic for ChannelData payload

2020-08-05 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=12242e147e25cdd05bc0977c353b37b9eedf6c24 Submitter: "Jörg Mayer " Changed: branch: master Repository: wireshark Commits: 12242e1 by Nardi Ivan (nardi.i...@gmail.com): STUN: fix heuristic for ChannelData payload

[Wireshark-commits] master f54611d: Qt: Pop filter syntax in search frame

2020-08-05 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f54611d1104d85a425e52c7318c522ed249916b6 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: f54611d by Stig Bjørlykke (s...@bjorlykke.org): Qt: Pop filter syntax in search frame

[Wireshark-commits] master 3a5d056: packet-stun.c: Support for different versions of the protocol

2020-08-05 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3a5d0569d7ad29a01499c04cf844e605634035d8 Submitter: "Alexis La Goutte " Changed: branch: master Repository: wireshark Commits: 3a5d056 by Joerg Mayer (jma...@loplof.de): packet-stun.c: Support for different versions

[Wireshark-commits] master 5670644: ISUP: Fix typo - increment offset to move past NC digits

2020-08-05 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=56706448296bc17b97acc705ebc95876cd6c7dc8 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 5670644 by Martin Mathieson (martin.mathie...@keysight.com): ISUP: Fix typo - increment

[Wireshark-commits] master 438a8a8: stun: eliminate a warning.

2020-08-05 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=438a8a8e7e5f8d86843a9358646fea7082c5f80e Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: 438a8a8 by Guy Harris (ghar...@sonic.net): stun: eliminate a warning. code to dissect

[Wireshark-commits] master 5c7bb21: packet-stun.c: Update to current RFCs and current IANA numbers

2020-08-04 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5c7bb2116ac88f76111ce159a7b801508cedc91b Submitter: "Jörg Mayer " Changed: branch: master Repository: wireshark Commits: 5c7bb21 by Joerg Mayer (jma...@loplof.de): packet-stun.c: Update to current RFCs and current

[Wireshark-commits] master 5e642b9: dhcp: add RFC8357 agent source port sub option

2020-08-04 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5e642b9cb63b72388af1805e6271838b35106648 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 5e642b9 by Andreas Schultz (andreas.schu...@travelping.com): dhcp: add RFC8357 agent source

[Wireshark-commits] master 22a0db9: TECMP: Adding subdissector support for CAN and FlexRay

2020-08-04 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=22a0db959f975019a68b77c6b37e2607ac75b013 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: 22a0db9 by Dr. Lars Völker (lars.voel...@technica-engineering.de): TECMP: Adding subdissector

[Wireshark-commits] master d8702b9: Added Lawful Intercept Diameter AVPs to the Verizonwireless.xml file.

2020-08-04 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d8702b98cfa85daf0e3289976a8a6902999b8d3d Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: d8702b9 by Mike Lugo (mlugo@gmail.com): Added Lawful Intercept Diameter AVPs to the

[Wireshark-commits] master d1a15ac: dhcp: add RFC7839 agent sub options

2020-08-04 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d1a15acd9e39180c7f4260ba1d1263dc7c5a9205 Submitter: "Anders Broman " Changed: branch: master Repository: wireshark Commits: d1a15ac by Andreas Schultz (andreas.schu...@travelping.com): dhcp: add RFC7839 agent sub

[Wireshark-commits] master 3a8111e: Lua: give better errors for more WTAP_ERR_ types from wtap_dump_open().

2020-08-04 Thread Wireshark code review
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3a8111e1c2adcdc0603993c6ed5d20a40f162125 Submitter: "Guy Harris " Changed: branch: master Repository: wireshark Commits: 3a8111e by Guy Harris (ghar...@sonic.net): Lua: give better errors for more WTAP_ERR_ types from

<    1   2   3   4   5   6   7   8   9   10   >