Re: [Wireshark-dev] 2.4.2 Stable release doesn't compile in Centos 7.1 64 bits

2017-10-27 Thread Juan Jose Martin Carrascosa
< joao.valve...@tecnico.ulisboa.pt> wrote: > > > On 27-10-2017 13:05, Juan Jose Martin Carrascosa wrote: > >> Hi all, >> >> I am trying to compile the source from the downloads webpage for version >> 2.4.2 and I get when doing make: >> >> Making all in

[Wireshark-dev] 2.4.2 Stable release doesn't compile in Centos 7.1 64 bits

2017-10-27 Thread Juan Jose Martin Carrascosa
Hi all, I am trying to compile the source from the downloads webpage for version 2.4.2 and I get when doing make: Making all in epan make[2]: Entering directory `epan' LN_S ws_version_info.c cp: missing destination file operand after ‘../ws_version_info.c’ Try 'cp --help' for more

[Wireshark-dev] Exporting as CSV

2017-09-20 Thread Juan Jose Martin Carrascosa
Hi folks, I am exporting as CSV the captured data. I have found that long fields are exported partially. For example: Field : 12345678901234567890123456789012345678901234567890 CSV export: 12345678901234567... Is there any way to make the CSV export take into account the full content? Changing

Re: [Wireshark-dev] Best way to give configuration information to a protocol

2017-09-19 Thread Juan Jose Martin Carrascosa
om> > To: Developer support list for Wireshark <wireshark-dev@wireshark.org> > Sent: Mon, Sep 18, 2017 3:03 pm > Subject: Re: [Wireshark-dev] Best way to give configuration information to > a protocol > > Hi Juan Jose, > > 2017-09-18 17:12 GMT+02:00 Juan Jose Ma

Re: [Wireshark-dev] Best way to give configuration information to a protocol

2017-09-18 Thread Juan Jose Martin Carrascosa
file the relationship GUID / plugin is static. Regards, Juanjo Martin On Mon, Sep 18, 2017 at 9:03 PM, Pascal Quantin <pascal.quan...@gmail.com> wrote: > Hi Juan Jose, > > 2017-09-18 17:12 GMT+02:00 Juan Jose Martin Carrascosa <jua...@rti.com>: > >> Hi all, >&

[Wireshark-dev] Best way to give configuration information to a protocol

2017-09-18 Thread Juan Jose Martin Carrascosa
Hi all, Which is the best way to pass configuration to a protocol? Do we have any builtin mechanisms? I tried to upload a patch using CSV at some point but it didn't succeed. So I wonder if there is any recommended way I can implement: table or list in the Preferences, XML file, CSV file... My

[Wireshark-dev] Add a protocol to the "decode as" option

2017-09-18 Thread Juan Jose Martin Carrascosa
Hi everybody, I have a set of plugins that work on top of the RTPS protocol. Which is the cleanest and right way to get this set of plugins available when I click in "decode as" in a RTPS packet? Thanks, Juanjo Martin ___

Re: [Wireshark-dev] New GUI for specific protocol

2017-01-26 Thread Juan Jose Martin Carrascosa
... Thanks, Juanjo Martin On Tue, Jan 24, 2017 at 9:10 PM, Guy Harris <g...@alum.mit.edu> wrote: > On Jan 24, 2017, at 9:51 AM, Juan Jose Martin Carrascosa <jua...@rti.com> > wrote: > > > I would like to write a new GUI to show nicely the information obtained > from the RTPS

Re: [Wireshark-dev] New GUI for specific protocol

2017-01-25 Thread Juan Jose Martin Carrascosa
Makes sense. Thanks for the information. I will definitely look into this. Thanks, Juanjo Martin On Tue, Jan 24, 2017 at 9:10 PM, Guy Harris <g...@alum.mit.edu> wrote: > On Jan 24, 2017, at 9:51 AM, Juan Jose Martin Carrascosa <jua...@rti.com> > wrote: > > > I wo

[Wireshark-dev] New GUI for specific protocol

2017-01-24 Thread Juan Jose Martin Carrascosa
Hi everybody, I would like to write a new GUI to show nicely the information obtained from the RTPS dissector. Can Wireshark help with that? Is there already a process in place for this? Having a separate tool/GUI would work for me. Just looking for recommendations/ideas that allow me to use the

Re: [Wireshark-dev] Correct way to add bytes to tree

2016-12-29 Thread Juan Jose Martin Carrascosa
calls tested. >> >> Thanks, >> Jaap >> >> On 28 Dec 2016, at 19:09, Juan Jose Martin Carrascosa <jua...@rti.com> >> wrote: >> >> Hi all, >> >> I have what I need to add bytes to a tree using proto_tree_add_item or >> proto_tree_add_

[Wireshark-dev] Correct way to add bytes to tree

2016-12-28 Thread Juan Jose Martin Carrascosa
Hi all, I have what I need to add bytes to a tree using proto_tree_add_item or proto_tree_add_bytes. The problem is that I want to customize the name of the proto_item adding a couple of parameters that I know from before. Something like this: given id = 5 and length = 10, tvb, offset and

Re: [Wireshark-dev] New statistics panel for RTPS

2016-11-03 Thread Juan Jose Martin Carrascosa
at b845e29 and 38d08e0. They're 2 examples of stats_tree for >> DNS and HPFEEDS that do exactly what Roland said. Use them as examples. >> >> On Thu, Nov 3, 2016 at 11:56 AM, Juan Jose Martin Carrascosa < >> jua...@rti.com> wrote: >> >>> Thanks Roland.

[Wireshark-dev] New statistics panel for RTPS

2016-11-03 Thread Juan Jose Martin Carrascosa
Hi everybody, I need to estimate how many weeks more or less would it take to implement a new panel in Statistics for RTPS. I think it's time to get this kind of stuff done :) I know everything about RTPS and I have been updating the dissector for a long time. Also, I know how to navigate

Re: [Wireshark-dev] Duplicate dissectors error

2016-08-30 Thread Juan Jose Martin Carrascosa
Glad to see that my question brought up such a nice discussion. I think that so far I will go with allowing duplicates in rtps. I have submitted this patch: https://code.wireshark.org/review/#/c/17393/ Do I have your blessing? :) Thanks, Juanjo On Mon, Aug 29, 2016 at 8:13 PM, Guy Harris

Re: [Wireshark-dev] Duplicate dissectors error

2016-08-29 Thread Juan Jose Martin Carrascosa
duplicated protocols? Just issues with "decode as"? If that is the only side effect, I can live with it. Let me know if I can provide more information. Thanks, Juanjo Martin On Mon, Aug 29, 2016 at 5:31 PM, Guy Harris <g...@alum.mit.edu> wrote: > On Aug 29, 2016, at 3:59 P

[Wireshark-dev] Duplicate dissectors error

2016-08-29 Thread Juan Jose Martin Carrascosa
Hi everybody, I am adding plugins to my Wireshark installation, so they register themselves in the table rtps.type_name (created in packet-rtps.c). Duplicate dissectors (null) and (null) for protocol Custom in dissector table rtps.type_name Duplicate dissectors (null) and (null) for protocol

Re: [Wireshark-dev] Building installer for Windows

2016-04-05 Thread Juan Jose Martin Carrascosa
True: //Path to the makensis utility. MAKENSIS_EXECUTABLE:FILEPATH=MAKENSIS_EXECUTABLE-NOTFOUND Thanks Graham. On Tue, Apr 5, 2016 at 7:00 PM, Graham Bloice <graham.blo...@trihedral.com> wrote: > > > On 5 April 2016 at 17:30, Juan Jose Martin Carrascosa <jua...@rti.com>

[Wireshark-dev] Building installer for Windows

2016-04-05 Thread Juan Jose Martin Carrascosa
Hi all, Did we change this? Run > msbuild /m /p:Configuration=RelWithDebInfo nsis_package_prep.vcxproj > msbuild /m /p:Configuration=RelWithDebInfo nsis_package.vcxproj to build a Wireshark installer. I can't find those projects. Thanks, Juanjo Martin

Re: [Wireshark-dev] Compiling a plugin in Windows

2016-04-05 Thread Juan Jose Martin Carrascosa
OK. Thanks for the information Graham. If I manage somehow to create a build infrastructure for plugins, I will share it. Thanks, Juanjo Martin On Tue, Apr 5, 2016 at 4:26 PM, Graham Bloice <graham.blo...@trihedral.com> wrote: > > > On 5 April 2016 at 15:03, Juan Jose Martin

[Wireshark-dev] Compiling a plugin in Windows

2016-04-05 Thread Juan Jose Martin Carrascosa
Hi everybody, I want to compile a plugin (C file) in Windows, to generate a .dll and provide it to Wireshark. I don't want to compile the whole tree of Wireshark. I just want to compile this C file. Does anybody have any resource/idea/instructions that can help me? Thanks, Juanjo Martin

[Wireshark-dev] Obfuscating a capture

2016-03-30 Thread Juan Jose Martin Carrascosa
Hi everybody, is there an existing way to obfuscate a capture? For instance, select a few fields and make them zero or random. I want to find a way to obfuscate captures so we can provide them to other people, or other people to us (security reasons). Any ideas? I don't feel like writing it

Re: [Wireshark-dev] ./configure fails

2016-03-30 Thread Juan Jose Martin Carrascosa
Nice! And obvious... thanks! On Wed, Mar 30, 2016 at 2:59 PM, João Valverde < joao.valve...@tecnico.ulisboa.pt> wrote: > > > On 30-03-2016 11:46, Juan Jose Martin Carrascosa wrote: > >> Hi all, >> >> ./configure was working for me two weeks ago. >> >

[Wireshark-dev] ./configure fails

2016-03-30 Thread Juan Jose Martin Carrascosa
Hi all, ./configure was working for me two weeks ago. Now it fails with: ./configure: line 19638: AX_COMPILER_VENDOR: command not found ./configure: line 19646: AX_COMPILER_VENDOR: command not found checking whether the compiler fails when given an unknown warning option... yes checking whether

[Wireshark-dev] FT_TYPE appropiated?

2016-03-20 Thread Juan Jose Martin Carrascosa
Hi all, I have a field that has the following content (hex bytes): 0a00020f7cfb0001 If I use FT_STRING, it displays 0a\n. Thus, I decided to use FT_BYTES. The problem now is that when I do right-click -> Apply as column, if I do right-click in the column and do "apply as filter" or

[Wireshark-dev] Manually resolve name

2016-03-19 Thread Juan Jose Martin Carrascosa
Hi everybody, I have managed to create an RTPS address using the guidPrefix, and I created a new column for it (adding it also to pinfo->rtps_src). It looks like this: [image: Inline image 2] This is going to help a lot in the debugging of RTPS issues. My next goal is to be able to manually

Re: [Wireshark-dev] Manually resolve name

2016-03-19 Thread Juan Jose Martin Carrascosa
gt; > On Wed, Mar 16, 2016 at 1:18 PM, Juan Jose Martin Carrascosa < > jua...@rti.com> wrote: > >> Hi everybody, >> >> I have managed to create an RTPS address using the guidPrefix, and I >> created a new column for it (adding it also to pinfo->rtps_src). >

Re: [Wireshark-dev] Change wiki page

2016-03-15 Thread Juan Jose Martin Carrascosa
Got it! Thanks! PS: Nice captcha questions. Juanjo On Tue, Mar 15, 2016 at 12:37 PM, Pascal Quantin <pascal.quan...@gmail.com> wrote: > Hi, > > 2016-03-15 11:57 GMT+01:00 Juan Jose Martin Carrascosa <jua...@rti.com>: > >> Hi everybody, >> >> How can

Re: [Wireshark-dev] Highlight fields

2016-02-23 Thread Juan Jose Martin Carrascosa
Shoot an email in this thread if you do so. I am highly interested on this feature. Thanks! Juanjo On Tuesday, February 23, 2016, Stig Bjørlykke wrote: > On Tue, Feb 23, 2016 at 9:11 PM, Jeff Morriss

Re: [Wireshark-dev] Highlight fields

2016-02-12 Thread Juan Jose Martin Carrascosa
t of the display filter >2. If so then highlighting the path back to the root of the tree (like >the expert info calls do) > > I don't know, however, how you could visually distinguish expert info's > from the "here is(are) your field(s)" highlights. > On Wed, Fe

[Wireshark-dev] Highlight fields

2016-02-10 Thread Juan Jose Martin Carrascosa
Hi all, Let's say I have several submessages in a packet (RTPS). When I filter, one of them matches so the whole RTPS (UDP datagram) matches and thus, it is shown in the display. However, if the amount of submessages is large (200?), it is quite tedious to find the matching submessage. Is there

Re: [Wireshark-dev] Highlight fields

2016-02-10 Thread Juan Jose Martin Carrascosa
; require a change to the dissectors handling the messages > > regards > > On Wed, Feb 10, 2016 at 11:44 AM, Juan Jose Martin Carrascosa < > jua...@rti.com> wrote: > >> Hi all, >> >> Let's say I have several submessages in a packet (RTPS). When I filter, >

[Wireshark-dev] Specify filter using API

2016-02-08 Thread Juan Jose Martin Carrascosa
Hi all, Is there any way to specify the filter name using an API? Like, I use this generic hf_field for my plugin and I specify the filter name in the code paths. It may not be the proper way to work when providing changes to the community, but it would help a lot in my use case. Thanks! Juanjo

Re: [Wireshark-dev] Specify filter using API

2016-02-08 Thread Juan Jose Martin Carrascosa
Thanks for the info Guy. I am not willing to hack the core, so I will go ahead with the multiple fields. Thanks, Juanjo Martin On Mon, Feb 8, 2016 at 6:21 PM, Guy Harris <g...@alum.mit.edu> wrote: > On Feb 8, 2016, at 8:27 AM, Juan Jose Martin Carrascosa <jua...@rti.

Re: [Wireshark-dev] Call XML and JSON dissectors with new HTTP Content-Type

2015-12-17 Thread Juan Jose Martin Carrascosa
17, 2015 at 1:48 PM, Pascal Quantin <pascal.quan...@gmail.com> > wrote: > >> Hi Juan, >> >> 2015-12-17 13:40 GMT+01:00 Juan Jose Martin Carrascosa <jua...@rti.com>: >> >>> Hi all, >>> >>> Web Integration Service (http://www.omg.org/sp

[Wireshark-dev] Call XML and JSON dissectors with new HTTP Content-Type

2015-12-17 Thread Juan Jose Martin Carrascosa
Hi all, Web Integration Service (http://www.omg.org/spec/DDS-WEB/1.0/Beta2/) is a new service that sends/receives DDS traffic (RTPS) over HTTP. The serialization is not directly RTPS but a conversion handled internally, that can be XML or JSON. I would like to add support to show the content of

Re: [Wireshark-dev] Call XML and JSON dissectors with new HTTP Content-Type

2015-12-17 Thread Juan Jose Martin Carrascosa
It seems the strings are official and won't change in the specification. Uploaded the patch: https://code.wireshark.org/review/#/c/12701/ If anyone has a couple of minutes... ;) Thanks! Juanjo Martin On Thu, Dec 17, 2015 at 1:56 PM, Juan Jose Martin Carrascosa <jua...@rti.com > wrote: &

[Wireshark-dev] Merge to master-2.0

2015-11-23 Thread Juan Jose Martin Carrascosa
Hi all, I got a merge approved for RTPS and it is available in master. I wanted to try it with the build from: https://www.wireshark.org/download/automated/ But I see only installers for master-2.0. 1) Do we have the same build infrastructure for master? 2) If the answer to (1) is NO, Is my

Re: [Wireshark-dev] Review of Gerrit patch for RTPS

2015-11-19 Thread Juan Jose Martin Carrascosa
les would help a lot. > > On Wed, Nov 18, 2015 at 7:21 PM, Juan Jose Martin Carrascosa < > jua...@rti.com> wrote: > >> I assumed that you were busy. Thanks for the answer. >> >> Is there anything I can help with? I may be able to spend some hours th

[Wireshark-dev] Review of Gerrit patch for RTPS

2015-11-18 Thread Juan Jose Martin Carrascosa
Hi everyone, It has been almost two weeks and I am surprised I still didn't have a review here. I am surprised because I always get reviews very early! (in the first 24h, which is awesome). https://code.wireshark.org/review/#/c/11602/ I understand that everyone might be busy. I just want to

Re: [Wireshark-dev] Review of Gerrit patch for RTPS

2015-11-18 Thread Juan Jose Martin Carrascosa
I assumed that you were busy. Thanks for the answer. Is there anything I can help with? I may be able to spend some hours this weekend. Thanks, Juanjo Martin On Wednesday, November 18, 2015, Pascal Quantin <pascal.quan...@gmail.com> wrote: > Hi Juan, > > 2015-11-18 17:36 GMT+

[Wireshark-dev] Printing floats using scientific notation when > than X digits

2015-11-04 Thread Juan Jose Martin Carrascosa
Hi team, Do you think it would be possible to know at run-time when a float value exceeds X digits? I would like to show the value using scientific notation but not in all cases, and I am reaching a point where I think it is not possible. Thanks, Juanjo Martin

Re: [Wireshark-dev] Printing floats using scientific notation when > than X digits

2015-11-04 Thread Juan Jose Martin Carrascosa
Hi all, I solved the issue by using %-7g to print floats and %-16g to print doubles. It chooses when using scientific notation and also adjusts the output to the left. Hope this helps anyone! Thanks, Juanjo Martin On Wed, Nov 4, 2015 at 1:44 PM, Juan Jose Martin Carrascosa <jua...@rti.

[Wireshark-dev] Send comments in Gerrit

2015-10-29 Thread Juan Jose Martin Carrascosa
Hi guys, I don't remember how to send the answers to the comments I got in a Code-Review. They are all drafts right now. Can anybody help me? Sorry for the dumb question :) Thanks, Juanjo Martin ___ Sent via:

Re: [Wireshark-dev] Compiling a plugin

2015-09-23 Thread Juan Jose Martin Carrascosa
to, since this is an old code) be > installed inside the distribution wireshark. Hope it works for you. > > On Wed, Sep 23, 2015 at 3:52 PM, Juan Jose Martin Carrascosa < > jua...@rti.com> wrote: > >> Hi all, >> >> I am looking for documentation r

[Wireshark-dev] Compiling a plugin

2015-09-23 Thread Juan Jose Martin Carrascosa
Hi all, I am looking for documentation regarding how to compile a plugin without the build directory. For instance, imagine I develop a plugin and I want to share it with a colleague. He modifies something and wants to compile it. Does he need the full build directory? If any documentation

Re: [Wireshark-dev] Windows automated builds migrated to CMake

2015-04-16 Thread Juan Jose Martin Carrascosa
Awesome. Good job! - Juanjo On Thursday, April 16, 2015, Graham Bloice graham.blo...@trihedral.com wrote: Woohoo. Change to delete *.nmake incoming :-) On 16 April 2015 at 04:06, Gerald Combs ger...@wireshark.org javascript:_e(%7B%7D,'cvml','ger...@wireshark.org'); wrote: We reached a

[Wireshark-dev] dpkg-buildpackage -rfakeroot picking wrong version and dissectors

2015-03-25 Thread Juan Jose Martin Carrascosa
Hi all, I am building a package for Ubuntu, and the debian packages I get as result are not picking the proper customized version (set in configure.ac), but what is worse, a custom dissector I wrote is not in the packages. I did make before doing the packaging and ./wireshark-gtk is as I expect.

Re: [Wireshark-dev] dpkg-buildpackage -rfakeroot picking wrong version and dissectors

2015-03-25 Thread Juan Jose Martin Carrascosa
/guidelines would be appreciated. Thanks, Juanjo On Wed, Mar 25, 2015 at 3:36 PM, Bálint Réczey bal...@balintreczey.hu wrote: Hi Juanjo, 2015-03-25 15:26 GMT+01:00 Juan Jose Martin Carrascosa jua...@rti.com: Hi all, I am building a package for Ubuntu, and the debian packages I get as result

Re: [Wireshark-dev] dpkg-buildpackage -rfakeroot picking wrong version and dissectors

2015-03-25 Thread Juan Jose Martin Carrascosa
/PATCH_VERSION and PROJECT_VERSION_EXTENSION. I think I got it working. Thanks for the initial point Bálint. Juanjo On Wed, Mar 25, 2015 at 4:06 PM, Juan Jose Martin Carrascosa jua...@rti.com wrote: Thanks for the prompt reply Bálint. So, I assume that what I did for the make build doesn't

Re: [Wireshark-dev] Usage of make-version.pl

2015-03-23 Thread Juan Jose Martin Carrascosa
...@gmail.com wrote: 2015-03-23 17:49 GMT+01:00 Juan Jose Martin Carrascosa jua...@rti.com: Hi all, I am building Wireshark for Windows, Linux and Mac. I have been reading and analyzing the make-version.pl script and I have found that I am not a perl expert: I have no idea about how to use

Re: [Wireshark-dev] Usage of make-version.pl

2015-03-23 Thread Juan Jose Martin Carrascosa
Actually, this is the one winning: enable: 1 pkg_format: -ABCD pkg_enable: 1 Thanks Pascal! Juanjo On Mon, Mar 23, 2015 at 6:47 PM, Pascal Quantin pascal.quan...@gmail.com wrote: 2015-03-23 18:42 GMT+01:00 Juan Jose Martin Carrascosa jua...@rti.com: Thanks for the prompt reply Pascal

[Wireshark-dev] Issue with dissector on top of TCP

2015-03-19 Thread Juan Jose Martin Carrascosa
Hi all, I am writing a dissector on top of TCP (let's call it Wrapper). For a given TCP segment, I see that the payload length is 1460 bytes. Within those bytes, I have messages of my Wrapper protocol. The message length of my protocol for those messages is 72 bytes. This is, 20 x messages =

Re: [Wireshark-dev] Issue with dissector on top of TCP

2015-03-19 Thread Juan Jose Martin Carrascosa
Hi Anders, Thanks for the prompt reply. I will give it a try. Thanks again, Juanjo On Thu, Mar 19, 2015 at 4:23 PM, Anders Broman anders.bro...@ericsson.com wrote: *From:* wireshark-dev-boun...@wireshark.org [mailto: wireshark-dev-boun...@wireshark.org] *On Behalf Of *Juan Jose Martin

[Wireshark-dev] Adding folder to package and modifying its content in packaging-time

2015-03-12 Thread Juan Jose Martin Carrascosa
Hi all, I have added a folder to the root folder and I would like to modify its content when I create the packages. Is there any documentation regarding what files do I have to modify? I am packaging for Windows, Linux and Mac. Thanks, Juanjo Martin

[Wireshark-dev] Issues packaging Wireshark in Ubuntu

2015-01-16 Thread Juan Jose Martin Carrascosa
Hi all, I have a very quick question: am I supposed to create deb packages by doing make debian-package? The makefile doesn't recognize that option :( Thanks, Juanjo Martin ___ Sent via:Wireshark-dev mailing list

Re: [Wireshark-dev] Issues packaging Wireshark in Ubuntu

2015-01-16 Thread Juan Jose Martin Carrascosa
It works perfectly. Many thanks for the prompt answer. Juanjo Martin On Fri, Jan 16, 2015 at 5:15 PM, Bálint Réczey bal...@balintreczey.hu wrote: Hi Juanjo, 2015-01-16 17:04 GMT+01:00 Juan Jose Martin Carrascosa jua...@rti.com: Hi all, I have a very quick question: am I supposed

[Wireshark-dev] Mandatory content in additional documentation

2014-12-26 Thread Juan Jose Martin Carrascosa
Hi all, I am working on preparing some bundles of a customized Wireshark version to provide them to some of our customers, and I have a question regarding documentation. I am preparing a PDF, kind of a Getting Started guide, and I wonder if I have to include any specific statement or content

[Wireshark-dev] What Wireshark base version to use for customization

2014-12-10 Thread Juan Jose Martin Carrascosa
Hi all, I have the task to customize and package a custom Wireshark version, so we can provide that to our customers. I wonder what Wireshark version should I use as base. The latest stable release or the development release? Also, I have been looking for the information to package binaries. So

Re: [Wireshark-dev] What Wireshark base version to use for customization

2014-12-10 Thread Juan Jose Martin Carrascosa
the bleeding edge stuff or the latest stable if stability is more of an issue. Regards Anders *From:* wireshark-dev-boun...@wireshark.org [mailto: wireshark-dev-boun...@wireshark.org] *On Behalf Of *Juan Jose Martin Carrascosa *Sent:* den 10 december 2014 14:39 *To:* Developer support list

Re: [Wireshark-dev] What Wireshark base version to use for customization

2014-12-10 Thread Juan Jose Martin Carrascosa
FAQ has answers for this type of question ( http://www.gnu.org/licenses/gpl-faq.html, see the section Distribution of programs released under the GNU licenses) but note that Wireshark is GPL 2.0. On 10 December 2014 at 15:21, Juan Jose Martin Carrascosa jua...@rti.com wrote: Hi Anders, Yes

[Wireshark-dev] New dissector between existing protocols

2014-11-27 Thread Juan Jose Martin Carrascosa
Hi all! I have to implement a new dissector that goes between TCP and RTPS. The name is not decided yet so let's call it XXX. I wonder, what is the best way to proceed here: 1) Currently, RTPS is already registered with UDP and TCP. Register it also with XXX. I don't know what steps do I need to

Re: [Wireshark-dev] New dissector between existing protocols

2014-11-27 Thread Juan Jose Martin Carrascosa
to the heuristic dissectors registered with call_heur_dissector_direct(udp_p_info-heur_dtbl_entry, next_tvb, pinfo, tree, NULL); I will assume that this is the way to go and I will implement it like this. Thanks! Juanjo Martin On Thu, Nov 27, 2014 at 12:09 PM, Juan Jose Martin Carrascosa jua

Re: [Wireshark-dev] New dissector between existing protocols

2014-11-27 Thread Juan Jose Martin Carrascosa
dissector works I think. Just my 2 cents Regards Anders *From:* wireshark-dev-boun...@wireshark.org [mailto: wireshark-dev-boun...@wireshark.org] *On Behalf Of *Juan Jose Martin Carrascosa *Sent:* den 27 november 2014 13:05 *To:* Developer support list for Wireshark *Subject:* Re

[Wireshark-dev] Changing author of an already accepted change

2014-09-02 Thread Juan Jose Martin Carrascosa
Hi all, My change has been accepted and merged to master, and I wonder if it would be possible to change the author that appears in git log. Currently it shows Juanjo, and since everyone is showing their last name, it would be great to show Juanjo Martin. How can I change that? I have seen that

Re: [Wireshark-dev] Changing author of an already accepted change

2014-09-02 Thread Juan Jose Martin Carrascosa
is probably add a note to the AUTHORS file or something... On Tue, Sep 2, 2014 at 12:51 PM, Juan Jose Martin Carrascosa jua...@rti.com wrote: Hi all, My change has been accepted and merged to master, and I wonder if it would be possible to change the author that appears in git log

[Wireshark-dev] Usage of BASE_CUSTOM

2014-08-28 Thread Juan Jose Martin Carrascosa
Hi all, In a code review I was told to use proto_tree_add_item and BASE_CUSTOM to replace this deprecated call: proto_tree_add_text(rtps_parameter_tree, tvb, offset, param_length, productVersion: %d.%d%c rev%d, major, minor, release, revision); I have been looking for

Re: [Wireshark-dev] Usage of BASE_CUSTOM

2014-08-28 Thread Juan Jose Martin Carrascosa
Alexis, I finally decided to create the subtree with inner elements as you suggested. Thanks! Juanjo On Thu, Aug 28, 2014 at 12:39 PM, Alexis La Goutte alexis.lagou...@gmail.com wrote: On Thu, Aug 28, 2014 at 11:45 AM, Juan Jose Martin Carrascosa jua...@rti.com wrote: Hi all

[Wireshark-dev] Equivalency between APIs

2014-08-26 Thread Juan Jose Martin Carrascosa
Hi all, I need to remove the proto_tree_add_text calls, and I wanted to know if this is equivalent: Before: ti_channel = proto_tree_add_text(rtps_parameter_tree, tvb, off, 0, Channel[%u], ch); channel_tree = proto_item_add_subtree(ti_channel, ett_rtps_locator_filter_channel);

Re: [Wireshark-dev] Equivalency between APIs

2014-08-26 Thread Juan Jose Martin Carrascosa
to proto_tree_add_subtree, you can just pass NULL in for the proto_item* parameter. -Original Message- From: Juan Jose Martin Carrascosa jua...@rti.com To: Developer support list for Wireshark wireshark-dev@wireshark.org Sent: Tue, Aug 26, 2014 9:43 am Subject: [Wireshark-dev] Equivalency between APIs

Re: [Wireshark-dev] Gerrit patches with trailing whitespace

2014-08-25 Thread Juan Jose Martin Carrascosa
I think that you are talking about my just committed changes. I just did it and I just checked in the website that it has the whitespaces... As Evan said, I don't have it installed by default and I wasn't really aware of the process (even reading the doc a couple of times). I am really sorry. I