Re: [Wireshark-dev] [Wireshark-announce] Wireshark 1.6.0rc2 is now available

2011-06-03 Thread Martin Mathieson
On Fri, Jun 3, 2011 at 2:25 PM, Jeff Morriss jeff.morriss...@gmail.comwrote: Wireshark announcements wrote: New and Updated Features The following features are new (or have been significantly updated) since version 1.4: Should this list mention the (intentional) removal of the

Re: [Wireshark-dev] Finding duplicate (conflicting) value_string entries

2011-05-18 Thread Martin Mathieson
On Wed, May 18, 2011 at 4:49 PM, Jakub Zawadzki darkjames...@darkjames.plwrote: On Wed, May 18, 2011 at 05:39:32PM +0200, Alexis La Goutte wrote: I think it is better to add this check in checkAPIs.pl script Well it's little hard to do this in checkAPIs.pl cause we need preprocessor, and

Re: [Wireshark-dev] Finding duplicate (conflicting) value_string entries

2011-05-18 Thread Martin Mathieson
On Wed, May 18, 2011 at 10:12 PM, Jeff Morriss jeff.morriss...@gmail.comwrote: Martin Mathieson wrote: On Wed, May 18, 2011 at 4:49 PM, Jakub Zawadzki darkjames...@darkjames.pl mailto:darkjames...@darkjames.pl wrote: On Wed, May 18, 2011 at 05:39:32PM +0200, Alexis La Goutte wrote

Re: [Wireshark-dev] [Wireshark-commits] rev 36659: / /trunk/epan/dissectors/: Makefile.common packet-rohc.c

2011-04-19 Thread Martin Mathieson
On Tue, Apr 19, 2011 at 9:25 PM, Guy Harris g...@alum.mit.edu wrote: On Apr 19, 2011, at 1:23 PM, Stephen Fisher wrote: Coverity has a warning about this code: Event result_independent_of_operands: (oct 2) == 1 is always false regardless of the values of its operands (logical operand

Re: [Wireshark-dev] [Wireshark-commits] rev 36659: / /trunk/epan/dissectors/: Makefile.common packet-rohc.c

2011-04-16 Thread Martin Mathieson
Hi Anders, There is already most of the ROHC profile in packet-pdcp-lte.c. I'd been meaning to separate it out so that it could be used from other places (e.g. when I create UMTS PDCP...) Martin On Sat, Apr 16, 2011 at 12:44 PM, etx...@wireshark.org wrote:

Re: [Wireshark-dev] [Wireshark-commits] rev 36659: / /trunk/epan/dissectors/: Makefile.common packet-rohc.c

2011-04-16 Thread Martin Mathieson
That should have read most of the RTP profile On Sat, Apr 16, 2011 at 1:03 PM, Martin Mathieson martin.r.mathie...@googlemail.com wrote: Hi Anders, There is already most of the ROHC profile in packet-pdcp-lte.c. I'd been meaning to separate it out so that it could be used from other places

Re: [Wireshark-dev] [Wireshark-commits] rev 36659: / /trunk/epan/dissectors/: Makefile.common packet-rohc.c

2011-04-16 Thread Martin Mathieson
On Sat, Apr 16, 2011 at 1:38 PM, Anders Broman a.bro...@bredband.netwrote: Martin Mathieson skrev 2011-04-16 14:03: Hi Anders, There is already most of the ROHC profile in packet-pdcp-lte.c. I'd been meaning to separate it out so that it could be used from other places (e.g. when I create

Re: [Wireshark-dev] [Wireshark-commits] rev 36659: / /trunk/epan/dissectors/: Makefile.common packet-rohc.c

2011-04-16 Thread Martin Mathieson
On Sat, Apr 16, 2011 at 2:44 PM, Anders Broman a.bro...@bredband.netwrote: Martin Mathieson skrev 2011-04-16 15:18: On Sat, Apr 16, 2011 at 1:38 PM, Anders Broman a.bro...@bredband.netwrote: Martin Mathieson skrev 2011-04-16 14:03: Hi Anders, There is already most of the ROHC profile

Re: [Wireshark-dev] [Wireshark-commits] rev 36286: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-rlc.c

2011-03-23 Thread Martin Mathieson
Oops, that was 1020 1021, rather. On Wed, Mar 23, 2011 at 10:58 AM, mart...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=36286 User: martinm Date: 2011/03/23 03:58 AM Log: Don't assign proto_item pointers that are not used. Coverity CIDs 1021

Re: [Wireshark-dev] Wireshark encountering error

2011-02-09 Thread Martin Mathieson
Hi Manjula, I can't view those attached images. More useful than the captures though would be the captured files that lead to the crash. Best regards, Martin On Wed, Feb 9, 2011 at 11:44 AM, M, Manjula (Manjula)** CTR ** manjul...@alcatel-lucent.com wrote: Hello all, We are working on

Re: [Wireshark-dev] wireshark crashes after adding preferencecodeto my

2011-01-30 Thread Martin Mathieson
...@wireshark.org] *On Behalf Of *Martin Mathieson *Sent:* Thursday, January 27, 2011 6:31 PM *To:* Developer support list for Wireshark *Subject:* Re: [Wireshark-dev] wireshark crashes after adding preferencecodeto my Hi Yosi On Thu, Jan 27, 2011 at 3:37 PM, Yosi Saggi yo...@designartnetworks.com

Re: [Wireshark-dev] wireshark crashes after adding preference codeto my

2011-01-27 Thread Martin Mathieson
a simple dissector that just parsed out the header, filled in the struct and called the mac_lte dissector with the payload. Best regards, Martin Any help will be great. Yosi *From:* wireshark-dev-boun...@wireshark.org [mailto: wireshark-dev-boun...@wireshark.org] *On Behalf Of *Martin

Re: [Wireshark-dev] wireshark crashes after adding preference code to my

2011-01-26 Thread Martin Mathieson
I can't see anything immediately wrong with this. I assume your prefs variables (global_dan_lte_sdk_dissect_MAC and global_dan_lte_sdk_dissect_RLC) are gbooleans with file scope? I'm wondering why the existing LTE MAC dissector isn't suitable, or can't be made to work with your frames? Regards,

Re: [Wireshark-dev] [Wireshark-commits] rev 35393: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-catapult-dct2000.c

2011-01-07 Thread Martin Mathieson
On Fri, Jan 7, 2011 at 3:33 AM, Jeff Morriss jeff.morriss...@gmail.comwrote: On 01/06/2011 12:49 PM, Martin Mathieson wrote: Martin, I assume the pre-tvb_get_ptr() code here was similar to this change in that it only retrieved the string once? (I ask since several of the strings

Re: [Wireshark-dev] [Wireshark-commits] rev 35393: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-catapult-dct2000.c

2011-01-06 Thread Martin Mathieson
Jeff, I made the change to use tvb_get_ptr() because a profile showed that getting the strings each time was quite slow. The reason I thought this is safe is that this protocol is really a header written out by the corresponding wiretap module, so it should be well-formed (if the file being read

Re: [Wireshark-dev] [Wireshark-commits] rev 35393: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-catapult-dct2000.c

2011-01-06 Thread Martin Mathieson
of tvb_get_ptr() (which I'd love to put in the category of do not use!--the only problem there being that it's used all over the place). It did occur to me later that it might be slower; I'll revert the change in a bit. Regards, -Jeff Martin Mathieson wrote: Jeff, I made the change to use

Re: [Wireshark-dev] [Wireshark-commits] rev 35393: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-catapult-dct2000.c

2011-01-06 Thread Martin Mathieson
On Thu, Jan 6, 2011 at 4:54 PM, Jeff Morriss jeff.morriss...@gmail.comwrote: Anders Broman wrote: Martin Mathieson skrev 2011-01-06 17:03: Thanks, I do believe that this is a special case - I wouldn't want to use tvb_get_ptr() anywhere else. Regards, Martin On Thu, Jan 6, 2011 at 3:58

Re: [Wireshark-dev] [Wireshark-commits] rev 35292: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-mac-lte.c

2010-12-28 Thread Martin Mathieson
Thanks for fixing the check on the loop. But why the ep_allocate() ? 64 bytes isn't much - they could be static in case MAX_RAR_PDUs ever increased. I don't mind that much... Martin On Tue, Dec 28, 2010 at 8:47 PM, ger...@wireshark.org wrote:

Re: [Wireshark-dev] [Wireshark-commits] rev 34860: /trunk/gtk/ /trunk/gtk/: text_import.c

2010-11-13 Thread Martin Mathieson
This still doesn't fix the build for me. There is an undefined reference to text_importset_in() in gtk/file_import_dlg.c:504 Martin On Sat, Nov 13, 2010 at 4:04 PM, mart...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=34860 User: martinm Date:

Re: [Wireshark-dev] [Wireshark-commits] rev 34261: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-gsm_a_rr.c

2010-09-27 Thread Martin Mathieson
I was just about to do the same, but wasn't sure about the last 3 references to 'subtree' in this function. It looked to me as though they could still get called even if the earlier places where 'subtree' gets assigned didn't... Martin On Mon, Sep 27, 2010 at 11:11 AM, etx...@wireshark.org

Re: [Wireshark-dev] type punning error in packet-gtpv2.c

2010-07-21 Thread Martin Mathieson
On Tue, Jul 6, 2010 at 3:33 PM, Ed Beroset bero...@mindspring.com wrote: I just updated and attempted to build Wireshark on a 32-bit Linux box using gcc 4.1.2 and I find that I get an error in the epan/dissectors/packet-gtpv2.c file: packet-gtpv2.c: In function 'proto_register_gtpv2':

Re: [Wireshark-dev] Creating a Wireshark installer with my dissector in it

2010-06-10 Thread Martin Mathieson
I used it recently with good success. You may need to set the configure options in packaging/rpm/SPECS/ wireshark.spec.in. Martin On Wed, Jun 9, 2010 at 11:27 PM, Jaap Keuter jaap.keu...@xs4all.nl wrote: Hi, Assuming the RPM packaging software is available: $ make rpm-package Personally I

[Wireshark-dev] Is it just me? (build error in packet-q708.c)

2010-05-19 Thread Martin Mathieson
I don't understand why I need to patch below to build this dissector, whereas the buildbots seem to be fine. Index: epan/dissectors/packet-q708.c === --- epan/dissectors/packet-q708.c (revision 32881) +++

Re: [Wireshark-dev] [Wireshark-commits] rev 32609: /trunk/ /trunk/epan/: column-utils.c /trunk/gtk/: packet_list_store.c

2010-04-30 Thread Martin Mathieson
Thanks! I spent a couple of hours trying to fix this a while ago but got nowhere. Martin On Fri, Apr 30, 2010 at 12:53 AM, ger...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=32609 User: gerald Date: 2010/04/29 04:53 PM Log: Several dissectors

[Wireshark-dev] Kerberos error while trying to build Wireshark rpm

2010-04-23 Thread Martin Mathieson
Hi, I've been having trouble running 'make rpm-package'. Using the version of krb5.h it finds by default can't determine which version (Heimdal or MIT) it is. So I tried: configure --with-krb5=/usr It identified the version as MIT this time, but when I tried to make the rpm package it again

Re: [Wireshark-dev] Kerberos error while trying to build Wireshark rpm

2010-04-23 Thread Martin Mathieson
christopher.mayn...@gtech.com wrote: I think you need to manually edit the wireshark.spec.in file to add the configure options you want. - Chris From: wireshark-dev-boun...@wireshark.org [ wireshark-dev-boun...@wireshark.org] On Behalf Of Martin Mathieson

Re: [Wireshark-dev] se_alloc() GSList segfault woes

2010-04-20 Thread Martin Mathieson
On Tue, Apr 20, 2010 at 4:45 PM, Jeff Morriss jeff.morriss...@gmail.comwrote: Jeremy O'Brien wrote: Hello everyone, I am using a static GSList to record some data about packets I've seen so that I can look up said info later. I've defined a custom callback for my g_slist_find_custom

Re: [Wireshark-dev] se_alloc() GSList segfault woes

2010-04-20 Thread Martin Mathieson
On Tue, Apr 20, 2010 at 4:57 PM, Martin Mathieson martin.r.mathie...@googlemail.com wrote: On Tue, Apr 20, 2010 at 4:45 PM, Jeff Morriss jeff.morriss...@gmail.comwrote: Jeremy O'Brien wrote: Hello everyone, I am using a static GSList to record some data about packets I've seen so

Re: [Wireshark-dev] [Wireshark-commits] rev 32184: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-cfm.h

2010-03-14 Thread Martin Mathieson
OK, checked the patch in bug 4391 to see that what I did was correct. Martin On Sun, Mar 14, 2010 at 9:17 AM, mart...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=32184 User: martinm Date: 2010/03/14 07:17 AM Log: Took a guess at the code for

Re: [Wireshark-dev] [Wireshark-commits] rev 31834: /trunk/docbook/wsug_graphics/ /trunk/docbook/wsug_graphics/: ws-gui-config-profiles.png ws-menu.png ws-statistics-menu.png ws-stats-lte-rlc-traffic.p

2010-02-09 Thread Martin Mathieson
Hi Jaap, Could you please describe how you did this? Is it documented somewhere? Martin On Mon, Feb 8, 2010 at 10:09 PM, j...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=31834 User: jake Date: 2010/02/08 02:09 PM Log: Rightsize graphics by

[Wireshark-dev] Crash at startup with current svn

2009-09-17 Thread Martin Mathieson
I'm getting this crash when I start up Wireshark with current svn version. Any ideas? I'm using gtk 2.8.10.. Martin Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 1116491232 (LWP 9020)] 0x42211338 in gdk_color_copy () from /opt/gnome/lib/libgdk-x11-2.0.so.0 (gdb) bt #0

Re: [Wireshark-dev] [Wireshark-commits] rev 29535: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-tcp.c

2009-08-24 Thread Martin Mathieson
I'm getting this: packet-tcp.c: In function `dissect_tcp_payload': packet-tcp.c:1551: warning: 'cleared_writable' might be used uninitialized in this function Not sure what the default value should be... Martin On Mon, Aug 24, 2009 at 10:05 AM, etx...@wireshark.org wrote:

Re: [Wireshark-dev] [Wireshark-commits] rev 29535:/trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-tcp.c

2009-08-24 Thread Martin Mathieson
Of *Martin Mathieson *Sent:* den 24 augusti 2009 11:28 *To:* wireshark-dev@wireshark.org *Subject:* Re: [Wireshark-dev] [Wireshark-commits] rev 29535:/trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-tcp.c I'm getting this: packet-tcp.c: In function `dissect_tcp_payload': packet-tcp.c:1551

[Wireshark-dev] expert_comp_table.c uses g_string_chunk_clear (introduced in glib 2.14)

2009-08-20 Thread Martin Mathieson
We can't use g_string_chunk_clear() as we still support glib 2.4 Martin ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe:

Re: [Wireshark-dev] Except.c build errors

2009-08-17 Thread Martin Mathieson
On Mon, Aug 17, 2009 at 5:32 AM, Kovarththanan Rajaratnam kovarththanan.rajarat...@gmail.com wrote: Hey, Martin Mathieson wrote: Hi, I was seeing error messages, because my compiler (gcc 3.4.6) wouldn't allow except_set_allocator() to cast the function prototype that differed by its

[Wireshark-dev] Except.c build errors

2009-08-16 Thread Martin Mathieson
Hi, I was seeing error messages, because my compiler (gcc 3.4.6) wouldn't allow except_set_allocator() to cast the function prototype that differed by its arg (i.e. the length field from size_t to gulong (as used by g_malloc()). The attached patch works for me - should it be checked in? Martin

Re: [Wireshark-dev] [Wireshark-commits] rev 29176: /trunk/epan/ /trunk/epan/dfilter/: dfilter.h /trunk/epan/: column-utils.c column_info.h

2009-07-23 Thread Martin Mathieson
Hi, I'm getting this: gcc -DHAVE_CONFIG_H -I. -I. -I../.. -I./../.. -I./.. -I/usr/local/include -DPLUGIN_DIR=\/usr/local/lib/wireshark/plugins/1.3.0\ -Werror -DINET6 -D_U_=__attribute__((unused)) -g -O2 -Wall -W -Wextra -Wdeclaration-after-statement -Wendif-labels -Wpointer-arith -Wcast-align

Re: [Wireshark-dev] [Wireshark-commits] rev 29176: /trunk/epan/ /trunk/epan/dfilter/: dfilter.h /trunk/epan/: column-utils.c column_info.h

2009-07-23 Thread Martin Mathieson
2009/7/23 Jakub Zawadzki darkja...@darkjames.ath.cx On Thu, Jul 23, 2009 at 12:47:30PM +0200, Jakub Zawadzki wrote: You can't typedef again, even if you use it without includes, in single file like: but you can do: struct bar; /* forward, just in case? */ struct foo

Re: [Wireshark-dev] How to get information form NBAP message for MAC and RLC dessectors?

2009-05-13 Thread Martin Mathieson
Hi Bright, There is already an FP dissector. Instead of taking its configuration from RRC, it reads them from file formats that supply it. I imagine you'd need to add to the RRC template functions to remember read these values and store them in global tables that may be read by FP (and MAC and

Re: [Wireshark-dev] text2catapult

2009-04-24 Thread Martin Mathieson
the structure of this file, nor how to convert from text format to catapult format?! Someone can help me please?! Regards -- Message: 4 Date: Thu, 23 Apr 2009 18:04:47 +0100 From: Martin Mathieson martin.r.mathie...@googlemail.com Subject: Re: [Wireshark-dev

Re: [Wireshark-dev] text2catapult

2009-04-23 Thread Martin Mathieson
If you send a short file with an example of each protocol you want to support, I can try to convert it (by hand) to show you how it might be done. Martin On Thu, Apr 23, 2009 at 5:00 PM, SOLTANI FATEN faten.solt...@alcatel-lucent.com wrote: Hi everyone I have a text file which includes an

Re: [Wireshark-dev] text2catapult

2009-04-23 Thread Martin Mathieson
, 2009 at 6:04 PM, Martin Mathieson martin.r.mathie...@googlemail.com wrote: If you send a short file with an example of each protocol you want to support, I can try to convert it (by hand) to show you how it might be done. Martin On Thu, Apr 23, 2009 at 5:00 PM, SOLTANI FATEN faten.solt

Re: [Wireshark-dev] [Wireshark-commits] rev 27893: /trunk/epan/dissectors/ /trunk/epan/dissectors/: Makefile.common packet-synphasor.c

2009-03-30 Thread Martin Mathieson
This code uses g_slice_new(), which was introduced in glib 2.10. Looking at configure.in, isn't 2.4 the minimum supported version of glib ? Martin On Mon, Mar 30, 2009 at 11:57 AM, wme...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=27893 User:

Re: [Wireshark-dev] catapult_pcap

2009-03-23 Thread Martin Mathieson
On Mon, Mar 23, 2009 at 4:08 PM, Guy Harris g...@alum.mit.edu wrote: On Mar 23, 2009, at 8:33 AM, SOLTANI FATEN wrote: As you know, Wireshark is able to read a catapult format (DCT2000), I want to know HOW? By conversion from DCT200 format to pcap format, or there is some modification

Re: [Wireshark-dev] Another typo in wireshark.nsi [PATCH]

2009-03-12 Thread Martin Mathieson
Done in 27710. On Thu, Mar 12, 2009 at 10:29 AM, Anders Broman anders.bro...@ericsson.comwrote: Hi, Can some one apply this patch? wireshark.nsi.patch Regards Anders ___ Sent via:Wireshark-dev mailing list

Re: [Wireshark-dev] [Wireshark-commits] rev 27688: /trunk/wiretap/ /trunk/wiretap/: ngsniffer.c

2009-03-10 Thread Martin Mathieson
I'm still getting this: ngsniffer.c:2546: warning: comparison between signed and unsigned with gcc 3.4.6 On Tue, Mar 10, 2009 at 4:33 PM, ger...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=27688 User: gerald Date: 2009/03/10 09:33 AM Log:

[Wireshark-dev] gtk layout help in new LTE MAC statistics window

2009-02-23 Thread Martin Mathieson
Hi, I'm struggling to create a satisfactory layout for the LTE MAC statistics window that I just checked in, and would really appreciate any help I can get from someone who is more familiar with gtk programming. What I'd like to have are 3 areas: (1) Common channel counters at the top. This

Re: [Wireshark-dev] gtk layout help in new LTE MAC statistics window

2009-02-23 Thread Martin Mathieson
On Mon, Feb 23, 2009 at 5:06 PM, Stig Bjørlykke s...@bjorlykke.org wrote: 2009/2/23 Martin Mathieson martin.r.mathie...@googlemail.com: (1) Common channel counters at the top. This should be a fixed-sized table with just one row where common channel counters are displayed. 2 rows (one

[Wireshark-dev] Build broken (packet-mp2t.c:245 offset might be clobbered by `longjmp' or `vfork')

2009-02-06 Thread Martin Mathieson
Hi, I found this warning after I updated from svn this morning. I'm using gcc 3.4.6 under Linux. I'm not sure what the correct fix would be, I wouldn't be surprised if it wasn't the attached patch though... Martin Index: packet-mp2t.c

Re: [Wireshark-dev] How to parse PDCP packet?

2009-01-06 Thread Martin Mathieson
On Tue, Jan 6, 2009 at 5:20 AM, Siva.S s.s...@gdatech.co.in wrote: Hi, Anyone finished parsing for PDCP?. How to identify whether the PDCP packet was having a 5-bit Sequence No or a 7-bit or 12-bit?. Likewise, I want to know for RLC too. Whether, it's UM mode or AM mode or TM mode.

Re: [Wireshark-dev] LTE MAC

2008-12-24 Thread Martin Mathieson
On Wed, Dec 24, 2008 at 2:48 AM, Yuming fang fangyuming@gmail.comwrote: 2008/12/24 Martin Mathieson martin.r.mathie...@googlemail.com Hi, I just submitted an LTE MAC dissector. In order to decode MAC frames it needs to know at least : - the RNTI type associated with the frame

Re: [Wireshark-dev] How does the wireshark identify the corresponding protocol according to the data from libcap

2008-12-23 Thread Martin Mathieson
On Tue, Dec 23, 2008 at 8:11 AM, Yuming fang fangyuming@gmail.comwrote: snipped Yeah, I register the dissector for the LTE data with the tcp.port dissector table with the value . And now I could get the LTE data from the port. Do I just add my LTE code into the corresponding

Re: [Wireshark-dev] How does the wireshark identify the corresponding protocol according to the data from libcap

2008-12-23 Thread Martin Mathieson
On Tue, Dec 23, 2008 at 9:09 AM, Yuming fang fangyuming@gmail.comwrote: 2008/12/23 Martin Mathieson martin.r.mathie...@googlemail.com On Tue, Dec 23, 2008 at 8:11 AM, Yuming fang fangyuming@gmail.comwrote: snipped Yeah, I register the dissector for the LTE data

Re: [Wireshark-dev] Clarification needed on the 3GPP specification implementation for Iub protocol on wireshark

2008-12-23 Thread Martin Mathieson
On Tue, Dec 23, 2008 at 11:38 AM, divya shree bm.di...@gmail.com wrote: Hi, Just want to know if 3GPP specification implementation for Iub protocol is present in wireshark. To explain, I'm expecting if the frame protocol on TCP/IP, UDP and SCTP on user plane. Hi, There is an FP dissector,

[Wireshark-dev] LTE MAC

2008-12-23 Thread Martin Mathieson
Hi, I just submitted an LTE MAC dissector. In order to decode MAC frames it needs to know at least : - the RNTI type associated with the frame - direction (uplink or downlink) These and other fields that can be passed to the dissector are in epan/dissectors/packet-mac-lte.h. I've added support

Re: [Wireshark-dev] [Wireshark-bugs] [Bug 3138] New: Buildbot crash output: fuzz-2008-12-18-2313.pcap

2008-12-19 Thread Martin Mathieson
On Thu, Dec 18, 2008 at 9:16 PM, Guy Harris g...@alum.mit.edu wrote: On Dec 18, 2008, at 1:03 PM, Martin Mathieson wrote: Sorry about that, I didn't grep to see if it was being called. Because it compiled OK I wrongly assumed it wasn't. BTW, as it's an add_bytes routine, presumably

Re: [Wireshark-dev] [Wireshark-bugs] [Bug 3138] New: Buildbot crash output: fuzz-2008-12-18-2313.pcap

2008-12-18 Thread Martin Mathieson
Sorry about that, I didn't grep to see if it was being called. Because it compiled OK I wrongly assumed it wasn't. Martin On Thu, Dec 18, 2008 at 8:18 PM, Gerald Combs ger...@wireshark.org wrote: As a result of r27047 a bunch of functions were passing raw packet data as a format string,

Re: [Wireshark-dev] Wireshark Dissector issue

2008-11-05 Thread Martin Mathieson
On Wed, Nov 5, 2008 at 12:41 PM, Sean [EMAIL PROTECTED] wrote: Greetings, I'm new for Wireshark, I'd like to implement a wireshark dissector for a selfdefined protocol, there is an issue: the packet data can't be decoded by the packet data itself, so does there any methods for passing some

[Wireshark-dev] Build failure on Linux (GCC 3.4.6)

2008-08-04 Thread Martin Mathieson
Hi, I've had this build failure for the past few days. I haven't looked at it deeply, but I don't understand how the exception stuff is working. packet-infiniband.c: In function `parse_PAYLOAD': packet-infiniband.c:806: warning: variable 'next_tvb' might be clobbered by `longjmp' or `vfork'

Re: [Wireshark-dev] Build failure on Linux (GCC 3.4.6)

2008-08-04 Thread Martin Mathieson
On Mon, Aug 4, 2008 at 4:23 PM, Guy Harris [EMAIL PROTECTED] wrote: On Aug 4, 2008, at 6:03 AM, Martin Mathieson wrote: Unfortunately not. I can't see what is different between this case and the one in the built-in packet-ethertype.c which may have been used as a template in part

Re: [Wireshark-dev] Build failure on Linux (GCC 3.4.6)

2008-08-04 Thread Martin Mathieson
On Mon, Aug 4, 2008 at 5:16 PM, Guy Harris [EMAIL PROTECTED] wrote: On Aug 4, 2008, at 8:48 AM, Martin Mathieson wrote: ukeng7 martinm main : cat /proc/cpuinfo processor : 0 vendor_id : GenuineIntel cpu family : 15 model : 4 model name : Intel(R

[Wireshark-dev] Getting a crash in UAT code (K12)

2008-07-28 Thread Martin Mathieson
Hi, I'm getting a crash that seems to be related to the K12 UAT file. I get the following crash only when I try to load in a K12 capture file. (lt-wireshark:25562): Pango-WARNING **: Invalid UTF-8 string passed to pango_layout_set_text() 14:54:17 Err Per-packet memory corrupted.

Re: [Wireshark-dev] iconv.m4?

2008-07-26 Thread Martin Mathieson
I think I ended up deleting Makefile and Makefile.in... On 7/26/08, Guy Harris [EMAIL PROTECTED] wrote: On Jul 26, 2008, at 8:44 AM, Frank Solensky wrote: I've been getting the following error since updating my work area about a week or so ago: $ make make: *** No

Re: [Wireshark-dev] packet-dcm.c:960: warning: pointer type mismatch in conditional expression

2008-07-25 Thread Martin Mathieson
I'm still getting a build error here about unused statics (dcm_uid_table and dcm_iud_data). They are declared static in the header file, which can't be right, can it? Surely they should be moved into the .c file, or if something will share them, made non-static? Martin On Fri, Jul 25, 2008 at

Re: [Wireshark-dev] Bug 2581 - Filter autocompletion

2008-07-23 Thread Martin Mathieson
On Wed, Jul 23, 2008 at 12:33 PM, Abhik Sarkar [EMAIL PROTECTED] wrote: Hi Bahaa / Martin, Ever since I have seen this enhancement request raised, I have been eager to try it out. But, now that I have compiled the latest SVN version... it doesn't seem to work (that is, no pop-up menu appears

Re: [Wireshark-dev] Improvement to WIMAXASNCP for decoding IEEE 802.16e specified TLV's

2008-06-20 Thread Martin Mathieson
Thanks in Advance! Regards Smit Rastogi Wipro Technologies -Original Message- From: [EMAIL PROTECTED] on behalf of Martin Mathieson Sent: Wed 6/18/2008 9:07 PM To: Developer support list for Wireshark Subject: Re: [Wireshark-dev] How to check whether a plugin is installed

Re: [Wireshark-dev] Request/Response tracking with multiple responses

2008-06-20 Thread Martin Mathieson
On Fri, Jun 20, 2008 at 6:26 PM, Guy Harris [EMAIL PROTECTED] wrote: Thomas Boehne wrote: I followed the README.request_response_tracking to add request/response tracking to a UDP based protocol, but the protocol sometimes sends multiple responses to a single request. Does anybody know

Re: [Wireshark-dev] [Wireshark-commits] rev 25485: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-per.c

2008-06-19 Thread Martin Mathieson
You just beat me to it. I wondered if there should be a continue or return following the PER_NOT_DECODED_YET at line 1868? Martin On Thu, Jun 19, 2008 at 1:36 PM, [EMAIL PROTECTED] wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=25485 User: stig Date: 2008/06/19 05:36

Re: [Wireshark-dev] How to check whether a plugin is installed from inside a dissector ?

2008-06-18 Thread Martin Mathieson
On Wed, Jun 18, 2008 at 4:20 PM, Jeff Morriss [EMAIL PROTECTED] wrote: [EMAIL PROTECTED] wrote: Hi all, I am currently trying to decode the IEEE 802.16E TLV's that WIMAXASNCP is unable to, and I found out that the corresponding TLV's are already dissected in the Intel WiMAX plugin.

Re: [Wireshark-dev] Return -1 from a heuristic dissector

2008-06-11 Thread Martin Mathieson
On Wed, Jun 11, 2008 at 3:04 PM, Stig Bjørlykke [EMAIL PROTECTED] wrote: Hi all. The ms-mms dissector is returning -1 in some cases where it seems to want more data. The attached capture has no ms-mms data, and end up with a UDP packet not showing any Data. Shouldn't the ms-mms dissector

Re: [Wireshark-dev] Return -1 from a heuristic dissector

2008-06-11 Thread Martin Mathieson
On Wed, Jun 11, 2008 at 8:59 PM, Stig Bjørlykke [EMAIL PROTECTED] wrote: On 11. juni. 2008, at 16.22, Martin Mathieson wrote: Section 2.7.2 of README.developer suggests that it should return 0, since that's how many bytes it has dissected. It also shouldn't be setting desegment_len to 1

Re: [Wireshark-dev] sigcomp implementation

2008-05-27 Thread Martin Mathieson
On Mon, May 26, 2008 at 6:55 PM, Claudio Fontana [EMAIL PROTECTED] wrote: Hello, I have seen the wireshark SIGCOMP implementation, and it seems to me that some operations are missing, and many corner cases are not handled as RFCs demand, especially regarding DECOMPRESSION- FAILURE conditions

Re: [Wireshark-dev] [Wireshark-commits] rev 25350: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-sip.c

2008-05-22 Thread Martin Mathieson
Thanks Stig. Did you see any warnings (on OSX?) ? I built and tested on Linux/GCC and VC 2005 EE. Martin On Thu, May 22, 2008 at 10:36 AM, [EMAIL PROTECTED] wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=25350 User: stig Date: 2008/05/22 02:36 AM Log: Initialize

Re: [Wireshark-dev] [Wireshark-commits] rev 25171: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-umts_fp.c

2008-04-25 Thread Martin Mathieson
On Fri, Apr 25, 2008 at 8:08 PM, Guy Harris [EMAIL PROTECTED] wrote: Bill Meier wrote: I expect that the next buildbot Windows compile of packet-umts_fp will fail (since it does on my Windows system): packet-umts_fp.c(861) : warning C4244: 'function' : conversion from 'unsigned

Re: [Wireshark-dev] Tap preferences

2008-04-23 Thread Martin Mathieson
Hi, On Wed, Apr 23, 2008 at 7:20 AM, Jaap Keuter [EMAIL PROTECTED] wrote: Hi, 1) It would be nice to have a generalized concept. 2) I'm not really happy with the Taps/Statistics moniker on this item. I mean, as a user I don't know what a 'Tap' is. Neither that it's the mechanism to get

Re: [Wireshark-dev] Tap preferences

2008-04-23 Thread Martin Mathieson
be a start. Thanx, Jaap Martin Mathieson wrote: Hi, On Wed, Apr 23, 2008 at 7:20 AM, Jaap Keuter [EMAIL PROTECTED] mailto:[EMAIL PROTECTED] wrote: Hi, 1) It would be nice to have a generalized concept. 2) I'm not really happy with the Taps/Statistics moniker

Re: [Wireshark-dev] [Wireshark-bugs] [Bug 2226] New: Mismatching /proto element in a PDML explort

2008-01-28 Thread Martin Mathieson
In order to conform to the schema, we'd need to insist that items were always added inside protocol trees, and not directly in to the top-level tree passed to dissectors. The TCP dissector writes unparsed data into the top-level tree. I know that I also added an ARP entry to the top-level tree

Re: [Wireshark-dev] 3GPP RLC and MAC protocols support

2008-01-09 Thread Martin Mathieson
? Since RRC is from the ASN.1, I've not tried it yet, but any pointers appreciated. Neil From: [EMAIL PROTECTED] [mailto: [EMAIL PROTECTED] On Behalf Of Martin Mathieson Sent: 08 January 2008 11:26 To: Developer support list for Wireshark Subject: Re: [Wireshark-dev] 3GPP RLC and MAC

Re: [Wireshark-dev] 3GPP RLC and MAC protocols support

2008-01-08 Thread Martin Mathieson
BTW is anyone planning on hooking RRC NAS message IEs into gsm_a_dtap ? Since RRC is from the ASN.1, I've not tried it yet, but any pointers appreciated. Neil -- *From:* [EMAIL PROTECTED] [mailto: [EMAIL PROTECTED] *On Behalf Of *Martin Mathieson *Sent:* 08

Re: [Wireshark-dev] RTCP frame length error indication in RTCP with a Bye chunk

2007-12-20 Thread Martin Mathieson
Could you please post this as a capture? Remember that the string is NULL terminated, and that this is part of the length On Dec 20, 2007 2:34 PM, Herculano Antonio Lambert Duarte [EMAIL PROTECTED] wrote: Hi! When the RTCP packet has a BYE chunk included, there is an expert message RTCP

Re: [Wireshark-dev] undefined symbol: h225_ReleaseCompleteReason_vals

2007-12-19 Thread Martin Mathieson
A colleague of mine had exactly this problem. A library from a previous (distribution) installation was being picked up instead of the one he was building and trying to run. We never did find out exactly where it was - we just uninstalled the distrubution package and the problem went away. Hope

[Wireshark-dev] RFC: Detecting duplicate IP addresses [PATCH]

2007-12-17 Thread Martin Mathieson
Hi, I want to see an expert item to report when wireshark can see that more than one endpoint is configured with the same IP address. The approach this (not-fully-tested-yet) patch takes is to pick IP/MAC pairs out of ARP requests/reponses and maintain an IP-MAC hash table. Should this work -

Re: [Wireshark-dev] [Wireshark-commits] rev 23765: /trunk/plugins/wimax/ /trunk/plugins/wimax/: packet-wmx.c

2007-12-05 Thread Martin Mathieson
On Dec 5, 2007 10:28 AM, [EMAIL PROTECTED] wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=23765 User: guy Date: 2007/12/05 10:28 AM Log: To generate a session-lifetime string given a format and va_list, use se_strdup_vprintf(). Directory: /trunk/plugins/wimax/

Re: [Wireshark-dev] [Wireshark-commits] rev 23761: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-ms-mms.c

2007-12-05 Thread Martin Mathieson
On Dec 5, 2007 9:31 AM, [EMAIL PROTECTED] wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=23761 User: guy Date: 2007/12/05 09:31 AM Log: Make the protocol field big enough to hold the 3-character null-terminated string that the format item used when scanning says

[Wireshark-dev] PDCP/ROHC support

2007-11-23 Thread Martin Mathieson
Hi, I'm toying with the idea of working on a dissector or dissectors that would decode PDCP headers and their embedded RoHC (rfc3095, later) packets. Rather than try to cleverly guess context state without seeing configuration information, I would initially decode these packets using the

Re: [Wireshark-dev] Seting up build env. and building from a tarball

2007-11-22 Thread Martin Mathieson
I recently followed the instructions found in http://www.wireshark.org/docs/wsdg_html_chunked/ChSetupWin32.html#ChSetupMSVC and it worked like a charm. These steps do include installing the platform SDK. Martin On Nov 22, 2007 5:50 PM, Anders Broman [EMAIL PROTECTED] wrote: Hi, I just got

Re: [Wireshark-dev] Is there a good way of handling bitfields withdifferent bitmask offsets ?

2007-11-14 Thread Martin Mathieson
I used the not-long-since-added proto_tree_add_bits_ret_val() in packet-umts_fp.c. There is also proto_tree_add_bits_item() which doesn't extract the value for you. Are these functions not suitable for your purpose? It certainly simplified the part of the code I needed it for. Martin On Nov

[Wireshark-dev] Can epan/xmlstub be removed now

2007-10-26 Thread Martin Mathieson
Hi, Diameter no longer uses xmlstub, and there are no other in-tree users of it. Should we delete it now? Martin ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] wimaxintel.dll

2007-10-22 Thread Martin Mathieson
Hi Etay, For the question you are asking - have you looked at the Mac-to-Mac plugin checked in at the same time as the wimax R1 plugin? The source code can be viewed at: http://anonsvn.wireshark.org/viewvc/viewvc.py/trunk/plugins/m2m/packet-m2m.c?view=log If you want to use a different framing,

[Wireshark-dev] [Patch] to fix Windows build

2007-10-18 Thread Martin Mathieson
Hi, Could someone please check in this patch to add eth_stdio_open() to libwireshark.def, as its used by the wimaxasncp plugin? (I just did my first ever Windows build :) using the anonymous svn tree :( ). The alternative would be to instead make that dissector a plugin now (which would also

Re: [Wireshark-dev] [Patch] to fix Windows build

2007-10-18 Thread Martin Mathieson
With patch. On 10/18/07, Martin Mathieson [EMAIL PROTECTED] wrote: Hi, Could someone please check in this patch to add eth_stdio_open() to libwireshark.def, as its used by the wimaxasncp plugin? (I just did my first ever Windows build :) using the anonymous svn tree :( ). The alternative

Re: [Wireshark-dev] [Wireshark-commits] rev 23176: /trunk/packaging/u3/win32/ /trunk/packaging/u3/win32/: makefile.nmake

2007-10-14 Thread Martin Mathieson
Hi Anders, Could you (or anyone else) please add the line: if not exist $(DEVICE)\radius $(MKDIR) $(DEVICE)\wimaxasncp to the device-dirs section? Hopefully the u3 build will then be able to run to completion. Best regards, Martin On 10/14/07, [EMAIL PROTECTED] [EMAIL PROTECTED]

Re: [Wireshark-dev] [Wireshark-bugs] [Bug 1903] wimaxasncp: TLVsdefined in XML files

2007-10-12 Thread Martin Mathieson
with Diameter, Radius etc so we don't have to move it later? Regards Anders -- *Från:* [EMAIL PROTECTED] [mailto: [EMAIL PROTECTED] *För *Martin Mathieson *Skickat:* den 11 oktober 2007 19:15 *Till:* wireshark-dev@wireshark.org *Ämne:* Re: [Wireshark-dev

Re: [Wireshark-dev] [Wireshark-bugs] [Bug 1903] wimaxasncp: TLVs defined in XML files

2007-10-11 Thread Martin Mathieson
On 10/11/07, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1903 --- Comment #11 from [EMAIL PROTECTED] 2007-10-11 09:34 GMT --- Just to be clear - I was thinking of people having the flexibility to offer the very latest plugin code

Re: [Wireshark-dev] [Wireshark-bugs] [Bug 1848] New WiMAX ASN Protocol (WMXA) Dissector

2007-10-09 Thread Martin Mathieson
by then. Thanks On 10/5/07, Martin Mathieson [EMAIL PROTECTED] wrote: Hi, Have you looked at this new submission in detail, or tried it out? Does it handle anything that is missing from the current one we have, or handle something in a better way? I don't actually work with WiMAX

Re: [Wireshark-dev] [Wireshark-bugs] [Bug 1848] New WiMAX ASN Protocol (WMXA) Dissector

2007-10-05 Thread Martin Mathieson
Hi, Have you looked at this new submission in detail, or tried it out? Does it handle anything that is missing from the current one we have, or handle something in a better way? I don't actually work with WiMAX, and haven't asked colleagues who do to play with this new submission. I was hoping

Re: [Wireshark-dev] WiMAX ASN Control Protocol dissector submission status?

2007-09-07 Thread Martin Mathieson
On 9/7/07, Wen Cheng [EMAIL PROTECTED] wrote: Hi all, Great job Stephen. I'm a wimax tester, I really like your tool. But I think the display pattern of TLVs is not very good from a tester point of view. May I help to do some improvment work? This dissector has already been useful to us,

Re: [Wireshark-dev] WiMAX ASN Control Protocol dissector submission status?

2007-09-06 Thread Martin Mathieson
as: WS_VAR_IMPORT const value_string sminmpec_values[]; where WS_VAR_IMPORT is defined as extern in my Linux config.h Any ideas? Martin On 9/6/07, Martin Mathieson [EMAIL PROTECTED] wrote: Sorry about the delay on this. I'm just about to pour a cup of tea and do it now. Thanks again for submitting

Re: [Wireshark-dev] WiMAX ASN Control Protocol dissector submission status?

2007-09-06 Thread Martin Mathieson
I also note that the following line appears in epan/libwireshark.def sminmpec_values DATA On 9/6/07, Martin Mathieson [EMAIL PROTECTED] wrote: I checked this in earlier today, but have the following remaining Windows warning/error. packet-wimaxasncp.c(4151) : error C2099

Re: [Wireshark-dev] [Wireshark-commits] rev 22586: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-ip.c

2007-08-29 Thread Martin Mathieson
On 8/24/07, Martin Mathieson [EMAIL PROTECTED] wrote: Especially as its such a lower-layer protocol. I think the best thing may be either: - just revert my change, or maybe - add something to the long text indicating that its 13 bits OK, I did the 2nd option (i.e. don't use remove bitmask

<    1   2   3   4   >