Re: [Wireshark-dev] Wireshark Developer's Guide bad URL

Can you push a change to gerrit? If you can't I'll do it for you. On Wed, Nov 20, 2019 at 1:21 AM Gavin Higham wrote: > I noticed on this page of the Wireshark Developer's Guide something that > looks like it should have become a URL after a text replacement: > >

Re: [Wireshark-dev] HomePlug AV dissector issues

Hi John You can submit a bug report and/or a patch yourself. https://www.wireshark.org/docs/wsdg_html_chunked/ChSrcContribute.html On Fri, Oct 25, 2019 at 10:39 AM John Serock wrote: > I noticed two issues with the dissection of HomePlug AV packets. I'm using > Wireshark 2.4.16, but the issues

Re: [Wireshark-dev] Migrate to GitLab?

On Tue, Oct 8, 2019 at 10:47 AM Guy Harris wrote: > > git push origin HEAD:feature-number-1 > > And can I then do a "git commit --amend" and another "git push origin > HEAD:feature-number-1" to fix issues found in the review/Petri dish/going > back and looking at what I did process? > You're

Re: [Wireshark-dev] Migrate to GitLab?

I don't like merge commits and polluted history as well, then that's how I configured my projects on gitlab. Merge commits are disabled, only fast forward merges are allowed. This requires every merge request to be rebased before merging. Moreover I configured successful CI as a requirement for

Re: [Wireshark-dev] QtCustomPlot: New Defects reported by Coverity Scan for Wireshark

On Wed, Sep 25, 2019 at 8:24 AM Roland Knall wrote: > Hi Jaap > > I was in contact with the original developer of QCustomPlot. According to > his statement, this warning is a false-positive, as it cannot occur with > real numbers. > > Maybe I'm wrong but I read 20769

Re: [Wireshark-dev] Nameclash in ieee80211 RM Report

Hi Patches in wireshark go through gerrit. You can find how here https://www.wireshark.org/docs/wsdg_html_chunked/ChSrcContribute.html Feel free to ask for more help if needed. Dario. On Wed, Sep 18, 2019, 20:55 Aleksej Matis wrote: > Hi, > > while working on a project involving wireshark I

Re: [Wireshark-dev] Shard Output Format

; > > https://github.com/oripka/wireshark/commit/c9d39a54f4f182ef2784c660a6e51f4b6a782523 > > All the best, > > Oliver > > > According to Dario Lombardo on Fri, Sep 13 2019: > > > Which sharks commands are you using? > > > > On Fri, Sep 13, 2019

Re: [Wireshark-dev] Shard Output Format

Which sharks commands are you using? On Fri, Sep 13, 2019 at 1:23 PM Oliver-Tobias Ripka wrote: > Hello List, > > I am looking to influence the output format of the sharkd json. > > For example tshark -T fields -e tcp.flags.syn, formats the flag as 0 or 1 > > Sharkd outputs "Set", "Not Set"

[Wireshark-dev] payload_proto_id in SCPT dissector

Hi, I'm working on fixing a bug reported by oss-fuzz, and I got stuck. The payload is TLS over SCPT. In the sctp dissector the variable payload_proto_id is read from the tlv in dissect_data_chunk. What is it supposed to contain? Which proto_id? Following the stack trace, this value is passed to

Re: [Wireshark-dev] Petri Dish Buildbot failure

Moreover, be sure your code compiles on the master. Changes are expected to run on top of it. Backport to older versions happen for bugfixes only. Since it looks to me this is not your case it is basically pointless to test it on top of stable versions. On Wed, Aug 14, 2019 at 6:26 PM Graham

Re: [Wireshark-dev] (34169) Pre-commit check failing incorrectly?

The message is telling you that ENC_BIG_ENDIAN has been used on a FT_UINT8 fiield, that is 1 byte long, then no point is setting the endianess. From a quick look of the dissector I can tell that hf_cdp_data has been used with variable lengths. What's its len? If it's a variable len field ("data"

Re: [Wireshark-dev] Passwordlist in Wireshark - User feedback wanted

The change has been merged. More protocols can be instrumented now to add credentials to the tap. Any request to add new protocols is welcome: contact me or file a new bug for additions. On Tue, Jun 25, 2019 at 4:45 PM Dario Lombardo wrote: > > > On Thu, Jun 20, 2019 at 12:34 PM

Re: [Wireshark-dev] Passwordlist in Wireshark - User feedback wanted

On Thu, Jun 20, 2019 at 12:34 PM Sake Blok | SYN-bit wrote: > > Sounds like a good compromise to me! > > Sake > > A quick update on the change: https://code.wireshark.org/review/c/33453/ The code has been changed according to the feedback received. The credentials table now lists the packet

Re: [Wireshark-dev] IO Graphs wording

Personally I like I/O as well. I am pleased that search engines can understand both IO and I/O, but I like that applications still use I/O in labels. Then, unless someone objects, I'd go with a patch to use I/O everywhere. On Sat, Jun 15, 2019 at 11:04 PM Guy Harris wrote: > On Jun 15, 2019, at

Re: [Wireshark-dev] Passwordlist in Wireshark - User feedback wanted

On Mon, Jun 17, 2019 at 1:42 PM Sake Blok | SYN-bit wrote: > Hi Dario, > To me for troubleshooting issues, it is sufficient to see the usernames > and sometimes extract a password, but I do not need a list of them > For security awareness, you do not need the passwords, just the protocol > and

Re: [Wireshark-dev] Passwordlist in Wireshark - User feedback wanted

Hi Sake On Mon, Jun 17, 2019 at 7:01 AM Sake Blok | SYN-bit wrote: > Personally I don't like the option to have a central place to add > credential information to show to the user. I think this crosses the (very > thin) line between "being able to see a password" and "being a tool to > extract

Re: [Wireshark-dev] Passwordlist in Wireshark - User feedback wanted

On Sun, Jun 16, 2019 at 10:00 PM Guy Harris wrote: > > Would providing this capability as a "third-party" plugin (even if the > "third party" happens to be a Wireshark core developer) work? *Wireshark* > doesn't offer it as a built-in capability, but you can drop in a plugin to > get it. > > It

[Wireshark-dev] IO Graphs wording

Hi A user reported a misalignment in the codebase for IO Graphs vs I/O Graphs. Indeed there is a mix of the two of them. What should be the correct wording? Dario. -- Naima is online. ___ Sent via:Wireshark-dev mailing

Re: [Wireshark-dev] Passwordlist in Wireshark - User feedback wanted

Actually no code for extracting credentials has been added. It's a tap that collects them and shows a table with them. The credentials already exist in wireshark in clear text. 2 protocols have been instrumented so far, http (basic and header auth) and ftp. On Sat, Jun 15, 2019, 09:57 Tomasz Moń

Re: [Wireshark-dev] IDE for C development on Linux

They're not IDEs but I'd suggest sublime and atom. They're very lightweight but powerful. I use sublime for editing the code and the shell for compiling under linux with ninja. On Mon, Jun 3, 2019, 18:54 Paul Offord wrote: > Thanks both. > > > > I didn’t realise Visual Studio Code even existed

Re: [Wireshark-dev] core dump when parsed VoIP call with text media

This probably triggered an error hidden in the debug code of the VOIP dissector. Your define popped it up. The error message says that a line of code tried to use a wmem scope when it's not active. Eg. It tries to allocate memory in the "file" scope when no files are open. You should use a

Re: [Wireshark-dev] Git hooks

> Jaap > > > On 20 May 2019, at 10:36, Dario Lombardo wrote: > > > > Hi list > > In the current development process we're trying to enforce the > contribution quality by providing git hooks that help the developer to push > better changes. > >

[Wireshark-dev] Git hooks

Hi list In the current development process we're trying to enforce the contribution quality by providing git hooks that help the developer to push better changes. Those hooks are provided in the 'tools' directory. According to the developer instructions they must be copied to .git/hooks to be used

Re: [Wireshark-dev] Building a custom rpm from the source tarball, post 3.0

If I'm not mistaken, that's a known bug. It should be fixed by https://code.wireshark.org/review/c/33214/ On Wed, May 15, 2019 at 11:12 PM Maynard, Chris wrote: > In the old days prior to Wireshark 3.0, one could visit > *https://www.wireshark.org/download/src/all-versions/* >

[Wireshark-dev] Duplicate fields

Hi I'm working on bug 15719 (duplicate fields in elastic-mapping report). I've found some fields that are duplicated in the fields list. A couple of examples: _ws.type_length.mismatch This field is registered as ei as PI_ERROR and PI_WARN. This makes sense to me. This however raises an error

Re: [Wireshark-dev] Script extcap on macOS

On Thu, Apr 18, 2019 at 1:56 PM Dario Lombardo wrote: > Are the extcap expected to be under build/run/extcap on macOS or elsewhere? > I guess I found the answer myself. tshark -G folders on travis builds give /Users/travis/build/crondaemon/wireshark/build/run/Wireshark.app/Contents

Re: [Wireshark-dev] CMake Error [CMAKE_MAKE_PROGRAM is not set] while building wireshark from source

There is a complimentary script under tools, that does that dirty job. It's debian-setup.sh and supports Ubuntu. On Thu, Apr 18, 2019 at 1:16 PM Abhisek Techie wrote: > Hi , > > I am trying to build wireshark from source in *Ubuntu 18.04.2 LTS* and > getting Cmake error . I am following the

Re: [Wireshark-dev] Script extcap on macOS

> cheers > Roland > > Am Do., 18. Apr. 2019 um 12:20 Uhr schrieb Dario Lombardo < > lom...@gmail.com>: > >> >> >> On Fri, Apr 12, 2019 at 10:32 PM Guy Harris wrote: >> >>> On Apr 12, 2019, at 1:22 PM, Roland Knall wrote: >>> >>>

Re: [Wireshark-dev] Script extcap on macOS

On Fri, Apr 12, 2019 at 10:32 PM Guy Harris wrote: > On Apr 12, 2019, at 1:22 PM, Roland Knall wrote: > > > There seems to be an issue on mac, depending how the original Wireshark > binary has been called. It seems to be, that by clicking on the icon, the > system python interpreter get's

Re: [Wireshark-dev] Script extcap on macOS

On Fri, Apr 12, 2019 at 10:23 PM Guy Harris wrote: > > Is Python 3 installed on the machine on which the test is being run? > > It is. All the test suite is python3 based and it's working. That's why I expected the extcap to work. It looks like the extcap is not the only test script using

Re: [Wireshark-dev] Script extcap on macOS

On Fri, Apr 12, 2019 at 10:14 PM Dario Lombardo wrote: > > https://travis-ci.org/crondaemon/wireshark/jobs/519284280 > > > This build actually comes from a tentative patch. A failing build on master is at the following link. https://travis-ci.org/crondaemon/wireshark

[Wireshark-dev] Script extcap on macOS

Hi In commit c442ee056bc46bcda59e473c00d5741ea90a1453 I've introduced a test extcap (actually written by Peter) to test the correct parsing of extcap sentences. This extcap is python3 based. Due to some limitations on script extcaps on windows

Re: [Wireshark-dev] Wiki access for DRBD documentation

You should use bugzilla instead, and reference the created bug with Bug: XXX just above the Change-Id: tag. On Tue, Mar 12, 2019 at 9:07 AM Joel Colledge wrote: > Hi, > > I would like to add a DRBD pcap to the wiki as requested in > https://code.wireshark.org/review/#/c/32332/ Could someone

Re: [Wireshark-dev] Could NOT find GLIB2 (missing: GLIB2_LIBRARY GLIB2_MAIN_INCLUDE_DIR)

Hi Mike Did you try the script tools/rpm-setup.sh? It should do the dirty job for you. It supports centos7. On Mon, Mar 11, 2019 at 5:07 PM Mike Mohler wrote: > Running into the following problem trying to make wireshark 3.0 on CentOS > 7. I have installed cmake and it is installed > in

Re: [Wireshark-dev] realtime dumpcap capability

Hi Marty Did you try nflog/nfqueue interface? If that is not fast enough (I haven't done any comparison), I'd suggest you to have a look at ntop projects (like n2disk). It basically depends if you want to high speed capture or dissection. If you can capture and analyze later, have a look at this

Re: [Wireshark-dev] Wireshark on Kali linux

> > +1 from me for this as well. The warning should be there for anyone not > realizing that this is dangerous, but having the option to mute that > warning for people who know (or think they do) what they're doing makes > sense. > > My only concern is that if we expect the distribution people to

Re: [Wireshark-dev] Wireshark on Kali linux

On Wed, Feb 6, 2019 at 11:26 PM João Valverde < joao.valve...@tecnico.ulisboa.pt> wrote: > > I think a warning for "running Wireshark/tshark as root is dangerous" is > very appropriate. There is a legitimate discussion to be had on whether > it should be more or less forceful and what to do about

Re: [Wireshark-dev] Wireshark on Kali linux

> This would mean that they'd have to build Wireshark differently from the default way it's built, using the "package for systems that run everything as root" option. That means a standard Debian package, built to run on a system where you *don't* run everything as root, so that you can leave the

Re: [Wireshark-dev] Wireshark on Kali linux

e to a new kali and you're back again with just the root account. At the moment I'm trying to change debian/rules to implement the patching of the Lua file when the package is installed on kali. Let's see where it goes. On Tue, Feb 5, 2019, 19:10 Guy Harris On Feb 5, 2019, at 8:48 AM, Dario Lomba

[Wireshark-dev] Wireshark on Kali linux

Hi Today I found out an annoying issue on kali. It ships with a pretty new version of wireshark, but when you launch it, an issue raises. This post describes the issue and proposes a fix, too. https://securityonline.info/run-wireshark-as-root-kali-linux/?cn-reloaded=1 I know that the problem is

[Wireshark-dev] Force rebase in Gerrit

Hi, Yesterday I cherry-picked a change into master-2.4 ( https://code.wireshark.org/review/c/31842/). I triggered the PD and it failed due to something not related to the change. Now the master-2.4 has been fixed and I need to rebase the change. Gerrit shows me Change is up to date with the

Re: [Wireshark-dev] patching ASN.1 dissectors

tch the code was to init the asn1_ctx with a proper value_ptr, when created. Maybe that's not the right fix: if that's the case which patch do you suggest? On Thu, Jan 31, 2019 at 2:29 PM Pascal Quantin wrote: > Hi Dario, > > Le jeu. 31 janv. 2019 à 14:24, Dario Lombardo a écrit : >

[Wireshark-dev] patching ASN.1 dissectors

Hi I want to fix a bug in the tcap dissector, specifically in the function dissect_UniDialoguePDU_PDU. This is a generated dissector, therefore I've looked for the generating code, but I got lost in the maze of the generation of this dissector. Any help on which code in the tree I should change

Re: [Wireshark-dev] Memory leak debugging - current master passes all tests!

Impressive achievement, Peter! On Mon, Jan 28, 2019 at 10:03 PM Peter Wu wrote: > This does not mean that there are no more memory leaks though (we have > pretty bad test coverage) Have you ever tried to compute the coverage with, eg., gcov/lcov? I'm working on it but it's still a WIP. There

Re: [Wireshark-dev] Raspberry

On Tue, Jan 15, 2019 at 8:11 AM Jaap Keuter wrote: > You’re referring to the obsolete wheezy Debian/Raspbian release here. With > current stable Debian/Raspbian (stretch) you’ll get Wireshark 2.6.5, so > that should be fine. > Right, I mixed things up with distro names. I'd go with that

Re: [Wireshark-dev] Wireshark Flatpak

2019 at 12:31 PM Dario Lombardo wrote: > > > > On Mon, Jan 14, 2019 at 8:42 PM Richard Sharpe < > realrichardsha...@gmail.com> wrote: > >> > >> "A collection of flatpak manifest for building Microsoft Windows > >> applications with Wine via

Re: [Wireshark-dev] Wireshark Flatpak

On Mon, Jan 14, 2019 at 8:42 PM Richard Sharpe wrote: > "A collection of flatpak manifest for building Microsoft Windows > applications with Wine via flatpak" > > I agree, but where is this sentence coming from? ___ Sent

Re: [Wireshark-dev] Raspberry

I have compiled wireshark on raspberry pi a couple of years ago, and I fixed a couple of issues in the master. I'd suggest you to try to compile the master if 1) you are used to compile it 2) you can open bugs on bugzilla and test fixes back According to

[Wireshark-dev] GUI testing

Hi I am investigating technologies for testing the GUI component of Wireshark. I have in mind 2 scenarios 1) feature testing In this scenario I'd like to launch qt ui and have a software that acts like a user, by opening menus and clicking on buttons. The goal of it is to check that some features

Re: [Wireshark-dev] dfilter functions

e. > > Examples:count(ip.src) > 1 > > count(smpp.sequence_number) > 1(Since sequence_number is required > for the packet, having more than one shows frames with multiple PDUs. > > > > > > -Original Message- > > From: Dario Lombardo > &g

[Wireshark-dev] dfilter functions

Hi I've noticed that the online documentation about dfilter functions just talks about 2 of them, upper and lower: https://www.wireshark.org/docs/man-pages/wireshark-filter.html but there are more that are undocumented AFAICS: - len - size - count Can someone explain me their purpose and give

Re: [Wireshark-dev] Cannot get external capture (extcap) interface to work with my new plugin.

On Thu, Jan 3, 2019 at 5:36 PM hdv wrote: > > On 2-1-2019 18:30, Dario Lombardo wrote: > > You cannot trace your code using prints because they're handled by the > caller (dumpcap). Have a look at the other extcaps for --debug and > --debug-file options to see how it's solved

Re: [Wireshark-dev] Cannot get external capture (extcap) interface to work with my new plugin.

You cannot trace your code using prints because they're handled by the caller (dumpcap). Have a look at the other extcaps for --debug and --debug-file options to see how it's solved there. On Wed, Jan 2, 2019, 17:40 hdv I actually found the issue(s), there were multiple issues stacked on top >

Re: [Wireshark-dev] Lua minimum version

with Lua 5.1. On Wed, Dec 19, 2018 at 11:05 PM Peter Wu wrote: > On Wed, Dec 19, 2018 at 09:53:48AM +0100, Dario Lombardo wrote: > > Hi, > > which is the lua minimum version supported? > > CMake says: > * LUA (required version >= 5.1) > &

[Wireshark-dev] Lua minimum version

Hi, which is the lua minimum version supported? The commit commit 5953756305388724545f0df46d286be2f02c048a Author: Guy Harris Date: Mon Dec 17 10:57:20 2018 -0800 Add routines to load Lua programs that assume the path is UTF-8 on Windows. used lua_load with 5 params, that was introduced

Re: [Wireshark-dev] Gcc compiler version for redhat for Wireshark 2.9.0

Hi Jeff Here you can find some pipelines https://gitlab.com/wireshark/wireshark/pipelines compiling git master and stable branches. One of them is centos7 with gcc 4.8, that works fine. On Fri, Dec 7, 2018 at 5:10 PM Jeff Peng wrote: > Hi All, > > I tried to compile Wireshark 2.9.0 for

Re: [Wireshark-dev] No activity in Change 29980 for a while

I made you a couple of comments on 1st of Nov. I'm waiting your updates. On Mon, Nov 12, 2018 at 7:30 PM Ismael Mendez wrote: > Hi, > > Change 29980 seems to be > stalled. It has been a while and there is no review or any kind of > activity. Could you

Re: [Wireshark-dev] GDB / Fuzz test ?

On Mon, Nov 12, 2018 at 9:40 AM Antoine d'Otreppe wrote: > 2. I used the fuzz-test.sh, looks nice, but how many passes should I run > to have adequate testing? > That's an interesting question. I don't recall how many passes I used in the past for fuzzing my dissectors. Moreover no default

Re: [Wireshark-dev] GDB / Fuzz test ?

On Mon, Nov 12, 2018 at 9:40 AM Antoine d'Otreppe wrote: > Hi folks! > > I'm progressing in the syncthing dissector. Wireshark compiled without > hassle on Manjaro (Arch derivative). I love the wireshark codebase, it's > refreshing to see a large project that just works... > Thanks :). > > >

Re: [Wireshark-dev] Its possible to build and run wireshark from IDE

On Wed, Nov 7, 2018 at 5:39 PM Tomer Bar wrote: > i want to expose the validation of the display filter and use it like > service? > any idea? > > Do you want to do it programmatically (I mean you have a C code and you want to link with wireshark in some way) or can you do it running binary

Re: [Wireshark-dev] Why are ett[] arrays static?

On Fri, Oct 19, 2018 at 4:52 PM Jeff Morriss wrote: > It seems to me that making it static is just wasting space (keeping the > array around forever)? > > Interesting point, Jeff! Do you expect enough memory save that is worth of a massive change?

Re: [Wireshark-dev] No Interfaces found issue

What does it happen if you press F5 (load interfaces)? On Sat, Oct 6, 2018, 20:50 Igor Chetverovod wrote: > Hello list, > > I had compiled wireshark-2.6.3 (I am trying to develop a plugin) and after > start I see Wireshark window with message "No Interfaces found" . Also I > have installation

Re: [Wireshark-dev] Uncheck Use GSM SAPI values via Script

It's a preference. You can set it in each user preferences file using a script. The preference file is a text file. On Wed, Oct 3, 2018 at 2:16 PM John Powell wrote: > > Hi, > > Is there any way that I can set this via a script for all users on my > system running CENTOS7 without having to

Re: [Wireshark-dev] wireshark.org site feedback

On Sun, Sep 23, 2018 at 7:55 PM Guy Harris wrote: > > I'm not sure what the best place for reporting Wireshark Web site issues, > but they can be reported on the Wireshark Bugzilla: > > Indeed that's the right place. When creating a new bug, this page

Re: [Wireshark-dev] Gerrit

I intended to add Jasper in CC, as I told him. I just realized that the assignee field and reviewers are close in the new UI and I clicked on the wrong one. I'm still getting used to polygerrit. On Thu, Sep 13, 2018 at 11:30 AM Jasper Bongertz wrote: > Hello Peter, > > I think calling it as

Re: [Wireshark-dev] Is there any way to specify remote interfaces with tshark?

Hi Richard Are you talking about rpcap? If I'm not mistaken you can use rpcap://IP as interface name. On Sat, Sep 8, 2018 at 6:01 PM Richard Sharpe wrote: > Hi, > > I have built wireshark to use remote interfaces (with the correct > build of libpcap) and cannot find any way in tshark to specify

Re: [Wireshark-dev] Cannot push patch to Gerrit - Found WIP commit

Maybe this is not related, but shouldn't it be refs/for/master/ ? On Wed, Sep 5, 2018 at 5:39 PM Andrii Vladyka wrote: > I am trying to push a patch (single commit on top of the latest master > branch) with the following syntax: > > git push ssh://usern...@code.wireshark.org:29418/wireshark >

Re: [Wireshark-dev] Making .deb packages on Ubuntu 18.04 requires packages not installed by debian-setup.sh

They've been recently removed by me since they're not needed anymore to build wireshark. I'm not sure about adding them to the script: that would force anyone using it and just building (like me and all the debian based CI platforms that rely on it) to have autotools back. Perhaps a new cmd line

Re: [Wireshark-dev] Access to the menagerie

Hi Darien The menagerie is not public. However if you ask for a specific file someone with access can share it if its not private. On Fri, Aug 17, 2018, 16:48 Darien Spencer wrote: > Hey group > > I recently found some old bug reports of fuzzed/reduced pcaps and I would > like to access the

Re: [Wireshark-dev] Parsing openflow

Hi Avi Have a look at tshark and its -E and -e options. That could do the job. On Tue, Aug 14, 2018 at 1:19 PM Avi Cohen (A) wrote: > Hi > I need to capture open-flow msgs (e.g FLOW_MOD to add new flows) from > controller to vSwitch , > And to generate e.g. a *file* which its rows are the

Re: [Wireshark-dev] New commit emails after gerrit update

red due to more > kinds of activity. I updated it to send email only when refs/changes/* and > refs/tags/* are updated, which should match its old behavior. > > On 8/8/18 8:20 AM, Dario Lombardo wrote: > > I'm receiving emails like this for every commit email message for merged >

[Wireshark-dev] New commit emails after gerrit update

I'm receiving emails like this for every commit email message for merged changes. What do they exactly mean? Are they useful or not? Maybe I'm missing something but they don't seem really useful to me. -- Forwarded message - From: Wireshark code review Date: Wed, Aug 8, 2018 at

Re: [Wireshark-dev] Display more digits for NTP packet's root dispersion

On Wed, Aug 8, 2018 at 9:39 AM Martin Burnicki wrote: > So IMO it would make more sense to display such values with a fixed > floating point format similar to the Peer Clock Precision field, e.g. > > 0.00 instead of 0 > 0.944107 instead of 0.944107055664063 > 0.76 instead of

Re: [Wireshark-dev] Gerrit problems ?

On Wed, Aug 8, 2018 at 1:40 PM Jaap Keuter wrote: > I’m not sure what to make of this but I noticed the following: > After having a (rather unremarkable) change ( 28995) accepted and merged > by Anders (thanks Anders!) I received the usual two emails about this > (Code-Review +2, Merged). The

[Wireshark-dev] Gerrit down

Gerrit was expected to be upgraded yesterday. Now it seems down. Anyone has news about the upgrade process? -- Naima is online. ___ Sent via:Wireshark-dev mailing list Archives:

Re: [Wireshark-dev] Display more digits for NTP packet's root dispersion

On Mon, Aug 6, 2018 at 1:20 PM Martin Burnicki wrote: > > I think to do this would be easy for someone who is a bit familiar with > the wireshark source code. However, I'm new to this stuff so I can > potentially get it wrong unless I'm doing quite a bit of investigation > first. ;-) > > Don't

Re: [Wireshark-dev] Display more digits for NTP packet's root dispersion

Hi Martin If you can code the patch, feel free to push it to gerrit for code review. Otherwise, your best bet is bugzilla. Which login issues are you experiencing? On Mon, Aug 6, 2018 at 11:20 AM Martin Burnicki wrote: > Hi all, > > actually the root dispersion field from an NTP packet is only

Re: [Wireshark-dev] Wrongly escaped UTF-8 characters in JSON values ( epan/print.c )

Ok, got it. Again, the best chances not to get this lost is to file a bug on bugzilla. On Fri, Jul 6, 2018 at 1:47 PM Andrea Lo Pumo wrote: > *From*: Dario Lombardo > >> What do you mean by "I do not know the Wireshark code"? What did you >> patch? Do you mean y

Re: [Wireshark-dev] Wrongly escaped UTF-8 characters in JSON values ( epan/print.c )

On Thu, Jul 5, 2018 at 4:01 PM Andrea Lo Pumo wrote: > I do not know the Wireshark code, so I am not submitting a patch. This, > however, should work because JSON supports UTF-8 (see again [1]). > > What do you mean by "I do not know the Wireshark code"? What did you patch? Do you mean you don't

Re: [Wireshark-dev] Retrieving dissection result from another dissector

On Thu, Jul 5, 2018 at 9:53 AM Guy Harris wrote: > > Is there some reason to forbid dissectors called by the dissector for the > next protocol in the stack to fetch that data? > No. My concern was: if the stack is IP/TCP/MYPROTO1/MYPROTO2/MYPROTO3 and myproto3 gives back some info, and

Re: [Wireshark-dev] Retrieving dissection result from another dissector

What about, instead, introducing a new field in pinfo? Something like "result from dissection of the next proto in the stack, reported to the previous"? This could be a struct like struct dissection_data { guint dissection_data_type; gchar dissection_data; } dissection_data_t; The called

Re: [Wireshark-dev] Retrieving dissection result from another dissector

On Tue, Jul 3, 2018 at 8:49 PM Guy Harris wrote: > > Should we, instead, get rid of the scope arguments to those functions and, > instead, have separate functions, one of which serves the original purpose, > using file scope, and one of which serves this new purpose, using > pinfo->pool scope? >

Re: [Wireshark-dev] Retrieving dissection result from another dissector

Actually I'm using the blob to pass data from the caller to the called. I guess it's a design flow to re-use this blob to have data back... On Tue, Jul 3, 2018 at 5:01 PM Richard Sharpe wrote: > On Tue, Jul 3, 2018 at 7:55 AM, Dario Lombardo wrote: > > Hi > > In my dissector

[Wireshark-dev] Retrieving dissection result from another dissector

Hi In my dissector I need to call another dissector, and I'm using call_dissector_with_data(). I need to have back one result coming from the dissection (an integer) to use in the calling dissector. How can I do that? Thanks Dario. -- Naima is online.

Re: [Wireshark-dev] Push failed after amend (Change 27518)

You're trying to push to refs/publish/master/dicom-heuristic and that is used when you're promoting a change from draft to published. Gerrit requires you to push to refs/for/master/dicom-hauristic for regular commits. You don't have to force anything on gerrit. This is allowed in pure git only.

Re: [Wireshark-dev] Windows builds on appveyor

WOW it worked :). I used PLATFORM=win64, but your one was the good one :). On Thu, Jun 7, 2018 at 1:53 PM, Craig Jackson wrote: > I think you need PLATFORM=x64. > > Craig Jackson > > On Thu, Jun 7, 2018, 4:37 AM Graham Bloice > wrote: > >> On Thu, 7 Jun 2018 at 0

[Wireshark-dev] Windows builds on appveyor

Hi I'm trying to set up an automated windows builder on appveyor. https://ci.appveyor.com/project/crondaemon/wireshark I've followed the windows build instructions except for one step: "2.2.10. Open a Visual Studio Command Prompt". Since this is a CI, I can't open a visual studio prompt. The

Re: [Wireshark-dev] extcaps not showing up under windows

There's a fix under review here https://code.wireshark.org/review/#/c/27745/ that should fix the windows error. On Wed, May 23, 2018 at 9:17 AM, Dirk Eibach via Wireshark-dev < wireshark-dev@wireshark.org> wrote: > I have successfully setup a windows build-environment and did a wireshark >

Re: [Wireshark-dev] extcaps not showing up under windows

not changed anything in my Python extcaps. > > Again, please take a look at commit 68ec514b5f63e09a1628df321c0e52 > 40edd54edc > > /Kenneth > > 2018-05-23 14:44 GMT+02:00 Dario Lombardo <lom...@gmail.com>: > >> I'm trying to reproduce the case. Are the extca

Re: [Wireshark-dev] extcaps not showing up under windows

. I reverted those and it was working on Windows. > > > > Am Mi., 23. Mai 2018 um 15:10 Uhr schrieb Dario Lombardo <lom...@gmail.com > >: > >> I confirm this commit is the culprit. I'm trying to track down the bug. >> >> On Wed, May 23, 2018 at 2:51 PM, Kenne

Re: [Wireshark-dev] extcaps not showing up under windows

s. > > Again, please take a look at commit 68ec514b5f63e09a1628df321c0e52 > 40edd54edc > > /Kenneth > > 2018-05-23 14:44 GMT+02:00 Dario Lombardo <lom...@gmail.com>: > >> I'm trying to reproduce the case. Are the extcap compiled? Do they run >> properly from c

Re: [Wireshark-dev] extcaps not showing up under windows

I'm trying to reproduce the case. Are the extcap compiled? Do they run properly from cmdline? On Wed, May 23, 2018 at 1:13 PM, Kenneth Soerensen wrote: > Hi Roland > > This is a problem with all extcaps including the ones included with > Wireshark. > > /Kenneth > >

Re: [Wireshark-dev] Wpa test failure

On Thu, May 17, 2018 at 4:16 PM, Peter Wu wrote: > > The test requires Libgcrypt 1.6, I'll send a patch. > > I hoped you had some kind of clues :). Can't wait to see it. ___ Sent via:Wireshark-dev

Re: [Wireshark-dev] Wpa test failure

On Wed, May 16, 2018 at 5:09 PM, Maynard, Christopher < christopher.mayn...@igt.com> wrote: > Is there a problem with the environment perhaps? > > > > On Windows, I needed to set WIRESHARK_APPDATA to the location of the > 80211_keys file in order for this to work. > > > > Maybe HOME isn’t enough?

[Wireshark-dev] Wpa test failure

I'm playing with the test suite (make test-programs && make test). I hit a test that doesn't pass on ubuntu 14.04, but passes on 16.04. The test is test_80211_wpa_tdls This puzzles me a lot and I'd like to have some clues if someone has any. Basically the problems seems that the wpa keys are not

Re: [Wireshark-dev] compilation hangs on Ubuntu

Can you submit a change on Gerrit for it? On Mon, May 14, 2018, 19:58 Eugène Adell wrote: > > Thanks all for the help and Darius for finding out this conflict with > ninja. Building with an ordinary user works. > > > By the way, I have another small request. Could you

Re: [Wireshark-dev] compilation hangs on Ubuntu

Are you working on a fresh master and build dir? Can you post the output of lsb_release -a git checkout master git pull git describe mkdir build-fresh cd build-fresh cmake .. make You can use tools/debian-setup.sh to install the ubuntu packages (mandatory/optional). On Sun, May 13, 2018 at 5:15

Re: [Wireshark-dev] Overriding a builtin dissector

What about using proto_deregister_protocol? In your dissector (I guess it's a plug in one) you first deregister the builtin one, then you register yours with the same name. Would it work? On Wed, Apr 25, 2018, 19:50 Roland Knall wrote: > And I think this would be the case

[Wireshark-dev] SPEC files

Hi What is the difference between packaging/rpm/wireshark.spec.in and packaging/rpm/SPECS/wireshark.spec.in? During my last patches I updated the former, but now I realized that there is also the latter. -- Naima is online.

Re: [Wireshark-dev] Windows builds

It was so obvious that I missed it :). Thank you. On Sun, Apr 22, 2018 at 10:19 PM, Graham Bloice <graham.blo...@trihedral.com > wrote: > > > On 22 April 2018 at 20:14, Dario Lombardo <lom...@gmail.com> wrote: > >> Hi >> I'm upgrading my windows 7 vm from

<    1   2   3   4   5   >