Re: [Wireshark-dev] ISO 7816 vs GSM SIM dissector

2021-08-19 Thread Martin Kaiser
Hi Pascal and Stig, Thus wrote Pascal Quantin (pas...@wireshark.org): > Le mer. 18 août 2021 à 13:51, Stig Bjørlykke a écrit : > > Hi, > > Does anyone know the difference between the ISO 7816 dissector and the GSM > > SIM dissector? amongst other things, the iso7816 dissector includes the

Re: [Wireshark-dev] Growing memory with tshark & Lua

2020-11-21 Thread Martin Kaiser
Hi Thomas, Thus wrote Thomas Baudelet (thomas.baude...@gmail.com): > Hi Devs, > When Wireshark profiles are correctly tuned (few protocols, disabled TCP > reassembly & analysis, bytes tracking, timestamps calculations, IP defrag), > tshark memory doesn't grow at all. > Simply adding a simple

Re: [Wireshark-dev] lua decoder accessing info from layers above

2020-10-21 Thread Martin Kaiser
Thus wrote Maynard, Chris via Wireshark-dev (wireshark-dev@wireshark.org): > > From: Wireshark-dev On Behalf Of > > chuck c > > Sent: Wednesday, October 14, 2020 10:33 AM > > To: Developer support list for Wireshark > > Subject: Re: [Wireshark-dev] lua decoder accessing info from layers above

[Wireshark-dev] NEWS flle

2017-11-11 Thread Martin Kaiser
Dear all, CMake has a target "news" that copies the release notes into a NEWS file in the source directory. NEWS is under version control and hasn't been updated in the repository for a while. Should we remove NEWS from the repository? Should we modify the CMake target to leave the source

Re: [Wireshark-dev] MPEG2-TS, DVB-SI, and DVB-GSE Dissectors

2017-03-17 Thread Martin Kaiser
Hi Alexander, good to see you again. We worked together in the DVC-CI+ group back in 2014. I hope that I told you about Wireshark's CI+ dissector then ;-) Thus wrote Alexander Adolf (alexander.ad...@condition-alpha.com): > For both topics, I would expect one likely guidance I'll be receiving >

Re: [Wireshark-dev] [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64

2016-06-28 Thread Martin Kaiser
Build Source Stamp: [branch master] 5c03bda31af87bf08a404509cd0714df65471416 > Blamelist: Martin Kaiser <wiresh...@kaiser.cx> > BUILD FAILED: failed compile_3 RCC qrc_i18n.cpp RCC Parse Error: 'i18n.qrc' Line: 2 Column: 34 [unexpected text] make[2]: *** [qrc_i18n.cpp] Error 1 m

Re: [Wireshark-dev] cmake, linker flags, whitespace, cmp0004

2016-05-12 Thread Martin Kaiser
Hi Jörg, Thus wrote Joerg Mayer (jma...@loplof.de): > Hello Martin, > is this problem still open? yes, it's still open. Just tried it again on master. Best regards, Martin > Thanks >Jörg > On Sun, Apr 17, 2016 at 03:14:32PM +0200, Martin Kaiser wrote: > > I'm

[Wireshark-dev] warning if running with Qt4

2016-05-01 Thread Martin Kaiser
Hi Gerald, all, the current master shows this warning on a Qt4 system. martin@husavik:~/src/wireshark.git$ ./wireshark Object::connect: No such slot QScrollBar::setRange(int,int) in overlay_scroll_bar.cpp:74 The offending line is connect(this, SIGNAL(rangeChanged(int,int)), _sb_,

[Wireshark-dev] cmake, linker flags, whitespace, cmp0004

2016-04-17 Thread Martin Kaiser
Hi, I'm getting strange cmake errors on Debian Wheezy (cmake 2.8.9). -- Performing Test WS_LD_FLAG_VALID0 CMake Error at CMakeLists.txt:11 (ADD_EXECUTABLE): Target "cmTryCompileExec701976172" links to item " -Wl,--as-needed" which has leading or trailing whitespace. This is now an error

Re: [Wireshark-dev] proto_tree_add_text stats

2015-04-30 Thread Martin Kaiser
Thus wrote mman...@netscape.net (mman...@netscape.net): 2. There are 12 dissectors with 20-30 proto_tree_add_text calls packet-dvbci.c I'll look into this one, shouldn't be much of a problem. ___ Sent via:Wireshark-dev

Re: [Wireshark-dev] [Wireshark-commits] master 9b5a09a: [Automatic update for 2015-04-26]

2015-04-27 Thread Martin Kaiser
Thus wrote Graham Bloice (graham.blo...@trihedral.com): We're really close to not worrying about that :-) That's what I was hoping :-) I couldn't get the QMakefile to rebuild the .qm files correctly. There's a bunch of examples on the web, none of them would work for me. The cmake version

Re: [Wireshark-dev] Latest build modifies files?

2015-03-08 Thread Martin Kaiser
Thus wrote Guy Harris (g...@alum.mit.edu): On Mar 7, 2015, at 4:26 PM, Martin Kaiser li...@kaiser.cx wrote: Thus wrote Martin Kaiser (li...@kaiser.cx): I just pushed a change to create the .qm files for Qt's translated texts from the corresponding .ts files. My change handles

Re: [Wireshark-dev] Latest build modifies files?

2015-03-08 Thread Martin Kaiser
Thus wrote Richard Sharpe (realrichardsha...@gmail.com): Hi folks, After my most recent build I noticed this: # On branch master # Your branch is ahead of 'origin/master' by 1 commit. # (use git push to publish your local commits) # # Changes not staged for commit: # (use git add

Re: [Wireshark-dev] Latest build modifies files?

2015-03-07 Thread Martin Kaiser
Thus wrote Guy Harris (g...@alum.mit.edu): On Mar 7, 2015, at 12:59 PM, Richard Sharpe realrichardsha...@gmail.com wrote: Hi folks, After my most recent build I noticed this: # On branch master # Your branch is ahead of 'origin/master' by 1 commit. # (use git push to publish

Re: [Wireshark-dev] Latest build modifies files?

2015-03-07 Thread Martin Kaiser
Thus wrote Martin Kaiser (li...@kaiser.cx): I just pushed a change to create the .qm files for Qt's translated texts from the corresponding .ts files. My change handles the autotools build. I saw that the cmake build already support this. Does anyone know if the Windows nmake build creates

Re: [Wireshark-dev] On which platforms is there a need for Wireshark to have a Language preference?

2014-11-09 Thread Martin Kaiser
Thus wrote Guy Harris (g...@alum.mit.edu): In the best of all possible worlds, the only people who would have a reason to use something other than the system language would be people testing translations or reproducing bugs and testing fixes and that's definitely something that we'll have to

[Wireshark-dev] reassembly, addresses, hash calculation

2014-10-05 Thread Martin Kaiser
Hi, when I looked at bug 10505, I noticed the following code in packet-mp2t.c /* It's possible that a fragment in the same packet set an address already * This will change the hash value, we need to make sure it's NULL */ SET_ADDRESS_HF(pinfo-src, AT_NONE, 0, NULL, 0);

Re: [Wireshark-dev] [Wireshark-commits] master 64cd827: Have dissect_usb_setup_request handle non-standard requests

2014-08-27 Thread Martin Kaiser
Hi Sean, Thus wrote Stalley, Sean (sean.stal...@intel.com): I think we should discuss how to clean up the usb dissector. It seems like we are running into the too many cooks in the kitchen scenario. So far, our changes co-existed nicely. Now's the first time they were in conflict ;-) My

Re: [Wireshark-dev] [Wireshark-commits] master 64cd827: Have dissect_usb_setup_request handle non-standard requests

2014-08-26 Thread Martin Kaiser
The new req_type is the same as the existing type. There's a switch(type) {...} followed by in if (req_type==...). My goal is to have only one call to try_dissect_next_protocol(). In dissect_usb_common(), we dissect the standard fields in the main switch-statement and call

Re: [Wireshark-dev] [Wireshark-commits] master 64cd827: Have dissect_usb_setup_request handle non-standard requests

2014-08-26 Thread Martin Kaiser
Hi Pascal, Thus wrote Pascal Quantin (pascal.quan...@gmail.com): I spotted a regression myself (that seems similar to what you report) and proposed https://code.wireshark.org/review/#/c/3858/ to fix it. Could you give it a try on your sample? looks good to me, I just merged it. Best

[Wireshark-dev] should extcap dir be a preference?

2014-08-26 Thread Martin Kaiser
Hi, at the moment, the directory for the extcap binaries is defined at compile time. When I first tried extcap a year ago, I created a patch to make the extcap directory a preference. This was much easier for me to handle when I played with several extcaps that needed frequent recompiling. I'd

Re: [Wireshark-dev] [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64

2014-08-25 Thread Martin Kaiser
://buildbot.wireshark.org/trunk/builders/OSX%2010.6%20x64/builds/5016 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: osx-10.6-x64 Build Reason: scheduler Build Source Stamp: [branch master] c284e1211296361d1548e8f98a7ccc51c621019f Blamelist: Martin Kaiser wiresh

Re: [Wireshark-dev] Adding a new dissector - beginners guide

2014-08-21 Thread Martin Kaiser
Thus wrote Thomas Wiens (th.wi...@gmx.de): I thought, with git add file I am saying: look only on this files and ignore all others. No, that's what you say with svn add. svn tracks files, git tracks changes. git add file means add the changes I made to this file into the next commit. What is

Re: [Wireshark-dev] [Wireshark-commits] master 1194061: clear the temporary components of usb_conv_info_t before we dissect a new packet

2014-08-20 Thread Martin Kaiser
Frankly, conversation structures shouldn't have per-packet data in them at all; this was probably the easiest way to fix the fuzz failure, but it really seems odd to me that it even needs to be done. Thoughts? True. Per-packet data shouldn't be part of the conversation struct. I'm working

Re: [Wireshark-dev] switching to proto_tree_add_subtree()

2014-07-29 Thread Martin Kaiser
Thus wrote darkjames...@darkjames.pl (darkjames...@darkjames.pl): Hi, On Mon, Jul 28, 2014 at 10:47:43PM +0200, Martin Kaiser wrote: However, I don't quite understand why for tree!=NULL but not visible, proto_tree_add_text() returns tree. I can see this in the code, we call

[Wireshark-dev] buildbot troubles

2014-07-29 Thread Martin Kaiser
Hi, I made a (seemingly simple) change to the DVB-CI dissector and ran it through the buildbot. The Ubuntu x86_64 one failed gcc: internal compiler error: Segmentation fault (program as) Please submit a full bug report, with preprocessed source if appropriate. See

[Wireshark-dev] switching to proto_tree_add_subtree()

2014-07-28 Thread Martin Kaiser
Hi all, I'm sending out some unsorted thoughts, hoping that you can help me understand the issue I'm seeing. After the switch to proto_tree_add_subtree(), I found that some output of the DVB-CI dissector was different than before. Replacing ti = proto_tree_add_text(tree, tvb, offset,

[Wireshark-dev] tvb_get_string_enc() doesn't always return valid UTF-8

2014-01-20 Thread Martin Kaiser
Hi, if I have a tvbuff that starts with 0x86 and I call a = tvb_get_string_enc(tvb, 0, ENC_ASCII) proto_tree_add_string(..., a); I can trigger the DISSECTOR_ASSERT since a is not a valid unicode string. Comments in the code suggest that tvb_get_string() should replace chars=0x80 with the

Re: [Wireshark-dev] tvb_get_string_enc() doesn't always return valid UTF-8

2014-01-20 Thread Martin Kaiser
Thus wrote Evan Huus (eapa...@gmail.com): I think we'd agreed that the right thing to do is to convert most of our string functions to handle and return counted strings (wmem_strbuf_t or something) and then do the replacement as you suggest. There are several other outstanding encoding issues

Re: [Wireshark-dev] [Wireshark-commits] rev 54662: /trunk/ui/qt/ /trunk/ui/qt/: main_window.h main_window_slots.cpp

2014-01-08 Thread Martin Kaiser
Thanks. I saw earlier today that the authors list would not appear when I ran from the build directory. This was because the main window (and the about window) were created before init_progfile_dir() was called. Your checkin fixed that as well. In GTK, we create the main window much later than

Re: [Wireshark-dev] FT_BYTES hf with len==0

2013-12-20 Thread Martin Kaiser
Thus wrote Martin Kaiser (li...@kaiser.cx): Thus wrote Jakub Zawadzki (darkjames...@darkjames.pl): proto_item_fill_label() allows empty bytes: 5389 case FT_BYTES: 5390 case FT_UINT_BYTES: 5391 bytes = (guint8 *)fvalue_get(fi-value); 5392 label_fill

Re: [Wireshark-dev] FT_BYTES hf with len==0

2013-12-20 Thread Martin Kaiser
Thus wrote Martin Kaiser (li...@kaiser.cx): 5392 label_fill(label_str, 0, hfinfo, 5393 (bytes) ? bytes_to_str(bytes, fvalue_length(fi-value)) : MISSING); 5394 break; It'd be good to make them consistent, allow empty bytes (+1

Re: [Wireshark-dev] FT_BYTES hf with len==0

2013-12-18 Thread Martin Kaiser
Thus wrote Guy Harris (g...@alum.mit.edu): Do you mean this is a byte array field that has a length that can range from 0 to {some maximum value}, so that the field might have some value in some packets and a length of 0 in others (in which case the default value is used). In r54145, I

Re: [Wireshark-dev] FT_BYTES hf with len==0

2013-12-18 Thread Martin Kaiser
Thus wrote Jakub Zawadzki (darkjames...@darkjames.pl): proto_item_fill_label() allows empty bytes: 5389 case FT_BYTES: 5390 case FT_UINT_BYTES: 5391 bytes = (guint8 *)fvalue_get(fi-value); 5392 label_fill(label_str, 0, hfinfo, 5393

[Wireshark-dev] FT_BYTES hf with len==0

2013-12-16 Thread Martin Kaiser
Dear all, is it allowed to add an FT_BYTES hf entry with len==0 to the protocol tree? E.g. proto_tree_add_bytes_format_value(tree, hf_myproto_myval, tvb, offset, 0, NULL, format, ...) The idea would be to allow filtering for this element although it has no value (it's just there). When I

Re: [Wireshark-dev] Move plugins/ to epan/dissectors/plugins/

2013-12-11 Thread Martin Kaiser
Thus wrote Joerg Mayer (jma...@loplof.de): I'd like to move the plugins/ directory into epan/dissectors/. They provide just more dissectors and depend on epan anyway. Are there good reasons not to do that move? Couldn't we have plugins for fileformats (wiretap) or taps as well?

[Wireshark-dev] r53871, test.sh decryption failure

2013-12-08 Thread Martin Kaiser
Hi Jakub and all, sorry for causing problems with the DVB-CI decryption test. Does this fail for others as well? If so, could you send me the output of tshark \ -o dvb-ci.sek: \ -o dvb-ci.siv: \ -Tfields -e

Re: [Wireshark-dev] [Wireshark-commits] rev 53619: /trunk/ /trunk/: NEWS

2013-11-28 Thread Martin Kaiser
Thus wrote Guy Harris (g...@alum.mit.edu): On Nov 27, 2013, at 3:09 PM, jma...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=53619 User: jmayer Date: 2013/11/27 11:09 PM Log: Having a generated file in the source tree is not fun. Should we

[Wireshark-dev] wmem_strbuf_printf()

2013-09-15 Thread Martin Kaiser
Dear all, I just looked at the radius dissector and saw the call to ep_strbuf_printf(), which has no wmem equivalent. I guess wmem_strbuf_printf() could be as simple as void wmem_strbuf_printf(wmem_strbuf_t *strbuf,

Re: [Wireshark-dev] wmem_strbuf_printf()

2013-09-15 Thread Martin Kaiser
Thanks Pascal Evan, Thus wrote Pascal Quantin (pascal.quan...@gmail.com): on my side while converting some dissectors to wmem, I replaced the ep_strbuf_printf by: - either a call to wmem_strbuf_append_printf directly if it was the first time the buffer was filled that's the case for

[Wireshark-dev] reported_length -1

2013-09-07 Thread Martin Kaiser
Dear all, I stumbled on tvb_new_subset(tvb, 10, (tvb_get_guint8(tvb, 1) - 2), (tvb_get_guint8(tvb, 1) - 2)); If tvb_get_guint8(tvb, 1)==0, we throw an exception because of backing_length - that makes sense. As for reported_length-1, it looks like that's ok when the tvb is created. There'll

Re: [Wireshark-dev] reported_length -1

2013-09-07 Thread Martin Kaiser
Hi Pascal, Thus wrote Pascal Quantin (pascal.quan...@gmail.com): 2013/9/7 Martin Kaiser li...@kaiser.cx tvb_new_subset(tvb, 10, (tvb_get_guint8(tvb, 1) - 2), (tvb_get_guint8(tvb, 1) - 2)); As for reported_length-1, it looks like that's ok when the tvb is created. There'll

[Wireshark-dev] SET_ADDRESS, if-else

2013-09-07 Thread Martin Kaiser
Hi, I just found that if (...) SET_ADDRESS(...); else SET_ADDRESS(...); does not compile as this would expand to if (...) { }; else { } and the compiler complains about else without if. Is there anything useful we could do about this other that putting another pair of brackets around

Re: [Wireshark-dev] Enabling linux kernel jit compiler from dumpcap?

2013-08-23 Thread Martin Kaiser
before we change it, should we remember the previous setting and restore it when dumpcap exits? Thus wrote Anders Broman (a.bro...@bredband.net): Bálint Réczey skrev 2013-08-22 23:02: Hi, I would be happier if the applications I run did not change kernel configuration without my consent. I

Re: [Wireshark-dev] dissect_sip_tcp_heur()

2013-08-12 Thread Martin Kaiser
I'm not really familiar with SIP over TCP (in all my use cases, SIP is over UDP) but your proposal makes sense. Thanks Pascal, that explains why nobody spotted this so far. I committed the change in r51313 and I'll schedule it for backporting to 1.10 and 1.8 if nobody complains. Best

[Wireshark-dev] dissect_sip_tcp_heur()

2013-08-10 Thread Martin Kaiser
I came across this while browsing through the coverity defects. gboolean first = TRUE; is never changed Does the following change make sense to those who are familiar with SIP? diff --git a/epan/dissectors/packet-sip.c b/epan/dissectors/packet-sip.c index fa317c8..c04a0c8 100644 ---

Re: [Wireshark-dev] [Wireshark-commits] rev 51037: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-dvbci.c

2013-07-30 Thread Martin Kaiser
Thus wrote Joerg Mayer (jma...@loplof.de): On Tue, Jul 30, 2013 at 08:05:49PM +, mart...@wireshark.org wrote: provide a mechnism to exclude some CI+ SAC messages from being exported in the clear by the export PDU mechanism use this mechanism to exclude SAC messages that contain CCK

Re: [Wireshark-dev] long options again

2013-07-16 Thread Martin Kaiser
Thus wrote Gisle Vanem (gva...@broadpark.no): Brandon Carpenter hashs...@pnnl.gov wrote: I have to say that I dislike getopt() and getopt_long() for option parsing because of the disconnect between the options and the help. It creates multiple places that require updating when options

[Wireshark-dev] long options again

2013-07-15 Thread Martin Kaiser
Hi, this was discussed months ago, I also raised this briefly at Sharkfest - but I changed my mind since then. Guy Harris skrev 2013-04-09 00:32: On Apr 8, 2013, at 3:02 PM, Anders Broman a.bro...@bredband.net wrote: I think we have getopt_long already

Re: [Wireshark-dev] something in -r 50382:50384 epan/dissectors/packet forces warning: 'ddsti' may be used uninitialized in this function

2013-07-07 Thread Martin Kaiser
Thus wrote Evan Huus (eapa...@gmail.com): Martin fixed this in r50386 by initializing that variable, though I think it was a typo in commit r50384 that changed ddti to ddsti? you're right I fixed the typo in r50435 ___

Re: [Wireshark-dev] Proposed Gerrit workflow (was: Re: Notes from Sharkfest '13)

2013-06-22 Thread Martin Kaiser
Thus wrote Bálint Réczey (bal...@balintreczey.hu): I have started describing a Gerrit based workflow which IMO would fit to the project at http://wiki.wireshark.org/Development/Workflow . Please check it and share your opinion. would that mean that even the most basic change needs peer review

Re: [Wireshark-dev] Proposed Gerrit workflow (was: Re: Notes from Sharkfest '13)

2013-06-22 Thread Martin Kaiser
Hi Balint, Thus wrote Bálint Réczey (bal...@balintreczey.hu): We can relax the rules for Core Developers to let them bypass the peer review, but I did not want to include this exception in the first proposal. Speaking of myself I would be OK with requiring peer review for all my commits,

Re: [Wireshark-dev] [Wireshark-commits] rev 50097: /trunk/epan/ /trunk/epan/dissectors/: Makefile.am Makefile.common /trunk/epan/: Makefile.am

2013-06-21 Thread Martin Kaiser
Thus wrote Guy Harris (g...@alum.mit.edu): On Jun 20, 2013, at 5:15 PM, Gerald Combs ger...@wireshark.org wrote: On 6/20/13 5:13 PM, Evan Huus wrote: Very cool. I'm starting to wonder now if the file dissectors should be named file-foo.c instead of packet-foo.c? That makes sense to

Re: [Wireshark-dev] read/write capture comments from the command line

2013-04-10 Thread Martin Kaiser
Thus wrote Guy Harris (g...@alum.mit.edu): Sounds like a job for capinfos. You're right, that's where it should go. And for capinfos, the cmdline options don't have to be aligned with wireshark/tshark/dumpcap ;-) (I assume by capture file comment you mean the comment in the first Section

[Wireshark-dev] read/write capture comments from the command line

2013-04-04 Thread Martin Kaiser
Dear all, I was asked by some people about access to capture comments from the command line tools. We identified two use cases - You have a capture file and want to display its capture file comment. Nothing but the comment, no packets etc. - You start a capture from the command line and want

[Wireshark-dev] libgcrypt 1.5.0 compiler warnings

2013-02-21 Thread Martin Kaiser
Dear all, this issue has been around for a long time. When we use libgcrypt 1.5.0, including gcrypt.h spills out lots of warnings about deprecated definitions, breaking compilation with -Werror. Steven Fisher asked about this on the libgcrypt list

Re: [Wireshark-dev] libgcrypt 1.5.0 compiler warnings

2013-02-21 Thread Martin Kaiser
Hi, Thus wrote Gerald Combs (ger...@wireshark.org): On 2/21/13 12:47 AM, Martin Kaiser wrote: If that's too error-prone as people may include gcrypt.h elsewhere in the future and forget to add the pragmas, we could have a wrapper include file (epan/crypt/ws-libgcrypt.h ?) with the 4 lines

[Wireshark-dev] error: logical with non-zero constant will always evaluate as true

2012-12-29 Thread Martin Kaiser
Dear all, I get this warning (error) when I compile svn head peektagged.c: In function ???wtap_file_read_till_separator???: peektagged.c:150: error: logical ?? with non-zero constant will always evaluate as true make[2]: *** [libwiretap_la-peektagged.lo] Error 1 The offending line is

Re: [Wireshark-dev] error: logical with non-zero constant will always evaluate as true

2012-12-29 Thread Martin Kaiser
Thus wrote Martin Kaiser (li...@kaiser.cx): which seems to evaluate on my system (debian squeeze) more specifically martin@skogar:~$ gcc -v Using built-in specs. Target: x86_64-linux-gnu Configured with: ../src/configure -v --with-pkgversion='Debian 4.4.5-8' --with-bugurl=file:///usr/share/doc

Re: [Wireshark-dev] [Wireshark-commits] rev 46111: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-bssgp.c

2012-11-21 Thread Martin Kaiser
Thus wrote Anders Broman (a.bro...@bredband.net): Guy Harris skrev 2012-11-21 22:10: if(len 0){ next_tvb = tvb_new_subset(tvb, offset, len, len); dissect_s1ap_SONtransferApplicationIdentity_PDU(tvb, gpinfo, tree, NULL); } Should it be passing next_tvb to

Re: [Wireshark-dev] Compiling Plugin error

2012-11-19 Thread Martin Kaiser
Hi Matteo, Jeff, Thus wrote Jeff Morriss (jeff.morriss...@gmail.com): Matteo Di Cosmo wrote: Dear all, I'm new in Wireshark and I'm trying to sniff IPMI packets throught a i2c bus. To do this I need to compile a plugin which has been previously developed in the context of

Re: [Wireshark-dev] [Wireshark-commits] rev 45566: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-rdp.c

2012-10-18 Thread Martin Kaiser
Hi, Thus wrote Maynard, Chris (christopher.mayn...@gtech.com): Recently, I found and fixed some of these problems, but obviously I didn't catch them all. Are there any more thoughts about changing tvb_length_remaining() and tvb_reported_length_remaining() to return 0 instead of -1? it

[Wireshark-dev] initializing a variable with a non-constant value

2012-10-14 Thread Martin Kaiser
Hi, doc/README.developer says Don't initialize variables in their declaration with non-constant values. Not all compilers support this. E.g. don't use guint32 i = somearray[2]; ... In file.c, read_packet(), we do const struct wtap_pkthdr *phdr = wtap_phdr(cf-wth); union

[Wireshark-dev] parsing an IPv6 address from a text string

2012-10-14 Thread Martin Kaiser
Hi, as part of #7729, we have to parse a text string that contains an IPv6 address and convert it into a sequence of bytes - and detect malformed addresses. The current proposal does the parsing manually. I was wondering if we could simplify things by using getaddrinfo(). It seems that it's

[Wireshark-dev] order of include files

2012-10-04 Thread Martin Kaiser
Hi, should the order in which we include files make any difference? #include epan/packet.h #include epan/expert.h - ok #include epan/expert.h #include epan/packet.h - failure expert.h needs packet_info.h, which is included by packet.h Trivial fix is of course to include packet_info.h in

Re: [Wireshark-dev] [Wireshark-commits] rev 45227: /trunk/ui/gtk/ /trunk/ui/gtk/: main_statusbar.c

2012-10-01 Thread Martin Kaiser
Thus wrote Maynard, Chris (christopher.mayn...@gtech.com): Capture comments can be added/removed through the summary dialog as well. and that obviously invokes a different callback function. Which does not update the statusbar icon. Thanks for spotting this. I'll commit a fix soon.

Re: [Wireshark-dev] Passing data from Plugin dissector to a standard wireshark dissector (i.e. TCP)

2012-08-12 Thread Martin Kaiser
Hi Hammad, Thus wrote hammad kabir (hammadsa...@gmail.com): I have recently implemented a wireshark dissector of a relatively simple protocol (lets call the protocol as COOL) for a project of mine. This dissector gets the data from IP layer and then parses it according to protocol definition

[Wireshark-dev] why does dissector_try_uint_new() return gboolean?

2012-07-24 Thread Martin Kaiser
Dear all, I have a tvbuff that contains one or more dvb sections. I don't know the number of sections or their lengths (only the overall length but that doesn't really matter). Each table starts with a tag, I can get the dissector table for dvb/mpeg sections and call dissector_try_uint_new(...)

Re: [Wireshark-dev] PCAP-NG metadata support

2012-07-20 Thread Martin Kaiser
Hi Brandon, Thus wrote Carpenter, Brandon J (brandon.carpen...@pnnl.gov): If so, what is the best way to make the patch available? I'll post more details with the patch. open a bug at https://bugs.wireshark.org/bugzilla/ and attach your patch. Best regards, Martin

[Wireshark-dev] cmake build of r43639 fails

2012-07-10 Thread Martin Kaiser
Dear all, I'm building r43639 using cmake, this fails at [ 78%] Built target tshark [ 78%] Built target codecs [ 88%] Built target gtkui Linking C executable wireshark lib/libgtkui.a(main_menubar.c.o):(.rodata+0x27d4): undefined reference to `rlc_lte_graph_cb' collect2: ld returned 1 exit status

Re: [Wireshark-dev] Wireshark with QT

2012-07-07 Thread Martin Kaiser
Hi, Thus wrote Akos Vandra (axo...@gmail.com): I'm having problems building wireshark with Qt. I'm trying to build on Ubuntu 10.04LTS x64, with QT 4.7.0, qmake 2.01a, latest svn revision at the moment, r43597. I used the following commands to build: autoconf ./configure

[Wireshark-dev] compile error on linux, r43534

2012-06-28 Thread Martin Kaiser
Hi, r43534 does not compile on linux. gcc -DHAVE_CONFIG_H -I. -I. -I./wiretap -DINET6 -DG_DISABLE_DEPRECATED -DG_DISABLE_SINGLE_INCLUDES -DGSEAL_ENABLE -DGTK_DISABLE_DEPRECATED -DGTK_DISABLE_SINGLE_INCLUDES -D_FORTIFY_SOURCE=2 -D_U_=__attribute__((unused)) -I/usr/local/include

Re: [Wireshark-dev] compile error on linux, r43534

2012-06-28 Thread Martin Kaiser
Thus wrote Martin Kaiser (li...@kaiser.cx): r43534 does not compile on linux. I assume that file_util.h should be included, trivial patch attached. ok, Jeff was faster than me ;-) ___ Sent via:Wireshark-dev mailing

[Wireshark-dev] warning - error in r41911

2012-04-03 Thread Martin Kaiser
Hi Graham and all, r41911 gives a warning on my system packet-dcerpc-spoolss.c: In function âdissect_spoolss_string_parm_dataâ: packet-dcerpc-spoolss.c:497: error: âitemâ may be used uninitialized in this function make[5]: *** [libdissectors_la-packet-dcerpc-spoolss.lo] Error 1 make[5]: ***

[Wireshark-dev] warning-error in r41867

2012-03-31 Thread Martin Kaiser
Dear all, there's a warning in r41867 cc1: warnings being treated as errors main_menubar.c:3874: error: set_menu_visible defined but not used make[2]: *** [libgtkui_a-main_menubar.o] Error 1 Trivial fix is attached. Best regards, Martin Index: ui/gtk/main_menubar.c

[Wireshark-dev] packet-mpeg-descriptor.c, unsused variable

2012-03-16 Thread Martin Kaiser
Dear all, @Guy M: thanks a lot for the mpeg descriptor dissector, this is great! while compiling it, I've got a warning == error about an unused variable in the parental rating descriptor. Trivial patch attached, thanks, Martin Index: epan/dissectors/packet-mpeg-descriptor.c

Re: [Wireshark-dev] Mentioning encapsulation type in Protocol column

2012-03-13 Thread Martin Kaiser
Hi Lori and all, Thus wrote Lori Jakab (lja...@ac.upc.edu): AFAIK, currently the protocol displayed in the Protocol column of Wireshark is that of the last dissector called on the packet. This makes it difficult to distinguish among packets with or without some type of encapsulation, unless

Re: [Wireshark-dev] Data not getting formatted for custom columns added

2012-03-03 Thread Martin Kaiser
Thus wrote ashish goel (ashish.kumar.go...@gmail.com): I have defined some custom columns through preferences - Columns. and I want the data of these columns to be formatted as strings not raw bytes. I have used VALS() function in my dissector code while registering fields and it is working

Re: [Wireshark-dev] Unable to build wireshark-1.6.5

2012-03-01 Thread Martin Kaiser
Thus wrote Munish Dayal (munish.da...@aricent.com): I am unable to compile wireshark-1.6.5 source code due to the following error. Build environment is Linux RHEL5. The compilation machine is not connected to the internet. Is there a way to bypass this step ? /usr/bin/perl

[Wireshark-dev] basic questions about writing dissectors

2012-02-26 Thread Martin Kaiser
Dear all, I'm playing with some enhancements to my dissectors, some basic questions came up: Is it possible to add an element in the packet tree that has an hf entry and can be filtered but does not have a corresponding tvb? I'm looking at getting info from a circuit and add this to the tree as

Re: [Wireshark-dev] basic questions about writing dissectors

2012-02-26 Thread Martin Kaiser
Hi Joerg, thanks for your quick reply. Thus wrote Joerg Mayer (jma...@loplof.de): Take a look at packet-extreme.c and search for hf_edp_checksum_good (similar code can be found in other dissectors). The core point is setting the item to PROTO_ITEM_SET_GENERATED. Does this do what you want?

[Wireshark-dev] packet-mip, vendor_id, r41171

2012-02-24 Thread Martin Kaiser
Hi, I get a warning(==eror) compiling the latest svn [ 5%] Building C object epan/CMakeFiles/epan.dir/dissectors/packet-mip.c.o /home/martin/wireshark.svn/epan/dissectors/packet-mip.c: In function 'dissect_mip_extensions': /home/martin/wireshark.svn/epan/dissectors/packet-mip.c:424:11: error:

Re: [Wireshark-dev] Decode MTP3 message

2012-02-24 Thread Martin Kaiser
Thus wrote Anya Verizi (anya_ver...@hotmail.com): Can anyone know how I can decode MTP3 message? For example I put code in txt file and then to pcap (text2pcap -l 141 file.txt file.pcap ), but when I open it in wireshark I got malformed packet:ISUP? Do I )must put some in txt file before? in

Re: [Wireshark-dev] Decode MTP3 message

2012-02-24 Thread Martin Kaiser
Thus wrote Anya Verizi (anya_ver...@hotmail.com): I have to decode this sequence 02 00 10 c0 00 19 81 0f 0f 00 2c 01 01 11 02 16 00 00 but when I put it in txt and run as pcap I got this Frame 1 (23 bytes on wire, 23 bytes captured) Arrival Time: Feb 24, 2012 13:38:09.0

Re: [Wireshark-dev] pcapng, must opt_commentstring?be?0-terminated?

2012-01-29 Thread Martin Kaiser
Hi Chris, Thus wrote Chris Maynard (chris.mayn...@gtech.com): Martin Kaiser lists@... writes: I was wondering why we need a static buffer at all. It looks like the intention is to keep using the same buffer for each option that we parse. When reading an option, how about checking

Re: [Wireshark-dev] Conference room before FOSDEM

2012-01-29 Thread Martin Kaiser
Dear all, Thus wrote Graham Bloice (graham.blo...@trihedral.com): As the FOSDEM Friday beer event, http://fosdem.org/2012/beerevent takes place at Delirium I'm not intending to miss it. that's for sure, we have to be there and see how many of the 2000 different beers are actually in stock ;-)

[Wireshark-dev] warning in packet-rohc, r40673

2012-01-23 Thread Martin Kaiser
Hi Anders and all, I get a warning (treated as an error) martin@greta:~/src/wireshark.svn$ svn info ... Last Changed Author: etxrab Last Changed Rev: 40673 Last Changed Date: 2012-01-23 22:13:10 +0100 (Mon, 23 Jan 2012) martin@greta:~/src/wireshark.svn$ uname -a Linux greta 2.6.32-5-amd64

Re: [Wireshark-dev] Conference room before FOSDEM

2012-01-21 Thread Martin Kaiser
Hi Gerald, Thus wrote Gerald Combs (ger...@wireshark.org): Can any developer who is attending FOSDEM *and* would like to meet at the hotel on Friday the 3rd send me an email? I'm working on booking a conference room for the day and need to size the room accordingly. you can count me in, I'll

Re: [Wireshark-dev] Dates for FOSDEM 2012: 4 5 February

2012-01-18 Thread Martin Kaiser
Thus wrote Joerg Mayer (jma...@loplof.de): On Tue, Jan 17, 2012 at 03:17:48PM -0800, Gerald Combs wrote: I've stayed at the Novotel Brussels Centre Tour Noire, which was nice. It looks like it's within walking distance of the Friday event:

Re: [Wireshark-dev] Fwd: [FOSDEM] Dates for FOSDEM 2012: 4 5 February

2012-01-14 Thread Martin Kaiser
Thus wrote Gerald Combs (ger...@wireshark.org): On 1/5/12 3:19 AM, Sake Blok wrote: Gerald, Are plans to meet around FOSDEM finalized? For me it would be possible to meet up during the day on Friday 3rd (after which we could join the FOSDEM Beer Event :-)). I could either drive up

Re: [Wireshark-dev] pcapng, must opt_comment string be?0-terminated?

2012-01-12 Thread Martin Kaiser
Thus wrote Chris Maynard (chris.mayn...@gtech.com): To avoid the possibility of reading past the end of option_content in the case when oh.option_length sizeof(option_content), I think it would be safer to do this instead: wblock-data.packet.opt_comment = g_strndup(option_content,

Re: [Wireshark-dev] Fwd: [FOSDEM] Dates for FOSDEM 2012: 4 5 February

2011-12-29 Thread Martin Kaiser
Hello Gerald and all, Thus wrote Gerald Combs (ger...@wireshark.org): Sorry for taking so long to get back to you on this. We don't have a devroom, but we might be able to find a spot in one of the existing rooms. Alternatively I might be able to reserve a conference room at a nearby hotel.

[Wireshark-dev] non-official X.509 certificate extensions

2011-11-13 Thread Martin Kaiser
Dear all, I would like to add ASN.1 definitions for some non-official certificate extensions. They should be visible and usable by one certain dissector but not disturb everyone else. It seems that some extensions have their own asn1/... subdirectory but they're globally visible. Could I create

[Wireshark-dev] RSASSA-PSS (bug #6541)

2011-11-10 Thread Martin Kaiser
Dear all, I'm trying to add support for RSASSA-PSS signatures in X.509 certificates. It's in a state where things are working for me, but I'm not sure that I understood the ASN.1 handling in wireshark well enough. Could anybody who's familiar with ANS.1 dissection spare some minutes and look at

[Wireshark-dev] compile warning/error on current svn (make_menu_actions)

2011-10-14 Thread Martin Kaiser
Dear all, compiling r39420 fails for me on redhat fc 15. main_menubar.c:3698:1: error: 'make_menu_actions' defined but not used [-Werror=unused-function] In main_menubar.c, the only place where make_menu_actions() is called is inside an #ifdef HAVE_LUA_5_1. Should we have #ifdef HAVE_LUA_5_1

Re: [Wireshark-dev] Send info to plugin

2011-10-07 Thread Martin Kaiser
Thus wrote Guy Harris (g...@alum.mit.edu): We should probably also add a notion of conversations available to dissectors at multiple layers (a notion more general than the current address-and-port-endpoint-pair notion, that can include multiple address layers, circuits for protocols that have

Re: [Wireshark-dev] [Wireshark-commits] rev 39143: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-dvbci.c

2011-09-26 Thread Martin Kaiser
Hi^2, Thus wrote Maynard, Chris (christopher.mayn...@gtech.com): So that would be option (c) then? c) Define ENC_NA differently from both ENC_LITTLE_ENDIAN and ENC_BIG_ENDIAN. ah, ENC_NA == ENC_BIG_ENDIAN == 0x0 at the moment. That's the problem you mentioned in your 1st mail? The impact of

Re: [Wireshark-dev] [Wireshark-commits] rev 39143: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-dvbci.c

2011-09-26 Thread Martin Kaiser
Dear all, I wanted to discuss this as well to make sure that my next submissions are in line with your policy, but you were faster ;-) Thus wrote Maynard, Chris (christopher.mayn...@gtech.com): -Original Message- From me: Change ENC_NA to ENC_BIG_ENDIAN as i suppose this is a

Re: [Wireshark-dev] Fwd: [FOSDEM] Dates for FOSDEM 2012: 4 5 February

2011-09-13 Thread Martin Kaiser
Hi Gerald and all, Thus wrote Gerald Combs (ger...@wireshark.org): Would anyone be interested in meeting at FOSDEM in February for a Wireshark Bug Day? As I recall, someone suggested this at Sharkfest. I'd be happy to join this and get to know the wireshark people in person. Best regards,

Re: [Wireshark-dev] strange crash when a display filter is cleared on a reassembled packet

2011-09-01 Thread Martin Kaiser
} - this one's content is invalid and still passed on to other routines, leading to a crash Any idea how to shed some light on this? Best regards, Martin Thus wrote Martin Kaiser (li...@kaiser.cx): Dear all, I'm struggling with a strange crash, I'd really appreciate your help. It may be that my

  1   2   >