Re: [Wireshark-dev] Compiling with or without extcap

[Guy Harris]

For what it's worth, libpcap 1.8 and later don't require that a local interface 
be openable before listing it in pcap_findalldevs(), so, whilst you might still 
need dumpcap to *capture* packets, it should be possible to *enumerate* 
interfaces directly within Wireshark/TShark with libpcap 1.8 and later, as you 
shouldn't need elevated privileges to enumerate interfaces.  This might speed 
up the process.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Compiling with or without extcap

[Anders Broman]

Hi,
This is run on a standard Windows7 PC with just the default extcaps.
This is the interfaces with the Preference off
C:\Development\wsbuild64>run\RelWithDebInfo\dumpcap.exe -D
1. \Device\NPF_{33D2B022-D2AC-40A3-BE47-C81B4F2EC346} (Wireless Network Connecti
on)
2. \Device\NPF_{F592C5E2-78A5-4C2C-87B5-4BB8682C9020} (Bluetooth Network Connect
ion)
3. \Device\NPF_{F0030874-E9A6-4B3F-8441-45E492FE6157} (Local Area Connection)

And it’s with winpcap.
Regards
Anders


From: Wireshark-dev [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of 
Roland Knall
Sent: den 9 januari 2018 15:12
To: Developer support list for Wireshark <wireshark-dev@wireshark.org>
Subject: Re: [Wireshark-dev] Compiling with or without extcap

I have 5 extcaps, and the difference is about half a second. Would be 
interesting, what kind of devices you have in your extcap list.

But in general, I still think the main time is loading the rest of interfaces, 
extcap is a very small part, just pushed the whole time over the top.

cheers

On Tue, Jan 9, 2018 at 2:38 PM, Anders Broman 
<anders.bro...@ericsson.com<mailto:anders.bro...@ericsson.com>> wrote:
Hi,
Startup time with extcap:
14:29:56.217 Main Info Wireshark is up and ready to go, elapsed time 
5485000 us

Startup time with the new extcap parameter OFF
14:30:40.559 Main Info Wireshark is up and ready to go, elapsed time 
3521000 us

Still a lot of time is spent with the local interfaces

14:30:39.304 Main Info fill_in_local_interfaces() starts
:
14:30:40.216 Main Info fill_in_local_interfaces() ends, taking 0.912s
14:30:40.216  Dbg  FIX: fetch recent color settings
14:30:40.216  Capture Dbg  sync_interface_stats_open
14:30:40.216  Capture Dbg  sync_pipe_open_command
14:30:40.497  Capture Dbg  read 6 indicator: S empty value
14:30:40.559 Main Info Wireshark is up and ready to go, elapsed time 3521000

Regards
Anders

-Original Message-
From: Wireshark-dev 
[mailto:wireshark-dev-boun...@wireshark.org<mailto:wireshark-dev-boun...@wireshark.org>]
 On Behalf Of Guy Harris
Sent: den 8 januari 2018 02:46
To: Developer support list for Wireshark 
<wireshark-dev@wireshark.org<mailto:wireshark-dev@wireshark.org>>
Subject: Re: [Wireshark-dev] Compiling with or without extcap
On Jan 7, 2018, at 3:19 PM, Roland Knall 
<rkn...@gmail.com<mailto:rkn...@gmail.com>> wrote:

> We had this discussion a bung of times. I have nothing against having a 
> preference, but I am very much against making not-loading extcap the default. 
> New users should not face a hassle to enable a capture interface, but 
> existing users, who wish to improve the performance in any way, can profit 
> from an option doing exactly that.
>
> So +1 on making this option available

+1

> big -1 on making it default to not-loading

+1 on the -1 :-)
___
Sent via:Wireshark-dev mailing list 
<wireshark-dev@wireshark.org<mailto:wireshark-dev@wireshark.org>>
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 
mailto:wireshark-dev-requ...@wireshark.org<mailto:wireshark-dev-requ...@wireshark.org>?subject=unsubscribe
___
Sent via:Wireshark-dev mailing list 
<wireshark-dev@wireshark.org<mailto:wireshark-dev@wireshark.org>>
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 
mailto:wireshark-dev-requ...@wireshark.org<mailto:wireshark-dev-requ...@wireshark.org>?subject=unsubscribe

___
Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark.org>
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Compiling with or without extcap

[Roland Knall]

I have 5 extcaps, and the difference is about half a second. Would be
interesting, what kind of devices you have in your extcap list.

But in general, I still think the main time is loading the rest of
interfaces, extcap is a very small part, just pushed the whole time over
the top.

cheers

On Tue, Jan 9, 2018 at 2:38 PM, Anders Broman <anders.bro...@ericsson.com>
wrote:

> Hi,
> Startup time with extcap:
> 14:29:56.217 Main Info Wireshark is up and ready to go, elapsed time
> 5485000 us
>
> Startup time with the new extcap parameter OFF
> 14:30:40.559 Main Info Wireshark is up and ready to go, elapsed time
> 3521000 us
>
> Still a lot of time is spent with the local interfaces
>
> 14:30:39.304 Main Info fill_in_local_interfaces() starts
> :
> 14:30:40.216 Main Info fill_in_local_interfaces() ends, taking 0.912s
> 14:30:40.216  Dbg  FIX: fetch recent color settings
> 14:30:40.216  Capture Dbg  sync_interface_stats_open
> 14:30:40.216  Capture Dbg  sync_pipe_open_command
> 14:30:40.497  Capture Dbg  read 6 indicator: S empty value
> 14:30:40.559 Main Info Wireshark is up and ready to go, elapsed time
> 3521000
>
> Regards
> Anders
>
> -Original Message-
> From: Wireshark-dev [mailto:wireshark-dev-boun...@wireshark.org] On
> Behalf Of Guy Harris
> Sent: den 8 januari 2018 02:46
> To: Developer support list for Wireshark <wireshark-dev@wireshark.org>
> Subject: Re: [Wireshark-dev] Compiling with or without extcap
>
> On Jan 7, 2018, at 3:19 PM, Roland Knall <rkn...@gmail.com> wrote:
>
> > We had this discussion a bung of times. I have nothing against having a
> preference, but I am very much against making not-loading extcap the
> default. New users should not face a hassle to enable a capture interface,
> but existing users, who wish to improve the performance in any way, can
> profit from an option doing exactly that.
> >
> > So +1 on making this option available
>
> +1
>
> > big -1 on making it default to not-loading
>
> +1 on the -1 :-)
> 
> ___
> Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark.org>
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org?subject=
> unsubscribe
> 
> ___
> Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark.org>
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org?subject=
> unsubscribe
>
___
Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark.org>
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Compiling with or without extcap

[Anders Broman]

Hi,
Startup time with extcap:
14:29:56.217 Main Info Wireshark is up and ready to go, elapsed time 
5485000 us

Startup time with the new extcap parameter OFF
14:30:40.559 Main Info Wireshark is up and ready to go, elapsed time 
3521000 us

Still a lot of time is spent with the local interfaces

14:30:39.304 Main Info fill_in_local_interfaces() starts
:
14:30:40.216 Main Info fill_in_local_interfaces() ends, taking 0.912s
14:30:40.216  Dbg  FIX: fetch recent color settings
14:30:40.216  Capture Dbg  sync_interface_stats_open
14:30:40.216  Capture Dbg  sync_pipe_open_command
14:30:40.497  Capture Dbg  read 6 indicator: S empty value
14:30:40.559 Main Info Wireshark is up and ready to go, elapsed time 3521000

Regards
Anders

-Original Message-
From: Wireshark-dev [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of 
Guy Harris
Sent: den 8 januari 2018 02:46
To: Developer support list for Wireshark <wireshark-dev@wireshark.org>
Subject: Re: [Wireshark-dev] Compiling with or without extcap

On Jan 7, 2018, at 3:19 PM, Roland Knall <rkn...@gmail.com> wrote:

> We had this discussion a bung of times. I have nothing against having a 
> preference, but I am very much against making not-loading extcap the default. 
> New users should not face a hassle to enable a capture interface, but 
> existing users, who wish to improve the performance in any way, can profit 
> from an option doing exactly that.
> 
> So +1 on making this option available

+1

> big -1 on making it default to not-loading

+1 on the -1 :-)
___
Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark.org>
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
___
Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark.org>
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Compiling with or without extcap

[Guy Harris]

On Jan 7, 2018, at 3:19 PM, Roland Knall  wrote:

> We had this discussion a bung of times. I have nothing against having a 
> preference, but I am very much against making not-loading extcap the default. 
> New users should not face a hassle to enable a capture interface, but 
> existing users, who wish to improve the performance in any way, can profit 
> from an option doing exactly that.
> 
> So +1 on making this option available

+1

> big -1 on making it default to not-loading

+1 on the -1 :-)
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Compiling with or without extcap

[Roland Knall]

We had this discussion a bung of times. I have nothing against having a
preference, but I am very much against making not-loading extcap the
default. New users should not face a hassle to enable a capture interface,
but existing users, who wish to improve the performance in any way, can
profit from an option doing exactly that.

So +1 on making this option available big -1 on making it default to
not-loading

cheers

On Sun, Jan 7, 2018 at 10:21 PM, Dario Lombardo  wrote:

>
>
> On Sun, Jan 7, 2018 at 12:02 AM, Stig Bjørlykke 
> wrote:
>
>> On Sat, Jan 6, 2018 at 7:15 PM, Dario Lombardo <
>> dario.lombardo...@gmail.com> wrote:
>>
>>> What about an environment variable that disable extcap interfaces
>>> loading?
>>>
>>
>> Or even better; a UI configurable preference to enable/disable extcap
>> interfaces.
>>
>> This should be default on.  When turned on or off it will automatically
>> run a "Refresh Interfaces" to load/unload extcap interfaces without having
>> to manually restart or "Refresh Interfaces".
>>
>> Sounds good!
> I'm working on 3 separate patches:
> 1) remove extcap ifdefs
> 2) prevent extcap loading based on env variable (during the review process
> we can decide whether to keep this or not)
> 3) prevent extcap loading based on pref.
>
> For the last one I'm just missing how to properly refresh the interface
> list. I've called wsApp->refreshLocalInterfaces() but the list doesn't
> get refreshed. Can you give it a look?
> Thanks.
> Dario.
>
> 
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org?subject=
> unsubscribe
>
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Compiling with or without extcap

[Dario Lombardo]

On Sun, Jan 7, 2018 at 12:02 AM, Stig Bjørlykke  wrote:

> On Sat, Jan 6, 2018 at 7:15 PM, Dario Lombardo <
> dario.lombardo...@gmail.com> wrote:
>
>> What about an environment variable that disable extcap interfaces loading?
>>
>
> Or even better; a UI configurable preference to enable/disable extcap
> interfaces.
>
> This should be default on.  When turned on or off it will automatically
> run a "Refresh Interfaces" to load/unload extcap interfaces without having
> to manually restart or "Refresh Interfaces".
>
> Sounds good!
I'm working on 3 separate patches:
1) remove extcap ifdefs
2) prevent extcap loading based on env variable (during the review process
we can decide whether to keep this or not)
3) prevent extcap loading based on pref.

For the last one I'm just missing how to properly refresh the interface
list. I've called wsApp->refreshLocalInterfaces() but the list doesn't get
refreshed. Can you give it a look?
Thanks.
Dario.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Compiling with or without extcap

[Stig Bjørlykke]

On Sat, Jan 6, 2018 at 7:15 PM, Dario Lombardo 
wrote:

> What about an environment variable that disable extcap interfaces loading?
>

Or even better; a UI configurable preference to enable/disable extcap
interfaces.

This should be default on.  When turned on or off it will automatically run
a "Refresh Interfaces" to load/unload extcap interfaces without having to
manually restart or "Refresh Interfaces".


-- 
Stig Bjørlykke
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Compiling with or without extcap

[Dario Lombardo]

What about an environment variable that disable extcap interfaces loading?
That would allow to remove the conditional compilation for extcap, and to
have the same startup speed as without pcap.
Roland, do you see anything wrong in doing this?

On Thu, Jan 4, 2018 at 3:47 PM, Anders Broman <anders.bro...@ericsson.com>
wrote:

>
>
>
>
> *From:* Wireshark-dev [mailto:wireshark-dev-boun...@wireshark.org] *On
> Behalf Of *Dario Lombardo
> *Sent:* den 4 januari 2018 15:22
> *To:* Developer support list for Wireshark <wireshark-dev@wireshark.org>
> *Subject:* Re: [Wireshark-dev] Compiling with or without extcap
>
>
>
>
>
>
>
> On Thu, Jan 4, 2018 at 3:10 PM, Anders Broman <anders.bro...@ericsson.com>
> wrote:
>
> I don’t have a problem with making extcap a mandatory feature of
> Wireshark. But since extcap prolongs the startup time and clutters the
> interface list.
>
> I would like a feature to turn some or all extcap interfaces off. I think
> it’s good to have them default available to make it obvious they exist but
> none of the default ones are particularly useful to me.
>
>
>
> >This is related to user experience, not compilation.
>
> Sure but the only(easiest) way to “get rid of them” currently is to not
> compile them 
>
>
>
> >Did you try to disable some interfaces group, main window, next to the
> filter? There is wired, wireless, USB and >external interfaces. Disable the
> last one and you get >rid of all extcaps (display only).
>
>
>
> I’m mostly annoyed by the startup delay.
>
>
>
> Regards
>
> Anders
>
> 
> ___
> Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark.org>
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org?subject=
> unsubscribe
>
___
Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark.org>
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Compiling with or without extcap

[Anders Broman]

From: Wireshark-dev [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of 
Dario Lombardo
Sent: den 4 januari 2018 15:22
To: Developer support list for Wireshark <wireshark-dev@wireshark.org>
Subject: Re: [Wireshark-dev] Compiling with or without extcap



On Thu, Jan 4, 2018 at 3:10 PM, Anders Broman 
<anders.bro...@ericsson.com<mailto:anders.bro...@ericsson.com>> wrote:
I don’t have a problem with making extcap a mandatory feature of Wireshark. But 
since extcap prolongs the startup time and clutters the interface list.
I would like a feature to turn some or all extcap interfaces off. I think it’s 
good to have them default available to make it obvious they exist but none of 
the default ones are particularly useful to me.

>This is related to user experience, not compilation.
Sure but the only(easiest) way to “get rid of them” currently is to not compile 
them 

>Did you try to disable some interfaces group, main window, next to the filter? 
>There is wired, wireless, USB and >external interfaces. Disable the last one 
>and you get >rid of all extcaps (display only).

I’m mostly annoyed by the startup delay.

Regards
Anders
___
Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark.org>
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Compiling with or without extcap

[Roland Knall]

Still, it looks for possible new extcap programs, which slows down the
systems a little bit I guess. But beside that, Dario is right, if you
disable all extcap, it behaves as if no extcap was present.



On Thu, Jan 4, 2018 at 3:21 PM, Dario Lombardo 
wrote:

>
>
> On Thu, Jan 4, 2018 at 3:10 PM, Anders Broman 
> wrote:
>
>> I don’t have a problem with making extcap a mandatory feature of
>> Wireshark. But since extcap prolongs the startup time and clutters the
>> interface list.
>>
>> I would like a feature to turn some or all extcap interfaces off. I think
>> it’s good to have them default available to make it obvious they exist but
>> none of the default ones are particularly useful to me.
>>
>
> This is related to user experience, not compilation. Did you try to
> disable some interfaces group, main window, next to the filter? There is
> wired, wireless, USB and external interfaces. Disable the last one and you
> get rid of all extcaps (display only).
>
> 
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org?subject=
> unsubscribe
>
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Compiling with or without extcap

[Dario Lombardo]

On Thu, Jan 4, 2018 at 3:10 PM, Anders Broman 
wrote:

> I don’t have a problem with making extcap a mandatory feature of
> Wireshark. But since extcap prolongs the startup time and clutters the
> interface list.
>
> I would like a feature to turn some or all extcap interfaces off. I think
> it’s good to have them default available to make it obvious they exist but
> none of the default ones are particularly useful to me.
>

This is related to user experience, not compilation. Did you try to disable
some interfaces group, main window, next to the filter? There is wired,
wireless, USB and external interfaces. Disable the last one and you get rid
of all extcaps (display only).
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Compiling with or without extcap

[Anders Broman]

From: Wireshark-dev [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of 
Dario Lombardo
Sent: den 4 januari 2018 13:41
To: Developer support list for Wireshark 
Subject: [Wireshark-dev] Compiling with or without extcap

During some reviews it went out again the point of compiling without pcap and 
without extcap. We've discussed a lot about pcap, but not that much about 
extcap.
Extcap is the feature to plug external modules, then it's not a core part, nor 
a mandatory feature. But it doesn't hurt: also without actual external modules, 
wireshark works perfectly fine with extcap support, doesn't it? Moreover it 
doesn't depend on any external library.
What about removing the conditional compilation for extcap? That would relieve 
the need for supporting another conditional compilation besides pcap. I'd like 
to hear some opinion, taking one side or another.
Cheers,
Dario.

Hi,
I don’t have a problem with making extcap a mandatory feature of Wireshark. But 
since extcap prolongs the startup time and clutters the interface list.
I would like a feature to turn some or all extcap interfaces off. I think it’s 
good to have them default available to make it obvious they exist but none of 
the default ones are particularly useful to me.
The SSH remote capture is potentially useful I suppose.
Just my 2 cents
Regards
Anders
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe