-devel] [PATCH v1 3/3] xen/arm: smmu: Renaming struct
iommu_domain *domain to, struct iommu_domain *iommu_domain
Hi Ian,
On 14/04/15 12:15, Ian Campbell wrote:
On Mon, 2015-04-06 at 16:15 +0200, Julien Grall wrote:
Hi Ian,
On 01/04/2015 10:30, Ian Campbell wrote:
On Tue, 2015-03-31 at 17:48 +0100
On Mon, 2015-04-06 at 16:15 +0200, Julien Grall wrote:
Hi Ian,
On 01/04/2015 10:30, Ian Campbell wrote:
On Tue, 2015-03-31 at 17:48 +0100, Stefano Stabellini wrote:
If it helps we could add a couple of comments on top of the structs in
smmu.c to explain the meaning of the fields, like:
On Tue, 2015-04-14 at 12:24 +, Jaggi, Manish wrote:
Hi Julien/Ian,
Please will you configure your mail client to do the chevron () style
of quotation favour in open source communities, picking out your replies
from the mail you are replying to is a massive chore, especially after a
couple of
On 14/04/15 13:24, Jaggi, Manish wrote:
[manish] Table is indeed a good option, but I think changing the name
of arm_smmu_xen_device to something like arch_smmu_device make more
sense as arm_smmu_xen_device and arm_smmu_device are not differentiable
just by name.
Can you explain how
Hi Ian,
On 01/04/2015 10:30, Ian Campbell wrote:
On Tue, 2015-03-31 at 17:48 +0100, Stefano Stabellini wrote:
If it helps we could add a couple of comments on top of the structs in
smmu.c to explain the meaning of the fields, like:
/* iommu_domain, not to be confused with a Xen domain */
I
On Tue, 2015-03-31 at 17:48 +0100, Stefano Stabellini wrote:
If it helps we could add a couple of comments on top of the structs in
smmu.c to explain the meaning of the fields, like:
/* iommu_domain, not to be confused with a Xen domain */
I was going to suggest something similar but more
On Fri, 27 Mar 2015, Jaggi, Manish wrote:
From: Julien Grall julien.gr...@linaro.org
Sent: Friday, March 27, 2015 6:34 PM
To: Jaggi, Manish; Xen Devel; prasun.kap...@cavium.com; Kumar, Vijaya; Ian
Campbell; Stefano Stabellini
Subject: Re: [PATCH v1 3/3] xen/arm: smmu: Renaming struct
Hi manish,
On 27/03/15 07:24, Manish Jaggi wrote:
It is good for code readability as there are many structures ending with
the name domain.
Also a code like this one is now easy to understand with the rename
old: dev_iommu_domain(dev) = domain;
new: dev_iommu_domain(dev) = iommu_domain;
Regards,
Manish Jaggi
From: Julien Grall julien.gr...@linaro.org
Sent: Friday, March 27, 2015 6:34 PM
To: Jaggi, Manish; Xen Devel; prasun.kap...@cavium.com; Kumar, Vijaya; Ian
Campbell; Stefano Stabellini
Subject: Re: [PATCH v1 3/3] xen/arm: smmu:
On 27/03/15 13:26, Jaggi, Manish wrote:
On 27/03/15 07:24, Manish Jaggi wrote:
It is good for code readability as there are many structures ending with
the name domain.
Also a code like this one is now easy to understand with the rename
old: dev_iommu_domain(dev) = domain;
new:
On 27/03/2015 18:05, Jaggi, Manish wrote:
From: Julien Grall julien.gr...@linaro.org
Sent: Friday, March 27, 2015 7:11 PM
To: Jaggi, Manish; Xen Devel; prasun.kap...@cavium.com; Kumar, Vijaya; Ian
Campbell; Stefano Stabellini
Subject: Re: [PATCH v1 3/3] xen/arm: smmu: Renaming struct
From: Julien Grall julien.gr...@linaro.org
Sent: Friday, March 27, 2015 7:11 PM
To: Jaggi, Manish; Xen Devel; prasun.kap...@cavium.com; Kumar, Vijaya; Ian
Campbell; Stefano Stabellini
Subject: Re: [PATCH v1 3/3] xen/arm: smmu: Renaming struct iommu_domain *domain
to, struct iommu_domain
12 matches
Mail list logo
