Hi Stefano,
> On 26 Apr 2024, at 23:36, Stefano Stabellini wrote:
>
> Signed-off-by: Stefano Stabellini
You might want to answer to Andrew on the footnote and agree or not on his way
to fix.
Appart from that:
Acked-by: Bertrand Marquis
Cheers
Bertrand
> ---
>
> Chan
Hi Julien,
> On 26 Apr 2024, at 21:07, Julien Grall wrote:
>
> Hi Jens,
>
> On 26/04/2024 09:47, Jens Wiklander wrote:
>> diff --git a/xen/arch/arm/irq.c b/xen/arch/arm/irq.c
>> index d7306aa64d50..5224898265a5 100644
>> --- a/xen/arch/arm/irq.c
>> +++ b/xen/arch/arm/irq.c
>> @@ -155,7 +155,7
Hi Jens,
> On 26 Apr 2024, at 15:02, Jens Wiklander wrote:
>
> On Fri, Apr 26, 2024 at 2:41 PM Bertrand Marquis
> wrote:
>>
>> Hi Jens,
>>
>>> On 26 Apr 2024, at 14:32, Jens Wiklander wrote:
>>>
>>> Hi Bertrand,
>>>
Hi Jens,
> On 26 Apr 2024, at 14:32, Jens Wiklander wrote:
>
> Hi Bertrand,
>
> On Fri, Apr 26, 2024 at 2:19 PM Bertrand Marquis
> wrote:
>>
>> Hi Jens,
>>
>>> On 26 Apr 2024, at 14:11, Jens Wiklander wrote:
>>>
>>> Hi Bertr
Hi Jens,
> On 26 Apr 2024, at 14:11, Jens Wiklander wrote:
>
> Hi Bertrand,
>
> On Fri, Apr 26, 2024 at 11:20 AM Bertrand Marquis
> wrote:
>>
>> Hi Jens,
>>
>>> On 26 Apr 2024, at 10:47, Jens Wiklander wrote:
>>>
>>> Add sup
Hi Jens
> On 26 Apr 2024, at 10:47, Jens Wiklander wrote:
>
> Hi,
>
> This patch set adds support for FF-A notifications. We only support
> global notifications, per vCPU notifications remain unsupported.
>
> The first three patches are further cleanup and can be merged before the
> rest if
Hi Jens,
> On 26 Apr 2024, at 10:47, Jens Wiklander wrote:
>
> Add support for FF-A notifications, currently limited to an SP (Secure
> Partition) sending an asynchronous notification to a guest.
>
> Guests and Xen itself are made aware of pending notifications with an
> interrupt. The
Hi Jens,
> On 23 Apr 2024, at 17:26, Jens Wiklander wrote:
>
> Hi Julien,
>
> On Mon, Apr 22, 2024 at 1:40 PM Julien Grall wrote:
>>
>> Hi Jens,
>>
>> This is not a full review of the code. I will let Bertrand doing it.
>>
>> On 22/04/2024 08:37, Jens Wiklander wrote:
>>> +void
Hi Julien,
> On 23 Apr 2024, at 17:16, Julien Grall wrote:
>
> Hi Bertrand,
>
> On 23/04/2024 16:12, Bertrand Marquis wrote:
>> Hi Julien,
>>> On 22 Apr 2024, at 13:40, Julien Grall wrote:
>>>
>>> Hi Jens,
>>>
>>>
Hi Julien,
> On 22 Apr 2024, at 13:40, Julien Grall wrote:
>
> Hi Jens,
>
> This is not a full review of the code. I will let Bertrand doing it.
>
> On 22/04/2024 08:37, Jens Wiklander wrote:
>> +void ffa_notif_init(void)
>> +{
>> +const struct arm_smccc_1_2_regs arg = {
>> +.a0 =
Hi Julien,
> On 23 Apr 2024, at 14:37, Bertrand Marquis wrote:
>
> Hi Julien,
>
>> On 23 Apr 2024, at 13:05, Julien Grall wrote:
>>
>>
>>
>> On 23/04/2024 10:35, Jens Wiklander wrote:
>>> Hi Julien,
>>
>> Hi Jens,
>>
&g
Hi Julien,
> On 23 Apr 2024, at 13:05, Julien Grall wrote:
>
>
>
> On 23/04/2024 10:35, Jens Wiklander wrote:
>> Hi Julien,
>
> Hi Jens,
>
>> On Mon, Apr 22, 2024 at 12:57 PM Julien Grall wrote:
>>>
>>> Hi Jens,
>>>
>>> On 22/04/2024 08:37, Jens Wiklander wrote:
Updates so
Hi Stefano,
> On 14 Mar 2024, at 22:50, Stefano Stabellini wrote:
>
>
> Signed-off-by: Stefano Stabellini
Acked-by: Bertrand Marquis
Cheers
Bertrand
> ---
> Changes in v2:
> - mention -Werror
> - change the position of the in-code comment in the example
&
Hi Stefano,
> On 15 Mar 2024, at 01:35, Stefano Stabellini wrote:
>
> Signed-off-by: Stefano Stabellini
With the semicolon comment from Jan addressed:
Acked-by: Bertrand Marquis
Cheers
Bertrand
Hi Julien,
> On 15 Apr 2024, at 12:08, Julien Grall wrote:
>
> Hi Bertrand,
>
> On 15/04/2024 08:48, Bertrand Marquis wrote:
>> Hi Julien,
>>> On 12 Apr 2024, at 19:01, Julien Grall wrote:
>>>
>>>
>>>
>>> On Fri,
Hi Julien,
> On 12 Apr 2024, at 19:01, Julien Grall wrote:
>
>
>
> On Fri, 12 Apr 2024 at 11:30, Bertrand Marquis
> wrote:
> Hi Julien,
>
> > On 12 Apr 2024, at 15:53, Julien Grall wrote:
> >
> >
> >
> > On Thu, 11 Apr 2024 at 18:
Hi Julien,
> On 12 Apr 2024, at 15:53, Julien Grall wrote:
>
>
>
> On Thu, 11 Apr 2024 at 18:08, Stefano Stabellini
> wrote:
> On Wed, 10 Apr 2024, Julien Grall wrote:
> > On Wed, 10 Apr 2024 at 19:47, Stefano Stabellini
> > wrote:
> > xen_ulong_t is widely used in public headers.
>
Hi Jens,
> On 10 Apr 2024, at 17:45, Jens Wiklander wrote:
>
> On Tue, Apr 9, 2024 at 5:36 PM Jens Wiklander
> wrote:
>>
>> Add support for FF-A notifications, currently limited to an SP (Secure
>> Partition) sending an asynchronous notification to a guest.
>>
>> Guests and Xen itself are
Hi Jens,
> On 10 Apr 2024, at 16:27, Jens Wiklander wrote:
>
> On Wed, Apr 10, 2024 at 9:49 AM Bertrand Marquis
> wrote:
>>
>> Hi Jens,
>>
>>> On 9 Apr 2024, at 17:36, Jens Wiklander wrote:
>>>
>>> Add support for FF-A notifi
Hi Jens,
> On 10 Apr 2024, at 16:27, Jens Wiklander wrote:
>
> On Wed, Apr 10, 2024 at 9:49 AM Bertrand Marquis
> wrote:
>>
>> Hi Jens,
>>
>>> On 9 Apr 2024, at 17:36, Jens Wiklander wrote:
>>>
>>> Add support for FF-A notifi
Hi Jens,
> On 9 Apr 2024, at 17:36, Jens Wiklander wrote:
>
> Add support for FF-A notifications, currently limited to an SP (Secure
> Partition) sending an asynchronous notification to a guest.
>
> Guests and Xen itself are made aware of pending notifications with an
> interrupt. The
; Signed-off-by: Jens Wiklander
Reviewed-by: Bertrand Marquis
Cheers
Bertrand
> ---
> xen/arch/arm/tee/ffa_shm.c | 18 ++
> 1 file changed, 6 insertions(+), 12 deletions(-)
>
> diff --git a/xen/arch/arm/tee/ffa_shm.c b/xen/arch/arm/tee/ffa_shm.c
> index 75a5b66aeb4
ff-by: Jens Wiklander
Reviewed-by: Bertrand Marquis
Cheers
Bertrand
> ---
> xen/arch/arm/tee/ffa_shm.c | 15 ---
> 1 file changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/xen/arch/arm/tee/ffa_shm.c b/xen/arch/arm/tee/ffa_shm.c
> index eed9ad2d2986..75a5b
Hi Jens,
> On 9 Apr 2024, at 17:36, Jens Wiklander wrote:
>
> Refactors the large switch block in ffa_handle_call() to use common code
> for the simple case where it's either an error code or success with no
> further parameters.
>
> Signed-off-by: Jens Wiklander
han having nothing documented
so:
Acked-by: Bertrand Marquis
Cheers
Bertrand
> ---
> Changes in v4:
> - list the architectures explicitly
> - add ARMv7-A
> ---
> docs/misra/C-language-toolchain.rst | 73 +
> 1 file changed, 73 insertions(+)
Hi Stefano,
> On 5 Apr 2024, at 01:57, Stefano Stabellini wrote:
>
> On Thu, 4 Apr 2024, Bertrand Marquis wrote:
>> Hi Stefano,
>>
>>> On 4 Apr 2024, at 03:12, Stefano Stabellini wrote:
>>>
>>> Xen makes assumptions about the size of integer
Hi Stefano,
> On 4 Apr 2024, at 03:12, Stefano Stabellini wrote:
>
> Xen makes assumptions about the size of integer types on the various
> architectures. Document these assumptions.
>
> Signed-off-by: Stefano Stabellini
> ---
> Changes in v3:
> - add links to System V, AAPCS32 and AAPCS64
>
Hi Julien,
> On 28 Mar 2024, at 18:58, Julien Grall wrote:
>
> Hi Bertrand,
>
> On 27/03/2024 13:40, Bertrand Marquis wrote:
>> Hi Jens,
>>> On 25 Mar 2024, at 10:39, Jens Wiklander wrote:
>>>
>>> Move memory sharing routines into a separate f
upport FFA_FEATURES" patch.
I reviewed the serie and there is only one tiny fix of copyright date that
can be done on commit.
Appart from that, I tested FF-A with the whole serie applied and I can
confirm it works on my side so for the whole serie:
Tested-by: Bertrand Marquis
Cheer
Hi Jens,
> On 25 Mar 2024, at 10:39, Jens Wiklander wrote:
>
> Add support for the mandatory FF-A ABI function FFA_FEATURES.
>
> Signed-off-by: Jens Wiklander
Reviewed-by: Bertrand Marquis
Cheers
Bertrand
> ---
> xen/arch/arm/tee/ffa.c | 57 +
ngs on initialization and teardown.
>
> Signed-off-by: Jens Wiklander
Reviewed-by: Bertrand Marquis
Cheers
Bertrand
> ---
> xen/arch/arm/tee/Makefile | 1 +
> xen/arch/arm/tee/ffa.c | 174 +-
> xen/arch/arm/tee/ffa_private.h | 7 ++
ffa_partinfo internal things
> on initialization and teardown.
>
> Signed-off-by: Jens Wiklander
Reviewed-by: Bertrand Marquis
Cheers
Bertrand
> ---
> xen/arch/arm/tee/Makefile | 1 +
> xen/arch/arm/tee/ffa.c | 359 +-
gned-off-by: Jens Wiklander
With the copyright date mentioned after fixed (which can be done on commit):
Reviewed-by: Bertrand Marquis ---
> xen/arch/arm/tee/Makefile | 1 +
> xen/arch/arm/tee/ffa.c | 708 +
> xen/arch/arm/tee/ffa_private.h
Hi Jens,
> On 25 Mar 2024, at 10:39, Jens Wiklander wrote:
>
> Prepare to separate ffa.c into modules by moving common things into the
> new internal header file ffa_private.h.
>
> Signed-off-by: Jens Wiklander
Reviewed-by: Bertrand Marquis
Cheers
Bertrand
> ---
>
Hi Jens,
> On 25 Mar 2024, at 10:38, Jens Wiklander wrote:
>
> Prepare to separate into modules by renaming functions that will need
> new names when becoming non-static in the following commit.
>
> Signed-off-by: Jens Wiklander
Reviewed-by: Bertrand Marquis
Cheers
Ber
Hi John,
> On 25 Mar 2024, at 13:18, John Ernberg wrote:
>
> Hi Bertrand,
>
> On 3/21/24 17:15, Bertrand Marquis wrote:
>> Hi John,
>>
>>> On 21 Mar 2024, at 17:05, John Ernberg wrote:
>>>
>>> Hi Bertrand,
>>>
>>>
Hi John,
> On 21 Mar 2024, at 17:05, John Ernberg wrote:
>
> Hi Bertrand,
>
> On 3/21/24 08:41, Bertrand Marquis wrote:
>> Hi,
>>
>>> On 20 Mar 2024, at 18:40, Julien Grall wrote:
>>>
>>> Hi John,
>>>
>>> On 20/03
Hi,
> On 20 Mar 2024, at 18:40, Julien Grall wrote:
>
> Hi John,
>
> On 20/03/2024 16:24, John Ernberg wrote:
>> Hi Bertrand,
>> On 3/13/24 11:07, Bertrand Marquis wrote:
>>> Hi,
>>>
>>>> On 8 Mar 2024, at 15:04, Julien Grall wrot
Hi Stefano,
> On 14 Mar 2024, at 00:04, Stefano Stabellini wrote:
>
> On Wed, 13 Mar 2024, Jan Beulich wrote:
>> On 13.03.2024 01:28, Stefano Stabellini wrote:
>>> --- a/docs/misra/rules.rst
>>> +++ b/docs/misra/rules.rst
>>> @@ -478,6 +478,30 @@ maintainers if you want to suggest a change.
>>>
Hi,
> On 8 Mar 2024, at 15:04, Julien Grall wrote:
>
> Hi John,
>
> Thank you for the reply.
>
> On 08/03/2024 13:40, John Ernberg wrote:
>> On 3/7/24 00:07, Julien Grall wrote:
>>> > Ping on the watchdog discussion bits.
>>>
>>> Sorry for the late reply.
>>>
>>> On 06/03/2024 13:13, John
Hi Stefano,
> On 13 Feb 2024, at 23:33, Stefano Stabellini
> wrote:
>
> Signed-off-by: Stefano Stabellini
Coherent with what was discussed during the Misra meeting so:
Acked-by: Bertrand Marquis
Cheers
Bertrand
> ---
> docs/misra/rules.rst | 9 +
> 1 file
off-by: Jens Wiklander
>From my point of view all looks good now so with the changes requested
by Andrew handled, feel free to add my R-b in the v5:
Reviewed-by: Bertrand Marquis
Cheers
Bertrand
> ---
>
> v4:
> - Retry FFA_MSG_SEND_VM_DESTROYED on the returned errors
> FFA_RET_I
Hi Andrew,
> On 2 Feb 2024, at 00:39, Andrew Cooper wrote:
>
> Wherever possible, it is a good idea to NULL out the visible reference to an
> object prior to freeing it. The FREE*() macros already collect together both
> parts, making it easy to adjust.
>
> This has a marginal code
Hi Jens,
> On 5 Feb 2024, at 14:39, Jens Wiklander wrote:
>
> Hi Bertrand,
>
> On Thu, Feb 1, 2024 at 2:57 PM Bertrand Marquis
> wrote:
>>
>> Hi Jens,
>>
>>> On 17 Jan 2024, at 12:06, Jens Wiklander wrote:
>>>
>>> Whe
Hi Jens,
> On 17 Jan 2024, at 12:06, Jens Wiklander wrote:
>
> When an FF-A enabled guest is destroyed it may leave behind memory
> shared with SPs. This memory must be reclaimed before it's reused or an
> SP may make changes to memory used by a new unrelated guest. So when the
> domain is
g the pointer.
>
> Fixes: a5ed59e62c6f ("arm/mmu: Move init_ttbr to a new section .data.idmap")
> Fixes: 9a5114074b04 ("arm/smpboot: Move smp_up_cpu to a new section
> .data.idmap)
>
> Reported-by: Oleksandr Tyshchenko
> Signed-off-by: Julien Grall
Reviewed
Hi Andrew,
> On 25 Jan 2024, at 00:27, Andrew Cooper wrote:
>
> On 23/01/2024 8:29 am, Bertrand Marquis wrote:
>>> Thanks for raising the visibility of this. I'm not familiar with ARM,
>>> but if I were investigating this I'd try to figure out what the
>
Hi Paul,
Please keep me in CC so that i can more easily find out that you answered me :-)
> On 25 Jan 2024, at 00:05, Paul Leiber wrote:
>
> Elliot, Bertrand, George: Thanks for your replies.
>
> Am 23.01.2024 um 09:29 schrieb Bertrand Marquis:
>> Hi,
>>
Hi,
will try to explain some of the messages here after but I am not sure of the
reason
of the crash so I will just set some pointers...
> On 22 Jan 2024, at 11:46, George Dunlap wrote:
>
> On Fri, Jan 19, 2024 at 8:32 PM Elliott Mitchell wrote:
>>
>> On Sun, Jan 14, 2024 at 10:54:24PM
Hi Jens,
Very sorry for the long delay.
> On 13 Dec 2023, at 12:25, Jens Wiklander wrote:
>
> When an FF-A enabled guest is destroyed it may leave behind memory
> shared with SPs. This memory must be reclaimed before it's reused or an
> SP may make changes to memory used by a new unrelated
ate every switch-clause").
> No funtional change.
>
> Signed-off-by: Federico Serafini
Reviewed-by: Bertrand Marquis ---
> xen/drivers/passthrough/arm/smmu-v3.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/xen/drivers/passthrough/arm/smmu-v3.c
> b/xen/
NFO_GET")
> Signed-off-by: Jens Wiklander
Reviewed-by: Bertrand Marquis
Cheers
Bertrand
> ---
> xen/arch/arm/tee/ffa.c | 21 +
> 1 file changed, 13 insertions(+), 8 deletions(-)
>
> diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c
> ind
t; ffa_handle_call() to return true and with the cpu_user_regs updated.
>
> Fixes: 38846de2176b ("xen/arm: tee: add a primitive FF-A mediator")
> Signed-off-by: Jens Wiklander
With the Nit from Michal fixed in the commit message (could be done on commit):
Reviewed-by: Bertrand M
> On 8 Dec 2023, at 12:04, Wei Chen wrote:
>
> Hi Henry,
>
> On 2023/12/8 00:20, Henry Wang wrote:
>> I've finished the opportunity to do two releases (4.17 and 4.18)
>> and Oleksii Kurochko has volunteered to be the next release manager.
>> Hand over the role to him by changing the
Hi All,
Sorry for coming back late on this thread.
> On 7 Dec 2023, at 22:41, Stefano Stabellini wrote:
>
> On Thu, 7 Dec 2023, Julien Grall wrote:
>> Hi Stefano,
>>
>> On 05/12/2023 23:21, Stefano Stabellini wrote:
>>> On Tue, 5 Dec 2023, Julien Grall wrote:
I agree that crashing a
Hi Julien,
Thanks a lot for your review and comment, this is very helpful.
> On 4 Dec 2023, at 20:24, Julien Grall wrote:
>
> Hi Jens,
>
> On 04/12/2023 07:55, Jens Wiklander wrote:
>> When an FF-A enabled guest is destroyed it may leave behind memory
>> shared with SPs. This memory must be
Hi Luca,
> On 13 Nov 2023, at 10:58, Luca Fancellu wrote:
>
>>
>>>
>>> The functions allocate_static_memory and assign_static_memory_11
>>> are now externally visible, so put their declarations into
>>> domain_build.h and move the #else and stub definition in the header
>>> as well.
>>>
>>>
seless empty file :-)
For the arm part:
Reviewed-by: Bertrand Marquis
Cheers
Bertrand
>
> --- a/xen/arch/arm/include/asm/xenoprof.h
> +++ /dev/null
> @@ -1,12 +0,0 @@
> -#ifndef __ASM_XENOPROF_H__
> -#define __ASM_XENOPROF_H__
> -
> -#endif /* __ASM_XENOPROF_H__ */
>
Hi Jan,
> On 30 Oct 2023, at 14:29, Jan Beulich wrote:
>
> smp_processor_id() is what we commonly use; there's no need for it to
> have an alias.
>
> Signed-off-by: Jan Beulich
For the arm part:
Reviewed-by: Bertrand Marquis
Cheers
Bertrand
>
> --- a/xen/arch/a
y to read. So move
> out the nested switch in a separate function to improve the
> readability and hopefully address the MISRA violation.
>
> Reported-by: Nicola Vetrini
> Signed-off-by: Julien Grall
Reviewed-by: Bertrand Marquis
Cheers
Bertrand
>
> ---
>
>
arm/booting.txt.
>
> [1] https://lore.kernel.org/20231013122658.1270506-3-leo@linaro.org
>
> Signed-off-by: Julien Grall
> Reviewed-by: Michal Orzel
Reviewed-by: Bertrand Marquis
Cheers
Bertrand
>
> ---
>
>Changes in v2:
>- The limit is 2 TiB no 5
>-
Hi Stefano,
> On 23 Oct 2023, at 22:56, Stefano Stabellini wrote:
>
> Signed-off-by: Stefano Stabellini
Acked-by: Bertrand Marquis
Cheers
Bertrand
> ---
> MAINTAINERS | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f6
Hi Frederico,
> On 18 Oct 2023, at 14:50, Federico Serafini
> wrote:
>
> Add missing parameter names. No functional change.
>
> Signed-off-by: Federico Serafini
Reviewed-by: Bertrand Marquis
Cheers
Bertrand
> ---
> Changes in v2:
> - fixed names.
>
> On 16 Oct 2023, at 17:31, Julien Grall wrote:
>
>
>
> On 16/10/2023 16:07, Bertrand Marquis wrote:
>> Hi,
>>> On 16 Oct 2023, at 16:46, Julien Grall wrote:
>>>
>>> CC Henry
>>>
>>> Hi Alexey,
>>>
>>&g
Hi,
> On 16 Oct 2023, at 16:46, Julien Grall wrote:
>
> CC Henry
>
> Hi Alexey,
>
> On 16/10/2023 15:24, Alexey Klimov wrote:
>> On Mon, 16 Oct 2023 at 15:13, Luca Fancellu wrote:
>>>
>>>
>>>
>>>> On 16 Oct 2023, at 15
Hi
+Luca and Rahul
> On 16 Oct 2023, at 15:54, Julien Grall wrote:
>
>
>
> On 16/10/2023 09:44, Michal Orzel wrote:
>> Hi,
>
> Hi,
>
>> On 13/10/2023 14:26, Leo Yan wrote:
>>>
>>>
>>> On ADLink AVA platform (Ampere Altra SoC with 32 Arm Neoverse N1 cores),
>>> the physical memory
Hi Julien,
> On 16 Oct 2023, at 15:38, Julien Grall wrote:
>
>
>
> On 16/10/2023 14:31, Bertrand Marquis wrote:
>> Hi Julien,
>
> Hi Bertrand,
>
>>> On 16 Oct 2023, at 11:07, Julien Grall wrote:
>>>
>>> Hi,
>>>
>>&g
; prepare/enable/disable")
I agree with Michal here, this is not a fix so this should be removed (can be
done
on commit).
> Reported-by: Alexey Klimov
> Signed-off-by: Leo Yan
Reviewed-by: Bertrand Marquis
Cheers
Bertrand
> ---
> xen/arch/arm/arm64/mm.c
Hi Julien,
> On 16 Oct 2023, at 11:07, Julien Grall wrote:
>
> Hi,
>
> On 13/10/2023 16:24, Federico Serafini wrote:
>> Add missing parameter names, no functional change.
>> Signed-off-by: Federico Serafini
>> ---
>> xen/drivers/passthrough/arm/smmu.c | 6 +++---
>
> This file is using the
; to boot a domain despite errors. This may lead to incorrect device tree
> generation and various guest issues (e.g. trap on attempt to access MMIO
> not mapped in P2M). Fix it.
>
> Fixes: 669ecdf8d6cd ("xen/arm: copy dtb fragment to guest dtb")
> Signed-off-by: Michal Orze
Hi,
> On 2 Oct 2023, at 10:26, Julien Grall wrote:
>
> Hi Stefano,
>
> On 29/09/2023 20:48, Stefano Stabellini wrote:
>> On Fri, 29 Sep 2023, Luca Fancellu wrote:
On 29 Sep 2023, at 01:33, Stefano Stabellini
wrote:
On Wed, 27 Sep 2023, Luca Fancellu wrote:
>
> On 28 Sep 2023, at 02:40, Stefano Stabellini wrote:
>
> On Wed, 27 Sep 2023, Bertrand Marquis wrote:
>>> On 27 Sep 2023, at 09:53, Nicola Vetrini wrote:
>>>
>>>>>> diff --git a/xen/arch/arm/psci.c b/xen/arch/arm/psci.c
>>>>>>
trolling value statically determined not to
> + match one or more case statements
> + - Functions that are intended to be referenced only from
> + assembly code (e.g. 'do_trap_fiq')
> + - Deliberate unreachability caused by certain macros/functions,
>
Hi Jan,
> On 27 Sep 2023, at 10:23, Jan Beulich wrote:
>
> On 27.09.2023 10:14, Bertrand Marquis wrote:
>>> On 27 Sep 2023, at 09:53, Nicola Vetrini wrote:
>>> My opinion is that it's far easier for this to be an eclair configuration
>>> (which has the
>
the "integer" word here.
With that done:
Acked-by: Bertrand Marquis
Cheers
Bertrand
> ---
> Rule 13.1 also discussed but it is already in docs/misra/rules.rst
> ---
> docs/misra/rules.rst | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/docs/misra/rules.rst b/doc
Hi,
> On 27 Sep 2023, at 09:53, Nicola Vetrini wrote:
>
>>> > diff --git a/xen/arch/arm/psci.c b/xen/arch/arm/psci.c
>>> > index 695d2fa1f1..2a8527cacc 100644
>>> > --- a/xen/arch/arm/psci.c
>>> > +++ b/xen/arch/arm/psci.c
>>> > @@ -59,6 +59,7 @@ void call_psci_cpu_off(void)
>>> > }
>>> >
;
> Signed-off-by: Stefano Stabellini
I am still not quite sure if we should accept a rule if we are deviating
on so much cases but as we can revisit anyway:
Acked-by: Bertrand Marquis
Cheers
Bertrand
> ---
> Changes in v3:
> - add ,
> - add switch(sizeof(...)) and switch(offset
Hi Oleksii,
> On 6 Sep 2023, at 13:37, Oleksii wrote:
>
> Hello Bertrand
>
> On Mon, 2023-09-04 at 13:39 +, Bertrand Marquis wrote:
>>> diff --git a/xen/scripts/Makefile.asm-generic
>>> b/xen/scripts/Makefile.asm-generic
>>> new file mo
Hi Oleksii,
> On 5 Sep 2023, at 15:37, Oleksii wrote:
>
> Hi Bertrand,
>
> On Mon, 2023-09-04 at 13:39 +, Bertrand Marquis wrote:
>> Hi Oleksii,
>>
>>> On 1 Sep 2023, at 18:02, Oleksii Kurochko
>>> wrote:
>>>
>>> Some heade
Hi Jan,
> On 5 Sep 2023, at 10:36, Jan Beulich wrote:
>
> On 05.09.2023 10:23, GitLab wrote:
>>
>>
>> Pipeline #992747061 has failed!
>>
>> Project: xen ( https://gitlab.com/xen-project/xen )
>> Branch: staging-4.17 (
>> https://gitlab.com/xen-project/xen/-/commits/staging-4.17 )
>>
>>
Hi Jan,
> On 4 Sep 2023, at 17:20, Jan Beulich wrote:
>
> On 04.09.2023 16:05, Bertrand Marquis wrote:
>>> On 4 Sep 2023, at 16:01, Jan Beulich wrote:
>>>
>>> On 04.09.2023 15:42, Bertrand Marquis wrote:
>>>>> On 1 Sep 2023, at 09:26
"xen/arm: ffa: support mapping guest RX/TX buffers")
> Signed-off-by: Jens Wiklander
Reviewed-by: Bertrand Marquis
Cheers
Bertrand
> ---
> xen/arch/arm/tee/ffa.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/tee/ffa.c b/xen/ar
Hi Jan,
> On 4 Sep 2023, at 16:01, Jan Beulich wrote:
>
> On 04.09.2023 15:42, Bertrand Marquis wrote:
>>> On 1 Sep 2023, at 09:26, Jan Beulich wrote:
>>>
>>> This using a GNU extension, it may not be exposed in general, just like
>>
>> Nit
Hi Leo,
> On 31 Aug 2023, at 13:01, Leo Yan wrote:
>
> Xen maps the virtual memory space starting from L0 slot 4, so it's open
> coded for macros with the offset '4'.
>
> For more readable, add a new macro XEN_VM_MAPPING which defines the
> start slot for Xen virtual memory mapping, and all
Hi Leo,
> On 31 Aug 2023, at 13:01, Leo Yan wrote:
>
> On some platforms, the memory regions could be:
>
> (XEN) MODULE[0]: 0807f6df - 0807f6f3e000 Xen
> (XEN) MODULE[1]: 0807f8054000 - 0807f8056000 Device Tree
> (XEN) MODULE[2]: fa834000 - fc5de1d5
supplied) - unlike on x86
> the type is actually needed outside of tools-only interfaces, because
> guest handle definitions use it.
>
> While there also add underscores around "aligned".
>
> Signed-off-by: Jan Beulich
With the Nit fixed (can be done on comm
Hi Oleksii,
> On 1 Sep 2023, at 18:02, Oleksii Kurochko wrote:
>
> Some headers are shared between individual architectures or are empty.
> To avoid duplication of these headers, asm-generic is introduced.
>
> With the following patch, an architecture uses generic headers
> mentioned in the
sented in an unsigned type
>
> Signed-off-by: Michal Orzel
Reviewed-by: Bertrand Marquis
Cheers
Bertrand
> ---
> xen/drivers/passthrough/arm/smmu-v3.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/xen/drivers/passthrough/arm/smmu-v3.h
>
Hi,
> On 30 Aug 2023, at 09:58, Jan Beulich wrote:
>
> On 30.08.2023 09:54, Bertrand Marquis wrote:
>>> On 30 Aug 2023, at 02:59, Stefano Stabellini wrote:
>>> + * - `Rule 14.4
>>> <https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/m
Hi Jan,
> On 30 Aug 2023, at 09:30, Jan Beulich wrote:
>
> On 29.08.2023 16:34, Oleksii Kurochko wrote:
>> --- a/xen/Makefile
>> +++ b/xen/Makefile
>> @@ -438,6 +438,7 @@ ifdef building_out_of_srctree
>> endif
>> CFLAGS += -I$(srctree)/include
>> CFLAGS += -I$(srctree)/arch/$(SRCARCH)/include
Hi Stefano,
> On 30 Aug 2023, at 02:59, Stefano Stabellini wrote:
>
> From: Stefano Stabellini
>
> Add 14.3, with a project-wide deviations on if statements.
> Add 14.4, clarifying that implicit conversions of integers, chars and
> pointers to bool are allowed.
>
> Also take the opportunity
Hi Stefano,
> On 25 Aug 2023, at 23:48, Stefano Stabellini wrote:
>
> From: Stefano Stabellini
>
> 10.1 with several caveats, described in the notes.
> 10.3 and 10.4 as "aspirational" guidelines, as clarified in the notes.
>
> Signed-off-by: Stefano Stabelli
Hi Kelly,
> On 18 Aug 2023, at 12:55, Kelly Choi wrote:
>
> Hi everyone! :)
>
> I hope you're all well.
>
> If we haven't met before, I'd like to introduce myself. I'm Kelly, the
> Community Manager for The Xen Project. My role is to support everyone and
> make sure the project is healthy and
Reviewed-by: Henry Wang
Reviewed-by: Bertrand Marquis
Cheers
Bertrand
> ---
> v10->v11
> - Add a CHANGELOG.md entry as requested
> ---
> CHANGELOG.md | 3 ++-
> SUPPORT.md | 9 +
> docs/man/xl.cfg.5.pod.in | 15 +++
> 3 files chang
Hi Jens,
> On 31 Jul 2023, at 14:15, Jens Wiklander wrote:
>
> Adds comments with a list of unsupported FF-A interfaces and limitations
> in the implemented FF-A interfaces.
>
> Signed-off-by: Jens Wiklander
> Reviewed-by: Henry Wang
Reviewed-by: Bertrand Marq
ock and tx_lock are only acquired using spin_trylock() which for
> well-behaving guests should always succeed. Guests using the RX and TX
> buffers are expected to serialize accesses before doing the FF-A
> request.
>
> Signed-off-by: Jens Wiklander
Reviewed-by: Bertrand Marq
est.
>
> Using FFA_PARTITION_INFO_GET changes the owner of the RX buffer to the
> caller (the guest in this case), so once it is done with the buffer it
> must be released using FFA_RX_RELEASE before another call can be made.
>
> Signed-off-by: Jens Wiklander
Reviewed-by: Bertrand Marqu
that cannot be passed in
> registers only.
>
> Signed-off-by: Jens Wiklander
Reviewed-by: Bertrand Marquis
Cheers
Bertrand
> ---
> v10->v11
> - Fixing a typo in a comment and adding a couple of newlines as requested
> ---
> xen/arch/arm/tee/ffa.c | 140 +++
klander
One NIT after which might be fixed on commit.
With that fixed:
Reviewed-by: Bertrand Marquis
> ---
> v10->v11:
> - Addressing comments and fixing a few style issues
> - Fixing how is_in_subscr_list() is used, it's supposed to take an
> sp_id, not a vm_id.
> ---
> xen/arch/
at.
>
> Signed-off-by: Jens Wiklander
> Reviewed-by: Henry Wang
Reviewed-by: Bertrand Marquis
Cheers
Bertrand
> ---
> v10->v11
> - In handle_msg_send_direct_req(), replaced the "arg" with "resp" at the
> default: label in
1 - 100 of 1345 matches
Mail list logo
