Re: [PATCH for-4.19] ppc/riscv: fix arch_acquire_resource_check()

2024-05-05 Thread Shawn Anastasio
ine minimal stub headers required for full > build') > Signed-off-by: Roger Pau Monné > --- This makes sense to me. This stub implementation was definitely an oversight on my part. Acked-by: Shawn Anastasio Thanks, Shawn

Re: [PATCH v7 06/19] xen/bitops: put __ffs() into linux compatible header

2024-04-12 Thread Shawn Anastasio
ext-bit.c only one usage of __ffs() leave > in smmu-v3.c. It seems that it __ffs can be changed to ffsl(x)-1 in > this file, but to keep smmu-v3.c looks close to linux it was deciced just > to define __ffs() in xen/linux-compat.h and include it in smmu-v3.c > > Signed-off-by: Oleksii Kuroch

Re: [PATCH v2 1/4] xen/link: Introduce a common BUGFRAMES definition

2024-04-12 Thread Shawn Anastasio
> structure. > > No functional change. > > Signed-off-by: Andrew Cooper > Reviewed-by: Jan Beulich Acked-by: Shawn Anastasio Thanks, Shawn

[PATCH v4 1/6] xen/ppc: Introduce stub asm/static-shmem.h

2024-04-11 Thread Shawn Anastasio
Required for bootfdt.c to build. Signed-off-by: Shawn Anastasio --- Changes in v4: none xen/arch/ppc/include/asm/static-shmem.h | 12 1 file changed, 12 insertions(+) create mode 100644 xen/arch/ppc/include/asm/static-shmem.h diff --git a/xen/arch/ppc/include/asm/static-shmem.h

[PATCH v4 6/6] xen/ppc: mm-radix: Allocate all paging structures at runtime

2024-04-11 Thread Shawn Anastasio
the size of the Process Table to its maximum supported value (on POWER9). Signed-off-by: Shawn Anastasio --- Changes in v4: - use mfn_add in initial_page_alloc() - zero pages returned by initial_page_alloc() xen/arch/ppc/mm-radix.c | 231 +--- 1 file changed

[PATCH v4 4/6] xen/ppc: Enable bootfdt and boot allocator

2024-04-11 Thread Shawn Anastasio
booted directly from skiboot. Since this means that Xen can now boot without a BOOTMOD_FDT present in bootinfo, clarify this fact in a comment above BOOTMOD_FDT's definition. Signed-off-by: Shawn Anastasio --- Changes in v4: - drop unnecessary libfdt.h include in setup.c - make boot_fdt

[PATCH v4 2/6] xen/device-tree: Move Arm's setup.c bootinfo functions to common

2024-04-11 Thread Shawn Anastasio
-by: Shawn Anastasio --- Changes in v4: - create new xen/include/bootinfo.h rather than relying on arch's asm/setup.h to provide required definitions for bootinfo.c - build bootinfo.c as .init.o - clean up and sort bootinfo.c's #includes - use CONFIG_SEPARATE_XENHEAP rather than

[PATCH v4 0/6] Early Boot Allocation on Power

2024-04-11 Thread Shawn Anastasio
Hello all, This series enables the Xen boot time allocator on Power by parsing the available memory regions from the firmware-provided device tree. Thanks, Shawn Shawn Anastasio (6): xen/ppc: Introduce stub asm/static-shmem.h xen/device-tree: Move Arm's setup.c bootinfo functions to common

[PATCH v4 3/6] xen/common: Move Arm's bootfdt.c to common

2024-04-11 Thread Shawn Anastasio
Move Arm's bootfdt.c to xen/common so that it can be used by other device tree architectures like PPC and RISCV. Suggested-by: Julien Grall Signed-off-by: Shawn Anastasio Acked-by: Julien Grall --- Changes in v4: - move function prototypes to patch 2's xen/include/bootfdt.h - clean up

[PATCH v4 5/6] xen/ppc: mm-radix: Replace debug printing code with printk

2024-04-11 Thread Shawn Anastasio
Now that we have common code building, there's no need to keep the old itoa64+debug print function in mm-radix.c Signed-off-by: Shawn Anastasio Reviewed-by: Jan Beulich --- Changes in v4: none xen/arch/ppc/mm-radix.c | 58 + 1 file changed, 12

Re: [PATCH v3 9/9] xen/ppc: mm-radix: Allocate all paging structures at runtime

2024-04-11 Thread Shawn Anastasio
Hi Jan, On 3/25/24 10:39 AM, Jan Beulich wrote: > On 14.03.2024 23:15, Shawn Anastasio wrote: >> --- a/xen/arch/ppc/mm-radix.c >> +++ b/xen/arch/ppc/mm-radix.c >> @@ -21,69 +21,101 @@ void enable_mmu(void); >> #define radix_dprintk(...) >> #endif >> &

Re: [PATCH v3 5/9] xen/device-tree: Move Arm's setup.c bootinfo functions to common

2024-04-11 Thread Shawn Anastasio
Hi Julien, On 3/21/24 12:53 PM, Julien Grall wrote: > Hi, > > On 14/03/2024 22:15, Shawn Anastasio wrote: >> diff --git a/xen/common/device-tree/Makefile >> b/xen/common/device-tree/Makefile >> new file mode 100644 >> index 00..c97b2bd88c >> --- /d

Re: [PATCH v3 6/9] xen/common: Move Arm's bootfdt.c to common

2024-04-11 Thread Shawn Anastasio
Hi Julien, On 3/21/24 12:50 PM, Julien Grall wrote: > Hi Shawn, > > On 14/03/2024 22:15, Shawn Anastasio wrote: >> Move Arm's bootfdt.c to xen/common so that it can be used by other >> device tree architectures like PPC and RISCV. >> >> Suggested-by: Juli

Re: [PATCH v3 8/9] xen/ppc: mm-radix: Replace debug printing code with printk

2024-04-11 Thread Shawn Anastasio
Hi Jan, On 3/25/24 10:29 AM, Jan Beulich wrote: > On 14.03.2024 23:15, Shawn Anastasio wrote: >> Now that we have common code building, there's no need to keep the old >> itoa64+debug print function in mm-radix.c >> >> Signed-off-by: Shawn Anastasio > > Re

Re: [PATCH v3 5/9] xen/device-tree: Move Arm's setup.c bootinfo functions to common

2024-04-11 Thread Shawn Anastasio
Hi Julien, On 3/21/24 12:47 PM, Julien Grall wrote: > Hi Shawn, > > On 14/03/2024 22:15, Shawn Anastasio wrote: >> Arm's setup.c contains a collection of functions for parsing memory map >> and other boot information from a device tree. Since these routines are >&

Re: [PATCH v3 3/9] xen/ppc: Introduce stub asm/static-shmem.h

2024-04-09 Thread Shawn Anastasio
Hi Jan, On 3/25/24 10:24 AM, Jan Beulich wrote: > On 14.03.2024 23:15, Shawn Anastasio wrote: >> Required for bootfdt.c to build. >> >> Signed-off-by: Shawn Anastasio > > As a temporary workaround this may be okay, but was the alternative > considered to prop

Re: [PATCH] xen/acpi: Allow xen/acpi.h to be included on non-ACPI archs

2024-04-09 Thread Shawn Anastasio
On 4/8/24 1:54 AM, Jan Beulich wrote: > On 05.04.2024 20:20, Shawn Anastasio wrote: >> Conditionalize xen/acpi.h's inclusion of acpi/acpi.h and asm/acpi.h on >> CONFIG_ACPI and import ARM's !CONFIG_ACPI stub for acpi_disabled() so >> that the header can be included on archi

[PATCH] xen/acpi: Allow xen/acpi.h to be included on non-ACPI archs

2024-04-05 Thread Shawn Anastasio
those as well. Suggested-by: Jan Beulich Signed-off-by: Shawn Anastasio --- xen/arch/arm/arm32/mmu/mm.c | 1 + xen/arch/arm/arm64/smpboot.c| 3 ++- xen/arch/arm/domain_build.c | 1 - xen/arch/arm/gic-v2.c | 1 - xen/arch/arm/gic-v3.c | 2 -- xen/arch/arm/include/asm

Re: [PATCH v3 2/9] xen/asm-generic: Introduce generic acpi.h

2024-04-04 Thread Shawn Anastasio
Hi Jan, On 3/25/24 10:19 AM, Jan Beulich wrote: > On 14.03.2024 23:15, Shawn Anastasio wrote: >> Introduce a generic acpi.h header that provides the required definitions >> to allow files including xen/acpi.h to be compiled. The definitions were >> largely derived from t

[PATCH v2] xen/ppc: Ensure ELF sections' physical load addresses start at 0x0

2024-03-20 Thread Shawn Anastasio
that the physical address of the LOAD section header starts at 0x0, move x86's DECL_SECTION macro to xen.lds.h and use it to declare all sections. Signed-off-by: Shawn Anastasio Acked-by: Andrew Cooper --- Changes in v2: - Move DECL_SECTION to xen.lds.h xen/arch/ppc/xen.lds.S| 27

Re: [PATCH v3 5/9] xen/device-tree: Move Arm's setup.c bootinfo functions to common

2024-03-20 Thread Shawn Anastasio
On 3/15/24 4:16 AM, Jan Beulich wrote: > On 14.03.2024 23:15, Shawn Anastasio wrote: >> Arm's setup.c contains a collection of functions for parsing memory map >> and other boot information from a device tree. Since these routines are >> generally useful on any architecture

Re: [PATCH v3 9/9] xen/ppc: mm-radix: Allocate all paging structures at runtime

2024-03-20 Thread Shawn Anastasio
On 3/14/24 5:15 PM, Shawn Anastasio wrote: > In the initial mm-radix implementation, the in-memory partition and > process tables required to configure the MMU, as well as the page tables > themselves were all allocated statically since the boot allocator was > not yet availab

[PATCH] xen/ppc: Ensure ELF sections' physical load addresses start at 0x0

2024-03-20 Thread Shawn Anastasio
that the physical address of the LOAD section header starts at 0x0, import the DECL_SECTION macro from x86's xen.lds.S. Signed-off-by: Shawn Anastasio --- xen/arch/ppc/xen.lds.S | 30 ++ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/xen/arch/ppc

[PATCH v3 1/9] EFI: Introduce inline stub for efi_enabled on !X86 && !ARM

2024-03-14 Thread Shawn Anastasio
On architectures with no EFI support, define an inline stub implementation of efi_enabled in efi.h that always returns false. Suggested-by: Jan Beulich Signed-off-by: Shawn Anastasio --- xen/include/xen/efi.h | 8 1 file changed, 8 insertions(+) diff --git a/xen/include/xen/efi.h b

[PATCH v3 7/9] xen/ppc: Enable bootfdt and boot allocator

2024-03-14 Thread Shawn Anastasio
when booted directly from skiboot. Signed-off-by: Shawn Anastasio --- xen/arch/ppc/include/asm/setup.h | 5 + xen/arch/ppc/setup.c | 21 - xen/common/device-tree/bootfdt.c | 11 +-- 3 files changed, 34 insertions(+), 3 deletions(-) diff --git a/xen/arch

[PATCH v3 0/9] Early Boot Allocation on Power

2024-03-14 Thread Shawn Anastasio
. Thanks, Shawn Shawn Anastasio (9): EFI: Introduce inline stub for efi_enabled on !X86 && !ARM xen/asm-generic: Introduce generic acpi.h xen/ppc: Introduce stub asm/static-shmem.h xen/ppc: Update setup.h with required definitions for bootfdt xen/device-tree: Move Arm's setup.c

[PATCH v3 6/9] xen/common: Move Arm's bootfdt.c to common

2024-03-14 Thread Shawn Anastasio
Move Arm's bootfdt.c to xen/common so that it can be used by other device tree architectures like PPC and RISCV. Suggested-by: Julien Grall Signed-off-by: Shawn Anastasio Acked-by: Julien Grall --- Changes in v2: - Drop #if defined(CONFIG_ARM_EFI) now that efi_enabled is stubbed

[PATCH v3 5/9] xen/device-tree: Move Arm's setup.c bootinfo functions to common

2024-03-14 Thread Shawn Anastasio
-by: Shawn Anastasio --- MAINTAINERS | 1 + xen/arch/arm/setup.c | 419 -- xen/common/Makefile | 1 + xen/common/device-tree/Makefile | 1 + xen/common/device-tree/bootinfo.c | 469 ++ 5 files

[PATCH v3 8/9] xen/ppc: mm-radix: Replace debug printing code with printk

2024-03-14 Thread Shawn Anastasio
Now that we have common code building, there's no need to keep the old itoa64+debug print function in mm-radix.c Signed-off-by: Shawn Anastasio --- Changes in v2: - Use CONFIG_DEBUG instead of NDEBUG xen/arch/ppc/mm-radix.c | 58 + 1 file changed, 12

[PATCH v3 3/9] xen/ppc: Introduce stub asm/static-shmem.h

2024-03-14 Thread Shawn Anastasio
Required for bootfdt.c to build. Signed-off-by: Shawn Anastasio --- xen/arch/ppc/include/asm/static-shmem.h | 12 1 file changed, 12 insertions(+) create mode 100644 xen/arch/ppc/include/asm/static-shmem.h diff --git a/xen/arch/ppc/include/asm/static-shmem.h b/xen/arch/ppc

[PATCH v3 4/9] xen/ppc: Update setup.h with required definitions for bootfdt

2024-03-14 Thread Shawn Anastasio
Add the definitions used by ARM's bootfdt.c, which will be moved into xen/common in a later patch, to PPC's setup.h. Signed-off-by: Shawn Anastasio --- xen/arch/ppc/include/asm/setup.h | 112 +++ 1 file changed, 112 insertions(+) diff --git a/xen/arch/ppc/include

[PATCH v3 2/9] xen/asm-generic: Introduce generic acpi.h

2024-03-14 Thread Shawn Anastasio
Introduce a generic acpi.h header that provides the required definitions to allow files including xen/acpi.h to be compiled. The definitions were largely derived from the !CONFIG_ACPI parts of ARM's acpi.h. Signed-off-by: Shawn Anastasio --- xen/arch/ppc/include/asm/Makefile | 1 + xen/include

[PATCH v3 9/9] xen/ppc: mm-radix: Allocate all paging structures at runtime

2024-03-14 Thread Shawn Anastasio
the size of the Process Table to its maximum supported value (on POWER9). Signed-off-by: Shawn Anastasio --- Changes in v2: - Drop all static allocation and use boot allocator for page tables too xen/arch/ppc/mm-radix.c | 227 +--- 1 file changed, 119

Re: [PATCH v2 7/7] xen/ppc: mm-radix: Allocate Partition and Process Tables at runtime

2024-03-14 Thread Shawn Anastasio
Hi Jan, I'm revisiting this series in preparation for a v3 and had some follow-up comments. On 12/21/23 1:06 AM, Jan Beulich wrote: > On 15.12.2023 03:44, Shawn Anastasio wrote: >> In the initial mm-radix implementation, the in-memory partition and >> process tables required to co

Re: [PATCH 1/7] xen/bitops: Cleanup ahead of rearrangements

2024-03-13 Thread Shawn Anastasio
Hi Andrew, On 3/13/24 12:27 PM, Andrew Cooper wrote: > diff --git a/xen/common/bitops.c b/xen/common/bitops.c > new file mode 100644 > index ..4c07191b4030 > --- /dev/null > +++ b/xen/common/bitops.c > @@ -0,0 +1,41 @@ > +#include > +#include > +#include > + > +/* Hide a value from

Re: [PATCH v2 2/5] xen/domain.h: Centrialize is_domain_direct_mapped()

2024-03-11 Thread Shawn Anastasio
lized ifdef approach suggested by Michal, consider the PPC parts: Acked-by: Shawn Anastasio Thanks, Shawn

Re: [PATCH v9 6/7] xen/ppc: switch PPC to use asm-generic/device.h

2024-03-07 Thread Shawn Anastasio
Hi Oleksii, On 2/16/24 6:39 AM, Oleksii Kurochko wrote: > Signed-off-by: Oleksii Kurochko Acked-by: Shawn Anastasio Thanks, Shawn

Re: [PATCH v9 3/7] xen/asm-generic: ifdef inclusion of

2024-03-07 Thread Shawn Anastasio
ctions from which > aren't available in case of !CONFIG_MEM_ACCESS. > > Suggested-by: Jan Beulich > Signed-off-by: Oleksii Kurochko > Acked-by: Tamas K Lengyel > Acked-by: Julien Grall Acked-by: Shawn Anastasio Thanks, Shawn

Re: [PATCH v9 2/7] xen/asm-generic: introduce stub header monitor.h

2024-03-07 Thread Shawn Anastasio
igned-off-by: Oleksii Kurochko > Acked-by: Jan Beulich > Acked-by: Tamas K Lengyel > Acked-by: Julien Grall Acked-by: Shawn Anastasio Thanks, Shawn

Re: [PATCH] xen/{RISCV,PPC}/xen.lds: Delete duplicate _erodata definitions

2024-03-05 Thread Shawn Anastasio
Hi Andrew, On 3/5/24 6:21 AM, Andrew Cooper wrote: > This is bad copy/paste from somewhere. Retain the second _erodata symbol, > which follows the Build ID, and matches the other architectures. > > No functional change. > > Signed-off-by: Andrew Cooper For the PPC part

Re: [PATCH v2] xen/lib: introduce generic find next bit operations

2024-02-27 Thread Shawn Anastasio
Hi Oleksii, On 2/20/24 9:20 AM, Oleksii wrote: > Hi Shawn, > > Could you please take a look at the patch and PPC-related changes ( > xen/arch/ppc/include/asm/bitops.h )? > Hi Oleksii, Sorry for the delay. This all looks good to me: Acked-by: Shawn Anastasio >

Re: [PATCH v6 1/3] xen: introduce Kconfig function alignment option

2024-02-26 Thread Shawn Anastasio
Hi Roger, On 2/7/24 8:55 AM, Roger Pau Monne wrote: > And use it to replace CODE_ALIGN in assembly. This allows to generalize the > way the code alignment gets set across all architectures. > > No functional change intended. > > Signed-off-by: Roger Pau Monné Acked-b

Re: [PATCH v2 2/6] xen/ppc: address violations of MISRA C:2012 Rule 11.8.

2024-02-26 Thread Shawn Anastasio
Hi Stefano, Sorry for the delay on this. Acked-by: Shawn Anastasio Best, Shawn On 2/23/24 5:19 PM, Stefano Stabellini wrote: > Shawn, > > I am thinking of committing this, if you disagree please say something > in the next couple of days > > > On Tue, 19 Dec 2023,

Re: [PATCH] xen/*/asm-offset: Fix bad copy from x86

2024-01-30 Thread Shawn Anastasio
iu > CC: Stefano Stabellini > CC: Julien Grall > CC: Volodymyr Babchuk > CC: Bertrand Marquis > CC: Michal Orzel > CC: Bob Eshleman > CC: Alistair Francis > CC: Connor Davis > CC: Shawn Anastasio > > Why does PPC have a local copy of ilog2() here

Re: Ping: [PATCH v5 6/8] PPC: switch entry point annotations to common model

2024-01-22 Thread Shawn Anastasio
gt; > The other architectures have been at least partly switched; would be nice > for PPC to follow suit. May I ask for an ack (or otherwise here), please? > Sorry for the delay. Acked-by: Shawn Anastasio > Thanks, Jan Thanks, Shawn

Re: [PATCH v2 6/7] xen/ppc: mm-radix: Replace debug printing code with printk

2024-01-17 Thread Shawn Anastasio
Hi Jan, On 12/20/23 5:48 AM, Jan Beulich wrote: > On 15.12.2023 03:44, Shawn Anastasio wrote: >> Now that we have common code building, there's no need to keep the old >> itoa64+debug print function in mm-radix.c >> >> Signed-off-by: Shawn Anastasio > &

Re: [PATCH v2 5/7] xen/ppc: Enable bootfdt and boot allocator

2024-01-17 Thread Shawn Anastasio
Hi Julien, On 12/20/23 7:49 AM, Julien Grall wrote: > Hi, > > On 15/12/2023 02:44, Shawn Anastasio wrote: >> diff --git a/xen/common/device-tree/bootfdt.c >> b/xen/common/device-tree/bootfdt.c >> index 796ac01c18..7ddfcc7e2a 100644 >> --- a/xen/common/device-t

[PATCH v2] xen/arm: bootfdt: Harden handling of malformed mem reserve map

2024-01-11 Thread Shawn Anastasio
the return code for an error and calling panic(). Signed-off-by: Shawn Anastasio --- v2: - panic() if the fdt_num_mem_rsv() call fails - Reword commit message to clarify that the error condition can only be triggered by a malformed device tree - Rebase to standalone patch instead of a part

Re: [PATCH v3 21/34] xen/riscv: introduce p2m.h

2024-01-11 Thread Shawn Anastasio
Hi Oleksii, On 12/22/23 9:13 AM, Oleksii Kurochko wrote: > Signed-off-by: Oleksii Kurochko > --- > Changes in V3: > - add SPDX > - drop unneeded for now p2m types. > - return false in all functions implemented with BUG() inside. > - update the commit message > --- > Changes in V2: > -

Re: [PATCH v2 4/7] xen/device-tree: Fix bootfdt.c to tolerate 0 reserved regions

2024-01-11 Thread Shawn Anastasio
Hi Julien On 1/9/24 12:14 PM, Julien Grall wrote: > (+ Stefano) > > Hi Shawn, > > On 15/12/2023 02:43, Shawn Anastasio wrote: >> The early_print_info routine in bootfdt.c incorrectly stores the result >> of a call to fdt_num_mem_rsv() in an unsigned int, which resul

Re: [PATCH v2] NUMA: no need for asm/numa.h when !NUMA

2024-01-08 Thread Shawn Anastasio
.h dependent upon NUMA=y. > > Drop the no longer applicable "implement NUMA support" comments - in a > !NUMA section this simply makes no sense. > > Signed-off-by: Jan Beulich Acked-by: Shawn Anastasio Thanks, Shawn

Re: [PATCH v6 8/9] xen/asm-generic: ifdef inclusion of

2024-01-05 Thread Shawn Anastasio
ctions from which > aren't available in case of !CONFIG_MEM_ACCESS. > > Suggested-by: Jan Beulich > Signed-off-by: Oleksii Kurochko Acked-by: Shawn Anastasio Thanks, Shawn

Re: [PATCH v6 7/9] xen: ifdef inclusion of in

2024-01-05 Thread Shawn Anastasio
t; Signed-off-by: Oleksii Kurochko Acked-by: Shawn Anastasio Thanks, Shawn

Re: [PATCH v3 07/34] xen/asm-generic: introdure nospec.h

2024-01-05 Thread Shawn Anastasio
Hi Oleksii, On 12/22/23 9:12 AM, Oleksii Kurochko wrote: > The header is similar between Arm, PPC, and RISC-V, > so it has been moved to asm-generic. > > Signed-off-by: Oleksii Kurochko Acked-by: Shawn Anastasio Thanks, Shawn

Re: [PATCH v2 3/7] xen/common: Move Arm's bootfdt to common

2023-12-20 Thread Shawn Anastasio
On 12/20/23 2:09 AM, Jan Beulich wrote: > On 19.12.2023 19:29, Julien Grall wrote: >> On 19/12/2023 17:03, Jan Beulich wrote: >>> On 15.12.2023 03:43, Shawn Anastasio wrote: >>>> --- a/xen/arch/arm/bootfdt.c >>>> +++ b/xen/common/device-tree/bootfdt.c &g

Re: [PATCH v2 2/7] xen/asm-generic: Introduce generic setup.h

2023-12-20 Thread Shawn Anastasio
Hi Jan, On 12/20/23 5:09 AM, Jan Beulich wrote: > On 15.12.2023 03:43, Shawn Anastasio wrote: >> Introduce setup.h to asm-generic based off of ARM's to define all >> stubs necessary to compile bootfdt.c >> >> Signed-off-by: Shawn Anastasio >> --- >>

[PATCH v2 1/7] xen/asm-generic: Introduce generic static-shmem.h

2023-12-14 Thread Shawn Anastasio
Introduce static-shmem.h to asm-generic as a prerequisite for moving ARM's bootfdt.c into xen/common. Signed-off-by: Shawn Anastasio --- xen/arch/ppc/include/asm/Makefile | 1 + xen/include/asm-generic/static-shmem.h | 12 2 files changed, 13 insertions(+) create mode 100644

[PATCH v2 0/7] Early Boot Allocation on Power

2023-12-14 Thread Shawn Anastasio
, instead of statically allocating them like was previously done. Among other things, switching to run-time allocation allows us to allocate a full-sized Process Table instead of the minimal one that was previously used to keep the Xen binary size small. Thanks, Shawn Shawn Anastasio (7): xen/asm

[PATCH v2 4/7] xen/device-tree: Fix bootfdt.c to tolerate 0 reserved regions

2023-12-14 Thread Shawn Anastasio
. Signed-off-by: Shawn Anastasio --- xen/common/device-tree/bootfdt.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/xen/common/device-tree/bootfdt.c b/xen/common/device-tree/bootfdt.c index ae9fa1e3d6..796ac01c18 100644 --- a/xen/common/device-tree/bootfdt.c +++ b/xen

[PATCH v2 5/7] xen/ppc: Enable bootfdt and boot allocator

2023-12-14 Thread Shawn Anastasio
memory region, as is the case on PPC when booted directly from skiboot. Also includes a minor change to record Xen's correct position on PPC where Xen relocates itself to at the entrypoint. Signed-off-by: Shawn Anastasio --- xen/arch/ppc/include/asm/Makefile | 1 - xen/arch/ppc/include/asm

[PATCH v2 7/7] xen/ppc: mm-radix: Allocate Partition and Process Tables at runtime

2023-12-14 Thread Shawn Anastasio
supported value (on POWER9). Also bump the number of static LVL2/3 PD frames to tolerate cases where the boot allocator returns an address outside of the range of the LVL2 frame used for Xen. Signed-off-by: Shawn Anastasio --- Changes in v2: - Bump LVL2/3 PD count to 3 to avoid running out in case

[PATCH v2 3/7] xen/common: Move Arm's bootfdt to common

2023-12-14 Thread Shawn Anastasio
Move Arm's bootfdt.c to xen/common so that it can be used by other device tree architectures like PPC and RISCV. Only a minor change to conditionalize a call to a function only available on EFI-supporting targets was made to the code itself. Suggested-by: Julien Grall Signed-off-by: Shawn

[PATCH v2 2/7] xen/asm-generic: Introduce generic setup.h

2023-12-14 Thread Shawn Anastasio
Introduce setup.h to asm-generic based off of ARM's to define all stubs necessary to compile bootfdt.c Signed-off-by: Shawn Anastasio --- xen/arch/ppc/include/asm/Makefile | 1 + xen/arch/ppc/include/asm/setup.h | 6 -- xen/include/asm-generic/setup.h | 148

[PATCH v2 6/7] xen/ppc: mm-radix: Replace debug printing code with printk

2023-12-14 Thread Shawn Anastasio
Now that we have common code building, there's no need to keep the old itoa64+debug print function in mm-radix.c Signed-off-by: Shawn Anastasio --- xen/arch/ppc/mm-radix.c | 58 + 1 file changed, 12 insertions(+), 46 deletions(-) diff --git a/xen/arch

Re: [PATCH 0/3] Early Boot Allocation on Power

2023-12-14 Thread Shawn Anastasio
Hi Jan, On 12/4/23 1:58 AM, Jan Beulich wrote: > A standalone patch with this title was sent earlier. What's their > interrelation? > I had intended to prefix this patch with 'RESEND' to clarify that it is the same as the one previously sent, but seem to have forgotten. My apologies! In any

Re: [PATCH 1/3] xen/ppc: Enable Boot Allocator

2023-12-14 Thread Shawn Anastasio
Hi Julien, Thank you for the feedback. Most of your points will be addressed by following your suggestion of moving ARM's bootfdt.c to common, but I wanted to respond with a few points of clarification. On 12/1/23 5:23 PM, Julien Grall wrote: > * fdt_get_mem_rsv_paddr(), this is part of the DT

Re: [PATCH] smp: move cpu_is_offline() definition

2023-12-13 Thread Shawn Anastasio
ulich > Acked-by: Shawn Anastasio Thanks, Shawn

Re: [PATCH v2 07/39] xen/riscv: introduce arch-riscv/hvm/save.h

2023-12-07 Thread Shawn Anastasio
On 12/5/23 9:59 AM, Jan Beulich wrote: > On 24.11.2023 11:30, Oleksii Kurochko wrote: >> --- a/xen/include/public/hvm/save.h >> +++ b/xen/include/public/hvm/save.h >> @@ -91,6 +91,8 @@ DECLARE_HVM_SAVE_TYPE(END, 0, struct hvm_save_end); >> #include "../arch-arm/hvm/save.h" >> #elif

[PATCH 1/3] xen/ppc: Enable Boot Allocator

2023-12-01 Thread Shawn Anastasio
Adapt arm's earlyfdt parsing code to ppc64 and enable Xen's early boot allocator. Routines for parsing arm-specific devicetree nodes (e.g. multiboot) were excluded, reducing the overall footprint of code that was copied. Signed-off-by: Shawn Anastasio --- xen/arch/ppc/Makefile| 1

[PATCH 0/3] Early Boot Allocation on Power

2023-12-01 Thread Shawn Anastasio
Process Table instead of the minimal one that was previously used to keep the Xen binary size small. Thanks, Shawn Anastasio (3): xen/ppc: Enable Boot Allocator xen/ppc: mm-radix: Replace debug printing code with printk xen/ppc: mm-radix: Allocate Partition and Process Tables at runtime xen

[PATCH 3/3] xen/ppc: mm-radix: Allocate Partition and Process Tables at runtime

2023-12-01 Thread Shawn Anastasio
supported value (on POWER9). Signed-off-by: Shawn Anastasio --- xen/arch/ppc/mm-radix.c | 167 +++- 1 file changed, 96 insertions(+), 71 deletions(-) diff --git a/xen/arch/ppc/mm-radix.c b/xen/arch/ppc/mm-radix.c index de181cf6f1..fae5ebfdcc 100644 --- a/xen/arch/ppc

[PATCH 2/3] xen/ppc: mm-radix: Replace debug printing code with printk

2023-12-01 Thread Shawn Anastasio
Now that we have common code building, there's no need to keep the old itoa64+debug print function in mm-radix.c Signed-off-by: Shawn Anastasio --- xen/arch/ppc/mm-radix.c | 58 + 1 file changed, 12 insertions(+), 46 deletions(-) diff --git a/xen/arch

Re: [PATCH v4 12/14] xen/asm-generic: introduce stub header softirq.h

2023-11-29 Thread Shawn Anastasio
Hi Oleksii, On 11/27/23 8:13 AM, Oleksii Kurochko wrote: > is common between Arm, PPC and RISC-V so it is > moved to asm-generic. > > Drop Arm and PPC's softirq.h and use asm-generic version instead. > Acked-by: Shawn Anastasio Thanks, Shawn

Re: [PATCH v4 12/14] xen/asm-generic: introduce stub header softirq.h

2023-11-29 Thread Shawn Anastasio
Hi Oleksii, On 11/27/23 8:13 AM, Oleksii Kurochko wrote: > is common between Arm, PPC and RISC-V so it is > moved to asm-generic. > > Drop Arm and PPC's softirq.h and use asm-generic version instead. > Acked-by: Shawn Anastasio Thanks, Shawn

Re: [PATCH v4 11/14] xen/asm-generic: introduce stub header numa.h

2023-11-29 Thread Shawn Anastasio
s are using it. */ extern mfn_t first_valid_mfn; This should probably be changed to generic/GENERIC as you've done elsewhere in the series. In any case, Acked-by: Shawn Anastasio Thanks, Shawn

Re: [PATCH v4 10/14] xen/asm-generic: introduce stub header monitor.h

2023-11-29 Thread Shawn Anastasio
On 11/29/23 6:39 AM, Oleksii wrote: > Hi Shawn, > > On Tue, 2023-11-28 at 16:21 -0600, Shawn Anastasio wrote: >> Hi Oleksii, >> >> On 11/27/23 8:13 AM, Oleksii Kurochko wrote: >>> diff --git a/xen/arch/ppc/include/asm/Makefile >>> b/xen/arch/

Re: [PATCH v4 02/14] xen/asm-generic: introduce generic device.h

2023-11-29 Thread Shawn Anastasio
On 11/29/23 6:49 AM, Oleksii wrote: > On Tue, 2023-11-28 at 15:28 -0600, Shawn Anastasio wrote: >> Hi Oleksii, >> >> On 11/27/23 8:13 AM, Oleksii Kurochko wrote: >>> diff --git a/xen/arch/ppc/include/asm/irq.h >>> b/xen/arch/ppc/include/asm/irq.h

Re: [PATCH v4 10/14] xen/asm-generic: introduce stub header monitor.h

2023-11-28 Thread Shawn Anastasio
Hi Oleksii, On 11/27/23 8:13 AM, Oleksii Kurochko wrote: > The header is shared between several archs so it is > moved to asm-generic. > > Signed-off-by: Oleksii Kurochko > Acked-by: Jan Beulich . > --- > Changes in V4: > - Removed the double blank line. > - Added Acked-by: Jan Beulich . > -

Re: [PATCH v4 09/14] xen/asm-generic: introduce generic header altp2m.h

2023-11-28 Thread Shawn Anastasio
Hi Oleksii, On 11/27/23 8:13 AM, Oleksii Kurochko wrote: > is common between several archs so it is > moved to asm-generic. > > Arm and PPC were switched to asm-generic version of altp2m.h. > Acked-by: Shawn Anastasio Thanks, Shawn

Re: [PATCH v4 08/14] xen/asm-generic: introduce generic div64.h header

2023-11-28 Thread Shawn Anastasio
Hi Oleksii, On 11/27/23 8:13 AM, Oleksii Kurochko wrote: > All archs have the do_div implementation for BITS_PER_LONG == 64 > so do_div64.h is moved to asm-generic. > > x86 and PPC were switched to asm-generic version of div64.h. > Acked-by: Shawn Anastasio Thanks, Shawn

Re: [PATCH v4 07/14] xen/asm-generic: introduce generalized hardirq.h

2023-11-28 Thread Shawn Anastasio
Hi Oleksii, On 11/27/23 8:13 AM, Oleksii Kurochko wrote: > is common through archs thereby it is moved > to asm-generic. > > Arm and PPC were switched to asm generic verstion of hardirq.h. > Acked-by: Shawn Anastasio Thanks, Shawn

Re: [PATCH v4 06/14] xen/asm-generic: introduce generic header percpu.h

2023-11-28 Thread Shawn Anastasio
plementation of this will need to be fixed (this was also the case before your patch in PPC's current percpu.h but it was conspicuously missing a TODO comment). In any case, Acked-by: Shawn Anastasio Thanks, Shawn

Re: [PATCH v4 05/14] xen/asm-generic: introduce stub header

2023-11-28 Thread Shawn Anastasio
Hi Oleksii, On 11/27/23 8:13 AM, Oleksii Kurochko wrote: > is common for Arm, PPC and RISC-V thereby it > is moved to asm-generic. > Acked-by: Shawn Anastasio Thanks, Shawn

Re: [PATCH v4 04/14] xen/asm-generic: introduce generic header iocap.h

2023-11-28 Thread Shawn Anastasio
Hi Oleksii, On 11/27/23 8:13 AM, Oleksii Kurochko wrote: > iocap.h is common for Arm, PPC and RISC-V architectures thereby > it was moved to asm-generic. > > Also Arm and PPC were switched to asm-generic version of iocap.h. > Acked-by: Shawn Anastasio Thanks, Shawn

Re: [PATCH v4 03/14] xen/asm-generic: introduce generic hypercall.h

2023-11-28 Thread Shawn Anastasio
Hi Oleksii, On 11/27/23 8:13 AM, Oleksii Kurochko wrote: > Introduce an empty generic hypercall.h for archs which don't > implement it. > > Drop PPC's hypercall.h and switch to generic one instead. Acked-by: Shawn Anastasio Thanks, Shawn

Re: [PATCH v4 02/14] xen/asm-generic: introduce generic device.h

2023-11-28 Thread Shawn Anastasio
Hi Oleksii, On 11/27/23 1:46 PM, Oleksii wrote: > On Mon, 2023-11-27 at 15:31 +0100, Jan Beulich wrote: >> On 27.11.2023 15:13, Oleksii Kurochko wrote: >>> --- a/xen/arch/ppc/include/asm/irq.h >>> +++ b/xen/arch/ppc/include/asm/irq.h >>> @@ -3,7 +3,9 @@ >>> #define __ASM_PPC_IRQ_H__ >>> >>>

Re: [PATCH v4 02/14] xen/asm-generic: introduce generic device.h

2023-11-28 Thread Shawn Anastasio
Hi Oleksii, On 11/27/23 8:13 AM, Oleksii Kurochko wrote: > diff --git a/xen/arch/ppc/include/asm/Makefile > b/xen/arch/ppc/include/asm/Makefile > index ece7fa66dd..df4c1ebb08 100644 > --- a/xen/arch/ppc/include/asm/Makefile > +++ b/xen/arch/ppc/include/asm/Makefile > @@ -1,3 +1,4 @@ > #

Re: [PATCH v4 01/14] xen/asm-generic: introduce stub header paging.h

2023-11-28 Thread Shawn Anastasio
ing_mode_translate and paging_mode_external by default. > > Also in this patch Arm and PPC architectures are switched to > generic paging.h header. Acked-by: Shawn Anastasio Thanks, Shawn

Re: [PATCH v2] xen: remove

2023-11-28 Thread Shawn Anastasio
My apologies for the delay on this and thank you for reaching to me for the ping, Oleksii. Acked-by: Shawn Anastasio On 11/27/23 4:26 AM, Oleksii wrote: > Hello Shawn, > > Could you kindly review the patch when you have a moment? > It can help with merging other patch series.

[PATCH] xen/ppc: Enable Boot Allocator

2023-11-17 Thread Shawn Anastasio
Adapt arm's earlyfdt parsing code to ppc64 and enable Xen's early boot allocator. Routines for parsing arm-specific devicetree nodes (e.g. multiboot) were excluded, reducing the overall footprint of code that was copied. Signed-off-by: Shawn Anastasio --- xen/arch/ppc/Makefile| 1

Re: [PATCH v3 2/2] xen/ppc: Implement a basic exception handler

2023-10-26 Thread Shawn Anastasio
On 10/26/23 3:03 AM, Jan Beulich wrote: > On 26.10.2023 00:41, Shawn Anastasio wrote: >> Implement a basic exception handler that dumps the CPU state to the >> console, as well as the code required to set the correct exception >> vector table's base address in setup.c. >&

[PATCH v3 2/2] xen/ppc: Implement a basic exception handler

2023-10-25 Thread Shawn Anastasio
Implement a basic exception handler that dumps the CPU state to the console, as well as the code required to set the correct exception vector table's base address in setup.c. Signed-off-by: Shawn Anastasio --- v3: - Add comment to explain %r1 clobber - Add comment about ISR declaration order

[PATCH v3 0/2] Early exception handlers on Power

2023-10-25 Thread Shawn Anastasio
Hello all, This series implements a basic exception handler and the required support infrastructure on Power. Currently the handler just dumps all registers to the serial console and nothing else, but even this is useful for debugging during early bring-up. Thanks, Shawn Anastasio (2): xen

[PATCH v3 1/2] xen/ppc: Add .text.exceptions section for exception vectors

2023-10-25 Thread Shawn Anastasio
assertion to pave the way for implementing exception support. Signed-off-by: Shawn Anastasio Acked-by: Jan Beulich --- xen/arch/ppc/include/asm/config.h | 3 +++ xen/arch/ppc/xen.lds.S| 7 +++ 2 files changed, 10 insertions(+) diff --git a/xen/arch/ppc/include/asm/config.h b/xen/arch

Re: [PATCH v2 2/2] xen/ppc: Implement a basic exception handler

2023-10-25 Thread Shawn Anastasio
On 10/20/23 1:22 AM, Jan Beulich wrote: > On 19.10.2023 22:02, Shawn Anastasio wrote: >> On 10/18/23 10:43 AM, Jan Beulich wrote: >>> On 13.10.2023 20:13, Shawn Anastasio wrote: >>>> --- a/xen/arch/ppc/setup.c >>>> +++ b/xen/arch/ppc/setup.c >>>&

Re: [PATCH v2 2/2] xen/ppc: Implement a basic exception handler

2023-10-19 Thread Shawn Anastasio
On 10/18/23 10:43 AM, Jan Beulich wrote: > On 13.10.2023 20:13, Shawn Anastasio wrote: >> --- /dev/null >> +++ b/xen/arch/ppc/ppc64/exceptions-asm.S >> @@ -0,0 +1,129 @@ >> +/* SPDX-License-Identifier: GPL-2.0-or-later */ >> + >> +#include >> +#include

[PATCH v2 2/2] xen/ppc: Implement a basic exception handler

2023-10-13 Thread Shawn Anastasio
Implement a basic exception handler that dumps the CPU state to the console, as well as the code required to set the correct exception vector table's base address in setup.c. Signed-off-by: Shawn Anastasio --- v2: - Place {h_,}exception_common in .text.exceptions section - Use assembler

[PATCH v2 1/2] xen/ppc: Add .text.exceptions section for exception vectors

2023-10-13 Thread Shawn Anastasio
assertion to pave the way for implementing exception support. Signed-off-by: Shawn Anastasio --- v2: - Wrap _stext_exceptions definition with HIDDEN() - Drop unnecessary line-continuing backslash in ASSERT xen/arch/ppc/include/asm/config.h | 3 +++ xen/arch/ppc/xen.lds.S| 7 +++ 2

[PATCH v2 0/2] Early exception handlers on Power

2023-10-13 Thread Shawn Anastasio
Hello all, This series implements a basic exception handler and the required support infrastructure on Power. Currently the handler just dumps all registers to the serial console and nothing else, but even this is useful for debugging during early bring-up. Thanks, Shawn Anastasio (2): xen

Re: [PATCH 3/3] xen/ppc: Implement a basic exception handler

2023-10-13 Thread Shawn Anastasio
On 9/29/23 4:48 AM, Andrew Cooper wrote: > On 29/09/2023 12:19 am, Shawn Anastasio wrote: >> Implement a basic exception handler that dumps the CPU state to the >> console, as well as the code required to set the correct exception >> vector table's base address in setu

  1   2   3   4   >