Re: [Xen-devel] [PATCH 1/2] make xen ocaml safe-strings compliant

On Tue, Mar 13, 2018 at 09:29:49AM +, Christian Lindig wrote: > On 12/03/18 19:35, Michael Young wrote: > > > Here is version 4 of the patch where I have replaced the uses of s with b > > where the patch changes it from string to bytes. I have also removed the > > two trailing spaces and

Re: [Xen-devel] [PATCH 1/2] make xen ocaml safe-strings compliant

On 12/03/18 19:35, Michael Young wrote: Here is version 4 of the patch where I have replaced the uses of s with b where the patch changes it from string to bytes. I have also removed the two trailing spaces and changed stmp back to s. Michael Young

Re: [Xen-devel] [PATCH 1/2] make xen ocaml safe-strings compliant

On Mon, 12 Mar 2018, Christian Lindig wrote: The problem with the old patch is illustrated by the following section from the old patch for tools/ocaml/xenstored/utils.ml @@ -85,7 +85,7 @@ let create_unix_socket name =  let read_file_single_integer filename =     let fd = Unix.openfile

Re: [Xen-devel] [PATCH 1/2] make xen ocaml safe-strings compliant

The problem with the old patch is illustrated by the following section from the old patch for tools/ocaml/xenstored/utils.ml @@ -85,7 +85,7 @@ let create_unix_socket name =  let read_file_single_integer filename =     let fd = Unix.openfile filename [ Unix.O_RDONLY ] 0o640 in     let buf

Re: [Xen-devel] [PATCH 1/2] make xen ocaml safe-strings compliant

On Fri, 9 Mar 2018, Christian Lindig wrote: On 9. Mar 2018, at 22:57, Michael Young wrote: I have had a go at fixing the patch and my revised attempt is attached. I suspect it could be tidied up, but it works for me. Thank you for giving this another go. What is

Re: [Xen-devel] [PATCH 1/2] make xen ocaml safe-strings compliant

> On 9. Mar 2018, at 22:57, Michael Young wrote: > > I have had a go at fixing the patch and my revised attempt is attached. I > suspect it could be tidied up, but it works for me. Thank you for giving this another go. What is the key difference to the previous patch

Re: [Xen-devel] [PATCH 1/2] make xen ocaml safe-strings compliant

On Mon, 12 Feb 2018, Wei Liu wrote: On Fri, Feb 09, 2018 at 09:20:33AM +, Christian Lindig wrote: On 8. Feb 2018, at 18:24, Wei Liu wrote: Christian, do you have any idea when you can look into fixing the safe-string patch? Sorry, I can’t make a promise because

Re: [Xen-devel] [PATCH 1/2] make xen ocaml safe-strings compliant

On Fri, 9 Feb 2018, Christian Lindig wrote: Sorry, I can’t make a promise because of my other obligations. I do wonder, though: this patch did not come out of nowhere but supposedly was working - what is different here? The patch was from Fedora and is broken there too! It fixes the build

Re: [Xen-devel] [PATCH 1/2] make xen ocaml safe-strings compliant

On Fri, Feb 09, 2018 at 09:20:33AM +, Christian Lindig wrote: > > > > On 8. Feb 2018, at 18:24, Wei Liu wrote: > > > > Christian, do you have any idea when you can look into fixing the > > safe-string patch? > > Sorry, I can’t make a promise because of my other

Re: [Xen-devel] [PATCH 1/2] make xen ocaml safe-strings compliant

On Fri, 2018-02-09 at 09:20 +, Christian Lindig wrote: > > On 8. Feb 2018, at 18:24, Wei Liu wrote: > > > > Christian, do you have any idea when you can look into fixing the > > safe-string patch? > > Sorry, I can’t make a promise because of my other obligations. I do >

Re: [Xen-devel] [PATCH 1/2] make xen ocaml safe-strings compliant

> On 8. Feb 2018, at 18:24, Wei Liu wrote: > > Christian, do you have any idea when you can look into fixing the > safe-string patch? Sorry, I can’t make a promise because of my other obligations. I do wonder, though: this patch did not come out of nowhere but supposedly

Re: [Xen-devel] [PATCH 1/2] make xen ocaml safe-strings compliant

On Thu, Feb 08, 2018 at 06:03:48PM +, Wei Liu wrote: > On Thu, Feb 08, 2018 at 06:49:58PM +0100, Dario Faggioli wrote: > > On Tue, 2018-01-30 at 22:55 +, Michael Young wrote: > > > Xen built with ocaml 4.06 gives errors such as > > > Error: This expression has type bytes but an expression

Re: [Xen-devel] [PATCH 1/2] make xen ocaml safe-strings compliant

On Thu, Feb 08, 2018 at 06:49:58PM +0100, Dario Faggioli wrote: > On Tue, 2018-01-30 at 22:55 +, Michael Young wrote: > > Xen built with ocaml 4.06 gives errors such as > > Error: This expression has type bytes but an expression was > > expected of type string > > as Byte and safe-strings

Re: [Xen-devel] [PATCH 1/2] make xen ocaml safe-strings compliant

On Tue, 2018-01-30 at 22:55 +, Michael Young wrote: > Xen built with ocaml 4.06 gives errors such as > Error: This expression has type bytes but an expression was > expected of type string > as Byte and safe-strings which were introduced in 4.02 are the > default in 4.06. > This patch

Re: [Xen-devel] [PATCH 1/2] make xen ocaml safe-strings compliant

On Tue, Feb 06, 2018 at 09:56:14PM +, Michael Young wrote: > On Tue, 6 Feb 2018, Wei Liu wrote: > > > On Tue, Jan 30, 2018 at 10:55:47PM +, Michael Young wrote: > > > Xen built with ocaml 4.06 gives errors such as > > > Error: This expression has type bytes but an expression was > > >

Re: [Xen-devel] [PATCH 1/2] make xen ocaml safe-strings compliant

On Tue, 6 Feb 2018, Wei Liu wrote: On Tue, Jan 30, 2018 at 10:55:47PM +, Michael Young wrote: Xen built with ocaml 4.06 gives errors such as Error: This expression has type bytes but an expression was expected of type string as Byte and safe-strings which were introduced in 4.02

Re: [Xen-devel] [PATCH 1/2] make xen ocaml safe-strings compliant

On Tue, Jan 30, 2018 at 10:55:47PM +, Michael Young wrote: > Xen built with ocaml 4.06 gives errors such as > Error: This expression has type bytes but an expression was > expected of type string > as Byte and safe-strings which were introduced in 4.02 are the > default in 4.06. > This