Re: [Xen-devel] [PATCH v3 04/17] SUPPORT.md: Add core ARM features

2017-11-23 Thread George Dunlap
On 11/23/2017 11:11 AM, Julien Grall wrote: > Hi George, > > On 22/11/17 19:20, George Dunlap wrote: >> Hardware support and guest type. >> >> Signed-off-by: George Dunlap >> --- >> Changes since v2: >> - Moved SMMUv* into generic IOMMU section

Re: [Xen-devel] [PATCH 13/16] SUPPORT.md: Add secondary memory management features

2017-11-23 Thread George Dunlap
On 11/23/2017 11:55 AM, Olaf Hering wrote: > On Thu, Nov 23, Olaf Hering wrote: > >> On Thu, Nov 23, Jan Beulich wrote: >>> Olaf, are you still playing with it every now and then? >> No, I have not tried it since I last touched it. > > I just tried it, and it failed: > > root@stein-schneider:~ #

Re: [Xen-devel] [PATCH v3 06/17] SUPPORT.md: Add scalability features

2017-11-23 Thread George Dunlap
On 11/23/2017 10:50 AM, Jan Beulich wrote: >>>> On 22.11.17 at 20:20, wrote: >> Superpage support and PVHVM. >> >> Signed-off-by: George Dunlap > > Acked-by: Jan Beulich > with one remark: > >> +## Scalability >> + >> +### Super p

Re: [Xen-devel] [PATCH v3 07/17] SUPPORT.md: Add virtual devices common to ARM and x86

2017-11-23 Thread George Dunlap
On 11/23/2017 10:59 AM, Jan Beulich wrote: >>>> On 22.11.17 at 20:20, wrote: >> Mostly PV protocols. >> >> Signed-off-by: George Dunlap > > Acked-by: Jan Beulich > with a couple of remarks. > >> @@ -223,6 +227,152 @@ which add paravirtuali

Re: [Xen-devel] [PATCH v3 10/17] SUPPORT.md: Add Debugging, analysis, crash post-portem

2017-11-23 Thread George Dunlap
On 11/23/2017 11:15 AM, Jan Beulich wrote: On 22.11.17 at 20:20, wrote: >> +## Debugging, analysis, and crash post-mortem >> + >> +### Host serial console >> + >> +Status, NS16550: Supported >> +Status, EHCI: Supported > > Inconsistent indentation. And I was so sure I'd checked all

Re: [Xen-devel] [PATCH v3 12/17] SUPPORT.md: Add Security-releated features

2017-11-23 Thread George Dunlap
On 11/23/2017 11:16 AM, Jan Beulich wrote: On 22.11.17 at 20:20, wrote: >> +### Live Patching >> + >> +Status, x86: Supported >> +Status, ARM: Experimental >> + >> +Compile time disabled for ARM > > "... by default"? > >> +### XSM & FLASK >> + >> +Status: Experimental >> + >> +C

Re: [Xen-devel] [PATCH v3 16/17] SUPPORT.md: Add limits RFC

2017-11-23 Thread George Dunlap
On 11/23/2017 11:21 AM, Jan Beulich wrote: On 22.11.17 at 20:20, wrote: >> +### Virtual RAM >> + >> +Limit-security, x86 PV 64-bit: 2047GiB >> +Limit-security, x86 PV 32-bit: 168GiB (see below) >> +Limit-security, x86 HVM: 1.5TiB >> +Limit, ARM32: 16GiB >> +Limit, ARM64: 1

Re: [Xen-devel] [PATCH 13/16] SUPPORT.md: Add secondary memory management features

2017-11-23 Thread George Dunlap
On 11/23/2017 12:58 PM, Andrew Cooper wrote: > On 23/11/17 12:45, Olaf Hering wrote: >> On Thu, Nov 23, Andrew Cooper wrote: >> >>> Its not that.  This failure comes from the ring living inside the p2m, >>> and has already been found with introspection. >> In my case it was just a wrong domid. Now

Re: [Xen-devel] [PATCH v3 05/17] SUPPORT.md: Toolstack core

2017-11-27 Thread George Dunlap
On 11/24/2017 04:26 PM, Ian Jackson wrote: > George Dunlap writes ("[PATCH v3 05/17] SUPPORT.md: Toolstack core"): >> For now only include xl-specific features, or interaction with the >> system. Feature support matrix will be added when features are >> me

Re: [Xen-devel] [PATCH 2/3] x86: check paging mode earlier in xenmem_add_to_physmap_one()

2017-11-27 Thread George Dunlap
On 11/27/2017 09:12 AM, Jan Beulich wrote: > There's no point in deferring this until after some initial processing, > and it's actively wrong for the XENMAPSPACE_gmfn_foreign handling to not > have such a check at all. > > Signed-off-by: Jan Beulich Reviewed-by: Geo

Re: [Xen-devel] [PATCH 1/3] x86: replace bad ASSERT() in xenmem_add_to_physmap_one()

2017-11-27 Thread George Dunlap
On 11/27/2017 09:11 AM, Jan Beulich wrote: > There are no locks being held, i.e. it is possible to be triggered by > racy hypercall invocations. Subsequent code doesn't really depend on the > checked values, so this is not a security issue. > > Signed-off-by: Jan Beulich Ack

Re: [Xen-devel] [PATCH v3 05/17] SUPPORT.md: Toolstack core

2017-11-27 Thread George Dunlap
On 11/27/2017 11:43 AM, Roger Pau Monné wrote: > On Wed, Nov 22, 2017 at 07:20:12PM +0000, George Dunlap wrote: >> For now only include xl-specific features, or interaction with the >> system. Feature support matrix will be added when features are >> mentioned. >> >

Re: [Xen-devel] [PATCH v3 05/17] SUPPORT.md: Toolstack core

2017-11-27 Thread George Dunlap
On 11/27/2017 11:43 AM, Roger Pau Monné wrote: > On Wed, Nov 22, 2017 at 07:20:12PM +0000, George Dunlap wrote: >> For now only include xl-specific features, or interaction with the >> system. Feature support matrix will be added when features are >> mentioned. >> >

Re: [Xen-devel] [PATCH v3 10/17] SUPPORT.md: Add Debugging, analysis, crash post-portem

2017-11-27 Thread George Dunlap
On 11/24/2017 08:04 AM, Jan Beulich wrote: On 23.11.17 at 18:08, wrote: >> On 11/23/2017 11:15 AM, Jan Beulich wrote: >> On 22.11.17 at 20:20, wrote: +## Debugging, analysis, and crash post-mortem + +### Host serial console + +Status, NS16550: Supported

Re: [Xen-devel] [PATCH v3 16/17] SUPPORT.md: Add limits RFC

2017-11-27 Thread George Dunlap
On 11/24/2017 08:14 AM, Jan Beulich wrote: On 23.11.17 at 18:21, wrote: >> On 11/23/2017 11:21 AM, Jan Beulich wrote: >> On 22.11.17 at 20:20, wrote: +### Virtual RAM + +Limit-security, x86 PV 64-bit: 2047GiB +Limit-security, x86 PV 32-bit: 168GiB (see below)

Re: [Xen-devel] [PATCH v3 05/17] SUPPORT.md: Toolstack core

2017-11-27 Thread George Dunlap
On 11/27/2017 02:39 PM, Roger Pau Monné wrote: > On Mon, Nov 27, 2017 at 02:12:40PM +0000, George Dunlap wrote: >> On 11/27/2017 11:43 AM, Roger Pau Monné wrote: >>> On Wed, Nov 22, 2017 at 07:20:12PM +0000, George Dunlap wrote: >>>> For now only include xl-specific

Re: [Xen-devel] [PATCH v3 14/17] SUPPORT.md: Add statement on PCI passthrough

2017-11-27 Thread George Dunlap
On 11/23/2017 11:17 AM, Jan Beulich wrote: >>>> On 22.11.17 at 20:20, wrote: >> Signed-off-by: George Dunlap > > With the XXX suitably addressed > Acked-by: Jan Beulich Would you give an Ack for the XXX line simply removed to begin with? Or would you rather wait

Re: [Xen-devel] [PATCH v3 05/17] SUPPORT.md: Toolstack core

2017-11-27 Thread George Dunlap
On 11/27/2017 02:39 PM, Roger Pau Monné wrote: > On Mon, Nov 27, 2017 at 02:12:40PM +0000, George Dunlap wrote: >> On 11/27/2017 11:43 AM, Roger Pau Monné wrote: >>> On Wed, Nov 22, 2017 at 07:20:12PM +0000, George Dunlap wrote: >>>> For now only include xl-specific

Re: [Xen-devel] [PATCH v3 14/17] SUPPORT.md: Add statement on PCI passthrough

2017-11-27 Thread George Dunlap
On 11/27/2017 03:04 PM, Jan Beulich wrote: >>>> On 27.11.17 at 15:48, wrote: >> On 11/23/2017 11:17 AM, Jan Beulich wrote: >>>>>> On 22.11.17 at 20:20, wrote: >>>> Signed-off-by: George Dunlap >>> >>> With the XXX suitably addres

Re: [Xen-devel] [PATCH v3 08/17] SUPPORT.md: Add x86-specific virtual hardware

2017-11-27 Thread George Dunlap
On 11/27/2017 03:12 PM, Anthony PERARD wrote: > On Wed, Nov 22, 2017 at 07:20:15PM +0000, George Dunlap wrote: >> x86-specific virtual hardware provided by the hypervisor, toolstack, >> or QEMU. >> >> Signed-off-by: George Dunlap >> --- >> Changes since v2

Re: [Xen-devel] [PATCH] XSM: add Kconfig option to override bootloader provided policy

2017-11-29 Thread George Dunlap
can't >>> be replaced by another unmeasured policy by the bootloader. Note that the >>> XSM >>> policy can still be updated after boot (from dom0 for example) if the >>> built-in >>> policy allows it. >>> >>> Signed-off-by

Re: [Xen-devel] [PATCH 1/2] gnttab: correct GNTTABOP_cache_flush empty batch handling

2017-12-04 Thread George Dunlap
On 11/30/2017 02:31 PM, Jan Beulich wrote: > Jann validly points out that with a caller bogusly requesting a zero- > element batch with non-zero high command bits (the ones used for > continuation encoding), the assertion right before the call to > hypercall_create_continuation() would trigger. A s

Re: [Xen-devel] [PATCH 2/2] gnttab: improve GNTTABOP_cache_flush locking

2017-12-04 Thread George Dunlap
On 12/04/2017 09:02 AM, Jan Beulich wrote: On 01.12.17 at 16:31, wrote: >> On 30/11/17 14:32, Jan Beulich wrote: >>> Dropping the lock before returning from grant_map_exists() means handing >>> possibly stale information back to the caller. Return back the pointer >>> to the active entry inst

Re: [Xen-devel] [Xen-users] Starting xenstored in a driver domain

2017-12-04 Thread George Dunlap
ilable to domain 0 but not to a driver domain). Can you try the attached patch and see if it helps? -George From 4c2194428bda881541760df489b4d68d3da5da88 Mon Sep 17 00:00:00 2001 From: George Dunlap Date: Mon, 4 Dec 2017 14:44:48 + Subject: [PATCH] hotplug: Fix vif-openvswitch to run inside

Re: [Xen-devel] [RFC] xen/arm: Handling cache maintenance instructions by set/way

2017-12-06 Thread George Dunlap
On 12/05/2017 06:39 PM, Julien Grall wrote: > Hi all, > > Even though it is an Arm failure, I have CCed x86 folks to get feedback > on the approach. I have a WIP branch I could share if that interest people. > > Few months ago, we noticed an heisenbug on jobs run by osstest on the > cubietrucks (

Re: [Xen-devel] [RFC] xen/arm: Handling cache maintenance instructions by set/way

2017-12-06 Thread George Dunlap
On 12/06/2017 03:19 PM, Julien Grall wrote: > Hi Konrad, > > On 12/06/2017 03:10 PM, Konrad Rzeszutek Wilk wrote: >> .snip.. >>> The suggested policy is based on the KVM one: >>> - If we trap a S/W instructions, we enable VM trapping (e.g >>> HCR_EL2.TVM) to >>> detect cache being turned on/of

Re: [Xen-devel] [RFC] xen/arm: Handling cache maintenance instructions by set/way

2017-12-06 Thread George Dunlap
On 12/06/2017 12:58 PM, Julien Grall wrote: > Hi George, > > On 12/06/2017 12:28 PM, George Dunlap wrote: >> On 12/05/2017 06:39 PM, Julien Grall wrote: >>> Hi all, >>> >>> Even though it is an Arm failure, I have CCed x86 folks to get feedback >&g

Re: [Xen-devel] [PATCH 1/3] x86/PoD: correctly handle non-order-0 decrease-reservation requests

2017-12-07 Thread George Dunlap
On 12/04/2017 11:06 AM, Jan Beulich wrote: > p2m_pod_decrease_reservation() returning just (not) all-done is not > sufficient for the caller: If some pages were processed, > guest_remove_page() returning an error for those pages is the expected > result rather than an indication of a problem. Make

Re: [Xen-devel] [RFC] xen/arm: Handling cache maintenance instructions by set/way

2017-12-07 Thread George Dunlap
On 12/07/2017 04:04 PM, Julien Grall wrote: > Hi Jan, > > On 07/12/17 15:45, Jan Beulich wrote: > On 07.12.17 at 15:53, wrote: >>> On 07/12/17 13:52, Julien Grall wrote: >>> There is exactly one case where set/way makes sense, and that's when >>> you're the only CPU left in the system, your M

Re: [Xen-devel] [RFC] xen/arm: Handling cache maintenance instructions by set/way

2017-12-07 Thread George Dunlap
On 12/07/2017 04:58 PM, Marc Zyngier wrote: > On 07/12/17 16:44, George Dunlap wrote: >> On 12/07/2017 04:04 PM, Julien Grall wrote: >>> Hi Jan, >>> >>> On 07/12/17 15:45, Jan Beulich wrote: >>>>>>> On 07.12.17 at 15:53, wrote: >>&g

Re: [Xen-devel] [RFC] xen/arm: Handling cache maintenance instructions by set/way

2017-12-08 Thread George Dunlap
On 12/07/2017 07:21 PM, Marc Zyngier wrote: > On 07/12/17 18:06, George Dunlap wrote: >> On 12/07/2017 04:58 PM, Marc Zyngier wrote: >>> On 07/12/17 16:44, George Dunlap wrote: >>>> On 12/07/2017 04:04 PM, Julien Grall wrote: >>>>> Hi Jan, >

Re: [Xen-devel] How to make tracking CPU cache-miss on Xen?

2017-12-11 Thread George Dunlap
On Mon, Dec 11, 2017 at 5:59 AM, Minjun Hong wrote: > Hello, I'm working on the 'credit scheduler' of Xen. > And I need to compare CPU cache misses between original Xen and my patching > version. > But I failed all attempt even if I have tried many methods by googling. > When I typed 'perf list' w

Re: [Xen-devel] [RFC] xen/arm: Handling cache maintenance instructions by set/way

2017-12-11 Thread George Dunlap
On 12/11/2017 11:10 AM, Andre Przywara wrote: > Hi, > > On 08/12/17 10:56, George Dunlap wrote: >> On 12/07/2017 07:21 PM, Marc Zyngier wrote: >>> On 07/12/17 18:06, George Dunlap wrote: >>>> On 12/07/2017 04:58 PM, Marc Zyngier wrote: >>>>> On 0

Re: [Xen-devel] [PATCH v8] x86/altp2m: support for setting restrictions for an array of pages

2017-12-11 Thread George Dunlap
On 12/11/2017 12:12 PM, Jan Beulich wrote: On 11.12.17 at 12:06, wrote: >> On 11/12/17 09:14, Jan Beulich wrote: >> On 08.12.17 at 13:42, wrote: On 12/08/2017 02:18 PM, Jan Beulich wrote: On 24.10.17 at 12:19, wrote: >> HVMOP_altp2m_set_mem_access_multi has been added

Re: [Xen-devel] [PATCH v8] x86/altp2m: support for setting restrictions for an array of pages

2017-12-11 Thread George Dunlap
On 12/11/2017 01:36 PM, Jan Beulich wrote: On 11.12.17 at 13:50, wrote: >> On 12/11/2017 12:12 PM, Jan Beulich wrote: >> On 11.12.17 at 12:06, wrote: My suggestion was that we don't break usecases. The Intel usecase specifically is for an in-guest entity to have full control o

Re: [Xen-devel] [PATCH v8] x86/altp2m: support for setting restrictions for an array of pages

2017-12-11 Thread George Dunlap
On 12/11/2017 02:46 PM, Razvan Cojocaru wrote: > On 12/11/2017 03:36 PM, Jan Beulich wrote: > On 11.12.17 at 13:50, wrote: >>> On 12/11/2017 12:12 PM, Jan Beulich wrote: >>> On 11.12.17 at 12:06, wrote: > My suggestion was that we don't break usecases. The Intel usecase > specifi

Re: [Xen-devel] [PATCH v8] x86/altp2m: support for setting restrictions for an array of pages

2017-12-11 Thread George Dunlap
On 12/11/2017 02:51 PM, George Dunlap wrote: > On 12/11/2017 02:46 PM, Razvan Cojocaru wrote: >> On 12/11/2017 03:36 PM, Jan Beulich wrote: >>>>>> On 11.12.17 at 13:50, wrote: >>>> On 12/11/2017 12:12 PM, Jan Beulich wrote: >>>>>>>>

Re: [Xen-devel] How to make tracking CPU cache-miss on Xen?

2017-12-11 Thread George Dunlap
On Mon, Dec 11, 2017 at 3:05 PM, Boris Ostrovsky wrote: > On 12/11/2017 09:36 AM, Meng Xu wrote: >> On Mon, Dec 11, 2017 at 8:14 AM, Minjun Hong wrote: >>> Thanks for your answer, George. >>> >>> What I want ultimately is cache misses from the guest, but even I could not >>> get the cache misses

Re: [Xen-devel] [PATCH v8] x86/altp2m: support for setting restrictions for an array of pages

2017-12-11 Thread George Dunlap
On 12/11/2017 02:58 PM, Jan Beulich wrote: On 11.12.17 at 15:50, wrote: >> On 12/11/2017 01:36 PM, Jan Beulich wrote: >> On 11.12.17 at 13:50, wrote: You argued that we should keep PV linear pagetables, before knowing that NetBSD used them, in spite of having discovered two *ac

Re: [Xen-devel] [PATCH v8] x86/altp2m: support for setting restrictions for an array of pages

2017-12-11 Thread George Dunlap
On 12/11/2017 03:05 PM, Jan Beulich wrote: On 11.12.17 at 15:51, wrote: >> On 12/11/2017 02:46 PM, Razvan Cojocaru wrote: >>> On 12/11/2017 03:36 PM, Jan Beulich wrote: >>> On 11.12.17 at 13:50, wrote: > On 12/11/2017 12:12 PM, Jan Beulich wrote: > On 11.12.17 at 12:06, wrot

Re: [Xen-devel] [PATCH v8] x86/altp2m: support for setting restrictions for an array of pages

2017-12-11 Thread George Dunlap
On Tue, Oct 24, 2017 at 11:19 AM, Petre Pircalabu wrote: > From: Razvan Cojocaru > > For the default EPT view we have xc_set_mem_access_multi(), which > is able to set an array of pages to an array of access rights with > a single hypercall. However, this functionality was lacking for the > altp2

Re: [Xen-devel] [PATCH v8] x86/altp2m: support for setting restrictions for an array of pages

2017-12-11 Thread George Dunlap
On Tue, Oct 24, 2017 at 11:19 AM, Petre Pircalabu wrote: > From: Razvan Cojocaru > > For the default EPT view we have xc_set_mem_access_multi(), which > is able to set an array of pages to an array of access rights with > a single hypercall. However, this functionality was lacking for the > altp2

Re: [Xen-devel] Xen Security Advisory 240 (CVE-2017-15595) - Unlimited recursion in linear pagetable de-typing

2017-12-12 Thread George Dunlap
On Tue, Dec 12, 2017 at 10:03 AM, Steven Haigh wrote: > On Tuesday, 12 December 2017 5:16:06 AM AEDT Xen. org security team wrote: >> Xen Security Advisory CVE-2017-15595 / XSA-240 >>version 6 >> >>Unlimited recursion in linear pagetable de-t

Re: [Xen-devel] [PATCH 4/6] x86/shadow: widen reference count

2017-12-12 Thread George Dunlap
On 12/12/2017 03:07 PM, Jan Beulich wrote: > Utilize as many of the bits available in the union as possible, without > (just to be on the safe side) colliding with any of the bits outside of > PGT_type_mask. > > Signed-off-by: Jan Beulich > > --- a/xen/arch/x86/mm/shadow/private.h > +++ b/xen/ar

Re: [Xen-devel] [PATCH 5/6] x86/mm: clean up SHARED_M2P{, _ENTRY} uses

2017-12-12 Thread George Dunlap
On 12/12/2017 03:08 PM, Jan Beulich wrote: > Stop open-coding SHARED_M2P() and drop a pointless use of it from > paging_mfn_is_dirty() (!VALID_M2P() is a superset of SHARED_M2P()) and > another one from free_page_type() (prior assertions render this > redundant). > > Signed-off-by: Jan Beulich >

Re: [Xen-devel] [PATCH 4/6] x86/shadow: widen reference count

2017-12-13 Thread George Dunlap
On 12/13/2017 09:17 AM, Jan Beulich wrote: On 12.12.17 at 17:32, wrote: >>> @@ -82,7 +153,7 @@ struct page_info >>> unsigned long type:5; /* What kind of shadow is this? */ >>> unsigned long pinned:1; /* Is the shadow pinned? */ >>> unsigned long head:

Re: [Xen-devel] [PATCH] docs/process/release-checklist.txt: Say to push staging branch

2017-12-13 Thread George Dunlap
then people who just "git fetch" > won't get the tag because it refers to commits they don't have. > (Because of the strange rules git has about tag fetching.) > Worse, the same may be true of people who "git clone". > > And anyway, those commits *should

Re: [Xen-devel] [PATCH V1 1/1] Xen/libxl: Perform PCI reset using 'reset' SysFS attribute

2017-12-13 Thread George Dunlap
On Thu, Dec 7, 2017 at 10:26 PM, Govinda Tatti wrote: > The life-cycle of a PCI device in Xen pciback is complex and is constrained > by the generic PCI locking mechanism. > > - It starts with the device being bound to us, for which we do a function > reset (done via SysFS so the PCI lock is hel

Re: [Xen-devel] [PATCH] docs/process/xen-release-management: Lesson to learn

2017-12-13 Thread George Dunlap
On Wed, Dec 13, 2017 at 12:02 PM, Ian Jackson wrote: > The 4.10 release preparation was significantly more hairy than ideal. > (We seem to have a good overall outcome despite, rather than because > of, our approach.) > > This is the second time (at least) that we have come close to failure > by co

Re: [Xen-devel] [PATCH V1 1/1] Xen/libxl: Perform PCI reset using 'reset' SysFS attribute

2017-12-14 Thread George Dunlap
On Wed, Dec 13, 2017 at 9:05 PM, Govinda Tatti wrote: > > Thanks George for your review comments. Please see below for my comments. > > > On 12/13/2017 8:01 AM, George Dunlap wrote: >> >> On Thu, Dec 7, 2017 at 10:26 PM, Govinda Tatti >> wrote: >>>

Re: [Xen-devel] [PATCH v3] x86/altp2m: Add a new hypercall to get the active altp2m index

2019-09-04 Thread George Dunlap
Sorry it took so long to get to it: Reviewed-by: George Dunlap ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [RFC] Generating Go bindings for libxl

2019-09-04 Thread George Dunlap
On 9/4/19 1:36 AM, Nicholas Rosbrook wrote: > George, > >> Are you up for taking a stab at something like `gengotypes.py`? > > I have was able to make a bit of progress on this over the weekend. I've > started > `gengotypes.py` in my branch[1]; the portion which generates > `xenlight_types.go`

Re: [Xen-devel] [RFC] Generating Go bindings for libxl

2019-09-04 Thread George Dunlap
On 9/4/19 5:52 PM, George Dunlap wrote: > On 9/4/19 1:36 AM, Nicholas Rosbrook wrote: >> George, >> >>> Are you up for taking a stab at something like `gengotypes.py`? >> >> I have was able to make a bit of progress on this over the weekend. I've >>

Re: [Xen-devel] [PATCH] x86/libxl: choose a sane default for HAP

2019-09-05 Thread George Dunlap
> On Sep 5, 2019, at 11:01 AM, Roger Pau Monne wrote: > > On Thu, Sep 05, 2019 at 11:52:59AM +0200, Jan Beulich wrote: >> On 05.09.2019 11:34, Roger Pau Monne wrote: >>> Current libxl code will always enable Hardware Assisted Paging (HAP), >>> expecting that the hypervisor will fallback to shad

Re: [Xen-devel] [PATCH] x86/libxl: choose a sane default for HAP

2019-09-05 Thread George Dunlap
On 9/5/19 12:01 PM, Roger Pau Monné wrote: > On Thu, Sep 05, 2019 at 12:34:11PM +0200, George Dunlap wrote: >> >> >>> On Sep 5, 2019, at 11:01 AM, Roger Pau Monne wrote: >>> >>> On Thu, Sep 05, 2019 at 11:52:59AM +0200, Jan Beulich wrote: >&

[Xen-devel] RFC: Criteria for checking in core scheduling series

2019-09-06 Thread George Dunlap
There was a discussion on the community call about the core scheduling series being developed by Juergen Gross [1]. The conclusion can be summarized as follows: * We normally wait to check in series until they are quite good -- all the i's dotted and all the t's crossed * This is for several rea

Re: [Xen-devel] [RFC] Generating Go bindings for libxl

2019-09-12 Thread George Dunlap
On 9/11/19 9:25 PM, Nicholas Rosbrook wrote: > Hi George, > > I made some more progress on gengotypes.py [1]. [snip] > What are your thoughts on these implementations so far? Great! Overall it looks like it's really making progress, which is exciting. > First, I implemented the KeyedUnion trans

Re: [Xen-devel] [RFC] Generating Go bindings for libxl

2019-09-13 Thread George Dunlap
On 9/12/19 6:35 PM, Nicholas Rosbrook wrote: > I'm not strongly opposed to the struct duplication, but I do prefer the > ability > to perform type assertions as a way to determine which field is "valid." Fair enough. >> So the advantage of this is that you can just call: >> >>     fromC(&di, &cd

Re: [Xen-devel] [PATCH v12 6/6] introduce a 'passthrough' configuration option to xl.cfg...

2019-09-16 Thread George Dunlap
On 9/16/19 10:27 AM, Paul Durrant wrote: > ...and hence the ability to disable IOMMU mappings, and control EPT > sharing. > > This patch introduces a new 'libxl_passthrough' enumeration into > libxl_domain_create_info. The value will be set by xl either when it parses > a new 'passthrough' option

Re: [Xen-devel] [PATCH] SUPPORT.md: Add PV display/sound, update keyboard

2019-09-30 Thread George Dunlap
On 9/30/19 9:56 AM, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > Signed-off-by: Oleksandr Andrushchenko > --- > SUPPORT.md | 15 ++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/SUPPORT.md b/SUPPORT.md > index 375473a45640..b536cf0814f3 1

Re: [Xen-devel] [PATCH] SUPPORT.md: Add PV display/sound, update keyboard

2019-09-30 Thread George Dunlap
On 9/30/19 11:29 AM, George Dunlap wrote: > On 9/30/19 9:56 AM, Oleksandr Andrushchenko wrote: >> From: Oleksandr Andrushchenko >> >> Signed-off-by: Oleksandr Andrushchenko >> --- >> SUPPORT.md | 15 ++- >> 1 file changed, 14 insertio

Re: [Xen-devel] [PATCH v5 01/19] xen/sched: add code to sync scheduling of all vcpus of a sched unit

2019-09-30 Thread George Dunlap
On 9/30/19 11:39 AM, Jan Beulich wrote: > On 30.09.2019 12:38, Andrew Cooper wrote: >> On 30/09/2019 11:36, Jan Beulich wrote: >>> On 30.09.2019 07:21, Juergen Gross wrote: When switching sched units synchronize all vcpus of the new unit to be scheduled at the same time. A varia

Re: [Xen-devel] [PATCH] SUPPORT.md: Add PV display/sound, update keyboard

2019-09-30 Thread George Dunlap
On 9/30/19 11:53 AM, Jürgen Groß wrote: > On 30.09.19 12:33, George Dunlap wrote: >> On 9/30/19 11:29 AM, George Dunlap wrote: >>> On 9/30/19 9:56 AM, Oleksandr Andrushchenko wrote: >>>> From: Oleksandr Andrushchenko >>>> &

Re: [Xen-devel] [PATCH v5 20/19] docs: add "sched-gran" boot parameter documentation

2019-09-30 Thread George Dunlap
On 9/30/19 12:26 PM, Jürgen Groß wrote: > On 30.09.19 13:20, Jan Beulich wrote: >> On 30.09.2019 13:13, Jürgen Groß wrote: >>> On 30.09.19 13:02, Jan Beulich wrote: On 30.09.2019 12:51, Jürgen Groß wrote: > On 30.09.19 12:25, Jan Beulich wrote: >> On 30.09.2019 12:09, Juergen Gross wro

Re: [Xen-devel] [RFC] Generating Go bindings for libxl

2019-09-30 Thread George Dunlap
On 9/24/19 1:33 AM, Nicholas Rosbrook wrote: > Hi George, > > I made the changes that we discussed WRT C to Go type marshaling. See [1] for > generated code. > > In addition, I took a pass at implementing Go to C type marshaling. The > generated toC functions are also in [1]. > > Finally, I ma

Re: [Xen-devel] [PATCH v4 2/4] x86/mem_sharing: copy a page_lock version to be internal to memshr

2019-05-03 Thread George Dunlap
On 5/3/19 2:57 PM, Jan Beulich wrote: On 03.05.19 at 15:43, wrote: >> On Fri, May 3, 2019 at 2:27 AM Jan Beulich wrote: >>> >> On 03.05.19 at 00:13, wrote: --- a/xen/arch/x86/mm/mem_sharing.c +++ b/xen/arch/x86/mm/mem_sharing.c @@ -112,13 +112,48 @@ static inline void pag

Re: [Xen-devel] [PATCH] mm: option to _always_ scrub freed domheap pages

2019-05-07 Thread George Dunlap
crubbed when freed > + */ > +static bool_t opt_scrub_domheap = 0; > +boolean_param("scrub_domheap", opt_scrub_domheap); I'm sure Jan will request this to be 'scrub-domheap' instead (not using '_' when you can use '-'). Otherwise this looks go

Re: [Xen-devel] [PATCH] mm: option to _always_ scrub freed domheap pages

2019-05-07 Thread George Dunlap
On 5/7/19 11:03 AM, Jan Beulich wrote: On 07.05.19 at 11:55, wrote: >> On 5/6/19 1:46 PM, Eslam Elnikety wrote: >> [...] >> I'm wondering if this should default to 'true', and people who really >> want the extra performance should turn it off. > > Why would we want to cater for buggy guests

Re: [Xen-devel] [PATCH v2] mm: option to _always_ scrub freed domheap pages

2019-05-07 Thread George Dunlap
On 5/7/19 1:11 PM, Jan Beulich wrote: On 07.05.19 at 13:34, wrote: >> --- a/xen/common/page_alloc.c >> +++ b/xen/common/page_alloc.c >> @@ -214,6 +214,10 @@ custom_param("bootscrub", parse_bootscrub_param); >> static unsigned long __initdata opt_bootscrub_chunk = MB(128); >> size_param("boo

Re: [Xen-devel] Improve build system for offline environments

2019-05-07 Thread George Dunlap
On Fri, May 3, 2019 at 1:55 PM Mathieu Tarral wrote: > > Hi, > > As stated by the documentation: > "_Xen Project downloads various dependencies at build time_" > > This makes Xen a difficult project to work with in an offline environment. There are lots of people who would like to see this change

Re: [Xen-devel] [PATCH] x86/mm: subsume set_gpfn_from_mfn() into guest_physmap_add_entry()

2019-05-07 Thread George Dunlap
On 5/2/19 7:58 AM, Jan Beulich wrote: > This is what both callers of guest_physmap_add_page() in memory.c want > (for the !paging_mode_translate() case), and it is also what both > callers in gnttab_transfer() need (but have been lacking). The other > (x86-specific) callers are all HVM-only, and he

Re: [Xen-devel] [PATCH v2 0/4] x86/HVM: implement memory read caching

2019-05-07 Thread George Dunlap
On 10/18/18 4:20 PM, George Dunlap wrote: > On 10/12/2018 03:19 PM, Jan Beulich wrote: >>>>> On 12.10.18 at 15:55, wrote: >>> On 11/09/18 14:10, Jan Beulich wrote: >>>> Emulation requiring device model assistance uses a form of instruction >>>&

Re: [Xen-devel] [PATCH] Minor security policy text changes to avoid ambiguity

2019-05-07 Thread George Dunlap
On 3/1/19 2:48 PM, Ian Jackson wrote: > Lars Kurth writes ("[PATCH] Minor security policy text changes to avoid > ambiguity"): >> See http://xenbits.xen.org/gitweb/?p=people/larsk/governance.git;a=summary >> for the repository. > > I don't think in fact that there was previously any ambiguity. T

Re: [Xen-devel] [PATCH] trace: fix build with gcc9

2019-05-07 Thread George Dunlap
On 3/8/19 12:14 PM, Jan Beulich wrote: >>>> On 08.03.19 at 12:58, wrote: > >> >>> On Mar 8, 2019, at 7:11 AM, Jan Beulich wrote: >>> >>>>>> George Dunlap 03/07/19 1:02 PM >>> >>>> On 3/7/19 10:34 AM, Jan Beulich wr

Re: [Xen-devel] [PATCH v2 1/2] xen: introduce VCPUOP_register_runstate_phys_memory_area hypercall

2019-05-08 Thread George Dunlap
On 4/23/19 9:10 AM, Andrii Anisov wrote: > From: Andrii Anisov > > The hypercall employs the same vcpu_register_runstate_memory_area > structure for the interface, but requires registered area to not > cross a page boundary. This needs a lot more information. I use the following template when w

Re: [Xen-devel] [PATCH] trace: fix build with gcc9

2019-05-08 Thread George Dunlap
ture where array alignment higher that that of > its elements. > > Reported-by: Martin Liška > Signed-off-by: Jan Beulich OK, you convinced me. Acked-by: George Dunlap At some point we'll probably need a prettier way to do this. -George _

[Xen-devel] [PATCH] MAINTAINERS: Add explicit check-in policy section

2019-05-08 Thread George Dunlap
he meaning of nesting" section title. Signed-off-by: George Dunlap --- CC: Ian Jackson CC: Wei Liu CC: Andrew Cooper CC: Jan Beulich CC: Tim Deegan CC: Konrad Wilk CC: Stefano Stabellini CC: Julien Grall CC: Lars Kurth This is a follow-up to the discussion in `[PATCH for-4.12] pas

Re: [Xen-devel] [PATCH] MAINTAINERS: Add explicit check-in policy section

2019-05-08 Thread George Dunlap
On 5/8/19 12:59 PM, Juergen Gross wrote: > What about variant 2b: > > 1. In order to get a change to a given file committed, it must have > an Ack or Review from at least one maintainer of that file other than > the submitter. > > 2. In the case the submitter is a maintainer of a modified file i

Re: [Xen-devel] [PATCH] x86/mm: subsume set_gpfn_from_mfn() into guest_physmap_add_entry()

2019-05-08 Thread George Dunlap
On 5/8/19 2:57 PM, Jan Beulich wrote: On 07.05.19 at 18:15, wrote: >> On 5/2/19 7:58 AM, Jan Beulich wrote: >>> This is what both callers of guest_physmap_add_page() in memory.c want >>> (for the !paging_mode_translate() case), and it is also what both >>> callers in gnttab_transfer() need (b

Re: [Xen-devel] [PATCH] x86/mm: subsume set_gpfn_from_mfn() into guest_physmap_add_entry()

2019-05-08 Thread George Dunlap
On 5/2/19 7:58 AM, Jan Beulich wrote: > This is what both callers of guest_physmap_add_page() in memory.c want > (for the !paging_mode_translate() case), and it is also what both > callers in gnttab_transfer() need (but have been lacking). The other > (x86-specific) callers are all HVM-only, and he

Re: [Xen-devel] [PATCH] x86/mm: subsume set_gpfn_from_mfn() into guest_physmap_add_entry()

2019-05-08 Thread George Dunlap
On 5/8/19 4:16 PM, Jan Beulich wrote: On 08.05.19 at 17:08, wrote: >> On 5/2/19 7:58 AM, Jan Beulich wrote: >>> --- a/xen/arch/x86/mm/p2m.c >>> +++ b/xen/arch/x86/mm/p2m.c >>> @@ -841,15 +841,19 @@ guest_physmap_add_entry(struct domain *d >>> * any guest-requested type changes succe

Re: [Xen-devel] [PATCH RFC V2 01/45] xen/sched: add inline wrappers for calling per-scheduler functions

2019-05-08 Thread George Dunlap
On 5/6/19 7:56 AM, Juergen Gross wrote: > Instead of using the SCHED_OP() macro to call the different scheduler > specific functions add inline wrappers for that purpose. > > Signed-off-by: Juergen Gross This seems like a great idea. One minor comment... > +static inline int sched_init(struct

Re: [Xen-devel] [PATCH RFC V2 02/45] xen/sched: use new sched_item instead of vcpu in scheduler interfaces

2019-05-08 Thread George Dunlap
On 5/6/19 7:56 AM, Juergen Gross wrote: > In order to prepare core- and socket-scheduling use a new struct > sched_item instead of struct vcpu for interfaces of the different > schedulers. > > Rename the per-scheduler functions insert_vcpu and remove_vcpu to > insert_item and remove_item to reflec

Re: [Xen-devel] [PATCH RFC V2 01/45] xen/sched: add inline wrappers for calling per-scheduler functions

2019-05-09 Thread George Dunlap
On 5/9/19 6:32 AM, Juergen Gross wrote: > On 08/05/2019 18:24, George Dunlap wrote: >> On 5/6/19 7:56 AM, Juergen Gross wrote: >>> Instead of using the SCHED_OP() macro to call the different scheduler >>> specific functions add inline wrappers for that purpose. >>&

Re: [Xen-devel] [PATCH] MAINTAINERS: Add explicit check-in policy section

2019-05-09 Thread George Dunlap
On 5/9/19 12:16 PM, Ian Jackson wrote: > George Dunlap writes ("[PATCH] MAINTAINERS: Add explicit check-in policy > section"): >> +Check-in policy >> +=== >> + >> +In order for a patch to be checked in, in general, several conditions

Re: [Xen-devel] [PATCH] x86/mm: free_page_type() is PV-only

2019-05-13 Thread George Dunlap
e of ASSERTs, thinking about ASSERT vs BUG_ON vs something else here. I guess in this case: 1. PV guests can't be in translate mode 2. If that ever changed, we'd probably trip over the ASSERT() while debugging So I guess ASSERT() is probably fine. Reviewed-by: George Dunlap

Re: [Xen-devel] [PATCH v2 03/12] x86/IRQ: avoid UB (or worse) in trace_irq_mask()

2019-05-13 Thread George Dunlap
2: New. > --- > TBD: I wonder whether the function shouldn't gain an early tb_init_done > check, like many other trace_*() have. Yeah, avoiding these memcopies when tracing is not enabled seems like a good thing. Either way: Acked-by: George Dunlap > > George, de

Re: [Xen-devel] [PATCH 2/3] IOMMU/x86: make page type checks consistent when mapping pages

2019-05-13 Thread George Dunlap
On 3/5/19 1:26 PM, Jan Beulich wrote: > There are currently three more or less different checks: > - _get_page_type() adjusts the IOMMU mappings according to the new type > alone, > - arch_iommu_populate_page_table() wants just the type to be > PGT_writable_page, > - iommu_hwdom_init() addition

Re: [Xen-devel] [PATCH 3/3] memory: restrict XENMEM_remove_from_physmap to translated guests

2019-05-13 Thread George Dunlap
rcall handling, and clarify things in the > public header accordingly. > > Take the liberty and also replace a pointless use of "current" with a > more efficient use of an existing local variable (or function parameter > to be precise). > > Signed-off-by: Jan Beulich L

Re: [Xen-devel] [PATCH 3/4] README: document that `python` is required

2019-05-13 Thread George Dunlap
On 5/13/19 2:47 PM, Wei Liu wrote: > The hypervisor build system requires `python`. To avoid putting too > much (confusing) information in README, mandate availability of > `python`. > > Signed-off-by: Wei Liu > --- > README | 4 > 1 file changed, 4 insertions(+) > > diff --git a/README b/

Re: [Xen-devel] [PATCH 1/4] xen/watchdog: Fold exit paths to have a single unlock

2019-05-13 Thread George Dunlap
On 5/10/19 7:28 PM, Andrew Cooper wrote: > This is mostly to simplify future logical changes, but it does come with a > modest redunction in compiled code size (-55, 345 => 290). > > No functional change. > > Signed-off-by: Andrew Cooper Revie

Re: [Xen-devel] [PATCH v2 1/3] x86/mm: short-circuit HVM-only mode flags when !HVM

2019-05-13 Thread George Dunlap
On 5/9/19 2:42 PM, Jan Beulich wrote: > #define-ing them to zero allows better code generation in this case, > and paves the way for more DCE, allowing to leave certain functions just > declared, but not defined. > > Signed-off-by: Jan Beulich Reviewed-by

Re: [Xen-devel] [PATCH v2 2/3] x86/mm: make guest_physmap_add_entry() HVM-only

2019-05-13 Thread George Dunlap
On 5/9/19 2:44 PM, Jan Beulich wrote: > Lift its !paging_mode_translate() part into guest_physmap_add_page() > (which is what common code calls), eliminating the dummy use of a > (HVM-only really) P2M type in the PV case. > > Suggested-by: George Dunlap > Signed-off-by: Ja

Re: [Xen-devel] [PATCH v2 3/3] x86/mm: subsume set_gpfn_from_mfn() into guest_physmap_add_page()

2019-05-13 Thread George Dunlap
my macro, as there's one > more use in page_alloc.c. > > Signed-off-by: Jan Beulich > Acked-by: Julien Grall > --- > v2: Re-base over added earlier patch. Re-write description. Thanks: Reviewed-by: George Dunlap ___ Xen-devel mailin

Re: [Xen-devel] pygrub not starting first menuentry in Fedora 30

2019-05-14 Thread George Dunlap
On Mon, May 13, 2019 at 11:25 AM Steven Haigh wrote: > > There seems to be some changes in Fedora 30 that cause the second boot > entry in grub.cfg to be booted instead of the first. > > This means that Fedora 30 systems either always boot into an older > kernel, or in the case of systems with onl

Re: [Xen-devel] [PATCH] x86/altp2m: move altp2m_get_effective_entry() under CONFIG_HVM

2019-05-15 Thread George Dunlap
On 5/15/19 7:53 AM, Wei Liu wrote: > On Tue, May 14, 2019 at 07:13:57PM +0300, Razvan Cojocaru wrote: >> All its callers live inside #ifdef CONFIG_HVM sections. >> >> Signed-off-by: Razvan Cojocaru > > Reviewed-by: Wei Li

Re: [Xen-devel] [PATCH v2 1/3] gitignore: ignore .vscode directory

2019-05-15 Thread George Dunlap
On 5/14/19 3:22 PM, Wei Liu wrote: > The directory is created by Visual Studio Code editor to store its > local state. > > Signed-off-by: Wei Liu Acked-by: George Dunlap ___ Xen-devel mailing list Xen-devel@lists.xenproje

Re: [Xen-devel] [PATCH v2 3/3] INSTALL: remove duplicate sentence

2019-05-15 Thread George Dunlap
On 5/14/19 3:22 PM, Wei Liu wrote: > The same sentence is repeated in the next paragraph. > > Signed-off-by: Wei Liu Acked-by: George Dunlap ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/lis

Re: [Xen-devel] [PATCH v2 2/2] autotools: Remove the configure script and just use autoconf

2019-05-20 Thread George Dunlap
On 5/20/19 9:05 AM, Jan Beulich wrote: On 18.05.19 at 00:31, wrote: >> Don't hardcode old versions of configure in the source code, instead >> let's just use autoconf to generate them. >> >> Signed-off-by: Alistair Francis > > For the record - I strongly disagree to this unless there's a ge

Re: [Xen-devel] [PATCH v4 1/2] x86/emulate: Move hvmemul_linear_to_phys

2019-05-22 Thread George Dunlap
>> ; Wei Liu ; Roger Pau Monne >> ; >> rcojoc...@bitdefender.com; ta...@tklengyel.com; George Dunlap >> ; Alexandru >> Stefan ISAILA >> Subject: [PATCH v4 1/2] x86/emulate: Move hvmemul_linear_to_phys >> >> Thiis is done so hvmemul_linear_to_phys() can be

  1   2   3   4   5   6   7   8   9   10   >