Re: [Xenomai-core] [pull request] Fixes and workarounds for the cond issues

2010-03-08 Thread Gilles Chanteperdrix
Charlton, John wrote: I merged some changes from git://git.xenomai.org/xenomai-jki.git for-upstream to my xenomai-2.5.1 release distribution to include the rt_cond_wait and pthread_cond_[timed]wait work arounds. I also merged changes to the mutex_torture.c. Everything builds and most tests seem

[Xenomai-core] [Xenomai-git] common: do not let u_mode exceptional cases leak out of current.[ch]

2010-03-08 Thread Jan Kiszka
xenomai-git-requ...@gna.org wrote: diff --git a/include/asm-generic/bits/current.h b/include/asm-generic/bits/current.h index f0e569c..b9ac680 100644 --- a/include/asm-generic/bits/current.h +++ b/include/asm-generic/bits/current.h ... @@ -33,25 +33,16 @@ static inline xnhandle_t

[Xenomai-core] [Xenomai-git] common: modify leak warning

2010-03-08 Thread Jan Kiszka
xenomai-git-requ...@gna.org wrote: diff --git a/src/skins/common/current.c b/src/skins/common/current.c index 7277189..5d418a4 100644 --- a/src/skins/common/current.c +++ b/src/skins/common/current.c @@ -29,8 +29,6 @@ static inline unsigned long *create_current_mode(void) static inline

Re: [Xenomai-core] [Xenomai-git] common: do not let u_mode exceptional cases leak out of current.[ch]

2010-03-08 Thread Gilles Chanteperdrix
Jan Kiszka wrote: xenomai-git-requ...@gna.org wrote: diff --git a/include/asm-generic/bits/current.h b/include/asm-generic/bits/current.h index f0e569c..b9ac680 100644 --- a/include/asm-generic/bits/current.h +++ b/include/asm-generic/bits/current.h ... @@ -33,25 +33,16 @@ static

Re: [Xenomai-core] u_mode and condvar fixes.

2010-03-08 Thread Jan Kiszka
Gilles Chanteperdrix wrote: Hi, I pushed the changes fixing the u_mode (taken from Jan, slightly modified) and condvar stuff (not entirely taken from Jan's changes), as well as the modifications coming from Philippe's branch. However, two questions remain open: - as in Jan's original

Re: [Xenomai-core] [Xenomai-git] common: modify leak warning

2010-03-08 Thread Gilles Chanteperdrix
Jan Kiszka wrote: xenomai-git-requ...@gna.org wrote: diff --git a/src/skins/common/current.c b/src/skins/common/current.c index 7277189..5d418a4 100644 --- a/src/skins/common/current.c +++ b/src/skins/common/current.c @@ -29,8 +29,6 @@ static inline unsigned long *create_current_mode(void)

Re: [Xenomai-core] [Xenomai-git] common: do not let u_mode exceptional cases leak out of current.[ch]

2010-03-08 Thread Jan Kiszka
Gilles Chanteperdrix wrote: Jan Kiszka wrote: xenomai-git-requ...@gna.org wrote: diff --git a/include/asm-generic/bits/current.h b/include/asm-generic/bits/current.h index f0e569c..b9ac680 100644 --- a/include/asm-generic/bits/current.h +++ b/include/asm-generic/bits/current.h ... @@

Re: [Xenomai-core] [Xenomai-git] common: do not let u_mode exceptional cases leak out of current.[ch]

2010-03-08 Thread Jan Kiszka
Jan Kiszka wrote: Gilles Chanteperdrix wrote: Jan Kiszka wrote: xenomai-git-requ...@gna.org wrote: diff --git a/include/asm-generic/bits/current.h b/include/asm-generic/bits/current.h index f0e569c..b9ac680 100644 --- a/include/asm-generic/bits/current.h +++

Re: [Xenomai-core] [Xenomai-git] common: do not let u_mode exceptional cases leak out of current.[ch]

2010-03-08 Thread Gilles Chanteperdrix
Jan Kiszka wrote: Jan Kiszka wrote: Gilles Chanteperdrix wrote: Jan Kiszka wrote: xenomai-git-requ...@gna.org wrote: diff --git a/include/asm-generic/bits/current.h b/include/asm-generic/bits/current.h index f0e569c..b9ac680 100644 --- a/include/asm-generic/bits/current.h +++

[Xenomai-core] [Xenomai-git] posix: fix pthread_cond_*wait return value overwriting

2010-03-08 Thread Jan Kiszka
xenomai-git-requ...@gna.org wrote: diff --git a/ksrc/skins/posix/syscall.c b/ksrc/skins/posix/syscall.c index 6c3ec3a..2a97a2d 100644 --- a/ksrc/skins/posix/syscall.c +++ b/ksrc/skins/posix/syscall.c @@ -1520,7 +1520,7 @@ static int __pthread_cond_wait_prologue(struct pt_regs *regs)

Re: [Xenomai-core] u_mode and condvar fixes.

2010-03-08 Thread Gilles Chanteperdrix
Jan Kiszka wrote: Gilles Chanteperdrix wrote: Hi, I pushed the changes fixing the u_mode (taken from Jan, slightly modified) and condvar stuff (not entirely taken from Jan's changes), as well as the modifications coming from Philippe's branch. However, two questions remain open: - as in

Re: [Xenomai-core] [Xenomai-git] posix: fix pthread_cond_*wait return value overwriting

2010-03-08 Thread Jan Kiszka
Jan Kiszka wrote: xenomai-git-requ...@gna.org wrote: diff --git a/ksrc/skins/posix/syscall.c b/ksrc/skins/posix/syscall.c index 6c3ec3a..2a97a2d 100644 --- a/ksrc/skins/posix/syscall.c +++ b/ksrc/skins/posix/syscall.c @@ -1520,7 +1520,7 @@ static int __pthread_cond_wait_prologue(struct

Re: [Xenomai-core] u_mode and condvar fixes.

2010-03-08 Thread Jan Kiszka
Gilles Chanteperdrix wrote: Jan Kiszka wrote: Gilles Chanteperdrix wrote: Hi, I pushed the changes fixing the u_mode (taken from Jan, slightly modified) and condvar stuff (not entirely taken from Jan's changes), as well as the modifications coming from Philippe's branch. However, two

Re: [Xenomai-core] [Xenomai-git] posix: fix pthread_cond_*wait return value overwriting

2010-03-08 Thread Gilles Chanteperdrix
Jan Kiszka wrote: xenomai-git-requ...@gna.org wrote: diff --git a/ksrc/skins/posix/syscall.c b/ksrc/skins/posix/syscall.c index 6c3ec3a..2a97a2d 100644 --- a/ksrc/skins/posix/syscall.c +++ b/ksrc/skins/posix/syscall.c @@ -1520,7 +1520,7 @@ static int __pthread_cond_wait_prologue(struct

Re: [Xenomai-core] [Xenomai-git] posix: fix pthread_cond_*wait return value overwriting

2010-03-08 Thread Gilles Chanteperdrix
Jan Kiszka wrote: Gilles Chanteperdrix wrote: Jan Kiszka wrote: xenomai-git-requ...@gna.org wrote: diff --git a/ksrc/skins/posix/syscall.c b/ksrc/skins/posix/syscall.c index 6c3ec3a..2a97a2d 100644 --- a/ksrc/skins/posix/syscall.c +++ b/ksrc/skins/posix/syscall.c @@ -1520,7 +1520,7 @@

Re: [Xenomai-core] [Xenomai-git] common: do not let u_mode exceptional cases leak out of current.[ch]

2010-03-08 Thread Gilles Chanteperdrix
Gilles Chanteperdrix wrote: Jan Kiszka wrote: Jan Kiszka wrote: Gilles Chanteperdrix wrote: Jan Kiszka wrote: xenomai-git-requ...@gna.org wrote: diff --git a/include/asm-generic/bits/current.h b/include/asm-generic/bits/current.h index f0e569c..b9ac680 100644 ---

Re: [Xenomai-core] [pull request] Fixes and workarounds for the cond issues

2010-03-08 Thread Charlton, John
I configured and built with linux-2.6.32.7 and xenomai-jki for-upstream snapshot: f98569c8eec5df605f806ff58e789668720805ee. I noticed that you removed the PTHREAD_WARNSW so I removed the call to pthread_set_mode_np to remove the following errors: PosixThread/PosixThread.cpp:1607: error:

Re: [Xenomai-core] [pull request] Fixes and workarounds for the cond issues

2010-03-08 Thread Charlton, John
Yes with the xenomai-2.5 branch latest as of 1900 UTC everything works without error including the mutex-torture tests (output below): r...@mcs2:/usr/xenomai/bin# ./mutex-torture-native simple_wait recursive_wait timed_mutex mode_switch pi_wait lock_stealing NOTE: lock_stealing mutex_trylock:

Re: [Xenomai-core] [pull request] Fixes and workarounds for the cond issues

2010-03-08 Thread Gilles Chanteperdrix
Charlton, John wrote: Yes with the xenomai-2.5 branch latest as of 1900 UTC everything works without error including the mutex-torture tests (output below): r...@mcs2:/usr/xenomai/bin# ./mutex-torture-native simple_wait recursive_wait timed_mutex mode_switch pi_wait lock_stealing

Re: [Xenomai-core] [pull request] Fixes and workarounds for the cond issues

2010-03-08 Thread Charlton, John
These tests also pass: r...@mcs2:/usr/xenomai/bin# ./cond-torture-native simple_condwait relative_condwait absolute_condwait sig_norestart_condwait sig_restart_condwait sig_norestart_condwait_mutex sig_restart_condwait_mutex sig_norestart_double sig_restart_double cond_destroy_whilewait Test OK