Kenneth Graunke kenn...@whitecape.org writes:
Mesa's implementation of glBindBuffer() checks to see if the supplied
buffer name happens to be already bound. If so, it returns immediately,
skipping the hash table lookup (mapping the GLuint buffer handle to the
actual struct), the associated
Rob Clark robdcl...@gmail.com writes:
On Tue, Dec 30, 2014 at 5:54 PM, Eric Anholt e...@anholt.net wrote:
I've been looking into X performance on VC4 recently. The first
obvious thing happening was that we're hitting some fallbacks in the
driver for things like GL_QUADS, so I thought what
I've been looking into X performance on VC4 recently. The first
obvious thing happening was that we're hitting some fallbacks in the
driver for things like GL_QUADS, so I thought what if I use the GLES2
paths instead? Turns out the GLES2 paths are thoroughly broken now.
I wrote two quick patches
as the caller caching it would be.
Signed-off-by: Eric Anholt e...@anholt.net
---
In some of these cases, we've now got gotos to just a return FALSE in
the error case. Do we want to just dump the gotos in this patch? Or
leave them in for consistency and in case we end up adding some sort
of other
It's not available in GLES2 (though it's in GLES3). It's trivial to
do the math, and avoids going through more switch statements in the GL
on desktop.
Signed-off-by: Eric Anholt e...@anholt.net
---
glamor/glamor_transfer.c | 17 ++---
1 file changed, 6 insertions(+), 11 deletions
Kenneth Graunke kenn...@whitecape.org writes:
present.c: In function 'ms_present_flush':
present.c:204:9: error: implicit declaration of function
'glamor_block_handler'
Reviewed-by: Eric Anholt e...@anholt.net
signature.asc
Description: PGP signature
Keith Packard kei...@keithp.com writes:
Eric Anholt e...@anholt.net writes:
--- a/glamor/glamor_xv.c
+++ b/glamor/glamor_xv.c
@@ -435,7 +435,7 @@ glamor_xv_put_image(glamor_port_private *port_priv,
}
top = (src_y) ~1;
-nlines = (src_y + height) - top;
+nlines
Keith Packard kei...@keithp.com writes:
Eric Anholt e...@anholt.net writes:
--- a/glamor/glamor_xv.c
+++ b/glamor/glamor_xv.c
@@ -435,7 +435,7 @@ glamor_xv_put_image(glamor_port_private *port_priv,
}
top = (src_y) ~1;
-nlines = (src_y + height) - top;
+nlines
Keith Packard kei...@keithp.com writes:
Kertesz Laszlo laszlo.kert...@gmail.com writes:
Ok, rebuilt the xserver package with debugging symbols (seems that
checkinstall strips stuff by default). I got a bigger gdb.txt. See if it
helps.
I found a bug -- glamor_xv_put_image was mis-computing
Keith Packard kei...@keithp.com writes:
Adam Jackson a...@nwnk.net writes:
Adam Jackson (2):
glx: Dynamically compute attribute slot in GetDrawableAttributes
glx: Add hack for GLX-1.2-style naked windows to GetDrawableAttributes
This one is a bug fix, but the other two look
this code a lot nicer to read, but
it's still better than hand-written constants.
These two patches are:
Reviewed-by: Eric Anholt e...@anholt.net
signature.asc
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http
mich...@redhat.com
Reviewed-by: Eric Anholt e...@anholt.net
signature.asc
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
-sync_flip,
valid, x_off, y_off))
{
Seem reasonable? If you wanted to squash this in, then this is:
Reviewed-by: Eric Anholt e...@anholt.net
(So's patch 1/2, regardless).
signature.asc
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org
to be pimped.
I don't know about the output hotplug stuff, so I skipped reviewing
that. Patches 1-5 are:
Reviewed-by: Eric Anholt e...@anholt.net
I think the repeated create_textured_screen_ext()s are leaking an EGL
image, but that's a fix in glamor_egl.c we should do independently
: Reviewed-by: Keith Packard kei...@keithp.com
With X_INFO,
Reviewed-by: Eric Anholt e...@anholt.net
pgp5eco4yj70a.pgp
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http
to cac4b064f9f66435430f61568c6a516c54bf3c40:
modesetting: Add support for DRI2 with glamor. (2014-10-27 13:16:43 -0700)
Eric Anholt (
dri2: Import a copy of Mesa's PCI ID - driver name mappings.
dri2: Automatically fill
This renames dumb_get_bo_from_handle(), since it wasn't using a handle
(GEM terminology) but a dmabuf fd.
Signed-off-by: Eric Anholt e...@anholt.net
---
hw/xfree86/drivers/modesetting/drmmode_display.c | 8
hw/xfree86/drivers/modesetting/drmmode_display.h | 3 +++
2 files changed, 7
Alex Deucher alexdeuc...@gmail.com writes:
On Fri, Oct 17, 2014 at 12:08 PM, Eric Anholt e...@anholt.net wrote:
Adam Jackson a...@nwnk.net writes:
On Fri, 2014-10-10 at 11:09 +0200, Eric Anholt wrote:
+CHIPSET(0xA011, IGD_GM, Intel(R) IGD)
+CHIPSET(0xA001, IGD_G,Intel(R) IGD)
Can
Adam Jackson a...@nwnk.net writes:
On Fri, 2014-10-10 at 11:09 +0200, Eric Anholt wrote:
+CHIPSET(0xA011, IGD_GM, Intel(R) IGD)
+CHIPSET(0xA001, IGD_G,Intel(R) IGD)
Can we not? Pineview, right? Or Atom D4xx/D5xx/N4xx/N5xx, or
whatever, but IGD is worse than useless.
+CHIPSET
(not that the normal 2D driver is stable with pageflipping for
me), and I won't get it fixed before the merge window. It now
passes all of the OML_sync_control tests from Jamey and Theo
(except for occasional warns in timing -fullscreen -divisor 2).
Signed-off-by: Eric Anholt e
William ML Leslie william.leslie@gmail.com writes:
This patch makes it possible to use C-S key combinations
within Xephyr without losing access to the host window manager's
commands.
Reviewed-by: Eric Anholt e...@anholt.net
pgpaBuaCz4BPX.pgp
Description: PGP signature
Mark Marshall markmarshal...@gmail.com writes:
Just a minor thing
On 10 October 2014 11:09, Eric Anholt e...@anholt.net wrote:
This will be used by the modesetting driver to support DRI2 across all
hardware that can support glamor, and could potentially be used by
other drivers that have
,
except for the lack of nouveau_vieux support (which requires a
predicate on the device).
Signed-off-by: Eric Anholt e...@anholt.net
---
hw/xfree86/dri2/dri2.c | 61 ++
1 file changed, 61 insertions(+)
diff --git a/hw/xfree86/dri2/dri2.c b/hw/xfree86
-rendering that require presence in GLX (which aren't supported
in glxdriswrast.c).
Signed-off-by: Eric Anholt e...@anholt.net
---
hw/xfree86/drivers/modesetting/Makefile.am |6 +-
hw/xfree86/drivers/modesetting/dri2.c| 1122 ++
hw/xfree86/drivers/modesetting
. (Some
day, when AIGLX transitions to EGL, we can drop the DRI2 filename
setup entirely).
Signed-off-by: Eric Anholt e...@anholt.net
---
hw/xfree86/dri2/pci_ids/i810_pci_ids.h | 4 +
hw/xfree86/dri2/pci_ids/i915_pci_ids.h | 15 ++
hw/xfree86/dri2/pci_ids/i965_pci_ids.h | 115
Eric Anholt e...@anholt.net writes:
This comes from Mesa commit acdcef6788beaa2a1532e13ff84c3e246b8025ed
I forgot to mention, this series is on the modesetting-dri2 branch of my
tree. I've done minor cleanups on 4/4 as I started looking into Present.
pgpi3bhmRt3Jz.pgp
Description: PGP
Signed-off-by: Eric Anholt e...@anholt.net
---
hw/xfree86/drivers/modesetting/drmmode_display.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/hw/xfree86/drivers/modesetting/drmmode_display.c
b/hw/xfree86/drivers/modesetting/drmmode_display.c
index ca02a4d..d959837
By default modesetting now tries to enable X acceleration using
glamor, but falls back to normal shadowfb if GL fails to initialize.
Signed-off-by: Eric Anholt e...@anholt.net
---
hw/xfree86/drivers/modesetting/Makefile.am | 1 +
hw/xfree86/drivers/modesetting/driver.c| 101
Signed-off-by: Eric Anholt e...@anholt.net
---
hw/xfree86/drivers/modesetting/driver.c | 55 +
1 file changed, 22 insertions(+), 33 deletions(-)
diff --git a/hw/xfree86/drivers/modesetting/driver.c
b/hw/xfree86/drivers/modesetting/driver.c
index f509a19..c713746
As I was editing code, the top-level .dir-locals.el was making my new
stuff conflict with the existing style. Make it consistently use the
xorg style, instead.
Signed-off-by: Eric Anholt e...@anholt.net
---
hw/xfree86/drivers/modesetting/driver.c | 579 ++---
hw/xfree86/drivers
Daniel Martin consume.no...@gmail.com writes:
All references to modinit.h have been remove with:
a1d41e3 Move extension initialisation prototypes into extinit.h
Signed-off-by: Daniel Martin consume.no...@gmail.com
Reviewed-by: Eric Anholt e...@anholt.net
pgpby1o6A9iXE.pgp
Description
-by: Eric Anholt e...@anholt.net
pgpzIWcuXJomm.pgp
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
Adam Jackson a...@redhat.com writes:
Nice, but not something our Windows servers build, and not something
that belongs in mi anyway.
Signed-off-by: Adam Jackson a...@redhat.com
Reviewed-by: Eric Anholt e...@anholt.net
pgpWCyQiIDjh_.pgp
Description: PGP signature
Adam Jackson a...@redhat.com writes:
Nothing's using it.
Reviewed-by: Eric Anholt e...@anholt.net
pgpV7slCH8rim.pgp
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http
Adam Jackson a...@redhat.com writes:
No modern driver pays attention to this. Presumably there existed
hardware once where you couldn't just read the right values out of the
CRTC.
Reviewed-by: Eric Anholt e...@anholt.net
pgpNUpue8mlHq.pgp
Description: PGP signature
(\nConfig Error:\n);
-va_start(ap, msg);
-VErrorF(msg, ap);
-va_end(ap);
-ErrorF(\n);
-return;
-}
Yeah, doesn't seem useful, really.
(also, the return; as the last statement is just the best)
Reviewed-by: Eric Anholt e...@anholt.net
pgpHykxJBKd1a.pgp
Description: PGP
Adam Jackson a...@redhat.com writes:
Signed-off-by: Adam Jackson a...@redhat.com
---
hw/xfree86/common/xf86cmap.c | 46
+++-
1 file changed, 20 insertions(+), 26 deletions(-)
Looks nicer to me.
Reviewed-by: Eric Anholt e...@anholt.net
Adam Jackson a...@redhat.com writes:
Not actually wired up so it's fairly useless.
Reviewed-by: Eric Anholt e...@anholt.net
pgpyp44Uj2jSa.pgp
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org
Adam Jackson a...@redhat.com writes:
SUBCLASS ALL THE THINGS
Isn't the Log enum dead now?
Other than that,
Reviewed-by: Eric Anholt e...@anholt.net
pgp4QRTLe7D2i.pgp
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives
Adam Jackson a...@redhat.com writes:
Signed-off-by: Adam Jackson a...@redhat.com
Reviewed-by: Eric Anholt e...@anholt.net
pgpNeLTmeBy5p.pgp
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org
Adam Jackson a...@redhat.com writes:
Signed-off-by: Adam Jackson a...@redhat.com
Patches 16, 17, and 19 are also:
Reviewed-by: Eric Anholt e...@anholt.net
pgpwWyi_3X7og.pgp
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Reviewed-by: Eric Anholt e...@anholt.net
pgpmY55z0hNnW.pgp
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
...
Reviewed-by: Eric Anholt e...@anholt.net
pgpL3b41X5ymY.pgp
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
after free.
modesetting: fix build regression against older servers.
Eric Anholt (9):
Merge branch 'modesetting-import' into master
modesetting: Merge modesetting's COPYING into the xserver's.
modesetting: unifdef MODESETTING_OUTPUT_SLAVE_SUPPORT
modesetting: xserver
From: Jon TURNEY jon.tur...@dronecode.org.uk
This should have been part of d0da0e9c3bb8fe0cd4879ecb24d21715bfaa209b
Signed-off-by: Jon TURNEY jon.tur...@dronecode.org.uk
Signed-off-by: Eric Anholt e...@anholt.net
Reviewed-by: Eric Anholt e...@anholt.net
---
os/utils.c | 4 ++--
1 file changed
v2: Fix libdrm version check, and use XORG_VERSION_* instead of a
static 1.0.0 version for the driver module.
Signed-off-by: Eric Anholt e...@anholt.net
---
Thanks for the review! I've added my s-o-bs (oops), and added your
review to the rest of the patches. modesetting-import branch
GLX_BufferSwapComplete events and crashes in clutter.
Reviewed-by: Eric Anholt e...@anholt.net
pgpgYegXXYAJU.pgp
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman
+iglx on the command line).
Signed-off-by: Eric Anholt e...@anholt.net
---
I kept saying I as going to send out this patch, and since I just
crashed my server a few times from trying to run Xephyr -glamor with a
broken driver, it's probably time.
os/utils.c | 2 +-
1 file changed, 1 insertion
Keith Packard kei...@keithp.com writes:
Eric Anholt e...@anholt.net writes:
So there's a bunch of disagreement between this new code and existing
practice about whitespace, and still misc unrelated whitespace changes
sprinkled into the remaining patches. That makes me grumpy when
reviewing
it's big:
commit 35dc7c75150733dbcef8a18b6796f49a7c48ebee
Merge: 3a51418 5f3485b
Author: Eric Anholt e...@anholt.net
Date: Mon Aug 25 15:52:58 2014 -0700
Merge branch 'modesetting-import' into master
This reintroduces a hardware driver to the xfree86 directory.
Unlike the drivers
---
hw/xfree86/drivers/modesetting/drmmode_display.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/hw/xfree86/drivers/modesetting/drmmode_display.c
b/hw/xfree86/drivers/modesetting/drmmode_display.c
index 6964e93..31c39a2 100644
--- a/hw/xfree86/drivers/modesetting/drmmode_display.c
---
hw/xfree86/drivers/modesetting/driver.c | 6 ++
hw/xfree86/drivers/modesetting/drmmode_display.c | 15 +--
hw/xfree86/drivers/modesetting/drmmode_display.h | 6 --
3 files changed, 3 insertions(+), 24 deletions(-)
diff --git
---
configure.ac | 10 +
hw/xfree86/Makefile.am | 2 +-
hw/xfree86/drivers/Makefile.am | 5 +
hw/xfree86/drivers/modesetting/Makefile.am | 27 ++--
---
COPYING| 24 +++
hw/xfree86/drivers/modesetting/COPYING | 44 --
2 files changed, 24 insertions(+), 44 deletions(-)
delete mode 100644 hw/xfree86/drivers/modesetting/COPYING
diff --git a/COPYING b/COPYING
index
The server will always have it.
---
hw/xfree86/drivers/modesetting/driver.c | 12
hw/xfree86/drivers/modesetting/drmmode_display.c | 17 +
hw/xfree86/drivers/modesetting/drmmode_display.h | 7 ---
3 files changed, 1 insertion(+), 35 deletions(-)
diff
---
hw/xfree86/drivers/modesetting/Makefile.am | 1 -
hw/xfree86/drivers/modesetting/compat-api.h | 94
hw/xfree86/drivers/modesetting/driver.c | 50 ++---
hw/xfree86/drivers/modesetting/drmmode_display.c | 1 -
4 files changed, 21
The xserver doesn't have that typedef.
---
hw/xfree86/drivers/modesetting/compat-api.h | 4 ++--
hw/xfree86/drivers/modesetting/driver.c | 6 +++---
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/hw/xfree86/drivers/modesetting/compat-api.h
---
hw/xfree86/drivers/modesetting/driver.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/xfree86/drivers/modesetting/driver.c
b/hw/xfree86/drivers/modesetting/driver.c
index bf5a9a4..9384f88 100644
--- a/hw/xfree86/drivers/modesetting/driver.c
+++
Keith Packard kei...@keithp.com writes:
Declare a constant string 'const', clean up some indentation whitespace
I'm confused about these whitespace fixes -- the lines surrounding those
two are also tabs.
pgptDagCNSkq3.pgp
Description: PGP signature
Keith Packard kei...@keithp.com writes:
Wait until the root window has been painted for the first time before
doing the modeset. This avoids flashing black while the root window
gets set up.
Signed-off-by: Keith Packard kei...@keithp.com
---
src/uxa/intel.h | 2 ++
, but I don't actually care to block things due to that. This
driver is enough of a disaster already that whitespace inconsistency
isn't its main problem.
Patches 1-3, 5-6, 8, 12-15 are:
Reviewed-by: Eric Anholt e...@anholt.net
16-18: I'm still looking at them.
pgpq5xGBPwgTJ.pgp
Description
Maks Naumov maksq...@ukr.net writes:
Signed-off-by: Maks Naumov maksq...@ukr.net
Reviewed-by: Eric Anholt e...@anholt.net
pgpC0wqlLs2Ls.pgp
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org
visible performance impact.
Signed-off-by: Keith Packard kei...@keithp.com
Reviewed-by: Eric Anholt e...@anholt.net
pgpdOF3gDKYJ_.pgp
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg
Michel Dänzer mic...@daenzer.net writes:
From: Michel Dänzer michel.daen...@amd.com
It results in a crash.
Signed-off-by: Michel Dänzer michel.daen...@amd.com
We really need to figure out how to make GLAMOR_DRM_ONLY go away.
Reviewed-by: Eric Anholt e...@anholt.net
pgp07AyI2W2b9.pgp
This happens to avoid GL errors on hardware without
EXT_texture_integer (which implies GLSL 130, and thus glamor_text.c
programs not compiling anyway).
Signed-off-by: Eric Anholt e...@anholt.net
---
With this, glamor on simulated RPi gets to the point of showing my
xterm on my gray background
to 3714f5401690b288045090c4bcd9cb01c6e4860e:
kdrive: Remove a dead struct. (2014-08-07 12:39:53 -0700)
Eric Anholt (15):
xv: Remove dead VIDEO_INVERT_CLIPLIST from the xorg and kdrive DDXes.
xv: Remove dead
unnecessary use of GLAMOR_ACCESS_WO, thanks Eric for pointing
that out. Disregard the GLAMOR_ACCESS_WO patch for now.
Nice. We may end up pulling the other patch some day, but it seemed
separate from what this one needed.
Reviewed-by: Eric Anholt e...@anholt.net
(My guess is keithp will pull
Peter Hutterer peter.hutte...@who-t.net writes:
We had reports that the top software button area is hard to hit for those
using the trackpoint and clicking the buttons with their thumb.
Analysis of event recordings (3 different people) for left, right and middle
clicks shows that there is a
Keith Packard kei...@keithp.com writes:
The shader-based trapezoid drawing code in glamor draws incorrectly
and doesn't appear to offer any performance benefits. This series
fixes a couple of compiler warning problems and then disables the
shader based trapezoid code.
This fixes the bottom
Michel Dänzer mic...@daenzer.net writes:
From: Michel Dänzer michel.daen...@amd.com
This provides a speedup e.g. when the destination is an SHM pixmap.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=76285
Signed-off-by: Michel Dänzer michel.daen...@amd.com
+
Keith Packard kei...@keithp.com writes:
Eric Anholt e...@anholt.net writes:
This change appears to be unrelated, and possibly harmful (if X has
dropped the last ref to the BO, but it's still the scanout buffer, a new
allocation would now reuse the BO and scribble on scanout until the next
Keith Packard kei...@keithp.com writes:
Eric Anholt e...@anholt.net writes:
Keith Packard kei...@keithp.com writes:
I don't see anything indicating that this code path is only used by
glamor.
True. It's a fix for DRI3 for either UXA or none. Mesa allocates a
single page for a 1x1 texture
Keith Packard kei...@keithp.com writes:
Don't try to destroy rotation_damage in the xf86RotateCloseScreen; it
will have been destroyed when the screen pixmap was destroyed.
This series is:
Reviewed-by: Eric Anholt e...@anholt.net
pgpT9MLZTtTDC.pgp
Description: PGP signature
Adam Jackson a...@redhat.com writes:
Since the sparse stuff is gone none of these variables get used for
anything, they're just dead side-effect-less execution.
Patches 1-8 are:
Reviewed-by: Eric Anholt e...@anholt.net
It sounds like #9 could work around OpenBSD being weird by just deleting
Keith Packard kei...@keithp.com writes:
I don't see anything indicating that this code path is only used by
glamor.
---
src/uxa/intel_uxa.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/uxa/intel_uxa.c b/src/uxa/intel_uxa.c
index b396188..717754f 100644
---
Keith Packard kei...@keithp.com writes:
GetScratchPixmapHeader should only be used for local memory pixmaps,
as used by PutImage and friends. That's because when you free the
scratch pixmap header, it doesn't actually free the pixmap; instead,
it gets stuffed in pScreen-pScratchPixmap and any
Keith Packard kei...@keithp.com writes:
Makes UXA no longer include calls to glamor acceleration functions.
Signed-off-by: Keith Packard kei...@keithp.com
---
src/uxa/Makefile.am| 9 --
src/uxa/intel_dri.c| 60 +
src/uxa/intel_driver.c | 1 -
src/uxa/intel_uxa.c
as long as it still calls
intel_glamor_flush(). If it did, it gets:
Reviewed-by: Eric Anholt e...@anholt.net
even before we sort out the rest of the series.
pgpsmzwOsTzDK.pgp
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Keith Packard kei...@keithp.com writes:
This eliminates the stubs in intel_glamor.h and replaces them with
ifdefs instead.
I don't feel strongly about this either way -- ifdefs are more
traditional userland style, while stubs are more kernel style.
Acked-by: Eric Anholt e...@anholt.net
Keith Packard kei...@keithp.com writes:
Make sure the pitch and tiling are correct.
Make sure there's a BO we can get at.
I thought we couldn't change these parameters, but now I can't find what
prevents them from changing. Can you cite sources?
pgp_XyaN_u7LY.pgp
Description: PGP signature
Keith Packard kei...@keithp.com writes:
This adds glamor support back into the driver, but instad of going
through UXA, this uses it directly instead.
This is hard to read with the conditionalizing all of the UXA code in
the same commit as adding the glamor code. Then there are a bunch of
Keith Packard kei...@keithp.com writes:
I spent the day just cleaning up this patch series and testing. I
think it's ready for others to use and review. I've been running it on
two machines for a couple of days now and it's been solid.
Patches 2, 4 are:
Reviewed-by: Eric Anholt e
Chris Wilson ch...@chris-wilson.co.uk writes:
On Fri, Jul 18, 2014 at 10:32:31AM -0700, Eric Anholt wrote:
Nobody was using it.
The ClientPtr gets used to send events back to the Client from various
implementations of Xv.
I've modified the in-tree code, which didn't use it, so I'd like
Keith Packard kei...@keithp.com writes:
Eric Anholt e...@anholt.net writes:
It was never used, and it meant a bunch of pointless frobbing of
structure members between the DDX and DIX.
This will generate warnings when initializing the (char *) name field
From a constant string.
One option
Robert Ancell robert.anc...@canonical.com writes:
Fix errors in SwapBuffers:
- The section in 8. Extension Requests was missing the target_msc, divisor
and remainder fields
- The section in A.2 Protocol Requests had two entries for SwapBuffers,
both incorrect
Reviewed-by: Eric Anholt e
Keith Packard kei...@keithp.com writes:
Eric Anholt e...@anholt.net writes:
Color key overlay implementations want to reuse this code, and XF86's
had bugs.
It might be helpful to describe which bugs were in the xf86 code so that
these two implementations could be compared.
Just the ones
Color key overlay implementations want to reuse this code, and XF86's
had bugs.
Signed-off-by: Eric Anholt e...@anholt.net
---
Xext/xvdix.h | 2 ++
Xext/xvmain.c | 31 +++
hw/xfree86/common/xf86xv.c | 25 +
3 files
Privates are initially cleared to zero by dixInitPrivates().
Signed-off-by: Eric Anholt e...@anholt.net
---
hw/kdrive/src/kxv.c | 21 -
hw/kdrive/src/kxv.h | 1 -
2 files changed, 22 deletions(-)
diff --git a/hw/kdrive/src/kxv.c b/hw/kdrive/src/kxv.c
index c916af4..0b4335a
It was never used, and it meant a bunch of pointless frobbing of
structure members between the DDX and DIX.
Signed-off-by: Eric Anholt e...@anholt.net
---
Xext/xvdix.h | 1 -
hw/kdrive/ephyr/ephyr_glamor_xv.c | 2 +-
hw/kdrive/ephyr/ephyrvideo.c | 2 +-
hw/kdrive/src
The core was passing pointers to pxvs's nAdaptors and pAdaptors, and
the two hardware implementations were copying pxvs's nAdaptors and
pAdaptors into those pointers.
Signed-off-by: Eric Anholt e...@anholt.net
---
Xext/xvdisp.c | 2 --
Xext/xvdix.h | 1 -
hw/kdrive
It's never been used in the history of the tree.
Signed-off-by: Eric Anholt e...@anholt.net
---
hw/kdrive/src/kxv.h | 9 -
1 file changed, 9 deletions(-)
diff --git a/hw/kdrive/src/kxv.h b/hw/kdrive/src/kxv.h
index 4eb4054..b997299 100644
--- a/hw/kdrive/src/kxv.h
+++ b/hw/kdrive/src
Here's a pile of stuff I wrote when I was working on Xephyr XV with
glamor. I wanted glamor to be able to create adaptors on its own
without needing cooperation from the DDX, and I didn't want to build a
third copy of DDX XV, so I was trying to clean up and share common
code. I eventually backed
As far as I can see, nothing has ever used this flag except possibly
the i.mx6 xorg ddx debug during bringup.
Signed-off-by: Eric Anholt e...@anholt.net
---
hw/kdrive/src/kxv.c | 46
hw/kdrive/src/kxv.h | 1 -
hw/xfree86/common
Signed-off-by: Eric Anholt e...@anholt.net
---
Xext/xvdix.h | 1 -
Xext/xvmain.c | 24
2 files changed, 25 deletions(-)
diff --git a/Xext/xvdix.h b/Xext/xvdix.h
index ddd8abb..b61659c 100644
--- a/Xext/xvdix.h
+++ b/Xext/xvdix.h
@@ -235,7 +235,6 @@ extern _X_EXPORT
Nobody was using it.
Signed-off-by: Eric Anholt e...@anholt.net
---
Xext/xvdisp.c | 8 +++-
Xext/xvdix.h | 20 +--
Xext/xvmain.c | 20 +--
hw/kdrive/src/kxv.c| 49
Since any DDX XV screen cleanup would need this same code for freeing
the tree of pointers for xv adaptors, move it to the dix.
Signed-off-by: Eric Anholt e...@anholt.net
---
Xext/xvdix.h | 1 +
Xext/xvmain.c | 41 +
hw/kdrive
It's been unused since mach64 was deleted, and now there's a helper in
core XV.
Signed-off-by: Eric Anholt e...@anholt.net
---
hw/kdrive/src/kxv.c | 41 -
hw/kdrive/src/kxv.h | 3 ---
2 files changed, 44 deletions(-)
diff --git a/hw/kdrive/src/kxv.c b/hw
As far as I can see (looking at trees on my disk, plus googling for
the term), nothing has ever used this flag
Signed-off-by: Eric Anholt e...@anholt.net
---
hw/kdrive/src/kxv.c | 24
hw/kdrive/src/kxv.h | 1 -
hw/xfree86/common/xf86xv.c | 24
Signed-off-by: Eric Anholt e...@anholt.net
---
Xext/xvdisp.c | 88 ++
Xext/xvdix.h | 3 --
Xext/xvmain.c | 2 +-
hw/kdrive/src/kxv.c| 17 -
hw/xfree86/common/xf86xv.c | 17 -
5 files
Signed-off-by: Eric Anholt e...@anholt.net
---
Xext/xvmain.c | 22 +-
1 file changed, 13 insertions(+), 9 deletions(-)
diff --git a/Xext/xvmain.c b/Xext/xvmain.c
index a3fb711..d84708b 100644
--- a/Xext/xvmain.c
+++ b/Xext/xvmain.c
@@ -1096,22 +1096,26 @@ XvFillColorKey
601 - 700 of 1094 matches
Mail list logo
