Re: [PATCH 0/4 v3] Use static buffers to log from driver signal handlers

2011-08-05 Thread Mark Kettenis
From: Daniel Kurtz Date: Fri, 5 Aug 2011 15:09:57 +0800 For Version 3: * 0001: Make cleaner and faster per Guillem Jover review comments. * 0002: Make slightly faster and fix some comments. Back in the bad old days, using xf86Msg() from a signal handler was a big no-no, as it would

Re: [PATCH:xset 3/3] Remove direct call to Solaris nanosleep system call

2011-07-23 Thread Mark Kettenis
-To: mark.kette...@xs4all.nl Attempted to workaround nanosleep() being only in POSIX realtime extensions library, but both usleep() nanosleep() are in libc now, so not useful anymore, nor was it ever officially supported. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com Reviewed-by: Mark

Re: [PATCH xdm] Support installing systemd unit file.

2011-06-15 Thread Mark Kettenis
From: =?UTF-8?q?Micha=C5=82=20G=C3=B3rny?= mgo...@gentoo.org Date: Wed, 15 Jun 2011 13:59:43 +0200 Signed-off-by: Michał Górny mgo...@gentoo.org Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=38339 Makefile.am | 10 ++ configure.ac| 12

Re: [PATCH:xwininfo] When matching window names, ensure name lengths match too

2011-06-08 Thread Mark Kettenis
From: Alan Coopersmith alan.coopersm...@oracle.com Date: Tue, 7 Jun 2011 23:13:46 -0700 Prevents strncmp returning on partial matches when one is shorter. https://bugs.freedesktop.org/show_bug.cgi?id=37710 Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com Reviewed-by: Mark

Re: [PATCH:xkbcomp] Replace repeated checks for gcc with _X_ATTRIBUTE_PRINTF from xproto

2011-06-08 Thread Mark Kettenis
From: Alan Coopersmith alan.coopersm...@oracle.com Date: Tue, 7 Jun 2011 23:55:25 -0700 Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com Strangely formatted code, but that's not your fault. Reviewed-by: Mark Kettenis kette...@openbsd.org utils.h | 63

Re: [PATCH:ico] Replace local checks for gcc with _X_NORETURN from xproto 7.0.17

2011-06-08 Thread Mark Kettenis
From: Alan Coopersmith alan.coopersm...@oracle.com Date: Wed, 8 Jun 2011 00:04:34 -0700 Also declare icoFatal as static since it's only used in this one file. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com Reviewed-by: Mark Kettenis kette...@openbsd.org --- configure.ac

Re: [PATCH] xf86AutoConfig: Try newport on mips.

2011-06-03 Thread Mark Kettenis
Date: Fri, 3 Jun 2011 17:42:45 +0200 From: Cyril Brulebois k...@debian.org Hi Mark. Cyril Brulebois k...@debian.org (27/02/2011): Mark Kettenis mark.kette...@xs4all.nl (27/02/2011): Not necessary a good idea. The autoconfig code was broken some time ago by a all-the-world-is-PCI

Re: macros: Changes to 'master'

2011-06-01 Thread Mark Kettenis
From: Gaetan Nadon mems...@videotron.ca Date: Wed, 01 Jun 2011 07:42:32 -0400 AC_LANG_DEFINES_PROVIDED seems to be only in newer, GPLv3, versions of au= toconf ... is there a way around this? I looked at it yesterday, using AC_LANG_SOURCE should be the right thing to do (some examples

Re: macros: Changes to 'master'

2011-06-01 Thread Mark Kettenis
Date: Wed, 1 Jun 2011 06:29:13 -0700 From: Dan Nicholson dbn.li...@gmail.com From: Gaetan Nadon mems...@videotron.ca Date: Wed, 01 Jun 2011 07:42:32 -0400 AC_LANG_DEFINES_PROVIDED seems to be only in newer, GPLv3, versions of au= toconf ... is there a way around this? I

Re: [PATCH xrandr 1/3] po4a: handle translated xrandr(1) manpage #37612

2011-05-28 Thread Mark Kettenis
___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xrandr 1/3] po4a: handle translated xrandr(1) manpage #37612

2011-05-28 Thread Mark Kettenis
Oops, sorry about that empty message. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] test: only test for double alignment on 64 bit. (#36986)

2011-05-19 Thread Mark Kettenis
Date: Thu, 19 May 2011 14:54:28 +1000 From: Peter Hutterer peter.hutte...@who-t.net X.Org Bug 36986 http://bugs.freedesktop.org/show_bug.cgi?id=36986 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- On Wed, May 18, 2011 at 12:45:05AM -0700, Keith Packard wrote: On Wed, 18

Re: [PATCH] input: Fix format string for verify_internal_event

2011-05-16 Thread Mark Kettenis
On Sat, May 14, 2011 at 04:31:10PM -0700, Jeremy Huddleston wrote: inpututils.c:577:25: warning: conversion specifies type 'unsigned short' but the argument has type 'unsigned char' [-Wformat,Format String Issue] ErrorF(%02hx , *data); ^~

Re: [PATCH:xdm 3/5] Stop casting free() arguments to (char *)

2011-05-14 Thread Mark Kettenis
with this ;). Reviewed-by: Mark Kettenis kette...@openbsd.org chooser/chooser.c | 12 ++-- xdm/access.c | 18 +- xdm/auth.c| 14 +++--- xdm/choose.c | 12 ++-- xdm/dpylist.c |8 xdm/file.c|4

Re: [PATCH:xdm 4/5] Stop casting return values of malloc and friends

2011-05-14 Thread Mark Kettenis
-by: Alan Coopersmith alan.coopersm...@oracle.com Reviewed-by: Mark Kettenis kette...@openbsd.org --- chooser/chooser.c |8 xdm/access.c |4 ++-- xdm/auth.c|7 +++ xdm/choose.c |4 ++-- xdm/dpylist.c |2 +- xdm/file.c|7

Re: [PATCH:xdm 2/5] Stop checking for NULL before calling free()

2011-05-14 Thread Mark Kettenis
From: Alan Coopersmith alan.coopersm...@oracle.com Date: Sat, 14 May 2011 11:01:30 -0700 Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com Reviewed-by: Mark Kettenis kette...@openbsd.org --- chooser/chooser.c |3 +-- xdm/access.c | 15 +-- xdm/auth.c

Re: [PATCH libpciaccess 1/2] Add map_legacy interface

2011-05-11 Thread Mark Kettenis
From: Adam Jackson a...@redhat.com Date: Tue, 10 May 2011 17:56:34 -0400 This allows platforms to hand back mmaps of the low 1M (ISA) address space on a per-domain basis. Any reason why you chose to have an explicit write_enable flag instead of using the standard map_flags used in the

Re: [PATCH:twm] Remove unused fallback implementation of putenv()

2011-05-10 Thread Mark Kettenis
. That should mean that everything that's even remotely UNIX these days should have it. Reviewed-by: Mark Kettenis kette...@openbsd.org Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- src/util.c | 66 1 files changed, 0

Re: [PATCH] dix: silence compiler warning

2011-04-18 Thread Mark Kettenis
Date: Mon, 18 Apr 2011 15:55:42 +1000 From: Peter Hutterer peter.hutte...@who-t.net resource.c: In function 'AddResource': resource.c:493:3: warning: format '%lx' expects type 'long unsigned int', but argument 3 has type 'RESTYPE' RESTYPE is uint32_t, not long. Well, uint32_t isn't a

Re: [PATCH sis v2 04/15] Fix suggest parentheses around operand of ‘!’ compiler warnings.

2011-04-08 Thread Mark Kettenis
parens instead of outside them. But they are consistent with the style used elsewhere in this driver. I agree on the patch description update though. Reviewed-by: Mark Kettenis kette...@openbsd.org ___ xorg-devel@lists.x.org: X.Org development Archives: http

Re: [PATCH sis 04/15] Fix suggest parentheses around operand of ‘!’ compiler warnings.

2011-04-06 Thread Mark Kettenis
From: Timo Aaltonen tjaal...@ubuntu.com Date: Wed, 6 Apr 2011 19:50:06 +0300 Signed-off-by: Timo Aaltonen timo.aalto...@canonical.com --- src/sis_cursor.c |2 +- src/sis_utility.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/sis_cursor.c

Re: [PATCH 3/5] dix: set pointer to NULL after freeing at CloseDevice

2011-04-05 Thread Mark Kettenis
Date: Tue, 05 Apr 2011 14:27:02 +0300 From: Tiago Vignatti tiago.vigna...@nokia.com On 04/05/2011 03:14 PM, ext Simon Thum wrote: On 04/04/2011 07:54 PM, Tiago Vignatti wrote: It will fix two possible cases of use after free in RemoveDevice. Signed-off-by: Tiago

Re: [PATCH] fb: cleanup fbChangeWindowAttributes

2011-03-31 Thread Mark Kettenis
it in the fbEvenTile call a few lines later. Signed-off-by: Dave Airlie airl...@redhat.com Makes sense to me. Reviewed-by: Mark Kettenis kette...@openbsd.org --- fb/fbwindow.c | 55 --- 1 files changed, 20 insertions(+), 35 deletions

Re: [PATCH] [RFC] dix/mi: remove ChangeWindowAttributes from rendering path.

2011-03-31 Thread Mark Kettenis
From: Dave Airlie airl...@gmail.com Date: Thu, 31 Mar 2011 16:07:46 +1000 From: Dave Airlie airl...@redhat.com This moves ChangeWindowAttributes to mi, and calls a new hook that fb/exa can use to fixup the pixmap properly. I've looked at XAA and it seems this should work there as well,

Re: [PATCH v2 1/2] [libXau] XauGetFileName: added a thread-safe variant of XauFileName

2011-03-31 Thread Mark Kettenis
From: Mikhail Gusarov dotted...@dottedmag.net Date: Thu, 31 Mar 2011 14:18:13 +0200 Twas brillig at 13:13:23 31.03.2011 UTC+01 when mark.marsh...@csr.com did gyre and gimble: +static const char * +xau_getenv(const char *name) +{ +size_t len=3D 64; +char

Re: [PATCH v2 1/2] [libXau] XauGetFileName: added a thread-safe variant of XauFileName

2011-03-31 Thread Mark Kettenis
From: =?UTF-8?q?Erkki=20Sepp=C3=A4l=C3=A4?= erkki.sepp...@vincit.fi Date: Wed, 30 Mar 2011 11:53:53 +0300 XauGetFileName has argument char **buffer, which can be used to provide an existing buffer for XauGetFileName to store the result in. *buffer can be NULL, in which case a newly

Re: [PATCH 1/2] fb: drop defines that aren't used/necessary anymore.

2011-03-29 Thread Mark Kettenis
From: Dave Airlie airl...@gmail.com Date: Tue, 29 Mar 2011 14:26:43 +1000 From: Dave Airlie airl...@redhat.com This was generated by: cd fb coan source --replace -DFB_SCREEN_PRIVATE -DFB_24BIT -DFB_24_32BIT -DFB_SCREEN_PRIVATE -UFBNOPIXADDR -UFBNO24BIT -UFBNO24_32 *.[ch] Unfortunately

Re: [PATCH 1/2] fb: drop defines that aren't used/necessary anymore.

2011-03-29 Thread Mark Kettenis
Date: Tue, 29 Mar 2011 09:55:56 +0200 (CEST) From: Mark Kettenis mark.kette...@xs4all.nl From: Dave Airlie airl...@gmail.com Date: Tue, 29 Mar 2011 14:26:43 +1000 From: Dave Airlie airl...@redhat.com This was generated by: cd fb coan source --replace -DFB_SCREEN_PRIVATE

Re: [Xcb] [PATCH libXau] Avoid heap corruption when calling XauFileName from multiple threads.

2011-03-29 Thread Mark Kettenis
Date: Tue, 29 Mar 2011 12:06:34 +0300 From: =?ISO-8859-1?Q?Rami_Ylim=E4ki?= rami.ylim...@vincit.fi On 03/28/2011 09:14 PM, Mark Kettenis wrote: Date: Mon, 28 Mar 2011 10:21:06 -0700 From: Alan Coopersmithalan.coopersm...@oracle.com This commit fixes only the heap corruption

Re: [PATCH] dix: remove unused debug code

2011-03-28 Thread Mark Kettenis
Date: Mon, 28 Mar 2011 12:40:28 +0300 From: Tiago Vignatti tiago.vigna...@nokia.com Hi, On 03/25/2011 04:42 PM, ext Mark Kettenis wrote: From: Tiago Vignattitiago.vigna...@nokia.com Date: Fri, 25 Mar 2011 16:31:41 +0200 Sorry, but what gives you the authority to say this debug code

Re: [PATCH libXau] Avoid heap corruption when calling XauFileName from multiple threads.

2011-03-28 Thread Mark Kettenis
From: =?utf-8?q?Rami=20Ylim=C3=A4ki?= rami.ylim...@vincit.fi Date: Mon, 28 Mar 2011 13:45:15 +0300 An XCB test application will always crash because of heap corruption if it's running xcb_connect/xcb_disconnect continuously from multiple threads. The problem can also happen in real

Re: [PATCHv2 13/13] xfree86: fix memory leak in xf86LoadModules

2011-03-28 Thread Mark Kettenis
Date: Mon, 28 Mar 2011 10:48:06 -0700 From: Alan Coopersmith alan.coopersm...@oracle.com On 03/28/11 06:14 AM, Tiago Vignatti wrote: Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- hw/xfree86/common/xf86Init.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-)

Re: [Xcb] [PATCH libXau] Avoid heap corruption when calling XauFileName from multiple threads.

2011-03-28 Thread Mark Kettenis
Date: Mon, 28 Mar 2011 10:21:06 -0700 From: Alan Coopersmith alan.coopersm...@oracle.com This commit fixes only the heap corruption and sporadic crashes. It's still possible that XauFileName returns a badly formed filename string if called from multiple threads. For example, changing

Re: [PATCH] dix: remove unused debug code

2011-03-25 Thread Mark Kettenis
From: Tiago Vignatti tiago.vigna...@nokia.com Date: Fri, 25 Mar 2011 16:31:41 +0200 Sorry, but what gives you the authority to say this debug code isn't useful? Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- dix/dixfonts.c | 12 1 files changed, 0 insertions(+),

Re: [PATCH] [xorg/xserver] os/client: Prevent rare fd leak in DetermineClientPid

2011-03-24 Thread Mark Kettenis
From: =?UTF-8?q?Erkki=20Sepp=C3=A4l=C3=A4?= erkki.sepp...@vincit.fi Date: Thu, 24 Mar 2011 15:46:39 +0200 DetermineClientPid didn't close file descriptor if read on /proc/pid/cmdline failed. Added close to that path of code. Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi

Re: [PATCH] modes: Replace xf86DefaultModes with DMTModes

2011-03-08 Thread Mark Kettenis
From: Adam Jackson a...@redhat.com Date: Tue, 8 Mar 2011 14:56:33 -0500 DMTModes is what xf86DefaultModes was always meant to be. I'd say xf86DefaultModes is a better variable name than DMTModes for an exported symbol though. ___

Re: [PATCH] modes: Replace xf86DefaultModes with DMTModes

2011-03-08 Thread Mark Kettenis
Date: Tue, 8 Mar 2011 21:27:47 +0100 (CET) From: Mark Kettenis mark.kette...@xs4all.nl From: Adam Jackson a...@redhat.com Date: Tue, 8 Mar 2011 14:56:33 -0500 DMTModes is what xf86DefaultModes was always meant to be. I'd say xf86DefaultModes is a better variable name than DMTModes

Re: [PATCH] modes: Replace xf86DefaultModes with DMTModes

2011-03-08 Thread Mark Kettenis
From: Adam Jackson a...@redhat.com Date: Tue, 08 Mar 2011 16:21:02 -0500 On Tue, 2011-03-08 at 21:32 +0100, Mark Kettenis wrote: Date: Tue, 8 Mar 2011 21:27:47 +0100 (CET) From: Mark Kettenis mark.kette...@xs4all.nl =20 From: Adam Jackson a...@redhat.com Date: Tue, 8 Mar 2011

Re: [PATCH] vgaarb: Don't wrap Block/WakeupHandler

2011-03-04 Thread Mark Kettenis
From: Adam Jackson a...@redhat.com Date: Fri, 4 Mar 2011 16:15:28 -0500 These aren't hardware access, unless they are, in which case the rest of the wrapping will catch us. Sorry, but I don't think that is true. The xf86-video-glint driver has a BlockHandler that can call

[PATCH] [glint] Fix uploading YV12 data to texture buffer on BE machines

2011-02-28 Thread Mark Kettenis
that does the uploading needs to take into account the byteswapping done by the hardware. For 32bpp modes we can use the same code as on LE machines, but 16bpp and 8bpp modes need their own versions. Signed-off-by: Mark Kettenis kette...@openbsd.org --- src/pm2_video.c | 52

Re: [PATCH xf86-video-glint] No need for byteswapping in YV12 decoding on BE machines

2011-02-28 Thread Mark Kettenis
From: Alan Hourihane al...@fairlite.co.uk Date: Mon, 28 Feb 2011 22:32:49 + On Mon, 2011-02-28 at 20:06 +, Matt Turner wrote: On Sat, Dec 11, 2010 at 10:24 PM, Mark Kettenis mark.kette...@xs4all.nl wrote: Date: Sat, 11 Dec 2010 22:52:25 +0100 (CET) From: Mark Kettenis

Re: [PATCH] xf86AutoConfig: Try newport on mips.

2011-02-27 Thread Mark Kettenis
From: Cyril Brulebois k...@debian.org Date: Sun, 27 Feb 2011 22:52:18 +0100 As suggested by Bernhard R. Link in Debian bug report #566545 (http://bugs.debian.org/566545), newport is a candidate for autodetection on mips. diff --git a/hw/xfree86/common/xf86AutoConfig.c

Re: [PATCH:xscope] Greatly reduce xscope's bss pages

2011-02-26 Thread Mark Kettenis
From: Alan Coopersmith alan.coopersm...@oracle.com Date: Fri, 25 Feb 2011 23:28:24 -0800 xscope had several static arrays of StaticMaxFD structures, which ended up in .bss sections. StaticMaxFD was initialized to FD_SETSIZE. On 32-bit Solaris, the default value FD_SETSIZE is 1024. On

Re: [PATCH] vbe: Fix malloc size bug

2011-02-25 Thread Mark Kettenis
(CARD16) * i + 1); +block-VideoModePtr = malloc(sizeof(CARD16) * (i + 1)); memcpy(block-VideoModePtr, modes, sizeof(CARD16) * i); block-VideoModePtr[i] = 0x; I agree that this looks better. Reviewed-by: Mark Kettenis kette...@openbsd.org

Re: [PATCH:xdm 2/5] Add echoPasswdChar resource to set character to display

2011-02-20 Thread Mark Kettenis
From: Alan Coopersmith alan.coopersm...@oracle.com Date: Sat, 19 Feb 2011 22:36:38 -0800 Stop hardcoding it to '*'. Allows setting a resource with no value to display to advance the cursor without drawing text. What's the motivation for this change? Giving users more knobs to play with

Re: [PATCH:xdm 1/5] Delete some unused variables

2011-02-20 Thread Mark Kettenis
...@oracle.com --- xdm/auth.c |1 - xdm/error.c |2 -- 2 files changed, 0 insertions(+), 3 deletions(-) Reviewed-by: Mark Kettenis kette...@openbsd.org ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg

Re: [PATCH:xdm 4/5] greeter: Remove unused extern dpy that is shadowed by local variables

2011-02-20 Thread Mark Kettenis
is here Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com Reviewed-by: Mark Kettenis kette...@openbsd.org --- greeter/greet.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) ___ xorg-devel@lists.x.org: X.Org development

Re: [PATCH:xdm 3/5] Remove forced cursor move for no-echo entry when echoPasswd not set

2011-02-20 Thread Mark Kettenis
From: Alan Coopersmith alan.coopersm...@oracle.com Date: Sat, 19 Feb 2011 22:36:39 -0800 If you want to have it, for feedback that's visible to the user but harder to shoulder-surf, enable echoPasswd and set the echoPasswdChar to empty/space. But that would move the pixel more than one

Re: [PATCH:xdm 5/5] greeter: Rename valueMask for xpm window to avoid shadowing argument

2011-02-20 Thread Mark Kettenis
From: Alan Coopersmith alan.coopersm...@oracle.com Date: Sat, 19 Feb 2011 22:36:41 -0800 The Realize function names one of its arguments valueMask, so rename the local variable to xpmValueMask to reduce confusion and clear the gcc -Wshadow warning: Login.c: In function `Realize':

[PATCH] Properly restore CLOCK_CNTL_INDEX register

2011-02-20 Thread Mark Kettenis
doesn't save and restore the VGA state. Signed-off-by: Mark Kettenis kette...@openbsd.org --- src/radeon_driver.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/radeon_driver.c b/src/radeon_driver.c index 20a81e6..35c2761 100644 --- a/src/radeon_driver.c +++ b/src

Re: [PATCH libFS] Silence gcc warning.

2011-02-19 Thread Mark Kettenis
Date: Sat, 19 Feb 2011 15:04:24 +0100 From: Julien Cristau jcris...@debian.org diff --git a/test/FSGetErrorText.c b/test/FSGetErrorText.c index 31523c6..f9a88d2 100644 --- a/test/FSGetErrorText.c +++ b/test/FSGetErrorText.c @@ -40,7 +40,7 @@ CheckErrorMessage(FSServer *srv, int code,

Re: [PATCH] XDM: Fix FTBFS with gold or recent gcc releases.

2011-02-19 Thread Mark Kettenis
Date: Sat, 19 Feb 2011 18:03:04 + From: Fernando Lemos fernando...@gmail.com /usr/bin/ld: session.o: undefined reference to symbol 'dlclose@@GLIBC_2.2.5' /usr/bin/ld: note: 'dlclose@@GLIBC_2.2.5' is defined in DSO /lib64/libdl.so.2 so try adding it to the linker command line

Re: [PATCH setxkbmap] Eliminate limitations on path length.

2011-02-16 Thread Mark Kettenis
From: Van de Bugger van.de.bug...@gmail.com Date: Wed, 16 Feb 2011 00:15:52 +0300 From 0aaae5b3c0d6183e2791c30155bae40132a0c779 Mon Sep 17 00:00:00 2001 From: Van de Bugger van.de.bug...@gmail.com Date: Tue, 15 Feb 2011 23:55:28 +0300 Subject: [PATCH setxkbmap] Eliminate limitations on

Re: [PATCH 3/8] fbdevhw: Remove the non-sysfs hack for mapping from PCI to fbdev

2011-02-14 Thread Mark Kettenis
Date: Sun, 13 Feb 2011 08:48:16 -0800 From: Alan Coopersmith alan.coopersm...@oracle.com On 02/12/11 02:13 PM, Mark Kettenis wrote: From: Adam Jackson a...@redhat.com Date: Sun, 23 Jan 2011 23:18:07 -0500 It's broken for devices with BARs above 4G, and the sysfs method should work

Re: [PATCH] savage: More (intermediate) casts to silence warnings

2011-02-14 Thread Mark Kettenis
Date: Sun, 13 Feb 2011 21:40:50 +0100 From: Tormod Volden lists.tor...@gmail.com On Sat, Feb 12, 2011 at 10:43 PM, Mark Kettenis wrote: This isn't really the right way to fix things.  At least the casts should use uintptr_t instead of int.  That way you won't truncate addresses on true

Re: [PATCH libX11] config: Add an option to initialize threads by default.

2011-02-13 Thread Mark Kettenis
Date: Mon, 31 Jan 2011 15:06:03 +0100 From: Julien Cristau jcris...@debian.org On Mon, Jan 31, 2011 at 15:12:29 +0200, Tiago Vignatti wrote: On 01/31/2011 01:13 PM, ext Julien Cristau wrote: On Mon, Jan 31, 2011 at 12:46:56 +0200, Rami Ylimäki wrote: This change makes it possible

Re: [PATCH] savage: More (intermediate) casts to silence warnings

2011-02-12 Thread Mark Kettenis
From: Tormod Volden lists.tor...@gmail.com Date: Sun, 23 Jan 2011 12:47:04 +0100 From: Tormod Volden debian.tor...@gmail.com savage_dga.c: In function ‘Savage_OpenFramebuffer’: savage_dga.c:393: warning: cast to pointer from integer of different size savage_dri.c: In function

Re: [PATCH 4/8] xfree86: warning fix

2011-02-12 Thread Mark Kettenis
'handle_detailed_monrec': xf86Crtc.c:1555:33: warning: comparison between 'enum det_monrec_source' and 'enum anonymous' xf86Crtc.c:1562:33: warning: comparison between 'enum det_monrec_source' and 'enum anonymous' Signed-off-by: Adam Jackson a...@redhat.com Reviewed-by: Mark Kettenis kette

Re: [PATCH 3/8] fbdevhw: Remove the non-sysfs hack for mapping from PCI to fbdev

2011-02-12 Thread Mark Kettenis
Jackson a...@redhat.com That code should really be #ifdef __linux__ to make it obvious that it is OS-specific code. Anyway, if the Linux community is happy with it, I am as well ;). Reviewed-by: Mark Kettenis kette...@openbsd.org --- hw/xfree86/fbdevhw/fbdevhw.c | 56

Re: [PATCH 01/32] [libx11] Using freed pointer e

2011-02-12 Thread Mark Kettenis
From: =?UTF-8?q?Erkki=20Sepp=C3=A4l=C3=A4?= erkki.sepp...@vincit.fi Date: Thu, 27 Jan 2011 09:53:44 +0200 Reordered code to first to do the comparison and then to release data Your static analysis tool isn't all that good. Using the value of a pointer after freeing the storage it points to

Re: [PATCH 03/32] [libx11] Using uninitialized value p-modifiers

2011-02-12 Thread Mark Kettenis
From: =?UTF-8?q?Erkki=20Sepp=C3=A4l=C3=A4?= erkki.sepp...@vincit.fi Date: Thu, 27 Jan 2011 09:53:46 +0200 Smal fix by using calloc instead of Xmalloc The comments introduced here (especially the first one) are fairly pointless. And this probably should use Xcalloc() instead of calloc().

Re: [PATCH:xbiff 1/2] Use paths.h and _PATH_MAILDIR to find mailboxes if present

2011-01-08 Thread Mark Kettenis
, but the FHS 2.0 standard changed it to /var/mail in 1997. So perhaps the +# elif defined(__linux__) +# define MAILBOX_DIRECTORY /var/spool/mail +# else should just go. In any case, not a big issue, just some possible further cleanup, so feel free to ignore that. Reviewed-by: Mark Kettenis

Re: [PATCH] include: purge foo(int /*bar*/) function declarations.

2011-01-06 Thread Mark Kettenis
Date: Thu, 6 Jan 2011 14:29:59 +1000 From: Peter Hutterer peter.hutte...@who-t.net because, really, comments should be for comments. Not sure this is a good idea, at least not in public headers. The problem is that if you have extern void foo(int bar); and for some reason bar is #defined

Re: [PATCH 3/3] xfree86: Fix the sdk headers to be multilib-safe

2011-01-06 Thread Mark Kettenis
From: Adam Jackson a...@redhat.com Date: Thu, 6 Jan 2011 17:29:01 -0500 Use _LP64 (verified on gcc and sun compilers) instead of _XSERVER64 in internal header usage, and always define _XSERVER64 for modules if _LP64 is defined. Prevents differing xorg-server.h between 32 and 64 bit

Re: [PATCH 01/11] dix: Refactor block and wakup handlers

2011-01-04 Thread Mark Kettenis
Date: Tue, 4 Jan 2011 12:26:13 +0200 From: Pauli Nieminen ext-pauli.niemi...@nokia.com On 03/01/11 13:23 -0800, ext Alan Coopersmith wrote: On 12/31/10 09:30 AM, Pauli wrote: From: Pauli Nieminen ext-pauli.niemi...@nokia.com It is common use case in server that only block or

Re: [PATCH 00/11] Allow registering only wakeup or block handler

2011-01-04 Thread Mark Kettenis
in tons of tiny micropatches. I hope Mark likes this patch set more than previous try to eliminate extra functions. Yes, introducing seperate functions is better than making RegisterBlockAndWakeupHandlers() accept NULL arguments, which would be an ABI break. Reviewed-by: Mark Kettenis kette

Re: [PATCH v2 modular 3/3] build.sh: comment the supported systems and how they are detected

2011-01-03 Thread Mark Kettenis
From: Gaetan Nadon mems...@videotron.ca Date: Mon, 03 Jan 2011 18:08:11 -0500 For many, build.sh is the first encounter to X.Org or even UNIX code. This comment should help them understand why certain packages cannot be built on thier system. Sorry, but I think this list is incomplete, and

Re: [PATCH modular 2/4] build.sh: use accurate values for HOST_CPU from config.guess

2011-01-02 Thread Mark Kettenis
From: Gaetan Nadon mems...@videotron.ca Date: Sun, 02 Jan 2011 08:58:03 -0500 Using x86*64* rather than x86_64 is misleading to the user as it implies there are a large number of possibilities. Use the values from config.guess which are known to be accurate. Signed-off-by: Gaetan Nadon

Re: [PATCH modular 3/4] build.sh: comment the supported systems and how they are detected

2011-01-02 Thread Mark Kettenis
From: Gaetan Nadon mems...@videotron.ca Date: Sun, 02 Jan 2011 15:20:06 -0500 The term amd64 is widely used, but is only returned as a uname -m value by a CYGWIN system - if I understand this file correctly! amd64:CYGWIN*:*:* | x86_64:CYGWIN*:*:*) echo x86_64-unknown-cygwin

Re: [PATCH 5/9] dri1: warning fix

2010-12-31 Thread Mark Kettenis
From: Daniel Stone dan...@fooishbar.org Date: Fri, 31 Dec 2010 02:00:19 + From: Adam Jackson a...@redhat.com dri.c: In function ‘DRIScreenInit’: dri.c:434: warning: cast from pointer to integer of different size Is just pacifying the compiler the right solution here? At least

Re: [PATCH 6/9] xcmisc: warning fix

2010-12-31 Thread Mark Kettenis
From: Daniel Stone dan...@fooishbar.org Date: Fri, 31 Dec 2010 02:00:20 + From: Adam Jackson a...@redhat.com xcmisc.c:202: warning: no previous prototype for ‘XCMiscExtensionInit’ Sorry, but what's the point of the #if 1/#endif around the prototype? +#if 1 +extern void

Re: [PATCH 2/3] XFree86: Linux: AGP: Fix void-pointer-arithmetic warning

2010-12-31 Thread Mark Kettenis
From: Daniel Stone dan...@fooishbar.org Date: Fri, 31 Dec 2010 09:55:10 + Cast it to a char *, mimicking the return immediately below it. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Mark Kettenis kette...@openbsd.org --- hw/xfree86/os-support/linux/lnx_video.c

Re: [PATCH 10/22] udev: Use shared NoopDDA to utilize code cache better

2010-12-30 Thread Mark Kettenis
Date: Thu, 30 Dec 2010 11:32:18 +0200 From: Pauli Nieminen ext-pauli.niemi...@nokia.com On 29/12/10 21:19 +0100, ext Mark Kettenis wrote: From: Pauli ext-pauli.niemi...@nokia.com Date: Wed, 29 Dec 2010 21:27:22 +0200 From: Pauli Nieminen ext-pauli.niemi...@nokia.com

Re: [PATCH] Update NetBSD support in libpciaccess

2010-12-29 Thread Mark Kettenis
that don't sit on PCI bus 0. Anyway, just some stuff to keep in mind. If you think this helps NetBSD users, by all means go ahead. Reviewed-by: Mark Kettenis kette...@openbsd.org ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org

Re: [PATCH 10/22] udev: Use shared NoopDDA to utilize code cache better

2010-12-29 Thread Mark Kettenis
From: Pauli ext-pauli.niemi...@nokia.com Date: Wed, 29 Dec 2010 21:27:22 +0200 From: Pauli Nieminen ext-pauli.niemi...@nokia.com Calling function that is in code cache is order of magnitude faster. In arm non-cached simple function takes about 1us while cached function takes max 200ns.

Re: [PATCH 11/22] dbus: Use shared NoopDDA to utilize code cache better

2010-12-29 Thread Mark Kettenis
From: Pauli ext-pauli.niemi...@nokia.com Date: Wed, 29 Dec 2010 21:27:23 +0200 From: Pauli Nieminen ext-pauli.niemi...@nokia.com Calling function that is in code cache is order of magnitude faster. In arm non-cached simple function takes about 1us while cached function takes max 200ns.

Re: [PATCH 12/22] kdrive/ephyr: Use shared NoopDDA to utilize code cache better

2010-12-29 Thread Mark Kettenis
From: Pauli ext-pauli.niemi...@nokia.com Date: Wed, 29 Dec 2010 21:27:24 +0200 From: Pauli Nieminen ext-pauli.niemi...@nokia.com Calling function that is in code cache is order of magnitude faster. In arm non-cached simple function takes about 1us while cached function takes max 200ns.

Re: [PATCH 4/4] GLX: DRI2: Fix mismatched-types warning

2010-12-28 Thread Mark Kettenis
From: Daniel Stone dan...@fooishbar.org Date: Tue, 28 Dec 2010 12:54:58 + All the DRI extension types have a base extension type as their first member to avoid exactly these types of warning. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Mark Kettenis kette

Re: [PATCH:libICE] Add AC_USE_SYSTEM_EXTENSIONS to make asprintf() visible in GNU libc

2010-12-22 Thread Mark Kettenis
...@oracle.com Reviewed-by: Mark Kettenis kette...@openbsd.org --- configure.ac |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/configure.ac b/configure.ac index 03432f5..88fbcd7 100644 --- a/configure.ac +++ b/configure.ac @@ -12,6 +12,11 @@ AC_CONFIG_HEADERS

Re: [PATCH:libICE] Fix stdio.h include for asprintf.

2010-12-19 Thread Mark Kettenis
From: Cyril Brulebois k...@debian.org Date: Sun, 19 Dec 2010 18:43:49 +0100 asprintf is a GNU extension and one needs to define _GNU_SOURCE before including stdio.h. Otherwise, the build breaks this way with --- src/process.c |6 ++ 1 files changed, 6 insertions(+), 0

Re: [PATCH] Remove SCO support

2010-12-16 Thread Mark Kettenis
From: Adam Jackson a...@redhat.com Date: Thu, 16 Dec 2010 13:20:09 -0500 diff --git a/hw/xfree86/common/scoasm.h b/hw/xfree86/common/scoasm.h index 8f80e7b..2774f9a 100644 --- a/hw/xfree86/common/scoasm.h +++ b/hw/xfree86/common/scoasm.h @@ -34,109 +34,3 @@ #include xorg-config.h

Re: [PATCH] Remove SCO support

2010-12-16 Thread Mark Kettenis
From: Adam Jackson a...@redhat.com Date: Thu, 16 Dec 2010 16:03:11 -0500 This has never been buildable in any modular server release. Signed-off-by: Adam Jackson a...@redhat.com Reviewed-by: Mark Kettenis kette...@openbsd.org ___ xorg-devel

Re: [PATCH 1/2] xfree86: use a thread for the generation of input events

2010-12-16 Thread Mark Kettenis
From: Adam Jackson a...@redhat.com Date: Thu, 16 Dec 2010 10:32:21 -0500 On Wed, 2010-12-15 at 23:08 +0100, Mark Kettenis wrote: Yes, that is the additional locking that's necessary. I'd say you'll need a mutex that you lock in x86BlockSIGIO() and unlock in xf86UnblockSIGIO

Re: [PATCH 1/2] xfree86: use a thread for the generation of input events

2010-12-15 Thread Mark Kettenis
From: Adam Jackson a...@redhat.com Date: Tue, 14 Dec 2010 17:27:46 -0500 On Mon, 2010-12-13 at 21:19 +0100, Mark Kettenis wrote: First, the autoconf bits suggest that the input thread is optional. But I can't see any evidence of that in the code changes. I really *don't* want

Re: [PATCH 1/2] xfree86: use a thread for the generation of input events

2010-12-13 Thread Mark Kettenis
From: Adam Jackson a...@redhat.com Date: Mon, 13 Dec 2010 12:52:53 -0500 From: Tiago Vignatti tiago.vigna...@nokia.com The current SIGIO signal handler method, used at generation of input events, has a bunch of oddities. This patch introduces an alternative way using a thread, which is

Re: [PATCH xf86-video-glint] No need for byteswapping in YV12 decoding on BE machines

2010-12-11 Thread Mark Kettenis
From: Alan Hourihane al...@fairlite.co.uk Date: Thu, 09 Dec 2010 13:00:54 + On Thu, 2010-12-09 at 13:41 +0100, Mark Kettenis wrote: Might want to check the hardware manuals on this, but there might be a byteswap bit someplace that does it in hardware. The PGX32 may do

Re: [PATCH xf86-video-glint] No need for byteswapping in YV12 decoding on BE machines

2010-12-11 Thread Mark Kettenis
Date: Sat, 11 Dec 2010 22:52:25 +0100 (CET) From: Mark Kettenis mark.kette...@xs4all.nl From: Alan Hourihane al...@fairlite.co.uk Date: Thu, 09 Dec 2010 13:00:54 + On Thu, 2010-12-09 at 13:41 +0100, Mark Kettenis wrote: Might want to check the hardware manuals

Re: Lack of middle button emulation makes HP life hard

2010-12-09 Thread Mark Kettenis
From: Keith Packard kei...@keithp.com Date: Wed, 08 Dec 2010 09:25:19 -0800 So, HP laptops come with a pointy-stick in the middle of the keyboard and only two buttons. Not having middle-button emulation in this environment is pretty harsh. I know it's not optimal to enable this by

Re: [PATCH xf86-video-glint] No need for byteswapping in YV12 decoding on BE machines

2010-12-09 Thread Mark Kettenis
From: Alan Hourihane al...@fairlite.co.uk Date: Wed, 08 Dec 2010 08:50:00 + On Tue, 2010-12-07 at 23:20 +, Matt Turner wrote: On Tue, Dec 7, 2010 at 8:07 PM, Mark Kettenis mark.kette...@xs4all.nl wrote: No need for byteswapping in YV12 decoding on BE machines

Re: [PATCH xf86-video-glint] No need for byteswapping in YV12 decoding on BE machines

2010-12-08 Thread Mark Kettenis
From: Matt Turner matts...@gmail.com Date: Tue, 7 Dec 2010 23:20:44 + On Tue, Dec 7, 2010 at 8:07 PM, Mark Kettenis mark.kette...@xs4all.nl wrote: No need for byteswapping in YV12 decoding on BE machines The hardware seems to do the proper thing already, so always use the same

Re: [PATCH xinput] use ASCII art when UTF-8 environment is not available

2010-12-08 Thread Mark Kettenis
Date: Wed, 8 Dec 2010 22:31:37 +0100 From: Matthieu Herrb matthieu.he...@laas.fr +/* + * There is no standard way to detect UTF-8 capabilities of a + * given terminal, but this gets pretty close as a good heuristic. + */ Actually, there is a somewhat better way to do this.

[PATCH xf86-video-sunffb] Remove xf86DPMSInit() duplication

2010-12-07 Thread Mark Kettenis
This driver calls xf86DPMSInit() twice, which is a bad idea since this function wraps CloseScreen(). Remove the second call. Fixes a crash on server shutdown with xserver 1.9.2 on OpenBSD/sparc64. Signed-off-by: Mark Kettenis kette...@openbsd.org --- src/ffb_driver.c | 13 - 1

[PATCH xf86-video-glint] No need for byteswapping in YV12 decoding on BE machines

2010-12-07 Thread Mark Kettenis
No need for byteswapping in YV12 decoding on BE machines The hardware seems to do the proper thing already, so always use the same code on both little-endian and big-endian machines. Fixes xv YV12 on a TechSource Raptor GFX aka Sun PGX32. Signed-off-by: Mark Kettenis kette...@openbsd.org

Re: [PATCH] Make pm2's xv driver collect options like all other drivers.

2010-12-05 Thread Mark Kettenis
From: Jesse Adkins jesserayadk...@gmail.com Date: Thu, 11 Nov 2010 19:48:37 -0800 The current method of argument collection is to collect options from different ports of a VideoAdaptor record. Specifically, the ports had to be named 'Input' for input options, and 'Output' for output

Re: [PATCH 1/6 v2] Add X*asprintf() routines to mirror common asprintf() routines

2010-12-03 Thread Mark Kettenis
From: Keith Packard kei...@keithp.com Date: Thu, 02 Dec 2010 22:28:08 -0800 So, it seems like we have the option of exporting asprintf in our effective ABI, or changing the name. Of the two, I'd be OK with exporting asprintf in our ABI, but I don't feel strongly about it. If someone has a

Re: [PATCH citron] Fail configure. This driver is unmaintained.

2010-12-02 Thread Mark Kettenis
Date: Wed, 01 Dec 2010 21:31:04 -0800 From: Alan Coopersmith alan.coopersm...@oracle.com The MAINTAINERS file already says it's deactivated. Where does the MAINTAINERS file live? I should probably list myself there for x86-video-mach64. ___

Re: [PATCH citron] Fail configure. This driver is unmaintained.

2010-12-02 Thread Mark Kettenis
Date: Thu, 2 Dec 2010 15:00:10 +0100 From: Julien Cristau jcris...@debian.org On Thu, Dec 2, 2010 at 14:42:44 +0100, Mark Kettenis wrote: Date: Wed, 01 Dec 2010 21:31:04 -0800 From: Alan Coopersmith alan.coopersm...@oracle.com The MAINTAINERS file already says it's deactivated

Re: [PATCH] dix: do not use bit-wise operators on the boolean result of BitIsOn

2010-12-01 Thread Mark Kettenis
From: Ferry Huberts maili...@hupie.com Date: Tue, 30 Nov 2010 19:06:55 +0100 From: Ferry Huberts ferry.hube...@pelagic.nl Performing bit-wise operations on a boolean amounts to mixing types, is confusing and basically incorrect; one should only perform logical operations on booleans.

Re: [PATCH 06/11] Add X*asprintf() routines to mirror common asprintf() routines

2010-12-01 Thread Mark Kettenis
Date: Tue, 30 Nov 2010 19:16:41 +0100 From: walter harms wha...@bfs.de Am 30.11.2010 05:57, schrieb Alan Coopersmith: Provides a portable implementation of this common allocating sprintf() API found in many, but not yet all, of the platforms we support. If the platform provides

Re: [PATCH 06/11] Add X*asprintf() routines to mirror common asprintf() routines

2010-12-01 Thread Mark Kettenis
Date: Wed, 01 Dec 2010 11:48:22 +0100 From: walter harms wha...@bfs.de Am 30.11.2010 23:37, schrieb Dan Nicholson: On Tue, Nov 30, 2010 at 10:16 AM, walter harms wha...@bfs.de wrote: Am 30.11.2010 05:57, schrieb Alan Coopersmith: Provides a portable implementation of this common

<    1   2   3   4   5   6   >