Re: Finishing the X11R7.5 katamari

2009-10-03 Thread Alan Coopersmith
Didier Spaier wrote: Thanks for the explanation Alan. I just can't find any clear definition of katamari in Xorg's context, searching the wiki as well as this mailing list :-\ Sorry, it's what we call the X11R7.x releases in which we roll up a set of individually released modules (the X

Re: Finishing the X11R7.5 katamari

2009-10-03 Thread Didier Spaier
On Saturday 03 October 2009 11:11:32 Alan Coopersmith wrote: Didier Spaier wrote: Thanks for the explanation Alan. I just can't find any clear definition of katamari in Xorg's context, searching the wiki as well as this mailing list :-\ Sorry, it's what we call the X11R7.x releases in

Re: checked sources of xorg-server 1.7.0 with static code analysis tool cppcheck

2009-10-03 Thread Michel Dänzer
On Fri, 2009-10-02 at 18:25 -0700, Jeremy Huddleston wrote: On Oct 2, 2009, at 16:17, Michel Dänzer wrote: On Fri, 2009-10-02 at 23:10 +0200, Martin Ettl wrote: diff --git a/exa/exa_classic.c b/exa/exa_classic.c index 1eff570..c9c7534 100644 --- a/exa/exa_classic.c +++

[cppcheck] Dangerous usage of strncat in file xf86AutoConfig.c

2009-10-03 Thread Martin Ettl
Hello friends, further analysation with the static code analysis tool cppcheck brought up another issue. The tool printed the following warning: ../xfree86/common/xf86AutoConfig.c,337,possible error,Dangerous usage of strncat. Tip: the 3rd parameter means maximum number of characters to append

Re: Finishing the X11R7.5 katamari

2009-10-03 Thread Peter Hutterer
On Fri, Oct 02, 2009 at 06:39:50PM -0700, Alan Coopersmith wrote: xf86-input-evdev 2.0.4* xf86-input-joystick 1.3.2* xf86-input-keyboard 1.3.1* xf86-input-mouse 1.3.0*

[cppcheck] resource leak xf86Configure.c

2009-10-03 Thread Martin Ettl
Hi friends, here is another issue (spotted out by cppcheck, a static code analysis tool). It prints the following warning: ../xfree86/common/xf86Configure.c,266,possible error,Resource leak: fd Take a look into file xf86Configure.c at line 266: ... fd = open(/dev/wsmouse, 0);

Re: checked sources of xorg-server 1.7.0 with static code analysis tool cppcheck

2009-10-03 Thread Michel Dänzer
On Sat, 2009-10-03 at 08:43 -0400, Thomas Dickey wrote: On Sat, 3 Oct 2009, Michel Dnzer wrote: What purpose is that? If these functions were actually called with a NULL PixmapPtr, surely the current code would have crashed with a segmentation fault. I suppose that if you prefer the

Re: [cppcheck] Dangerous usage of strncat in file xf86AutoConfig.c

2009-10-03 Thread David Gerard
2009/10/3 Thomas Dickey dic...@his.com: On Sat, 3 Oct 2009, David Gerard wrote: I suggest running the whole server code base through cppcheck, seeing what it comes up with then going through very carefully to work out what's a bug in Xorg code and what's actually a bug in cppcheck. Probably

Re: checked sources of xorg-server 1.7.0 with static code analysis tool cppcheck

2009-10-03 Thread Thomas Dickey
On Sat, 3 Oct 2009, Michel D�nzer wrote: On Sat, 2009-10-03 at 08:43 -0400, Thomas Dickey wrote: On Sat, 3 Oct 2009, Michel Dnzer wrote: What purpose is that? If these functions were actually called with a NULL PixmapPtr, surely the current code would have crashed with a segmentation fault.

Re: wheel emulation broken in recent evdev

2009-10-03 Thread Daniel Stone
On Sat, Sep 19, 2009 at 04:28:55PM -0400, Andy Neitzke wrote: On my system (Thinkpad X60t, Gentoo amd64) wheel emulation was broken by commit f4ba2bd785b25fd522967abd7775925d5fded70f (Allow 0 as wheel emulation button for unconditional scrolling (#20529)). A little experimenting here

Re: [xorg-delevel] Separate X-Screen feature - dual monitoring

2009-10-03 Thread Daniel Stone
On Tue, Sep 22, 2009 at 09:56:40AM +0900, Pradeep Reddy wrote: *In order to support Separate X-screen*, *i have connected to external monitor and tried various combinations of xorg.conf.* *I am still unable to get separate X-screens. So i suspect on Intel hardware My X-server too. Do any one

Re: [PATCH] EXA: Accumulate arbitrary number of glyphs without flushing.

2009-10-03 Thread Daniel Stone
On Wed, Sep 23, 2009 at 01:16:38PM +0200, Michel Dänzer wrote: From: Michel Dänzer daen...@vmware.com If you queue up these fixes in an xserver-exa tree, I'd be happy to test them. Cheers, Daniel pgpB5hNxNGASM.pgp Description: PGP signature ___

Re: [PATCH/libXdamage] Require pkg-config to find the packages, no funky x11 lookups.

2009-10-03 Thread Daniel Stone
On Wed, Sep 23, 2009 at 09:51:07PM +1000, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Acked-by: Daniel Stone dan...@fooishbar.org pgpfNBTaFdzt5.pgp Description: PGP signature ___ xorg-devel mailing list

Re: [PATCH] Add libgcrypt as an option for sha1

2009-10-03 Thread Daniel Stone
On Thu, Sep 24, 2009 at 01:41:31PM +0200, Julien Cristau wrote: Signed-off-by: Julien Cristau jcris...@debian.org --- We've been using that in Debian since April (to avoid openssl's gpl-incompatible license, and because gcrypt is already in our base system). One thing I'm not sure about is

Re: [PATCH] Move xtrans.pc to /usr/share/pkg-config

2009-10-03 Thread Daniel Stone
On Sat, Sep 26, 2009 at 04:39:20AM +0700, Mikhail Gusarov wrote: This fixes configuration in cross-compilation mode: pkg-config does not look for .pc in /usr/lib/pkg-config during cross-compilation to avoid picking up wrong libraries. Hmm. Doesn't that mean that we'd have to change every

Re: fix for xf86-video-vesa with xserver 1.7

2009-10-03 Thread Daniel Stone
On Mon, Sep 28, 2009 at 11:18:45PM +0200, Matthieu Herrb wrote: I need those 2 fixes to run the vesa driver with xserver 1.7. ok? commit 9829de7a1b2a9734d20a239d3ed84a73ddaf70f1 Author: Matthieu Herrb matthieu.he...@laas.fr Date: Mon Sep 28 23:00:27 2009 +0200 fix vesa for xserver

Re: [PATCH/evdev] Add explicit options to ignore relative or absolute axes.

2009-10-03 Thread Daniel Stone
On Wed, Sep 30, 2009 at 12:35:56PM +1000, Peter Hutterer wrote: The X server cannot deal with devices that have both relative and absolute axes. Evdev tries to guess wich axes to ignore given the device type and disables absolute axes for mice and relative axes for tablets, touchscreens and

Re: [PATCH] Replace miPointerCurrentScreen with miPointerGetScreen.

2009-10-03 Thread Daniel Stone
Hi, On Fri, Oct 02, 2009 at 02:54:57PM -0700, Jamey Sharp wrote: I get the impression from glancing at the code that you're right, but xf86RandRSetConfig begins with miPointerGetPosition(inputInfo.pointer, px, py); and this if block ends with (*pScreen-SetCursorPosition)

Re: [PATCHv2] Fix possibly uninitialized warnings in glx.

2009-10-03 Thread Daniel Stone
On Fri, Oct 02, 2009 at 02:20:33PM -0700, Jamey Sharp wrote: In both functions, answer was uninitialized if compsize was 0, but in that case __GLX_SEND_VOID_ARRAY(compsize) results in a call to WriteToClient for 0 bytes, which returns immediately without examining the answer argument. So

Re: [PATCH] Use PRId32/PRIx32 from inttypes.h for printf of CARD32 values.

2009-10-03 Thread Daniel Stone
On Fri, Oct 02, 2009 at 01:42:46PM -0700, Jamey Sharp wrote: Signed-off-by: Jamey Sharp ja...@minilop.net --- hw/xfree86/int10/helper_exec.c | 28 ++-- 1 files changed, 14 insertions(+), 14 deletions(-) diff --git a/hw/xfree86/int10/helper_exec.c

Re: [PATCH] Fix GCC warnings in xorg_backtrace.

2009-10-03 Thread Daniel Stone
On Fri, Oct 02, 2009 at 01:42:49PM -0700, Jamey Sharp wrote: Signed-off-by: Jamey Sharp ja...@minilop.net Acked-by: Daniel Stone dan...@fooishbar.org, merged to ~daniels/xserver. Cheers, Daniel pgph3kNZ9Ci0x.pgp Description: PGP signature ___

Re: [PATCH] Cast small-int values through intptr_t when they're passed as pointers.

2009-10-03 Thread Daniel Stone
On Fri, Oct 02, 2009 at 01:42:50PM -0700, Jamey Sharp wrote: On 64-bit systems, int and pointers don't have the same size, so GCC gives warnings about casts between int and pointer types. However, in the cases covered by this patch, it's always a value that fits in int being stored temporarily

Re: [PATCH] MAINTAINERS: Use xorg-devel instead of xorg for mailing list

2009-10-03 Thread Guillem Jover
On Sun, 2009-10-04 at 11:49:30 +1100, Daniel Stone wrote: On Sat, Sep 19, 2009 at 09:50:11PM +0200, Guillem Jover wrote: Signed-off-by: Guillem Jover guil...@hadrons.org Signed-off-by: Daniel Stone dan...@fooishbar.org Thanks! Pushed. regards, guillem

Re: [PATCH] Use PRId32/PRIx32 from inttypes.h for printf of CARD32 values.

2009-10-03 Thread Daniel Stone
On Sat, Oct 03, 2009 at 06:12:54PM -0700, Jamey Sharp wrote: On Sat, Oct 3, 2009 at 6:06 PM, Daniel Stone dan...@fooishbar.org wrote: On Fri, Oct 02, 2009 at 01:42:46PM -0700, Jamey Sharp wrote: +     ErrorF( rep_insb(%#x) % PRId32 bytes at %8.8 PRIx32 %s\n, Is this portable beyond

Re: [PATCH] Move xtrans.pc to /usr/share/pkg-config

2009-10-03 Thread Mikhail Gusarov
Twas brillig at 11:55:24 04.10.2009 UTC+11 when dan...@fooishbar.org did gyre and gimble: DS On Sat, Sep 26, 2009 at 04:39:20AM +0700, Mikhail Gusarov wrote: This fixes configuration in cross-compilation mode: pkg-config does not look for .pc in /usr/lib/pkg-config during

Re: [PATCH] Use PRId32/PRIx32 from inttypes.h for printf of CARD32 values.

2009-10-03 Thread Matthieu Herrb
Daniel Stone wrote: On Fri, Oct 02, 2009 at 01:42:46PM -0700, Jamey Sharp wrote: Signed-off-by: Jamey Sharp ja...@minilop.net --- hw/xfree86/int10/helper_exec.c | 28 ++-- 1 files changed, 14 insertions(+), 14 deletions(-) diff --git