3304bbff9b4ed63f1a47410a5320a136420ba2c6 added smooth scrolling support for
pointer events and for XIQueryDevice but didn't add the matching parts to
XIDeviceChangedEvents.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
dix/eventconvert.c | 53
Instead of device and master (and just using master), drop the master
argument and let the callers pass in the device the event is to be sent for.
No effective functional changes.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
Xi/exevents.c |6 +++---
dix/devices.c |
No effective functional changes, prep work for future patches.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
dix/getevents.c |7 +++
include/input.h |3 ++-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/dix/getevents.c b/dix/getevents.c
index
If we're sending the event for a given device, make sure the deviceid is
that of the device.
This allows callers to use the same DCE for slave and master without having
to fiddle the DCE's internal fields.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
Xi/exevents.c |1 +
1 files
If a floating device changes, the master is NULL but we must still create a
DCE for it.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
dix/getevents.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/dix/getevents.c b/dix/getevents.c
index 8057e62..4845a10
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
Xi/exevents.c | 13 -
1 files changed, 12 insertions(+), 1 deletions(-)
diff --git a/Xi/exevents.c b/Xi/exevents.c
index 7afb69e..053c76f 100644
--- a/Xi/exevents.c
+++ b/Xi/exevents.c
@@ -1103,6 +1103,8 @@
On Wed, Oct 19, 2011 at 10:47:17AM -0700, Jeremy Huddleston wrote:
Actually, I retract this. I didn't intend to do it originally, but
now that it's done, meh.
If you change your mind:
Reviewed-by: Jamey Sharp ja...@minilop.net
But I, for one, am perfectly happy with meh. :-)
I think we
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
test/xi2/protocol-eventconvert.c |7 +++
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/test/xi2/protocol-eventconvert.c b/test/xi2/protocol-eventconvert.c
index bfa23b5..4bc57d3 100644
---
On Oct 19, 2011, at 23:45, Jamey Sharp wrote:
I think we coddled the drivers enough with the current set of
just-deprecations. This is too trivial. I'll just go through and
make sure nobody is actually using it because drivers still build
successfully due to us not using
Hi,
On 2011-10-18 20:15, Matt Dew wrote:
On 10/17/2011 03:07 AM, Marko Myllynen wrote:
There's a comment in the keysymdef.h file:
ezh/EZH happened to be in ranges covered by IPAExt_upper_mapping and
LatinExtB_{upper,lower}_mapping mappings in KeyBind.c already but indeed
permille needed a
On Wed, Oct 19, 2011 at 11:20:54AM -0700, Jeremy Huddleston wrote:
On Oct 19, 2011, at 1:02 AM, Zhigang Gong wrote:
Just as I said above. Your thought do make sense. Currently glamor
implements some GL based rendering functions. And in the long term,
we may merge those functions into cairo
Fixes from RHEL coverity scan + fbdev work.
The following changes since commit c8413362049cee8c30e0a9d67f78f9ebefe8e71f:
Merge remote-tracking branch 'herrb/master' (2011-10-18 07:45:24 -0700)
are available in the git repository at:
ssh://people.freedesktop.org/~airlied/xserver rhel-fixes
On Mit, 2011-10-19 at 11:20 -0700, Jeremy Huddleston wrote:
As I understand it, you want to allow accelerated 2D rendering at the
*DIX* level (whereas EXA and XAA are for Xorg DDX drivers).
Actually, EXA is at the DIX level as well, and used by Xephyr.
That is a great goal, but another
Hello,
On 20 October 2011 11:38, bugzilla-dae...@freedesktop.org wrote:
https://bugs.freedesktop.org/show_bug.cgi?id=42035
--- Comment #1 from Michel Dänzer mic...@daenzer.net 2011-10-20 02:38:29
PDT ---
According to comments in bug 28771 a the xorg ddx is hardcoded to wait for
vsync
This is a bunch of low hanging coverity fixes, there are a lot more,
but some of them are a bit more intricate, and also there seems to be
a fair few false positives (or me deluding myself).
Dave.
___
xorg-devel@lists.x.org: X.Org development
Archives:
From: Dave Airlie airl...@redhat.com
coverity scan pointed this out.
In some of its error cases AllocARGBCursor freed the bits passed in,
because it assigned them to the cursor and called FreeCursorBits, in
one case it didn't, if it hadn't done the assignment.
This standardises the interface so
From: Dave Airlie airl...@redhat.com
Coverity scan pointed this out.
Drop unused randrp setup.
Signed-off-by: Dave Airlie airl...@redhat.com
---
hw/xfree86/modes/xf86RandR12.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/hw/xfree86/modes/xf86RandR12.c
From: Dave Airlie airl...@redhat.com
Pointed out by coverity scan.
Signed-off-by: Dave Airlie airl...@redhat.com
---
hw/xfree86/common/xf86pciBus.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/xfree86/common/xf86pciBus.c b/hw/xfree86/common/xf86pciBus.c
index
From: Dave Airlie airl...@redhat.com
This isn't used anywhere in here.
Pointed out by coverity scan.
Signed-off-by: Dave Airlie airl...@redhat.com
---
hw/xfree86/common/xf86Helper.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/hw/xfree86/common/xf86Helper.c
From: Dave Airlie airl...@redhat.com
pointed out by coverity.
Signed-off-by: Dave Airlie airl...@redhat.com
---
hw/xnest/Keyboard.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/hw/xnest/Keyboard.c b/hw/xnest/Keyboard.c
index ec629dc..c138438 100644
---
From: Dave Airlie airl...@redhat.com
pointed out by coverity scan.
Signed-off-by: Dave Airlie airl...@redhat.com
---
hw/kdrive/linux/evdev.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/kdrive/linux/evdev.c b/hw/kdrive/linux/evdev.c
index 3797f09..c8fc5bc
From: Dave Airlie airl...@redhat.com
same as the xnest case.
Signed-off-by: Dave Airlie airl...@redhat.com
---
hw/kdrive/ephyr/ephyr.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/hw/kdrive/ephyr/ephyr.c b/hw/kdrive/ephyr/ephyr.c
index 7ebf1c2..67376cc 100644
---
From: Dave Airlie airl...@redhat.com
Pointed out by coverity scan.
Signed-off-by: Dave Airlie airl...@redhat.com
Reviewed-by: Daniel Stone dan...@fooishbar.org
---
config/hal.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/config/hal.c b/config/hal.c
index
From: Dave Airlie airl...@redhat.com
Pointed out by coverity.
Signed-off-by: Dave Airlie airl...@redhat.com
---
Xext/xvdisp.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Xext/xvdisp.c b/Xext/xvdisp.c
index 364a90c..71bf722 100644
--- a/Xext/xvdisp.c
+++
From: Dave Airlie airl...@redhat.com
newPix could be leaked if AddResource failed.
pointed out by coverity scan.
Signed-off-by: Dave Airlie airl...@redhat.com
---
composite/compext.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/composite/compext.c
From: Dave Airlie airl...@redhat.com
pointed out by coverity scan.
Signed-off-by: Dave Airlie airl...@redhat.com
---
composite/compext.c |7 ++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/composite/compext.c b/composite/compext.c
index 01bd578..16daf23 100644
---
From: Dave Airlie airl...@redhat.com
These get used at the end of the function in a calculation,
even the result isn't used its not pretty.
pointed out by coverity.
Signed-off-by: Dave Airlie airl...@redhat.com
---
exa/exa_render.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
On Wed, Oct 19, 2011 at 05:26:09PM -0700, Keith Packard wrote:
On Sun, 9 Oct 2011 01:11:04 +0300, Ville Syrjala syrj...@sci.fi wrote:
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=22566
Merged.
e4787ec..a5266dc master - master
Cheers.
Jeremy, I assume you want to cherry-pick
Hi,
On Thu, Oct 20, 2011 at 04:25:41PM +1000, Peter Hutterer wrote:
@@ -482,6 +483,41 @@ appendValuatorInfo(DeviceChangedEvent *dce,
xXIValuatorInfo *info, int axisnumbe
}
static int
+appendScrollInfo(DeviceChangedEvent *dce, xXIScrollInfo *info, int
axisnumber)
+{
+if
On Thu, Oct 20, 2011 at 04:25:42PM +1000, Peter Hutterer wrote:
Instead of device and master (and just using master), drop the master
argument and let the callers pass in the device the event is to be sent for.
No effective functional changes.
Signed-off-by: Peter Hutterer
On Thu, Oct 20, 2011 at 04:25:45PM +1000, Peter Hutterer wrote:
If a floating device changes, the master is NULL but we must still create a
DCE for it.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Reviewed-by: Daniel Stone dan...@fooishbar.org
Hi,
On Thu, Oct 20, 2011 at 04:25:46PM +1000, Peter Hutterer wrote:
@@ -1139,7 +1141,16 @@ SetScrollValuator(DeviceIntPtr dev, int axnum, enum
ScrollType type, double incr
ax-scroll.type = type;
ax-scroll.increment = increment;
ax-scroll.flags = flags;
-/* FIXME:
On Thu, Oct 20, 2011 at 04:25:43PM +1000, Peter Hutterer wrote:
No effective functional changes, prep work for future patches.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Reviewed-by: Daniel Stone dan...@fooishbar.org
___
Hi,
On Thu, Oct 20, 2011 at 01:05:28PM +1000, Peter Hutterer wrote:
Use the same struct for both InputOption and XF86OptionRec so we don't need
to convert to and fro the two in the config backends.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Reviewed-by: Dan Nicholson
On Thu, Oct 20, 2011 at 01:05:29PM +1000, Peter Hutterer wrote:
The former strdups for us. If the strdup fails we miss out on the
CorePointer option (default on anyway) and we're likely to fall over soon
anyway, so let's pretend this is the same behaviour.
Signed-off-by: Peter Hutterer
Hi,
On Thu, Oct 20, 2011 at 01:05:32PM +1000, Peter Hutterer wrote:
diff --git a/hw/xfree86/common/xf86Config.c b/hw/xfree86/common/xf86Config.c
index 96e98c1..cb4be42 100644
--- a/hw/xfree86/common/xf86Config.c
+++ b/hw/xfree86/common/xf86Config.c
@@ -1196,6 +1196,10 @@
On 20 October 2011 04:05, Peter Hutterer peter.hutte...@who-t.net wrote:
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Reviewed-by: Daniel Stone dan...@fooishbar.org
___
xorg-devel@lists.x.org: X.Org development
Archives:
On 20 October 2011 04:05, Peter Hutterer peter.hutte...@who-t.net wrote:
ptrveloc.c: In function 'QueryTrackers':
ptrveloc.c:598:34: warning: variable 'used_offset' set but not used
[-Wunused-but-set-variable]
used_offset is used, but only in the debugging code. Move the #if statement
to
On 20 October 2011 07:25, Peter Hutterer peter.hutte...@who-t.net wrote:
If we're sending the event for a given device, make sure the deviceid is
that of the device.
This allows callers to use the same DCE for slave and master without having
to fiddle the DCE's internal fields.
On 10/20/11 03:44, Dave Airlie wrote:
From: Dave Airlieairl...@redhat.com
Pointed out by coverity scan.
Signed-off-by: Dave Airlieairl...@redhat.com
---
hw/xfree86/common/xf86pciBus.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/xfree86/common/xf86pciBus.c
On 10/20/11 03:44, Dave Airlie wrote:
From: Dave Airlieairl...@redhat.com
pointed out by coverity.
Signed-off-by: Dave Airlieairl...@redhat.com
---
hw/xnest/Keyboard.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/hw/xnest/Keyboard.c b/hw/xnest/Keyboard.c
index
On 10/20/11 03:44, Dave Airlie wrote:
From: Dave Airlieairl...@redhat.com
pointed out by coverity scan.
Signed-off-by: Dave Airlieairl...@redhat.com
---
hw/kdrive/linux/evdev.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/kdrive/linux/evdev.c
On 10/20/11 03:44, Dave Airlie wrote:
From: Dave Airlieairl...@redhat.com
newPix could be leaked if AddResource failed.
pointed out by coverity scan.
Signed-off-by: Dave Airlieairl...@redhat.com
---
composite/compext.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff
On Thu, Oct 20, 2011 at 9:43 AM, Dave Airlie airl...@gmail.com wrote:
From: Dave Airlie airl...@redhat.com
If you started an X server with no connected outputs, we pick a default
1024x768 mode, however if you then ran an xvidmode using app against that
server it would segfault the server due
On Wed, Oct 19, 2011 at 05:01:45PM +0100, Dave Airlie wrote:
From: Dave Airlie airl...@redhat.com
This code had an off-by-one and would allow writing one past the end of
the callbacks array.
I think you mean reading one past the end? I don't see any bad pointer
writes here, though I'm only
On Thu, 20 Oct 2011 09:54:29 +0200, Jamey Sharp ja...@minilop.net wrote:
Non-text part: multipart/mixed
Non-text part: multipart/signed
This is also like Xgl, as I recall, in that Xgl was a large development
effort happening inside a company (Novell, in that case) and then being
dropped on the
On Thu, 20 Oct 2011 14:43:01 +0100, Dave Airlie airl...@gmail.com wrote:
+ scrn-modes = xf86ModesAdd(scrn-modes,
+xf86CVTMode(scrn-display-virtualX,
+scrn-display-virtualY,
+
On Thu, Oct 20, 2011 at 6:37 PM, Keith Packard kei...@keithp.com wrote:
On Thu, 20 Oct 2011 14:43:01 +0100, Dave Airlie airl...@gmail.com wrote:
+ scrn-modes = xf86ModesAdd(scrn-modes,
+ xf86CVTMode(scrn-display-virtualX,
+
Sorry I didn't catch this before it hit master, but:
On Mon, Oct 10, 2011 at 12:19:19 -0700, Jeremy Huddleston wrote:
diff --git a/hw/xnest/Events.c b/hw/xnest/Events.c
index 619427d..2399313 100644
--- a/hw/xnest/Events.c
+++ b/hw/xnest/Events.c
@@ -198,6 +198,8 @@ xnestCollectEvents(void)
On Oct 20, 2011, at 12:08, Julien Cristau wrote:
if (xnestParentWindow != (Window) 0
X.xdestroywindow.window == xnestParentWindow)
+CloseWellKnownConnections();
+OsCleanup(1);
exit (0);
That looks broken, don't you need braces around the if branch? Also I'm
not
On 10/19/11 23:45, Jamey Sharp wrote:
On Wed, Oct 19, 2011 at 10:47:17AM -0700, Jeremy Huddleston wrote:
I think we coddled the drivers enough with the current set of
just-deprecations. This is too trivial. I'll just go through and
make sure nobody is actually using it because drivers still
On 10/20/11 03:44, Dave Airlie wrote:
From: Dave Airlieairl...@redhat.com
pointed out by coverity scan.
Signed-off-by: Dave Airlieairl...@redhat.com
---
composite/compext.c |7 ++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/composite/compext.c
On 10/20/11 03:44, Dave Airlie wrote:
From: Dave Airlieairl...@redhat.com
These get used at the end of the function in a calculation,
even the result isn't used its not pretty.
I can't quite follow the second line of that comment - the xMask yMask
calculation results are passed to the
On 10/20/11 03:44, Dave Airlie wrote:
From: Dave Airlieairl...@redhat.com
Coverity scan pointed this out.
Drop unused randrp setup.
Signed-off-by: Dave Airlieairl...@redhat.com
---
hw/xfree86/modes/xf86RandR12.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git
We've deprecated keyboard a long time ago
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
hw/xfree86/doc/ddxDesign.xml |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/xfree86/doc/ddxDesign.xml b/hw/xfree86/doc/ddxDesign.xml
index a4baad5..0d5e952 100644
On Thu, Oct 20, 2011 at 02:17:57PM +0100, Daniel Stone wrote:
Hi,
On Thu, Oct 20, 2011 at 01:05:32PM +1000, Peter Hutterer wrote:
diff --git a/hw/xfree86/common/xf86Config.c b/hw/xfree86/common/xf86Config.c
index 96e98c1..cb4be42 100644
--- a/hw/xfree86/common/xf86Config.c
+++
On 10/20/11 03:44, Dave Airlie wrote:
From: Dave Airlieairl...@redhat.com
coverity scan pointed this out.
In some of its error cases AllocARGBCursor freed the bits passed in,
because it assigned them to the cursor and called FreeCursorBits, in
one case it didn't, if it hadn't done the
On 10/20/11 16:15, Peter Hutterer wrote:
We've deprecated keyboard a long time ago
Signed-off-by: Peter Huttererpeter.hutte...@who-t.net
---
hw/xfree86/doc/ddxDesign.xml |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/xfree86/doc/ddxDesign.xml
On Thu, Oct 20, 2011 at 02:03:25PM +0100, Daniel Stone wrote:
Hi,
On Thu, Oct 20, 2011 at 04:25:41PM +1000, Peter Hutterer wrote:
@@ -482,6 +483,41 @@ appendValuatorInfo(DeviceChangedEvent *dce,
xXIValuatorInfo *info, int axisnumbe
}
static int
Be consistent with other usages of touchid.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
XI2proto.h |2 +-
specs/XI2proto.txt |4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/XI2proto.h b/XI2proto.h
index 2460cf5..56df401 100644
---
On 10/20/2011 05:07 PM, Peter Hutterer wrote:
Be consistent with other usages of touchid.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Fine with me.
Reviewed-by: Chase Douglas chase.doug...@canonical.com
___
xorg-devel@lists.x.org: X.Org
61 matches
Mail list logo
