Re: [PATCH] ephyr: Repaint entire screen when colormap is updated

2014-02-06 Thread Eric Anholt
Keith Packard kei...@keithp.com writes: Eric Anholt e...@anholt.net writes: I expected DamageReportDamage() to be used instead, but this is safe because we're using DamageReportNone (and leaving the blockhandler to do our paint). I didn't want other root damage trackers to receive damage

Re: [PATCH] Stop defining GL_GLEXT_PROTOTYPES

2014-02-04 Thread Eric Anholt
Keith Packard kei...@keithp.com writes: It looks like GL_GLEXT_PROTOTYPES is just a trap for the unwary, causing glext.h to define a pile of functions which are also defined in gl.h. However, there is *one* function used in the server which is not defined in gl.h and is only defined in

Re: [PATCH] dri3: Don't enable the DRI3 extension unless some screen supports it

2014-02-03 Thread Eric Anholt
that only check for the extension and not for appropriate per-screen support. I don't think that's a real risk as DRI3 is only useful for systems with deep knowledge of the hardware. Reviewed-by: Eric Anholt e...@anholt.net pgpOxA4icIVRP.pgp Description: PGP signature

[PATCH 6/8] xephyr: Build support for rendering with glamor using a -glamor option.

2014-02-03 Thread Eric Anholt
Signed-off-by: Eric Anholt e...@anholt.net --- configure.ac | 3 + glamor/glamor.c| 11 ++ glamor/glamor.h| 2 + hw/kdrive/ephyr/Makefile.am| 20 ++- hw/kdrive/ephyr/ephyr.c| 36 +++-- hw/kdrive/ephyr/ephyr.h

[PATCH 4/8] glamor: Fix attempting to compile shaders with no active context.

2014-02-03 Thread Eric Anholt
Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/glamor/glamor_core.c b/glamor/glamor_core.c index 5246c98..5883809 100644 --- a/glamor/glamor_core.c +++ b/glamor/glamor_core.c @@ -215,6 +215,7

[PATCH 5/8] glamor: Promote the screen pixmap to a texture when it starts as MEMORY.

2014-02-03 Thread Eric Anholt
. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor.c | 17 + 1 file changed, 17 insertions(+) diff --git a/glamor/glamor.c b/glamor/glamor.c index 5947d7f..65fabc2 100644 --- a/glamor/glamor.c +++ b/glamor/glamor.c @@ -115,6 +115,23 @@ glamor_set_screen_pixmap

[PATCH 3/8] glamor: Put in a pluggable context switcher for GLX versus EGL.

2014-02-03 Thread Eric Anholt
was rather incestuous, along with pulling in xf86 dependencies to our dix code. The new code just initializes itself from the current state. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/Makefile.am| 2 ++ glamor/glamor.c | 8 +++-- glamor/glamor.h | 7 ++-- glamor

[PATCH 8/8] xephyr: Use GLX swap events to reduce repaints.

2014-02-03 Thread Eric Anholt
can use to avoid full screen repaints when the swap is a copy. Signed-off-by: Eric Anholt e...@anholt.net --- hw/kdrive/ephyr/ephyr.c| 1 + hw/kdrive/ephyr/ephyr_glamor_glx.c | 95 +- hw/kdrive/ephyr/ephyr_glamor_glx.h | 1 + hw/kdrive/ephyr/hostx.c

[PATCH 7/8] xephyr: Pass incoming XCB events to the Xlib event filter.

2014-02-03 Thread Eric Anholt
This is the same thing that Qt ended up doing to get DRI2's event mangling to happen despite using an XCB event loop. Signed-off-by: Eric Anholt e...@anholt.net --- hw/kdrive/ephyr/ephyr.c| 3 +++ hw/kdrive/ephyr/ephyr_glamor_glx.c | 39 ++ hw

[PATCH 2/8] glamor: Rename glamor_get/put_dispatch to glamor_get/put_context.

2014-02-03 Thread Eric Anholt
It used to be the thing that returned your dispatch table and happeend to set up the context, but now it just sets up the context. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor.c | 8 glamor/glamor_copyarea.c | 18 +- glamor/glamor_core.c

xephyr-glamor series

2014-02-03 Thread Eric Anholt
Additionally, there's a rendering bug when you run some Render-using applications (cairogears -xrender TRAP shows it off very well) that I think is fallback-related but I haven't quite tracked it down yet. You can see some fallback fixes in glamor-server I wrote while trying to fix this. This

[PATCH 02/15] glamor: Drop fixed function transformation matrix setup.

2014-02-03 Thread Eric Anholt
gl_ModelViewProjection and friends aren't used in our shaders, so this setup didn't do anything. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_pixmap.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/glamor/glamor_pixmap.c b/glamor/glamor_pixmap.c index 9fe2b2e..41d5f5a

[PATCH 03/15] glamor: yInverted is a boolean value, so use the Bool type.

2014-02-03 Thread Eric Anholt
Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor.c | 4 ++-- glamor/glamor_priv.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/glamor/glamor.c b/glamor/glamor.c index f1c71ea..ba2a1f4 100644 --- a/glamor/glamor.c +++ b/glamor/glamor.c @@ -308,10 +308,10

[PATCH 04/15] glamor: Drop a bunch of GLES2 ifdefs.

2014-02-03 Thread Eric Anholt
Now that we're using epoxy, we can write code using both desktop and ES symbols and decide what to use at runtime. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor.c | 40 +++- glamor/glamor_copyarea.c | 15 ++- glamor

[PATCH 14/15] glamor: Move the EGL DRI3 code to GLAMOR_HAS_GBM.

2014-02-03 Thread Eric Anholt
There's nothing dependent on the presence of DRI3 code in the server for this, but it does rely on GBM. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_egl.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/glamor/glamor_egl.c b/glamor/glamor_egl.c

[PATCH 01/15] glamor: Drop useless glEnable/glDisable(GL_TEXTURE_2D) calls.

2014-02-03 Thread Eric Anholt
Those calls are only for enabling texture handling in the fixed function pipeline, while everything we do is with shaders. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_copyarea.c | 4 glamor/glamor_pixmap.c| 6 -- glamor/glamor_putimage.c | 2 -- glamor

[PATCH 07/15] glamor: Unifdef the cache format indices.

2014-02-03 Thread Eric Anholt
We only ask for GL_RGB on desktop GL as far as I can see, but now if GLES2 did happen to ask for GL_RGB it would return a cache index instead of -1. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_priv.h | 4 glamor/glamor_utils.h | 18 ++ 2 files changed, 2

[PATCH 15/15] xephyr: Allow initializing glamor with gles2 (on GLX).

2014-02-03 Thread Eric Anholt
This should be useful for glamor development, so you can test both paths (which are significantly different, and apparently glamor_gradient.c was broken on GLES2 as of the import). Signed-off-by: Eric Anholt e...@anholt.net --- hw/kdrive/ephyr/ephyr_glamor_glx.c | 24 +++- hw

[PATCH 09/15] glamor: Unifdef the picture-format-to-format-and-type functions.

2014-02-03 Thread Eric Anholt
There's no way these should be in a header file, but I'll leave that cleanup until later. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_pixmap.c | 50 +- 1 file changed, 29 insertions(+), 21 deletions(-) diff --git a/glamor

[PATCH 10/15] glamor: Move shader precision stuff from build time to shader compile time.

2014-02-03 Thread Eric Anholt
This is the last desktop-versus-ES2 build ifdef in core glamor. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_priv.h | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/glamor/glamor_priv.h b/glamor/glamor_priv.h index 81b46b6..e28a021 100644 --- a/glamor

[PATCH 11/15] glamor: Fix typo in setting v_position's attrib location.

2014-02-03 Thread Eric Anholt
Assuming it was the first attribute assigned by the GL, it would have ended up with location 0 anyway. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_gradient.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/glamor/glamor_gradient.c b/glamor/glamor_gradient.c

[PATCH 08/15] glamor: Move glamor_get_tex_format_type_from_pictformat to a .c file.

2014-02-03 Thread Eric Anholt
A pair of 150 lines of inlined switch statements in a header file is crazy. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_pixmap.c | 303 + glamor/glamor_utils.h | 303 - 2 files

[PATCH 12/15] glamor: Don't bother keeping references to shader stages for gradients.

2014-02-03 Thread Eric Anholt
They never get reattached to any other program, so saving them to unreference later is a waste of code. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_gradient.c | 88 glamor/glamor_priv.h | 9 - 2 files changed, 6

[PATCH 05/15] glamor: Add a screen argument to drop an ifdef from glamor_set_alu().

2014-02-03 Thread Eric Anholt
Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_copyarea.c | 7 --- glamor/glamor_fill.c | 4 ++-- glamor/glamor_pixmap.c | 17 +++-- glamor/glamor_priv.h | 2 +- glamor/glamor_tile.c | 4 ++-- 5 files changed, 20 insertions(+), 14 deletions(-) diff

[PATCH 06/15] glamor: Pass pixmaps around to unifdef glamor_iformat_for_depth().

2014-02-03 Thread Eric Anholt
Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor.c | 6 +++--- glamor/glamor_picture.c | 3 +-- glamor/glamor_pixmap.c | 4 ++-- glamor/glamor_utils.h | 26 -- 4 files changed, 18 insertions(+), 21 deletions(-) diff --git a/glamor/glamor.c b

[PATCH 13/15] glamor: Fix linking of the gradient shaders on GLES2.

2014-02-03 Thread Eric Anholt
GLES2 sensibly doesn't allow you to attach multiple shaders for the same stage to a single program. This means we have to attach the whole thing in one glShaderSource call. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_gradient.c | 68

Re: [PATCH 5/5] test: Fix compiler warning on 64-bit.

2014-02-03 Thread Eric Anholt
Mark Kettenis mark.kette...@xs4all.nl writes: From: Eric Anholt e...@anholt.net Date: Mon, 27 Jan 2014 11:36:09 -0800 We all know that XIDs are 32 bits, even if 32-bit headers call them long. --- test/hashtabletest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PULL] glamor-reformat

2014-01-27 Thread Eric Anholt
glapi awareness glamor: Use dix-config.h not project config.h Eric Anholt (14): glamor: Touch up some code so indent doesn't get confused. glamor: Apply x-indent.sh. glamor: Fix some mangling of shader strings by indent. glamor: Fix some indent damage of putting

[PATCH 5/5] test: Fix compiler warning on 64-bit.

2014-01-27 Thread Eric Anholt
We all know that XIDs are 32 bits, even if 32-bit headers call them long. --- test/hashtabletest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/hashtabletest.c b/test/hashtabletest.c index ceadfa7..a37dfb5 100644 --- a/test/hashtabletest.c +++ b/test/hashtabletest.c @@

[PATCH 4/5] xfree86: Fix a compiler warning on 64-bit.

2014-01-27 Thread Eric Anholt
asm/mtrr.h makes this an unsigned long on 32, but a u64 on 64. Cast it to a long to win. --- hw/xfree86/os-support/linux/lnx_video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/xfree86/os-support/linux/lnx_video.c b/hw/xfree86/os-support/linux/lnx_video.c index

[PATCH 1/5] glx: Stop relying on libGL ABI bugs for glGetCompressedTexImage().

2014-01-27 Thread Eric Anholt
In theory, the linux libGL ABI exposes just GL 1.2 plus GLX 1.3. But, thanks to libglapi, we're letting glGetCompressedTexImageARB() be exposed too. The GLX code was inappropriately relying on it by using GL_GLEXT_PROTOTYPES. --- glx/indirect_texture_compression.c | 8 ++-- 1 file changed,

[PATCH 2/5] glx: Reduce compiler warnings by not requesting GL extension prototypes.

2014-01-27 Thread Eric Anholt
They're not officially in the ABI, so you shouldn't use them anyway. --- glx/glxserver.h | 1 - 1 file changed, 1 deletion(-) diff --git a/glx/glxserver.h b/glx/glxserver.h index 7f36e5f..3f2ae35 100644 --- a/glx/glxserver.h +++ b/glx/glxserver.h @@ -46,7 +46,6 @@ #include resource.h #include

[PATCH 3/5] glx: Delete dead NV program string functions.

2014-01-27 Thread Eric Anholt
These have been throwing a compiler warning about missing prototypes, since the generated code to define the prototypes stopped being generated (possibly because the code was dead). --- glx/indirect_program.c | 22 -- 1 file changed, 22 deletions(-) diff --git

[PATCH] glamor: Disable definitions of GL extension prototypes to avoid warnings.

2014-01-24 Thread Eric Anholt
We're not using the extension prototypes, since you have to dlsym them anyway. Disabling their definitions prevents them from being defined twice (once by gl.h, once by glext.h). Signed-off-by: Eric Anholt e...@anholt.net --- I was about to send the pull req for the glamor reformat and initial

Re: warning-fixes review.

2014-01-23 Thread Eric Anholt
Keith Packard kei...@keithp.com writes: Eric Anholt e...@anholt.net writes: Patch 1 - NAK due to changes to DO NOT EDIT files. I've removed the changes to indirect_dispatch_swap.c and indirect_program.c Yeah, any suggestions on how we can fix the generated files to not have warnings? Fix

Re: [PATCH:libXfont 1/3] Correct comment in configure.ac about scalable font support

2014-01-22 Thread Eric Anholt
Alan Coopersmith alan.coopersm...@oracle.com writes: Bitstream Speedo support was removed in commit d50de26430c1a114a. All scalable font support now goes through FreeType, which can also handle some bitmap font formats as well. This series is: Reviewed-by: Eric Anholt e...@anholt.net

Re: [PATCH] inputproto: Allow library users to avoid having the 'Pointer' typedef declared

2014-01-22 Thread Eric Anholt
Keith Packard kei...@keithp.com writes: 'Pointer' collides with too many other application names, so stop using it locally and allow applications to avoid having it in the API. Some googling didn't find anyone using Pointer with a 'P', so: Reviewed-by: Eric Anholt e...@anholt.net

Re: [PATCH] glx: Remove left-over glthread.c

2014-01-22 Thread Eric Anholt
Jackson a...@redhat.com Reviewed-by: Eric Anholt e...@anholt.net pgpjxbem0xQwT.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg

Re: [PATCH 10/15] glamor: Disable the XV code for now.

2014-01-16 Thread Eric Anholt
Michel Dänzer mic...@daenzer.net writes: On Fre, 2014-01-10 at 09:26 +0800, Eric Anholt wrote: We're going to want to make this DIX code instead of XF86 if at all possible, but for now just disable it so we can work on the rest of the build. The radeon driver can't really use the in-tree

Re: [PATCH 0/4] fb support for 8bpp bitmaps

2014-01-15 Thread Eric Anholt
Michel Dänzer mic...@daenzer.net writes: On Die, 2014-01-14 at 05:34 -0800, Keith Packard wrote: Michel Dänzer mic...@daenzer.net writes: Didn't SNA prove though that sharing the same pixel storage for GPU and CPU doesn't give the overall best performance even with Intel GPUs? It

glamor cleanup series: reindent and connect to the build

2014-01-09 Thread Eric Anholt
Here's my first patch series for review on glamor -- mostly boring stuff just trying to get things to a consistent style with the rest of the server. The end result is a building module we can start doing interesting things to, with no compiler warnings on my system. Note that x-indent.sh did

[PATCH 08/15] glamor/egl: Remove glapi awareness

2014-01-09 Thread Eric Anholt
Signed-off-by: Eric Anholt e...@anholt.net Reviewed-by: Eric Anholt e...@anholt.net --- glamor/Makefile.am| 3 +- glamor/glamor_egl.c | 24 ++- glamor/glamor_utils.h | 15 --- glamor/glapi.h| 116 -- 4 files changed, 4

[PATCH 07/15] glamor: Remove compat code for building out of tree.

2014-01-09 Thread Eric Anholt
Signed-off-by: Eric Anholt e...@anholt.net --- glamor/Makefile.am | 1 - glamor/compat-api.h | 107 --- glamor/glamor.c | 4 +- glamor/glamor.h | 4 -- glamor/glamor_egl.c | 16 ++-- glamor/glamor_priv.h | 1 - 6 files

[PATCH 03/15] glamor: Fix some mangling of shader strings by indent.

2014-01-09 Thread Eric Anholt
Signed-off-by: Eric Anholt e...@anholt.net --- Once again, git-send-email refused due to x-indent's output being too long, so this isn't a real patch because I replaced that line with THE STRINGS BELOW ALL SMASHED INTO ONE LINE. Look at the git tree for real patches. glamor/glamor_core.c

[PATCH 11/15] glamor: Drop xfree86 dependencies from this dix module.

2014-01-09 Thread Eric Anholt
Signed-off-by: Eric Anholt e...@anholt.net --- glamor/Makefile.am | 2 +- glamor/glamor.h| 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/glamor/Makefile.am b/glamor/Makefile.am index 15a8b74..90d80a7 100644 --- a/glamor/Makefile.am +++ b/glamor/Makefile.am @@ -6,7

[PATCH 01/15] glamor: Touch up some code so indent doesn't get confused.

2014-01-09 Thread Eric Anholt
Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_pixmap.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/glamor/glamor_pixmap.c b/glamor/glamor_pixmap.c index 84694ec..be7aa3d 100644 --- a/glamor/glamor_pixmap.c +++ b/glamor/glamor_pixmap.c @@ -248,7

[PATCH 04/15] glamor: Fix some indent damage of putting a ' ' after the '*' for pointers.

2014-01-09 Thread Eric Anholt
Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor.c | 4 +-- glamor/glamor.h | 16 - glamor/glamor_addtraps.c| 6 ++-- glamor/glamor_fbo.c | 32 +- glamor/glamor_glyphblt.c| 12 +++ glamor/glamor_glyphs.c | 30

[PATCH 12/15] glamor: Silence warnings for non-debug builds.

2014-01-09 Thread Eric Anholt
Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_getspans.c | 1 + glamor/glamor_render.c | 5 ++--- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/glamor/glamor_getspans.c b/glamor/glamor_getspans.c index afb76f6..ff58725 100644 --- a/glamor/glamor_getspans.c +++ b

[PATCH 02/15] glamor: Apply x-indent.sh.

2014-01-09 Thread Eric Anholt
Signed-off-by: Eric Anholt e...@anholt.net --- I've entirely trimmed this patch -- it was strictly applying x-indent.sh with no other changes, and the next patches are fixups that follow it. I was going to just send it out, but git-send-email fatal errored because one of the lines was too long

[PATCH 10/15] glamor: Disable the XV code for now.

2014-01-09 Thread Eric Anholt
We're going to want to make this DIX code instead of XF86 if at all possible, but for now just disable it so we can work on the rest of the build. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor.h| 2 ++ glamor/glamor_xv.c | 2 ++ 2 files changed, 4 insertions(+) diff --git

[PATCH 06/15] glamor: Remove copy of sna's compiler.h

2014-01-09 Thread Eric Anholt
From: Adam Jackson a...@redhat.com Xfuncproto.h has equivalents for these already. v2: Adjust a couple more likelies after the rebase (anholt) Signed-off-by: Adam Jackson a...@redhat.com Signed-off-by: Eric Anholt e...@anholt.net Reviewed-by: Eric Anholt e...@anholt.net --- glamor/Makefile.am

[PATCH 15/15] glamor: Remove more out-of-tree compat code.

2014-01-09 Thread Eric Anholt
Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_priv.h | 13 - 1 file changed, 13 deletions(-) diff --git a/glamor/glamor_priv.h b/glamor/glamor_priv.h index 9f0c558..9bd88e0 100644 --- a/glamor/glamor_priv.h +++ b/glamor/glamor_priv.h @@ -56,19 +56,6 @@ #include

[PATCH 05/15] glamor: Fix up some indentation damage on header prototypes.

2014-01-09 Thread Eric Anholt
Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_priv.h | 292 +-- 1 file changed, 118 insertions(+), 174 deletions(-) diff --git a/glamor/glamor_priv.h b/glamor/glamor_priv.h index 96fb404..d4f5371 100644 --- a/glamor/glamor_priv.h

[PATCH 14/15] glamor: Remove an extra copy of RegionNil().

2014-01-09 Thread Eric Anholt
Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_compositerects.c | 4 ++-- glamor/glamor_utils.h | 6 -- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/glamor/glamor_compositerects.c b/glamor/glamor_compositerects.c index 967e228..3b6b2ed 100644

[PATCH 09/15] glamor: Use dix-config.h not project config.h

2014-01-09 Thread Eric Anholt
From: Adam Jackson a...@redhat.com v2: Also edit the one in glamor_egl.c (by anholt) v3: Also edit the one in glamor_eglmodule.c (by anholt) Signed-off-by: Adam Jackson a...@redhat.com Signed-off-by: Eric Anholt e...@anholt.net Reviewed-by: Eric Anholt e...@anholt.net --- glamor/glamor_egl.c

[PATCH 13/15] glamor: Hook the module back up to the build.

2014-01-09 Thread Eric Anholt
For now we're just building an uninstalled library. The extra EGL stubs are required so that we can get the DIX building and usable without pulling in the xf86 DDX code in glamor_egl.c. Signed-off-by: Eric Anholt e...@anholt.net --- Makefile.am | 6 + configure.ac

[PULL] glamor import

2013-12-30 Thread Eric Anholt
König (1): Use GBM_LIBS and GBM_CFLAGS Dave Airlie (5): glamor: fix make distcheck part 1 glamor: add compiler.h glamor_utils: fix unlikely define use glamor: add initial Xv support glamor: fix leak in xv code. Eric Anholt (102): Add build infrastructure

[PULL] glx loader unifdeffing.

2013-12-30 Thread Eric Anholt
to fetch changes up to 295d41fa2aa97b74c1b9ffd7ef4ccf52f3e97dde: glx: unifdef swrast dri_interface.h values from Mesa 7.1. (2013-12-30 23:10:34 -0800) Eric Anholt (2): glx: unifdef for DRI2 dri_interface.h things in mesa 9.2

Re: [PATCH 01/10] Replace 'pointer' type with 'void *'

2013-12-29 Thread Eric Anholt
caught a few of the code bugs present. With all of these changes, this patch is: Reviewed-by: Eric Anholt e...@anholt.net diff --git a/Xext/hashtable.h b/Xext/hashtable.h index 8a65732..780d5d2 100644 --- a/Xext/hashtable.h +++ b/Xext/hashtable.h @@ -55,27 +55,27 @@ extern _X_EXPORT HashTable

[PATCH 2/2] glx: unifdef swrast dri_interface.h values from Mesa 7.1.

2013-12-16 Thread Eric Anholt
We can't remove all the ifdefs (__DRI_TEX_BUFFER_VERSION) because configure.ac is only checking for that version of Mesa in the absence of dri2. --- glx/glxdriswrast.c | 25 + 1 file changed, 1 insertion(+), 24 deletions(-) diff --git a/glx/glxdriswrast.c

[PATCH 1/2] glx: unifdef for DRI2 dri_interface.h things in mesa 9.2.

2013-12-16 Thread Eric Anholt
Thanks to configure.ac's check, we know that we have a new enough dri_interface.h that we don't need to conditionalize all this code. --- glx/glxdri2.c | 59 --- 1 file changed, 59 deletions(-) diff --git a/glx/glxdri2.c b/glx/glxdri2.c

Re: [PATCH] glx: Add null pointer protection to __glGetProcAddress

2013-12-10 Thread Eric Anholt
) An ErrorF when returning NoopDDA to warn that we're papering over a bug in implementing some function would be pretty nice. Either way, Reviewed-by: Eric Anholt e...@anholt.net pgppr2J9Bj6GK.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH] present: Send GLX_BufferSwapComplete events from present extension

2013-11-25 Thread Eric Anholt
it to matter in practice (I expect that the swap-requesting client using this GLX extension is also the drawable-creating one), and either choice seems wrong compared to send the event to everyone listening for the event on this drawable. That would be a separate change, anyway. Reviewed-by: Eric

Re: [PATCH] hw/xfree86: Make strings in DriverRec and ScrnInfoRec const

2013-11-15 Thread Eric Anholt
Keith Packard kei...@keithp.com writes: This avoids compiler warnings when initializing with string constants. Signed-off-by: Keith Packard kei...@keithp.com I've apparently misplaced my patch that did the same thing. Reviewed-by: Eric Anholt e...@anholt.net pgpf7MVcX5gyJ.pgp Description

Re: [PATCH] xfree86: Prefer fbdev to vesa

2013-11-15 Thread Eric Anholt
not and vesa will kick in anyway. Reviewed-by: Eric Anholt e...@anholt.net pgp_byZJGLpcI.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg

[PATCH 1/2] glx: Fix incorrect use of dri_interface.h version defines in extensions.

2013-11-14 Thread Eric Anholt
Those defines are so you can compile-time check do I have a dri_interface.h that defines this new field of the struct? You don't want the server to claim it implements the new struct just because you installed a new copy of Mesa. --- glx/glxdri2.c | 4 ++-- glx/glxdricommon.c | 2 +-

[PATCH 2/2] glx: Fix incorrect use of dri_interface.h version defines in driver probing.

2013-11-14 Thread Eric Anholt
If we extend __DRI_CORE or __DRI_SWRAST in dri_interface.h to allow a new version, it shouldn't make old server code retroactively require the new version from swrast drivers. Notably, new Mesa defines __DRI_SWRAST version 4, but we still want to be able to probe version 1 drivers, since we don't

[PATCH] Add correct dependency on libxtrans.

2013-11-06 Thread Eric Anholt
The 1.3 release is when the new FD passing bits landed. Signed-off-by: Eric Anholt e...@anholt.net --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 6925df8..32b7f64 100644 --- a/configure.ac +++ b/configure.ac @@ -806,7 +806,7

Re: [Xcb] [PATCH 5/7] Add event queue splitting

2013-11-06 Thread Eric Anholt
Uli Schlachter psyc...@znc.in writes: Hi, On 06.11.2013 20:34, Peter Harris wrote: On 2013-11-05 19:41, Keith Packard wrote: [...] diff --git a/src/xcb.h b/src/xcb.h index f7dc6af..f99e677 100644 --- a/src/xcb.h +++ b/src/xcb.h @@ -138,23 +138,6 @@ typedef struct { }

Re: [Xcb] [PATCH 5/7] Add event queue splitting

2013-11-06 Thread Eric Anholt
Peter Harris phar...@opentext.com writes: On 2013-11-05 19:41, Keith Packard wrote: This allows apps to peel off certain XGE events into separate queues for custom handling. Designed to support the Present extension Signed-off-by: Keith Packard kei...@keithp.com Re:

Re: [PATCH] Xext: Enable MIT-SHM FD-passing request definitions only when defined

2013-11-04 Thread Eric Anholt
Keith Packard kei...@keithp.com writes: Check to see if the new protocol headers are available and advertise appropriate version of the SHM extension I'd rather see the updated protocol headers just be required by configure.ac. pgpvnEZ5fpzFh.pgp Description: PGP signature

Re: [PATCH] glx: Remove DRI1 AIGLX

2013-10-22 Thread Eric Anholt
there's no EGL implemented for DRI1 drivers, this would already doom AIGLX on DRI1 (short of entirely forking the GLX implementation, which I'm not enthusiastic about). I think you also want to drop the DRI1 checks for AIGLX and AIGLX_DRI_LOADER in configure.ac. If you do: Reviewed-by: Eric Anholt

[PATCH] glx: Add support for the new DRI loader entrypoint.

2013-10-22 Thread Eric Anholt
. v2: typo fix in the comment Signed-off-by: Eric Anholt e...@anholt.net Reviewed-by: Adam Jackson a...@redhat.com --- glx/glxdricommon.c | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/glx/glxdricommon.c b/glx/glxdricommon.c index b027f24..0ab3e30

Re: [PATCH 2/2] ephyr: Ensure stride of private framebuffer is multiple of 4

2013-10-22 Thread Eric Anholt
stride = (width * Bpp + 0x3) ~0x3; + trailing whitespace +*bytes_per_line = stride; *bits_per_pixel = scrpriv-server_depth; Other than the whitespace, these two patches are: Reviewed-by: Eric Anholt e...@anholt.net pgpGPTqqNhHbn.pgp Description: PGP signature

[PATCH] glx: Add support for the new DRI loader entrypoint.

2013-10-11 Thread Eric Anholt
This is going to be exposed (and not the old entrypoint) for some DRI drivers once the megadrivers series lands, and the plan is to eventually transition all drivers to that. Hopefully this is unobtrusive enough to merge to stable X servers so that they can be compatible with new Mesa versions.

Re: [PATCH] loader: Use RTLD_DEEPBIND if available to prefer local symbols

2013-10-04 Thread Eric Anholt
Keith Packard kei...@keithp.com writes: Egbert Eich e...@freedesktop.org writes: If there are namespace clashes among different drivers it would be preferrable if each driver used its local symbols. Use the RTLD_DEEPBIND if available to achive this. Eric and Adam are doing a lot of work in

Re: [PATCH 2/3] glx: Fix memory leak in context garbage collection

2013-09-30 Thread Eric Anholt
, so that we have a back-pointer to chase when walking the list of contexts when ClientStateGone happens. Patch 1/3 is: Reviewed-by: Eric Anholt e...@anholt.net But I'm lost on this one. loseCurrent is just -core-unbindContext, which is mesa's dri_util.c dereferencing the drawables and calling

Re: [PATCH RESEND xserver 3/6] Xorg binary: use install-exec-hook rather than install-exec-local

2013-09-28 Thread Eric Anholt
, it is possible to perform post-installation modifications using an install hook. With the -local targets, there is no particular guarantee of execution order; typically, they are run early, but with parallel make, there is no way to be sure of that. Reviewed-by: Eric Anholt e...@anholt.net

Re: [PATCH 05/17] ephyr: Move event processing into ephyr.c.

2013-09-03 Thread Eric Anholt
Julien Cristau jcris...@debian.org writes: On Mon, Aug 26, 2013 at 13:26:11 -0700, Eric Anholt wrote: -struct EphyrHostXEvent { -EphyrHostXEventType type; -union { -struct mouse_motion { -int x; -int y; -int screen; -int

Re: [PATCH 09/17] Remove the host/server split for XV attributes.

2013-09-03 Thread Eric Anholt
Julien Cristau jcris...@debian.org writes: On Mon, Aug 26, 2013 at 13:26:15 -0700, Eric Anholt wrote: --- hw/kdrive/ephyr/ephyrhostvideo.c | 107 --- hw/kdrive/ephyr/ephyrhostvideo.h | 19 -- hw/kdrive/ephyr/ephyrvideo.c | 133

Re: [PATCH 02/17] ephyr: Expose a single function for detecting extensions.

2013-09-03 Thread Eric Anholt
Julien Cristau jcris...@debian.org writes: On Mon, Aug 26, 2013 at 13:26:08 -0700, Eric Anholt wrote: Signed-off-by: Eric Anholt e...@anholt.net --- hw/kdrive/ephyr/ephyr.c | 15 ++- hw/kdrive/ephyr/ephyrdriext.c | 7 +-- hw/kdrive/ephyr/ephyrglxext.c | 3 ++- hw

Re: [PATCH 2/7] damage: Simplify DamageUnregister

2013-09-03 Thread Eric Anholt
Adam Jackson a...@redhat.com writes: You can only register one drawable on a given damage, so there's no reason to require the caller to specify the drawable, the damage is enough. The implementation would do something fairly horrible if you _did_ pass mismatched drawable and damage, so

Re: [PATCH 7/7] damageext: Xineramify

2013-09-03 Thread Eric Anholt
, 3, 4, and 6 are: Reviewed-by: Eric Anholt e...@anholt.net pgptHnR7JyAqT.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

[PULL] xephyr xcb conversion, code deletion, and bugfixes

2013-09-03 Thread Eric Anholt
changes up to abc2bfca16adcd1e5657d4ce54f4e1335d5ed53f: kdrive: initialize GLX for xephyr (2013-09-03 14:35:39 -0700) Eric Anholt (20): ephyr: Drop dead ephyrHostAtomToLocal code. ephyr: Expose a single function

[PATCH 03/19] Xephyr: use xcb-shape instead of XShape*

2013-08-26 Thread Eric Anholt
From: Julien Cristau jcris...@debian.org Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net Reviewed-by: Eric Anholt e...@anholt.net Signed-off-by: Julien Cristau jcris...@debian.org --- hw/kdrive/ephyr/hostx.c | 40 +++- 1 file changed, 27 insertions(+), 13

[PATCH 01/19] Xephyr: stop loading the host's keymap

2013-08-26 Thread Eric Anholt
From: Julien Cristau jcris...@debian.org This isn't used anywhere. v2: Rebase to the top of the patch series (anholt) Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net (v1) Signed-off-by: Julien Cristau jcris...@debian.org Signed-off-by: Eric Anholt e...@anholt.net --- hw/kdrive/ephyr

[PATCH 04/19] Xephyr: no need for XDisplayKeycodes

2013-08-26 Thread Eric Anholt
From: Julien Cristau jcris...@debian.org Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net Reviewed-by: Eric Anholt e...@anholt.net Signed-off-by: Julien Cristau jcris...@debian.org --- hw/kdrive/ephyr/hostx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/kdrive

[PATCH 05/19] Xephyr: xcb-ify pointer/keyboard grab

2013-08-26 Thread Eric Anholt
From: Julien Cristau jcris...@debian.org Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net Reviewed-by: Eric Anholt e...@anholt.net Signed-off-by: Julien Cristau jcris...@debian.org --- hw/kdrive/ephyr/hostx.c | 45 - 1 file changed, 32 insertions

[PATCH 02/19] Xephyr: start converting hostx.c over to xcb

2013-08-26 Thread Eric Anholt
From: Julien Cristau jcris...@debian.org v2: Dropped the hostx_load_keymap changes, now that that function is gutted (anholt). Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net (v1) Signed-off-by: Julien Cristau jcris...@debian.org Signed-off-by: Eric Anholt e...@anholt.net

[PATCH 07/19] Xephyr: delete unused proxy code

2013-08-26 Thread Eric Anholt
From: Julien Cristau jcris...@debian.org Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net Reviewed-by: Eric Anholt e...@anholt.net Signed-off-by: Julien Cristau jcris...@debian.org --- hw/kdrive/ephyr/ephyrhostproxy.c | 91 --- hw/kdrive/ephyr/ephyrhostproxy.h

[PATCH 09/19] Xephyr: replace XKeycodeToKeysym with xcb-keysyms

2013-08-26 Thread Eric Anholt
From: Julien Cristau jcris...@debian.org Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net Reviewed-by: Eric Anholt e...@anholt.net Signed-off-by: Julien Cristau jcris...@debian.org --- configure.ac| 2 +- hw/kdrive/ephyr/hostx.c | 13 - 2 files changed, 9 insertions

[PATCH 06/19] Xephyr: xcb-ify visual list construction

2013-08-26 Thread Eric Anholt
From: Julien Cristau jcris...@debian.org Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net Reviewed-by: Eric Anholt e...@anholt.net Signed-off-by: Julien Cristau jcris...@debian.org --- hw/kdrive/ephyr/hostx.c | 59 +++-- 1 file changed, 33

[PATCH 11/19] Xephyr: some more hostx.c xcb-ification

2013-08-26 Thread Eric Anholt
From: Julien Cristau jcris...@debian.org Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net Reviewed-by: Eric Anholt e...@anholt.net Signed-off-by: Julien Cristau jcris...@debian.org --- hw/kdrive/ephyr/hostx.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw

[PATCH 12/19] Xephyr: use xcb for event handling

2013-08-26 Thread Eric Anholt
Gusarov dotted...@dottedmag.net (v1) Signed-off-by: Julien Cristau jcris...@debian.org Signed-off-by: Eric Anholt e...@anholt.net --- hw/kdrive/ephyr/hostx.c | 284 ++-- 1 file changed, 155 insertions(+), 129 deletions(-) diff --git a/hw/kdrive/ephyr

[PATCH 10/19] Xephyr: move HostX.visual to xcb

2013-08-26 Thread Eric Anholt
From: Julien Cristau jcris...@debian.org Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net Reviewed-by: Eric Anholt e...@anholt.net Signed-off-by: Julien Cristau jcris...@debian.org --- hw/kdrive/ephyr/hostx.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw

[PATCH 18/19] Xephyr: handle errors in event loop

2013-08-26 Thread Eric Anholt
From: Julien Cristau jcris...@debian.org Signed-off-by: Julien Cristau jcris...@debian.org Reviewed-by: Eric Anholt e...@anholt.net Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net --- hw/kdrive/ephyr/hostx.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/hw/kdrive

[PATCH 17/19] Xephyr: drop remaining Xlib dependency

2013-08-26 Thread Eric Anholt
From: Julien Cristau jcris...@debian.org Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net Reviewed-by: Eric Anholt e...@anholt.net Signed-off-by: Julien Cristau jcris...@debian.org --- configure.ac| 4 ++-- hw/kdrive/ephyr/hostx.c | 64

[PATCH 19/19] Xephyr: we're not using Xlib anymore, no need to undef _XSERVER64

2013-08-26 Thread Eric Anholt
From: Julien Cristau jcris...@debian.org Drop obsolete comments about interaction between Xlib code and that macro, and stop undefining it. Signed-off-by: Julien Cristau jcris...@debian.org Reviewed-by: Eric Anholt e...@anholt.net --- hw/kdrive/ephyr/ephyrhostglx.c | 11 --- hw/kdrive

[PATCH 08/19] Xephyr: delete unused hostx_get_extension_info function

2013-08-26 Thread Eric Anholt
From: Julien Cristau jcris...@debian.org v2: Also remove the prototype (anholt) Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net (v1) Signed-off-by: Julien Cristau jcris...@debian.org Signed-off-by: Eric Anholt e...@anholt.net --- hw/kdrive/ephyr/hostx.c | 15 --- hw/kdrive

[PATCH 16/19] Xephyr: move glx code to xcb

2013-08-26 Thread Eric Anholt
From: Julien Cristau jcris...@debian.org v2: Rebase on master, notably adding XCB for X_GLXvop_MakeCurrentReadSGI (anholt). Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net (v1) Signed-off-by: Julien Cristau jcris...@debian.org Signed-off-by: Eric Anholt e...@anholt.net --- hw/kdrive

<    5   6   7   8   9   10   11   >