Re: [PATCH modular 01/15] jhbuild: Clean up formatting of xorg.modules

2011-03-08 Thread Dirk Wallenstein
On Sun, Mar 06, 2011 at 09:29:46AM -0800, Dan Nicholson wrote: Signed-off-by: Dan Nicholson dbn.li...@gmail.com --- xorg.modules | 748 +++--- 1 files changed, 555 insertions(+), 193 deletions(-) Reviewed-by: Dirk Wallenstein

Re: [PATCH modular 02/15] jhbuild: Use git.freedesktop.org as default repository

2011-03-08 Thread Dirk Wallenstein
On Sun, Mar 06, 2011 at 09:29:47AM -0800, Dan Nicholson wrote: Since all the modules use fdo's git, the moduleset can be a lot cleaner. Signed-off-by: Dan Nicholson dbn.li...@gmail.com --- xorg.modules | 551 +++-- 1 files changed, 184

Re: [PATCH modular 03/15] jhbuild: Remove duplicate xtrans module

2011-03-08 Thread Dirk Wallenstein
On Sun, Mar 06, 2011 at 09:29:48AM -0800, Dan Nicholson wrote: All the other modules depend on the one with the libxtrans id. Signed-off-by: Dan Nicholson dbn.li...@gmail.com --- xorg.modules |5 - 1 files changed, 0 insertions(+), 5 deletions(-) Reviewed-by: Dirk Wallenstein

Re: [PATCH modular 07/15] jhbuild: No xserver DDXs require xkbui anymore

2011-03-08 Thread Dirk Wallenstein
On Sun, Mar 06, 2011 at 09:29:52AM -0800, Dan Nicholson wrote: Signed-off-by: Dan Nicholson dbn.li...@gmail.com --- xorg.modules |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/xorg.modules b/xorg.modules index 3976837..052f044 100644 --- a/xorg.modules +++

Re: [PATCH modular 08/15] jhbuild: Reorder and rename font modules sanely

2011-03-08 Thread Dirk Wallenstein
On Sun, Mar 06, 2011 at 09:29:53AM -0800, Dan Nicholson wrote: The font modules seemed to be in a random order and had inconsistent names. adobe-75dpi corresponds to the tarball font-adobe-75dpi, yet fonts-cursor corresponds to the tarball font-cursor-misc. Instead, the tarball names will be

Re: [PATCH modular 09/15] jhbuild: Add definitions for remaining font modules

2011-03-08 Thread Dirk Wallenstein
On Sun, Mar 06, 2011 at 09:29:54AM -0800, Dan Nicholson wrote: The rest of the X.Org font modules aren't built as part of the xorg-fonts metamodule, but they should be buildable from jhbuild. Signed-off-by: Dan Nicholson dbn.li...@gmail.com --- xorg.modules | 264

Re: [PATCH modular 11/15] jhbuild: Group external modules at top of moduleset

2011-03-08 Thread Dirk Wallenstein
On Sun, Mar 06, 2011 at 09:29:56AM -0800, Dan Nicholson wrote: A few of the non-X.Org modules such as pixman and libdrm were mixed in with the X.Org libraries. Instead, they should be at the top of the moduleset with the rest of the external modules such as fontconfig. This also adds

Re: [PATCH modular 12/15] jhbuild: Don't build broken impact driver

2011-03-08 Thread Dirk Wallenstein
On Sun, Mar 06, 2011 at 09:29:57AM -0800, Dan Nicholson wrote: xf86-video-impact has been broken for a while and isn't built by build.sh. Move it to the unmaintained metamodule until someone cares. Signed-off-by: Dan Nicholson dbn.li...@gmail.com --- xorg.modules |2 +- 1 files

Re: [PATCH] Xi: fix XI2 passive grab reply length calculation

2011-03-08 Thread Julien Cristau
On Tue, Mar 8, 2011 at 14:44:02 +1000, Peter Hutterer wrote: If modifiers failed, the reply length was 4 bytes too short. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- Xi/xipassivegrab.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v2 evdev 0/3] Memory leak fixes.

2011-03-08 Thread Rami Ylimäki
v2: XKB options are now released with XkbFreeRMLVOSet. The first version of these patches assigned a dynamically allocated device filename to a const pointer. Calling free with this pointer causes a warning, but this warning was suppressed by casting its constness away when calling free. The

[PATCH v2 evdev 1/3] Release leaked XKB options on input device disconnect.

2011-03-08 Thread Rami Ylimäki
Currently the XKB options duplicated in EvdevAddKeyClass are never released. For example, connecting and disconnecting a bluetooth keyboard repeatedly causes a steadily growing memory leak. Signed-off-by: Rami Ylimäki rami.ylim...@vincit.fi Reviewed-by: Erkki Seppälä erkki.sepp...@vincit.fi ---

[PATCH v2 evdev 2/3] Release leaked device identifier on input device disconnect.

2011-03-08 Thread Rami Ylimäki
Signed-off-by: Rami Ylimäki rami.ylim...@vincit.fi Reviewed-by: Erkki Seppälä erkki.sepp...@vincit.fi --- src/evdev.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index 18b7246..db62375 100644 --- a/src/evdev.c +++ b/src/evdev.c @@ -2170,6

[PATCH v2 evdev 3/3] Remove constness of device filename to avoid warning when freed.

2011-03-08 Thread Rami Ylimäki
A warning from free() can be avoided by casting the constness away from its argument pointer or by not declaring the pointer as const in the first place. Signed-off-by: Rami Ylimäki rami.ylim...@vincit.fi --- src/evdev.c |2 +- src/evdev.h |2 +- 2 files changed, 2 insertions(+), 2

[PATCH] xfree86/common: Removed a configScreen leak when conf_screen is NULL

2011-03-08 Thread Erkki Seppälä
configScreen used a dynamically allocated buffer for XF86ConfScreenRec when conf_screen argument was NULL. This pointer was never stored anywhere, nor was it released, so this patch makes the function use automatically allocated storage in that situation. Reviewed-by: Rami Ylimäki

[PATCH] xfree86/modes: Fixed memory leak in xf86InitialConfiguration

2011-03-08 Thread Erkki Seppälä
There were two memory leaks in the function: one was the lack of free for enabled, the other was the full lack of releasing anything when configuration was too small. The first issue was fixed by adding the missing free, the other was addressed by replacing the duplicate memory releasing sequences

Re: [PATCH:libXt] Bug 34715: XtAppMainLoop doesn't work without a Display

2011-03-08 Thread walter harms
Am 07.03.2011 22:19, schrieb Alan Coopersmith: On 03/ 7/11 03:00 AM, walter harms wrote: Am 06.03.2011 21:53, schrieb Alan Coopersmith: From: Jordan Hayes jor...@bitway.com https://bugs.freedesktop.org/show_bug.cgi?id=34715 XtAppNextEvent() doesn't return until there's an actual XEvent

Re: [PATCH:libXt 3/3] Convert ALLOCATE_LOCAL + sprintf to XtAsprintf

2011-03-08 Thread Cyril Brulebois
Alan Coopersmith alan.coopersm...@oracle.com (07/03/2011): Perhaps a difference in the setting of $HOME or one of the other environment variables that GetRootDirName checks for the homedir? Indeed, '/' when starting from init, '/root' when starting later as root. I tried unsetting a few

Re: [PATCH modular 15/15] release.sh: Update jhbuild moduleset with --moduleset

2011-03-08 Thread Dan Nicholson
On Tue, Mar 8, 2011 at 1:11 AM, Dirk Wallenstein hals...@t-online.de wrote: On Sun, Mar 06, 2011 at 09:30:00AM -0800, Dan Nicholson wrote: In order to keep the katamari moduleset up to date with current tarball information, have release.sh update the file when new releases are made. This is

Re: [PATCH modular 01/15] jhbuild: Clean up formatting of xorg.modules

2011-03-08 Thread Dan Nicholson
On Tue, Mar 8, 2011 at 1:01 AM, Dirk Wallenstein hals...@t-online.de wrote: On Sun, Mar 06, 2011 at 09:29:46AM -0800, Dan Nicholson wrote: Signed-off-by: Dan Nicholson dbn.li...@gmail.com ---  xorg.modules |  748 +++---  1 files changed,

Re: [PATCH:libXt 3/3] Convert ALLOCATE_LOCAL + sprintf to XtAsprintf

2011-03-08 Thread walter harms
the only place where a change is, is CombineAppUserDefaults() can you set XAPPLRESDIR to see if both paths generate the same error ? re, wh Am 08.03.2011 12:45, schrieb Cyril Brulebois: Alan Coopersmith alan.coopersm...@oracle.com (07/03/2011): Perhaps a difference in the setting of $HOME

Re: [PATCH modular 05/15] jhbuild: Build openchrome driver from svn

2011-03-08 Thread Dan Nicholson
On Mon, Mar 7, 2011 at 7:05 AM, Dirk Wallenstein hals...@t-online.de wrote: On Mon, Mar 07, 2011 at 05:13:42AM -0800, Dan Nicholson wrote: On Mon, Mar 7, 2011 at 3:15 AM, Dirk Wallenstein hals...@t-online.de wrote: On Sun, Mar 06, 2011 at 09:29:50AM -0800, Dan Nicholson wrote: Since the

Re: [PATCH] xfree86: block signals between EnableDevice and first CheckMotion()

2011-03-08 Thread Daniel Stone
On Tue, Mar 08, 2011 at 11:18:50AM +1000, Peter Hutterer wrote: Devices usually enable SIGIO processing in EnableDevice. CheckMotion initialises the pointer sprite, sends Enter/Leave events, etc. This leaves us with a small window where events may be processed without the sprite or pointer

Re: [PATCH modular 15/15] release.sh: Update jhbuild moduleset with --moduleset

2011-03-08 Thread Dirk Wallenstein
On Tue, Mar 08, 2011 at 05:19:38AM -0800, Dan Nicholson wrote: On Tue, Mar 8, 2011 at 1:11 AM, Dirk Wallenstein hals...@t-online.de wrote: On Sun, Mar 06, 2011 at 09:30:00AM -0800, Dan Nicholson wrote: In order to keep the katamari moduleset up to date with current tarball information, have

[libXt:PATCH] XtAsprintf: Fix memory corruption.

2011-03-08 Thread Cyril Brulebois
Don't write the null terminator to a random place, this can trigger some segfault in XtOpenDisplay() and other annoyances. Debian Bug #617208 http://bugs.debian.org/617208 Signed-off-by: Cyril Brulebois k...@debian.org --- src/Alloc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

[PATCH 1/3] Absorb miTriFan() into CompositeTriFan()

2011-03-08 Thread Søren Sandmann
From: Søren Sandmann Pedersen s...@redhat.com There is no need to virtualize this function that nobody cares about. Signed-off-by: Soren Sandmann s...@redhat.com --- render/mitri.c | 21 - render/picture.c | 23 +++ 2 files changed, 19

[PATCH 2/3] Absorb miTriStrip() into CompositeTriStrip()

2011-03-08 Thread Søren Sandmann
From: Søren Sandmann Pedersen s...@redhat.com There is no need to virtualize this function that nobody cares about. Signed-off-by: Soren Sandmann s...@redhat.com --- render/mitri.c | 19 --- render/picture.c | 22 ++ 2 files changed, 18 insertions(+),

[PATCH 3/3] Remove TriStrip and TriFan from the picture screen

2011-03-08 Thread Søren Sandmann
From: Søren Sandmann Pedersen s...@redhat.com These functions no longer go through the screen vtable, so remove them and fix up the various wrappers. Signed-off-by: Soren Sandmann s...@redhat.com --- hw/dmx/dmx.h |2 - hw/dmx/dmxpict.c | 87

Re: [PATCH inputproto xi 2.1] Updates for pointer emulation and more touch device modes

2011-03-08 Thread Chase Douglas
On 03/08/2011 12:41 AM, Peter Hutterer wrote: On Wed, Mar 02, 2011 at 11:35:41AM -0500, Chase Douglas wrote: On 03/02/2011 05:58 AM, Daniel Stone wrote: On Tue, Feb 22, 2011 at 10:06:37AM -0500, Chase Douglas wrote: @@ -132,16 +133,16 @@ /* Device event flags (common) */ /* Device event

Re: [PATCH modular 13/15] jhbuild: Add moduleset with tarballs used for 7.6 katamari

2011-03-08 Thread Dirk Wallenstein
On Sun, Mar 06, 2011 at 09:29:58AM -0800, Dan Nicholson wrote: Add a moduleset for the 7.6 katamari based on xorg.modules and module-list.txt. This uses the module list from 7.6 with gzipped tarballs and sha1sums from announce emails (when available). Modules not included in the katamari

Re: [PATCH modular 13/15] jhbuild: Add moduleset with tarballs used for 7.6 katamari

2011-03-08 Thread Dan Nicholson
On Tue, Mar 8, 2011 at 7:25 AM, Dirk Wallenstein hals...@t-online.de wrote: On Sun, Mar 06, 2011 at 09:29:58AM -0800, Dan Nicholson wrote: Add a moduleset for the 7.6 katamari based on xorg.modules and module-list.txt. This uses the module list from 7.6 with gzipped tarballs and sha1sums from

Re: [PATCH] libXfixes v5: Pointer barriers

2011-03-08 Thread Adam Jackson
On Tue, 2011-03-08 at 11:13 +1000, Peter Hutterer wrote: diff --git a/include/X11/extensions/Xfixes.h b/include/X11/extensions/Xfixes.h index 0c00310..b39716a 100644 --- a/include/X11/extensions/Xfixes.h +++ b/include/X11/extensions/Xfixes.h @@ -1,5 +1,6 @@ /* * Copyright (c)

[PATCH 01/14] glx: Do something unpleasant to current drawable tracking

2011-03-08 Thread Adam Jackson
This is wrong, very wrong. Almost as wrong as what it replaces. Do not merge me, ever. --- glx/glxcmds.c |6 -- glx/glxext.c | 12 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/glx/glxcmds.c b/glx/glxcmds.c index 9b4bc9e..59df1c8 100644 ---

[PATCH 02/14] glx: Remove unused _glapi_get_proc_offset and friends

2011-03-08 Thread Adam Jackson
Reviewed-by: Julien Cristau jcris...@debian.org Signed-off-by: Adam Jackson a...@redhat.com --- glx/glapi.c | 107 --- glx/glapi.h | 19 -- 2 files changed, 0 insertions(+), 126 deletions(-) diff --git a/glx/glapi.c b/glx/glapi.c

[PATCH 00/14] GLX cleanup, round two

2011-03-08 Thread Adam Jackson
Largely a resend of the last series, but patches 1 and 14 are novel. The first is _wrong_, wrong wrong wrong, but it makes piglit actually runnable in indirect contexts so in the spirit of showing one's work it's included. I don't know how I'm going to fix that particular issue yet, but I

[PATCH 03/14] glx: unifdef SOLARIS_THREADS

2011-03-08 Thread Adam Jackson
Solaris 7 and older are not supported; Solaris 8 and later have (and use) pthreads. Acked-by: Alan Coopersmith alan.coopersm...@oracle.com Signed-off-by: Adam Jackson a...@redhat.com --- glx/glthread.c | 70 glx/glthread.h | 25

[PATCH 04/14] glx: unifdef USE_XTHREADS

2011-03-08 Thread Adam Jackson
xthreads is an ancient wrapper around a half dozen or so common thread APIs, including pthreads. Just use pthreads directly if you have it; if you don't, get with the times. Reviewed-by: Julien Cristau jcris...@debian.org Signed-off-by: Adam Jackson a...@redhat.com --- glx/glthread.c | 51

[PATCH 05/14] glx: unifdef BEOS_THREADS

2011-03-08 Thread Adam Jackson
We don't support BeOS, so, no. Signed-off-by: Adam Jackson a...@redhat.com --- glx/glthread.c | 41 - glx/glthread.h |2 +- 2 files changed, 1 insertions(+), 42 deletions(-) diff --git a/glx/glthread.c b/glx/glthread.c index a2d95b5..5da7e43 100644

[PATCH 06/14] glx: Simplify _glapi_check_multithread

2011-03-08 Thread Adam Jackson
We can guarantee that the X server does not call DRI driver services from multiple threads, so _glapi_check_multithread need never do anything special. As a result, ThreadSafe is always false, so remove it and simplify expressions where it appeared to match. Reviewed-by: Julien Cristau

[PATCH 07/14] glx: Remove unused _glapi_get_proc_name

2011-03-08 Thread Adam Jackson
Reviewed-by: Julien Cristau jcris...@debian.org Signed-off-by: Adam Jackson a...@redhat.com --- glx/glapi.c | 49 - glx/glapi.h |3 --- 2 files changed, 0 insertions(+), 52 deletions(-) diff --git a/glx/glapi.c b/glx/glapi.c index

[PATCH 09/14] glx: Remove unused _glapi_set_warning_func and friends

2011-03-08 Thread Adam Jackson
These could only have been hit from the (now-removed) noop dispatch table. Signed-off-by: Adam Jackson a...@redhat.com --- glx/glapi.c | 23 --- glx/glapi.h |6 -- hw/xquartz/GL/indirect.c |9 - 3 files changed, 0 insertions(+),

[PATCH 11/14] glx: Update some glapi comments

2011-03-08 Thread Adam Jackson
Reviewed-by: Julien Cristau jcris...@debian.org Signed-off-by: Adam Jackson a...@redhat.com --- glx/glapi.c | 38 ++ 1 files changed, 6 insertions(+), 32 deletions(-) diff --git a/glx/glapi.c b/glx/glapi.c index de5e7ea..f421c24 100644 --- a/glx/glapi.c +++

[PATCH 10/14] glx: Lobotomize _glapi_get_proc_address

2011-03-08 Thread Adam Jackson
This isn't a meaningful thing in the indirect glx loader, so just warn if it ever happens and move on. Signed-off-by: Adam Jackson a...@redhat.com --- glx/glapi.c | 39 ++- 1 files changed, 6 insertions(+), 33 deletions(-) diff --git a/glx/glapi.c

[PATCH 12/14] glx: Flatten -DXFree86Server

2011-03-08 Thread Adam Jackson
Always defined by the makefile, so, just get rid of it. Signed-off-by: Adam Jackson a...@redhat.com --- glx/Makefile.am |1 - glx/glapi.c | 43 --- 2 files changed, 0 insertions(+), 44 deletions(-) diff --git a/glx/Makefile.am b/glx/Makefile.am

[PATCH 13/14] glx: _glapi_get_proc_address is PUBLIC

2011-03-08 Thread Adam Jackson
Signed-off-by: Adam Jackson a...@redhat.com --- glx/glapi.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/glx/glapi.c b/glx/glapi.c index c3447f5..4bb07e2 100644 --- a/glx/glapi.c +++ b/glx/glapi.c @@ -649,7 +649,7 @@ _glapi_add_dispatch( const char * const *

[PATCH 14/14] glx: Fix _glapi_add_dispatch

2011-03-08 Thread Adam Jackson
We never need to generate stubs, because those conditions can't happen in the server. Yank that code out, but keep the bookkeeping for which extension functions are registered so the DRI driver doesn't get confused. As a pleasant bonus, we're now friendlier for environments like selinux that

Re: [PATCH] xfree86/common: Removed a configScreen leak when conf_screen is NULL

2011-03-08 Thread Adam Jackson
On Tue, 2011-03-08 at 13:10 +0200, Erkki Seppälä wrote: configScreen used a dynamically allocated buffer for XF86ConfScreenRec when conf_screen argument was NULL. This pointer was never stored anywhere, nor was it released, so this patch makes the function use automatically allocated storage

[PULL] xserver-next, 2011-03-08

2011-03-08 Thread Adam Jackson
The vbe fix and the memory leak are the only two real bugfixes here, the rest is somewhat cosmetic. --- The following changes since commit 628d16a92a7fa556fbb70bf4a4adf57ec05c190b: loader: Don't distribute sdksyms.c and make it depend on the config (2011-03-03 21:54:25 -0800) are available

[PATCH 2/3] dix: Shrink PropertyRec on LP64

2011-03-08 Thread Adam Jackson
size needn't be a long. No change on ILP32 but, combined with the previous change, 56 - 40 bytes on LP64. Signed-off-by: Adam Jackson a...@redhat.com --- include/propertyst.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/propertyst.h b/include/propertyst.h

[PATCH 1/3] dix: Fix ATOM typedef

2011-03-08 Thread Adam Jackson
unsigned long is needlessly large on LP64. Use uint32_t instead. Signed-off-by: Adam Jackson a...@redhat.com --- include/misc.h |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/include/misc.h b/include/misc.h index 0717db6..386d295 100644 --- a/include/misc.h +++

[PATCH 3/3] dix: Define RESTYPE as uint32_t

2011-03-08 Thread Adam Jackson
long is needlessly long on LP64. Before: textdata bss dec hex filename 1833242 69920 49696 1952858 1dcc5a hw/vfb/Xvfb After: textdata bss dec hex filename 1832426 69920 49504 1951850 1dc86a hw/vfb/Xvfb Signed-off-by: Adam Jackson a...@redhat.com

Re: [PATCH 2/3] dix: Shrink PropertyRec on LP64

2011-03-08 Thread Daniel Stone
On Tue, Mar 08, 2011 at 02:13:47PM -0500, Adam Jackson wrote: size needn't be a long. No change on ILP32 but, combined with the previous change, 56 - 40 bytes on LP64. Signed-off-by: Adam Jackson a...@redhat.com --- include/propertyst.h |4 ++-- 1 files changed, 2 insertions(+), 2

[PATCH] modes: Replace xf86DefaultModes with DMTModes

2011-03-08 Thread Adam Jackson
DMTModes is what xf86DefaultModes was always meant to be. textdata bss dec hex filename 1867137 72220 55392 1994749 1e6ffd hw/xfree86/Xorg-before 1852481 72180 55392 1980053 1e3695 hw/xfree86/Xorg-after Signed-off-by: Adam Jackson a...@redhat.com ---

Re: [PATCH 2/3] dix: Shrink PropertyRec on LP64

2011-03-08 Thread Adam Jackson
On Tue, 2011-03-08 at 19:37 +, Daniel Stone wrote: On Tue, Mar 08, 2011 at 02:13:47PM -0500, Adam Jackson wrote: size needn't be a long. No change on ILP32 but, combined with the previous change, 56 - 40 bytes on LP64. Signed-off-by: Adam Jackson a...@redhat.com ---

Re: [PATCH] modes: Replace xf86DefaultModes with DMTModes

2011-03-08 Thread Mark Kettenis
From: Adam Jackson a...@redhat.com Date: Tue, 8 Mar 2011 14:56:33 -0500 DMTModes is what xf86DefaultModes was always meant to be. I'd say xf86DefaultModes is a better variable name than DMTModes for an exported symbol though. ___

Re: [PATCH] modes: Replace xf86DefaultModes with DMTModes

2011-03-08 Thread Mark Kettenis
Date: Tue, 8 Mar 2011 21:27:47 +0100 (CET) From: Mark Kettenis mark.kette...@xs4all.nl From: Adam Jackson a...@redhat.com Date: Tue, 8 Mar 2011 14:56:33 -0500 DMTModes is what xf86DefaultModes was always meant to be. I'd say xf86DefaultModes is a better variable name than DMTModes

[PATCH 1/3] input: warning fix

2011-03-08 Thread Adam Jackson
getevents.c:770:5: warning: suggest parentheses around '' within '||' Introduced with dc57f89959e549403f8488eb9f23425bd7118b22: -if(dev-u.master dev-valuator) { +if(dev-valuator IsMaster(dev) || !IsFloating(dev)) { So I'm assuming the two terms around the || are meant to be a unit.

[PATCH 2/3] input: warning fixes

2011-03-08 Thread Adam Jackson
eventconvert.c:287:9: warning: enumeration value 'ET_Enter' not handled in switch eventconvert.c:287:9: warning: enumeration value 'ET_Leave' not handled in switch eventconvert.c:287:9: warning: enumeration value 'ET_FocusIn' not handled in switch eventconvert.c:287:9: warning: enumeration

[PATCH 3/3] record: warning fix

2011-03-08 Thread Adam Jackson
record.c:810:9: warning: unused variable 'count' Scope-shadowed by a later variable of the same name, safe to just delete. Signed-off-by: Adam Jackson a...@redhat.com --- record/record.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/record/record.c b/record/record.c

[PATCH:libXt] Add test framework similar to xserver and use it to test XtAsprintf

2011-03-08 Thread Alan Coopersmith
Simple test case just compares the results of snprintf to a static buffer with the new buffer returned by XtAsprintf. Test run currently fails due to correctly detecting the bug in null terminating the XtAsprintf returned string. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com ---

Re: [libXt:PATCH] XtAsprintf: Fix memory corruption.

2011-03-08 Thread Alan Coopersmith
On 03/ 8/11 07:09 AM, Cyril Brulebois wrote: Don't write the null terminator to a random place, this can trigger some segfault in XtOpenDisplay() and other annoyances. - new_string[len] = '\0'; + (*new_string)[len] = '\0'; Oops! Sorry. Yes. Reviewed-by: Alan Coopersmith

Re: [PATCH] modes: Replace xf86DefaultModes with DMTModes

2011-03-08 Thread Adam Jackson
On Tue, 2011-03-08 at 21:32 +0100, Mark Kettenis wrote: Date: Tue, 8 Mar 2011 21:27:47 +0100 (CET) From: Mark Kettenis mark.kette...@xs4all.nl From: Adam Jackson a...@redhat.com Date: Tue, 8 Mar 2011 14:56:33 -0500 DMTModes is what xf86DefaultModes was always meant to be.

Re: moving subwindow

2011-03-08 Thread Peter Harris
On 2011-03-08 13:46, Al'miev Il'dar wrote: These commands produce the main window and the subwindow with the borders specified. However, the subwindow can not be moved inside the main window by dragging it with a mouse. The windows manager is attached only to the main window, and I guess not

Re: [PATCH] modes: Replace xf86DefaultModes with DMTModes

2011-03-08 Thread Mark Kettenis
From: Adam Jackson a...@redhat.com Date: Tue, 08 Mar 2011 16:21:02 -0500 On Tue, 2011-03-08 at 21:32 +0100, Mark Kettenis wrote: Date: Tue, 8 Mar 2011 21:27:47 +0100 (CET) From: Mark Kettenis mark.kette...@xs4all.nl =20 From: Adam Jackson a...@redhat.com Date: Tue, 8 Mar 2011

Re: [PATCH 1/3] input: warning fix

2011-03-08 Thread Peter Hutterer
On Tue, Mar 08, 2011 at 03:33:11PM -0500, Adam Jackson wrote: getevents.c:770:5: warning: suggest parentheses around '' within '||' Introduced with dc57f89959e549403f8488eb9f23425bd7118b22: -if(dev-u.master dev-valuator) { +if(dev-valuator IsMaster(dev) || !IsFloating(dev)) {

Re: [PATCH:libXt] Add test framework similar to xserver and use it to test XtAsprintf

2011-03-08 Thread Cyril Brulebois
Alan Coopersmith alan.coopersm...@oracle.com (08/03/2011): Simple test case just compares the results of snprintf to a static buffer with the new buffer returned by XtAsprintf. Good idea. I think you should also have another test, with a bigger string to hit the second code path (the vsnprintf

Re: [PATCH] Xi: fix XI2 passive grab reply length calculation

2011-03-08 Thread Peter Hutterer
On Tue, Mar 08, 2011 at 01:37:13PM +, Daniel Stone wrote: On Tue, Mar 08, 2011 at 02:44:02PM +1000, Peter Hutterer wrote: If modifiers failed, the reply length was 4 bytes too short. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net This only works because xXIGrabModifierInfo

Re: [PATCH:libXt] Add test framework similar to xserver and use it to test XtAsprintf

2011-03-08 Thread Gaetan Nadon
On Tue, 2011-03-08 at 13:07 -0800, Alan Coopersmith wrote: Simple test case just compares the results of snprintf to a static buffer with the new buffer returned by XtAsprintf. Test run currently fails due to correctly detecting the bug in null terminating the XtAsprintf returned string.

Re: [PATCH:libXt] Add test framework similar to xserver and use it to test XtAsprintf

2011-03-08 Thread Cyril Brulebois
Gaetan Nadon mems...@videotron.ca (08/03/2011): Tests are only executed when running make check, is the --enable-unit-tests really needed? I could understand why people wouldn't want glib to be pulled in unconditionally when building libxt. As a package maintainer, I'm happy to declare through

Re: [PATCH:libXt] Add test framework similar to xserver and use it to test XtAsprintf

2011-03-08 Thread Alan Coopersmith
On 03/ 8/11 03:23 PM, Gaetan Nadon wrote: +int snlen, aslen; Whitespace error Will fix. Would it be the time to provide some common support for unit testing? We will soon end-up in a situation where every package does it differently, making it difficult to add test cases in multiple

[PATCH 1/5] glx: Factor out glxProbeDriver function.

2011-03-08 Thread Christopher James Halse Rogers
DRI, DRI2 and swrast all had near-identical driver probing logic. Pull it into glxdricommon Signed-off-by: Christopher James Halse Rogers christopher.halse.rog...@canonical.com Reviewed-by: Adam Jackson a...@redhat.com --- glx/glxdri.c | 44 +--

[PATCH 2/5] Consolidate all the PATH_MAX handling into misc.h

2011-03-08 Thread Christopher James Halse Rogers
Signed-off-by: Christopher James Halse Rogers christopher.halse.rog...@canonical.com --- hw/xfree86/common/xf86Configure.c |5 + hw/xfree86/os-support/xf86_OSlib.h | 11 +++ hw/xfree86/parser/scan.c | 11 +++ include/misc.h | 11

[PATCH 1/5] glx: Factor out glxProbeDriver function.

2011-03-08 Thread Christopher James Halse Rogers
DRI, DRI2 and swrast all had near-identical driver probing logic. Pull it into glxdricommon Signed-off-by: Christopher James Halse Rogers christopher.halse.rog...@canonical.com Reviewed-by: Adam Jackson a...@redhat.com --- glx/glxdri.c | 44 +--

[PATCH 3/5] glx: Use PATH_MAX as size of filename buffer

2011-03-08 Thread Christopher James Halse Rogers
Signed-off-by: Christopher James Halse Rogers christopher.halse.rog...@canonical.com --- glx/glxdricommon.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/glx/glxdricommon.c b/glx/glxdricommon.c index 5569ab7..16f6588 100644 --- a/glx/glxdricommon.c +++

[RFC PATCHv2 4/5] glx: Search for DRI drivers in colon-delimited list of paths.

2011-03-08 Thread Christopher James Halse Rogers
This matches the behaviour of mesa libGL. Signed-off-by: Christopher James Halse Rogers christopher.halse.rog...@canonical.com --- Upon investigating more closely what mesa libGL does to find DRI drivers, the extra work handling drivers where driCreateScreen fails isn't needed. configure.ac

[PATCH 5/5] glx: Use GLX rather than AIGLX in ouput strings.

2011-03-08 Thread Christopher James Halse Rogers
If swrast is being used there's nothing “Accelerated” about it Signed-off-by: Christopher James Halse Rogers christopher.halse.rog...@canonical.com --- glx/glxdri.c | 36 ++-- glx/glxdri2.c | 22 +++--- glx/glxdricommon.c |6

Re: [PATCH 1/3] Absorb miTriFan() into CompositeTriFan()

2011-03-08 Thread Keith Packard
On Tue, 8 Mar 2011 10:14:26 -0500, Søren Sandmann sandm...@cs.au.dk wrote: From: Søren Sandmann Pedersen s...@redhat.com There is no need to virtualize this function that nobody cares about. Signed-off-by: Soren Sandmann s...@redhat.com For the series: Acked-by: Keith Packard

Re: [PATCH:libXt] Add test framework similar to xserver and use it to test XtAsprintf

2011-03-08 Thread Gaetan Nadon
On Wed, 2011-03-09 at 00:39 +0100, Cyril Brulebois wrote: I could understand why people wouldn't want glib to be pulled in unconditionally when building libxt. As a package maintainer, I'm happy to declare through a configure option that I want to enable unit tests, and make configure fail if

Re: [PATCH inputproto xi 2.1] Updates for pointer emulation and more touch device modes

2011-03-08 Thread Peter Hutterer
On Mon, Mar 07, 2011 at 06:07:57PM -0500, Chase Douglas wrote: The event stream for an unowned selection is identical to a touch +grab. When a client does not select for unowned and ownership events, it will +receive a TouchBegin event when it becomes the owner of a touch stream. this

Re: [PATCH inputproto xi 2.1] Updates for pointer emulation and more touch device modes

2011-03-08 Thread Peter Hutterer
On Tue, Mar 08, 2011 at 10:24:42AM -0500, Chase Douglas wrote: On 03/08/2011 12:41 AM, Peter Hutterer wrote: On Wed, Mar 02, 2011 at 11:35:41AM -0500, Chase Douglas wrote: On 03/02/2011 05:58 AM, Daniel Stone wrote: On Tue, Feb 22, 2011 at 10:06:37AM -0500, Chase Douglas wrote: @@ -132,16

Re: [PATCH] xfree86/modes: Fixed memory leak in xf86InitialConfiguration

2011-03-08 Thread Peter Hutterer
On Tue, Mar 08, 2011 at 01:11:50PM +0200, Erkki Seppälä wrote: There were two memory leaks in the function: one was the lack of free for enabled, the other was the full lack of releasing anything when configuration was too small. The first issue was fixed by adding the missing free, the other

[PULL] misc fixes

2011-03-08 Thread Peter Hutterer
a few warning fixes, ptraccel refactoring and memleaks, that pretty much sums it up. The following changes since commit 628d16a92a7fa556fbb70bf4a4adf57ec05c190b: loader: Don't distribute sdksyms.c and make it depend on the config (2011-03-03 21:54:25 -0800) are available in the git

panoramiX macro/inline cleanups

2011-03-08 Thread Dave Airlie
this patch series are things I extracted from my dynerama tree, they just clean up a few things with macros and inlines. This is the first step to dropping panoramiXNumScreens which is needed to do dynamic xinerama stuff. Dave. ___

[PATCH 1/5] panoramiX: consolidate common id assignment code.

2011-03-08 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com This adds a new FOR_NSCREENS_FORWARD_SKIP, which skips the first element and is a common idiom throughout panoramiX code. It then adds a new inline function to hide id assignment to a panoramiX resource and cleans up lots of common repeated code.

[PATCH 2/5] panoramiX: convert 0-panoramiXNumScreens loops to macro

2011-03-08 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com This just uses the FOR_NSCREENS macro instead. --- Xext/panoramiX.c | 14 +++--- Xext/panoramiXprocs.c |2 +- Xext/saver.c |2 +- Xext/shm.c|2 +- Xext/xvdisp.c |2 +- dix/events.c |4

[PATCH 3/5] panoramiX: convert 1-panoramiXNumScreens loops to use macro

2011-03-08 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com This converts all the remaining 1-num loops to the macro, this removes nearly all the panoramiXNumScreens usage in loops, and is a step to replacing it. Signed-off-by: Dave Airlie airl...@redhat.com --- Xext/panoramiX.c |2 +- Xext/panoramiXprocs.c

[PATCH 4/5] panoramiX: use RESTYPE instead of unsigned long

2011-03-08 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com unsigned long seems like the wrong type to use here, switch to using RESTYPE. Signed-off-by: Dave Airlie airl...@redhat.com --- Xext/panoramiX.c| 10 +- Xext/panoramiXsrv.h | 12 ++-- render/render.c |2 +- 3 files changed, 12

[PATCH 5/5] panoramiX: macro checking if drawable is root

2011-03-08 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com this code appears in quite a few places, consolidate it into a macro in a header. Signed-off-by: Dave Airlie airl...@redhat.com --- Xext/panoramiX.h |1 + Xext/panoramiXprocs.c | 26 +- 2 files changed, 14 insertions(+), 13

Re: [PATCH v2 evdev 0/3] Memory leak fixes.

2011-03-08 Thread Peter Hutterer
On Tue, Mar 08, 2011 at 11:23:44AM +0200, Rami Ylimäki wrote: v2: XKB options are now released with XkbFreeRMLVOSet. The first version of these patches assigned a dynamically allocated device filename to a const pointer. Calling free with this pointer causes a warning, but this warning

[PATCH] panoramiX: macro checking if drawable is root (v2)

2011-03-08 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com this code appears in quite a few places, consolidate it into a macro in a header. v2: align braces with macro just above it, and with lines removed Signed-off-by: Dave Airlie airl...@redhat.com --- Xext/panoramiX.h |1 + Xext/panoramiXprocs.c |

Re: [PATCH 5/5] panoramiX: macro checking if drawable is root

2011-03-08 Thread Dave Airlie
On Wed, Mar 9, 2011 at 3:29 PM, Dave Airlie airl...@gmail.com wrote: From: Dave Airlie airl...@redhat.com this code appears in quite a few places, consolidate it into a macro in a header. Nak I've posted a v2 of this patch on its own, just aligning the braces. Dave.