[PATCH:smproxy 6/7] Print which option was in error along with usage message

Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- smproxy.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/smproxy.c b/smproxy.c index 7c59f16..3ceb880 100644 --- a/smproxy.c +++ b/smproxy.c @@ -1168,17 +1168,27 @@ main (int argc, char *argv

[PATCH:smproxy 3/7] Add local copy of asprintf()

Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- configure.ac |7 ++- save.c | 45 + smproxy.h|5 + 3 files changed, 56 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index ea49c18

[PATCH:smproxy 1/7] Replace #ifdef X_NOT_POSIX with explicit check for mktemp function

Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- configure.ac |2 +- save.c | 10 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/configure.ac b/configure.ac index c97bb04..1f23bac 100644 --- a/configure.ac +++ b/configure.ac @@ -35,7 +35,7

[PATCH:smproxy 4/7] Convert sprintf calls to asprintf or snprintf

Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- save.c| 17 ++--- smproxy.c | 23 ++- 2 files changed, 20 insertions(+), 20 deletions(-) diff --git a/save.c b/save.c index 5d6b4ce..267f806 100644 --- a/save.c +++ b/save.c @@ -361,7 +361,7

[PATCH] Xdmx: Initialize DMX extension even if not built with GLX support

dmxAddExtensions takes an argument to determine if it should just initialize the DMX extension, or both DMX GLX, but if GLX wasn't compiled in, the entire call was #ifdef'ed out, leaving the DMX extension unavailable. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- hw/dmx

[PATCH:showfont 1/3] Rename row pointer to avoid shadowing row integer variable

Fixes gcc warning: showfont.c: In function ‘show_glyphs’: showfont.c:261:18: warning: declaration of ‘row’ shadows a previous local [-Wshadow] showfont.c:178:10: warning: shadowed declaration is here [-Wshadow] Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- showfont.c |4

[PATCH:showfont 3/3] Add -version flag to print program version

Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- man/showfont.man |3 +++ showfont.c | 12 ++-- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/man/showfont.man b/man/showfont.man index 47d077c..d513bdd 100644 --- a/man/showfont.man +++ b/man

[PATCH:showfont 2/3] Print which option was in error along with usage message

Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- showfont.c | 35 ++- 1 file changed, 22 insertions(+), 13 deletions(-) diff --git a/showfont.c b/showfont.c index 05895ac..cef5f1d 100644 --- a/showfont.c +++ b/showfont.c @@ -347,10 +347,16

[PATCH:libXi] Remove fallback for _XEatDataWords, require libX11 1.6 for it

versions that didn't have libX11 1.6 yet. Now that we're past that hurdle, we can drop the fallbacks and just require libX11 1.6 for building new versions of the extension libraries. Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com

Re: [PATCH 01/14] present: Disable when Xinerama is active

it now is a lot of hassle. -- -Alan Coopersmith- alan.coopersm...@oracle.com Oracle Solaris Engineering - http://blogs.oracle.com/alanc ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg

Re: [PATCH xf86-video-sis] Fix format-security warnings

(pScrn1-scrnIndex, X_INFO, rectxine); ^ sis_driver.c:1924:8: error: format not a string literal and no format arguments [-Werror=format-security] xf86DrvMsg(pScrn1-scrnIndex, X_INFO, rectxine); Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Alan Coopersmith

Re: [PATCH] miext: Move SyncShm FDs out of the way of clients

) return fd; #ifndef F_DUPFD_CLOEXEC fcntl(newfd, F_SETFD, FD_CLOEXEC); #endif so that we don't pass all those fds to xkbcomp when we fork it. -- -Alan Coopersmith- alan.coopersm...@oracle.com Oracle Solaris Engineering - http://blogs.oracle.com/alanc

Re: [Xcb] [PATCH:libX11] Don't need to link libX11-xcb against libX11

On 11/21/13 02:06 PM, Adam Jackson wrote: On Wed, 2013-11-20 at 16:23 -0800, Josh Triplett wrote: On Fri, Nov 15, 2013 at 06:03:25PM -0800, Alan Coopersmith wrote: libX11-xcb only accesses data structures defined in X11 headers, it doesn't call any functions or reference any global variables

Re: [PATCH libxtrans] Don't restrict FD passing to Linux Solaris

/Xtransint.h @@ -72,10 +72,6 @@ from The Open Group. # define XTRANSDEBUG 1 #endif -#if XTRANS_SEND_FDS !(defined(linux) || defined(__sun)) -#error FD passing support only on Linux Solaris -#endif - #ifdef WIN32 # define _WILLWINSOCK_ #endif Reviewed-by: Alan Coopersmith alan.coopersm

Re: [PATCH xproto] Xthreads.h: Declare _Xthread_init for WIN32

Oops, sorry, I forgot this patch was still outstanding when I cut the xproto release tonight. The prototype matches the definition in libX11's src/locking.c, so Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com On 11/21/13 06:29 PM, Yaakov (Cygwin/X) wrote: From: Yaakov Selkowitz

[PATCH:xinit] Pass files to cpp via CLI arg instead of stdin to workaround gcc 4.8 change

Fixes Bug 69439 - Empty lines before #!/bin/sh in startx https://bugs.freedesktop.org/show_bug.cgi?id=69439 Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- cpprules.in |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpprules.in b/cpprules.in index eaea428

Re: [PATCH libxxtrans 2/2] Fix alignment issues in FD passing code

...@openbsd.org Reviewed-by: Matthieu Herrb matth...@herrb.eu Given that the equivalent diff for xcb has been merged, iss Matthieu's approval enough for me to push this? Yes, please go ahead and push. -- -Alan Coopersmith- alan.coopersm...@oracle.com Oracle Solaris

Re: [PATCH 29/37] xfree86/dri: Mark DRIDrvMsg and dri_drm_debug_print as gnu_printf. Fix resulting warnings.

/Xfuncproto.h like all the existing uses in the X server code? It already has the right compiler/version checks built in. -- -Alan Coopersmith- alan.coopersm...@oracle.com Oracle Solaris Engineering - http://blogs.oracle.com/alanc

[PATCH:libXmu] Remove SUNSHLIB support for SunOS 4.x shared libraries

Never enabled in modular builds, was only enabled for SunOS 4.x in imake. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- src/Atoms.c |8 +-- src/Makefile.am |3 +-- src/StrToCurs.c |2 +- src/sharedlib.c | 67

[PATCH:xf86-video-cirrus] Skip building xaa files when XAA is not supported

No point building linking empty *.o files into the drivers. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- src/Makefile.am | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index c649b3d..36b8d8b 100644 --- a/src

[PATCH:xf86-video-mga] Remove mga_esc.c vestigal stub

Previously contained MGA HAL code, was left an empty shell by the removal of USEMGAHAL in commit 94bbeb132c7eda. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- src/Makefile.am |1 - src/mga_esc.c | 13 - 2 files changed, 14 deletions(-) delete mode 100644

Re: [PATCH libX11 0/2] Xlib 32-bit sequence number wrap bug(fix)

On 11/17/13 10:42 AM, Jonas Petersen wrote: Am 16.11.2013 23:30, schrieb Alan Coopersmith: cc'ing the xcb mailing list, since more people there know about how the Xlib/xcb interaction in xcb_io works. For the people there who didn't see the patches on xorg-devel, you can find them at: http

Re: [PATCH:xpr] Remove unneeded uses of math.h -lm

On 11/16/13 07:12 AM, Gaetan Nadon wrote: On 13-11-16 02:05 AM, Alan Coopersmith wrote: Can't see why they were ever needed. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- Makefile.am |2 +- x2pmp.c |1 - 2 files changed, 1 insertion(+), 2 deletions

Re: [PATCH:libX11] Don't need to link libX11-xcb against libX11

On 11/16/13 06:33 AM, Thomas Klausner wrote: On Fri, Nov 15, 2013 at 06:39:58PM -0800, Alan Coopersmith wrote: On 11/15/13 06:18 PM, Thomas Klausner wrote: On Fri, Nov 15, 2013 at 06:03:25PM -0800, Alan Coopersmith wrote: libX11-xcb only accesses data structures defined in X11 headers

Re: [PATCH libX11 0/2] Xlib 32-bit sequence number wrap bug(fix)

insertions(+), 3 deletions(-) -- -Alan Coopersmith- alan.coopersm...@oracle.com Oracle Solaris Engineering - http://blogs.oracle.com/alanc ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg

[PATCH:libSM] Stop compiling empty sm_auth.c stub

File exists as a placeholder in case someone someday decides to add additional auth methods on top of what libICE provides, but it's been two decades and no one has, so stop spending time compiling linking for now. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- src/Makefile.am

[PATCH:libX11] Don't need to link libX11-xcb against libX11

libX11-xcb only accesses data structures defined in X11 headers, it doesn't call any functions or reference any global variables in libX11 itself. (Seems to have been left from previous XCL implementation.) Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- src/Makefile.am |1

[PATCH:appres 01/17] Print which option was in error along with usage message

Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- appres.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/appres.c b/appres.c index 2f43d2d..fad870f 100644 --- a/appres.c +++ b/appres.c @@ -156,8 +156,11 @@ main (int argc, char *argv[]) printf

[PATCH:fstobdf 09/17] Print error and usage on invalid arg, instead of ignoring it

Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- fstobdf.c |5 + 1 file changed, 5 insertions(+) diff --git a/fstobdf.c b/fstobdf.c index 5fe4816..255d82e 100644 --- a/fstobdf.c +++ b/fstobdf.c @@ -109,6 +109,11 @@ main(int argc, char *argv[]) printf(%s\n

[PATCH:fstobdf 08/17] Add -version option to print version

Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- fstobdf.c | 14 -- man/fstobdf.man |6 ++ 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/fstobdf.c b/fstobdf.c index bcdffbc..5fe4816 100644 --- a/fstobdf.c +++ b/fstobdf.c @@ -43,6 +43,10

[PATCH:iceauth 11/17] Fix noexistent typo in error message

Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- process.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/process.c b/process.c index 97bcfa9..09cb7ef 100644 --- a/process.c +++ b/process.c @@ -1060,7 +1060,7 @@ static int do_help ( if (n == 0

[PATCH:fstobdf 07/17] Print which option was in error along with usage message

Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- configure.ac |2 +- fstobdf.c| 19 ++- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/configure.ac b/configure.ac index 1dbf55a..0ef434b 100644 --- a/configure.ac +++ b/configure.ac

[PATCH:fslsfonts 05/17] Print which option was in error along with usage message

Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- configure.ac |2 +- fslsfonts.c | 35 --- 2 files changed, 25 insertions(+), 12 deletions(-) diff --git a/configure.ac b/configure.ac index e828085..58a4607 100644 --- a/configure.ac +++ b

[PATCH:mkfontscale 14/17] Add missing newline to usage output

Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- mkfontscale.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mkfontscale.c b/mkfontscale.c index a67f283..1194145 100644 --- a/mkfontscale.c +++ b/mkfontscale.c @@ -118,7 +118,7 @@ usage(void) { fprintf

[PATCH:bdftopcf 02/17] Print which option was in error along with usage message

Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- bdftopcf.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/bdftopcf.c b/bdftopcf.c index 1b24aa1..2208fee 100644 --- a/bdftopcf.c +++ b/bdftopcf.c @@ -145,6 +145,8 @@ main(int argc, char *argv[]) else

[PATCH:iceauth 10/17] Actually print command list in usage message

called with file pointer prefix, and since the prefix matched no command names, no help was printed. Since the way iceauth's help list is structured doesn't make it easy to add a prefix to every line, skip indentation for now and just pass NULL for the command argument. Signed-off-by: Alan

[PATCH 00/17] CLI option handling updates for various apps

One of the tasks I've been doing at work is looking at what it will take to bring our software into compliance with the latest accessibility standards, specifically http://www.w3.org/TR/wcag2ict/ which seems to be one of the standards which many countries will be adopting in their acessibility

[PATCH:bitmap 03/17] Print which option was in error along with usage message

Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- atobm.c | 26 +++--- bmtoa.c |8 +++- configure.ac |2 +- 3 files changed, 27 insertions(+), 9 deletions(-) diff --git a/atobm.c b/atobm.c index 040fecb..ef6da7e 100644 --- a/atobm.c +++ b

[PATCH:fstobdf 06/17] Spell out -server in usage message to match man page

Code matches -s*, so either form works, but better to have them agree. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- fstobdf.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fstobdf.c b/fstobdf.c index 8d029a5..db168c9 100644 --- a/fstobdf.c +++ b

[PATCH:fslsfonts 04/17] Add -version option to print version

Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- fslsfonts.c |9 + man/fslsfonts.man |3 +++ 2 files changed, 12 insertions(+) diff --git a/fslsfonts.c b/fslsfonts.c index 6ff6a2d..9de741e 100644 --- a/fslsfonts.c +++ b/fslsfonts.c @@ -43,6 +43,10

[PATCH:iceauth 13/17] Print which option was in error along with usage message

Special case -u, since it's documented as printing the usage message (sort of like an ancient --help), so shouldn't be called unrecognized. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- iceauth.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff

[PATCH:mkfontscale 16/17] Make usage() always exit(1)

Avoid duplicating exit(1) calls after every single call to usage() Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- configure.ac |2 +- mkfontscale.c | 12 +++- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/configure.ac b/configure.ac index 971ae5c

[PATCH:mkfontscale 15/17] Add -v flag to print program version

Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- man/mkfontscale.man |5 + mkfontscale.c |5 - 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/man/mkfontscale.man b/man/mkfontscale.man index 4aa88ab..cb18458 100644 --- a/man/mkfontscale.man +++ b

Re: [PATCH:libX11] Don't need to link libX11-xcb against libX11

On 11/15/13 06:18 PM, Thomas Klausner wrote: On Fri, Nov 15, 2013 at 06:03:25PM -0800, Alan Coopersmith wrote: libX11-xcb only accesses data structures defined in X11 headers, it doesn't call any functions or reference any global variables in libX11 itself. (Seems to have been left from

[PATCH:iceauth 12/17] Add -V flag to print version

Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- iceauth.c |4 man/iceauth.man |2 ++ 2 files changed, 6 insertions(+) diff --git a/iceauth.c b/iceauth.c index e729ed5..c1688c0 100644 --- a/iceauth.c +++ b/iceauth.c @@ -63,6 +63,7 @@ usage (void) -q

[PATCH:mkfontscale 17/17] Print which option was in error along with usage message

Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- mkfontscale.c | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/mkfontscale.c b/mkfontscale.c index d27bb8d..a494f93 100644 --- a/mkfontscale.c +++ b/mkfontscale.c @@ -113,11 +113,12

[PATCH:xpr] Remove unneeded uses of math.h -lm

Can't see why they were ever needed. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- Makefile.am |2 +- x2pmp.c |1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index c96f863..8b75b07 100644 --- a/Makefile.am +++ b

Fwd: [oss-security] I miss LSD, slides, paper and tools relating to finding UNIX system level vulnerabilities (as given at 44CON)

As we expand our use of shared memory via the new extensions, we should try to make sure we're not making more problems along the lines of those mentioned in the presentation linked below associated whitepaper published at:

Re: [PATCH 2/2] Enable XTRANS_SEND_FDS on Solaris too.

On 11/11/13 03:38 PM, Keith Packard wrote: Alan Coopersmith alan.coopersm...@oracle.com writes: +/* Enable general extensions on Solaris. */ +#ifndef __EXTENSIONS__ +# undef __EXTENSIONS__ +#endif This doesn't make sense to me -- if __EXTENSIONS__ isn't defined, then undefine __EXTENSIONS__

[PATCH] Stop including inline assembly .il file for Solaris Studio builds

instructions inlined, making it a slightly slower bcopy. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- configure.ac |9 - exa/Makefile.am|4 hw/xfree86/Makefile.am | 11 --- 3 files changed, 24 deletions(-) diff --git a/configure.ac

[PULL: xserver] FD passing support for Solaris

-0800) Alan Coopersmith (2): Avoid conflicts with Solaris sys/regset.h defines that clash with our names Enable XTRANS_SEND_FDS on Solaris too. configure.ac |3 ++- hw/xfree86/x86emu/decode.c

[PATCH 1/2] Avoid conflicts with Solaris sys/regset.h defines that clash with our names

#undef these so they don't interfere with our use. (Yes, have filed a bug against the system headers for exposing these, but this solves the problem for building on existing releases.) Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- hw/xfree86/x86emu/decode.c | 10

Re: [PATCH 3/7] Xext: Enable MIT-SHM FD-passing request definitions only when possible

| 17 - include/protocol-versions.h | 4 3 files changed, 33 insertions(+), 2 deletions(-) Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com -- -Alan Coopersmith- alan.coopersm...@oracle.com Oracle Solaris Engineering - http

[PATCH 0/2] Solaris support for XTRANS_SEND_FDS

After applying these two patches on top of Keith's current tree, plus the changes just pushed to libxtrans libxcb, I was able to get the expected colorful squares display on Solaris using the shmfd test program from ssh://people.freedesktop.org/~keithp/shmfd . Alan Coopersmith (2): Avoid

[PATCH 2/2] Enable XTRANS_SEND_FDS on Solaris too.

Requires passing through the __EXTENSIONS__ and _XOPEN_SOURCE defines in order to expose the msg_control members in struct msghdr. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- configure.ac|3 ++- include/dix-config.h.in |8 2 files changed, 10

Re: [PATCH 2/7] Require xextproto version 7.2.99.901

Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com -- -Alan Coopersmith- alan.coopersm...@oracle.com Oracle Solaris Engineering - http://blogs.oracle.com/alanc ___ xorg-devel@lists.x.org: X.Org development Archives

Re: [PATCH:shmfd 2/2] Use /var/tmp instead of /run/shm on non-linux OS'es

. (On my platform, /tmp is tmpfs, /var/tmp is disk, so I clearly picked wrong if that was the goal.) -- -Alan Coopersmith- alan.coopersm...@oracle.com Oracle Solaris Engineering - http://blogs.oracle.com/alanc ___ xorg-devel

[PATCH:libxkbcommon] Make XkbFileCreate argument types match between header implementation

Fixes build failure with Solaris Studio compilers: src/xkbcomp/ast-build.c, line 492: identifier redeclared: XkbFileCreate current : function(..., enum xkb_map_flags) previous: function(..., unsigned int) : src/xkbcomp/ast-build.h, line 98 Signed-off-by: Alan Coopersmith alan.coopersm

[PATCH:printproto] Move xau from Requires to Requires.private in printproto.pc

The xau headers are required because Print.h has #include X11/Xauth.h for the definition of the Xauth typedef, but software including this header doesn't necessarily need to link with libXau. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- printproto.pc.in |2 +- 1 file

Re: [PATCH:shmfd 2/2] Use /var/tmp instead of /run/shm on non-linux OS'es

On 11/ 7/13 11:53 PM, Mark Kettenis wrote: From: Alan Coopersmith alan.coopersm...@oracle.com Date: Thu, 7 Nov 2013 20:55:44 -0800 Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- Makefile |9 + shmfd.c |4 2 files changed, 9 insertions(+), 4 deletions

[PATCH:libxtrans 2/2] Check if we need to define _XOPEN_SOURCE for struct msghdr.msg_control

Required to expose the structure members in Solaris headers, since it was an XPG4/UNIX95 addition to the Solaris ABI. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- xtrans.m4 | 33 + 1 file changed, 33 insertions(+) diff --git a/xtrans.m4 b

[PATCH:libxtrans 1/2] Add stubs for send/recv fd functions in local transports

Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- Xtranslcl.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/Xtranslcl.c b/Xtranslcl.c index 5beef7c..4deb86c 100644 --- a/Xtranslcl.c +++ b/Xtranslcl.c @@ -140,6 +140,21 @@ TRANS(ReopenFail

[PATCH:libXext] Remove fallback for _XEatDataWords, require libX11 1.6 for it

that we're past that hurdle, we can drop the fallbacks and just require libX11 1.6 for building new versions of the extension libraries. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- configure.ac|8 +--- src/Makefile.am |1 - src/XEVI.c |1 - src

[PATCH:shmfd 2/2] Use /var/tmp instead of /run/shm on non-linux OS'es

Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- Makefile |9 + shmfd.c |4 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index e77f938..672979e 100644 --- a/Makefile +++ b/Makefile @@ -1,7 +1,8 @@ -CFLAGS=-Wall -O0 -g

[PATCH:shmfd 1/2] Bail if make_shm fails

For instance, if the specified path doesn't exist. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- shmfd.c |4 1 file changed, 4 insertions(+) diff --git a/shmfd.c b/shmfd.c index 45b9067..4dee9de 100644 --- a/shmfd.c +++ b/shmfd.c @@ -95,6 +95,10 @@ main (int argc

Re: [PATCH:shmfd 2/2] Use /var/tmp instead of /run/shm on non-linux OS'es

Whoops, didn't mean to include the makefile changes in that patch, just shmfd.c. -alan- On 11/ 7/13 08:55 PM, Alan Coopersmith wrote: Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- Makefile |9 + shmfd.c |4 2 files changed, 9 insertions(+), 4

Re: [ANNOUNCE] libxshmfence 1.0

On 11/ 2/13 12:39 AM, Keith Packard wrote: Alan Coopersmith alan.coopersm...@oracle.com writes: What about platforms which don't have linux/futex.h ? I looked into alternate synchronization mechanisms; I couldn't figure out how to use standard pthread APIs to provide the desired semantics

[PATCH:bdftopcf] Correct usage message for scanline unit option to be -u, not -s

Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- bdftopcf.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bdftopcf.c b/bdftopcf.c index da83938..1b24aa1 100644 --- a/bdftopcf.c +++ b/bdftopcf.c @@ -148,7 +148,7 @@ main(int argc, char *argv

Re: xserver with DRI3 shm.c: unknown type name: xShmAttachFdReq and xShmCreateSegmentReq

On 11/ 2/13 04:55 PM, Gaetan Nadon wrote: I can't find where those types are defined. Should they be in shmproto.h? In http://patchwork.freedesktop.org/patch/15082/ which Keith's xserver changes require, but he hasn't pushed to the xextproto git repo yet. -- -Alan Coopersmith

Re: [ANNOUNCE] libxshmfence 1.0

___ xorg-announce mailing list xorg-annou...@lists.x.org http://lists.x.org/mailman/listinfo/xorg-announce -- -Alan Coopersmith- alan.coopersm...@oracle.com Oracle Solaris Engineering - http://blogs.oracle.com/alanc

[PATCH:xkbcomp 1/4] Remove unused function entry/exit tracking framework

Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- utils.c | 59 --- utils.h | 60 xkbcomp.c |1 - 3 files changed, 120 deletions(-) diff --git a/utils.c

[PATCH:xkbcomp 4/4] Fix many const char * warnings from gcc

Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- action.c |8 action.h |4 ++-- compat.c |2 +- expr.c | 12 ++-- geometry.c | 26 +- indicators.c |2 +- indicators.h |2 +- keytypes.c |2

[PATCH:xkbcomp 3/4] Convert remaining sprintf calls to snprintf

Most were fixed length or length checked anyway, this just saves time doublechecking that. (A few could be replaced by asprintf, but we don't have a copy guaranteed to be reachable from this program yet.) Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- expr.c |2

[PATCH:xkbcomp 2/4] Remove unused uASSERT macro

Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- utils.h |9 - 1 file changed, 9 deletions(-) diff --git a/utils.h b/utils.h index 62c9f2f..81f5893 100644 --- a/utils.h +++ b/utils.h @@ -219,15 +219,6 @@ uInformation(const char * /* s

[PATCH:libXfont 1/2] xstrdup - strdup

Missed in xalloc - malloc etal conversion in 0cdc9b8f850342 Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- src/FreeType/ftfuncs.c |4 ++-- src/FreeType/xttcap.c | 20 src/FreeType/xttcap.h |9 - 3 files changed, 2 insertions(+), 31

[PATCH:libXfont 2/2] Replace malloc(strlen)+strcpy/strcat calls with strdup

Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- src/FreeType/ftfuncs.c |4 +--- src/FreeType/xttcap.c |3 +-- src/fontfile/fontdir.c | 10 +++--- 3 files changed, 5 insertions(+), 12 deletions(-) diff --git a/src/FreeType/ftfuncs.c b/src/FreeType/ftfuncs.c index

Re: [PATCH:xkbcomp 3/4] Convert remaining sprintf calls to snprintf

in this patch to add one - maybe later, once the XKB *alloc calls are converted to standard C ones. -- -Alan Coopersmith- alan.coopersm...@oracle.com Oracle Solaris Engineering - http://blogs.oracle.com/alanc ___ xorg-devel

Re: [PATCH:libXfont 2/2] Replace malloc(strlen)+strcpy/strcat calls with strdup

libXfont to see if we can safely drop this from the API or not, but this is one step forward in the meantime. -- -Alan Coopersmith- alan.coopersm...@oracle.com Oracle Solaris Engineering - http://blogs.oracle.com/alanc ___ xorg

Re: [PATCH modular] build.sh: remove font-bitstream-speedo from the build list

@@ -1177,7 +1177,6 @@ build_font() { build font bh-type1 build font bitstream-100dpi build font bitstream-75dpi -build font bitstream-speedo build font bitstream-type1 build font cronyx-cyrillic build font cursor-misc Reviewed-by: Alan Coopersmith

Re: [PATCH:libxkbfile 1/4] unifdef -UXKB_IN_SERVER

don't have a ton of time, so will do bits and pieces when I can, and hope someone with more time gets to them first. -- -Alan Coopersmith- alan.coopersm...@oracle.com Oracle Solaris Engineering - http://blogs.oracle.com/alanc

Re: [PATCH:libxkbfile 3/4] Convert sprintf calls to snprintf

into XKB's nasty little buffers. -- -Alan Coopersmith- alan.coopersm...@oracle.com Oracle Solaris Engineering - http://blogs.oracle.com/alanc ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives

Re: SIGUSR1 to xinit

-- -Alan Coopersmith- alan.coopersm...@oracle.com Oracle Solaris Engineering - http://blogs.oracle.com/alanc ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman

Re: [PATCH] Xi: fix logic error when calculating emulated motion events

!= LISTENER_POINTER_REGULAR || 1480 ti-listeners[0].type != LISTENER_POINTER_GRAB) 1481 return; This condition was always true, causing dropped motion events. Reported-by: Alan Coopersmith alan.coopersm...@oracle.com Signed-off-by: Peter Hutterer peter.hutte...@who-t.net

Do XkbKSIsLower() and XkbKSIsUpper() matter?

considered private API, but we know software like GNOME has used it in the past.) -- -Alan Coopersmith- alan.coopersm...@oracle.com Oracle Solaris Engineering - http://blogs.oracle.com/alanc ___ xorg-devel@lists.x.org: X.Org

[PATCH:libxkbfile 1/4] unifdef -UXKB_IN_SERVER

Xserver has its own copy of this code now, so we don't need to keep an unused copy in libxkbfile too. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- include/X11/extensions/XKBfile.h |2 -- include/X11/extensions/XKBrules.h |2 -- src/XKBfileInt.h |2

[PATCH:libxkbfile 2/4] Don't dereference xkb pointer until after checking it for NULL

Some compilers can perform mind-twistingly evil optimizations if you check for NULL after using it, others just let you segv. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- src/xkmout.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src

[PATCH:libxkbfile 3/4] Convert sprintf calls to snprintf

Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- src/cout.c |4 +- src/maprules.c |8 +- src/xkbtext.c | 230 ++-- 3 files changed, 128 insertions(+), 114 deletions(-) diff --git a/src/cout.c b/src/cout.c index

[PATCH:libxkbfile 4/4] Constify atom name argument to XkbInternAtom

Matches XInternAtom, which it wraps, and quiets a bunch of const warnings in xkbcomp. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- include/X11/extensions/XKBfile.h |2 +- src/xkbatom.c|4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff

-Wlogical-op warning on DeliverEmulatedMotionEvent

lines in that block become dead code. I'd guess the || should be , but figured you'd be in a better position to evaluate test that. -- -Alan Coopersmith- alan.coopersm...@oracle.com Oracle Solaris Engineering - http://blogs.oracle.com/alanc

[PATCH:xf86-video-sis] Fix HDisplay/VDisplay typos

] Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- src/sis_driver.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/sis_driver.c b/src/sis_driver.c index cefe503..80b8d51 100644 --- a/src/sis_driver.c +++ b/src/sis_driver.c @@ -13751,12 +13751,12

[PATCH:libX11] Xcms file parsing should not require the impossible to succeed

as the check at other points in this function, to return failure only if we hit \n or \0 before successfully finding two fields. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- src/xcms/cmsColNm.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/xcms/cmsColNm.c b

Re: [PATCH:libX11] Xcms file parsing should not require the impossible to succeed

On 10/23/13 01:45 PM, Alan Coopersmith wrote: This has gone unnoticed since 1991, until gcc -Wlogicalop came to our rescue, and https://bugs.freedesktop.org/show_bug.cgi?id=70803 was filed. And I probably should have mentioned it's gone unnoticed because the effect is truly minor - it's only

Re: [PATCH:xf86-input-mouse] Use asprintf (or Xprintf on old servers) instead of strdup+sprintf

On 10/21/13 03:02 PM, Peter Hutterer wrote: On Sat, Oct 19, 2013 at 09:51:31PM -0700, Alan Coopersmith wrote: +/* Xorg = 1.10 provides an asprintf() implementation even if libc doesn't */ +#include xorgVersion.h +#if defined(HAVE_ASPRINTF) || \ +(XORG_VERSION_CURRENT = XORG_VERSION_NUMERIC

[PATCH:xdm] Ensure fgets read at least one byte before modifying string

If a file has a \0 byte (binary file, strange encoding, corruption), fgets() can return a string starting with a \0 byte - check for that before checking to see if the byte before the \0 is a \n, so we don't reach back before the start of our memory buffer. Signed-off-by: Alan Coopersmith

[PATCH:xman] Ensure fgets read at least one byte before modifying string

is a \n before we chop it off, in case we're reading from a file missing a newline, or a line longer than fit in the buffer provided to fgets(). Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- man.c|7 ++- misc.c |4 +++- search.c |6 -- 3 files changed, 13

[PATCH:xf86-input-mouse] Use asprintf (or Xprintf on old servers) instead of strdup+sprintf

Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- configure.ac |3 +++ src/mouse.c | 57 - 2 files changed, 43 insertions(+), 17 deletions(-) diff --git a/configure.ac b/configure.ac index ee6a345..bd782a5 100644

Re: any xserver stable branch nominations?

On 10/17/13 04:34 PM, Alan Coopersmith wrote: On 10/17/13 04:29 PM, Matt Dew wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi all, Today was the nominal 1.14.4-rc2 release. I've gotten no nominations, pull or cherry-pick requests since 1.14.3 was released. 1.14.4 should include

Re: any xserver stable branch nominations?

it into master. -- -Alan Coopersmith- alan.coopersm...@oracle.com Oracle Solaris Engineering - http://blogs.oracle.com/alanc ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http

Re: [PULL: xserver master] misc. bug fixes cleanups, including CVE-2013-4396

On 10/16/13 01:38 PM, Keith Packard wrote: Alan Coopersmith alan.coopersm...@oracle.com writes: Alan Coopersmith (4): Skip damage calls if DamageCreate fails in exa functions Seems like this is going to break stuff badly when this happens. Is there some way

[PULL: xserver master] misc. bug fixes cleanups, including CVE-2013-4396

to 73b2660d7273d175d279d22f8ca0c3932a14ff1c: Avoid use-after-free in dix/dixfonts.c: doImageText() [CVE-2013-4396] (2013-10-14 17:56:44 -0700) Alan Coopersmith (4): Skip damage calls if DamageCreate fails in exa functions DMX

<    5   6   7   8   9   10   11   12   13   14   >