[PATCH 6/8] kdrive: Mark XV names const to avoid warnings.

No code modifies it at runtime, and it's common to store string literals to it. Signed-off-by: Eric Anholt e...@anholt.net --- hw/kdrive/src/kxv.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/kdrive/src/kxv.h b/hw/kdrive/src/kxv.h index e50615b..3a49a65 100644

glamor XV in xephyr

I wanted to be able to hack on the glamor XV code on a single system, so I had to build Xephyr support for it. This branch (glamor-xv of my tree) is less aggressive than my initial attempt at XV sanity (all-xv of my tree), but it does get glamor XV working on both Xephyr and intel, and fixes

[PULL] glamor-fixes

The following changes since commit 42a4873cc7fe0c7a729e48f806e877c4dac5c07f: hw/xfree86: Video Driver ABI version 18.0 (2014-05-01 16:53:57 -0700) are available in the git repository at: git://people.freedesktop.org/~anholt/xserver glamor-fixes for you to fetch changes up to

[PATCH] glamor: Don't forget to check whether we can fall back in polysegment.

. Signed-off-by: Eric Anholt e...@anholt.net Reviewed-by: Keith Packard kei...@keithp.com --- glamor/glamor_segment.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/glamor/glamor_segment.c b/glamor/glamor_segment.c index 84b27ac..53f7da0 100644 --- a/glamor

Re: [PATCH 5/8] glamor: Split the XV code into XF86-dependent parts and generic.

walter harms wha...@bfs.de writes: Am 05.05.2014 22:09, schrieb Eric Anholt: I want to expose this from Xephyr as well, both to be able to test XV changes rapidly, and beause the XV passthrough to the host's overlay really doesn't work out well when we glXSwapBuffers() over the colorkey

Re: [PATCH 12/13] mi: Fill all spans for PolyFillArc at once

walter harms wha...@bfs.de writes: Am 06.05.2014 00:02, schrieb Keith Packard: This allocates span data for all of the provided arcs and draws the whole set in one call, rather than doing them one at a time. For modern hardware, this is a significant performance improvement. Signed-off-by:

Re: [PATCH 02/13] glamor: Add glamor_program based copy acceleration

Signed-off-by: Keith Packard kei...@keithp.com There's some mess in the commit message from a squash. The code looks good now and I'd like to just get some comments touched up. However, regardless of what you decide to do with my comment suggestions, Reviewed-by: Eric Anholt e...@anholt.net

Re: [PATCH 03/13] glamor: Use glamor_program for glamor_push_pixels

Keith Packard kei...@keithp.com writes: This uses the same shaders as glamor_poly_glyph_blt. Signed-off-by: Keith Packard kei...@keithp.com --- glamor/glamor_glyphblt.c | 131 ++- 1 file changed, 49 insertions(+), 82 deletions(-) diff --git

Re: [PATCH 00/13] Updated set of glamor patches

Keith Packard kei...@keithp.com writes: Here's the current set of glamor patches to be added post 1.16. -keith Patches 1, 7, 8, 9 are also: Reviewed-by: Eric Anholt e...@anholt.net pgp12e2Y8F8hJ.pgp Description: PGP signature ___ xorg-devel

Re: warnings fixes with --enable-debug

Michel Dänzer mic...@daenzer.net writes: On 06.05.2014 03:10, Eric Anholt wrote: Here's a series for fixing almost all the warnings I get with --enable-debug. I had been building X without --enable-debug (and thus without asserts) AFAICT xserver doesn't #define NDEBUG in general, so

[PATCH] glamor: Stop disabling asserts by default.

Disabling asserts is something the user gets to manage. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_priv.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/glamor/glamor_priv.h b/glamor/glamor_priv.h index 96635be..c56c559 100644 --- a/glamor/glamor_priv.h +++ b/glamor

Re: [PATCH 02/13] glamor: Add glamor_program based copy acceleration

Keith Packard kei...@keithp.com writes: Michel Dänzer mic...@daenzer.net writes: On 06.05.2014 07:02, Keith Packard wrote: +static Bool +glamor_copy_gl(DrawablePtr src, + DrawablePtr dst, + GCPtr gc, + BoxPtr box, + int nbox, +

Re: [PATCH 05/13] glamor: Add glamor_program based 0-width dashed lines

Keith Packard kei...@keithp.com writes: Markus Wick mar...@selfnet.de writes: Am 2014-05-06 00:02, schrieb Keith Packard: +static const char on_off_fs_exec[] = + float pattern = texture2D(dash, vec2(dash_offset, 0.5)).w;\n + if (pattern == 0.0)\n +

Re: glamor XV in xephyr

Keith Packard kei...@keithp.com writes: Eric Anholt e...@anholt.net writes: I wanted to be able to hack on the glamor XV code on a single system, so I had to build Xephyr support for it. This branch (glamor-xv of my tree) is less aggressive than my initial attempt at XV sanity (all-xv

[PATCH] glamor: Don't leak a prepare_access_gc() in putimage fallbacs.

It turns out putimage doesn't use the GC tile or stipple anyway, so there's no need to do this. Signed-off-by: Eric Anholt e...@anholt.net --- I didn't see a followup email from either of you, so how about this patch for the fixes tree? glamor/glamor_image.c | 3 +-- 1 file changed, 1

Re: [PATCH 3/3] glamor: Choose max fbo size by texture + viewport size

Keith Packard kei...@keithp.com writes: Markus Wick mar...@selfnet.de writes: The max size of renderbuffers and texture often match by accident, but as we always use textures, we should check for the right flag. Also check for viewport size as this may be lower and we want to render to

Re: [PATCH 0/5] glamor: Fixes ported from the standalone tree

Keith Packard kei...@keithp.com writes: Michel Dänzer mic...@daenzer.net writes: AFAICT these are all the relevant fixes which went into the standalone glamor tree since it was imported into the xserver tree. We're already a few days overdue for the non-critical bug fix window, and I'd

[PULL] glamor-fixes

a11bbd875f3f90a3d02d727778cb1d3524cf59fd found at anholt-pub but git fetch anholt-pub glamor-fixes got me that commit back, so I don't know what's going on. Eric Anholt (1): glamor: Don't leak a prepare_access_gc() in putimage fallbacks. Markus Wick (2): glamor: Fix no-mipmap allocations

Re: [PATCH 13/13] mi: Draw all points/spans for miZeroPolyArc at once if possible

Keith Packard kei...@keithp.com writes: Drawing all of the spans in one driver call is a considerable performance improvement, which we can do unless the arcs are double-dashed, in which case overlapping dashes should draw the latter arc contents. Signed-off-by: Keith Packard

[PATCH] glamor: Remove always-true yInverted flag.

All users of glamor had the same value set, and it complicated things for no reason. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor.c | 5 -- glamor/glamor.h | 8 +- glamor/glamor_gradient.c | 19 ++-- glamor/glamor_pixmap.c| 77

[PATCH 3/4] glamor: Drop unnecessary glTexParameteri() in upload of texture data.

We're not drawing, and we're not initially setting up the texture for later drawing. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_transfer.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/glamor/glamor_transfer.c b/glamor/glamor_transfer.c index 4eea902..8914155 100644

[PATCH 4/4] glamor: Drop constant arguments to glamor_solid().

After keithp's change to drop the old glamor_fill() code, nothing ever changed these values. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_glyphs.c| 4 ++-- glamor/glamor_priv.h | 1 - glamor/glamor_trapezoid.c | 3 +-- glamor/glamor_utils.c | 9 +++-- 4 files

[PATCH 2/4] glamor: Use MIN/MAX macros to clean up glamor_transfer.c

Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_transfer.c | 45 ++--- 1 file changed, 10 insertions(+), 35 deletions(-) diff --git a/glamor/glamor_transfer.c b/glamor/glamor_transfer.c index ad875c9..4eea902 100644 --- a/glamor

[PATCH 1/4] glamor: Drop unnecessary glTexParameteri() in SetSpans().

If this path needed the filters set, so would all the other glDrawArrays() callers. But they don't. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_spans.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/glamor/glamor_spans.c b/glamor/glamor_spans.c index 46ba6c3..582d11d

[PATCH 4/5] glamor: Remove a dead prototype.

The corresponding code was deleted in 2ff41008494e6c5909c058f1f80b4f66617dada1 (2012) Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_priv.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/glamor/glamor_priv.h b/glamor/glamor_priv.h index 61f393d..dc4f9b8 100644

[PATCH 1/5] glamor: Drop dead get/pub sub pixmap functions.

These were replaced by the new glamor_prepare.c code. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_pixmap.c | 129 - glamor/glamor_priv.h | 5 -- 2 files changed, 134 deletions(-) diff --git a/glamor/glamor_pixmap.c b/glamor

[PATCH 5/5] glamor: Drop the are we doing a series of blits or draws logic.

It's unused since keithp's copy acceleration code completely replaced glamor_copyarea.c and removed the blit path. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor.c| 5 - glamor/glamor_points.c | 3 --- glamor/glamor_priv.h | 7 --- glamor/glamor_render.c | 2

[PATCH 2/5] glamor: Drop dead glamor_download_pixmap_to_cpu()

Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_pixmap.c | 314 - glamor/glamor_priv.h | 15 --- 2 files changed, 329 deletions(-) diff --git a/glamor/glamor_pixmap.c b/glamor/glamor_pixmap.c index 00e3827..2275ede 100644

[PATCH 3/5] glamor: Drop dead glamor_restore_pixmap_to_texture().

Unused since the glamor_prepare.c replacement of glamor_finish_access(). Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_pixmap.c | 7 --- glamor/glamor_priv.h | 10 -- 2 files changed, 17 deletions(-) diff --git a/glamor/glamor_pixmap.c b/glamor/glamor_pixmap.c

[PATCH] glamor: Fix GLES2 non-VBO temporary memory allocation.

-by: Eric Anholt e...@anholt.net --- Of the pile of patches I've sent today, this is the only one intended for -fixes. glamor/glamor_vbo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/glamor/glamor_vbo.c b/glamor/glamor_vbo.c index c678559..e906101 100644 --- a/glamor

Re: [PATCH 0/5] Document screen proc wrapping and fix places where it was wrong

wrapping Fixes all of the screen wrappers in the VGA arbiter. [PATCH 5/5] hw/xfree86: Let xf86Rotate leave the BlockHandler Finally, removes the rotate block handler when possible. Sorry, I misplaced this series. It looks great. Reviewed-by: Eric Anholt e...@anholt.net pgpSxQtxAObxl.pgp

Re: [PATCH 2/2] add SERVER_SUPPORTS_NON_PCI_PLATFORM_DEVS

if the device is already claimed. Meaning that a user could not make things work even with a .conf file to explicitly specify the driver to use. Series is: Tested-by: Eric Anholt e...@anholt.net (it gets the modesetting driver up and running on the Pi). pgpPXvqK4wHAl.pgp Description: PGP signature

Re: [PATCH] Revert glamor: Fix coordinates handling for composite source/mask pictures

, here's a revert for 1.16. Reviewed-by: Eric Anholt e...@anholt.net pgpu2JaiEqqYW.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo

[PULL] glamor changes for 1.17

to fetch changes up to 6d4954884908ea9894fcfe9836db1ba7bb45be61: Merge remote-tracking branch 'origin/master' into glamor-next (2014-07-17 18:07:26 -0700) Eric Anholt (20): xorg: Remove duplicated definitions of some XV-related

[PATCH 09/16] xv: Move xf86 XV color key helper to core.

Color key overlay implementations want to reuse this code, and XF86's had bugs. Signed-off-by: Eric Anholt e...@anholt.net --- Xext/xvdix.h | 2 ++ Xext/xvmain.c | 31 +++ hw/xfree86/common/xf86xv.c | 25 + 3 files

[PATCH 12/16] kdrive: Don't bother explicitly clearing new window privates to NULL.

Privates are initially cleared to zero by dixInitPrivates(). Signed-off-by: Eric Anholt e...@anholt.net --- hw/kdrive/src/kxv.c | 21 - hw/kdrive/src/kxv.h | 1 - 2 files changed, 22 deletions(-) diff --git a/hw/kdrive/src/kxv.c b/hw/kdrive/src/kxv.c index c916af4..0b4335a

[PATCH 16/16] xv: Remove the pScreen from the XV encodings.

It was never used, and it meant a bunch of pointless frobbing of structure members between the DDX and DIX. Signed-off-by: Eric Anholt e...@anholt.net --- Xext/xvdix.h | 1 - hw/kdrive/ephyr/ephyr_glamor_xv.c | 2 +- hw/kdrive/ephyr/ephyrvideo.c | 2 +- hw/kdrive/src

[PATCH 04/16] xv: Drop the ddQueryAdaptors() interface.

The core was passing pointers to pxvs's nAdaptors and pAdaptors, and the two hardware implementations were copying pxvs's nAdaptors and pAdaptors into those pointers. Signed-off-by: Eric Anholt e...@anholt.net --- Xext/xvdisp.c | 2 -- Xext/xvdix.h | 1 - hw/kdrive

[PATCH 15/16] kdrive: Remove a dead struct.

It's never been used in the history of the tree. Signed-off-by: Eric Anholt e...@anholt.net --- hw/kdrive/src/kxv.h | 9 - 1 file changed, 9 deletions(-) diff --git a/hw/kdrive/src/kxv.h b/hw/kdrive/src/kxv.h index 4eb4054..b997299 100644 --- a/hw/kdrive/src/kxv.h +++ b/hw/kdrive/src

XV cleanup series

Here's a pile of stuff I wrote when I was working on Xephyr XV with glamor. I wanted glamor to be able to create adaptors on its own without needing cooperation from the DDX, and I didn't want to build a third copy of DDX XV, so I was trying to clean up and share common code. I eventually backed

[PATCH 02/16] xv: Remove dead VIDEO_NO_CLIPPING from the xorg and kdrive DDXes.

As far as I can see, nothing has ever used this flag except possibly the i.mx6 xorg ddx debug during bringup. Signed-off-by: Eric Anholt e...@anholt.net --- hw/kdrive/src/kxv.c | 46 hw/kdrive/src/kxv.h | 1 - hw/xfree86/common

[PATCH 07/16] xv: Drop unused XvdiVideoStopped().

Signed-off-by: Eric Anholt e...@anholt.net --- Xext/xvdix.h | 1 - Xext/xvmain.c | 24 2 files changed, 25 deletions(-) diff --git a/Xext/xvdix.h b/Xext/xvdix.h index ddd8abb..b61659c 100644 --- a/Xext/xvdix.h +++ b/Xext/xvdix.h @@ -235,7 +235,6 @@ extern _X_EXPORT

[PATCH 14/16] xv: Drop the ClientPtr from the interface to the DDX.

Nobody was using it. Signed-off-by: Eric Anholt e...@anholt.net --- Xext/xvdisp.c | 8 +++- Xext/xvdix.h | 20 +-- Xext/xvmain.c | 20 +-- hw/kdrive/src/kxv.c| 49

[PATCH 03/16] xv: Move common code for adaptor cleanup to xvmain.c

Since any DDX XV screen cleanup would need this same code for freeing the tree of pointers for xv adaptors, move it to the dix. Signed-off-by: Eric Anholt e...@anholt.net --- Xext/xvdix.h | 1 + Xext/xvmain.c | 41 + hw/kdrive

[PATCH 11/16] kdrive: Remove dead KXVPaintRegion().

It's been unused since mach64 was deleted, and now there's a helper in core XV. Signed-off-by: Eric Anholt e...@anholt.net --- hw/kdrive/src/kxv.c | 41 - hw/kdrive/src/kxv.h | 3 --- 2 files changed, 44 deletions(-) diff --git a/hw/kdrive/src/kxv.c b/hw

[PATCH 01/16] xv: Remove dead VIDEO_INVERT_CLIPLIST from the xorg and kdrive DDXes.

As far as I can see (looking at trees on my disk, plus googling for the term), nothing has ever used this flag Signed-off-by: Eric Anholt e...@anholt.net --- hw/kdrive/src/kxv.c | 24 hw/kdrive/src/kxv.h | 1 - hw/xfree86/common/xf86xv.c | 24

[PATCH 13/16] xv: Remove the no-op AllocatePort/FreePort interfaces.

Signed-off-by: Eric Anholt e...@anholt.net --- Xext/xvdisp.c | 88 ++ Xext/xvdix.h | 3 -- Xext/xvmain.c | 2 +- hw/kdrive/src/kxv.c| 17 - hw/xfree86/common/xf86xv.c | 17 - 5 files

[PATCH 10/16] xv: Fix malloc-failure cases in the fill color key helper.

Signed-off-by: Eric Anholt e...@anholt.net --- Xext/xvmain.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/Xext/xvmain.c b/Xext/xvmain.c index a3fb711..d84708b 100644 --- a/Xext/xvmain.c +++ b/Xext/xvmain.c @@ -1096,22 +1096,26 @@ XvFillColorKey

[PATCH 05/16] xv: Move the DDX XV screen private allocation into the DDXes.

global screen private. Signed-off-by: Eric Anholt e...@anholt.net --- Xext/xvdix.h | 1 - hw/kdrive/src/kxv.c| 12 +--- hw/xfree86/common/xf86xv.c | 14 +++--- 3 files changed, 12 insertions(+), 15 deletions(-) diff --git a/Xext/xvdix.h b/Xext/xvdix.h index

[PATCH 08/16] xv: Move CloseScreen setup from a DIX hook to normal wrapping.

Signed-off-by: Eric Anholt e...@anholt.net --- Xext/xvdix.h | 1 - Xext/xvmain.c | 2 -- hw/kdrive/src/kxv.c| 18 +- hw/kdrive/src/kxv.h| 1 + hw/xfree86/common/xf86xv.c | 19 ++- hw/xfree86/common

[PATCH 06/16] xv: Drop unused XvdiPreemptVideo().

Signed-off-by: Eric Anholt e...@anholt.net --- Xext/xvdix.h | 1 - Xext/xvmain.c | 22 -- 2 files changed, 23 deletions(-) diff --git a/Xext/xvdix.h b/Xext/xvdix.h index 2437eb4..ddd8abb 100644 --- a/Xext/xvdix.h +++ b/Xext/xvdix.h @@ -259,7 +259,6 @@ extern _X_EXPORT int

Re: [PATCH] glamor: Add support for SHM sync fences

Keith Packard kei...@keithp.com writes: This hooks up SHM sync fences to complete the requirements for DRI3 running on Glamor. Signed-off-by: Keith Packard kei...@keithp.com This looks equivalent to what I had in my Xephyr DRI3 branch. Reviewed-by: Eric Anholt e...@anholt.net

Re: [PATCH 09/16] xv: Move xf86 XV color key helper to core.

Keith Packard kei...@keithp.com writes: Eric Anholt e...@anholt.net writes: Color key overlay implementations want to reuse this code, and XF86's had bugs. It might be helpful to describe which bugs were in the xf86 code so that these two implementations could be compared. Just the ones

Re: [PATCH 4/4] xfree86/modes: rotation damage is automatically destroyed on close

Keith Packard kei...@keithp.com writes: Don't try to destroy rotation_damage in the xf86RotateCloseScreen; it will have been destroyed when the screen pixmap was destroyed. This series is: Reviewed-by: Eric Anholt e...@anholt.net pgpT9MLZTtTDC.pgp Description: PGP signature

Re: [PATCH 08/12] xfree86: Clean up some more alpha awareness

Adam Jackson a...@redhat.com writes: Since the sparse stuff is gone none of these variables get used for anything, they're just dead side-effect-less execution. Patches 1-8 are: Reviewed-by: Eric Anholt e...@anholt.net It sounds like #9 could work around OpenBSD being weird by just deleting

Re: [PATCH 01/12] Stop trying to out-guess mesa for BO allocation

Keith Packard kei...@keithp.com writes: I don't see anything indicating that this code path is only used by glamor. --- src/uxa/intel_uxa.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/uxa/intel_uxa.c b/src/uxa/intel_uxa.c index b396188..717754f 100644 ---

Re: [PATCH 03/12] Don't use GetScratchPixmapHeader for shadow pixmaps

Keith Packard kei...@keithp.com writes: GetScratchPixmapHeader should only be used for local memory pixmaps, as used by PutImage and friends. That's because when you free the scratch pixmap header, it doesn't actually free the pixmap; instead, it gets stuffed in pScreen-pScratchPixmap and any

Re: [PATCH 06/12] Remove glamor support from UXA acceleration

Keith Packard kei...@keithp.com writes: Makes UXA no longer include calls to glamor acceleration functions. Signed-off-by: Keith Packard kei...@keithp.com --- src/uxa/Makefile.am| 9 -- src/uxa/intel_dri.c| 60 + src/uxa/intel_driver.c | 1 - src/uxa/intel_uxa.c

Re: [PATCH 07/12] Add intel_flush to abstract flushing pending acceleration operations

as long as it still calls intel_glamor_flush(). If it did, it gets: Reviewed-by: Eric Anholt e...@anholt.net even before we sort out the rest of the series. pgpsmzwOsTzDK.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development

Re: [PATCH 08/12] Get rid of glamor stubs in intel_glamor.h

Keith Packard kei...@keithp.com writes: This eliminates the stubs in intel_glamor.h and replaces them with ifdefs instead. I don't feel strongly about this either way -- ifdefs are more traditional userland style, while stubs are more kernel style. Acked-by: Eric Anholt e...@anholt.net

Re: [PATCH 09/12] Do more checks for proposed flip pixmaps

Keith Packard kei...@keithp.com writes: Make sure the pitch and tiling are correct. Make sure there's a BO we can get at. I thought we couldn't change these parameters, but now I can't find what prevents them from changing. Can you cite sources? pgp_XyaN_u7LY.pgp Description: PGP signature

Re: [PATCH 10/12] Add glamor back into the driver

Keith Packard kei...@keithp.com writes: This adds glamor support back into the driver, but instad of going through UXA, this uses it directly instead. This is hard to read with the conditionalizing all of the UXA code in the same commit as adding the glamor code. Then there are a bunch of

Re: [PATCH 00/12] Rework intel 2D driver glamor support

Keith Packard kei...@keithp.com writes: I spent the day just cleaning up this patch series and testing. I think it's ready for others to use and review. I've been running it on two machines for a couple of days now and it's been solid. Patches 2, 4 are: Reviewed-by: Eric Anholt e

Re: [PATCH 14/16] xv: Drop the ClientPtr from the interface to the DDX.

Chris Wilson ch...@chris-wilson.co.uk writes: On Fri, Jul 18, 2014 at 10:32:31AM -0700, Eric Anholt wrote: Nobody was using it. The ClientPtr gets used to send events back to the Client from various implementations of Xv. I've modified the in-tree code, which didn't use it, so I'd like

Re: [PATCH 16/16] xv: Remove the pScreen from the XV encodings.

Keith Packard kei...@keithp.com writes: Eric Anholt e...@anholt.net writes: It was never used, and it meant a bunch of pointless frobbing of structure members between the DDX and DIX. This will generate warnings when initializing the (char *) name field From a constant string. One option

Re: [PATCH] dri2proto: Fix fields in SwapBuffers

Robert Ancell robert.anc...@canonical.com writes: Fix errors in SwapBuffers: - The section in 8. Extension Requests was missing the target_msc, divisor and remainder fields - The section in A.2 Protocol Requests had two entries for SwapBuffers, both incorrect Reviewed-by: Eric Anholt e

Re: [PATCH 03/12] Don't use GetScratchPixmapHeader for shadow pixmaps

Keith Packard kei...@keithp.com writes: Eric Anholt e...@anholt.net writes: This change appears to be unrelated, and possibly harmful (if X has dropped the last ref to the BO, but it's still the scanout buffer, a new allocation would now reuse the BO and scribble on scanout until the next

Re: [PATCH 01/12] Stop trying to out-guess mesa for BO allocation

Keith Packard kei...@keithp.com writes: Eric Anholt e...@anholt.net writes: Keith Packard kei...@keithp.com writes: I don't see anything indicating that this code path is only used by glamor. True. It's a fix for DRI3 for either UXA or none. Mesa allocates a single page for a 1x1 texture

Re: [PATCH 2/2] glamor: Add glamor_copy_fbo_cpu() for CopyArea to non-GPU destination

Michel Dänzer mic...@daenzer.net writes: From: Michel Dänzer michel.daen...@amd.com This provides a speedup e.g. when the destination is an SHM pixmap. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=76285 Signed-off-by: Michel Dänzer michel.daen...@amd.com +

Re: [PATCH v2] glamor: Add glamor_copy_fbo_cpu() for CopyArea to non-GPU destination

unnecessary use of GLAMOR_ACCESS_WO, thanks Eric for pointing that out. Disregard the GLAMOR_ACCESS_WO patch for now. Nice. We may end up pulling the other patch some day, but it seemed separate from what this one needed. Reviewed-by: Eric Anholt e...@anholt.net (My guess is keithp will pull

Re: [PATCH synaptics] conf: increase top software button area to 15%

Peter Hutterer peter.hutte...@who-t.net writes: We had reports that the top software button area is hard to hit for those using the trackpoint and clicking the buttons with their thumb. Analysis of event recordings (3 different people) for left, right and middle clicks shows that there is a

Re: [PATCH 0/3] glamor: Disable shader-based trapezoids. Bug 76213.

Keith Packard kei...@keithp.com writes: The shader-based trapezoid drawing code in glamor draws incorrectly and doesn't appear to offer any performance benefits. This series fixes a couple of compiler warning problems and then disables the shader based trapezoid code. This fixes the bottom

[PULL] xv cleanups

to 3714f5401690b288045090c4bcd9cb01c6e4860e: kdrive: Remove a dead struct. (2014-08-07 12:39:53 -0700) Eric Anholt (15): xv: Remove dead VIDEO_INVERT_CLIPLIST from the xorg and kdrive DDXes. xv: Remove dead

[PATCH] glamor: Don't try to set up core fonts textures when we won't use them.

This happens to avoid GL errors on hardware without EXT_texture_integer (which implies GLSL 130, and thus glamor_text.c programs not compiling anyway). Signed-off-by: Eric Anholt e...@anholt.net --- With this, glamor on simulated RPi gets to the point of showing my xterm on my gray background

Re: [PATCH] glamor: Free Xv put image data immediately after use

visible performance impact. Signed-off-by: Keith Packard kei...@keithp.com Reviewed-by: Eric Anholt e...@anholt.net pgpdOF3gDKYJ_.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg

Re: [PATCH] glamor: Don't call glamor_copy_fbo_cpu() for GLAMOR_DRM_ONLY pixmaps

Michel Dänzer mic...@daenzer.net writes: From: Michel Dänzer michel.daen...@amd.com It results in a crash. Signed-off-by: Michel Dänzer michel.daen...@amd.com We really need to figure out how to make GLAMOR_DRM_ONLY go away. Reviewed-by: Eric Anholt e...@anholt.net pgp07AyI2W2b9.pgp

Re: [PATCH] glx: Fix 'y ' value in swrastGetDrawableInfo()

Maks Naumov maksq...@ukr.net writes: Signed-off-by: Maks Naumov maksq...@ukr.net Reviewed-by: Eric Anholt e...@anholt.net pgpC0wqlLs2Ls.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org

Re: [PATCH 04/18] Three minor warning and whitespace fixes

Keith Packard kei...@keithp.com writes: Declare a constant string 'const', clean up some indentation whitespace I'm confused about these whitespace fixes -- the lines surrounding those two are also tabs. pgptDagCNSkq3.pgp Description: PGP signature

Re: [PATCH 07/18] Delay initial modeset until root window contents are prepared

Keith Packard kei...@keithp.com writes: Wait until the root window has been painted for the first time before doing the modeset. This avoids flashing black while the root window gets set up. Signed-off-by: Keith Packard kei...@keithp.com --- src/uxa/intel.h | 2 ++

Re: [PATCH 04/18] Three minor warning and whitespace fixes

, but I don't actually care to block things due to that. This driver is enough of a disaster already that whitespace inconsistency isn't its main problem. Patches 1-3, 5-6, 8, 12-15 are: Reviewed-by: Eric Anholt e...@anholt.net 16-18: I'm still looking at them. pgpq5xGBPwgTJ.pgp Description

Re: [PATCH 04/18] Three minor warning and whitespace fixes

Keith Packard kei...@keithp.com writes: Eric Anholt e...@anholt.net writes: So there's a bunch of disagreement between this new code and existing practice about whitespace, and still misc unrelated whitespace changes sprinkled into the remaining patches. That makes me grumpy when reviewing

Merging the modesetting driver to the X Server

it's big: commit 35dc7c75150733dbcef8a18b6796f49a7c48ebee Merge: 3a51418 5f3485b Author: Eric Anholt e...@anholt.net Date: Mon Aug 25 15:52:58 2014 -0700 Merge branch 'modesetting-import' into master This reintroduces a hardware driver to the xfree86 directory. Unlike the drivers

[PATCH 3/8] modesetting: xserver already checks XEXTPROTO = 7.2.99.901.

--- hw/xfree86/drivers/modesetting/drmmode_display.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/hw/xfree86/drivers/modesetting/drmmode_display.c b/hw/xfree86/drivers/modesetting/drmmode_display.c index 6964e93..31c39a2 100644 --- a/hw/xfree86/drivers/modesetting/drmmode_display.c

[PATCH 8/8] modesetting: Drop remaining old-xserver compatibility.

--- hw/xfree86/drivers/modesetting/driver.c | 6 ++ hw/xfree86/drivers/modesetting/drmmode_display.c | 15 +-- hw/xfree86/drivers/modesetting/drmmode_display.h | 6 -- 3 files changed, 3 insertions(+), 24 deletions(-) diff --git

[PATCH 6/8] modesetting: Connect the driver to the build.

--- configure.ac | 10 + hw/xfree86/Makefile.am | 2 +- hw/xfree86/drivers/Makefile.am | 5 + hw/xfree86/drivers/modesetting/Makefile.am | 27 ++--

[PATCH 1/8] modesetting: Merge modesetting's COPYING into the xserver's.

--- COPYING| 24 +++ hw/xfree86/drivers/modesetting/COPYING | 44 -- 2 files changed, 24 insertions(+), 44 deletions(-) delete mode 100644 hw/xfree86/drivers/modesetting/COPYING diff --git a/COPYING b/COPYING index

[PATCH 2/8] modesetting: unifdef MODESETTING_OUTPUT_SLAVE_SUPPORT

The server will always have it. --- hw/xfree86/drivers/modesetting/driver.c | 12 hw/xfree86/drivers/modesetting/drmmode_display.c | 17 + hw/xfree86/drivers/modesetting/drmmode_display.h | 7 --- 3 files changed, 1 insertion(+), 35 deletions(-) diff

[PATCH 7/8] modesetting: Drop use of compat-api.h

--- hw/xfree86/drivers/modesetting/Makefile.am | 1 - hw/xfree86/drivers/modesetting/compat-api.h | 94 hw/xfree86/drivers/modesetting/driver.c | 50 ++--- hw/xfree86/drivers/modesetting/drmmode_display.c | 1 - 4 files changed, 21

[PATCH 4/8] modesetting: Drop use of pointer for void *

The xserver doesn't have that typedef. --- hw/xfree86/drivers/modesetting/compat-api.h | 4 ++-- hw/xfree86/drivers/modesetting/driver.c | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/xfree86/drivers/modesetting/compat-api.h

[PATCH 5/8] modesetting: Update for the platform device API change.

--- hw/xfree86/drivers/modesetting/driver.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/xfree86/drivers/modesetting/driver.c b/hw/xfree86/drivers/modesetting/driver.c index bf5a9a4..9384f88 100644 --- a/hw/xfree86/drivers/modesetting/driver.c +++

Re: [PATCH] glx/present: Only send GLX_BufferSwapComplete for PresentCompleteKindPixmap

GLX_BufferSwapComplete events and crashes in clutter. Reviewed-by: Eric Anholt e...@anholt.net pgpgYegXXYAJU.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman

[PATCH] glx: Disable indirect GLX contexts by default.

+iglx on the command line). Signed-off-by: Eric Anholt e...@anholt.net --- I kept saying I as going to send out this patch, and since I just crashed my server a few times from trying to run Xephyr -glamor with a broken driver, it's probably time. os/utils.c | 2 +- 1 file changed, 1 insertion

[PATCH 6/8 v2] modesetting: Connect the driver to the build.

v2: Fix libdrm version check, and use XORG_VERSION_* instead of a static 1.0.0 version for the driver module. Signed-off-by: Eric Anholt e...@anholt.net --- Thanks for the review! I've added my s-o-bs (oops), and added your review to the rest of the patches. modesetting-import branch

Re: [PATCH] loader: Remove compatibility with ancient XFree86 version numbering

... Reviewed-by: Eric Anholt e...@anholt.net pgpL3b41X5ymY.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

[PULL] modesetting driver import

after free. modesetting: fix build regression against older servers. Eric Anholt (9): Merge branch 'modesetting-import' into master modesetting: Merge modesetting's COPYING into the xserver's. modesetting: unifdef MODESETTING_OUTPUT_SLAVE_SUPPORT modesetting: xserver

[PATCH] Update help text since -iglx is now the default

From: Jon TURNEY jon.tur...@dronecode.org.uk This should have been part of d0da0e9c3bb8fe0cd4879ecb24d21715bfaa209b Signed-off-by: Jon TURNEY jon.tur...@dronecode.org.uk Signed-off-by: Eric Anholt e...@anholt.net Reviewed-by: Eric Anholt e...@anholt.net --- os/utils.c | 4 ++-- 1 file changed

Re: [PATCH] glamor: Fix leak of converted_bits in _glamor_upload_bits_to_pixmap_texture

Reviewed-by: Eric Anholt e...@anholt.net pgpmY55z0hNnW.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] glamor: Use GL_STREAM_READ also for read/write access to a PBO

-by: Eric Anholt e...@anholt.net pgpzIWcuXJomm.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH 06/19] mi: Remove Windows 8-bpp colormap compatibility

Adam Jackson a...@redhat.com writes: Nice, but not something our Windows servers build, and not something that belongs in mi anyway. Signed-off-by: Adam Jackson a...@redhat.com Reviewed-by: Eric Anholt e...@anholt.net pgpWCyQiIDjh_.pgp Description: PGP signature

Re: [PATCH 08/19] xfree86: Remove xv clip notify driver hook

Adam Jackson a...@redhat.com writes: Nothing's using it. Reviewed-by: Eric Anholt e...@anholt.net pgpV7slCH8rim.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http

<    1   2   3   4   5   6   7   8   9   10   >