Re: [PATCH xf86-video-vmware] Remove obsolete B16 & B32 tags in struct definitions

2018-11-12 Thread Thomas Hellstrom
Hi, On Sat, 2018-11-10 at 13:12 -0800, Alan Coopersmith wrote: > They were defined as empty strings on all platforms except for the > long unsupported Cray systems which needed to use bitfields to define > any type smaller than 64-bits. > > Signed-off-by: Alan Coopersmith > Thanks, Alan.

RR Leases use-after-free bug

2018-06-25 Thread Thomas Hellstrom
Hi! I'd like to draw your attention to bug 106960 where the new leases code accesses freed memory. On xf86-video-vmware it causes a server segfault. On modesetting it doesn't (yet) but can be seen with valgrind. /Thomas ___

Re: [Linux-graphics-maintainer] [PATCH] glamor: Work around GEM usage v2

2018-06-20 Thread Thomas Hellstrom
. This fixes modesetting driver dri2 on vmwgfx. Signed-off-by: Thomas Hellstrom --- v2: Strip changes to an unrelated file. --- glamor/glamor_egl.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/glamor/glamor_egl.c b/glamor/glamor_egl.c index 4a4ca4bd8

Re: Grabbing modesetting ddx related patches for pull request

2018-06-20 Thread Thomas Hellstrom
On 06/20/2018 06:53 PM, Lyude Paul wrote: On Wed, 2018-06-20 at 16:46 +0200, Thomas Hellstrom wrote: On 06/18/2018 10:48 PM, Lyude Paul wrote: To help ajax out with getting a bug release out for Xorg, we figured it would be a good idea for me to go through the stuff I needed to get upstream

[PATCH] glamor: Work around GEM usage v2

2018-06-20 Thread Thomas Hellstrom
supported. This fixes modesetting driver dri2 on vmwgfx. Signed-off-by: Thomas Hellstrom --- v2: Strip changes to an unrelated file. --- glamor/glamor_egl.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/glamor/glamor_egl.c b/glamor/glamor_egl.c index 4a4ca4bd8

Re: Grabbing modesetting ddx related patches for pull request

2018-06-20 Thread Thomas Hellstrom
On 06/18/2018 10:48 PM, Lyude Paul wrote: To help ajax out with getting a bug release out for Xorg, we figured it would be a good idea for me to go through the stuff I needed to get upstream and file pull requests for all of it. This is pretty much the same thing as what I'm doing for EGLStreams

Re: [PATCH xserver] glamor: Work around GEM usage

2018-05-24 Thread Thomas Hellstrom
On 05/24/2018 11:03 AM, Emil Velikov wrote: On 23 May 2018 at 22:23, Mark Kettenis <mark.kette...@xs4all.nl> wrote: From: Thomas Hellstrom <thellst...@vmware.com> Date: Wed, 23 May 2018 22:58:05 +0200 On 05/23/2018 08:00 PM, Adam Jackson wrote: On Wed, 2018-05-23 at 11:14 +

Re: [PATCH xserver] glamor: Work around GEM usage

2018-05-23 Thread Thomas Hellstrom
On 05/23/2018 08:00 PM, Adam Jackson wrote: On Wed, 2018-05-23 at 11:14 +0200, Thomas Hellstrom wrote: KMS drivers are not required to support GEM. In particular, vmwgfx doesn't support flink and handles and names are identical. Getting a bo name should really be part of a lower level API

Re: [PATCH xserver] glamor: Work around GEM usage

2018-05-23 Thread Thomas Hellstrom
On 05/23/2018 11:14 AM, Thomas Hellstrom wrote: KMS drivers are not required to support GEM. In particular, vmwgfx doesn't support flink and handles and names are identical. Getting a bo name should really be part of a lower level API, if needed, but in the mean time work around this by setting

[PATCH xserver] glamor: Work around GEM usage

2018-05-23 Thread Thomas Hellstrom
supported. This fixes modesetting driver dri2 on vmwgfx. Signed-off-by: Thomas Hellstrom <thellst...@vmware.com> --- glamor/glamor_egl.c | 14 -- test-driver | 10 +- 2 files changed, 17 insertions(+), 7 deletions(-) diff --git a/glamor/glamor_egl.c b/glamor/glamor

Re: [PATCH xf86-video-vmware] saa: Build compatibility with xserver 1.20

2018-03-14 Thread Thomas Hellstrom
rver 1.20 fbGetRotatedPixmap went away with 24bpp support, just treat it as NULL and we'll do the right thing. Signed-off-by: Adam Jackson <a...@redhat.com> Signed-off-by: Thomas Hellstrom <thellst...@vmware.com> --- src/common_compat.h | 4 1 file changed, 4 insertions(+) diff --git a/src/

Re: [PATCH xserver] glx: Only assign 8 bpc fbconfigs for composite visuals.

2018-02-09 Thread Thomas Hellstrom
On 02/07/2018 03:18 PM, Mario Kleiner wrote: On 02/06/2018 08:04 PM, Adam Jackson wrote: On Mon, 2018-02-05 at 11:25 +0100, Thomas Hellstrom wrote: On 02/05/2018 11:20 AM, Mario Kleiner wrote: Commit 91c42093b248 ("glx: Duplicate relevant fbconfigs for compositing visuals") add

Re: [PATCH xserver] glx: Only assign 8 bpc fbconfigs for composite visuals.

2018-02-05 Thread Thomas Hellstrom
d-3D104597=DwIBAg=uilaK90D4TOVoH58JNXRgQ=wnSlgOCqfpNS4d02vP68_E9q2BNMCwfD2OZ_6dCFVQQ=IbtkCrmjzJVhB0PdaE0y9A3Zqx2CEYhUPvtI6PeGSEo=6MOlztrQC3tRtcJvqesPVJ1ri_ILRWLMh-iZbrs7NJ0= Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> Cc: Thomas Hellstrom <thellst...@vmware.com> Cc: Adam Jackson <a...@redhat

Re: [PATCH] glx: do not pick sRGB config for 32-bit RGBA visual

2017-12-17 Thread Thomas Hellstrom
On 12/18/2017 08:10 AM, Tapani Pälli wrote: On 12/15/2017 08:32 PM, Thomas Hellstrom wrote: Hi! On 12/15/2017 04:37 PM, Tapani Pälli wrote: Yes it does. And the GLX ARB specification states that sRGB support starts turned off so that it shouldn't affect existing applications that get

Re: [PATCH] glx: do not pick sRGB config for 32-bit RGBA visual

2017-12-15 Thread Thomas Hellstrom
Hi! On 12/15/2017 04:37 PM, Tapani Pälli wrote: Yes it does. And the GLX ARB specification states that sRGB support starts turned off so that it shouldn't affect existing applications that get an sRGB fbconfig by mistake. Is there any mention about 'texture from pixmap' when sRGB is used?

Re: [PATCH] glx: do not pick sRGB config for 32-bit RGBA visual

2017-12-15 Thread Thomas Hellstrom
On 12/15/2017 02:50 PM, Tapani Pälli wrote: Hi; On 15.12.2017 10:10, Thomas Hellstrom wrote: On 12/11/2017 06:53 AM, Tapani Pälli wrote: Hi; Any comments? Without this change there will be issues with certain Linux desktops when distributions start to use Mesa 17.4. Tapani, Did you

Re: [PATCH] glx: do not pick sRGB config for 32-bit RGBA visual

2017-12-15 Thread Thomas Hellstrom
On 12/11/2017 06:53 AM, Tapani Pälli wrote: Hi; Any comments? Without this change there will be issues with certain Linux desktops when distributions start to use Mesa 17.4. Tapani, Did you actually try this with latest xserver master without this patch applied, or with 1.19 only? With it

Re: [PATCH] glx: Duplicate relevant fbconfigs for compositing visuals

2017-11-02 Thread Thomas Hellstrom
Ping? It would be good to resolve this. Thomas On 10/13/2017 07:43 AM, Thomas Hellstrom wrote: Hi, On 10/12/2017 10:32 PM, Adam Jackson wrote: On Thu, 2017-10-12 at 15:06 +0200, Thomas Hellstrom wrote: Ping? If we're going to do this, and I guess we have to, I'd like to see two changes

Re: [PATCH] glx: Duplicate relevant fbconfigs for compositing visuals

2017-10-12 Thread Thomas Hellstrom
Hi, On 10/12/2017 10:32 PM, Adam Jackson wrote: On Thu, 2017-10-12 at 15:06 +0200, Thomas Hellstrom wrote: Ping? If we're going to do this, and I guess we have to, I'd like to see two changes: 1) Don't duplicate single-buffered fbconfigs OK. I was trying to figure out what Nvidia was doing

Re: [PATCH] glx: Duplicate relevant fbconfigs for compositing visuals

2017-10-12 Thread Thomas Hellstrom
Ping? On 10/03/2017 02:19 PM, Thomas Hellstrom wrote: Ping? On 09/27/2017 02:28 AM, Thomas Hellstrom wrote: Previously, before GLX_OML_swap_method was fixed, both the X server and client ignored the swapMethod fbconfig value, which meant that, if the dri driver thought it exposed more than

Re: [PATCH xserver 2/2] glx: Fix visual fbconfig matching with respect to swap method

2017-10-05 Thread Thomas Hellstrom
On 10/03/2017 12:44 PM, Thomas Hellstrom wrote: Hi! On 10/02/2017 11:51 PM, Fredrik Höglund wrote: On Monday 02 October 2017, Thomas Hellstrom wrote: Hi, Fredrik, On 10/02/2017 07:10 PM, Fredrik Höglund wrote: On Tuesday 26 September 2017, Thomas Hellstrom wrote: Hi, Fredrik, On 09/26

Re: [PATCH] glx: Duplicate relevant fbconfigs for compositing visuals

2017-10-03 Thread Thomas Hellstrom
Ping? On 09/27/2017 02:28 AM, Thomas Hellstrom wrote: Previously, before GLX_OML_swap_method was fixed, both the X server and client ignored the swapMethod fbconfig value, which meant that, if the dri driver thought it exposed more than one swapMethod, it actually just exported a duplicated set

Re: [PATCH xserver 2/2] glx: Fix visual fbconfig matching with respect to swap method

2017-10-03 Thread Thomas Hellstrom
Hi! On 10/02/2017 11:51 PM, Fredrik Höglund wrote: On Monday 02 October 2017, Thomas Hellstrom wrote: Hi, Fredrik, On 10/02/2017 07:10 PM, Fredrik Höglund wrote: On Tuesday 26 September 2017, Thomas Hellstrom wrote: Hi, Fredrik, On 09/26/2017 11:53 AM, Fredrik Höglund wrote: On Wednesday

Re: [PATCH xserver 2/2] glx: Fix visual fbconfig matching with respect to swap method

2017-10-02 Thread Thomas Hellstrom
Hi, Fredrik, On 10/02/2017 07:10 PM, Fredrik Höglund wrote: On Tuesday 26 September 2017, Thomas Hellstrom wrote: Hi, Fredrik, On 09/26/2017 11:53 AM, Fredrik Höglund wrote: On Wednesday 06 September 2017, Thomas Hellstrom wrote: For the built in visuals, we'd typically select the "

[PATCH] glx: Duplicate relevant fbconfigs for compositing visuals

2017-09-26 Thread Thomas Hellstrom
visualtype. Fixes: 4486d199bd3b ("glx: Fix visual fbconfig matching with respect to swap method") Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102806 Signed-off-by: Thomas Hellstrom <thellst...@vmware.com> Tested-By: Nick Sarnie <commendsar...@gmail

Re: [RFC PATCH] glx: Try to reduce the number of GLX visuals

2017-09-26 Thread Thomas Hellstrom
On 09/26/2017 05:35 PM, Thomas Hellstrom wrote: Don't create GLX visuals that would be viewed as identical as an already existing GLX visual by glXChooseVisual. Multiple fbconfigs may point to the same GLX visual. Signed-off-by: Thomas Hellstrom <thellst...@vmware.com> --- glx/glxscr

[RFC PATCH] glx: Try to reduce the number of GLX visuals

2017-09-26 Thread Thomas Hellstrom
Don't create GLX visuals that would be viewed as identical as an already existing GLX visual by glXChooseVisual. Multiple fbconfigs may point to the same GLX visual. Signed-off-by: Thomas Hellstrom <thellst...@vmware.com> --- glx/glxscreens.

Re: [PATCH xserver 2/2] glx: Fix visual fbconfig matching with respect to swap method

2017-09-26 Thread Thomas Hellstrom
Hi, Fredrik, On 09/26/2017 11:53 AM, Fredrik Höglund wrote: On Wednesday 06 September 2017, Thomas Hellstrom wrote: For the built in visuals, we'd typically select the "best" fbconfig without considering the swap method. If the client then requests a specific swap method, say GLX_SWA

Re: [PATCH xserver 1/2] glx: Work around a GLX_OML swap method in older dri drivers

2017-09-12 Thread Thomas Hellstrom
Hi! Could someone review this series please, Thanks Thomas On 09/06/2017 04:27 PM, Thomas Hellstrom wrote: The swapMethod config member would typically contain an arbitrary value on older dri drivers. Fix this so that if we detect an illegal value, return GLX_SWAP_UNDEFINED_OML Signed-off

[PATCH xserver 2/2] glx: Fix visual fbconfig matching with respect to swap method

2017-09-06 Thread Thomas Hellstrom
Signed-off-by: Thomas Hellstrom <thellst...@vmware.com> --- glx/glxscreens.c | 9 + 1 file changed, 9 insertions(+) diff --git a/glx/glxscreens.c b/glx/glxscreens.c index 3792927..f000e56 100644 --- a/glx/glxscreens.c +++ b/glx/glxscreens.c @@ -275,6 +275,15 @@ pickFBConfig(__GLXscr

[PATCH xserver 1/2] glx: Work around a GLX_OML swap method in older dri drivers

2017-09-06 Thread Thomas Hellstrom
The swapMethod config member would typically contain an arbitrary value on older dri drivers. Fix this so that if we detect an illegal value, return GLX_SWAP_UNDEFINED_OML Signed-off-by: Thomas Hellstrom <thellst...@vmware.com> --- glx/glxdricommon.c | 7 +++ 1 file changed, 7 inse

Re: [PATCH:xf86-input-vmmouse 2/2 v2] Add NetBSD/amd64 support for iopl calls.

2015-06-26 Thread Thomas Hellstrom
Hi! On 06/26/2015 10:51 AM, Thomas Klausner wrote: Updated patch: move header include lower and be consistent in ifdef vs. if defined Thomas Thanks for the patches! I've reviewed them and pushed them to git master. Unfortunately it will take a couple of weeks until the next release. I

[PATCH 1/2] vmmouse: Run vmmouse_detect as an io privileged process

2015-04-07 Thread Thomas Hellstrom
Many distros already include patches to do this in various more or less hackish ways. Since VMware now is about to restrict access to the VMmouse backdoor, let's try to support it officially. Signed-off-by: Thomas Hellstrom thellst...@vmware.com Acked-by: Sinclair Yeh s...@vmware.com

[PATCH 2/2] vmmouse: Add support for the access restrict command

2015-04-07 Thread Thomas Hellstrom
The access restrict command, if implemented, restricts vmmouse port access to the indicated level. Signed-off-by: Thomas Hellstrom thellst...@vmware.com Reviewed-by: Michael Bancak bana...@vmware.com --- shared/vmmouse_client.c | 7 +++ shared/vmmouse_defs.h | 7 +++ shared

Re: [PATCH] saa: Adapt to GC client clip changes in xserver 1.17

2014-12-10 Thread Thomas Hellstrom
Hi, Sorry for the late response. Best is to send to linux-graphics-maintai...@vmware.com as listed in the xorg maintainer info. The change looks good to me. I just need to run it through our compile-testing-tool Thanks! /Thomas On 12/10/2014 05:05 PM, Adam Jackson wrote: On Thu, 2014-12-04

Re: [PATCH 4/4] modesetting: Add support for rendering using glamor.

2014-11-17 Thread Thomas Hellstrom
Ping? If there's no intention to fix this before 1.17, this commit should probably be reverted. Thanks, Thomas On 11/12/2014 09:38 AM, Thomas Hellstrom wrote: Hi! On 10/08/2014 10:58 AM, Eric Anholt wrote: By default modesetting now tries to enable X acceleration using glamor, but falls

Re: [PATCH 4/4] modesetting: Add support for rendering using glamor.

2014-11-12 Thread Thomas Hellstrom
Hi! On 10/08/2014 10:58 AM, Eric Anholt wrote: By default modesetting now tries to enable X acceleration using glamor, but falls back to normal shadowfb if GL fails to initialize. Signed-off-by: Eric Anholt e...@anholt.net --- hw/xfree86/drivers/modesetting/Makefile.am | 1 +

Re: [PATCH] vmmouse_client.h: Include xorg-server.h before xf86_OSproc.h

2014-10-24 Thread Thomas Hellstrom
On 10/07/2014 11:32 AM, Stefan Dirsch wrote: xf86_OSproc.h cannot be included without first including xorg-server.h. Without this the build fails on systems with the latest glibc, throwing this error: In file included from /usr/include/string.h:634:0, from

Re: [PATCH] xf86xv.h cannot be included without first including xorg-server.h.

2014-10-14 Thread Thomas Hellstrom
On 10/14/2014 05:37 AM, Michel Dänzer wrote: On 14.10.2014 12:25, Stefan Dirsch wrote: On Tue, Oct 14, 2014 at 10:02:13AM +0900, Michel Dänzer wrote: On 13.10.2014 21:58, Stefan Dirsch wrote: On Tue, Oct 07, 2014 at 11:56:55AM +0100, Daniel Stone wrote: Hi, On 7 October 2014 10:54, Michel

Re: [PATCH] Back off if we detect a vmmouse kernel driver v3

2014-10-08 Thread Thomas Hellstrom
On 10/07/2014 05:01 PM, Sinclair Yeh wrote: Reviewed-by: Sinclair Yeh s...@vmware.com Thanks for the review. Pushed. /Thomas On Mon, Oct 06, 2014 at 10:30:12PM +0200, Thomas Hellstrom wrote: On 10/06/2014 04:59 PM, Sinclair Yeh wrote: On Mon, Oct 06, 2014 at 01:17:13PM +0200, Thomas

[PATCH] Back off if we detect a vmmouse kernel driver v3

2014-10-06 Thread Thomas Hellstrom
handling. Signed-off-by: Thomas Hellstrom thellst...@vmware.com --- configure.ac | 14 +++ tools/Makefile.am | 7 +++- tools/vmmouse_detect.c | 5 +++ tools/vmmouse_udev.c | 105 + 4 files changed, 129 insertions(+), 2

Re: [PATCH] Back off if we detect a vmmouse kernel driver v3

2014-10-06 Thread Thomas Hellstrom
On 10/06/2014 04:59 PM, Sinclair Yeh wrote: On Mon, Oct 06, 2014 at 01:17:13PM +0200, Thomas Hellstrom wrote: If a vmmouse kernel driver is active, vmmouse input is handled by the Xorg evdev driver and not by the vmmouse driver, so make sure the vmmouse_detect utility doesn't detect a vmmouse

[PATCH vmmouse] Back off if we detect a vmmouse kernel driver v2

2014-10-02 Thread Thomas Hellstrom
If a vmmouse kernel driver is active, vmmouse input is handled by the Xorg evdev driver and not by the vmmouse driver, so make sure the vmmouse_detect utility doesn't detect a vmmouse if a kernel driver is active. v2: Change the vmmouse kernel device name, fix comment. Signed-off-by: Thomas

Re: [PATCH vmmouse] Back off if we detect a vmmouse kernel driver v2

2014-10-02 Thread Thomas Hellstrom
On 10/02/2014 02:42 PM, Hans de Goede wrote: Hi, On 10/02/2014 02:39 PM, Thomas Hellstrom wrote: If a vmmouse kernel driver is active, vmmouse input is handled by the Xorg evdev driver and not by the vmmouse driver, so make sure the vmmouse_detect utility doesn't detect a vmmouse if a kernel

Re: vmmouse kernel driver

2014-09-28 Thread Thomas Hellstrom
On 09/29/2014 01:48 AM, Peter Hutterer wrote: On Fri, Sep 26, 2014 at 02:44:15PM +0200, Hans de Goede wrote: Hi, On 09/26/2014 09:06 AM, Thomas Hellstrom wrote: Hi! On 09/26/2014 03:36 AM, Peter Hutterer wrote: On Wed, Sep 24, 2014 at 11:12:50AM +0200, Thomas Hellstrom wrote: While

Re: vmmouse kernel driver

2014-09-26 Thread Thomas Hellstrom
Hi! On 09/26/2014 03:36 AM, Peter Hutterer wrote: On Wed, Sep 24, 2014 at 11:12:50AM +0200, Thomas Hellstrom wrote: While looking at a vmmouse kernel driver, I wonder how the Xorg evdev driver can be configured to receive both absolute and relative events from the same device as the vmmouse

vmmouse kernel driver

2014-09-24 Thread Thomas Hellstrom
Hi! While looking at a vmmouse kernel driver, I wonder how the Xorg evdev driver can be configured to receive both absolute and relative events from the same device as the vmmouse sometimes sends absolute events and sometimes relative. Is the IgnoreAbsoluteAxes False option sufficient? Thanks,

dri2 and vtSema

2013-09-24 Thread Thomas Hellstrom
Hi! I'm not completely sure what's the correct list for this nowadays, so forgive me for crossposting. I've got an interesting problem in that when any dri2 operations are carried out while the X server is switched away, they are pushed all the way down to the kernel graphics driver, which

Re: [PATCH vmware] Build fix for ABI version 12

2011-11-17 Thread Thomas Hellstrom
Jeremy, When submitting and commiting patches for the vmware driver please follow the guidelines outlined in http://wiki.x.org/wiki/vmware Not following this messes up our internal testing. Thanks, Thomas On 10/07/2011 10:22 PM, Thomas Hellstrom wrote: On 10/07/2011 10:19 PM, Jeremy

Re: [PATCH vmware] Build fix for ABI version 12

2011-11-17 Thread Thomas Hellstrom
On 11/17/2011 08:25 PM, Jeremy Huddleston wrote: Hi Thomas, I didn't realize you had restrictions on your trees. I just wanted to get your driver building again. Patches are much appreciated! Thanks, Thomas ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH vmware] Build fix for ABI version 12

2011-10-07 Thread Thomas Hellstrom
On 10/07/2011 10:19 PM, Jeremy Huddleston wrote: This results in the vmware driver assuming there is only one PCI domain, which I think is true for everywhere this is expected to run anyway. Signed-off-by: Jeremy Huddlestonjerem...@apple.com --- This gets vmware building with my recent bus

Re: [PATCH xf86-video-vmware] Use dixLookupWindow instead of LookupWindow on Xorg 1.5 later

2011-10-05 Thread Thomas Hellstrom
On 10/01/2011 06:07 PM, Alan Coopersmith wrote: On 09/27/11 07:31 PM, Alan Coopersmith wrote: +static inline int +dixLookupWindow(WindowPtr *pWin, XID id, ClientPtr client, Mask access) +{ +*pWin = LookupWindow(stuff-window, client); Oops, just noticed that should be LookupWindow(id,

Re: [PATCH xf86-video-vmware] Use dixLookupWindow instead of LookupWindow on Xorg 1.5 later

2011-09-29 Thread Thomas Hellstrom
Alan, On 09/28/2011 04:31 AM, Alan Coopersmith wrote: The LookupWindow function was deprecated in xserver commit ed75b056511ccb4 and removed during the Xorg 1.11 merge window by commit 82a8677d9175732. Signed-off-by: Alan Coopersmithalan.coopersm...@oracle.com --- Needed for compatibility

What's up with Xv cliprects?

2011-03-23 Thread Thomas Hellstrom
Hi! I just tried Xserver 1.10 on Ubuntu 11.04 and noticed that regardless of whether I put another window on top of a non-redirected Xv window, XvPutImage will only be sent a single cliprect covering the whole window. Needless to say this is bad news for any other window that happens to be

Re: What's up with Xv cliprects?

2011-03-23 Thread Thomas Hellstrom
On 03/23/2011 04:38 PM, Ville Syrjälä wrote: On Wed, Mar 23, 2011 at 03:36:16PM +0100, ext Thomas Hellstrom wrote: Hi! I just tried Xserver 1.10 on Ubuntu 11.04 and noticed that regardless of whether I put another window on top of a non-redirected Xv window, XvPutImage will only be sent

Re: [PATCH xf86-video-vmware] Remove unused variable.

2011-03-03 Thread Thomas Hellstrom
On 02/26/2011 01:57 PM, Cyril Brulebois wrote: Signed-off-by: Cyril Bruleboisk...@debian.org Pushed, Thanks! Sorry for the delay. Thomas ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info:

Re: [PATCH xf86-video-vmware] Fix include order.

2011-01-21 Thread Thomas Hellstrom
You're right. This was caused by a sloppy fix by me for another problem. I'll revert that fix tomorrow and try to find a correct fix for that problem. /Thomas On 01/21/2011 10:57 PM, Gaetan Nadon wrote: On Fri, 2011-01-21 at 20:07 +0100, Cyril Brulebois wrote: HAVE_LIBDRM comes from

Re: [PATCH vmmouse 1/4] Replace LocalDevicePtr with InputInfoPtr.

2010-11-04 Thread Thomas Hellstrom
This patch series has been reviewed, tested and pushed. Thanks, /Thomas On 11/02/2010 12:09 AM, Peter Hutterer wrote: The LocalDevicePtr define was removed from the server with ABI 12, but InputInfoPtr has been an alias for it since the Xfree86/Xorg fork. Signed-off-by: Peter

Re: [PATCH input-vmmouse 2/3] config: upgrade to util-macros 1.8 for additional man page support

2010-10-21 Thread Thomas Hellstrom
...@videotron.ca Build-tested on servers 1.0 through 1.9. Please add the below Acked-by and push. Acked-by: Thomas Hellstrom thellst...@vmware.com --- configure.ac|7 +++ man/Makefile.am | 21 + 2 files changed, 4 insertions(+), 24 deletions(-) diff --git

Re: [PATCH input-vmmouse 3/3] tools make: use Autoconf provided $(AM_V_GEN)$(SED)

2010-10-21 Thread Thomas Hellstrom
On 10/20/2010 02:20 AM, Gaetan Nadon wrote: Enables silent rule and use platform appropriate version of sed. Signed-off-by: Gaetan Nadonmems...@videotron.ca Build-tested on servers 1.0 through 1.9. Please add the below Acked-by and push. Acked-by: Thomas Hellstrom thellst...@vmware.com

Re: [PATCH input-vmmouse 1/3] make: remove duplicate definition of EXTRA_DIST

2010-10-21 Thread Thomas Hellstrom
1.0 through 1.9. Please add the below Acked-by and push. Acked-by: Thomas Hellstrom thellst...@vmware.com --- tools/Makefile.am |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/tools/Makefile.am b/tools/Makefile.am index 77a9731..b7357b9 100644 --- a/tools/Makefile.am

Re: [PATCH input-vmmouse 1/3] make: remove duplicate definition of EXTRA_DIST

2010-10-21 Thread Thomas Hellstrom
On 10/21/2010 01:04 PM, Peter Hutterer wrote: On 21/10/10 18:59 , Thomas Hellstrom wrote: On 10/20/2010 02:20 AM, Gaetan Nadon wrote: autoreconf -vfi produces this output: tools/Makefile.am:59: EXTRA_DIST multiply defined in condition TRUE ... tools/Makefile.am:36: ... `EXTRA_DIST

Re: [PATCH input-vmmouse 1/3] make: remove duplicate definition of EXTRA_DIST

2010-10-21 Thread Thomas Hellstrom
On 10/21/2010 09:03 PM, Gaetan Nadon wrote: On Thu, 2010-10-21 at 14:43 +0200, Thomas Hellstrom wrote: Sure, I can take care of that. I'll push these three. I have one question. I noticed the patches have been applied in reverse order. Would that be because of the branch merging ? I am

Re: [PATCH xf86-input-vmmouse v3 2/2] InputDriverRec XINPUT cleanup.

2010-10-20 Thread Thomas Hellstrom
Reviewed-by: Thomas Hellstrom thellst...@vmware.com Is there a patch to bump the Input ABI major number in flight somewhere? /Thomas On 10/19/2010 09:52 PM, Trevor Woerner wrote: From: Trevor Woernertwoer...@gmail.com ABI version 12 of the InputDriverRec data structure no longer includes

Re: [PATCH xf86-input-vmmouse v3 2/2] InputDriverRec XINPUT cleanup.

2010-10-20 Thread Thomas Hellstrom
On 10/20/2010 08:18 AM, Thomas Hellstrom wrote: Reviewed-by: Thomas Hellstromthellst...@vmware.com Is there a patch to bump the Input ABI major number in flight somewhere? Never mind, I just saw the mail from Peter in the ABI thread. Thanks, Thomas /Thomas On 10/19/2010 09:52 PM

Re: [PATCH xf86-input-vmmouse 1/2] Deprecated code cleanup.

2010-10-19 Thread Thomas Hellstrom
On 10/19/2010 01:14 AM, Peter Hutterer wrote: On Mon, Oct 18, 2010 at 12:11:24PM -0400, Trevor Woerner wrote: From: Trevor Woernertwoer...@gmail.com Signed-off-by: Trevor Woernertwoer...@gmail.com Reviewed-by: Peter Huttererpeter.hutte...@who-t.net Nak in its current form.

Re: [PATCH xf86-input-vmmouse 2/2] InputDriverRec cleanup.

2010-10-19 Thread Thomas Hellstrom
On 10/19/2010 01:15 AM, Peter Hutterer wrote: On Mon, Oct 18, 2010 at 12:12:18PM -0400, Trevor Woerner wrote: From: Trevor Woernertwoer...@gmail.com The InputDriverRec data structure no longer includes the refCount member. Signed-off-by: Trevor Woernertwoer...@gmail.com

Re: [PATCH xf86-input-vmmouse 1/2] Deprecated code cleanup.

2010-10-19 Thread Thomas Hellstrom
On 10/19/2010 02:50 PM, Trevor Woerner wrote: On Tue, Oct 19, 2010 at 2:26 AM, Thomas Hellstrom thellst...@shipmail.org wrote: On 10/19/2010 01:14 AM, Peter Hutterer wrote: Nak in its current form. (please see how this was done in one of the latest commits of xf86-video-vmware

Re: [PATCH xf86-input-vmmouse 1/2] Deprecated code cleanup.

2010-10-19 Thread Thomas Hellstrom
On 10/19/2010 04:13 PM, Trevor Woerner wrote: On Tue, Oct 19, 2010 at 9:00 AM, Thomas Hellstromthellst...@vmware.com wrote: On 10/19/2010 02:50 PM, Trevor Woerner wrote: Instead of defining a HAVE_XORG_SERVER_1_5_0 flag at configure time, IMO it's also OK to define such a flag during

Re: ABI questions

2010-10-19 Thread Thomas Hellstrom
On 10/19/2010 05:18 PM, Trevor Woerner wrote: Thanks so much, Peter, for taking the time to reply. The following is what I've tried to understand from poking around. I'd appreciate any clarifications if I'm off-track: From what I can tell, there are 5 ABI's which are important to the code,

Re: [PATCH xf86-input-vmmouse v2 2/2] InputDriverRec XINPUT cleanup.

2010-10-19 Thread Thomas Hellstrom
Trevor, Please see below. On 10/19/2010 09:10 PM, Trevor Woerner wrote: From: Trevor Woernertwoer...@gmail.com ABI version 11 of the InputDriverRec data structure no longer includes the refCount member. Signed-off-by: Trevor Woernertwoer...@gmail.com --- src/vmmouse.c |5 - 1 files

ABI breakage

2010-10-14 Thread Thomas Hellstrom
Hi! Isn't the commit 5c6a2f93ebc16a78093782b442306de23ae94e78 xfree86: Kill pixmapPrivate with a vengeance (v2) a major ABI breakage (It alters the layout of the ScreenInfoRec structure and also there are drivers hacking the pixmatPrivate member to workaround the problem of the root

Re: ABI breakage

2010-10-14 Thread Thomas Hellstrom
On 10/14/2010 06:11 PM, Thomas Hellstrom wrote: Hi! Isn't the commit 5c6a2f93ebc16a78093782b442306de23ae94e78 xfree86: Kill pixmapPrivate with a vengeance (v2) a major ABI breakage (It alters the layout of the ScreenInfoRec structure and also there are drivers hacking the pixmatPrivate

Re: ABI breakage

2010-10-14 Thread Thomas Hellstrom
On 10/14/2010 09:08 PM, Aaron Plattner wrote: On Thu, Oct 14, 2010 at 12:00:40PM -0700, Thomas Hellstrom wrote: On 10/14/2010 06:11 PM, Thomas Hellstrom wrote: Hi! Isn't the commit 5c6a2f93ebc16a78093782b442306de23ae94e78 xfree86: Kill pixmapPrivate with a vengeance (v2) a major

Re: [PATCH] linux: Don't lose console events on non-evdev drivers (#29969)

2010-09-06 Thread Thomas Hellstrom
On 09/06/2010 03:52 AM, Peter Hutterer wrote: From: Thomas Hellstromthellst...@vmware.com The drain_console() function will race with new keyboard events being added by the hardware causing the server to lose keyboard events if the console fd is used for input. Only use the drain_console()

Re: [PATCH/RFC] xfree86: add a hook to replace the new console handler.

2010-09-06 Thread Thomas Hellstrom
On 09/06/2010 03:56 AM, Peter Hutterer wrote: since we haven't bumped the API yet for 1.10 and I've got a lot of changes anyway, queing this one up for input abi 12 would be easy. hw/xfree86/common/xf86.h |1 + hw/xfree86/common/xf86Events.c | 19

X server losing keyboard events

2010-09-05 Thread Thomas Hellstrom
Hi! Just wanted to make people aware of bug 29969, which IMHO is pretty nasty. /Thomas ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

VMware drivers maintainers

2010-08-18 Thread Thomas Hellstrom
Hi! I've updated the maintainer contact info and patch- and release policies for the VMware drivers: Basically this means that we would like all patches touching these drivers to have an Acked-by: or Signed-off-by: the VMware maintainer before pushed. Releases should be cut only by the

Re: VMware drivers maintainers

2010-08-18 Thread Thomas Hellstrom
On 08/18/2010 02:00 PM, Gaetan Nadon wrote: On Wed, 2010-08-18 at 10:48 +0200, Thomas Hellstrom wrote: I've updated the maintainer contact info and patch- and release policies for the VMware drivers: Excellent. thanks. About vmwarectrl directory in video vmware. It's not reachable during

Re: VMware drivers maintainers

2010-08-18 Thread Thomas Hellstrom
On 08/18/2010 03:00 PM, Gaetan Nadon wrote: On Wed, 2010-08-18 at 14:09 +0200, Thomas Hellstrom wrote: It appears that the vmwarectrl program has its own configure.ac script, so it won't be compiled unless explicitly configured and build in that directory. Correct. It's the only package out

[PATCH 0/1 dri2] Bump dri2 version minor.

2009-12-31 Thread Thomas Hellstrom
This change should really have been done at an earlier time, and it should probably be backported to the Xserver 1.7 branch. Dri2 clients need to know whether to request a fake front or not. As of some time ago, the DRI2 server side automatically adds a fake front to window drawables if there

[PATCH 1/1 dri2] Bump dri2 version minor.

2009-12-31 Thread Thomas Hellstrom
A feature was added to the DRI2 server side to always create a fake front buffer when requesting the real front-buffer for a window. A client needs to detect whether this feature is present or not, and can now do so by version checking. Signed-off-by: Thomas Hellstrom thellst...@vmware.com