Re: [Xournal-devel] MRU

2014-12-14 Thread Romano Gtti (comp)
On 14/12/14 07:05, D M German wrote: > > --page N > > to jump to the N-th page in the document (or the last one if N > page > numbers). > > These were all the options I implemented: > >-p, --page=N Jump to Page >-e, --export-pdf=FILENAME Export document to a PDF file

Re: [Xournal-devel] MRU

2014-12-13 Thread D M German
Hi Denis, Denis Auroux twisted the bytes to say: Denis> Thanks for the work on saving pages in the MRU! I don't have Denis> time to review the patch carefully at the moment, but at least Denis> I've downloaded and played with it and it seems to do the right Denis> thing. I'll keep testing

Re: [Xournal-devel] MRU

2014-12-13 Thread Denis Auroux
Hi Daniel, Thanks for the work on saving pages in the MRU! I don't have time to review the patch carefully at the moment, but at least I've downloaded and played with it and it seems to do the right thing. [metadata use for saving last page] > Denis, if you use Linux, I think you will like it.

Re: [Xournal-devel] MRU

2014-12-12 Thread D M German
Hi Denis, Denis> Hi Daniel, Denis> Yes, the top of the MRU does always have the current document as soon as Denis> there is a .xoj file name available (i.e., either we opened an existing Denis> .xoj file, or it was created from scratch and saved to disk). So, all Denis> that should be n

Re: [Xournal-devel] MRU

2014-12-10 Thread Michael Walter
Hi Daniel and Denis, the issue is that if you are running two instances of xournal (i.e., edit two documents in parallel) then upon closing the second instance the MRU entries added by the first instance are plainly overwritten. Since I usually have more than a single instance of xournal running,

Re: [Xournal-devel] MRU

2014-12-10 Thread D M German
Denis> Hi Michael, >> the discussion on MRU reminded me of another problem, namely that if one >> is running multiple instances of Xournal then the MRU file tends to be >> overwritten instead of extended. I do not know of the top of my head if >> this is still the case. If yes then perhaps t

Re: [Xournal-devel] MRU

2014-12-10 Thread dmg
this is the actual patch. https://github.com/dmgerman/xournal/commit/40470be71ddf130a6f64ac7581498500cd2d58be On Wed, Dec 10, 2014 at 1:51 AM, dmg wrote: > Here is the code I have been working on. I think it works, but needs testing > > It is the branch mru > > https://github.com/dmgerman/xourna

Re: [Xournal-devel] MRU

2014-12-10 Thread Denis Auroux
Hi Daniel, > In general, the standard way to do this is to have a "Revert" option in > the menu. It will be cleaner from the point of view of the user (and > implementation too). Hmm, but a menu entry called "revert xoj and update pdf" seems rather complicated conceptually. I guess we could call

Re: [Xournal-devel] MRU

2014-12-10 Thread dmg
Here is the code I have been working on. I think it works, but needs testing It is the branch mru https://github.com/dmgerman/xournal/tree/mru i did some refactoring of the mru code and added some functions to maintain encapsulation. I also looked into evince. evince uses gvfs to save the page

Re: [Xournal-devel] MRU

2014-12-10 Thread Denis Auroux
Hi Michael, > the discussion on MRU reminded me of another problem, namely that if one > is running multiple instances of Xournal then the MRU file tends to be > overwritten instead of extended. I do not know of the top of my head if > this is still the case. If yes then perhaps the MRU list shoul

Re: [Xournal-devel] MRU

2014-12-09 Thread D M German
Denis> Hi Daniel, [..] Denis> (By the way, one could modify the MRU logic so that the filename also gets inserted into the MRU only when the file is discarded, rather than when it is opened Denis> or assigned a name -- so, at the same time that we update the page number in the MRU. This wo

Re: [Xournal-devel] MRU

2014-12-09 Thread Michael Walter
Hi all, the discussion on MRU reminded me of another problem, namely that if one is running multiple instances of Xournal then the MRU file tends to be overwritten instead of extended. I do not know of the top of my head if this is still the case. If yes then perhaps the MRU list should be re-read

Re: [Xournal-devel] MRU

2014-12-09 Thread Denis Auroux
Hi Daniel, Yes, the top of the MRU does always have the current document as soon as there is a .xoj file name available (i.e., either we opened an existing .xoj file, or it was created from scratch and saved to disk). So, all that should be needed in order to save the last page viewed is for

Re: [Xournal-devel] MRU

2014-12-09 Thread dmg
On Tue, Dec 9, 2014 at 2:06 PM, D M German wrote: > > 2. When should the MRU be updated with the page number? The current > document does not have an entry. I gets it when it is saved. so my gut > feeling tells me when the xournal is saved. What do you think? Oh, but then it will not be very usa

[Xournal-devel] MRU

2014-12-09 Thread D M German
Hi Denis, I have created code to add a page number to the MRU. So far so good. i have two questions though: 1. Should we make the size of the MRU a parameter in the config file? 2. When should the MRU be updated with the page number? The current document does not have an entry. I gets it when