[
https://issues.apache.org/jira/browse/YARN-9560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844919#comment-16844919
]
Jim Brennan commented on YARN-9560:
---
Thanks for the updates [~ebadger]!
Some comments on the new patch:
[
https://issues.apache.org/jira/browse/YARN-9561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844311#comment-16844311
]
Jim Brennan commented on YARN-9561:
---
[~ebadger] thanks for the patch! I did an extensive review of this
[
https://issues.apache.org/jira/browse/YARN-9560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844121#comment-16844121
]
Jim Brennan commented on YARN-9560:
---
[~ebadger] Thanks for the patch. Overall this looks like a good
[
https://issues.apache.org/jira/browse/YARN-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16839719#comment-16839719
]
Jim Brennan commented on YARN-2194:
---
As I mentioned in [YARN-9518], I am also +1 on this patch for
[
https://issues.apache.org/jira/browse/YARN-9518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16839693#comment-16839693
]
Jim Brennan commented on YARN-9518:
---
Thanks [~jhung]! The patch looks good to me. I also built it and
[
https://issues.apache.org/jira/browse/YARN-9518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16839570#comment-16839570
]
Jim Brennan commented on YARN-9518:
---
[~shurong.mai], ideally we would use the same solution in 2.7 that
[
https://issues.apache.org/jira/browse/YARN-9518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836669#comment-16836669
]
Jim Brennan commented on YARN-9518:
---
[~shurong.mai], i believe that [~jhung] is correct, and this
[
https://issues.apache.org/jira/browse/YARN-9527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836638#comment-16836638
]
Jim Brennan commented on YARN-9527:
---
I was able to repro the problem in branch-2.8 on a one-node-cluster
[
https://issues.apache.org/jira/browse/YARN-9527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836456#comment-16836456
]
Jim Brennan commented on YARN-9527:
---
Thanks for the review [~ebadger]! I've put up another patch that
[
https://issues.apache.org/jira/browse/YARN-9527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Brennan updated YARN-9527:
--
Attachment: YARN-9527.004.patch
> Rogue LocalizerRunner/ContainerLocalizer repeatedly downloading same
[
https://issues.apache.org/jira/browse/YARN-9527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16835623#comment-16835623
]
Jim Brennan commented on YARN-9527:
---
I put up patch 003 to address the checkstyle issues.
> Rogue
[
https://issues.apache.org/jira/browse/YARN-9527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Brennan updated YARN-9527:
--
Attachment: YARN-9527.003.patch
> Rogue LocalizerRunner/ContainerLocalizer repeatedly downloading same
[
https://issues.apache.org/jira/browse/YARN-9527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Brennan updated YARN-9527:
--
Attachment: YARN-9527.002.patch
> Rogue LocalizerRunner/ContainerLocalizer repeatedly downloading same
[
https://issues.apache.org/jira/browse/YARN-9527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Brennan reassigned YARN-9527:
-
Assignee: Jim Brennan
> Rogue LocalizerRunner/ContainerLocalizer repeatedly downloading same
[
https://issues.apache.org/jira/browse/YARN-9527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831903#comment-16831903
]
Jim Brennan commented on YARN-9527:
---
I was able to find a node where the problem was actively happening,
[
https://issues.apache.org/jira/browse/YARN-9527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831883#comment-16831883
]
Jim Brennan commented on YARN-9527:
---
For example, we recently had a case where all of the disks used by
Jim Brennan created YARN-9527:
-
Summary: Rogue LocalizerRunner/ContainerLocalizer repeatedly
downloading same file
Key: YARN-9527
URL: https://issues.apache.org/jira/browse/YARN-9527
Project: Hadoop YARN
[
https://issues.apache.org/jira/browse/YARN-9518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830347#comment-16830347
]
Jim Brennan commented on YARN-9518:
---
[~shurong.mai], your patch needs to be based on branch trunk. I
[
https://issues.apache.org/jira/browse/YARN-9518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829328#comment-16829328
]
Jim Brennan commented on YARN-9518:
---
[~shurong.mai], are you running with the latest code (trunk)? The
[
https://issues.apache.org/jira/browse/YARN-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826198#comment-16826198
]
Jim Brennan commented on YARN-9486:
---
[~eyang] thanks for updating the comment. +1 (non-binding) on
[
https://issues.apache.org/jira/browse/YARN-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826142#comment-16826142
]
Jim Brennan commented on YARN-9486:
---
[~eyang], I am +1 (non-binding) on patch 004.
> Docker container
[
https://issues.apache.org/jira/browse/YARN-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826101#comment-16826101
]
Jim Brennan commented on YARN-9486:
---
{quote}
As the result, we need to check both markedLaunched and
[
https://issues.apache.org/jira/browse/YARN-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825465#comment-16825465
]
Jim Brennan commented on YARN-9486:
---
{quote}Patch 003 added the safe guard for missing pid file, and
[
https://issues.apache.org/jira/browse/YARN-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825404#comment-16825404
]
Jim Brennan commented on YARN-9486:
---
[~eyang]
{quote}
The right logic is probably try to locate it
[
https://issues.apache.org/jira/browse/YARN-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825333#comment-16825333
]
Jim Brennan commented on YARN-9486:
---
[~eyang] I am not too familiar with the ContainerRelaunch path, but
[
https://issues.apache.org/jira/browse/YARN-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825222#comment-16825222
]
Jim Brennan commented on YARN-9486:
---
[~eyang] I'm not sure I agree. This suggests that
[
https://issues.apache.org/jira/browse/YARN-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823309#comment-16823309
]
Jim Brennan commented on YARN-9486:
---
{quote}
It looks like the problem is in the usage of
[
https://issues.apache.org/jira/browse/YARN-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823189#comment-16823189
]
Jim Brennan commented on YARN-9486:
---
[~eyang] I'm just trying to understand the logic here.
[
https://issues.apache.org/jira/browse/YARN-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16822028#comment-16822028
]
Jim Brennan commented on YARN-9486:
---
[~eyang], why is launch.markLaunched() returning false in this
[
https://issues.apache.org/jira/browse/YARN-7848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16815434#comment-16815434
]
Jim Brennan commented on YARN-7848:
---
Thanks for updating [~eyang]! lgtm. I am +1 on patch 004
[
https://issues.apache.org/jira/browse/YARN-7848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814627#comment-16814627
]
Jim Brennan commented on YARN-7848:
---
Thanks [~eyang] for the update!
Some comments:
In
[
https://issues.apache.org/jira/browse/YARN-7848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812744#comment-16812744
]
Jim Brennan commented on YARN-7848:
---
[~eyang], [~ebadger], it looks to me like the code in patch 002
[
https://issues.apache.org/jira/browse/YARN-9442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811131#comment-16811131
]
Jim Brennan commented on YARN-9442:
---
[~eyang] thanks for testing! I also ran terasort as part of my
[
https://issues.apache.org/jira/browse/YARN-9442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811021#comment-16811021
]
Jim Brennan commented on YARN-9442:
---
{quote}
I think the group read permission is used by shuffle
[
https://issues.apache.org/jira/browse/YARN-9442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811011#comment-16811011
]
Jim Brennan commented on YARN-9442:
---
I have put up patch.002 which adds a check to the
[
https://issues.apache.org/jira/browse/YARN-9442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Brennan updated YARN-9442:
--
Attachment: YARN-9442.002.patch
> container working directory has group read permissions
>
[
https://issues.apache.org/jira/browse/YARN-9442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16809950#comment-16809950
]
Jim Brennan edited comment on YARN-9442 at 4/4/19 3:25 PM:
---
Specifically, we
[
https://issues.apache.org/jira/browse/YARN-9442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16809950#comment-16809950
]
Jim Brennan edited comment on YARN-9442 at 4/4/19 3:23 PM:
---
Specifically, we
[
https://issues.apache.org/jira/browse/YARN-9442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Brennan reassigned YARN-9442:
-
Assignee: Jim Brennan
> container working directory has group read permissions
>
[
https://issues.apache.org/jira/browse/YARN-9442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16809950#comment-16809950
]
Jim Brennan commented on YARN-9442:
---
Specifically, we have something like this now:
{noformat}
[
https://issues.apache.org/jira/browse/YARN-9442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Brennan updated YARN-9442:
--
Priority: Minor (was: Major)
> container working directory has group read permissions
>
Jim Brennan created YARN-9442:
-
Summary: container working directory has group read permissions
Key: YARN-9442
URL: https://issues.apache.org/jira/browse/YARN-9442
Project: Hadoop YARN
Issue
[
https://issues.apache.org/jira/browse/YARN-7848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16802833#comment-16802833
]
Jim Brennan commented on YARN-7848:
---
I think I agree with [~eyang] on the use of {{-f}}. By the time we
[
https://issues.apache.org/jira/browse/YARN-8200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801916#comment-16801916
]
Jim Brennan commented on YARN-8200:
---
Thanks [~jhung]. Is the intention to propose a 2.10 release with
[
https://issues.apache.org/jira/browse/YARN-9391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16800957#comment-16800957
]
Jim Brennan commented on YARN-9391:
---
[~ebadger], [~eyang] patch 001 is ready for review.
> Disable
[
https://issues.apache.org/jira/browse/YARN-9391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Brennan updated YARN-9391:
--
Attachment: YARN-9391.001.patch
> Disable PATH variable to be passed to Docker container
>
[
https://issues.apache.org/jira/browse/YARN-9391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797182#comment-16797182
]
Jim Brennan commented on YARN-9391:
---
OK. I will put up a patch to fix this issue.
> Disable PATH
[
https://issues.apache.org/jira/browse/YARN-9391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Brennan reassigned YARN-9391:
-
Assignee: Jim Brennan
> Disable PATH variable to be passed to Docker container
>
[
https://issues.apache.org/jira/browse/YARN-9391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796597#comment-16796597
]
Jim Brennan commented on YARN-9391:
---
[~eyang] if the concern is only for Nodemanager white-list
[
https://issues.apache.org/jira/browse/YARN-9391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796560#comment-16796560
]
Jim Brennan commented on YARN-9391:
---
[~ebadger] I assume you are referring to the PATH variable in
[
https://issues.apache.org/jira/browse/YARN-9391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796521#comment-16796521
]
Jim Brennan commented on YARN-9391:
---
{quote}
The whitelist needs to behave differently for docker
[
https://issues.apache.org/jira/browse/YARN-9391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796227#comment-16796227
]
Jim Brennan commented on YARN-9391:
---
[~ebadger] you are correct. It doesn't look like we explicitly add
[
https://issues.apache.org/jira/browse/YARN-8200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793917#comment-16793917
]
Jim Brennan commented on YARN-8200:
---
[~jhung] what is the status of this effort? Are you still working
[
https://issues.apache.org/jira/browse/YARN-8376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16792661#comment-16792661
]
Jim Brennan commented on YARN-8376:
---
+1 on patch 003 (non-binding)
> Separate white list for
[
https://issues.apache.org/jira/browse/YARN-8376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16792100#comment-16792100
]
Jim Brennan commented on YARN-8376:
---
To be clear, I am ok with the approach used in patch 002, where
[
https://issues.apache.org/jira/browse/YARN-8376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16791855#comment-16791855
]
Jim Brennan commented on YARN-8376:
---
[~eyang] [~ebadger] sorry for joining this late. It seems like the
[
https://issues.apache.org/jira/browse/YARN-7129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16791024#comment-16791024
]
Jim Brennan commented on YARN-7129:
---
{quote}Now, Hadoop build process intended to introduce inline
[
https://issues.apache.org/jira/browse/YARN-7129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790838#comment-16790838
]
Jim Brennan commented on YARN-7129:
---
I agree with [~ebadger]. Suddenly today I am unable to build
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786121#comment-16786121
]
Jim Brennan commented on YARN-5714:
---
Thanks [~eepayne]! I re-uploaded the branch-2 patch.
>
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Brennan updated YARN-5714:
--
Attachment: (was: YARN-5714-branch-2.001.patch)
> ContainerExecutor does not order environment map
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Brennan updated YARN-5714:
--
Attachment: YARN-5714-branch-2.001.patch
> ContainerExecutor does not order environment map
>
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Brennan reassigned YARN-5714:
-
Assignee: Remi Catherinot (was: Jim Brennan)
> ContainerExecutor does not order environment map
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16783437#comment-16783437
]
Jim Brennan commented on YARN-5714:
---
cc: [~eepayne]
I changed the assignee back to [~rcatherinot] - I
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Brennan updated YARN-5714:
--
Attachment: YARN-5714-branch-2.8.001.patch
YARN-5714-branch-2.001.patch
>
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Brennan reopened YARN-5714:
---
Assignee: Jim Brennan (was: Remi Catherinot)
Re-opening so I can put up branch-2 patches.
>
[
https://issues.apache.org/jira/browse/YARN-9098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16777136#comment-16777136
]
Jim Brennan commented on YARN-9098:
---
I downloaded patch 007, built it and ran unit tests.
+1 this looks
[
https://issues.apache.org/jira/browse/YARN-9098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763695#comment-16763695
]
Jim Brennan commented on YARN-9098:
---
[~snemeth] thanks for updating the patch! I agree with your fix
[
https://issues.apache.org/jira/browse/YARN-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762738#comment-16762738
]
Jim Brennan commented on YARN-9206:
---
The new patches look good to me.
> RMServerUtils does not count
[
https://issues.apache.org/jira/browse/YARN-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757718#comment-16757718
]
Jim Brennan commented on YARN-9206:
---
[~kshukla] thanks for the new patch. This looks good to me. +1
[
https://issues.apache.org/jira/browse/YARN-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16751227#comment-16751227
]
Jim Brennan commented on YARN-9206:
---
[~sunilg], [~kshukla] While I agree that [~sunilg]'s version looks
[
https://issues.apache.org/jira/browse/YARN-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16749132#comment-16749132
]
Jim Brennan commented on YARN-9206:
---
{quote}{quote}I think you need to iterate the acceptedStates() and
[
https://issues.apache.org/jira/browse/YARN-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748895#comment-16748895
]
Jim Brennan commented on YARN-9206:
---
[~kshukla], thanks for the patch! I think it would be cleaner if
[
https://issues.apache.org/jira/browse/YARN-9003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16746448#comment-16746448
]
Jim Brennan commented on YARN-9003:
---
[~eyang],
{quote}
Docker does not support multiple network
[
https://issues.apache.org/jira/browse/YARN-9202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745516#comment-16745516
]
Jim Brennan commented on YARN-9202:
---
[~kshukla] thanks for the patch!
I'd like some clarification of
[
https://issues.apache.org/jira/browse/YARN-9003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744202#comment-16744202
]
Jim Brennan commented on YARN-9003:
---
[~eyang] thanks for the patch. I have a few comments on the code:
[
https://issues.apache.org/jira/browse/YARN-9053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16743217#comment-16743217
]
Jim Brennan commented on YARN-9053:
---
[~Charo Zhang], [~eyang] Can we close this Jira as Not-Doing?
>
[
https://issues.apache.org/jira/browse/YARN-9184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16742429#comment-16742429
]
Jim Brennan commented on YARN-9184:
---
I also agree with [~ebadger] and [~eyang] that this should be a
[
https://issues.apache.org/jira/browse/YARN-9074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16742256#comment-16742256
]
Jim Brennan commented on YARN-9074:
---
+1 (non-binding) this looks good to me.
> Docker container rm
[
https://issues.apache.org/jira/browse/YARN-9098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16725212#comment-16725212
]
Jim Brennan commented on YARN-9098:
---
[~snemeth] I found the bug (or at least one bug).
In
[
https://issues.apache.org/jira/browse/YARN-9098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16725136#comment-16725136
]
Jim Brennan commented on YARN-9098:
---
[~snemeth] thanks for updating the patch. I will download and
[
https://issues.apache.org/jira/browse/YARN-9098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724524#comment-16724524
]
Jim Brennan commented on YARN-9098:
---
[~snemeth] thanks for the patch!
In general the code looks good to
[
https://issues.apache.org/jira/browse/YARN-9053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703337#comment-16703337
]
Jim Brennan commented on YARN-9053:
---
[~Charo Zhang] can you explain more about what your users are doing
[
https://issues.apache.org/jira/browse/YARN-9053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701974#comment-16701974
]
Jim Brennan commented on YARN-9053:
---
The launch_script.sh is run inside the docker container, so any
[
https://issues.apache.org/jira/browse/YARN-9053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700556#comment-16700556
]
Jim Brennan commented on YARN-9053:
---
{quote}
Besides, we don't think white-listed way is good, because
[
https://issues.apache.org/jira/browse/YARN-9053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699142#comment-16699142
]
Jim Brennan commented on YARN-9053:
---
{quote}
Environment variables are not written to docker container.
[
https://issues.apache.org/jira/browse/YARN-8911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16657448#comment-16657448
]
Jim Brennan commented on YARN-8911:
---
[~haibochen], can you provide a little more detail about what lead
[
https://issues.apache.org/jira/browse/YARN-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16636178#comment-16636178
]
Jim Brennan commented on YARN-6091:
---
[~jlowe], [~ebadger] this does indeed look like it was fixed by
[
https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16613729#comment-16613729
]
Jim Brennan commented on YARN-8648:
---
[~jlowe] thanks for the review. I've made the change you
[
https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Brennan updated YARN-8648:
--
Attachment: YARN-8648.006.patch
> Container cgroups are leaked when using docker
>
[
https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16612556#comment-16612556
]
Jim Brennan commented on YARN-8648:
---
Thanks [~jlowe] for the review! I have addressed all of this
[
https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Brennan updated YARN-8648:
--
Attachment: YARN-8648.005.patch
> Container cgroups are leaked when using docker
>
[
https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609206#comment-16609206
]
Jim Brennan commented on YARN-8648:
---
This is ready for review.
> Container cgroups are leaked when
[
https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608212#comment-16608212
]
Jim Brennan commented on YARN-8648:
---
I have uploaded a patch that adds the cgroup cleanup to the
[
https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Brennan updated YARN-8648:
--
Attachment: YARN-8648.004.patch
> Container cgroups are leaked when using docker
>
[
https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603606#comment-16603606
]
Jim Brennan commented on YARN-8648:
---
Put up another patch to fix the checkstyle issue.
> Container
[
https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Brennan updated YARN-8648:
--
Attachment: YARN-8648.003.patch
> Container cgroups are leaked when using docker
>
[
https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603202#comment-16603202
]
Jim Brennan commented on YARN-8648:
---
I've uploaded a patch that addresses most of issues raised by
[
https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Brennan updated YARN-8648:
--
Attachment: YARN-8648.002.patch
> Container cgroups are leaked when using docker
>
[
https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16599235#comment-16599235
]
Jim Brennan commented on YARN-8648:
---
{quote}
I explicitly check that the directory exists before calling
[
https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16599213#comment-16599213
]
Jim Brennan commented on YARN-8648:
---
[~jlowe] thanks for the review!
{quote}Why was the postComplete
501 - 600 of 816 matches
Mail list logo
