[
https://issues.apache.org/jira/browse/YARN-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13891884#comment-13891884
]
Mayank Bansal commented on YARN-1413:
-
[~zjshen] Thanks for the comments.
As discussed
[
https://issues.apache.org/jira/browse/YARN-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13866844#comment-13866844
]
Zhijie Shen commented on YARN-1413:
---
Checked RMContainerImpl again. It's wrong to set
[
https://issues.apache.org/jira/browse/YARN-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13860955#comment-13860955
]
Hadoop QA commented on YARN-1413:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857194#comment-13857194
]
Vinod Kumar Vavilapalli commented on YARN-1413:
---
There's a minor merge
[
https://issues.apache.org/jira/browse/YARN-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13852737#comment-13852737
]
Zhijie Shen commented on YARN-1413:
---
bq. RMContainerImpl has hard-coded /host:port ? !
[
https://issues.apache.org/jira/browse/YARN-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13852738#comment-13852738
]
Mayank Bansal commented on YARN-1413:
-
Thanks [~zjshen] and [~vinodkv] for review
bq.
[
https://issues.apache.org/jira/browse/YARN-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13852744#comment-13852744
]
Hadoop QA commented on YARN-1413:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13853066#comment-13853066
]
Zhijie Shen commented on YARN-1413:
---
bq. I am not sure what you are asking here , I think
[
https://issues.apache.org/jira/browse/YARN-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13853468#comment-13853468
]
Mayank Bansal commented on YARN-1413:
-
Added the the Util method for LOG generation.
[
https://issues.apache.org/jira/browse/YARN-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13853473#comment-13853473
]
Hadoop QA commented on YARN-1413:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13852365#comment-13852365
]
Mayank Bansal commented on YARN-1413:
-
Thanks [~vinodkv] and [~zjshen] for review
bq.
[
https://issues.apache.org/jira/browse/YARN-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13852381#comment-13852381
]
Hadoop QA commented on YARN-1413:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13852527#comment-13852527
]
Zhijie Shen commented on YARN-1413:
---
Thanks for the patch, Mayank! It's almost fine. Just
[
https://issues.apache.org/jira/browse/YARN-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13852571#comment-13852571
]
Zhijie Shen commented on YARN-1413:
---
BTW, how about keep showing the full logURL on the
[
https://issues.apache.org/jira/browse/YARN-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13849611#comment-13849611
]
Vinod Kumar Vavilapalli commented on YARN-1413:
---
Does it make sense to add
[
https://issues.apache.org/jira/browse/YARN-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13847208#comment-13847208
]
Zhijie Shen commented on YARN-1413:
---
Some comments:
1. The wrong javadoc bellow:
{code}
[
https://issues.apache.org/jira/browse/YARN-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13844567#comment-13844567
]
Hadoop QA commented on YARN-1413:
-
{color:red}-1 overall{color}. Here are the results of
17 matches
Mail list logo