[
https://issues.apache.org/jira/browse/YARN-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15047165#comment-15047165
]
Chris Nauroth commented on YARN-4248:
-
This patch introduced license warnings on the testing json
[
https://issues.apache.org/jira/browse/YARN-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15047389#comment-15047389
]
Chris Nauroth commented on YARN-4248:
-
Hi [~curino]. It looks like [~chris.douglas] just uploaded a
[
https://issues.apache.org/jira/browse/YARN-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15047418#comment-15047418
]
Hudson commented on YARN-4248:
--
FAILURE: Integrated in Hadoop-trunk-Commit #8941 (See
[
https://issues.apache.org/jira/browse/YARN-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15047378#comment-15047378
]
Carlo Curino commented on YARN-4248:
Chris, I am happy to fix it, but if I am not mistaken json doesn't
[
https://issues.apache.org/jira/browse/YARN-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15047395#comment-15047395
]
Chris Douglas commented on YARN-4248:
-
Pushed to trunk, branch-2, branch-2.8. Sorry to have missed
[
https://issues.apache.org/jira/browse/YARN-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15047396#comment-15047396
]
Carlo Curino commented on YARN-4248:
Thanks for spotting this and to [~chris.douglas] for the
[
https://issues.apache.org/jira/browse/YARN-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15048030#comment-15048030
]
Hudson commented on YARN-4248:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #677 (See
[
https://issues.apache.org/jira/browse/YARN-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15047553#comment-15047553
]
Chris Nauroth commented on YARN-4248:
-
bq. Not sure why it wasn't flagged by test-patch.
I decided to
[
https://issues.apache.org/jira/browse/YARN-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15047576#comment-15047576
]
Chris Douglas commented on YARN-4248:
-
Thanks, Chris.
> REST API for submit/update/delete Reservations
[
https://issues.apache.org/jira/browse/YARN-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15045810#comment-15045810
]
Hudson commented on YARN-4248:
--
FAILURE: Integrated in Hadoop-trunk-Commit #8935 (See
[
https://issues.apache.org/jira/browse/YARN-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15045828#comment-15045828
]
Carlo Curino commented on YARN-4248:
Committed this to trunk/branch-2/branch-2.8. I will update the
[
https://issues.apache.org/jira/browse/YARN-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15045438#comment-15045438
]
Chris Douglas commented on YARN-4248:
-
+1 lgtm
If it's appropriate for this to go into 2.8, set the
[
https://issues.apache.org/jira/browse/YARN-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15046154#comment-15046154
]
Hudson commented on YARN-4248:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #674 (See
[
https://issues.apache.org/jira/browse/YARN-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15042782#comment-15042782
]
Hadoop QA commented on YARN-4248:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15042788#comment-15042788
]
Hadoop QA commented on YARN-4248:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15042396#comment-15042396
]
Hadoop QA commented on YARN-4248:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15042153#comment-15042153
]
Carlo Curino commented on YARN-4248:
I added a few null checks which return more clear error messages
[
https://issues.apache.org/jira/browse/YARN-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15042511#comment-15042511
]
Hadoop QA commented on YARN-4248:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15035000#comment-15035000
]
Carlo Curino commented on YARN-4248:
[~chris.douglas] thanks for the review. I addressed your comments
[
https://issues.apache.org/jira/browse/YARN-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15025746#comment-15025746
]
Chris Douglas commented on YARN-4248:
-
* Would it make sense to return 201
[
https://issues.apache.org/jira/browse/YARN-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15025863#comment-15025863
]
Carlo Curino commented on YARN-4248:
[~chris.douglas] thanks for the review. I will address your
[
https://issues.apache.org/jira/browse/YARN-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15023435#comment-15023435
]
Hadoop QA commented on YARN-4248:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014092#comment-15014092
]
Carlo Curino commented on YARN-4248:
Updated patch:
* Fixed 2/5 of the asflicense issues (the last 3
[
https://issues.apache.org/jira/browse/YARN-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15012725#comment-15012725
]
Hadoop QA commented on YARN-4248:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14959393#comment-14959393
]
Carlo Curino commented on YARN-4248:
I will address the QA issues next, but I have a question for the
[
https://issues.apache.org/jira/browse/YARN-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14951429#comment-14951429
]
Hadoop QA commented on YARN-4248:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
26 matches
Mail list logo