[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272455#comment-15272455
]
Hudson commented on YARN-4311:
--
FAILURE: Integrated in Hadoop-trunk-Commit #9722 (See
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272341#comment-15272341
]
Jason Lowe commented on YARN-4311:
--
+1 lgtm. Committing this.
> Removing nodes from include and exclude
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268772#comment-15268772
]
Kuhu Shukla commented on YARN-4311:
---
Requesting [~jlowe] for review/comments. Thanks a lot!
> Removing
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268227#comment-15268227
]
Hadoop QA commented on YARN-4311:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268022#comment-15268022
]
Kuhu Shukla commented on YARN-4311:
---
Opened YARN-5032 for tracking
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15267936#comment-15267936
]
Hadoop QA commented on YARN-4311:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15267463#comment-15267463
]
Jason Lowe commented on YARN-4311:
--
Sorry for the delay in getting back to this.
I think the changes to
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15252464#comment-15252464
]
Hadoop QA commented on YARN-4311:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15246690#comment-15246690
]
Hadoop QA commented on YARN-4311:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235389#comment-15235389
]
Hudson commented on YARN-4311:
--
FAILURE: Integrated in Hadoop-trunk-Commit #9592 (See
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235358#comment-15235358
]
Jason Lowe commented on YARN-4311:
--
If we only remove truly untracked nodes then option 1 should be OK.
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235331#comment-15235331
]
Jason Lowe commented on YARN-4311:
--
No need for a followup JIRA, I'll revert the one in trunk until we
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235307#comment-15235307
]
Kuhu Shukla commented on YARN-4311:
---
The problem does exist. In a scenario where the node being removed
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235181#comment-15235181
]
Kuhu Shukla commented on YARN-4311:
---
Thank you [~jlowe] for the comments. The final variables and the
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235166#comment-15235166
]
Jason Lowe commented on YARN-4311:
--
Thanks for updating the patch! Couple of comments:
The patch has a
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15234023#comment-15234023
]
Kuhu Shukla commented on YARN-4311:
---
Requesting [~jlowe] for reviews on branch-2.7 version of the patch.
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15234020#comment-15234020
]
Hadoop QA commented on YARN-4311:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15233888#comment-15233888
]
Hadoop QA commented on YARN-4311:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15233433#comment-15233433
]
Hadoop QA commented on YARN-4311:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15232580#comment-15232580
]
Hadoop QA commented on YARN-4311:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15226581#comment-15226581
]
Kuhu Shukla commented on YARN-4311:
---
Thank you so much [~jlowe] for the detailed help and review!
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15226284#comment-15226284
]
Hudson commented on YARN-4311:
--
FAILURE: Integrated in Hadoop-trunk-Commit #9558 (See
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15226259#comment-15226259
]
Jason Lowe commented on YARN-4311:
--
+1 latest patch lgtm. Committing this.
> Removing nodes from include
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225459#comment-15225459
]
Kuhu Shukla commented on YARN-4311:
---
Requesting [~jlowe] for comments/review. Thanks a lot!
> Removing
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15222566#comment-15222566
]
Kuhu Shukla commented on YARN-4311:
---
New test failure of
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1526#comment-1526
]
Hadoop QA commented on YARN-4311:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15221204#comment-15221204
]
Kuhu Shukla commented on YARN-4311:
---
... and the Log line during removal.
> Removing nodes from include
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220279#comment-15220279
]
Jason Lowe commented on YARN-4311:
--
Thanks for updating the patch! Everything looks great except nodes
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15219185#comment-15219185
]
Kuhu Shukla commented on YARN-4311:
---
Requesting [~jlowe] for review/comments. Thanks a lot!
> Removing
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15213326#comment-15213326
]
Kuhu Shukla commented on YARN-4311:
---
Maven and javac failures are unrelated and coming from hdfs project.
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15213032#comment-15213032
]
Hadoop QA commented on YARN-4311:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212400#comment-15212400
]
Jason Lowe commented on YARN-4311:
--
Thanks for updating the patch! Sorry for the delay in getting back to
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15198218#comment-15198218
]
Daniel Templeton commented on YARN-4311:
I don't have any further comments. LGTM.
> Removing nodes
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197826#comment-15197826
]
Kuhu Shukla commented on YARN-4311:
---
Requesting Jason Lowe, Daniel Templeton for review/comments. Thanks
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15178448#comment-15178448
]
Kuhu Shukla commented on YARN-4311:
---
Requesting [~jlowe], [~templedf] for review/comments. Thanks a lot!
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15178426#comment-15178426
]
Hadoop QA commented on YARN-4311:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15159729#comment-15159729
]
Hadoop QA commented on YARN-4311:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15128966#comment-15128966
]
Hadoop QA commented on YARN-4311:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15108668#comment-15108668
]
Kuhu Shukla commented on YARN-4311:
---
[~jlowe], [~templedf], Requesting comments. The new failures with
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15102226#comment-15102226
]
Hadoop QA commented on YARN-4311:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15099204#comment-15099204
]
Hadoop QA commented on YARN-4311:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15097218#comment-15097218
]
Jason Lowe commented on YARN-4311:
--
Thanks for updating the patch!
I'd like to see the
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15095581#comment-15095581
]
Hadoop QA commented on YARN-4311:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15092920#comment-15092920
]
Hadoop QA commented on YARN-4311:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15091979#comment-15091979
]
Kuhu Shukla commented on YARN-4311:
---
[~jlowe], [~templedf] request for your comments. Thank you!
>
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15092342#comment-15092342
]
Daniel Templeton commented on YARN-4311:
Thanks, [~kshukla].
Can we simplify this:
{code}
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15090376#comment-15090376
]
Hadoop QA commented on YARN-4311:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15086256#comment-15086256
]
Kuhu Shukla commented on YARN-4311:
---
bq. Do note that with this solution, if a user does a node refresh
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15083701#comment-15083701
]
Hadoop QA commented on YARN-4311:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15068939#comment-15068939
]
Daniel Templeton commented on YARN-4311:
In the constructor, you check if the inactive nodes list
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15068940#comment-15068940
]
Daniel Templeton commented on YARN-4311:
Oh, and I'm a big proponent of using blank lines to make
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15051542#comment-15051542
]
Kuhu Shukla commented on YARN-4311:
---
[~eepayne], request for comments and review. Thanks a lot.
>
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15045420#comment-15045420
]
Kuhu Shukla commented on YARN-4311:
---
{code}
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15039529#comment-15039529
]
Hadoop QA commented on YARN-4311:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15036629#comment-15036629
]
Hadoop QA commented on YARN-4311:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14997478#comment-14997478
]
Jason Lowe commented on YARN-4311:
--
Sorry, I couldn't find a reference to {{isUntracked}} in trunk nor in
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14997366#comment-14997366
]
Kuhu Shukla commented on YARN-4311:
---
Thank you [~jlowe] for the comments.
For graceful refresh nodes, I
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14997655#comment-14997655
]
Kuhu Shukla commented on YARN-4311:
---
Thanks [~jlowe]. Will rework my patch accordingly.
> Removing nodes
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14997648#comment-14997648
]
Jason Lowe commented on YARN-4311:
--
bq. Could these be part of shutdown nodes or do we need a separate
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14990565#comment-14990565
]
Jason Lowe commented on YARN-4311:
--
Thanks for the patch, Kuhu! Test failures are related, please look
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14989697#comment-14989697
]
Kuhu Shukla commented on YARN-4311:
---
[~jlowe], [~leftnoteasy], request for comments. Thanks a lot.
>
[
https://issues.apache.org/jira/browse/YARN-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14988114#comment-14988114
]
Hadoop QA commented on YARN-4311:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
62 matches
Mail list logo