[
https://issues.apache.org/jira/browse/YARN-7988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418796#comment-16418796
]
Sunil G commented on YARN-7988:
---
Except java doc, jenkins seems fine. I ll take care of that while
[
https://issues.apache.org/jira/browse/YARN-7988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417939#comment-16417939
]
genericqa commented on YARN-7988:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417691#comment-16417691
]
Naganarasimha G R commented on YARN-7988:
-
Newer approach LGTM,
+1
> Refactor FSNodeLabelStore
[
https://issues.apache.org/jira/browse/YARN-7988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417503#comment-16417503
]
Sunil G commented on YARN-7988:
---
pending jenkins.
+1 on latest patch.
> Refactor FSNodeLabelStore code for
[
https://issues.apache.org/jira/browse/YARN-7988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417365#comment-16417365
]
genericqa commented on YARN-7988:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417350#comment-16417350
]
genericqa commented on YARN-7988:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417197#comment-16417197
]
Bibin A Chundatt commented on YARN-7988:
[~sunilg]
Attaching patch after handling review comments.
[
https://issues.apache.org/jira/browse/YARN-7988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413536#comment-16413536
]
Sunil G commented on YARN-7988:
---
Thanks [~bibinchundatt]
Few comments
# *public abstract class
[
https://issues.apache.org/jira/browse/YARN-7988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413454#comment-16413454
]
Bibin A Chundatt commented on YARN-7988:
[~Naganarasimha]/[~sunilg]/[~cheersyang]
Could some
[
https://issues.apache.org/jira/browse/YARN-7988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410801#comment-16410801
]
genericqa commented on YARN-7988:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410683#comment-16410683
]
Bibin A Chundatt commented on YARN-7988:
[~sunilg]
Thank you for comment. Personally i would have
[
https://issues.apache.org/jira/browse/YARN-7988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409928#comment-16409928
]
Sunil G commented on YARN-7988:
---
[~bibinchundatt]
Thanks for the patch. As discussed offline, could we use a
[
https://issues.apache.org/jira/browse/YARN-7988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404567#comment-16404567
]
Naganarasimha G R commented on YARN-7988:
-
Hi [~sunil.gov...@gmail.com],
As discussed in the
[
https://issues.apache.org/jira/browse/YARN-7988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16403563#comment-16403563
]
Bibin A Chundatt commented on YARN-7988:
[~Naganarasimha]/[~sunil.gov...@gmail.com]/[~cheersyang]
[
https://issues.apache.org/jira/browse/YARN-7988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386555#comment-16386555
]
Bibin A Chundatt commented on YARN-7988:
[~Naganarasimha]/[~sunil.gov...@gmail.com]/[~cheersyang]
[
https://issues.apache.org/jira/browse/YARN-7988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385893#comment-16385893
]
genericqa commented on YARN-7988:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384175#comment-16384175
]
genericqa commented on YARN-7988:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383976#comment-16383976
]
Bibin A Chundatt commented on YARN-7988:
Thank you [~Naganarasimha] for review
Adding summary of
[
https://issues.apache.org/jira/browse/YARN-7988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382946#comment-16382946
]
Naganarasimha G R commented on YARN-7988:
-
Thanks for working on the patch [~bibinchundatt]
May be
[
https://issues.apache.org/jira/browse/YARN-7988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382467#comment-16382467
]
genericqa commented on YARN-7988:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382280#comment-16382280
]
Bibin A Chundatt commented on YARN-7988:
Thank you [~cheersyang] for review
{quote}
line 38, 44,
[
https://issues.apache.org/jira/browse/YARN-7988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381853#comment-16381853
]
Weiwei Yang commented on YARN-7988:
---
Hi [~bibinchundatt]
Thanks for the work on the refactoring, it
[
https://issues.apache.org/jira/browse/YARN-7988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381613#comment-16381613
]
genericqa commented on YARN-7988:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-7988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381519#comment-16381519
]
Bibin A Chundatt commented on YARN-7988:
Attached v1 patch for refactoring .
24 matches
Mail list logo
