[jira] [Commented] (YARN-9135) NM State store ResourceMappings serialization are tested with Strings instead of real Device objects

2019-08-12 Thread Szilard Nemeth (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16905119#comment-16905119 ] Szilard Nemeth commented on YARN-9135: -- Hi [~pbacsko]! Thanks for the patches, committed to branch

[jira] [Commented] (YARN-9135) NM State store ResourceMappings serialization are tested with Strings instead of real Device objects

2019-08-12 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16905004#comment-16905004 ] Hadoop QA commented on YARN-9135: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9135) NM State store ResourceMappings serialization are tested with Strings instead of real Device objects

2019-08-10 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904473#comment-16904473 ] Hadoop QA commented on YARN-9135: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9135) NM State store ResourceMappings serialization are tested with Strings instead of real Device objects

2019-08-10 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904464#comment-16904464 ] Hadoop QA commented on YARN-9135: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9135) NM State store ResourceMappings serialization are tested with Strings instead of real Device objects

2019-07-12 Thread Szilard Nemeth (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883906#comment-16883906 ] Szilard Nemeth commented on YARN-9135: -- Trunk commit went fine. However, cherry-pick was not

[jira] [Commented] (YARN-9135) NM State store ResourceMappings serialization are tested with Strings instead of real Device objects

2019-07-12 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883904#comment-16883904 ] Hudson commented on YARN-9135: -- FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #16906 (See

[jira] [Commented] (YARN-9135) NM State store ResourceMappings serialization are tested with Strings instead of real Device objects

2019-07-12 Thread Szilard Nemeth (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883902#comment-16883902 ] Szilard Nemeth commented on YARN-9135: -- Hi [~pbacsko]! Thanks for the patch, +1. Committing this to

[jira] [Commented] (YARN-9135) NM State store ResourceMappings serialization are tested with Strings instead of real Device objects

2019-07-11 Thread Peter Bacsko (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883064#comment-16883064 ] Peter Bacsko commented on YARN-9135: OK, so apparently there are no findbugs issues anymore, which is

[jira] [Commented] (YARN-9135) NM State store ResourceMappings serialization are tested with Strings instead of real Device objects

2019-07-11 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883013#comment-16883013 ] Hadoop QA commented on YARN-9135: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9135) NM State store ResourceMappings serialization are tested with Strings instead of real Device objects

2019-07-11 Thread Peter Bacsko (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882936#comment-16882936 ] Peter Bacsko commented on YARN-9135: Reuploaded patch v5 so that we can see the findbugs problems

[jira] [Commented] (YARN-9135) NM State store ResourceMappings serialization are tested with Strings instead of real Device objects

2019-04-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16810945#comment-16810945 ] Hadoop QA commented on YARN-9135: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9135) NM State store ResourceMappings serialization are tested with Strings instead of real Device objects

2019-02-14 Thread Peter Bacsko (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768360#comment-16768360 ] Peter Bacsko commented on YARN-9135: {quote}Using the immutable type in the definition of the methods

[jira] [Commented] (YARN-9135) NM State store ResourceMappings serialization are tested with Strings instead of real Device objects

2019-02-14 Thread Szilard Nemeth (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768102#comment-16768102 ] Szilard Nemeth commented on YARN-9135: -- Thanks for the comment [~pbacsko]! I would rather keep this

[jira] [Commented] (YARN-9135) NM State store ResourceMappings serialization are tested with Strings instead of real Device objects

2019-02-13 Thread Peter Bacsko (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767287#comment-16767287 ] Peter Bacsko commented on YARN-9135: Thanks for updating the patch [~snemeth]. Please make sure that

[jira] [Commented] (YARN-9135) NM State store ResourceMappings serialization are tested with Strings instead of real Device objects

2019-02-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16760894#comment-16760894 ] Hadoop QA commented on YARN-9135: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9135) NM State store ResourceMappings serialization are tested with Strings instead of real Device objects

2019-02-05 Thread Szilard Nemeth (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16760785#comment-16760785 ] Szilard Nemeth commented on YARN-9135: -- fixed the checkstyle issue with patch005 > NM State store

[jira] [Commented] (YARN-9135) NM State store ResourceMappings serialization are tested with Strings instead of real Device objects

2019-01-31 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757560#comment-16757560 ] Hadoop QA commented on YARN-9135: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9135) NM State store ResourceMappings serialization are tested with Strings instead of real Device objects

2019-01-31 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757548#comment-16757548 ] Hadoop QA commented on YARN-9135: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9135) NM State store ResourceMappings serialization are tested with Strings instead of real Device objects

2019-01-31 Thread Szilard Nemeth (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757436#comment-16757436 ] Szilard Nemeth commented on YARN-9135: -- Hi [~pbacsko]! Thanks for the review! Very good point, we

[jira] [Commented] (YARN-9135) NM State store ResourceMappings serialization are tested with Strings instead of real Device objects

2019-01-23 Thread Peter Bacsko (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16750049#comment-16750049 ] Peter Bacsko commented on YARN-9135: [~snemeth] there is one big problem with this change:

[jira] [Commented] (YARN-9135) NM State store ResourceMappings serialization are tested with Strings instead of real Device objects

2018-12-18 Thread Szilard Nemeth (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723878#comment-16723878 ] Szilard Nemeth commented on YARN-9135: -- [~devaraj.k], [~tangzhankun], [~zyluo], [~sunilg],

[jira] [Commented] (YARN-9135) NM State store ResourceMappings serialization are tested with Strings instead of real Device objects

2018-12-17 Thread Szilard Nemeth (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722869#comment-16722869 ] Szilard Nemeth commented on YARN-9135: -- I haven't touched the code that generated the checkstyle

[jira] [Commented] (YARN-9135) NM State store ResourceMappings serialization are tested with Strings instead of real Device objects

2018-12-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-9135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722268#comment-16722268 ] Hadoop QA commented on YARN-9135: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||