[jira] [Commented] (YARN-2675) the containersKilled metrics is not updated when the container is killed during localization.

[ https://issues.apache.org/jira/browse/YARN-2675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14254178#comment-14254178 ] Karthik Kambatla commented on YARN-2675: Given we split up all the cases of

[jira] [Commented] (YARN-2675) the containersKilled metrics is not updated when the container is killed during localization.

[ https://issues.apache.org/jira/browse/YARN-2675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14254216#comment-14254216 ] zhihai xu commented on YARN-2675: - Although we don't use it in the state machine directly,

[jira] [Commented] (YARN-2675) the containersKilled metrics is not updated when the container is killed during localization.

[ https://issues.apache.org/jira/browse/YARN-2675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14254302#comment-14254302 ] Karthik Kambatla commented on YARN-2675: bq. it is the base class of all other

[jira] [Commented] (YARN-2675) the containersKilled metrics is not updated when the container is killed during localization.

[ https://issues.apache.org/jira/browse/YARN-2675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14254307#comment-14254307 ] Karthik Kambatla commented on YARN-2675: The latest patch looks good, the findbugs

[jira] [Commented] (YARN-2675) the containersKilled metrics is not updated when the container is killed during localization.

[ https://issues.apache.org/jira/browse/YARN-2675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14252481#comment-14252481 ] Ray Chiang commented on YARN-2675: -- Started reviewing, but it looks like this patch needs

[jira] [Commented] (YARN-2675) the containersKilled metrics is not updated when the container is killed during localization.

[ https://issues.apache.org/jira/browse/YARN-2675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14252854#comment-14252854 ] zhihai xu commented on YARN-2675: - Thanks for the review. I uploaded a new

[jira] [Commented] (YARN-2675) the containersKilled metrics is not updated when the container is killed during localization.

[ https://issues.apache.org/jira/browse/YARN-2675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14252893#comment-14252893 ] Hadoop QA commented on YARN-2675: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (YARN-2675) the containersKilled metrics is not updated when the container is killed during localization.

[ https://issues.apache.org/jira/browse/YARN-2675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14222463#comment-14222463 ] zhihai xu commented on YARN-2675: - I uploaded a new patch YARN-2675.005.patch after rebase

[jira] [Commented] (YARN-2675) the containersKilled metrics is not updated when the container is killed during localization.

[ https://issues.apache.org/jira/browse/YARN-2675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14222474#comment-14222474 ] Hadoop QA commented on YARN-2675: - {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (YARN-2675) the containersKilled metrics is not updated when the container is killed during localization.

[ https://issues.apache.org/jira/browse/YARN-2675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14221509#comment-14221509 ] Karthik Kambatla commented on YARN-2675: Looks good. [~vinodkv] - do you want to

[jira] [Commented] (YARN-2675) the containersKilled metrics is not updated when the container is killed during localization.

[ https://issues.apache.org/jira/browse/YARN-2675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14219141#comment-14219141 ] zhihai xu commented on YARN-2675: - Hi [~kasha], Good suggestion, I added unit tests to

[jira] [Commented] (YARN-2675) the containersKilled metrics is not updated when the container is killed during localization.

[ https://issues.apache.org/jira/browse/YARN-2675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14219195#comment-14219195 ] Hadoop QA commented on YARN-2675: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (YARN-2675) the containersKilled metrics is not updated when the container is killed during localization.

[ https://issues.apache.org/jira/browse/YARN-2675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14219244#comment-14219244 ] Hadoop QA commented on YARN-2675: - {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (YARN-2675) the containersKilled metrics is not updated when the container is killed during localization.

[ https://issues.apache.org/jira/browse/YARN-2675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14218965#comment-14218965 ] Karthik Kambatla commented on YARN-2675: Can we add unit tests to exercise all the

[jira] [Commented] (YARN-2675) the containersKilled metrics is not updated when the container is killed during localization.

[ https://issues.apache.org/jira/browse/YARN-2675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14216452#comment-14216452 ] zhihai xu commented on YARN-2675: - Hi [~vinodkv], Are you ok with the new patch? The new

[jira] [Commented] (YARN-2675) the containersKilled metrics is not updated when the container is killed during localization.

[ https://issues.apache.org/jira/browse/YARN-2675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14213889#comment-14213889 ] zhihai xu commented on YARN-2675: - Hi [~vinodkv], thanks for the review. Good suggestion.

[jira] [Commented] (YARN-2675) the containersKilled metrics is not updated when the container is killed during localization.

[ https://issues.apache.org/jira/browse/YARN-2675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14213896#comment-14213896 ] Hadoop QA commented on YARN-2675: - {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (YARN-2675) the containersKilled metrics is not updated when the container is killed during localization.

[ https://issues.apache.org/jira/browse/YARN-2675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14213761#comment-14213761 ] Vinod Kumar Vavilapalli commented on YARN-2675: --- I admit it's not caused by

[jira] [Commented] (YARN-2675) the containersKilled metrics is not updated when the container is killed during localization.

[ https://issues.apache.org/jira/browse/YARN-2675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14213107#comment-14213107 ] Anubhav Dhoot commented on YARN-2675: - Minor: In ContainerImpl finished, it may be good

[jira] [Commented] (YARN-2675) the containersKilled metrics is not updated when the container is killed during localization.

[ https://issues.apache.org/jira/browse/YARN-2675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14213207#comment-14213207 ] zhihai xu commented on YARN-2675: - Hi [~adhoot], Good suggestion. I uploaded a new patch

[jira] [Commented] (YARN-2675) the containersKilled metrics is not updated when the container is killed during localization.

[ https://issues.apache.org/jira/browse/YARN-2675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14213255#comment-14213255 ] Hadoop QA commented on YARN-2675: - {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (YARN-2675) the containersKilled metrics is not updated when the container is killed during localization.

[ https://issues.apache.org/jira/browse/YARN-2675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14167168#comment-14167168 ] zhihai xu commented on YARN-2675: - I uploaded a patch YARN-2675.000.patch for review. the