[jira] [Commented] (YARN-3516) killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status.
[ https://issues.apache.org/jira/browse/YARN-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14516859#comment-14516859 ] Hudson commented on YARN-3516: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #2109 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/2109/]) Update CHANGES.txt - Pulled in YARN-3465, YARN-3516, and YARN-3464 to branch-2.7 (for 2.7.1) (kasha: rev 32cd2c8d429ddb87348299c00b7d851246a25b4e) * hadoop-yarn-project/CHANGES.txt killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status. --- Key: YARN-3516 URL: https://issues.apache.org/jira/browse/YARN-3516 Project: Hadoop YARN Issue Type: Bug Components: nodemanager Reporter: zhihai xu Assignee: zhihai xu Priority: Minor Fix For: 2.7.1 Attachments: YARN-3516.000.patch killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status. This is a typo from YARN-3024. With YARN-3024, ContainerLocalizer will be killed only if {{action}} is set to {{LocalizerAction.DIE}}, calling {{response.setLocalizerAction}} will be overwritten. This is also a regression from old code. Also it make sense to kill the ContainerLocalizer when FETCH_FAILURE happened, because the container will send CLEANUP_CONTAINER_RESOURCES event after localization failure. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3516) killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status.
[ https://issues.apache.org/jira/browse/YARN-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14516889#comment-14516889 ] Hudson commented on YARN-3516: -- FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #177 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/177/]) Update CHANGES.txt - Pulled in YARN-3465, YARN-3516, and YARN-3464 to branch-2.7 (for 2.7.1) (kasha: rev 32cd2c8d429ddb87348299c00b7d851246a25b4e) * hadoop-yarn-project/CHANGES.txt killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status. --- Key: YARN-3516 URL: https://issues.apache.org/jira/browse/YARN-3516 Project: Hadoop YARN Issue Type: Bug Components: nodemanager Reporter: zhihai xu Assignee: zhihai xu Priority: Minor Fix For: 2.7.1 Attachments: YARN-3516.000.patch killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status. This is a typo from YARN-3024. With YARN-3024, ContainerLocalizer will be killed only if {{action}} is set to {{LocalizerAction.DIE}}, calling {{response.setLocalizerAction}} will be overwritten. This is also a regression from old code. Also it make sense to kill the ContainerLocalizer when FETCH_FAILURE happened, because the container will send CLEANUP_CONTAINER_RESOURCES event after localization failure. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3516) killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status.
[ https://issues.apache.org/jira/browse/YARN-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14516873#comment-14516873 ] Hudson commented on YARN-3516: -- FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #168 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/168/]) Update CHANGES.txt - Pulled in YARN-3465, YARN-3516, and YARN-3464 to branch-2.7 (for 2.7.1) (kasha: rev 32cd2c8d429ddb87348299c00b7d851246a25b4e) * hadoop-yarn-project/CHANGES.txt killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status. --- Key: YARN-3516 URL: https://issues.apache.org/jira/browse/YARN-3516 Project: Hadoop YARN Issue Type: Bug Components: nodemanager Reporter: zhihai xu Assignee: zhihai xu Priority: Minor Fix For: 2.7.1 Attachments: YARN-3516.000.patch killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status. This is a typo from YARN-3024. With YARN-3024, ContainerLocalizer will be killed only if {{action}} is set to {{LocalizerAction.DIE}}, calling {{response.setLocalizerAction}} will be overwritten. This is also a regression from old code. Also it make sense to kill the ContainerLocalizer when FETCH_FAILURE happened, because the container will send CLEANUP_CONTAINER_RESOURCES event after localization failure. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3516) killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status.
[ https://issues.apache.org/jira/browse/YARN-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14516911#comment-14516911 ] Hudson commented on YARN-3516: -- FAILURE: Integrated in Hadoop-Yarn-trunk #911 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/911/]) Update CHANGES.txt - Pulled in YARN-3465, YARN-3516, and YARN-3464 to branch-2.7 (for 2.7.1) (kasha: rev 32cd2c8d429ddb87348299c00b7d851246a25b4e) * hadoop-yarn-project/CHANGES.txt killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status. --- Key: YARN-3516 URL: https://issues.apache.org/jira/browse/YARN-3516 Project: Hadoop YARN Issue Type: Bug Components: nodemanager Reporter: zhihai xu Assignee: zhihai xu Priority: Minor Fix For: 2.7.1 Attachments: YARN-3516.000.patch killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status. This is a typo from YARN-3024. With YARN-3024, ContainerLocalizer will be killed only if {{action}} is set to {{LocalizerAction.DIE}}, calling {{response.setLocalizerAction}} will be overwritten. This is also a regression from old code. Also it make sense to kill the ContainerLocalizer when FETCH_FAILURE happened, because the container will send CLEANUP_CONTAINER_RESOURCES event after localization failure. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3516) killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status.
[ https://issues.apache.org/jira/browse/YARN-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14517233#comment-14517233 ] Hudson commented on YARN-3516: -- SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2127 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2127/]) Update CHANGES.txt - Pulled in YARN-3465, YARN-3516, and YARN-3464 to branch-2.7 (for 2.7.1) (kasha: rev 32cd2c8d429ddb87348299c00b7d851246a25b4e) * hadoop-yarn-project/CHANGES.txt killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status. --- Key: YARN-3516 URL: https://issues.apache.org/jira/browse/YARN-3516 Project: Hadoop YARN Issue Type: Bug Components: nodemanager Reporter: zhihai xu Assignee: zhihai xu Priority: Minor Fix For: 2.7.1 Attachments: YARN-3516.000.patch killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status. This is a typo from YARN-3024. With YARN-3024, ContainerLocalizer will be killed only if {{action}} is set to {{LocalizerAction.DIE}}, calling {{response.setLocalizerAction}} will be overwritten. This is also a regression from old code. Also it make sense to kill the ContainerLocalizer when FETCH_FAILURE happened, because the container will send CLEANUP_CONTAINER_RESOURCES event after localization failure. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3516) killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status.
[ https://issues.apache.org/jira/browse/YARN-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14517165#comment-14517165 ] Hudson commented on YARN-3516: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #178 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/178/]) Update CHANGES.txt - Pulled in YARN-3465, YARN-3516, and YARN-3464 to branch-2.7 (for 2.7.1) (kasha: rev 32cd2c8d429ddb87348299c00b7d851246a25b4e) * hadoop-yarn-project/CHANGES.txt killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status. --- Key: YARN-3516 URL: https://issues.apache.org/jira/browse/YARN-3516 Project: Hadoop YARN Issue Type: Bug Components: nodemanager Reporter: zhihai xu Assignee: zhihai xu Priority: Minor Fix For: 2.7.1 Attachments: YARN-3516.000.patch killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status. This is a typo from YARN-3024. With YARN-3024, ContainerLocalizer will be killed only if {{action}} is set to {{LocalizerAction.DIE}}, calling {{response.setLocalizerAction}} will be overwritten. This is also a regression from old code. Also it make sense to kill the ContainerLocalizer when FETCH_FAILURE happened, because the container will send CLEANUP_CONTAINER_RESOURCES event after localization failure. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3516) killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status.
[ https://issues.apache.org/jira/browse/YARN-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14514955#comment-14514955 ] Hudson commented on YARN-3516: -- FAILURE: Integrated in Hadoop-trunk-Commit #7688 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/7688/]) Update CHANGES.txt - Pulled in YARN-3465, YARN-3516, and YARN-3464 to branch-2.7 (for 2.7.1) (kasha: rev 32cd2c8d429ddb87348299c00b7d851246a25b4e) * hadoop-yarn-project/CHANGES.txt killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status. --- Key: YARN-3516 URL: https://issues.apache.org/jira/browse/YARN-3516 Project: Hadoop YARN Issue Type: Bug Components: nodemanager Reporter: zhihai xu Assignee: zhihai xu Priority: Minor Fix For: 2.7.1 Attachments: YARN-3516.000.patch killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status. This is a typo from YARN-3024. With YARN-3024, ContainerLocalizer will be killed only if {{action}} is set to {{LocalizerAction.DIE}}, calling {{response.setLocalizerAction}} will be overwritten. This is also a regression from old code. Also it make sense to kill the ContainerLocalizer when FETCH_FAILURE happened, because the container will send CLEANUP_CONTAINER_RESOURCES event after localization failure. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3516) killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status.
[ https://issues.apache.org/jira/browse/YARN-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14510846#comment-14510846 ] Hudson commented on YARN-3516: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #2105 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/2105/]) YARN-3516. killing ContainerLocalizer action doesn't take effect when (xgong: rev 0b3f8957a87ada1a275c9904b211fdbdcefafb02) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/ResourceLocalizationService.java * hadoop-yarn-project/CHANGES.txt killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status. --- Key: YARN-3516 URL: https://issues.apache.org/jira/browse/YARN-3516 Project: Hadoop YARN Issue Type: Bug Components: nodemanager Reporter: zhihai xu Assignee: zhihai xu Priority: Minor Fix For: 2.8.0 Attachments: YARN-3516.000.patch killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status. This is a typo from YARN-3024. With YARN-3024, ContainerLocalizer will be killed only if {{action}} is set to {{LocalizerAction.DIE}}, calling {{response.setLocalizerAction}} will be overwritten. This is also a regression from old code. Also it make sense to kill the ContainerLocalizer when FETCH_FAILURE happened, because the container will send CLEANUP_CONTAINER_RESOURCES event after localization failure. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3516) killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status.
[ https://issues.apache.org/jira/browse/YARN-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14510863#comment-14510863 ] Hudson commented on YARN-3516: -- FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #164 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/164/]) YARN-3516. killing ContainerLocalizer action doesn't take effect when (xgong: rev 0b3f8957a87ada1a275c9904b211fdbdcefafb02) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/ResourceLocalizationService.java * hadoop-yarn-project/CHANGES.txt killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status. --- Key: YARN-3516 URL: https://issues.apache.org/jira/browse/YARN-3516 Project: Hadoop YARN Issue Type: Bug Components: nodemanager Reporter: zhihai xu Assignee: zhihai xu Priority: Minor Fix For: 2.8.0 Attachments: YARN-3516.000.patch killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status. This is a typo from YARN-3024. With YARN-3024, ContainerLocalizer will be killed only if {{action}} is set to {{LocalizerAction.DIE}}, calling {{response.setLocalizerAction}} will be overwritten. This is also a regression from old code. Also it make sense to kill the ContainerLocalizer when FETCH_FAILURE happened, because the container will send CLEANUP_CONTAINER_RESOURCES event after localization failure. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3516) killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status.
[ https://issues.apache.org/jira/browse/YARN-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14510921#comment-14510921 ] Hudson commented on YARN-3516: -- SUCCESS: Integrated in Hadoop-Yarn-trunk #907 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/907/]) YARN-3516. killing ContainerLocalizer action doesn't take effect when (xgong: rev 0b3f8957a87ada1a275c9904b211fdbdcefafb02) * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/ResourceLocalizationService.java killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status. --- Key: YARN-3516 URL: https://issues.apache.org/jira/browse/YARN-3516 Project: Hadoop YARN Issue Type: Bug Components: nodemanager Reporter: zhihai xu Assignee: zhihai xu Priority: Minor Fix For: 2.8.0 Attachments: YARN-3516.000.patch killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status. This is a typo from YARN-3024. With YARN-3024, ContainerLocalizer will be killed only if {{action}} is set to {{LocalizerAction.DIE}}, calling {{response.setLocalizerAction}} will be overwritten. This is also a regression from old code. Also it make sense to kill the ContainerLocalizer when FETCH_FAILURE happened, because the container will send CLEANUP_CONTAINER_RESOURCES event after localization failure. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3516) killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status.
[ https://issues.apache.org/jira/browse/YARN-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14510882#comment-14510882 ] Hudson commented on YARN-3516: -- FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #173 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/173/]) YARN-3516. killing ContainerLocalizer action doesn't take effect when (xgong: rev 0b3f8957a87ada1a275c9904b211fdbdcefafb02) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/ResourceLocalizationService.java * hadoop-yarn-project/CHANGES.txt killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status. --- Key: YARN-3516 URL: https://issues.apache.org/jira/browse/YARN-3516 Project: Hadoop YARN Issue Type: Bug Components: nodemanager Reporter: zhihai xu Assignee: zhihai xu Priority: Minor Fix For: 2.8.0 Attachments: YARN-3516.000.patch killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status. This is a typo from YARN-3024. With YARN-3024, ContainerLocalizer will be killed only if {{action}} is set to {{LocalizerAction.DIE}}, calling {{response.setLocalizerAction}} will be overwritten. This is also a regression from old code. Also it make sense to kill the ContainerLocalizer when FETCH_FAILURE happened, because the container will send CLEANUP_CONTAINER_RESOURCES event after localization failure. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3516) killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status.
[ https://issues.apache.org/jira/browse/YARN-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14511024#comment-14511024 ] Hudson commented on YARN-3516: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #174 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/174/]) YARN-3516. killing ContainerLocalizer action doesn't take effect when (xgong: rev 0b3f8957a87ada1a275c9904b211fdbdcefafb02) * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/ResourceLocalizationService.java killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status. --- Key: YARN-3516 URL: https://issues.apache.org/jira/browse/YARN-3516 Project: Hadoop YARN Issue Type: Bug Components: nodemanager Reporter: zhihai xu Assignee: zhihai xu Priority: Minor Fix For: 2.8.0 Attachments: YARN-3516.000.patch killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status. This is a typo from YARN-3024. With YARN-3024, ContainerLocalizer will be killed only if {{action}} is set to {{LocalizerAction.DIE}}, calling {{response.setLocalizerAction}} will be overwritten. This is also a regression from old code. Also it make sense to kill the ContainerLocalizer when FETCH_FAILURE happened, because the container will send CLEANUP_CONTAINER_RESOURCES event after localization failure. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3516) killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status.
[ https://issues.apache.org/jira/browse/YARN-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14511063#comment-14511063 ] Hudson commented on YARN-3516: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #2123 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2123/]) YARN-3516. killing ContainerLocalizer action doesn't take effect when (xgong: rev 0b3f8957a87ada1a275c9904b211fdbdcefafb02) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/ResourceLocalizationService.java * hadoop-yarn-project/CHANGES.txt killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status. --- Key: YARN-3516 URL: https://issues.apache.org/jira/browse/YARN-3516 Project: Hadoop YARN Issue Type: Bug Components: nodemanager Reporter: zhihai xu Assignee: zhihai xu Priority: Minor Fix For: 2.8.0 Attachments: YARN-3516.000.patch killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status. This is a typo from YARN-3024. With YARN-3024, ContainerLocalizer will be killed only if {{action}} is set to {{LocalizerAction.DIE}}, calling {{response.setLocalizerAction}} will be overwritten. This is also a regression from old code. Also it make sense to kill the ContainerLocalizer when FETCH_FAILURE happened, because the container will send CLEANUP_CONTAINER_RESOURCES event after localization failure. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3516) killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status.
[ https://issues.apache.org/jira/browse/YARN-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14510058#comment-14510058 ] Xuan Gong commented on YARN-3516: - +1 LGTM. Will commit killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status. --- Key: YARN-3516 URL: https://issues.apache.org/jira/browse/YARN-3516 Project: Hadoop YARN Issue Type: Bug Components: nodemanager Reporter: zhihai xu Assignee: zhihai xu Priority: Minor Attachments: YARN-3516.000.patch killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status. This is a typo from YARN-3024. With YARN-3024, ContainerLocalizer will be killed only if {{action}} is set to {{LocalizerAction.DIE}}, calling {{response.setLocalizerAction}} will be overwritten. This is also a regression from old code. Also it make sense to kill the ContainerLocalizer when FETCH_FAILURE happened, because the container will send CLEANUP_CONTAINER_RESOURCES event after localization failure. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3516) killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status.
[ https://issues.apache.org/jira/browse/YARN-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14510080#comment-14510080 ] Xuan Gong commented on YARN-3516: - Committed into trunk/branch-2. Thanks, zhihai ! killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status. --- Key: YARN-3516 URL: https://issues.apache.org/jira/browse/YARN-3516 Project: Hadoop YARN Issue Type: Bug Components: nodemanager Reporter: zhihai xu Assignee: zhihai xu Priority: Minor Fix For: 2.8.0 Attachments: YARN-3516.000.patch killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status. This is a typo from YARN-3024. With YARN-3024, ContainerLocalizer will be killed only if {{action}} is set to {{LocalizerAction.DIE}}, calling {{response.setLocalizerAction}} will be overwritten. This is also a regression from old code. Also it make sense to kill the ContainerLocalizer when FETCH_FAILURE happened, because the container will send CLEANUP_CONTAINER_RESOURCES event after localization failure. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3516) killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status.
[ https://issues.apache.org/jira/browse/YARN-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14510092#comment-14510092 ] Hudson commented on YARN-3516: -- FAILURE: Integrated in Hadoop-trunk-Commit #7656 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/7656/]) YARN-3516. killing ContainerLocalizer action doesn't take effect when (xgong: rev 0b3f8957a87ada1a275c9904b211fdbdcefafb02) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/ResourceLocalizationService.java * hadoop-yarn-project/CHANGES.txt killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status. --- Key: YARN-3516 URL: https://issues.apache.org/jira/browse/YARN-3516 Project: Hadoop YARN Issue Type: Bug Components: nodemanager Reporter: zhihai xu Assignee: zhihai xu Priority: Minor Fix For: 2.8.0 Attachments: YARN-3516.000.patch killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status. This is a typo from YARN-3024. With YARN-3024, ContainerLocalizer will be killed only if {{action}} is set to {{LocalizerAction.DIE}}, calling {{response.setLocalizerAction}} will be overwritten. This is also a regression from old code. Also it make sense to kill the ContainerLocalizer when FETCH_FAILURE happened, because the container will send CLEANUP_CONTAINER_RESOURCES event after localization failure. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3516) killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status.
[ https://issues.apache.org/jira/browse/YARN-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14505326#comment-14505326 ] Xuan Gong commented on YARN-3516: - [~zxu] Thanks for working on this jira. I will take a look shortly. killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status. --- Key: YARN-3516 URL: https://issues.apache.org/jira/browse/YARN-3516 Project: Hadoop YARN Issue Type: Bug Components: nodemanager Reporter: zhihai xu Assignee: zhihai xu Attachments: YARN-3516.000.patch killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status. This is a typo from YARN-3024. With YARN-3024, ContainerLocalizer will be killed only if {{action}} is set to {{LocalizerAction.DIE}}, calling {{response.setLocalizerAction}} will be overwritten. This is also a regression from old code. Also it make sense to kill the ContainerLocalizer when FETCH_FAILURE happened, because the container will send CLEANUP_CONTAINER_RESOURCES event after localization failure. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3516) killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status.
[ https://issues.apache.org/jira/browse/YARN-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14505409#comment-14505409 ] Hadoop QA commented on YARN-3516: - {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12726922/YARN-3516.000.patch against trunk revision 8ddbb8d. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: org.apache.hadoop.yarn.server.nodemanager.webapp.TestNMWebServicesApps org.apache.hadoop.yarn.server.nodemanager.webapp.TestNMWebServices org.apache.hadoop.yarn.server.nodemanager.webapp.TestNMWebServicesContainers Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7428//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7428//console This message is automatically generated. killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status. --- Key: YARN-3516 URL: https://issues.apache.org/jira/browse/YARN-3516 Project: Hadoop YARN Issue Type: Bug Components: nodemanager Reporter: zhihai xu Assignee: zhihai xu Attachments: YARN-3516.000.patch killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status. This is a typo from YARN-3024. With YARN-3024, ContainerLocalizer will be killed only if {{action}} is set to {{LocalizerAction.DIE}}, calling {{response.setLocalizerAction}} will be overwritten. This is also a regression from old code. Also it make sense to kill the ContainerLocalizer when FETCH_FAILURE happened, because the container will send CLEANUP_CONTAINER_RESOURCES event after localization failure. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3516) killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status.
[ https://issues.apache.org/jira/browse/YARN-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14504513#comment-14504513 ] Hadoop QA commented on YARN-3516: - {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12726776/YARN-3516.000.patch against trunk revision d52de61. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.TestDataTransferProtocol The following test timeouts occurred in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.TestLeaseRecovery2 Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7415//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7415//console This message is automatically generated. killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status. --- Key: YARN-3516 URL: https://issues.apache.org/jira/browse/YARN-3516 Project: Hadoop YARN Issue Type: Bug Components: nodemanager Reporter: zhihai xu Assignee: zhihai xu Attachments: YARN-3516.000.patch killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status. This is a typo from YARN-3024. With YARN-3024, ContainerLocalizer will be killed only if {{action}} is set to {{LocalizerAction.DIE}}, calling {{response.setLocalizerAction}} will be overwritten. This is also a regression from old code. Also it make sense to kill the ContainerLocalizer when FETCH_FAILURE happened, because the container will send CLEANUP_CONTAINER_RESOURCES event after localization failure. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3516) killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status.
[ https://issues.apache.org/jira/browse/YARN-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14506208#comment-14506208 ] Hadoop QA commented on YARN-3516: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | pre-patch | 15m 1s | Pre-patch trunk compilation is healthy. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | | {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that end in whitespace. | | {color:green}+1{color} | javac | 7m 44s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 9m 47s | There were no new javadoc warning messages. | | {color:green}+1{color} | release audit | 0m 21s | The applied patch does not increase the total number of release audit warnings. | | {color:green}+1{color} | checkstyle | 5m 34s | There were no new checkstyle issues. | | {color:green}+1{color} | install | 1m 34s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 32s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | findbugs | 1m 1s | The patch does not introduce any new Findbugs (version 2.0.3) warnings. | | {color:green}+1{color} | yarn tests | 5m 54s | Tests passed in hadoop-yarn-server-nodemanager. | | | | 47m 30s | | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12727051/YARN-3516.000.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / cfba355 | | hadoop-yarn-server-nodemanager test log | https://builds.apache.org/job/PreCommit-YARN-Build/7440/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/7440/testReport/ | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/7440//console | This message was automatically generated. killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status. --- Key: YARN-3516 URL: https://issues.apache.org/jira/browse/YARN-3516 Project: Hadoop YARN Issue Type: Bug Components: nodemanager Reporter: zhihai xu Assignee: zhihai xu Attachments: YARN-3516.000.patch killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status. This is a typo from YARN-3024. With YARN-3024, ContainerLocalizer will be killed only if {{action}} is set to {{LocalizerAction.DIE}}, calling {{response.setLocalizerAction}} will be overwritten. This is also a regression from old code. Also it make sense to kill the ContainerLocalizer when FETCH_FAILURE happened, because the container will send CLEANUP_CONTAINER_RESOURCES event after localization failure. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3516) killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status.
[ https://issues.apache.org/jira/browse/YARN-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14504283#comment-14504283 ] zhihai xu commented on YARN-3516: - Hi [~xgong], Could you review the patch YARN-3516.000.patch? This is a very small change to fix a regression. thanks killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status. --- Key: YARN-3516 URL: https://issues.apache.org/jira/browse/YARN-3516 Project: Hadoop YARN Issue Type: Bug Components: nodemanager Reporter: zhihai xu Assignee: zhihai xu Attachments: YARN-3516.000.patch killing ContainerLocalizer action doesn't take effect when private localizer receives FETCH_FAILURE status. This is a typo from YARN-3024. With YARN-3024, ContainerLocalizer will be killed only if {{action}} is set to {{LocalizerAction.DIE}}, calling {{response.setLocalizerAction}} will be overwritten. This is also a regression from old code. Also it make sense to kill the ContainerLocalizer when FETCH_FAILURE happened, because the container will send CLEANUP_CONTAINER_RESOURCES event after localization failure. -- This message was sent by Atlassian JIRA (v6.3.4#6332)