[jira] [Commented] (YARN-3974) Refactor the reservation system test cases to use parameterized base test
[ https://issues.apache.org/jira/browse/YARN-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14661842#comment-14661842 ] Hudson commented on YARN-3974: -- FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #269 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/269/]) YARN-3974. Refactor the reservation system test cases to use parameterized base test. (subru via curino) (Carlo Curino: rev 8572a5a14b999a866fa64ce32ee20078ffefdb1e) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/TestReservationSystem.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/PlanView.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/ReservationSystem.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/TestFairReservationSystem.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/TestCapacitySchedulerPlanFollower.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/ReservationSystemTestUtil.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/ReservationSchedulerConfiguration.java * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/TestFairSchedulerPlanFollower.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/Plan.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/TestCapacityReservationSystem.java Refactor the reservation system test cases to use parameterized base test - Key: YARN-3974 URL: https://issues.apache.org/jira/browse/YARN-3974 Project: Hadoop YARN Issue Type: Sub-task Components: capacityscheduler, fairscheduler Reporter: Subru Krishnan Assignee: Subru Krishnan Fix For: 2.8.0 Attachments: YARN-3974-v1.patch, YARN-3974-v2.patch, YARN-3974-v3.patch, YARN-3974-v4.patch, YARN-3974-v5.patch We have two test suites for testing ReservationSystem against Capacity Fair scheduler. We should combine them using a parametrized reservation system base test similar to YARN-2797 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3974) Refactor the reservation system test cases to use parameterized base test
[ https://issues.apache.org/jira/browse/YARN-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14661864#comment-14661864 ] Hudson commented on YARN-3974: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #277 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/277/]) YARN-3974. Refactor the reservation system test cases to use parameterized base test. (subru via curino) (Carlo Curino: rev 8572a5a14b999a866fa64ce32ee20078ffefdb1e) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/TestCapacitySchedulerPlanFollower.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/PlanView.java * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/TestCapacityReservationSystem.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/Plan.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/TestFairReservationSystem.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/ReservationSystem.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/TestFairSchedulerPlanFollower.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/ReservationSystemTestUtil.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/TestReservationSystem.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/ReservationSchedulerConfiguration.java Refactor the reservation system test cases to use parameterized base test - Key: YARN-3974 URL: https://issues.apache.org/jira/browse/YARN-3974 Project: Hadoop YARN Issue Type: Sub-task Components: capacityscheduler, fairscheduler Reporter: Subru Krishnan Assignee: Subru Krishnan Fix For: 2.8.0 Attachments: YARN-3974-v1.patch, YARN-3974-v2.patch, YARN-3974-v3.patch, YARN-3974-v4.patch, YARN-3974-v5.patch We have two test suites for testing ReservationSystem against Capacity Fair scheduler. We should combine them using a parametrized reservation system base test similar to YARN-2797 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3974) Refactor the reservation system test cases to use parameterized base test
[ https://issues.apache.org/jira/browse/YARN-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14661633#comment-14661633 ] Hudson commented on YARN-3974: -- FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #280 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/280/]) YARN-3974. Refactor the reservation system test cases to use parameterized base test. (subru via curino) (Carlo Curino: rev 8572a5a14b999a866fa64ce32ee20078ffefdb1e) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/TestCapacitySchedulerPlanFollower.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/TestFairSchedulerPlanFollower.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/TestCapacityReservationSystem.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/ReservationSchedulerConfiguration.java * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/PlanView.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/TestReservationSystem.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/TestFairReservationSystem.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/ReservationSystemTestUtil.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/Plan.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/ReservationSystem.java Refactor the reservation system test cases to use parameterized base test - Key: YARN-3974 URL: https://issues.apache.org/jira/browse/YARN-3974 Project: Hadoop YARN Issue Type: Sub-task Components: capacityscheduler, fairscheduler Reporter: Subru Krishnan Assignee: Subru Krishnan Fix For: 2.8.0 Attachments: YARN-3974-v1.patch, YARN-3974-v2.patch, YARN-3974-v3.patch, YARN-3974-v4.patch, YARN-3974-v5.patch We have two test suites for testing ReservationSystem against Capacity Fair scheduler. We should combine them using a parametrized reservation system base test similar to YARN-2797 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3974) Refactor the reservation system test cases to use parameterized base test
[ https://issues.apache.org/jira/browse/YARN-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14661643#comment-14661643 ] Hudson commented on YARN-3974: -- FAILURE: Integrated in Hadoop-Yarn-trunk #1010 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/1010/]) YARN-3974. Refactor the reservation system test cases to use parameterized base test. (subru via curino) (Carlo Curino: rev 8572a5a14b999a866fa64ce32ee20078ffefdb1e) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/ReservationSystem.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/TestFairSchedulerPlanFollower.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/TestCapacitySchedulerPlanFollower.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/Plan.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/PlanView.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/TestCapacityReservationSystem.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/ReservationSystemTestUtil.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/TestFairReservationSystem.java * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/ReservationSchedulerConfiguration.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/TestReservationSystem.java Refactor the reservation system test cases to use parameterized base test - Key: YARN-3974 URL: https://issues.apache.org/jira/browse/YARN-3974 Project: Hadoop YARN Issue Type: Sub-task Components: capacityscheduler, fairscheduler Reporter: Subru Krishnan Assignee: Subru Krishnan Fix For: 2.8.0 Attachments: YARN-3974-v1.patch, YARN-3974-v2.patch, YARN-3974-v3.patch, YARN-3974-v4.patch, YARN-3974-v5.patch We have two test suites for testing ReservationSystem against Capacity Fair scheduler. We should combine them using a parametrized reservation system base test similar to YARN-2797 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3974) Refactor the reservation system test cases to use parameterized base test
[ https://issues.apache.org/jira/browse/YARN-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14661916#comment-14661916 ] Hudson commented on YARN-3974: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #2207 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/2207/]) YARN-3974. Refactor the reservation system test cases to use parameterized base test. (subru via curino) (Carlo Curino: rev 8572a5a14b999a866fa64ce32ee20078ffefdb1e) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/PlanView.java * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/TestCapacitySchedulerPlanFollower.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/TestFairSchedulerPlanFollower.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/TestFairReservationSystem.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/ReservationSchedulerConfiguration.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/TestCapacityReservationSystem.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/ReservationSystemTestUtil.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/Plan.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/TestReservationSystem.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/ReservationSystem.java Refactor the reservation system test cases to use parameterized base test - Key: YARN-3974 URL: https://issues.apache.org/jira/browse/YARN-3974 Project: Hadoop YARN Issue Type: Sub-task Components: capacityscheduler, fairscheduler Reporter: Subru Krishnan Assignee: Subru Krishnan Fix For: 2.8.0 Attachments: YARN-3974-v1.patch, YARN-3974-v2.patch, YARN-3974-v3.patch, YARN-3974-v4.patch, YARN-3974-v5.patch We have two test suites for testing ReservationSystem against Capacity Fair scheduler. We should combine them using a parametrized reservation system base test similar to YARN-2797 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3974) Refactor the reservation system test cases to use parameterized base test
[ https://issues.apache.org/jira/browse/YARN-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14661891#comment-14661891 ] Hudson commented on YARN-3974: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #2226 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2226/]) YARN-3974. Refactor the reservation system test cases to use parameterized base test. (subru via curino) (Carlo Curino: rev 8572a5a14b999a866fa64ce32ee20078ffefdb1e) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/TestFairSchedulerPlanFollower.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/ReservationSystem.java * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/TestCapacityReservationSystem.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/TestCapacitySchedulerPlanFollower.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/PlanView.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/ReservationSchedulerConfiguration.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/TestFairReservationSystem.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/Plan.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/TestReservationSystem.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/ReservationSystemTestUtil.java Refactor the reservation system test cases to use parameterized base test - Key: YARN-3974 URL: https://issues.apache.org/jira/browse/YARN-3974 Project: Hadoop YARN Issue Type: Sub-task Components: capacityscheduler, fairscheduler Reporter: Subru Krishnan Assignee: Subru Krishnan Fix For: 2.8.0 Attachments: YARN-3974-v1.patch, YARN-3974-v2.patch, YARN-3974-v3.patch, YARN-3974-v4.patch, YARN-3974-v5.patch We have two test suites for testing ReservationSystem against Capacity Fair scheduler. We should combine them using a parametrized reservation system base test similar to YARN-2797 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3974) Refactor the reservation system test cases to use parameterized base test
[ https://issues.apache.org/jira/browse/YARN-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14660538#comment-14660538 ] Hudson commented on YARN-3974: -- FAILURE: Integrated in Hadoop-trunk-Commit #8275 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/8275/]) YARN-3974. Refactor the reservation system test cases to use parameterized base test. (subru via curino) (Carlo Curino: rev 8572a5a14b999a866fa64ce32ee20078ffefdb1e) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/ReservationSystem.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/Plan.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/TestCapacityReservationSystem.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/ReservationSchedulerConfiguration.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/TestReservationSystem.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/PlanView.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/TestFairSchedulerPlanFollower.java * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/TestFairReservationSystem.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/TestCapacitySchedulerPlanFollower.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/ReservationSystemTestUtil.java Refactor the reservation system test cases to use parameterized base test - Key: YARN-3974 URL: https://issues.apache.org/jira/browse/YARN-3974 Project: Hadoop YARN Issue Type: Sub-task Components: capacityscheduler, fairscheduler Reporter: Subru Krishnan Assignee: Subru Krishnan Fix For: 2.8.0 Attachments: YARN-3974-v1.patch, YARN-3974-v2.patch, YARN-3974-v3.patch, YARN-3974-v4.patch, YARN-3974-v5.patch We have two test suites for testing ReservationSystem against Capacity Fair scheduler. We should combine them using a parametrized reservation system base test similar to YARN-2797 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3974) Refactor the reservation system test cases to use parameterized base test
[ https://issues.apache.org/jira/browse/YARN-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14660541#comment-14660541 ] Subru Krishnan commented on YARN-3974: -- Thanks [~adhoot] for all the feedback and [~curino] for reviewing/committing the patch. Refactor the reservation system test cases to use parameterized base test - Key: YARN-3974 URL: https://issues.apache.org/jira/browse/YARN-3974 Project: Hadoop YARN Issue Type: Sub-task Components: capacityscheduler, fairscheduler Reporter: Subru Krishnan Assignee: Subru Krishnan Fix For: 2.8.0 Attachments: YARN-3974-v1.patch, YARN-3974-v2.patch, YARN-3974-v3.patch, YARN-3974-v4.patch, YARN-3974-v5.patch We have two test suites for testing ReservationSystem against Capacity Fair scheduler. We should combine them using a parametrized reservation system base test similar to YARN-2797 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3974) Refactor the reservation system test cases to use parameterized base test
[ https://issues.apache.org/jira/browse/YARN-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14660517#comment-14660517 ] Carlo Curino commented on YARN-3974: +1. I committed this to trunk and branch-2. Thanks [~subru] for clean up / improving these tests, and to [~adhoot] for the review. Refactor the reservation system test cases to use parameterized base test - Key: YARN-3974 URL: https://issues.apache.org/jira/browse/YARN-3974 Project: Hadoop YARN Issue Type: Sub-task Components: capacityscheduler, fairscheduler Reporter: Subru Krishnan Assignee: Subru Krishnan Attachments: YARN-3974-v1.patch, YARN-3974-v2.patch, YARN-3974-v3.patch, YARN-3974-v4.patch, YARN-3974-v5.patch We have two test suites for testing ReservationSystem against Capacity Fair scheduler. We should combine them using a parametrized reservation system base test similar to YARN-2797 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3974) Refactor the reservation system test cases to use parameterized base test
[ https://issues.apache.org/jira/browse/YARN-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14659409#comment-14659409 ] Hadoop QA commented on YARN-3974: - \\ \\ | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | pre-patch | 16m 14s | Pre-patch trunk compilation is healthy. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:green}+1{color} | tests included | 0m 0s | The patch appears to include 6 new or modified test files. | | {color:green}+1{color} | javac | 7m 46s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 9m 40s | There were no new javadoc warning messages. | | {color:green}+1{color} | release audit | 0m 23s | The applied patch does not increase the total number of release audit warnings. | | {color:green}+1{color} | checkstyle | 0m 56s | There were no new checkstyle issues. | | {color:green}+1{color} | whitespace | 0m 2s | The patch has no lines that end in whitespace. | | {color:green}+1{color} | install | 1m 21s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 36s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | findbugs | 1m 27s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. | | {color:green}+1{color} | yarn tests | 52m 38s | Tests passed in hadoop-yarn-server-resourcemanager. | | | | 91m 6s | | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12748970/YARN-3974-v5.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / f59612e | | hadoop-yarn-server-resourcemanager test log | https://builds.apache.org/job/PreCommit-YARN-Build/8778/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/8778/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/8778/console | This message was automatically generated. Refactor the reservation system test cases to use parameterized base test - Key: YARN-3974 URL: https://issues.apache.org/jira/browse/YARN-3974 Project: Hadoop YARN Issue Type: Sub-task Components: capacityscheduler, fairscheduler Reporter: Subru Krishnan Assignee: Subru Krishnan Attachments: YARN-3974-v1.patch, YARN-3974-v2.patch, YARN-3974-v3.patch, YARN-3974-v4.patch, YARN-3974-v5.patch We have two test suites for testing ReservationSystem against Capacity Fair scheduler. We should combine them using a parametrized reservation system base test similar to YARN-2797 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3974) Refactor the reservation system test cases to use parameterized base test
[ https://issues.apache.org/jira/browse/YARN-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14646895#comment-14646895 ] Hadoop QA commented on YARN-3974: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | pre-patch | 23m 43s | Pre-patch trunk compilation is healthy. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:green}+1{color} | tests included | 0m 0s | The patch appears to include 6 new or modified test files. | | {color:green}+1{color} | javac | 10m 44s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 16m 15s | There were no new javadoc warning messages. | | {color:green}+1{color} | release audit | 0m 42s | The applied patch does not increase the total number of release audit warnings. | | {color:green}+1{color} | checkstyle | 1m 13s | There were no new checkstyle issues. | | {color:green}+1{color} | whitespace | 0m 2s | The patch has no lines that end in whitespace. | | {color:green}+1{color} | install | 2m 13s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 46s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | findbugs | 2m 3s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. | | {color:red}-1{color} | yarn tests | 54m 55s | Tests failed in hadoop-yarn-server-resourcemanager. | | | | 112m 41s | | \\ \\ || Reason || Tests || | Timed out tests | org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12747854/YARN-3974-v4.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / c020b62 | | hadoop-yarn-server-resourcemanager test log | https://builds.apache.org/job/PreCommit-YARN-Build/8710/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/8710/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/8710/console | This message was automatically generated. Refactor the reservation system test cases to use parameterized base test - Key: YARN-3974 URL: https://issues.apache.org/jira/browse/YARN-3974 Project: Hadoop YARN Issue Type: Sub-task Components: capacityscheduler, fairscheduler Reporter: Subru Krishnan Assignee: Subru Krishnan Attachments: YARN-3974-v1.patch, YARN-3974-v2.patch, YARN-3974-v3.patch, YARN-3974-v4.patch We have two test suites for testing ReservationSystem against Capacity Fair scheduler. We should combine them using a parametrized reservation system base test similar to YARN-2797 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3974) Refactor the reservation system test cases to use parameterized base test
[ https://issues.apache.org/jira/browse/YARN-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14647070#comment-14647070 ] Anubhav Dhoot commented on YARN-3974: - LGTM Refactor the reservation system test cases to use parameterized base test - Key: YARN-3974 URL: https://issues.apache.org/jira/browse/YARN-3974 Project: Hadoop YARN Issue Type: Sub-task Components: capacityscheduler, fairscheduler Reporter: Subru Krishnan Assignee: Subru Krishnan Attachments: YARN-3974-v1.patch, YARN-3974-v2.patch, YARN-3974-v3.patch, YARN-3974-v4.patch We have two test suites for testing ReservationSystem against Capacity Fair scheduler. We should combine them using a parametrized reservation system base test similar to YARN-2797 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3974) Refactor the reservation system test cases to use parameterized base test
[ https://issues.apache.org/jira/browse/YARN-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14645310#comment-14645310 ] Anubhav Dhoot commented on YARN-3974: - Hi Subru the patch looks mostly good. Minor comments. Why the change from link to code? Also there is a checkstyle error. Refactor the reservation system test cases to use parameterized base test - Key: YARN-3974 URL: https://issues.apache.org/jira/browse/YARN-3974 Project: Hadoop YARN Issue Type: Sub-task Components: capacityscheduler, fairscheduler Reporter: Subru Krishnan Assignee: Subru Krishnan Attachments: YARN-3974-v1.patch, YARN-3974-v2.patch, YARN-3974-v3.patch We have two test suites for testing ReservationSystem against Capacity Fair scheduler. We should combine them using a parametrized reservation system base test similar to YARN-2797 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3974) Refactor the reservation system test cases to use parameterized base test
[ https://issues.apache.org/jira/browse/YARN-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14645470#comment-14645470 ] Subru Krishnan commented on YARN-3974: -- Thanks [~adhoot] for taking a look. I changed from link to code as I was getting checkstyle errors locally as the corresponding class is only in Javadoc and not in the API. That also answers your next comment, checkstyle errors have decreased hence the -1 which is good :). bq. The applied patch generated 1 new checkstyle issues (total was 45, now 37). Refactor the reservation system test cases to use parameterized base test - Key: YARN-3974 URL: https://issues.apache.org/jira/browse/YARN-3974 Project: Hadoop YARN Issue Type: Sub-task Components: capacityscheduler, fairscheduler Reporter: Subru Krishnan Assignee: Subru Krishnan Attachments: YARN-3974-v1.patch, YARN-3974-v2.patch, YARN-3974-v3.patch We have two test suites for testing ReservationSystem against Capacity Fair scheduler. We should combine them using a parametrized reservation system base test similar to YARN-2797 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3974) Refactor the reservation system test cases to use parameterized base test
[ https://issues.apache.org/jira/browse/YARN-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14643816#comment-14643816 ] Hadoop QA commented on YARN-3974: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | pre-patch | 16m 22s | Pre-patch trunk compilation is healthy. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:green}+1{color} | tests included | 0m 0s | The patch appears to include 6 new or modified test files. | | {color:green}+1{color} | javac | 7m 48s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 9m 44s | There were no new javadoc warning messages. | | {color:green}+1{color} | release audit | 0m 23s | The applied patch does not increase the total number of release audit warnings. | | {color:red}-1{color} | checkstyle | 0m 48s | The applied patch generated 1 new checkstyle issues (total was 45, now 37). | | {color:green}+1{color} | whitespace | 0m 2s | The patch has no lines that end in whitespace. | | {color:green}+1{color} | install | 1m 22s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | findbugs | 1m 25s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. | | {color:green}+1{color} | yarn tests | 52m 25s | Tests passed in hadoop-yarn-server-resourcemanager. | | | | 90m 57s | | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12747483/YARN-3974-v3.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / 3572ebd | | checkstyle | https://builds.apache.org/job/PreCommit-YARN-Build/8690/artifact/patchprocess/diffcheckstylehadoop-yarn-server-resourcemanager.txt | | hadoop-yarn-server-resourcemanager test log | https://builds.apache.org/job/PreCommit-YARN-Build/8690/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/8690/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/8690/console | This message was automatically generated. Refactor the reservation system test cases to use parameterized base test - Key: YARN-3974 URL: https://issues.apache.org/jira/browse/YARN-3974 Project: Hadoop YARN Issue Type: Sub-task Components: capacityscheduler, fairscheduler Reporter: Subru Krishnan Assignee: Subru Krishnan Attachments: YARN-3974-v1.patch, YARN-3974-v2.patch, YARN-3974-v3.patch We have two test suites for testing ReservationSystem against Capacity Fair scheduler. We should combine them using a parametrized reservation system base test similar to YARN-2797 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3974) Refactor the reservation system test cases to use parameterized base test
[ https://issues.apache.org/jira/browse/YARN-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14641075#comment-14641075 ] Hadoop QA commented on YARN-3974: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | pre-patch | 6m 36s | Pre-patch trunk compilation is healthy. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:green}+1{color} | tests included | 0m 0s | The patch appears to include 7 new or modified test files. | | {color:green}+1{color} | javac | 7m 42s | There were no new javac warning messages. | | {color:red}-1{color} | release audit | 0m 17s | The applied patch generated 1 release audit warnings. | | {color:green}+1{color} | checkstyle | 0m 47s | There were no new checkstyle issues. | | {color:green}+1{color} | whitespace | 0m 1s | The patch has no lines that end in whitespace. | | {color:green}+1{color} | install | 1m 19s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 31s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | findbugs | 1m 26s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. | | {color:green}+1{color} | yarn tests | 51m 58s | Tests passed in hadoop-yarn-server-resourcemanager. | | | | 70m 41s | | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12747097/YARN-3974-v1.patch | | Optional Tests | javac unit findbugs checkstyle | | git revision | trunk / d19d187 | | Release Audit | https://builds.apache.org/job/PreCommit-YARN-Build/8657/artifact/patchprocess/patchReleaseAuditProblems.txt | | hadoop-yarn-server-resourcemanager test log | https://builds.apache.org/job/PreCommit-YARN-Build/8657/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/8657/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/8657/console | This message was automatically generated. Refactor the reservation system test cases to use parameterized base test - Key: YARN-3974 URL: https://issues.apache.org/jira/browse/YARN-3974 Project: Hadoop YARN Issue Type: Sub-task Components: capacityscheduler, fairscheduler Reporter: Subru Krishnan Assignee: Subru Krishnan Attachments: YARN-3974-v1.patch We have two test suites for testing ReservationSystem against Capacity Fair scheduler. We should combine them using a parametrized reservation system base test similar to YARN-2797 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3974) Refactor the reservation system test cases to use parameterized base test
[ https://issues.apache.org/jira/browse/YARN-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14641365#comment-14641365 ] Hadoop QA commented on YARN-3974: - \\ \\ | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | pre-patch | 6m 41s | Pre-patch trunk compilation is healthy. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:green}+1{color} | tests included | 0m 0s | The patch appears to include 6 new or modified test files. | | {color:green}+1{color} | javac | 7m 41s | There were no new javac warning messages. | | {color:green}+1{color} | release audit | 0m 20s | The applied patch does not increase the total number of release audit warnings. | | {color:green}+1{color} | checkstyle | 0m 48s | There were no new checkstyle issues. | | {color:green}+1{color} | whitespace | 0m 1s | The patch has no lines that end in whitespace. | | {color:green}+1{color} | install | 1m 22s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 32s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | findbugs | 1m 24s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. | | {color:green}+1{color} | yarn tests | 52m 19s | Tests passed in hadoop-yarn-server-resourcemanager. | | | | 71m 11s | | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12747148/YARN-3974-v2.patch | | Optional Tests | javac unit findbugs checkstyle | | git revision | trunk / adcf5dd | | hadoop-yarn-server-resourcemanager test log | https://builds.apache.org/job/PreCommit-YARN-Build/8664/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/8664/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/8664/console | This message was automatically generated. Refactor the reservation system test cases to use parameterized base test - Key: YARN-3974 URL: https://issues.apache.org/jira/browse/YARN-3974 Project: Hadoop YARN Issue Type: Sub-task Components: capacityscheduler, fairscheduler Reporter: Subru Krishnan Assignee: Subru Krishnan Attachments: YARN-3974-v1.patch, YARN-3974-v2.patch We have two test suites for testing ReservationSystem against Capacity Fair scheduler. We should combine them using a parametrized reservation system base test similar to YARN-2797 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3974) Refactor the reservation system test cases to use parameterized base test
[ https://issues.apache.org/jira/browse/YARN-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14641343#comment-14641343 ] Anubhav Dhoot commented on YARN-3974: - Thanks Subru for improving these test cases. I think we can make it derive from ParameterizedSchedulerTestBase and get rid of ParameterizedReservationSystemTestBase (Attaching patch that does this) Some minor feedback Casing for getreservationQueueName - getReservationQueueName Looks like there are some methods that are no longer called such as validateNewReservationQueue which can be removed, which is great Refactor the reservation system test cases to use parameterized base test - Key: YARN-3974 URL: https://issues.apache.org/jira/browse/YARN-3974 Project: Hadoop YARN Issue Type: Sub-task Components: capacityscheduler, fairscheduler Reporter: Subru Krishnan Assignee: Subru Krishnan Attachments: YARN-3974-v1.patch We have two test suites for testing ReservationSystem against Capacity Fair scheduler. We should combine them using a parametrized reservation system base test similar to YARN-2797 -- This message was sent by Atlassian JIRA (v6.3.4#6332)