[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15273639#comment-15273639 ] Rohith Sharma K S commented on YARN-4807: - [~sunilg] I tried back porting this JIRA, there are

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15271054#comment-15271054 ] Sunil G commented on YARN-4807: --- Hi [~kasha] and [~yufeigu] I think this patch will be very helpful in 2.8

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15260496#comment-15260496 ] Yufei Gu commented on YARN-4807: Thanks a lot for the review, [~templedf] and [~kasha]. Thanks a lot for

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15260477#comment-15260477 ] Hudson commented on YARN-4807: -- FAILURE: Integrated in Hadoop-trunk-Commit #9682 (See

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15260452#comment-15260452 ] Karthik Kambatla commented on YARN-4807: +1, checking this in. > MockAM#waitForState sleep

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15256689#comment-15256689 ] Yufei Gu commented on YARN-4807: All test failures are not related to the patch after my investigation.

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15255000#comment-15255000 ] Hadoop QA commented on YARN-4807: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15251093#comment-15251093 ] Hadoop QA commented on YARN-4807: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15250750#comment-15250750 ] Hadoop QA commented on YARN-4807: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15250423#comment-15250423 ] Yufei Gu commented on YARN-4807: Seems like it did make some test cases flaky. Need more investigate. Sorry

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15250372#comment-15250372 ] Yufei Gu commented on YARN-4807: Thanks [~kasha] for the review. Some of them did invoke {{waitForState}}.

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15250287#comment-15250287 ] Karthik Kambatla commented on YARN-4807: Thanks [~yufeigu] for working on this and [~templedf] for

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15248956#comment-15248956 ] Hadoop QA commented on YARN-4807: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15248918#comment-15248918 ] Daniel Templeton commented on YARN-4807: LGTM. [~kasha], wanna take one last look? >

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15248894#comment-15248894 ] Yufei Gu commented on YARN-4807: Thanks [~templedf] for detailed review. I uploaded the new patch for it.

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15248714#comment-15248714 ] Daniel Templeton commented on YARN-4807: Thanks, [~yufeigu]. I just did one last thorough review

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15248635#comment-15248635 ] Yufei Gu commented on YARN-4807: [~templedf], Thanks very much for detailed review. I uploaded a new patch

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15248587#comment-15248587 ] Hadoop QA commented on YARN-4807: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15248555#comment-15248555 ] Daniel Templeton commented on YARN-4807: The signatures look better, but I'd still like to see the

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15248408#comment-15248408 ] Yufei Gu commented on YARN-4807: [~templedf], Thanks very much for pointing out. You are right. Some of

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15248175#comment-15248175 ] Daniel Templeton commented on YARN-4807: Thanks, [~yufeigu]! A quick skim of the patch looks good.

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15246863#comment-15246863 ] Hadoop QA commented on YARN-4807: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15246717#comment-15246717 ] Yufei Gu commented on YARN-4807: Thanks [~templedf] for all nice suggestions. The new patch I attached

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15246217#comment-15246217 ] Daniel Templeton commented on YARN-4807: Thanks for the update, [~yufeigu]. Back to those loops...

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15241479#comment-15241479 ] Yufei Gu commented on YARN-4807: Worth to mention that all failed test cases are unrelated to the patch.

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15240164#comment-15240164 ] Hadoop QA commented on YARN-4807: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15240145#comment-15240145 ] Hadoop QA commented on YARN-4807: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15239905#comment-15239905 ] Daniel Templeton commented on YARN-4807: Looks like the same tests are still failing. Did you add

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15236498#comment-15236498 ] Hadoop QA commented on YARN-4807: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228934#comment-15228934 ] Yufei Gu commented on YARN-4807: [~ka...@cloudera.com], you are right. I have a misunderstanding to the

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15223451#comment-15223451 ] Karthik Kambatla commented on YARN-4807: The latest Jenkins run has a bunch of test failures. Are

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15223443#comment-15223443 ] Yufei Gu commented on YARN-4807: Sure. Thanks for nice suggestions. I haven't found any test case failing

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15222734#comment-15222734 ] Karthik Kambatla commented on YARN-4807: For the tests that are failing because the insufficient

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15222631#comment-15222631 ] Hadoop QA commented on YARN-4807: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15222546#comment-15222546 ] Yufei Gu commented on YARN-4807: Hi [~ka...@cloudera.com], I uploaded the seventh path. Please have a look.

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15222045#comment-15222045 ] Yufei Gu commented on YARN-4807: BTW, I create YARN-4907 as a followup JIRA for inconsistency. >

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15222023#comment-15222023 ] Yufei Gu commented on YARN-4807: Thanks [~ka...@cloudera.com] for detailed review. 1. Yes. Besides, I also

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15221887#comment-15221887 ] Karthik Kambatla commented on YARN-4807: One other nit: can we rename variables {{loop}} to

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15221876#comment-15221876 ] Karthik Kambatla commented on YARN-4807: Few comments, mostly nits: MockRM # Can we use "private

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15221855#comment-15221855 ] Karthik Kambatla commented on YARN-4807: Taking a closer look... > MockAM#waitForState sleep

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15221051#comment-15221051 ] Hadoop QA commented on YARN-4807: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15219380#comment-15219380 ] Yufei Gu commented on YARN-4807: Thanks [~ka...@cloudera.com] for review and very nice suggestions.

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15219092#comment-15219092 ] Karthik Kambatla commented on YARN-4807: Quickly skimmed through the patch. Couple of comments: #

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15218824#comment-15218824 ] Yufei Gu commented on YARN-4807: Thanks [~sunilg] for review. Nice suggestion about SEC. I'll put them in

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15216839#comment-15216839 ] Hadoop QA commented on YARN-4807: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15216652#comment-15216652 ] Sunil G commented on YARN-4807: --- Thanks [~yufeigu] and [~templedf] for this work. Its much needed, and lots

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15216626#comment-15216626 ] Yufei Gu commented on YARN-4807: Thanks a lot for reviewing, [~templedf]. Nice suggestions! I uploaded the

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15216044#comment-15216044 ] Daniel Templeton commented on YARN-4807: Thanks, [~yufeigu]! Looks really good. To bring this

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212755#comment-15212755 ] Hadoop QA commented on YARN-4807: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212446#comment-15212446 ] Yufei Gu commented on YARN-4807: Hi [~templedf], Thank you very much for the second review. I uploaded

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212127#comment-15212127 ] Daniel Templeton commented on YARN-4807: Thanks, [~yufeigu]. Here's an example of what I mean

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211344#comment-15211344 ] Hadoop QA commented on YARN-4807: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210992#comment-15210992 ] Yufei Gu commented on YARN-4807: Hi [~templedf], Thanks a lot for reviewing my code. I uploaded patch 002.

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210429#comment-15210429 ] Daniel Templeton commented on YARN-4807: [~yufeigu], thanks for the patch. I have a few comments:

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207937#comment-15207937 ] Hadoop QA commented on YARN-4807: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15205047#comment-15205047 ] Yufei Gu commented on YARN-4807: 1. {quote}I have seen test cases where there is no reference to an RM or

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15192771#comment-15192771 ] Sunil G commented on YARN-4807: --- Yes [~kasha]. Many of the waiteState has cumulative timeout value hardcoded

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15192753#comment-15192753 ] Varun Vasudev commented on YARN-4807: - I'd prefer to start with Karthik's approach. Let's make the

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15192416#comment-15192416 ] Karthik Kambatla commented on YARN-4807: Actually, the problem seems worse. We have multiple

[jira] [Commented] (YARN-4807) MockAM#waitForState sleep duration is too long

[ https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15192270#comment-15192270 ] Sunil G commented on YARN-4807: --- As I see, {{MockRM#waitForState}} is also considering 500ms to 1sec in