[jira] [Commented] (YARN-5756) Add state-machine implementation for queues

2016-12-22 Thread Wangda Tan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15771177#comment-15771177 ] Wangda Tan commented on YARN-5756: -- +1, will commit tomorrow if no opposite opinions. Than

[jira] [Commented] (YARN-5756) Add state-machine implementation for queues

2016-12-21 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15768724#comment-15768724 ] Hadoop QA commented on YARN-5756: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-5756) Add state-machine implementation for queues

2016-12-21 Thread Xuan Gong (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15768555#comment-15768555 ] Xuan Gong commented on YARN-5756: - Added a new testcase for this. Please review. > Add st

[jira] [Commented] (YARN-5756) Add state-machine implementation for queues

2016-12-19 Thread Wangda Tan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15762758#comment-15762758 ] Wangda Tan commented on YARN-5756: -- Thanks [~xgong], generally looks good, only one commen

[jira] [Commented] (YARN-5756) Add state-machine implementation for queues

2016-12-16 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15755898#comment-15755898 ] Hadoop QA commented on YARN-5756: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote |

[jira] [Commented] (YARN-5756) Add state-machine implementation for queues

2016-12-16 Thread Xuan Gong (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15755732#comment-15755732 ] Xuan Gong commented on YARN-5756: - [~wangda] Thanks for the view. Attached a patch for all

[jira] [Commented] (YARN-5756) Add state-machine implementation for queues

2016-12-15 Thread Wangda Tan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15753079#comment-15753079 ] Wangda Tan commented on YARN-5756: -- Thanks [~xgong], Generally looks good, some minor com

[jira] [Commented] (YARN-5756) Add state-machine implementation for queues

2016-12-14 Thread Xuan Gong (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15749691#comment-15749691 ] Xuan Gong commented on YARN-5756: - Thanks for the comments, [~leftnoteasy] Have uploaded a

[jira] [Commented] (YARN-5756) Add state-machine implementation for queues

2016-12-06 Thread Wangda Tan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15726717#comment-15726717 ] Wangda Tan commented on YARN-5756: -- Thanks [~xgong], some comments/questions. General: -

[jira] [Commented] (YARN-5756) Add state-machine implementation for queues

2016-12-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15723920#comment-15723920 ] Hadoop QA commented on YARN-5756: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-5756) Add state-machine implementation for queues

2016-12-05 Thread Li Lu (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15723639#comment-15723639 ] Li Lu commented on YARN-5756: - Thanks [~xgong]. Looks fine but I'm not extremely familiar with

[jira] [Commented] (YARN-5756) Add state-machine implementation for queues

2016-12-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15723427#comment-15723427 ] Hadoop QA commented on YARN-5756: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-5756) Add state-machine implementation for queues

2016-12-02 Thread Xuan Gong (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15716638#comment-15716638 ] Xuan Gong commented on YARN-5756: - Thanks for the review. [~gtCarrera9] uploaded a new pat

[jira] [Commented] (YARN-5756) Add state-machine implementation for queues

2016-12-01 Thread Li Lu (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15713505#comment-15713505 ] Li Lu commented on YARN-5756: - Thanks [~xgong] for the patch! Generally fine, some comments: Q

[jira] [Commented] (YARN-5756) Add state-machine implementation for queues

2016-12-01 Thread Li Lu (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15713290#comment-15713290 ] Li Lu commented on YARN-5756: - Seems like the second submission has been ignored by Jenkins. Ki

[jira] [Commented] (YARN-5756) Add state-machine implementation for queues

2016-11-30 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15710419#comment-15710419 ] Hadoop QA commented on YARN-5756: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-5756) Add state-machine implementation for queues

2016-11-30 Thread Xuan Gong (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15710327#comment-15710327 ] Xuan Gong commented on YARN-5756: - rebase the patch. > Add state-machine implementation fo

[jira] [Commented] (YARN-5756) Add state-machine implementation for queues

2016-11-30 Thread Li Lu (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15710022#comment-15710022 ] Li Lu commented on YARN-5756: - Hi [~xgong], I tried to apply the patch locally but there were s

[jira] [Commented] (YARN-5756) Add state-machine implementation for queues

2016-11-07 Thread Xuan Gong (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15644904#comment-15644904 ] Xuan Gong commented on YARN-5756: - In this patch, created a QueueStateManager to manage the