[
https://issues.apache.org/jira/browse/YARN-7455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Brennan reassigned YARN-7455:
-
Assignee: Jim Brennan
> quote_and_append_arg can overflow buffer
>
[
https://issues.apache.org/jira/browse/YARN-7455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272902#comment-16272902
]
Jim Brennan commented on YARN-7455:
---
The unit test failures do not appear to be related to my patch -
[
https://issues.apache.org/jira/browse/YARN-7455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Brennan updated YARN-7455:
--
Attachment: YARN-7455.002.patch
Attaching a second patch with minor changes to my test (no functional
[
https://issues.apache.org/jira/browse/YARN-7455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16273206#comment-16273206
]
Jim Brennan commented on YARN-7455:
---
Another hadoop.yarn.server.nodemanager.webapp.TestNMWebServices that
[
https://issues.apache.org/jira/browse/YARN-7455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16273622#comment-16273622
]
Jim Brennan commented on YARN-7455:
---
Thanks for the suggestions. Using snprintf to calculate the size is
[
https://issues.apache.org/jira/browse/YARN-7455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Brennan updated YARN-7455:
--
Attachment: YARN-7455.001.patch
I am attaching a patch that addresses the buffer overflow issues
[
https://issues.apache.org/jira/browse/YARN-7455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274788#comment-16274788
]
Jim Brennan commented on YARN-7455:
---
The same hadoop.yarn.server.nodemanager.webapp.TestNMWebServices
[
https://issues.apache.org/jira/browse/YARN-7595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288371#comment-16288371
]
Jim Brennan commented on YARN-7595:
---
Will do. Thanks!
> Container launching code suppresses close
[
https://issues.apache.org/jira/browse/YARN-7595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16291151#comment-16291151
]
Jim Brennan commented on YARN-7595:
---
This is ready for review for branch-2.
> Container launching code
[
https://issues.apache.org/jira/browse/YARN-7595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Brennan reopened YARN-7595:
---
Re-opening after adding a patch for branch-2.
> Container launching code suppresses close exceptions
[
https://issues.apache.org/jira/browse/YARN-7595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Brennan updated YARN-7595:
--
Attachment: YARN-7595-branch-2.8.001.patch
Adding a patch for branch-2.8.
Ran nodemanager tests locally
[
https://issues.apache.org/jira/browse/YARN-7595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Brennan updated YARN-7595:
--
Attachment: YARN-7595-branch-2.8.002.patch
Submitting a new branch-2.8 patch that fixes the checkstyle
[
https://issues.apache.org/jira/browse/YARN-7595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292968#comment-16292968
]
Jim Brennan commented on YARN-7595:
---
I believe these junit test failures are not related to this patch.
I
[
https://issues.apache.org/jira/browse/YARN-7595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Brennan updated YARN-7595:
--
Attachment: YARN-7595-branch-2.001.patch
Attaching a patch for branch-2.
> Container launching code
[
https://issues.apache.org/jira/browse/YARN-7595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282541#comment-16282541
]
Jim Brennan commented on YARN-7595:
---
The JUnit test that failed (testValidEnvVariableSubstitution) fails
[
https://issues.apache.org/jira/browse/YARN-7455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Brennan updated YARN-7455:
--
Attachment: YARN-7455.003.patch
Uploaded a new patch with changes as suggested by JLowe.
Reran tests
[
https://issues.apache.org/jira/browse/YARN-7595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Brennan updated YARN-7595:
--
Attachment: YARN-7595.001.patch
Attaching patch with fixes. Ran tests locally.
> Container launching
[
https://issues.apache.org/jira/browse/YARN-7595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Brennan updated YARN-7595:
--
Attachment: YARN-7595.002.patch
Thanks for the comments. I have uploaded a new patch that addresses
[
https://issues.apache.org/jira/browse/YARN-7595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Brennan reassigned YARN-7595:
-
Assignee: Jim Brennan
> Container launching code suppresses close exceptions after writes
>
[
https://issues.apache.org/jira/browse/YARN-7595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16286708#comment-16286708
]
Jim Brennan commented on YARN-7595:
---
The unit test failure is the same one as before.
The checkstyle
[
https://issues.apache.org/jira/browse/YARN-7595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Brennan updated YARN-7595:
--
Attachment: YARN-7595.003.patch
Updating a new patch that addresses the checkstyle issues.
> Container
[
https://issues.apache.org/jira/browse/YARN-8244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Brennan updated YARN-8244:
--
Attachment: YARN-8244.001.patch
> TestContainerSchedulerQueuing.testStartMultipleContainers failed
>
[
https://issues.apache.org/jira/browse/YARN-8244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468926#comment-16468926
]
Jim Brennan commented on YARN-8244:
---
The problem is in the test. It is using the same
[
https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468949#comment-16468949
]
Jim Brennan commented on YARN-7654:
---
{quote}docker logs does not seem to separate out stdout from stderr.
[
https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469201#comment-16469201
]
Jim Brennan commented on YARN-8206:
---
[~ebadger], patch 7 does not look right...
> Sending a kill does
[
https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469331#comment-16469331
]
Jim Brennan commented on YARN-8206:
---
New patch looks good to me.
> Sending a kill does not immediately
[
https://issues.apache.org/jira/browse/YARN-8244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Brennan updated YARN-8244:
--
Attachment: YARN-8244.002.patch
> TestContainerSchedulerQueuing.testStartMultipleContainers failed
>
[
https://issues.apache.org/jira/browse/YARN-8244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470551#comment-16470551
]
Jim Brennan commented on YARN-8244:
---
[~jlowe], I put up another patch that does pretty much what you
[
https://issues.apache.org/jira/browse/YARN-8244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469504#comment-16469504
]
Jim Brennan commented on YARN-8244:
---
Looking into why the other tests are not failing for me.
The
[
https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469116#comment-16469116
]
Jim Brennan commented on YARN-8206:
---
[~ebadger], thanks for the patch!
In handleContainerKill(), you
[
https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467574#comment-16467574
]
Jim Brennan commented on YARN-8206:
---
+1 for proposal 2.
> Sending a kill does not immediately kill
[
https://issues.apache.org/jira/browse/YARN-8244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Brennan reassigned YARN-8244:
-
Assignee: Jim Brennan
> TestContainerSchedulerQueuing.testStartMultipleContainers failed
>
[
https://issues.apache.org/jira/browse/YARN-6919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479115#comment-16479115
]
Jim Brennan commented on YARN-6919:
---
[~ebadger], thanks for the patch! Code looks good to me.
>
[
https://issues.apache.org/jira/browse/YARN-8071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477936#comment-16477936
]
Jim Brennan commented on YARN-8071:
---
[~jlowe], thanks for the review:
{quote}The changes to
[
https://issues.apache.org/jira/browse/YARN-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508198#comment-16508198
]
Jim Brennan commented on YARN-8259:
---
I think we should go with Option 1 with documentation to whitelist
[
https://issues.apache.org/jira/browse/YARN-8417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517531#comment-16517531
]
Jim Brennan commented on YARN-8417:
---
Just to clarify - this is only for the ENTRY_POINT case, right?
[
https://issues.apache.org/jira/browse/YARN-8444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16518616#comment-16518616
]
Jim Brennan commented on YARN-8444:
---
I am not able to reproduce the unit test failures locally, and it
[
https://issues.apache.org/jira/browse/YARN-8444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Brennan updated YARN-8444:
--
Attachment: YARN-8444.001.patch
> NodeResourceMonitor crashes on bad swapFree value
>
[
https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460139#comment-16460139
]
Jim Brennan commented on YARN-8207:
---
[~eyang], I spent a little time looking at this one today. Didn't
[
https://issues.apache.org/jira/browse/YARN-8209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459733#comment-16459733
]
Jim Brennan commented on YARN-8209:
---
[~ebadger], a few comments:
As [~eyang] said,
[
https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458694#comment-16458694
]
Jim Brennan commented on YARN-8206:
---
[~eyang], [~jlowe], I'm not sure I see the advantage of using the
[
https://issues.apache.org/jira/browse/YARN-8071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458661#comment-16458661
]
Jim Brennan commented on YARN-8071:
---
{quote}
The original code passed the current environment map,
[
https://issues.apache.org/jira/browse/YARN-8071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Brennan updated YARN-8071:
--
Attachment: YARN-8071.003.patch
> Add ability to specify nodemanager environment variables individually
[
https://issues.apache.org/jira/browse/YARN-8071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458819#comment-16458819
]
Jim Brennan commented on YARN-8071:
---
[~jlowe], this is ready to review again.
> Add ability to specify
[
https://issues.apache.org/jira/browse/YARN-7796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340101#comment-16340101
]
Jim Brennan commented on YARN-7796:
---
We ran into this same issue when running a container-executor that
[
https://issues.apache.org/jira/browse/YARN-6721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340132#comment-16340132
]
Jim Brennan commented on YARN-6721:
---
The segmentation fault in container-executor reported in -YARN-7796-
[
https://issues.apache.org/jira/browse/YARN-7796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341628#comment-16341628
]
Jim Brennan commented on YARN-7796:
---
[~grepas] that is interesting. I wonder if it is the version of gcc
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345301#comment-16345301
]
Jim Brennan commented on YARN-7677:
---
I believe the unit test failure
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Brennan updated YARN-7677:
--
Attachment: YARN-7677.001.patch
> HADOOP_CONF_DIR should not be automatically put in task environment
>
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344137#comment-16344137
]
Jim Brennan commented on YARN-7677:
---
Based on the discussion here and in YARN-7226, and after discussing
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Brennan updated YARN-7677:
--
Attachment: YARN-7677.002.patch
> HADOOP_CONF_DIR should not be automatically put in task environment
>
[
https://issues.apache.org/jira/browse/YARN-6721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345362#comment-16345362
]
Jim Brennan commented on YARN-6721:
---
I've filed a new Jira for this compatibility issue: YARN-7857
>
[
https://issues.apache.org/jira/browse/YARN-7796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345361#comment-16345361
]
Jim Brennan commented on YARN-7796:
---
I've filed a new Jira for this binary compatibility issue: YARN-7857
[
https://issues.apache.org/jira/browse/YARN-7857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345354#comment-16345354
]
Jim Brennan commented on YARN-7857:
---
I've also verified this with a simple test program that just does
Jim Brennan created YARN-7857:
-
Summary: -fstack-check compilation flag causes binary
incompatibility for container-executor between RHEL 6 and RHEL 7
Key: YARN-7857
URL:
[
https://issues.apache.org/jira/browse/YARN-7857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345341#comment-16345341
]
Jim Brennan commented on YARN-7857:
---
This redhat link suggests that there are problems with stack-check:
[
https://issues.apache.org/jira/browse/YARN-7857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345356#comment-16345356
]
Jim Brennan commented on YARN-7857:
---
Also see the discussion in the comments in YARN-7796
>
[
https://issues.apache.org/jira/browse/YARN-7857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Brennan updated YARN-7857:
--
Comment: was deleted
(was: The {{-fcheck-stack}} flag was introduced by this Jira.)
> -fstack-check
[
https://issues.apache.org/jira/browse/YARN-7857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Brennan updated YARN-7857:
--
Comment: was deleted
(was: The SIGSEGV reported in this Jira is a result of compiling with
[
https://issues.apache.org/jira/browse/YARN-7857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345776#comment-16345776
]
Jim Brennan commented on YARN-7857:
---
The SIGSEGV reported in this Jira is a result of compiling with
[
https://issues.apache.org/jira/browse/YARN-7857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345771#comment-16345771
]
Jim Brennan commented on YARN-7857:
---
The {{-fcheck-stack}} flag was introduced by this Jira.
>
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350500#comment-16350500
]
Jim Brennan commented on YARN-7677:
---
Thanks everyone! I will work on a new patch using this approach.
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16348684#comment-16348684
]
Jim Brennan commented on YARN-7677:
---
Thanks [~jlowe] I will put up a patch for branch-2.
> Docker image
[
https://issues.apache.org/jira/browse/YARN-7857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350833#comment-16350833
]
Jim Brennan commented on YARN-7857:
---
Thanks [~miklos.szeg...@cloudera.com]! That is a good suggestion. I
[
https://issues.apache.org/jira/browse/YARN-7857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Brennan updated YARN-7857:
--
Attachment: YARN-7857.001.patch
> -fstack-check compilation flag causes binary incompatibility for
>
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349117#comment-16349117
]
Jim Brennan commented on YARN-7677:
---
Thanks [~shaneku...@gmail.com] and [~billie.rinaldi], I will try out
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349168#comment-16349168
]
Jim Brennan commented on YARN-7677:
---
Agreed - given that we are just processing the hash map in order, it
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349024#comment-16349024
]
Jim Brennan commented on YARN-7677:
---
[~shaneku...@gmail.com], [~jlowe], [~ebadger] I have verified that
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16348795#comment-16348795
]
Jim Brennan commented on YARN-7677:
---
[~shaneku...@gmail.com] are you running with docker?
> Docker image
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16348898#comment-16348898
]
Jim Brennan commented on YARN-7677:
---
[~shaneku...@gmail.com], I am trying to repro locally. In my dev
[
https://issues.apache.org/jira/browse/YARN-7857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347175#comment-16347175
]
Jim Brennan commented on YARN-7857:
---
Thanks [~miklos.szeg...@cloudera.com] for the detailed analysis!
I
[
https://issues.apache.org/jira/browse/YARN-7857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349410#comment-16349410
]
Jim Brennan commented on YARN-7857:
---
As this is a change to the command line for container-executor, it
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349305#comment-16349305
]
Jim Brennan commented on YARN-7677:
---
I have tested a version of the patch where I write out the
[
https://issues.apache.org/jira/browse/YARN-7796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343452#comment-16343452
]
Jim Brennan commented on YARN-7796:
---
[~miklos.szeg...@cloudera.com] - I believe the max stack size
[
https://issues.apache.org/jira/browse/YARN-7857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352816#comment-16352816
]
Jim Brennan commented on YARN-7857:
---
[~miklos.szeg...@cloudera.com] I have prepared another patch that
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Brennan updated YARN-7677:
--
Attachment: YARN-7677.003.patch
> Docker image cannot set HADOOP_CONF_DIR
>
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361418#comment-16361418
]
Jim Brennan commented on YARN-7677:
---
I've put up another patch for this that addresses the ordering
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362445#comment-16362445
]
Jim Brennan commented on YARN-7677:
---
I submitted a new patch that addresses some of the style-check
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Brennan updated YARN-7677:
--
Attachment: YARN-7677.004.patch
> Docker image cannot set HADOOP_CONF_DIR
>
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362696#comment-16362696
]
Jim Brennan commented on YARN-7677:
---
I believe these are intermittent failures:
{noformat}
ERROR]
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363006#comment-16363006
]
Jim Brennan commented on YARN-7677:
---
Thanks for the review! I will address these issues and put up a new
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364778#comment-16364778
]
Jim Brennan commented on YARN-7677:
---
The remaining check-style issue is for adding an 8th parameter to
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364945#comment-16364945
]
Jim Brennan commented on YARN-7677:
---
{quote}I noticed that sanitizeWindowsEnv no longer adds CLASSPATH to
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364652#comment-16364652
]
Jim Brennan commented on YARN-7677:
---
Uploaded another patch with updates based on [~jlowe]'s review.
>
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Brennan updated YARN-7677:
--
Attachment: YARN-7677.005.patch
> Docker image cannot set HADOOP_CONF_DIR
>
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365721#comment-16365721
]
Jim Brennan commented on YARN-7677:
---
[~jlowe], do you agree about the CLASSPATH for windows? Let me know
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Brennan updated YARN-5714:
--
Attachment: YARN-5714.007.patch
> ContainerExecutor does not order environment map
>
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372162#comment-16372162
]
Jim Brennan commented on YARN-5714:
---
As this has become a blocking issue for YARN-7677, I took the
[
https://issues.apache.org/jira/browse/YARN-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369205#comment-16369205
]
Jim Brennan commented on YARN-7677:
---
Agreed. Without this patch, the ordering of variables in the
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373045#comment-16373045
]
Jim Brennan commented on YARN-5714:
---
Original version of path.008 did not include the checkstyle fixes.
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Brennan updated YARN-5714:
--
Attachment: YARN-5714.008.patch
> ContainerExecutor does not order environment map
>
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373113#comment-16373113
]
Jim Brennan commented on YARN-5714:
---
I believe this patch is now ready for review.
>
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Brennan updated YARN-5714:
--
Attachment: (was: YARN-5714.008.patch)
> ContainerExecutor does not order environment map
>
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Brennan updated YARN-5714:
--
Attachment: YARN-5714.009.patch
> ContainerExecutor does not order environment map
>
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373444#comment-16373444
]
Jim Brennan commented on YARN-5714:
---
This patch is ready for review.
> ContainerExecutor does not order
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Brennan updated YARN-5714:
--
Attachment: YARN-5714.008.patch
> ContainerExecutor does not order environment map
>
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372939#comment-16372939
]
Jim Brennan commented on YARN-5714:
---
Uploaded a new patch that addresses the check-style issues.
>
Jim Brennan created YARN-7678:
-
Summary: Logging of container memory stats is missing in 2.8
Key: YARN-7678
URL: https://issues.apache.org/jira/browse/YARN-7678
Project: Hadoop YARN
Issue Type:
[
https://issues.apache.org/jira/browse/YARN-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300442#comment-16300442
]
Jim Brennan commented on YARN-7678:
---
Did not add a new automated test because this just changes the
[
https://issues.apache.org/jira/browse/YARN-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Brennan updated YARN-7678:
--
Attachment: YARN-7678.001.patch
Uploading patch for testing.
Tested locally by running unit tests and
1 - 100 of 736 matches
Mail list logo
