[jira] [Commented] (YARN-2868) Add metric for initial container launch time to FairScheduler

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14376633#comment-14376633 ] Karthik Kambatla commented on YARN-2868: +1, checking this in. > Add metric for i

[jira] [Commented] (YARN-2868) Add metric for initial container launch time to FairScheduler

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14372575#comment-14372575 ] Hadoop QA commented on YARN-2868: - {color:red}-1 overall{color}. Here are the results of t

[jira] [Commented] (YARN-2868) Add metric for initial container launch time to FairScheduler

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14372364#comment-14372364 ] Hadoop QA commented on YARN-2868: - {color:red}-1 overall{color}. Here are the results of t

[jira] [Commented] (YARN-2868) Add metric for initial container launch time to FairScheduler

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14372341#comment-14372341 ] Karthik Kambatla commented on YARN-2868: +1, pending Jenkins. > Add metric for ini

[jira] [Commented] (YARN-2868) Add metric for initial container launch time to FairScheduler

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14349323#comment-14349323 ] Ray Chiang commented on YARN-2868: -- RE: findbugs None of the flagged issues are in files

[jira] [Commented] (YARN-2868) Add metric for initial container launch time to FairScheduler

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14348252#comment-14348252 ] Hadoop QA commented on YARN-2868: - {color:red}-1 overall{color}. Here are the results of t

[jira] [Commented] (YARN-2868) Add metric for initial container launch time to FairScheduler

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14343653#comment-14343653 ] Karthik Kambatla commented on YARN-2868: Sorry for coming in late. Few comments on

[jira] [Commented] (YARN-2868) Add metric for initial container launch time to FairScheduler

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14319300#comment-14319300 ] Ray Chiang commented on YARN-2868: -- [~leftnoteasy] just following up to be sure. Are you

[jira] [Commented] (YARN-2868) Add metric for initial container launch time to FairScheduler

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14302581#comment-14302581 ] Ray Chiang commented on YARN-2868: -- RE: Failing unit tests The first four tests pass fine

[jira] [Commented] (YARN-2868) Add metric for initial container launch time to FairScheduler

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14302509#comment-14302509 ] Hadoop QA commented on YARN-2868: - {color:red}-1 overall{color}. Here are the results of t

[jira] [Commented] (YARN-2868) Add metric for initial container launch time to FairScheduler

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14301920#comment-14301920 ] Ray Chiang commented on YARN-2868: -- I will do the rename. I'm still doing some writeup fo

[jira] [Commented] (YARN-2868) Add metric for initial container launch time to FairScheduler

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14301910#comment-14301910 ] Wangda Tan commented on YARN-2868: -- That makes sense, but I think we still need to address

[jira] [Commented] (YARN-2868) Add metric for initial container launch time to FairScheduler

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14301758#comment-14301758 ] Ray Chiang commented on YARN-2868: -- My current thoughts: D1) Metrics are bound to be over

[jira] [Commented] (YARN-2868) Add metric for initial container launch time to FairScheduler

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14299302#comment-14299302 ] Wangda Tan commented on YARN-2868: -- bq. Our scenario is debugging queue related issues for

[jira] [Commented] (YARN-2868) Add metric for initial container launch time to FairScheduler

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294431#comment-14294431 ] Anubhav Dhoot commented on YARN-2868: - Hi [~leftnoteasy] RMAppMetrics will be interest

[jira] [Commented] (YARN-2868) Add metric for initial container launch time to FairScheduler

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294372#comment-14294372 ] Wangda Tan commented on YARN-2868: -- Thanks for your summary, [~rchiang]. What I'm worry a

[jira] [Commented] (YARN-2868) Add metric for initial container launch time to FairScheduler

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14293908#comment-14293908 ] Ray Chiang commented on YARN-2868: -- Linked YARN-3105. > Add metric for initial container

[jira] [Commented] (YARN-2868) Add metric for initial container launch time to FairScheduler

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14293897#comment-14293897 ] Ray Chiang commented on YARN-2868: -- That makes sense, but I think that's opening up anothe

[jira] [Commented] (YARN-2868) Add metric for initial container launch time to FairScheduler

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14292798#comment-14292798 ] Jian He commented on YARN-2868: --- >From what I understand, both YARN-2802 and this jira are tr

[jira] [Commented] (YARN-2868) Add metric for initial container launch time to FairScheduler

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14292235#comment-14292235 ] Ray Chiang commented on YARN-2868: -- I would like to make this metrics discussion a bit mor

[jira] [Commented] (YARN-2868) Add metric for initial container launch time to FairScheduler

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14290431#comment-14290431 ] Rohith commented on YARN-2868: -- bq. All clustermetrics that are related to a queue should be m

[jira] [Commented] (YARN-2868) Add metric for initial container launch time to FairScheduler

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14290420#comment-14290420 ] Anubhav Dhoot commented on YARN-2868: - Adding it to ClusterMetrics will only give you a

[jira] [Commented] (YARN-2868) Add metric for initial container launch time to FairScheduler

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14290411#comment-14290411 ] Rohith commented on YARN-2868: -- I had a thought that metric can be common to all schedulers. I

[jira] [Commented] (YARN-2868) Add metric for initial container launch time to FairScheduler

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14290291#comment-14290291 ] Wangda Tan commented on YARN-2868: -- Just checked code, is it good to put in ClusterMetrics

[jira] [Commented] (YARN-2868) Add metric for initial container launch time to FairScheduler

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14290286#comment-14290286 ] Ray Chiang commented on YARN-2868: -- I had it previously in FSQueueMetrics, then moved it t

[jira] [Commented] (YARN-2868) Add metric for initial container launch time to FairScheduler

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14290272#comment-14290272 ] Wangda Tan commented on YARN-2868: -- Hmm, I think it may not good enough to put in QueueMet

[jira] [Commented] (YARN-2868) Add metric for initial container launch time to FairScheduler

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14290250#comment-14290250 ] Hadoop QA commented on YARN-2868: - {color:red}-1 overall{color}. Here are the results of t

[jira] [Commented] (YARN-2868) Add metric for initial container launch time to FairScheduler

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14289835#comment-14289835 ] Ray Chiang commented on YARN-2868: -- [~rohithsharma], it looks like CapacityScheduler/Abstr

[jira] [Commented] (YARN-2868) Add metric for initial container launch time

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14289591#comment-14289591 ] Ray Chiang commented on YARN-2868: -- Okay, my bad. I'll put it back the way it was. > Add

[jira] [Commented] (YARN-2868) Add metric for initial container launch time

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288431#comment-14288431 ] Anubhav Dhoot commented on YARN-2868: - volatile cannot be used for thread synchronizati

[jira] [Commented] (YARN-2868) Add metric for initial container launch time

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288175#comment-14288175 ] Wangda Tan commented on YARN-2868: -- [~rchiang], Just reviewed patch, I'm not sure if you m

[jira] [Commented] (YARN-2868) Add metric for initial container launch time

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14286194#comment-14286194 ] Ray Chiang commented on YARN-2868: -- Addressing the doubts: 1) It could be added to both.

[jira] [Commented] (YARN-2868) Add metric for initial container launch time

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14285424#comment-14285424 ] Rohith commented on YARN-2868: -- Thanks [~rchiang] for working on this jira. Some commets and d

[jira] [Commented] (YARN-2868) Add metric for initial container launch time

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14285306#comment-14285306 ] Hadoop QA commented on YARN-2868: - {color:red}-1 overall{color}. Here are the results of t

[jira] [Commented] (YARN-2868) Add metric for initial container launch time

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14274369#comment-14274369 ] Ray Chiang commented on YARN-2868: -- Okay. Let me look at the changes and submit a new pat

[jira] [Commented] (YARN-2868) Add metric for initial container launch time

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14274363#comment-14274363 ] Wangda Tan commented on YARN-2868: -- Thanks for explanation, #3 and [~kasha]'s comment make

[jira] [Commented] (YARN-2868) Add metric for initial container launch time

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14274317#comment-14274317 ] Karthik Kambatla commented on YARN-2868: bq. implementation of scheduler should mak

[jira] [Commented] (YARN-2868) Add metric for initial container launch time

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14274308#comment-14274308 ] Ray Chiang commented on YARN-2868: -- RE: Comment 1) Using AtomicLong seemed like the least

[jira] [Commented] (YARN-2868) Add metric for initial container launch time

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14274252#comment-14274252 ] Wangda Tan commented on YARN-2868: -- Some comments: 1. It seems overkill to me to use Atomi

[jira] [Commented] (YARN-2868) Add metric for initial container launch time

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14274162#comment-14274162 ] Hadoop QA commented on YARN-2868: - {color:red}-1 overall{color}. Here are the results of t

[jira] [Commented] (YARN-2868) Add metric for initial container launch time

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14274073#comment-14274073 ] Wangda Tan commented on YARN-2868: -- [~rchiang], Thanks for working on this. [~rkanter], co

[jira] [Commented] (YARN-2868) Add metric for initial container launch time

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14274040#comment-14274040 ] Ray Chiang commented on YARN-2868: -- Great. Thanks! > Add metric for initial container la

[jira] [Commented] (YARN-2868) Add metric for initial container launch time

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14274023#comment-14274023 ] Robert Kanter commented on YARN-2868: - Looks good to me. The last Jenkins run was a wh

[jira] [Commented] (YARN-2868) Add metric for initial container launch time

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14252367#comment-14252367 ] Ray Chiang commented on YARN-2868: -- RE: findbugs. None affecting this code. RE: unit tes

[jira] [Commented] (YARN-2868) Add metric for initial container launch time

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14252164#comment-14252164 ] Hadoop QA commented on YARN-2868: - {color:red}-1 overall{color}. Here are the results of t

[jira] [Commented] (YARN-2868) Add metric for initial container launch time

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14250541#comment-14250541 ] Anubhav Dhoot commented on YARN-2868: - Minor nits: FSQueueMetrics has some unused impo

[jira] [Commented] (YARN-2868) Add metric for initial container launch time

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14248936#comment-14248936 ] Hadoop QA commented on YARN-2868: - {color:red}-1 overall{color}. Here are the results of t

[jira] [Commented] (YARN-2868) Add metric for initial container launch time

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14248655#comment-14248655 ] Hadoop QA commented on YARN-2868: - {color:red}-1 overall{color}. Here are the results of t

[jira] [Commented] (YARN-2868) Add metric for initial container launch time

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14247620#comment-14247620 ] Hadoop QA commented on YARN-2868: - {color:red}-1 overall{color}. Here are the results of t

[jira] [Commented] (YARN-2868) Add metric for initial container launch time

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14215150#comment-14215150 ] Ray Chiang commented on YARN-2868: -- Thanks. I'll update the patch and test it out. > Add

[jira] [Commented] (YARN-2868) Add metric for initial container launch time

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14215064#comment-14215064 ] Hadoop QA commented on YARN-2868: - {color:red}-1 overall{color}. Here are the results of t

[jira] [Commented] (YARN-2868) Add metric for initial container launch time

[ https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14215025#comment-14215025 ] Anubhav Dhoot commented on YARN-2868: - Seems like the QueueMetrics change can be revert