[jira] [Commented] (YARN-5830) Avoid preempting AM containers

[ https://issues.apache.org/jira/browse/YARN-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836541#comment-15836541 ] Hadoop QA commented on YARN-5830: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5830) Avoid preempting AM containers

[ https://issues.apache.org/jira/browse/YARN-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836438#comment-15836438 ] ASF GitHub Bot commented on YARN-5830: -- Github user kambatla commented on a diff in the pull request:

[jira] [Commented] (YARN-5830) Avoid preempting AM containers

[ https://issues.apache.org/jira/browse/YARN-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836441#comment-15836441 ] Karthik Kambatla commented on YARN-5830: bq. The following code seems like buggy since when we

[jira] [Commented] (YARN-5830) Avoid preempting AM containers

[ https://issues.apache.org/jira/browse/YARN-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836439#comment-15836439 ] ASF GitHub Bot commented on YARN-5830: -- Github user kambatla commented on a diff in the pull request:

[jira] [Commented] (YARN-5830) Avoid preempting AM containers

[ https://issues.apache.org/jira/browse/YARN-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15828550#comment-15828550 ] Hadoop QA commented on YARN-5830: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5830) Avoid preempting AM containers

[ https://issues.apache.org/jira/browse/YARN-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15828484#comment-15828484 ] ASF GitHub Bot commented on YARN-5830: -- GitHub user flyrain opened a pull request:

[jira] [Commented] (YARN-5830) Avoid preempting AM containers

[ https://issues.apache.org/jira/browse/YARN-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15828449#comment-15828449 ] Yufei Gu commented on YARN-5830: Patch 006 to rebase. > Avoid preempting AM containers >

[jira] [Commented] (YARN-5830) Avoid preempting AM containers

[ https://issues.apache.org/jira/browse/YARN-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15827726#comment-15827726 ] Hadoop QA commented on YARN-5830: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5830) Avoid preempting AM containers

[ https://issues.apache.org/jira/browse/YARN-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15827715#comment-15827715 ] Yufei Gu commented on YARN-5830: Thanks [~kasha] for the detailed review. Uploaded patch 005 for your

[jira] [Commented] (YARN-5830) Avoid preempting AM containers

[ https://issues.apache.org/jira/browse/YARN-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15827067#comment-15827067 ] Karthik Kambatla commented on YARN-5830: Patch looks mostly good. Few nits: # SchedulerNode ##

[jira] [Commented] (YARN-5830) Avoid preempting AM containers

[ https://issues.apache.org/jira/browse/YARN-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15825859#comment-15825859 ] Hadoop QA commented on YARN-5830: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5830) Avoid preempting AM containers

[ https://issues.apache.org/jira/browse/YARN-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15825753#comment-15825753 ] Yufei Gu commented on YARN-5830: [~kasha], thanks a lot for your detailed review. Uploaded patch 004 for

[jira] [Commented] (YARN-5830) Avoid preempting AM containers

[ https://issues.apache.org/jira/browse/YARN-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15816420#comment-15816420 ] Karthik Kambatla commented on YARN-5830: Comments on the latest patch: # The patch does not apply

[jira] [Commented] (YARN-5830) Avoid preempting AM containers

[ https://issues.apache.org/jira/browse/YARN-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15799749#comment-15799749 ] Hadoop QA commented on YARN-5830: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5830) Avoid preempting AM containers

[ https://issues.apache.org/jira/browse/YARN-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15799497#comment-15799497 ] Yufei Gu commented on YARN-5830: Thanks [~kasha] for the review and suggestion. I've uploaded the new patch

[jira] [Commented] (YARN-5830) Avoid preempting AM containers

[ https://issues.apache.org/jira/browse/YARN-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795778#comment-15795778 ] Karthik Kambatla commented on YARN-5830: Discussed with Yufei offline. I have a couple of

[jira] [Commented] (YARN-5830) Avoid preempting AM containers

[ https://issues.apache.org/jira/browse/YARN-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15785998#comment-15785998 ] Hadoop QA commented on YARN-5830: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5830) Avoid preempting AM containers

[ https://issues.apache.org/jira/browse/YARN-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15784024#comment-15784024 ] Yufei Gu commented on YARN-5830: [~kasha], thanks for the review. The high-level approach: 1. In first

[jira] [Commented] (YARN-5830) Avoid preempting AM containers

[ https://issues.apache.org/jira/browse/YARN-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15781991#comment-15781991 ] Karthik Kambatla commented on YARN-5830: [~yufeigu], thanks for working on this. The patch seems