Re: [zd1211-devs] [PATCH] wireless-2.6 zd1211rw check against regulatory domain rather than hardcoded value of 11

2006-10-31 Thread Daniel Drake
Michael Buesch wrote: > I think the real question is: What does this "band edge" bit actually do? Not entirely sure, and I don't think we've even seen a device where this code path runs (it only runs if a certain bit is set in the EEPROM). However, considering that this looks like it plays with

Re: [zd1211-devs] [PATCH] wireless-2.6 zd1211rw check against regulatory domain rather than hardcoded value of 11

2006-10-31 Thread Holden Karau
The patch was based off the FIXME comment in the code [which suggested replacing 11 with the boundary for the regulatory domain]. I'll take a look at the vendors driver and see about modifying the patch to fit more with its logic or just limmiting it to the FCC regulatory domain. On 10/30/06, Uli

Re: [zd1211-devs] [PATCH] wireless-2.6 zd1211rw check against regulatory domain rather than hardcoded value of 11

2006-10-30 Thread Uli Kunitz
Johannes Berg wrote: >> I'm not so sure about this. This patching might be US-specific and we >> cannot simply apply the setting for top channel of another domain >> instead of channel 11. One option would be to set the value only under >> the US regulatory domain. > > ?? > What the patch does

Re: [zd1211-devs] [PATCH] wireless-2.6 zd1211rw check against regulatory domain rather than hardcoded value of 11

2006-10-29 Thread Uli Kunitz
Daniel Drake wrote: > Holden Karau wrote: >> I've changed the patch based on your suggestions :-) > > Thanks, looks fine. Let's just wait for an OK from Ulrich, then you can > send it to John, without broken tabs/lines, with signoff and description. > > Daniel I'm not so sure about this. This p

Re: [zd1211-devs] [PATCH] wireless-2.6 zd1211rw check against regulatory domain rather than hardcoded value of 11

2006-10-24 Thread Daniel Drake
Holden Karau wrote: > I've changed the patch based on your suggestions :-) Thanks, looks fine. Let's just wait for an OK from Ulrich, then you can send it to John, without broken tabs/lines, with signoff and description. Daniel -

Re: [zd1211-devs] [PATCH] wireless-2.6 zd1211rw check against regulatory domain rather than hardcoded value of 11

2006-10-23 Thread Daniel Drake
Holden Karau wrote: > From: Holden Karau <[EMAIL PROTECTED]> http://www.holdenkarau.com > > I have made a small patch for the zd1211rw driver which uses the > boundry channels of the regulatory domain, rather than the hard coded > values of 1 & 11. > Signed-off-by: Holden Karau <[EMAIL PROTECTED]>