[Zeitgeist] [Bug 722762] Re: zeitgeist-daemon using ~100% of CPU
Thanks for the logs everyone. To anyone else experiencing this problem: You don't have to comment here to register your problem; simply tick the affects me too in the top. We can all totally appreciate that you are burning CPU and we're working to resolve it asap. -- You received this bug notification because you are a member of Zeitgeist Extensions, which is the registrant for Zeitgeist Extensions. https://bugs.launchpad.net/bugs/722762 Title: zeitgeist-daemon using ~100% of CPU Status in Zeitgeist Framework: Triaged Status in Zeitgeist Extensions: New Status in “zeitgeist” package in Ubuntu: Confirmed Status in “zeitgeist-extensions” package in Ubuntu: Confirmed Bug description: I've tried restarting my computer, closing all applications, etc., but no matter what System Monitor tells me zeitgeist-daemon is using 96-100% of the CPU on my i5 Sony Vaio laptop. To manage notifications about this bug go to: https://bugs.launchpad.net/zeitgeist/+bug/722762/+subscriptions ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 722762] Re: zeitgeist-daemon using ~100% of CPU
If someone is seeing this please try running 'top' in a terminal and check whether the PID of zeitgeist-daemon keeps changing every so often... I have a hunch that the daemon may be restarting over and over again... -- You received this bug notification because you are a member of Zeitgeist Extensions, which is the registrant for Zeitgeist Extensions. https://bugs.launchpad.net/bugs/722762 Title: zeitgeist-daemon using ~100% of CPU Status in Zeitgeist Framework: Triaged Status in Zeitgeist Extensions: New Status in “zeitgeist” package in Ubuntu: Confirmed Status in “zeitgeist-extensions” package in Ubuntu: Confirmed Bug description: I've tried restarting my computer, closing all applications, etc., but no matter what System Monitor tells me zeitgeist-daemon is using 96-100% of the CPU on my i5 Sony Vaio laptop. To manage notifications about this bug go to: https://bugs.launchpad.net/zeitgeist/+bug/722762/+subscriptions ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 722762] Re: zeitgeist-daemon using ~100% of CPU
Ok, I actually have it myself here now - and I can attest that it's _not_ because Zeitgeist is restarting... -- You received this bug notification because you are a member of Zeitgeist Extensions, which is the registrant for Zeitgeist Extensions. https://bugs.launchpad.net/bugs/722762 Title: zeitgeist-daemon using ~100% of CPU Status in Zeitgeist Framework: Triaged Status in Zeitgeist Extensions: New Status in “zeitgeist” package in Ubuntu: Confirmed Status in “zeitgeist-extensions” package in Ubuntu: Confirmed Bug description: I've tried restarting my computer, closing all applications, etc., but no matter what System Monitor tells me zeitgeist-daemon is using 96-100% of the CPU on my i5 Sony Vaio laptop. To manage notifications about this bug go to: https://bugs.launchpad.net/zeitgeist/+bug/722762/+subscriptions ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 722762] Re: zeitgeist-daemon using ~100% of CPU
I found the root cause. It's purely a bug in the fts extension so marking as Invalid for Zeitgeist itself. ** Changed in: zeitgeist-extensions Importance: Undecided = Critical ** Changed in: zeitgeist-extensions Status: New = Triaged ** Changed in: zeitgeist-extensions Assignee: (unassigned) = Mikkel Kamstrup Erlandsen (kamstrup) ** Changed in: zeitgeist Status: Triaged = Invalid ** Changed in: zeitgeist (Ubuntu) Status: Confirmed = Invalid -- You received this bug notification because you are a member of Zeitgeist Extensions, which is the registrant for Zeitgeist Extensions. https://bugs.launchpad.net/bugs/722762 Title: zeitgeist-daemon using ~100% of CPU Status in Zeitgeist Framework: Invalid Status in Zeitgeist Extensions: Triaged Status in “zeitgeist” package in Ubuntu: Invalid Status in “zeitgeist-extensions” package in Ubuntu: Confirmed Bug description: I've tried restarting my computer, closing all applications, etc., but no matter what System Monitor tells me zeitgeist-daemon is using 96-100% of the CPU on my i5 Sony Vaio laptop. To manage notifications about this bug go to: https://bugs.launchpad.net/zeitgeist/+bug/722762/+subscriptions ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Branch ~zeitgeist/zeitgeist/bluebird] Rev 222: added new failing test case for disabled datasources
revno: 222
committer: Seif Lotfy s...@lotfy.com
branch nick: bluebird
timestamp: Mon 2011-09-05 10:46:11 +0200
message:
added new failing test case for disabled datasources
modified:
extensions/ds-registry.vala
test/dbus/dsr-test.py
--
lp:~zeitgeist/zeitgeist/bluebird
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird
Your team Zeitgeist Framework Team is subscribed to branch
lp:~zeitgeist/zeitgeist/bluebird.
To unsubscribe from this branch go to
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird/+edit-subscription
=== modified file 'extensions/ds-registry.vala'
--- extensions/ds-registry.vala 2011-09-04 18:35:10 +
+++ extensions/ds-registry.vala 2011-09-05 08:46:11 +
@@ -268,10 +268,12 @@
data_source.timestamp = Timestamp.now ();
dirty = false;
if (!data_source.enabled)
+{
for (int i=0; i events.length; i++)
{
events[i] = null;
}
+}
}
}
}
=== modified file 'test/dbus/dsr-test.py'
--- test/dbus/dsr-test.py 2011-08-31 00:30:01 +
+++ test/dbus/dsr-test.py 2011-09-05 08:46:11 +
@@ -164,6 +164,28 @@
ds = list(self.client._registry.GetDataSources())[0]
self.assertEquals(ds[DataSource.Enabled], True)
+ def testSetDataSourceDisabled(self):
+ # Insert a data-source -- it should be enabled by default
+ self.client._registry.RegisterDataSource(*self._ds1)
+ ds = list(self.client._registry.GetDataSources())[0]
+ self.assertEquals(ds[DataSource.Enabled], True)
+
+ # Now we can choose to disable it...
+ self.client._registry.SetDataSourceEnabled(self._ds1[0], False)
+ ds = list(self.client._registry.GetDataSources())[0]
+ self.assertEquals(ds[DataSource.Enabled], False)
+
+ ids = self.insertEventsAndWait([Event.new_for_values(
+ subject_manifestation = !stfu:File)])
+
+ self.assertEquals(ids[0], 0)
+
+ # And enable it again!
+ self.client._registry.SetDataSourceEnabled(self._ds1[0], True)
+ ds = list(self.client._registry.GetDataSources())[0]
+ self.assertEquals(ds[DataSource.Enabled], True)
+
+
def testGetDataSourceFromId(self):
# Insert a data-source -- and then retrieve it by id
self.client._registry.RegisterDataSource(*self._ds1)
___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 722762] Re: zeitgeist-daemon using ~100% of CPU
** Branch linked: lp:zeitgeist-extensions -- You received this bug notification because you are a member of Zeitgeist Extensions, which is the registrant for Zeitgeist Extensions. https://bugs.launchpad.net/bugs/722762 Title: zeitgeist-daemon using ~100% of CPU Status in Zeitgeist Framework: Invalid Status in Zeitgeist Extensions: Fix Released Status in “zeitgeist” package in Ubuntu: Invalid Status in “zeitgeist-extensions” package in Ubuntu: Confirmed Bug description: I've tried restarting my computer, closing all applications, etc., but no matter what System Monitor tells me zeitgeist-daemon is using 96-100% of the CPU on my i5 Sony Vaio laptop. To manage notifications about this bug go to: https://bugs.launchpad.net/zeitgeist/+bug/722762/+subscriptions ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 757512] Re: DatabaseError
*** This bug is a duplicate of bug 705944 *** https://bugs.launchpad.net/bugs/705944 ** This bug has been marked a duplicate of bug 705944 FTS index corruption -- You received this bug notification because you are a member of Zeitgeist Extensions, which is the registrant for Zeitgeist Extensions. https://bugs.launchpad.net/bugs/757512 Title: DatabaseError Status in Zeitgeist Extensions: New Bug description: While using Synapse I get this error, and I think it's ZG-only related :) Remote Exception invoking org.gnome.zeitgeist.Index.Search() on /org/gnome/zeitgeist/index/activity at name org.gnome.zeitgeist.Engine: org.freedesktop.DBus.Python.xapian.DatabaseError: Traceback (most recent call last): File /usr/lib/pymodules/python2.6/dbus/service.py, line 702, in _message_cb retval = candidate_method(self, *args, **keywords) File /usr/share/zeitgeist/_zeitgeist/engine/extensions/fts.py, line 123, in Search offset, count, result_type) File /usr/share/zeitgeist/_zeitgeist/engine/extensions/fts.py, line 255, in search hits = self._enquire.get_mset (offset, raw_maxhits) DatabaseError: Error reading block 4279174522: got end of file To manage notifications about this bug go to: https://bugs.launchpad.net/zeitgeist-extensions/+bug/757512/+subscriptions ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 614282] Re: fts extension is missing negation support
** Changed in: zeitgeist-extensions Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Zeitgeist Extensions, which is the registrant for Zeitgeist Extensions. https://bugs.launchpad.net/bugs/614282 Title: fts extension is missing negation support Status in Zeitgeist Extensions: Fix Released Bug description: As reported by Michal on irc today, the fts extension is missing negation support, it would be nice if we could add negation in queries. To manage notifications about this bug go to: https://bugs.launchpad.net/zeitgeist-extensions/+bug/614282/+subscriptions ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 722762] Re: zeitgeist-daemon using ~100% of CPU
This bug was fixed in the package zeitgeist-extensions - 0.0.11-0ubuntu1 --- zeitgeist-extensions (0.0.11-0ubuntu1) oneiric; urgency=low * New upstream release: - Fix zeitgeist-daemon using ~100% of CPU (LP: #722762) -- Didier Roche didro...@ubuntu.com Mon, 05 Sep 2011 10:53:29 +0200 ** Changed in: zeitgeist-extensions (Ubuntu) Status: Confirmed = Fix Released -- You received this bug notification because you are a member of Zeitgeist Extensions, which is the registrant for Zeitgeist Extensions. https://bugs.launchpad.net/bugs/722762 Title: zeitgeist-daemon using ~100% of CPU Status in Zeitgeist Framework: Invalid Status in Zeitgeist Extensions: Fix Released Status in “zeitgeist” package in Ubuntu: Invalid Status in “zeitgeist-extensions” package in Ubuntu: Fix Released Bug description: I've tried restarting my computer, closing all applications, etc., but no matter what System Monitor tells me zeitgeist-daemon is using 96-100% of the CPU on my i5 Sony Vaio laptop. To manage notifications about this bug go to: https://bugs.launchpad.net/zeitgeist/+bug/722762/+subscriptions ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 827420] Re: Unity dash file search returns relevant files and folders but not all as I expect.
** Also affects: ubuntu-translations Importance: Undecided Status: New ** Changed in: ubuntu-translations Status: New = Triaged ** Changed in: ubuntu-translations Importance: Undecided = Medium ** Changed in: ubuntu-translations Assignee: (unassigned) = Ubuntu Simplified Chinese Translators (ubuntu-l10n-zh-cn) -- You received this bug notification because you are a member of Zeitgeist Extensions, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/827420 Title: Unity dash file search returns relevant files and folders but not all as I expect. Status in Ubuntu Translations: Triaged Status in Unity: Invalid Status in Zeitgeist Framework: Invalid Status in Zeitgeist Extensions: Invalid Bug description: I created 1 new file named “通信传染” and 1 new folder named “通信传” on the Desktop. Searching for “通” in the 'dash' (Super + F) returns 0 match. I expect those 2 files should appear in the search result. Searching for “下载” in the 'dash' (Super + F) returns the “Downloads” folder as expected. Searching for “文件” for “Documents” returns the “Documents” folder and 2 other documents I just created. However, there is also “文” in the home folder and in File System name in Chinese but they are not shown in the search result. I think the home folder should be shown, I am not sure about the file system. Test results courtesy of samantha.jian-pie...@canonical.com To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-translations/+bug/827420/+subscriptions ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 716503] Re: FTS: can't get more than 132 results
No it does not, and I know because it doesn't use sql at all ;-) My guess is that it triggers this inside the zg engine by calling into some of the public api, like get_events() or something. ** Also affects: zeitgeist Importance: Undecided Status: New ** Changed in: zeitgeist-extensions Status: New = Invalid -- You received this bug notification because you are a member of Zeitgeist Extensions, which is the registrant for Zeitgeist Extensions. https://bugs.launchpad.net/bugs/716503 Title: FTS: can't get more than 132 results Status in Zeitgeist Framework: New Status in Zeitgeist Extensions: Invalid Bug description: The FTS extension uses SQLite's argument parsing, which limits the results to 132 distinct URIs. FTS should workaround this restriction like Zeitgeist itself already does. To manage notifications about this bug go to: https://bugs.launchpad.net/zeitgeist/+bug/716503/+subscriptions ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 827420] Re: Unity dash file search returns relevant files and folders but not all as I expect.
Thanks Brandon. So I think we can exonerate Zeitgeist now. ** Changed in: zeitgeist Status: New = Invalid ** Changed in: zeitgeist-extensions Status: New = Invalid -- You received this bug notification because you are a member of Zeitgeist Extensions, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/827420 Title: Unity dash file search returns relevant files and folders but not all as I expect. Status in Ubuntu Translations: Triaged Status in Unity: Invalid Status in Zeitgeist Framework: Invalid Status in Zeitgeist Extensions: Invalid Bug description: I created 1 new file named “通信传染” and 1 new folder named “通信传” on the Desktop. Searching for “通” in the 'dash' (Super + F) returns 0 match. I expect those 2 files should appear in the search result. Searching for “下载” in the 'dash' (Super + F) returns the “Downloads” folder as expected. Searching for “文件” for “Documents” returns the “Documents” folder and 2 other documents I just created. However, there is also “文” in the home folder and in File System name in Chinese but they are not shown in the search result. I think the home folder should be shown, I am not sure about the file system. Test results courtesy of samantha.jian-pie...@canonical.com To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-translations/+bug/827420/+subscriptions ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Branch ~zeitgeist/zeitgeist/bluebird] Rev 223: fixed datasource-registries failure to do the pre_insert
revno: 223
committer: Seif Lotfy s...@lotfy.com
branch nick: bluebird
timestamp: Mon 2011-09-05 11:53:08 +0200
message:
fixed datasource-registries failure to do the pre_insert
modified:
extensions/ds-registry.vala
test/dbus/dsr-test.py
--
lp:~zeitgeist/zeitgeist/bluebird
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird
Your team Zeitgeist Framework Team is subscribed to branch
lp:~zeitgeist/zeitgeist/bluebird.
To unsubscribe from this branch go to
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird/+edit-subscription
=== modified file 'extensions/ds-registry.vala'
--- extensions/ds-registry.vala 2011-09-05 08:46:11 +
+++ extensions/ds-registry.vala 2011-09-05 09:53:08 +
@@ -131,7 +131,7 @@
construct
{
sources = new HashTablestring, DataSource (str_hash, str_equal);
-
+running = new HashTablestring, GenericArrayBusName?(str_hash, str_equal);
// FIXME: load data sources
// this will be called after bus is acquired, so it shouldn't block
@@ -256,7 +256,7 @@
Datasource with unique ID: %s not found.printf (unique_id));
}
-public void pre_insert_events(GenericArrayEvent? events,
+public override void pre_insert_events(GenericArrayEvent? events,
BusName? sender)
{
foreach (string unique_id in running.get_keys())
=== modified file 'test/dbus/dsr-test.py'
--- test/dbus/dsr-test.py 2011-09-05 08:46:11 +
+++ test/dbus/dsr-test.py 2011-09-05 09:53:08 +
@@ -184,6 +184,11 @@
self.client._registry.SetDataSourceEnabled(self._ds1[0], True)
ds = list(self.client._registry.GetDataSources())[0]
self.assertEquals(ds[DataSource.Enabled], True)
+
+ ids = self.insertEventsAndWait([Event.new_for_values(
+ subject_manifestation = !stfu:File)])
+
+ self.assertEquals(ids[0], 1)
def testGetDataSourceFromId(self):
___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 617309] Re: fts can SIGSEGV ZG during reindex
revno: 67 fixes bug(s): https://launchpad.net/bugs/617309 committer: Mikkel Kamstrup Erlandsen mikkel.kamst...@gmail.com branch nick: MASTER timestamp: Mon 2011-09-05 11:51:19 +0200 message: Fix bug fts can SIGSEGV ZG during reindex. This was caused by searching while rebuilding the index. The Xapian API is not thread safe in any shape or form so protect all read and write access with a lock. ** Changed in: zeitgeist-extensions Status: Triaged = Fix Committed -- You received this bug notification because you are a member of Zeitgeist Extensions, which is the registrant for Zeitgeist Extensions. https://bugs.launchpad.net/bugs/617309 Title: fts can SIGSEGV ZG during reindex Status in Zeitgeist Extensions: Fix Committed Bug description: Any search query while FTS is reindexing the DB will cause a SIGSEGV. To manage notifications about this bug go to: https://bugs.launchpad.net/zeitgeist-extensions/+bug/617309/+subscriptions ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 705944] Re: Can't recover from FTS index corruption
** Branch linked: lp:zeitgeist-extensions -- You received this bug notification because you are a member of Zeitgeist Extensions, which is the registrant for Zeitgeist Extensions. https://bugs.launchpad.net/bugs/705944 Title: Can't recover from FTS index corruption Status in Synapse: Invalid Status in Zeitgeist Extensions: Fix Committed Bug description: The Zeitgeist FTS extension should be able to automatically recover from corrupted indexes by rebuilding the index from the Zeitgeist log. -- Original report - Hallo, since a few days synapse does not show any folders anymore - of course I made sure that the directory plugin is enabled. I also disabled it, restarted synapse and enabled it again. It still did not work. The config.json file seems to be proper, too. Starting synapse from commandline, I get the following output each time I press any letter: ** (synapse:26138): WARNING **: zeitgeist-plugin.vala:574: Zeitgeist search failed: Remote Exception invoking org.gnome.zeitgeist.Index.Search() on /org/gnome/zeitgeist/index/activity at name org.gnome.zeitgeist.Engine: org.freedesktop.DBus.Python.xapian.DatabaseCorruptError: Traceback (most recent call last): File /usr/lib/pymodules/python2.6/dbus/service.py, line 702, in _message_cb retval = candidate_method(self, *args, **keywords) File /usr/share/zeitgeist/_zeitgeist/engine/extensions/fts.py, line 123, in Search offset, count, result_type) File /usr/share/zeitgeist/_zeitgeist/engine/extensions/fts.py, line 253, in search self.QUERY_PARSER_FLAGS) DatabaseCorruptError: Data ran out unexpectedly when reading posting list. org.freedesktop.DBus.Python.xapian.DatabaseCorruptError Traceback%20%28most%20recent%20call%20last%29%3A%0A%20%20File%20%22%2Fusr%2Flib%2Fpymodules%2Fpython2.6%2Fdbus%2Fservice.py%22%2C%20line%20702%2C%20in%20_message_cb%0A%20%20%20%20retval%20%3D%20candidate_method%28self%2C%20%2Aargs%2C%20%2A%2Akeywords%29%0A%20%20File%20%22%2Fusr%2Fshare%2Fzeitgeist%2F_zeitgeist%2Fengine%2Fextensions%2Ffts.py%22%2C%20line%20123%2C%20in%20Search%0A%20%20%20%20offset%2C%20count%2C%20result_type%29%0A%20%20File%20%22%2Fusr%2Fshare%2Fzeitgeist%2F_zeitgeist%2Fengine%2Fextensions%2Ffts.py%22%2C%20line%20253%2C%20in%20search%0A%20%20%20%20self.QUERY_PARSER_FLAGS%29%0ADatabaseCorruptError%3A%20Data%20ran%20out%20unexpectedly%20when%20reading%20posting%20list.%0A ** (synapse:26138): DEBUG: zeitgeist-plugin.vala:580: ZG search took 19 ms SynapseHybridSearchPlugin found 0 extra uris (ZG returned 0) I've tested synapse 0.2.2.1, 0.2.2.2 from your download section and I also tested the recent version from branch. The folders I tried to find were ordinary folders within the home-partition (like Documents, Music, Desktop, Videos). Sincerely, Daniel To manage notifications about this bug go to: https://bugs.launchpad.net/synapse-project/+bug/705944/+subscriptions ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 705944] Re: Can't recover from FTS index corruption
** Changed in: zeitgeist-extensions Status: Triaged = Fix Committed -- You received this bug notification because you are a member of Zeitgeist Extensions, which is the registrant for Zeitgeist Extensions. https://bugs.launchpad.net/bugs/705944 Title: Can't recover from FTS index corruption Status in Synapse: Invalid Status in Zeitgeist Extensions: Fix Committed Bug description: The Zeitgeist FTS extension should be able to automatically recover from corrupted indexes by rebuilding the index from the Zeitgeist log. -- Original report - Hallo, since a few days synapse does not show any folders anymore - of course I made sure that the directory plugin is enabled. I also disabled it, restarted synapse and enabled it again. It still did not work. The config.json file seems to be proper, too. Starting synapse from commandline, I get the following output each time I press any letter: ** (synapse:26138): WARNING **: zeitgeist-plugin.vala:574: Zeitgeist search failed: Remote Exception invoking org.gnome.zeitgeist.Index.Search() on /org/gnome/zeitgeist/index/activity at name org.gnome.zeitgeist.Engine: org.freedesktop.DBus.Python.xapian.DatabaseCorruptError: Traceback (most recent call last): File /usr/lib/pymodules/python2.6/dbus/service.py, line 702, in _message_cb retval = candidate_method(self, *args, **keywords) File /usr/share/zeitgeist/_zeitgeist/engine/extensions/fts.py, line 123, in Search offset, count, result_type) File /usr/share/zeitgeist/_zeitgeist/engine/extensions/fts.py, line 253, in search self.QUERY_PARSER_FLAGS) DatabaseCorruptError: Data ran out unexpectedly when reading posting list. org.freedesktop.DBus.Python.xapian.DatabaseCorruptError Traceback%20%28most%20recent%20call%20last%29%3A%0A%20%20File%20%22%2Fusr%2Flib%2Fpymodules%2Fpython2.6%2Fdbus%2Fservice.py%22%2C%20line%20702%2C%20in%20_message_cb%0A%20%20%20%20retval%20%3D%20candidate_method%28self%2C%20%2Aargs%2C%20%2A%2Akeywords%29%0A%20%20File%20%22%2Fusr%2Fshare%2Fzeitgeist%2F_zeitgeist%2Fengine%2Fextensions%2Ffts.py%22%2C%20line%20123%2C%20in%20Search%0A%20%20%20%20offset%2C%20count%2C%20result_type%29%0A%20%20File%20%22%2Fusr%2Fshare%2Fzeitgeist%2F_zeitgeist%2Fengine%2Fextensions%2Ffts.py%22%2C%20line%20253%2C%20in%20search%0A%20%20%20%20self.QUERY_PARSER_FLAGS%29%0ADatabaseCorruptError%3A%20Data%20ran%20out%20unexpectedly%20when%20reading%20posting%20list.%0A ** (synapse:26138): DEBUG: zeitgeist-plugin.vala:580: ZG search took 19 ms SynapseHybridSearchPlugin found 0 extra uris (ZG returned 0) I've tested synapse 0.2.2.1, 0.2.2.2 from your download section and I also tested the recent version from branch. The folders I tried to find were ordinary folders within the home-partition (like Documents, Music, Desktop, Videos). Sincerely, Daniel To manage notifications about this bug go to: https://bugs.launchpad.net/synapse-project/+bug/705944/+subscriptions ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Branch ~zeitgeist/zeitgeist/bluebird] Rev 224: Fix up lots of warnings
revno: 224
committer: Michal Hruby michal@gmail.com
branch nick: bluebird
timestamp: Mon 2011-09-05 12:27:02 +0200
message:
Fix up lots of warnings
modified:
configure.ac
extensions/Makefile.am
extensions/blacklist.vala
extensions/ds-registry.vala
extra/ontology2code
src/Makefile.am
src/errors.vala
src/ontology.vala.in
src/utils.vala
src/zeitgeist-daemon.vala
--
lp:~zeitgeist/zeitgeist/bluebird
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird
Your team Zeitgeist Framework Team is subscribed to branch
lp:~zeitgeist/zeitgeist/bluebird.
To unsubscribe from this branch go to
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird/+edit-subscription
=== modified file 'configure.ac'
--- configure.ac 2011-08-21 14:17:16 +
+++ configure.ac 2011-09-05 10:27:02 +
@@ -11,6 +11,8 @@
AM_PROG_VALAC([0.12.1])
+AM_SILENT_RULES([yes])
+
AH_TEMPLATE([GETTEXT_PACKAGE], [Package name for gettext])
GETTEXT_PACKAGE=bluebird
AC_DEFINE_UNQUOTED(GETTEXT_PACKAGE, $GETTEXT_PACKAGE)
=== modified file 'extensions/Makefile.am'
--- extensions/Makefile.am 2011-08-31 11:02:37 +
+++ extensions/Makefile.am 2011-09-05 10:27:02 +
@@ -6,7 +6,8 @@
AM_CPPFLAGS = \
$(BLUEBIRD_CFLAGS) \
-include $(CONFIG_HEADER) \
- -I $(top_srcdir)/src
+ -I $(top_srcdir)/src \
+ -w \
$(NULL)
VALAFLAGS = \
=== modified file 'extensions/blacklist.vala'
--- extensions/blacklist.vala 2011-08-31 11:02:37 +
+++ extensions/blacklist.vala 2011-09-05 10:27:02 +
@@ -26,7 +26,7 @@
namespace Zeitgeist
{
[DBus (name = org.gnome.zeitgeist.Blacklist)]
-interface RemoteBlacklist: Object
+public interface RemoteBlacklist: Object
{
public abstract void add_template (string blacklist_id,
[DBus (signature = (asaasay))] Variant event_template)
@@ -59,18 +59,32 @@
// FIXME: load blacklist from file
// This will be called after bus is acquired, so it shouldn't block
-var connection = Bus.get_sync (BusType.SESSION, null);
-registration_id = connection.register_objectRemoteBlacklist (
-/org/gnome/zeitgeist/blacklist, this);
+try
+{
+var connection = Bus.get_sync (BusType.SESSION, null);
+registration_id = connection.register_objectRemoteBlacklist (
+/org/gnome/zeitgeist/blacklist, this);
+}
+catch (Error err)
+{
+warning (%s, err.message);
+}
}
public override void unload ()
{
-var connection = Bus.get_sync (BusType.SESSION, null);
-if (registration_id != 0)
-{
-connection.unregister_object (registration_id);
-registration_id = 0;
+try
+{
+var connection = Bus.get_sync (BusType.SESSION, null);
+if (registration_id != 0)
+{
+connection.unregister_object (registration_id);
+registration_id = 0;
+}
+}
+catch (Error err)
+{
+warning (%s, err.message);
}
debug (%s, this.ref_count = %u, Log.METHOD, this.ref_count);
@@ -114,10 +128,10 @@
[ModuleInit]
#if BUILTIN_EXTENSIONS
-Type blacklist_init (TypeModule module)
+public static Type blacklist_init (TypeModule module)
{
#else
-Type extension_register (TypeModule module)
+public static Type extension_register (TypeModule module)
{
#endif
return typeof (Blacklist);
=== modified file 'extensions/ds-registry.vala'
--- extensions/ds-registry.vala 2011-09-05 09:53:08 +
+++ extensions/ds-registry.vala 2011-09-05 10:27:02 +
@@ -24,7 +24,7 @@
namespace Zeitgeist
{
[DBus (name = org.gnome.zeitgeist.DataSourceRegistry)]
-interface RemoteRegistry: Object
+public interface RemoteRegistry: Object
{
[DBus (signature = a(sssa(asaasay)bxb))]
public abstract Variant get_data_sources () throws Error;
@@ -135,9 +135,18 @@
// FIXME: load data sources
// this will be called after bus is acquired, so it shouldn't block
-var connection = Bus.get_sync (BusType.SESSION, null);
-registration_id = connection.register_objectRemoteRegistry (
-/org/gnome/zeitgeist/data_source_registry, this);
+try
+{
+var connection = Bus.get_sync (BusType.SESSION, null);
+registration_id = connection.register_objectRemoteRegistry (
+/org/gnome/zeitgeist/data_source_registry, this);
+}
+catch (Error err)
+{
+warning (%s, err.message);
+}
+
+// FIXME: nothing changed, why is this here?
[Zeitgeist] [Bug 705944] Re: Can't recover from FTS index corruption
If you have at least r69 of the fts extension you can test this by killing zeitgeist, then running: $ head /dev/urandom ~/.local/share/zeitgeist/fts.index/postlist.DB And restarting Zeitgeist. This should cause a reindex. You can verify this by looking in ~/.cache/zeitgeist/daemon.log. You should see a line like: WARNING - zeitgeist.fts - Full text index corrupted: 'Expected block 37 to be level 1, not 49'. Rebuilding index. -- You received this bug notification because you are a member of Zeitgeist Extensions, which is the registrant for Zeitgeist Extensions. https://bugs.launchpad.net/bugs/705944 Title: Can't recover from FTS index corruption Status in Synapse: Invalid Status in Zeitgeist Extensions: Fix Committed Bug description: The Zeitgeist FTS extension should be able to automatically recover from corrupted indexes by rebuilding the index from the Zeitgeist log. -- Original report - Hallo, since a few days synapse does not show any folders anymore - of course I made sure that the directory plugin is enabled. I also disabled it, restarted synapse and enabled it again. It still did not work. The config.json file seems to be proper, too. Starting synapse from commandline, I get the following output each time I press any letter: ** (synapse:26138): WARNING **: zeitgeist-plugin.vala:574: Zeitgeist search failed: Remote Exception invoking org.gnome.zeitgeist.Index.Search() on /org/gnome/zeitgeist/index/activity at name org.gnome.zeitgeist.Engine: org.freedesktop.DBus.Python.xapian.DatabaseCorruptError: Traceback (most recent call last): File /usr/lib/pymodules/python2.6/dbus/service.py, line 702, in _message_cb retval = candidate_method(self, *args, **keywords) File /usr/share/zeitgeist/_zeitgeist/engine/extensions/fts.py, line 123, in Search offset, count, result_type) File /usr/share/zeitgeist/_zeitgeist/engine/extensions/fts.py, line 253, in search self.QUERY_PARSER_FLAGS) DatabaseCorruptError: Data ran out unexpectedly when reading posting list. org.freedesktop.DBus.Python.xapian.DatabaseCorruptError Traceback%20%28most%20recent%20call%20last%29%3A%0A%20%20File%20%22%2Fusr%2Flib%2Fpymodules%2Fpython2.6%2Fdbus%2Fservice.py%22%2C%20line%20702%2C%20in%20_message_cb%0A%20%20%20%20retval%20%3D%20candidate_method%28self%2C%20%2Aargs%2C%20%2A%2Akeywords%29%0A%20%20File%20%22%2Fusr%2Fshare%2Fzeitgeist%2F_zeitgeist%2Fengine%2Fextensions%2Ffts.py%22%2C%20line%20123%2C%20in%20Search%0A%20%20%20%20offset%2C%20count%2C%20result_type%29%0A%20%20File%20%22%2Fusr%2Fshare%2Fzeitgeist%2F_zeitgeist%2Fengine%2Fextensions%2Ffts.py%22%2C%20line%20253%2C%20in%20search%0A%20%20%20%20self.QUERY_PARSER_FLAGS%29%0ADatabaseCorruptError%3A%20Data%20ran%20out%20unexpectedly%20when%20reading%20posting%20list.%0A ** (synapse:26138): DEBUG: zeitgeist-plugin.vala:580: ZG search took 19 ms SynapseHybridSearchPlugin found 0 extra uris (ZG returned 0) I've tested synapse 0.2.2.1, 0.2.2.2 from your download section and I also tested the recent version from branch. The folders I tried to find were ordinary folders within the home-partition (like Documents, Music, Desktop, Videos). Sincerely, Daniel To manage notifications about this bug go to: https://bugs.launchpad.net/synapse-project/+bug/705944/+subscriptions ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 617309] Re: fts can SIGSEGV ZG during reindex
If you want to try and help verify that this bug is indeed fixed you need at least r67 of the fts extension. Then open d-feet and run the ForceReindex() method on the index - and quickly open Synapse or the Unity dash and type a search string. As this is a race it may or may not be elusive. So run the above a few times. -- You received this bug notification because you are a member of Zeitgeist Extensions, which is the registrant for Zeitgeist Extensions. https://bugs.launchpad.net/bugs/617309 Title: fts can SIGSEGV ZG during reindex Status in Zeitgeist Extensions: Fix Committed Bug description: Any search query while FTS is reindexing the DB will cause a SIGSEGV. To manage notifications about this bug go to: https://bugs.launchpad.net/zeitgeist-extensions/+bug/617309/+subscriptions ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 807950] Re: zeitgeist-daemon crashed with LookupError in remove_from_connection(): _zeitgeist.engine.remote.RemoteInterface at /org/gnome/zeitgeist/log/activity at 0xb74ee2cc is not
Since I installed the beta 1 with all it's updates, I had no crashes at all. -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. https://bugs.launchpad.net/bugs/807950 Title: zeitgeist-daemon crashed with LookupError in remove_from_connection(): _zeitgeist.engine.remote.RemoteInterface at /org/gnome/zeitgeist/log/activity at 0xb74ee2cc is not exported at a location matching (None,None) Status in Zeitgeist Framework: Fix Committed Status in “zeitgeist” package in Ubuntu: Triaged Status in “zeitgeist” source package in Oneiric: Triaged Bug description: I tried to start update of Ubuntu ProblemType: Crash DistroRelease: Ubuntu 11.10 Package: zeitgeist-core 0.8.1-1ubuntu1 ProcVersionSignature: Ubuntu 3.0-2.3-generic 3.0.0-rc4 Uname: Linux 3.0-2-generic i686 NonfreeKernelModules: nvidia Architecture: i386 Date: Sat Jul 9 15:52:11 2011 ExecutablePath: /usr/bin/zeitgeist-daemon InstallationMedia: Ubuntu 11.10 Oneiric Ocelot - Alpha i386 (20110704.1) InterpreterPath: /usr/bin/python2.7 PackageArchitecture: all ProcCmdline: /usr/bin/python /usr/bin/zeitgeist-daemon ProcEnviron: SHELL=/bin/bash LANG=ru_RU.UTF-8 PythonArgs: ['/usr/bin/zeitgeist-daemon'] SourcePackage: zeitgeist Title: zeitgeist-daemon crashed with LookupError in remove_from_connection(): _zeitgeist.engine.remote.RemoteInterface at /org/gnome/zeitgeist/log/activity at 0xb74ee2cc is not exported at a location matching (None,None) UpgradeStatus: No upgrade log present (probably fresh install) UserGroups: adm admin cdrom dialout lpadmin plugdev sambashare To manage notifications about this bug go to: https://bugs.launchpad.net/zeitgeist/+bug/807950/+subscriptions ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Branch ~zeitgeist/zeitgeist/bluebird] Rev 226: Cleanup superfluous spaces in ds-registry.vala.
revno: 226
committer: Siegfried-Angel Gevatter Pujals siegfr...@gevatter.com
branch nick: bluebird
timestamp: Mon 2011-09-05 13:16:46 +0200
message:
Cleanup superfluous spaces in ds-registry.vala.
modified:
extensions/ds-registry.vala
--
lp:~zeitgeist/zeitgeist/bluebird
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird
Your team Zeitgeist Framework Team is subscribed to branch
lp:~zeitgeist/zeitgeist/bluebird.
To unsubscribe from this branch go to
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird/+edit-subscription
=== modified file 'extensions/ds-registry.vala'
--- extensions/ds-registry.vala 2011-09-05 10:27:02 +
+++ extensions/ds-registry.vala 2011-09-05 11:16:46 +
@@ -189,7 +189,7 @@
return array.end ();
}
-private bool is_sender_known(BusName? sender,
+private bool is_sender_known(BusName? sender,
GenericArrayBusName? sender_array)
{
for (int i=0; isender_array.length; i++)
@@ -204,7 +204,7 @@
string description, Variant event_templates, BusName? sender)
{
debug (%s: %s, %s, %s, Log.METHOD, unique_id, name, description);
-
+
var sender_array = running.lookup(unique_id);
if (sender_array == null)
{
@@ -215,7 +215,7 @@
{
running.lookup(unique_id).add(sender);
}
-
+
unowned DataSource? ds = sources.lookup (unique_id);
if (ds != null)
{
@@ -259,7 +259,7 @@
warning (DataSource \%s\ wasn't registered!, unique_id);
}
}
-
+
public Variant get_data_source_from_id (string unique_id) throws Error
{
unowned DataSource? ds = sources.lookup (unique_id);
@@ -271,7 +271,7 @@
throw new EngineError.INVALID_KEY (
Datasource with unique ID: %s not found.printf (unique_id));
}
-
+
public override void pre_insert_events(GenericArrayEvent? events,
BusName? sender)
{
@@ -293,7 +293,7 @@
}
}
}
-
+
private bool write_to_disk()
{
//FIXME: Write to disk needs to be implemented
___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Branch ~zeitgeist/zeitgeist/bluebird] Rev 225: Downgrade datamodel assertions to exceptions so Zeitgeist won't
revno: 225
committer: Siegfried-Angel Gevatter Pujals siegfr...@gevatter.com
branch nick: bluebird
timestamp: Mon 2011-09-05 13:16:04 +0200
message:
Downgrade datamodel assertions to exceptions so Zeitgeist won't
crash every time a client sends it something broken.
modified:
src/datamodel.vala
src/errors.vala
--
lp:~zeitgeist/zeitgeist/bluebird
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird
Your team Zeitgeist Framework Team is subscribed to branch
lp:~zeitgeist/zeitgeist/bluebird.
To unsubscribe from this branch go to
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird/+edit-subscription
=== modified file 'src/datamodel.vala'
--- src/datamodel.vala 2011-08-30 13:57:04 +
+++ src/datamodel.vala 2011-09-05 11:16:04 +
@@ -22,6 +22,13 @@
namespace Zeitgeist
{
+private void assert_sig (bool condition, string error_message)
+throws EngineError
+{
+if (!condition)
+throw new EngineError.INVALID_SIGNATURE (error_message);
+}
+
namespace Timestamp
{
public static int64 now ()
@@ -67,8 +74,10 @@
}
public TimeRange.from_variant (Variant variant)
+throws EngineError
{
-assert (variant.get_type_string () == (xx));
+assert_sig (variant.get_type_string () == (xx),
+expected (xx));
int64 start_msec = 0;
int64 end_msec = 0;
@@ -280,18 +289,18 @@
subjects.add (subject);
}
-public Event.from_variant (Variant event_variant) { // (asaasay)
-assert (event_variant.get_type_string () == (asaasay));
+public Event.from_variant (Variant event_variant) throws EngineError {
+assert_sig (event_variant.get_type_string () == (asaasay),
+expected (asaasay));
VariantIter iter = event_variant.iterator();
-assert (iter.n_children() == 3);
VariantIter event_array = iter.next_value().iterator();
VariantIter subjects_array = iter.next_value().iterator();
Variant payload_variant = iter.next_value ();
var event_props = event_array.n_children ();
-assert (event_props = 5);
+assert_sig (event_props = 5, expected event_props = 5);
id = (uint32) uint64.parse (event_array.next_value().get_string ());
var str_timestamp = event_array.next_value().get_string ();
if (str_timestamp == )
@@ -469,10 +478,12 @@
{
public static GenericArrayEvent from_variant (Variant vevents)
+throws EngineError
{
GenericArrayEvent events = new GenericArrayEvent ();
-assert (vevents.get_type_string () == a(asaasay));
+assert_sig (vevents.get_type_string () == a(asaasay),
+expected a(asaasay));
foreach (Variant event in vevents)
{
@@ -528,11 +539,12 @@
public string current_uri { get; set; }
public Subject.from_variant (Variant subject_variant)
+throws EngineError
{
VariantIter iter = subject_variant.iterator();
var subject_props = iter.n_children ();
-assert (subject_props = 7);
+assert_sig (subject_props = 7, expected subject_props = 7);
uri = iter.next_value().get_string ();
interpretation = iter.next_value().get_string ();
manifestation = iter.next_value().get_string ();
=== modified file 'src/errors.vala'
--- src/errors.vala 2011-09-05 10:27:02 +
+++ src/errors.vala 2011-09-05 11:16:04 +
@@ -26,6 +26,7 @@
DATABASE_ERROR,
INVALID_ARGUMENT,
INVALID_KEY,
+INVALID_SIGNATURE, // FIXME: change from EngineError to sth. + public
}
// vala doesn't include proper headers, this fixes it
___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Branch ~zeitgeist/zeitgeist/bluebird] Rev 227: Revert some of the signature check asserts, they are supposed to be
revno: 227
committer: Siegfried-Angel Gevatter Pujals siegfr...@gevatter.com
branch nick: bluebird
timestamp: Mon 2011-09-05 13:49:45 +0200
message:
Revert some of the signature check asserts, they are supposed to be
checked by D-Bus itself and so shouldn't be a problem.
modified:
extensions/blacklist.vala
extensions/ds-registry.vala
src/datamodel.vala
--
lp:~zeitgeist/zeitgeist/bluebird
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird
Your team Zeitgeist Framework Team is subscribed to branch
lp:~zeitgeist/zeitgeist/bluebird.
To unsubscribe from this branch go to
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird/+edit-subscription
=== modified file 'extensions/blacklist.vala'
--- extensions/blacklist.vala 2011-09-05 10:27:02 +
+++ extensions/blacklist.vala 2011-09-05 11:49:45 +
@@ -95,33 +95,63 @@
// FIXME: write to file.
}
-public GenericArrayEvent? pre_insert_events (
-GenericArrayEvent? events, BusName sender)
+public override void pre_insert_events (GenericArrayEvent? events,
+BusName? sender)
{
// FIXME: do template matching...
// for event in events:
// for tmpl in blacklist:
// if event.matches_template(tmpl): event = null
-return events;
}
public void add_template (string blacklist_id, Variant event_template)
+throws EngineError
{
Event template = new Event.from_variant (event_template);
blacklist.insert (blacklist_id, template);
+debug (Added blacklist template: %s, blacklist_id);
+// FIXME: signals...
flush ();
}
public void remove_template (string blacklist_id)
{
Event template = blacklist.lookup (blacklist_id);
-blacklist.remove (blacklist_id);
+if (blacklist.remove (blacklist_id))
+debug (Removed blacklist template: %s, blacklist_id);
+else
+debug (Blacklist template \%s\ not found., blacklist_id);
+// FIXME: signals...
flush ();
}
+private Variant blacklist_template_to_variant (string blacklist_id,
+Event event_template)
+{
+var vb = new VariantBuilder (new VariantType (s(asaasay)));
+vb.add (s, blacklist_id);
+vb.add_value (event_template.to_variant ());
+return vb.end ();
+}
+
public Variant get_templates ()
{
-return null; //blacklist;
+var vb = new VariantBuilder (new VariantType (a{s(asaasay)}));
+{
+var iter = HashTableIterstring, Event (blacklist);
+string blacklist_id;
+Event event_template;
+vb.open (new VariantType ({s(asaasay)}));
+while (iter.next (out blacklist_id, out event_template))
+{
+vb.open (new VariantType (s(asaasay)));
+vb.add_value (blacklist_template_to_variant (
+blacklist_id, event_template));
+vb.close ();
+}
+vb.close ();
+}
+return vb.end ();
}
}
=== modified file 'extensions/ds-registry.vala'
--- extensions/ds-registry.vala 2011-09-05 11:16:46 +
+++ extensions/ds-registry.vala 2011-09-05 11:49:45 +
@@ -68,7 +68,7 @@
event_templates: templates);
}
-public DataSource.from_variant (Variant variant)
+public DataSource.from_variant (Variant variant) throws EngineError
{
// we expect (sssa(asaasay)bxb)
warn_if_fail (variant.get_type_string () == (sssa(asaasay)bxb)
@@ -202,6 +202,7 @@
public bool register_data_source (string unique_id, string name,
string description, Variant event_templates, BusName? sender)
+throws EngineError
{
debug (%s: %s, %s, %s, Log.METHOD, unique_id, name, description);
=== modified file 'src/datamodel.vala'
--- src/datamodel.vala 2011-09-05 11:16:04 +
+++ src/datamodel.vala 2011-09-05 11:49:45 +
@@ -74,10 +74,8 @@
}
public TimeRange.from_variant (Variant variant)
-throws EngineError
{
-assert_sig (variant.get_type_string () == (xx),
-expected (xx));
+assert (variant.get_type_string () == (xx));
int64 start_msec = 0;
int64 end_msec = 0;
@@ -290,8 +288,7 @@
}
public Event.from_variant (Variant event_variant) throws EngineError {
-assert_sig (event_variant.get_type_string () == (asaasay),
-expected (asaasay));
+assert (event_variant.get_type_string ()
[Zeitgeist] [Branch ~zeitgeist/zeitgeist/bluebird] 1 revision removed
1 revision was removed from the branch. -- lp:~zeitgeist/zeitgeist/bluebird https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird Your team Zeitgeist Framework Team is subscribed to branch lp:~zeitgeist/zeitgeist/bluebird. To unsubscribe from this branch go to https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird/+edit-subscription ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Branch ~zeitgeist/zeitgeist/bluebird] Rev 227: Revert several signature checks to normal assert since they're supposed to
revno: 227
committer: Siegfried-Angel Gevatter Pujals siegfr...@gevatter.com
branch nick: bluebird
timestamp: Mon 2011-09-05 13:59:07 +0200
message:
Revert several signature checks to normal assert since they're supposed to
be checked by D-Bus anyway.
modified:
src/datamodel.vala
--
lp:~zeitgeist/zeitgeist/bluebird
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird
Your team Zeitgeist Framework Team is subscribed to branch
lp:~zeitgeist/zeitgeist/bluebird.
To unsubscribe from this branch go to
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird/+edit-subscription
=== modified file 'src/datamodel.vala'
--- src/datamodel.vala 2011-09-05 11:16:04 +
+++ src/datamodel.vala 2011-09-05 11:59:07 +
@@ -74,10 +74,8 @@
}
public TimeRange.from_variant (Variant variant)
-throws EngineError
{
-assert_sig (variant.get_type_string () == (xx),
-expected (xx));
+assert (variant.get_type_string () == (xx));
int64 start_msec = 0;
int64 end_msec = 0;
@@ -290,8 +288,7 @@
}
public Event.from_variant (Variant event_variant) throws EngineError {
-assert_sig (event_variant.get_type_string () == (asaasay),
-expected (asaasay));
+assert (event_variant.get_type_string () == (asaasay));
VariantIter iter = event_variant.iterator();
@@ -478,12 +475,10 @@
{
public static GenericArrayEvent from_variant (Variant vevents)
-throws EngineError
{
GenericArrayEvent events = new GenericArrayEvent ();
-assert_sig (vevents.get_type_string () == a(asaasay),
-expected a(asaasay));
+assert (vevents.get_type_string () == a(asaasay));
foreach (Variant event in vevents)
{
___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Merge] lp:~kamstrup/zeitgeist/network-manager-state-fix into lp:zeitgeist
Mikkel Kamstrup Erlandsen has proposed merging lp:~kamstrup/zeitgeist/network-manager-state-fix into lp:zeitgeist. Requested reviews: Zeitgeist Framework Team (zeitgeist) Related bugs: Bug #841764 in Zeitgeist Framework: Storage monitor for networkmanager broken with NM = 0.9 https://bugs.launchpad.net/zeitgeist/+bug/841764 For more details, see: https://code.launchpad.net/~kamstrup/zeitgeist/network-manager-state-fix/+merge/74089 See linked bug. Updates to be compatible with NM API version 0.9 and =0.9 -- https://code.launchpad.net/~kamstrup/zeitgeist/network-manager-state-fix/+merge/74089 Your team Zeitgeist Framework Team is requested to review the proposed merge of lp:~kamstrup/zeitgeist/network-manager-state-fix into lp:zeitgeist. === modified file '_zeitgeist/engine/extensions/storagemonitor.py' --- _zeitgeist/engine/extensions/storagemonitor.py 2011-03-11 14:18:47 + +++ _zeitgeist/engine/extensions/storagemonitor.py 2011-09-05 12:13:00 + @@ -303,11 +303,9 @@ NM_IFACE = org.freedesktop.NetworkManager NM_OBJECT_PATH = /org/freedesktop/NetworkManager - NM_STATE_UNKNOWN = 0 - NM_STATE_ASLEEP = 1 - NM_STATE_CONNECTING = 2 - NM_STATE_CONNECTED = 3 - NM_STATE_DISCONNECTED = 4 + # NM 0.9 broke API so we have to check for two possible values for the state + NM_STATE_CONNECTED_PRE_09 = 3 + NM_STATE_CONNECTED_POST_09 = 70 def __init__ (self, on_network_up, on_network_down): log.debug(Creating NetworkManager network monitor) @@ -335,7 +333,7 @@ def _on_state_changed(self, state): log.debug(NetworkManager network state: %s % state) - if state == NMNetworkMonitor.NM_STATE_CONNECTED: + if state == NMNetworkMonitor.NM_STATE_CONNECTED_PRE_09 or state == NMNetworkMonitor.NM_STATE_CONNECTED_POST_09: self._up () else: self._down() ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 841764] [NEW] Storage monitor for networkmanager broken with NM = 0.9
Public bug reported: The storage device monitoring is broken for NetworkManager = 0.9 since the latest version of NM broke API. The result is that the 'net' storage id will always be marked as unavailable. ** Affects: zeitgeist Importance: Undecided Status: New -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. https://bugs.launchpad.net/bugs/841764 Title: Storage monitor for networkmanager broken with NM = 0.9 Status in Zeitgeist Framework: New Bug description: The storage device monitoring is broken for NetworkManager = 0.9 since the latest version of NM broke API. The result is that the 'net' storage id will always be marked as unavailable. To manage notifications about this bug go to: https://bugs.launchpad.net/zeitgeist/+bug/841764/+subscriptions ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Branch ~zeitgeist/zeitgeist/bluebird] 3 revisions removed
3 revisions were removed from the branch. -- lp:~zeitgeist/zeitgeist/bluebird https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird Your team Zeitgeist Framework Team is subscribed to branch lp:~zeitgeist/zeitgeist/bluebird. To unsubscribe from this branch go to https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird/+edit-subscription ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Branch ~zeitgeist/zeitgeist/bluebird] Rev 225: Clean up superfluous whitespace in ds-registry.vala.
revno: 225
committer: Siegfried-Angel Gevatter Pujals siegfr...@gevatter.com
branch nick: bluebird
timestamp: Mon 2011-09-05 14:19:04 +0200
message:
Clean up superfluous whitespace in ds-registry.vala.
modified:
extensions/ds-registry.vala
--
lp:~zeitgeist/zeitgeist/bluebird
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird
Your team Zeitgeist Framework Team is subscribed to branch
lp:~zeitgeist/zeitgeist/bluebird.
To unsubscribe from this branch go to
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird/+edit-subscription
=== modified file 'extensions/ds-registry.vala'
--- extensions/ds-registry.vala 2011-09-05 10:27:02 +
+++ extensions/ds-registry.vala 2011-09-05 12:19:04 +
@@ -189,7 +189,7 @@
return array.end ();
}
-private bool is_sender_known(BusName? sender,
+private bool is_sender_known(BusName? sender,
GenericArrayBusName? sender_array)
{
for (int i=0; isender_array.length; i++)
@@ -204,7 +204,7 @@
string description, Variant event_templates, BusName? sender)
{
debug (%s: %s, %s, %s, Log.METHOD, unique_id, name, description);
-
+
var sender_array = running.lookup(unique_id);
if (sender_array == null)
{
@@ -215,7 +215,7 @@
{
running.lookup(unique_id).add(sender);
}
-
+
unowned DataSource? ds = sources.lookup (unique_id);
if (ds != null)
{
@@ -259,7 +259,7 @@
warning (DataSource \%s\ wasn't registered!, unique_id);
}
}
-
+
public Variant get_data_source_from_id (string unique_id) throws Error
{
unowned DataSource? ds = sources.lookup (unique_id);
@@ -271,7 +271,7 @@
throw new EngineError.INVALID_KEY (
Datasource with unique ID: %s not found.printf (unique_id));
}
-
+
public override void pre_insert_events(GenericArrayEvent? events,
BusName? sender)
{
@@ -293,7 +293,7 @@
}
}
}
-
+
private bool write_to_disk()
{
//FIXME: Write to disk needs to be implemented
___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/bluebird-sig-crash into lp:~zeitgeist/zeitgeist/bluebird
Siegfried Gevatter has proposed merging
lp:~zeitgeist/zeitgeist/bluebird-sig-crash into
lp:~zeitgeist/zeitgeist/bluebird.
Requested reviews:
Zeitgeist Framework Team (zeitgeist)
For more details, see:
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird-sig-crash/+merge/74091
So, how will we do this?
(Consider this merge proposal a cheap blueprint.)
--
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird-sig-crash/+merge/74091
Your team Zeitgeist Framework Team is requested to review the proposed merge of
lp:~zeitgeist/zeitgeist/bluebird-sig-crash into
lp:~zeitgeist/zeitgeist/bluebird.
=== modified file 'src/datamodel.vala'
--- src/datamodel.vala 2011-08-30 13:57:04 +
+++ src/datamodel.vala 2011-09-05 12:23:42 +
@@ -22,6 +22,13 @@
namespace Zeitgeist
{
+private void assert_sig (bool condition, string error_message)
+throws EngineError
+{
+if (!condition)
+throw new EngineError.INVALID_SIGNATURE (error_message);
+}
+
namespace Timestamp
{
public static int64 now ()
@@ -280,18 +287,17 @@
subjects.add (subject);
}
-public Event.from_variant (Variant event_variant) { // (asaasay)
+public Event.from_variant (Variant event_variant) throws EngineError {
assert (event_variant.get_type_string () == (asaasay));
VariantIter iter = event_variant.iterator();
-assert (iter.n_children() == 3);
VariantIter event_array = iter.next_value().iterator();
VariantIter subjects_array = iter.next_value().iterator();
Variant payload_variant = iter.next_value ();
var event_props = event_array.n_children ();
-assert (event_props = 5);
+warn_if_fail (event_props = 5);
id = (uint32) uint64.parse (event_array.next_value().get_string ());
var str_timestamp = event_array.next_value().get_string ();
if (str_timestamp == )
@@ -528,11 +534,12 @@
public string current_uri { get; set; }
public Subject.from_variant (Variant subject_variant)
+throws EngineError
{
VariantIter iter = subject_variant.iterator();
var subject_props = iter.n_children ();
-assert (subject_props = 7);
+warn_if_fail (subject_props = 7);
uri = iter.next_value().get_string ();
interpretation = iter.next_value().get_string ();
manifestation = iter.next_value().get_string ();
=== modified file 'src/errors.vala'
--- src/errors.vala 2011-09-05 10:27:02 +
+++ src/errors.vala 2011-09-05 12:23:42 +
@@ -26,6 +26,7 @@
DATABASE_ERROR,
INVALID_ARGUMENT,
INVALID_KEY,
+INVALID_SIGNATURE, // FIXME: change from EngineError to sth. + public
}
// vala doesn't include proper headers, this fixes it
___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 841764] Re: Storage monitor for networkmanager broken with NM = 0.9
** Branch linked: lp:~kamstrup/zeitgeist/network-manager-state-fix -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. https://bugs.launchpad.net/bugs/841764 Title: Storage monitor for networkmanager broken with NM = 0.9 Status in Zeitgeist Framework: New Bug description: The storage device monitoring is broken for NetworkManager = 0.9 since the latest version of NM broke API. The result is that the 'net' storage id will always be marked as unavailable. To manage notifications about this bug go to: https://bugs.launchpad.net/zeitgeist/+bug/841764/+subscriptions ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 841764] Re: Storage monitor for networkmanager broken with NM = 0.9
revno: 1802 [merge] committer: Mikkel Kamstrup Erlandsen mikkel.kamst...@gmail.com branch nick: MASTER timestamp: Mon 2011-09-05 14:21:57 +0200 message: Merge lp:~kamstrup/zeitgeist/network-manager-state-fix. Fixes it so we support both 0.9 and = 0.9 versions of the NetworkManager API ** Changed in: zeitgeist Importance: Undecided = Low ** Changed in: zeitgeist Status: New = Fix Committed ** Changed in: zeitgeist Assignee: (unassigned) = Mikkel Kamstrup Erlandsen (kamstrup) -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. https://bugs.launchpad.net/bugs/841764 Title: Storage monitor for networkmanager broken with NM = 0.9 Status in Zeitgeist Framework: Fix Committed Bug description: The storage device monitoring is broken for NetworkManager = 0.9 since the latest version of NM broke API. The result is that the 'net' storage id will always be marked as unavailable. To manage notifications about this bug go to: https://bugs.launchpad.net/zeitgeist/+bug/841764/+subscriptions ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 841764] Re: Storage monitor for networkmanager broken with NM = 0.9
** Changed in: zeitgeist Milestone: None = 0.8.2 -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. https://bugs.launchpad.net/bugs/841764 Title: Storage monitor for networkmanager broken with NM = 0.9 Status in Zeitgeist Framework: Fix Committed Bug description: The storage device monitoring is broken for NetworkManager = 0.9 since the latest version of NM broke API. The result is that the 'net' storage id will always be marked as unavailable. To manage notifications about this bug go to: https://bugs.launchpad.net/zeitgeist/+bug/841764/+subscriptions ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Branch ~zeitgeist/zeitgeist/bluebird] Rev 226: Blacklist: implement D-Bus methods.
revno: 226
committer: Siegfried-Angel Gevatter Pujals siegfr...@gevatter.com
branch nick: bluebird
timestamp: Mon 2011-09-05 15:09:08 +0200
message:
Blacklist: implement D-Bus methods.
added:
test/dbus/blacklist-test.py
modified:
extensions/blacklist.vala
test/dbus/dsr-test.py
test/dbus/testutils.py
--
lp:~zeitgeist/zeitgeist/bluebird
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird
Your team Zeitgeist Framework Team is subscribed to branch
lp:~zeitgeist/zeitgeist/bluebird.
To unsubscribe from this branch go to
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird/+edit-subscription
=== modified file 'extensions/blacklist.vala'
--- extensions/blacklist.vala 2011-09-05 10:27:02 +
+++ extensions/blacklist.vala 2011-09-05 13:09:08 +
@@ -28,17 +28,17 @@
[DBus (name = org.gnome.zeitgeist.Blacklist)]
public interface RemoteBlacklist: Object
{
-public abstract void add_template (string blacklist_id,
+public abstract void add_template (string template_id,
[DBus (signature = (asaasay))] Variant event_template)
throws Error;
[DBus (signature = a{s(asaasay)})]
public abstract Variant get_templates () throws Error;
-public abstract void remove_template (string blacklist_id)
+public abstract void remove_template (string template_id)
throws Error;
-public signal void template_added (string blacklist_id,
+public signal void template_added (string template_id,
[DBus (signature = s(asaasay))] Variant event_template);
-public signal void template_removed (string blacklist_id,
+public signal void template_removed (string template_id,
[DBus (signature = s(asassay))] Variant event_template);
}
@@ -95,33 +95,52 @@
// FIXME: write to file.
}
-public GenericArrayEvent? pre_insert_events (
-GenericArrayEvent? events, BusName sender)
+public override void pre_insert_events (GenericArrayEvent? events,
+BusName? sender)
{
// FIXME: do template matching...
// for event in events:
// for tmpl in blacklist:
// if event.matches_template(tmpl): event = null
-return events;
}
-public void add_template (string blacklist_id, Variant event_template)
+public void add_template (string template_id, Variant event_template)
+throws EngineError
{
Event template = new Event.from_variant (event_template);
-blacklist.insert (blacklist_id, template);
+blacklist.insert (template_id, template);
+debug (Added blacklist template: %s, template_id);
+template_added (template_id, event_template);
flush ();
}
-public void remove_template (string blacklist_id)
+public void remove_template (string template_id)
{
-Event template = blacklist.lookup (blacklist_id);
-blacklist.remove (blacklist_id);
+Event event_template = blacklist.lookup (template_id);
+if (blacklist.remove (template_id))
+debug (Removed blacklist template: %s, template_id);
+else
+debug (Blacklist template \%s\ not found., template_id);
+template_removed (template_id, event_template.to_variant ());
flush ();
}
public Variant get_templates ()
{
-return null; //blacklist;
+var vb = new VariantBuilder (new VariantType (a{s(asaasay)}));
+{
+var iter = HashTableIterstring, Event (blacklist);
+string template_id;
+Event event_template;
+while (iter.next (out template_id, out event_template))
+{
+vb.open (new VariantType ({s(asaasay)}));
+vb.add (s, template_id);
+vb.add_value (event_template.to_variant ());
+vb.close ();
+}
+}
+return vb.end ();
}
}
=== added file 'test/dbus/blacklist-test.py'
--- test/dbus/blacklist-test.py 1970-01-01 00:00:00 +
+++ test/dbus/blacklist-test.py 2011-09-05 13:09:08 +
@@ -0,0 +1,151 @@
+#! /usr/bin/python
+# -.- coding: utf-8 -.-
+
+# remote-test.py
+#
+# Copyright © 2009 Mikkel Kamstrup Erlandsen mikkel.kamst...@gmail.com
+# Copyright © 2010 Markus Korn thek...@gmx.de
+# Copyright © 2010 Siegfried-Angel Gevatter Pujals siegfr...@gevatter.com
+# Copyright © 2011 Manish Sinha manishsi...@ubuntu.com
+# Copyright © 2011 Collabora Ltd.
+# By Siegfried-Angel Gevatter Pujals siegfr...@gevatter.com
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of
[Zeitgeist] [Bug 807950] Re: zeitgeist-daemon crashed with LookupError in remove_from_connection(): _zeitgeist.engine.remote.RemoteInterface at /org/gnome/zeitgeist/log/activity at 0xb74ee2cc is not
Here with fully updated system I continue to receive this bug alert everytime I log in. -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. https://bugs.launchpad.net/bugs/807950 Title: zeitgeist-daemon crashed with LookupError in remove_from_connection(): _zeitgeist.engine.remote.RemoteInterface at /org/gnome/zeitgeist/log/activity at 0xb74ee2cc is not exported at a location matching (None,None) Status in Zeitgeist Framework: Fix Committed Status in “zeitgeist” package in Ubuntu: Triaged Status in “zeitgeist” source package in Oneiric: Triaged Bug description: I tried to start update of Ubuntu ProblemType: Crash DistroRelease: Ubuntu 11.10 Package: zeitgeist-core 0.8.1-1ubuntu1 ProcVersionSignature: Ubuntu 3.0-2.3-generic 3.0.0-rc4 Uname: Linux 3.0-2-generic i686 NonfreeKernelModules: nvidia Architecture: i386 Date: Sat Jul 9 15:52:11 2011 ExecutablePath: /usr/bin/zeitgeist-daemon InstallationMedia: Ubuntu 11.10 Oneiric Ocelot - Alpha i386 (20110704.1) InterpreterPath: /usr/bin/python2.7 PackageArchitecture: all ProcCmdline: /usr/bin/python /usr/bin/zeitgeist-daemon ProcEnviron: SHELL=/bin/bash LANG=ru_RU.UTF-8 PythonArgs: ['/usr/bin/zeitgeist-daemon'] SourcePackage: zeitgeist Title: zeitgeist-daemon crashed with LookupError in remove_from_connection(): _zeitgeist.engine.remote.RemoteInterface at /org/gnome/zeitgeist/log/activity at 0xb74ee2cc is not exported at a location matching (None,None) UpgradeStatus: No upgrade log present (probably fresh install) UserGroups: adm admin cdrom dialout lpadmin plugdev sambashare To manage notifications about this bug go to: https://bugs.launchpad.net/zeitgeist/+bug/807950/+subscriptions ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 722762] Re: zeitgeist-daemon using ~100% of CPU
Thanks, that looks like it has fixed the problem for me. :) -- You received this bug notification because you are a member of Zeitgeist Extensions, which is the registrant for Zeitgeist Extensions. https://bugs.launchpad.net/bugs/722762 Title: zeitgeist-daemon using ~100% of CPU Status in Zeitgeist Framework: Invalid Status in Zeitgeist Extensions: Fix Released Status in “zeitgeist” package in Ubuntu: Invalid Status in “zeitgeist-extensions” package in Ubuntu: Fix Released Bug description: I've tried restarting my computer, closing all applications, etc., but no matter what System Monitor tells me zeitgeist-daemon is using 96-100% of the CPU on my i5 Sony Vaio laptop. To manage notifications about this bug go to: https://bugs.launchpad.net/zeitgeist/+bug/722762/+subscriptions ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 722762] Re: zeitgeist-daemon using ~100% of CPU
Same here, seems that is fixed. -- You received this bug notification because you are a member of Zeitgeist Extensions, which is the registrant for Zeitgeist Extensions. https://bugs.launchpad.net/bugs/722762 Title: zeitgeist-daemon using ~100% of CPU Status in Zeitgeist Framework: Invalid Status in Zeitgeist Extensions: Fix Released Status in “zeitgeist” package in Ubuntu: Invalid Status in “zeitgeist-extensions” package in Ubuntu: Fix Released Bug description: I've tried restarting my computer, closing all applications, etc., but no matter what System Monitor tells me zeitgeist-daemon is using 96-100% of the CPU on my i5 Sony Vaio laptop. To manage notifications about this bug go to: https://bugs.launchpad.net/zeitgeist/+bug/722762/+subscriptions ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Branch ~zeitgeist/zeitgeist/bluebird] Rev 227: Pass Engine instance to extensions
revno: 227
committer: Michal Hruby michal@gmail.com
branch nick: bluebird
timestamp: Mon 2011-09-05 18:16:36 +0200
message:
Pass Engine instance to extensions
modified:
src/engine.vala
src/extension-collection.vala
src/extension.vala
--
lp:~zeitgeist/zeitgeist/bluebird
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird
Your team Zeitgeist Framework Team is subscribed to branch
lp:~zeitgeist/zeitgeist/bluebird.
To unsubscribe from this branch go to
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird/+edit-subscription
=== modified file 'src/engine.vala'
--- src/engine.vala 2011-09-02 17:46:22 +
+++ src/engine.vala 2011-09-05 16:16:36 +
@@ -34,7 +34,7 @@
public class Engine : Object
{
-private Zeitgeist.SQLite.ZeitgeistDatabase database;
+public Zeitgeist.SQLite.ZeitgeistDatabase database { get; private set; }
private ExtensionCollection extension_collection;
private unowned Sqlite.Database db;
@@ -47,16 +47,16 @@
public Engine () throws EngineError
{
-database = new Zeitgeist.SQLite.ZeitgeistDatabase();
+database = new Zeitgeist.SQLite.ZeitgeistDatabase ();
db = database.database;
-last_id = database.get_last_id();
-
-interpretations_table = new TableLookup(database, interpretation);
-manifestations_table = new TableLookup(database, manifestation);
-mimetypes_table = new TableLookup(database, mimetype);
-actors_table = new TableLookup(database, actor);
-
-extension_collection = new ExtensionCollection ();
+last_id = database.get_last_id ();
+
+interpretations_table = new TableLookup (database, interpretation);
+manifestations_table = new TableLookup (database, manifestation);
+mimetypes_table = new TableLookup (database, mimetype);
+actors_table = new TableLookup (database, actor);
+
+extension_collection = new ExtensionCollection (this);
}
public string[] get_extension_names ()
=== modified file 'src/extension-collection.vala'
--- src/extension-collection.vala 2011-09-02 17:46:22 +
+++ src/extension-collection.vala 2011-09-05 16:16:36 +
@@ -23,9 +23,11 @@
{
private GenericArrayExtension extensions;
-public ExtensionCollection ()
+public unowned Engine engine { get; construct; }
+
+public ExtensionCollection (Engine engine)
{
-Object ();
+Object (engine: engine);
}
~ExtensionCollection ()
@@ -49,7 +51,7 @@
foreach (var func in builtins)
{
ExtensionLoader builtin = new BuiltinExtension (func);
-extension = builtin.create_instance ();
+extension = builtin.create_instance (engine);
if (extension != null) extensions.add (extension);
}
#endif
@@ -78,7 +80,7 @@
debug (Loading extension: \%s\, path);
var loader = new ModuleLoader (path);
// FIXME: check if enabled
-extension = loader.create_instance ();
+extension = loader.create_instance (engine);
if (extension != null) extensions.add (extension);
}
else
=== modified file 'src/extension.vala'
--- src/extension.vala 2011-09-02 17:46:22 +
+++ src/extension.vala 2011-09-05 16:16:36 +
@@ -37,6 +37,8 @@
*/
public abstract class Extension : Object
{
+public unowned Engine engine { get; construct set; }
+
/**
* This method gets called before Zeitgeist stops.
*
@@ -132,12 +134,13 @@
{
public Type extension_type { get; protected set; }
-public virtual Extension? create_instance ()
+public virtual Extension? create_instance (Engine engine)
{
if (this.use ())
{
if (extension_type == Type.INVALID) return null;
-Extension? instance = Object.@new (extension_type) as Extension;
+Extension? instance = Object.@new (extension_type,
+engine, engine) as Extension;
debug (Loaded extension: %s, extension_type.name ());
this.unuse ();
return instance;
___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Branch ~zeitgeist/zeitgeist/bluebird] Rev 228: Add Histogram extension
revno: 228
committer: Michal Hruby michal@gmail.com
branch nick: bluebird
timestamp: Mon 2011-09-05 18:19:38 +0200
message:
Add Histogram extension
added:
extensions/histogram.vala
src/ext-histogram.vala@
modified:
src/Makefile.am
src/extension-collection.vala
--
lp:~zeitgeist/zeitgeist/bluebird
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird
Your team Zeitgeist Framework Team is subscribed to branch
lp:~zeitgeist/zeitgeist/bluebird.
To unsubscribe from this branch go to
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird/+edit-subscription
=== added file 'extensions/histogram.vala'
--- extensions/histogram.vala 1970-01-01 00:00:00 +
+++ extensions/histogram.vala 2011-09-05 16:19:38 +
@@ -0,0 +1,124 @@
+/* histogram.vala
+ *
+ * Copyright © 2011 Michal Hruby michal@gmail.com
+ *
+ * Based upon a Python implementation (2010-2011) by:
+ * Siegfried-Angel Gevatter Pujals siegfr...@gevatter.com
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Lesser General Public License as published by
+ * the Free Software Foundation, either version 2.1 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program. If not, see http://www.gnu.org/licenses/.
+ *
+ */
+
+namespace Zeitgeist
+{
+[DBus (name = org.gnome.zeitgeist.Histogram)]
+public interface RemoteHistogram: Object
+{
+[DBus (signature = a(xu))]
+public abstract Variant get_histogram_data () throws Error;
+}
+
+class Histogram: Extension, RemoteHistogram
+{
+
+private uint registration_id = 0;
+
+construct
+{
+// This will be called after bus is acquired, so it shouldn't block
+try
+{
+var connection = Bus.get_sync (BusType.SESSION, null);
+registration_id = connection.register_objectRemoteHistogram (
+/org/gnome/zeitgeist/journal/activity, this);
+}
+catch (Error err)
+{
+warning (%s, err.message);
+}
+}
+
+public override void unload ()
+{
+try
+{
+var connection = Bus.get_sync (BusType.SESSION, null);
+if (registration_id != 0)
+{
+connection.unregister_object (registration_id);
+registration_id = 0;
+}
+}
+catch (Error err)
+{
+warning (%s, err.message);
+}
+
+debug (%s, this.ref_count = %u, Log.METHOD, this.ref_count);
+}
+
+public Variant get_histogram_data () throws Error
+{
+var builder = new VariantBuilder (new VariantType (a(xu)));
+
+string sql =
+SELECT strftime('%s', datetime(timestamp/1000, 'unixepoch'),
+'start of day') AS daystamp,
+COUNT(*)
+FROM event
+GROUP BY daystamp
+ORDER BY daystamp DESC
+;
+
+Sqlite.Statement stmt;
+var database = engine.database;
+unowned Sqlite.Database db = database.database;
+
+int rc = db.prepare_v2 (sql, -1, out stmt);
+database.assert_query_success (rc, SQL error);
+
+while ((rc = stmt.step ()) == Sqlite.ROW)
+{
+int64 t = stmt.column_int64 (0);
+uint32 count = stmt.column_int (1);
+
+builder.add ((xu), t, count);
+}
+
+if (rc != Sqlite.DONE)
+{
+string error_message = Error in get_histogram_data: +
+%d, %s.printf (rc, db.errmsg ());
+warning (%s, error_message);
+throw new EngineError.DATABASE_ERROR (error_message);
+}
+
+return builder.end ();
+}
+
+}
+
+[ModuleInit]
+#if BUILTIN_EXTENSIONS
+public static Type histogram_init (TypeModule module)
+{
+#else
+public static Type extension_register (TypeModule module)
+{
+#endif
+return typeof (Histogram);
+}
+}
+
+// vim:expandtab:ts=4:sw=4
=== modified file 'src/Makefile.am'
--- src/Makefile.am 2011-09-05 10:27:02 +
+++ src/Makefile.am 2011-09-05 16:19:38 +
@@ -21,6 +21,7 @@
extensions_VALASOURCES = \
ext-data-source-registry.vala \
ext-blacklist.vala \
+ ext-histogram.vala \
$(NULL)
bluebird_VALASOURCES = \
@@ -59,7 +60,7 @@
[Zeitgeist] [Branch ~zeitgeist/zeitgeist/bluebird] Rev 229: GetEvents: make sure event_ids[] isn't empty
revno: 229
committer: Siegfried-Angel Gevatter Pujals siegfr...@gevatter.com
branch nick: bluebird
timestamp: Mon 2011-09-05 21:02:23 +0200
message:
GetEvents: make sure event_ids[] isn't empty
modified:
src/engine.vala
--
lp:~zeitgeist/zeitgeist/bluebird
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird
Your team Zeitgeist Framework Team is subscribed to branch
lp:~zeitgeist/zeitgeist/bluebird.
To unsubscribe from this branch go to
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird/+edit-subscription
=== modified file 'src/engine.vala'
--- src/engine.vala 2011-09-05 16:16:36 +
+++ src/engine.vala 2011-09-05 19:02:23 +
@@ -76,6 +76,8 @@
Sqlite.Statement stmt;
int rc;
+if (event_ids.length == 0)
+return new GenericArrayEvent? ();
var sql_event_ids = database.get_sql_string_from_event_ids (event_ids);
string sql =
SELECT * FROM event_view
@@ -699,6 +701,7 @@
}
public TimeRange? delete_events (uint32[] event_ids, BusName? sender)
+requires (event_ids.length 0)
{
event_ids = extension_collection.call_pre_delete_events (
event_ids, sender);
___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Branch ~zeitgeist/zeitgeist/bluebird] Rev 230: Fix more warnings
revno: 230
committer: Michal Hruby michal@gmail.com
branch nick: bluebird
timestamp: Mon 2011-09-05 21:18:19 +0200
message:
Fix more warnings
modified:
src/engine.vala
--
lp:~zeitgeist/zeitgeist/bluebird
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird
Your team Zeitgeist Framework Team is subscribed to branch
lp:~zeitgeist/zeitgeist/bluebird.
To unsubscribe from this branch go to
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird/+edit-subscription
=== modified file 'src/engine.vala'
--- src/engine.vala 2011-09-05 19:02:23 +
+++ src/engine.vala 2011-09-05 19:18:19 +
@@ -701,6 +701,7 @@
}
public TimeRange? delete_events (uint32[] event_ids, BusName? sender)
+throws EngineError
requires (event_ids.length 0)
{
event_ids = extension_collection.call_pre_delete_events (
@@ -1029,7 +1030,7 @@
}
protected WhereClause get_where_clause_for_symbol (string table_name,
-string symbol, TableLookup lookup_table)
+string symbol, TableLookup lookup_table) throws EngineError
{
string _symbol = symbol;
bool negated = parse_negation (ref _symbol);
___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Branch ~zeitgeist/zeitgeist/bluebird] Rev 231: Prettify make output
revno: 231 committer: Michal Hruby michal@gmail.com branch nick: bluebird timestamp: Mon 2011-09-05 21:18:53 +0200 message: Prettify make output modified: src/Makefile.am -- lp:~zeitgeist/zeitgeist/bluebird https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird Your team Zeitgeist Framework Team is subscribed to branch lp:~zeitgeist/zeitgeist/bluebird. To unsubscribe from this branch go to https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird/+edit-subscription === modified file 'src/Makefile.am' --- src/Makefile.am 2011-09-05 16:19:38 + +++ src/Makefile.am 2011-09-05 19:18:53 + @@ -58,17 +58,17 @@ zeitgeist-engine_vala.stamp: $(bluebird_VALASOURCES) $(VALA_V)$(VALAC) $(VALAFLAGS) -C -H zeitgeist-engine.h --library zeitgeist-engine $^ - touch $@ + @touch $@ extensions_vala.stamp: zeitgeist-engine_vala.stamp $(extensions_VALASOURCES) - $(foreach ext_src,$(filter %.vala,$^),\ + $(AM_V_GEN)$(foreach ext_src,$(filter %.vala,$^),\ $(VALAC) $(VALAFLAGS) $(EXT_FLAGS) -C zeitgeist-engine.vapi $(ext_src) || exit 1;) - touch $@ + @touch $@ # FIXME: can we make this depend on $(ontology_trig_DATA)? ontology_vala.stamp: ontology.vala.in ontology-uris.vala.in - $(top_srcdir)/extra/ontology2code --vala - touch $@ + $(AM_V_GEN)$(top_srcdir)/extra/ontology2code --vala + @touch $@ ontology.vala ontology-uris.vala: ontology_vala.stamp ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Branch ~zeitgeist/zeitgeist/bluebird] Rev 232: Flow-analyse this Vala\!
revno: 232
committer: Michal Hruby michal@gmail.com
branch nick: bluebird
timestamp: Mon 2011-09-05 21:22:17 +0200
message:
Flow-analyse this Vala\!
modified:
src/errors.vala
--
lp:~zeitgeist/zeitgeist/bluebird
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird
Your team Zeitgeist Framework Team is subscribed to branch
lp:~zeitgeist/zeitgeist/bluebird.
To unsubscribe from this branch go to
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird/+edit-subscription
=== modified file 'src/errors.vala'
--- src/errors.vala 2011-09-05 10:27:02 +
+++ src/errors.vala 2011-09-05 19:22:17 +
@@ -37,8 +37,15 @@
}
catch (Error err)
{
+i_know_its_unused ();
}
}
+
+// also screw your warnings vala
+private static void i_know_its_unused ()
+{
+vala_bug_workaround ();
+}
}
// vim:expandtab:ts=4:sw=4
___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 722762] Re: zeitgeist-daemon using ~100% of CPU
agreed. fixed it for me too -- You received this bug notification because you are a member of Zeitgeist Extensions, which is the registrant for Zeitgeist Extensions. https://bugs.launchpad.net/bugs/722762 Title: zeitgeist-daemon using ~100% of CPU Status in Zeitgeist Framework: Invalid Status in Zeitgeist Extensions: Fix Released Status in “zeitgeist” package in Ubuntu: Invalid Status in “zeitgeist-extensions” package in Ubuntu: Fix Released Bug description: I've tried restarting my computer, closing all applications, etc., but no matter what System Monitor tells me zeitgeist-daemon is using 96-100% of the CPU on my i5 Sony Vaio laptop. To manage notifications about this bug go to: https://bugs.launchpad.net/zeitgeist/+bug/722762/+subscriptions ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Branch ~zeitgeist/zeitgeist/bluebird] Rev 233: Remove debug on event insertion
revno: 233
committer: Michal Hruby michal@gmail.com
branch nick: bluebird
timestamp: Mon 2011-09-05 21:43:04 +0200
message:
Remove debug on event insertion
modified:
src/engine.vala
--
lp:~zeitgeist/zeitgeist/bluebird
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird
Your team Zeitgeist Framework Team is subscribed to branch
lp:~zeitgeist/zeitgeist/bluebird.
To unsubscribe from this branch go to
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird/+edit-subscription
=== modified file 'src/engine.vala'
--- src/engine.vala 2011-09-05 19:18:19 +
+++ src/engine.vala 2011-09-05 19:43:04 +
@@ -688,10 +688,6 @@
}
}
-stdout.printf ( Inserted event: \n);
-event.debug_print ();
-stdout.printf (\n);
-
if (event.interpretation == ZG.MOVE_EVENT)
{
handle_move_event (event);
___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Branch ~zeitgeist/zeitgeist/bluebird] Rev 234: added name_changed logic
revno: 234
committer: Seif Lotfy s...@lotfy.com
branch nick: bluebird
timestamp: Tue 2011-09-06 00:00:16 +0200
message:
added name_changed logic
modified:
extensions/ds-registry.vala
--
lp:~zeitgeist/zeitgeist/bluebird
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird
Your team Zeitgeist Framework Team is subscribed to branch
lp:~zeitgeist/zeitgeist/bluebird.
To unsubscribe from this branch go to
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird/+edit-subscription
=== modified file 'extensions/ds-registry.vala'
--- extensions/ds-registry.vala 2011-09-05 12:19:04 +
+++ extensions/ds-registry.vala 2011-09-05 22:00:16 +
@@ -140,6 +140,50 @@
var connection = Bus.get_sync (BusType.SESSION, null);
registration_id = connection.register_objectRemoteRegistry (
/org/gnome/zeitgeist/data_source_registry, this);
+
+connection.signal_subscribe (org.freedesktop.DBus,
+org.freedesktop.DBus, NameOwnerChanged,
+/org/freedesktop/DBus, null, 0,
+(conn, sender, path, ifc_name, sig_name, parameters) =
+{
+// name, old_owner, new_owner
+var name = parameters.get_child_value (0).dup_string ();
+var old_owner = parameters.get_child_value (1).dup_string ();
+var new_owner = parameters.get_child_value (2).dup_string ();
+
+var uids = new GenericArraystring();
+foreach (var uid in running.get_keys())
+{
+var temp_uids = running.lookup(uid);
+for (int i = 0; i temp_uids.length; i++)
+{
+var temp_name = temp_uids[i];
+if (temp_name == name)
+{
+uids.add(uid);
+}
+}
+}
+if (uids.length == 0)
+return;
+var uid = uids[0];
+var data_source = sources.lookup(uid);
+data_source.timestamp = Timestamp.now();
+var strid = uid +(+ data_source.name +);
+debug(Client disconnected: %s, strid);
+
+if (running.lookup(uid).length == 1)
+{
+debug(No remaining client running: %s, strid);
+running.remove(uid);
+data_source.running = false;
+data_source_disconnected (data_source.to_variant());
+}
+else
+{
+running.lookup(uid).remove((BusName)name);
+}
+});
}
catch (Error err)
{
@@ -223,9 +267,10 @@
ds.name = name;
ds.description = description;
ds.event_templates = templates;
-// FIXME: update the timestamp?
ds.timestamp = Timestamp.now ();
ds.running = true;
+// FIXME: Wrtie to disk here
+data_source_registered (ds.to_variant ());
return ds.enabled;
}
else
@@ -237,10 +282,11 @@
new_ds.running = true;
new_ds.timestamp = Timestamp.now ();
sources.insert (unique_id, new_ds);
+// FIXME: Wrtie to disk here
data_source_registered (new_ds.to_variant ());
-
return new_ds.enabled;
}
+
}
public void set_data_source_enabled (string unique_id, bool enabled)
___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help : https://help.launchpad.net/ListHelp
