[Zeitgeist] [Bug 485433] Re: Dont' raise an exception when a duplicate event is detected

2009-11-24 Thread Mikkel Kamstrup Erlandsen
Fixed in revision #1157 ** Changed in: zeitgeist Status: Triaged => Fix Released -- Dont' raise an exception when a duplicate event is detected https://bugs.launchpad.net/bugs/485433 You received this bug notification because you are a member of Zeitgeist-Engine, which is the registrant f

[Zeitgeist] [Bug 485433] Re: Dont' raise an exception when a duplicate event is detected

2009-11-23 Thread Mikkel Kamstrup Erlandsen
I'll do this tonight, and update the unit tests accordingly ** Changed in: zeitgeist Assignee: Seif Lotfy (seif) => Mikkel Kamstrup Erlandsen (kamstrup) -- Dont' raise an exception when a duplicate event is detected https://bugs.launchpad.net/bugs/485433 You received this bug notification b

[Zeitgeist] [Bug 485433] Re: Dont' raise an exception when a duplicate event is detected

2009-11-23 Thread Seif Lotfy
OK so what is the status on this bug! Shal lwe just return the id of the event that is already inserted? ** Changed in: zeitgeist Importance: Critical => Medium ** Changed in: zeitgeist Importance: Medium => Critical ** Changed in: zeitgeist Status: New => Triaged ** Changed in: ze

Re: [Zeitgeist] [Bug 485433] Re: Dont' raise an exception when a duplicate event is detected

2009-11-20 Thread Siegfried Gevatter
2009/11/20 Seif Lotfy : > if u insert 50 events and all are the same do we want to get a list of 50 > identical ids or just a list with one id in it? 50. The IDs need to be returned in the same position in the lists as the corresponding event was in the list you passed to InsertEvents when calling

Re: [Zeitgeist] [Bug 485433] Re: Dont' raise an exception when a duplicate event is detected

2009-11-19 Thread Seif Lotfy
uhm not really if u insert 50 events and all are the same do we want to get a list of 50 identical ids or just a list with one id in it? This is a tough decision but i think the direction is pretty right. we shall not skip other inserts just because one failed. 2009/11/19 Mikkel Kamstrup Erlandsen

[Zeitgeist] [Bug 485433] Re: Dont' raise an exception when a duplicate event is detected

2009-11-19 Thread Mikkel Kamstrup Erlandsen
For duplicate events this I think that Markus' proposal is OK. But do we have any other error scenarios when inserting events? What is the solution in this case then? -- Dont' raise an exception when a duplicate event is detected https://bugs.launchpad.net/bugs/485433 You received this bug notif

[Zeitgeist] [Bug 485433] Re: Dont' raise an exception when a duplicate event is detected

2009-11-19 Thread Markus Korn
after thinking about it I think we should drop raising the KeyError. Instead this we should return the id of the already existing event in the DB. This way inserting 50 Events will always return a list of 50 ids. -- Dont' raise an exception when a duplicate event is detected https://bugs.launchp